Re: [PATCH] Re: WAN: new PPP code for generic HDLC

Krzysztof Halasa
2008-03-12T19:25:13Z

Stephen Hemminger <shemminger@vyatta.com> writes:

>> +struct hdlc_header {
>> + u8 address;
>> + u8 control;
>> + __be16 protocol;
>> +} __attribute__ ((packed));
>> +
>> +struct cp_header {
>> + u8 code;
>> + u8 id;
>> + __be16 len;
>> +} __attribute__ ((packed));
>> +
>
> If I remember correctly, the packed is unnecessary for structures like this
> and causes GCC to generate worse code.

Interesting. Gcc obviously will do the right thing without "packed",
at least on "current" architectures, but I don't know what the C
standard says. I will remove it, thanks.
--
Krzysztof Halasa