public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Halasa <khc@pm.waw.pl>
To: Joe Perches <joe@perches.com>
Cc: netdev@vger.kernel.org, "Jan \"Yenya\" Kasprzak" <kas@fi.muni.cz>,
	Kevin Curtis <kevin.curtis@farsite.co.uk>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/8] wan: Remove unnecessary alloc/OOM messages
Date: Sun, 10 Feb 2013 21:30:27 +0100	[thread overview]
Message-ID: <m3zjzb9ajg.fsf@intrepid.localdomain> (raw)
In-Reply-To: <392e9b2c652a41f6c5791268dde1eb8c71d0be90.1359939013.git.joe@perches.com> (Joe Perches's message of "Sun, 3 Feb 2013 19:28:12 -0800")

Joe Perches <joe@perches.com> writes:

> alloc failures already get standardized OOM
> messages and a dump_stack.
>
> Hoist assigns from if tests.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  drivers/net/wan/cosa.c    | 9 ++++-----
>  drivers/net/wan/farsync.c | 6 ++----
>  drivers/net/wan/hdlc.c    | 9 ++++-----
>  drivers/net/wan/x25_asy.c | 1 -
>  4 files changed, 10 insertions(+), 15 deletions(-)

Good to see.

Acked-by: Krzysztof Halasa <khc@pm.waw.pl>
-- 
Krzysztof Halasa

  reply	other threads:[~2013-02-10 20:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-04  3:28 [PATCH 0/8] drivers/net: Remove unnecessary alloc/OOM messages Joe Perches
2013-02-04  3:28 ` [PATCH 1/8] caif: " Joe Perches
2013-02-04  3:28 ` [PATCH 2/8] can: " Joe Perches
2013-02-04  9:02   ` Marc Kleine-Budde
2013-02-04  3:28 ` [PATCH 4/8] drivers: net: usb: " Joe Perches
2013-02-04  3:28 ` [PATCH 5/8] wan: " Joe Perches
2013-02-10 20:30   ` Krzysztof Halasa [this message]
2013-02-04  3:28 ` [PATCH 6/8] wimax: Remove unnecessary alloc/OOM messages, alloc cleanups Joe Perches
2013-02-04  3:28 ` [PATCH 7/8] wireless: " Joe Perches
2013-02-04  3:28 ` [PATCH 8/8] drivers:net:misc: Remove unnecessary alloc/OOM messages Joe Perches
2013-02-07  4:08   ` Rusty Russell
2013-02-04  3:43 ` [PATCH 3/8] ethernet: Remove unnecessary alloc/OOM messages, alloc cleanups Joe Perches
2013-02-04 18:23 ` [PATCH 0/8] drivers/net: Remove unnecessary alloc/OOM messages David Miller
2013-02-05  2:48   ` [PATCH] net: core: " Joe Perches
2013-02-06 20:02     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3zjzb9ajg.fsf@intrepid.localdomain \
    --to=khc@pm.waw.pl \
    --cc=joe@perches.com \
    --cc=kas@fi.muni.cz \
    --cc=kevin.curtis@farsite.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox