From: Krzysztof Halasa <khc@pm.waw.pl>
To: Jeff Garzik <jeff@garzik.org>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] Driver for IXP4xx built-in Ethernet ports
Date: Sat, 03 May 2008 00:09:12 +0200 [thread overview]
Message-ID: <m3zlr8qrxz.fsf@maximus.localdomain> (raw)
In-Reply-To: <4816B99F.7040102@garzik.org> (Jeff Garzik's message of "Tue\, 29 Apr 2008 02\:01\:03 -0400")
Jeff Garzik <jeff@garzik.org> writes:
> the ifdefs are really ugly and want cleaning, but the rest seems
> sane. applied
Thanks.
They (#ifdef __ARMEB__) are indeed very ugly but I don't know how to
clean them, except by splitting the driver into two (which is worse).
The most used things are #defined and then used without those
__ARMEB__ checks.
Duplicating those functions is effectively splitting into two :-(
Well, perhaps Intel could give us firmware which could convert LE-BE
on the fly while TX/RX, that would make the LE code go away.
Binary-only :-(
OTOH I could convert #if* DEBUG_*, I will look at it.
--
Krzysztof Halasa
prev parent reply other threads:[~2008-05-02 22:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-20 17:06 [PATCH] Driver for IXP4xx built-in Ethernet ports Krzysztof Halasa
2008-04-26 9:29 ` Martin Michlmayr
2008-04-26 10:16 ` Mikael Pettersson
2008-04-28 9:16 ` Krzysztof Halasa
2008-04-29 6:01 ` Jeff Garzik
2008-05-02 22:09 ` Krzysztof Halasa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3zlr8qrxz.fsf@maximus.localdomain \
--to=khc@pm.waw.pl \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).