Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR

Krzysztof Halasa
2007-05-08T13:57:38Z

Michael-Luke Jones <mlj28@cam.ac.uk> writes:

> Already in mach-ixp4xx, so can just be called qmgr.c

Same here.

>> +#define QUEUE_IRQ_SRC_NEARLY_FULL 2
>> +#define QUEUE_IRQ_SRC_FULL 3
>> +#define QUEUE_IRQ_SRC_NOT_EMPTY 4
>> +#define QUEUE_IRQ_SRC_NOT_NEARLY_EMPTY 5
>> +#define QUEUE_IRQ_SRC_NOT_NEARLY_FULL 6
>> +#define QUEUE_IRQ_SRC_NOT_FULL 7
>
> Here, unlike ixp4xx_npe.c defines are in qmgr.h - that seems a bit
> more natural.

Because they are public interface :-)
--
Krzysztof Halasa