Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

Roman Zippel
2007-05-07T01:44:37Z

Hi,

On Mon, 7 May 2007, Krzysztof Halasa wrote:

> Allow enabling WAN drivers without selecting generic HDLC first,
> HDLC will be selected automatically.
>
> Signed-off-by: Krzysztof Halasa <khc@pm.waw.pl>
>
> diff --git a/drivers/net/wan/Kconfig b/drivers/net/wan/Kconfig
> index 8897f53..3a2fe82 100644
> --- a/drivers/net/wan/Kconfig
> +++ b/drivers/net/wan/Kconfig
> @@ -171,7 +171,8 @@ comment "X.25/LAPB support is disabled"
>
> config PCI200SYN
> tristate "Goramo PCI200SYN support"
> - depends on HDLC && PCI
> + depends on PCI
> + select HDLC
> help
> Driver for PCI200SYN cards by Goramo sp. j.
>

What's the advantage? The HDLC option is directly before this?

bye, Roman