Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

Lennert Buytenhek
2007-05-15T21:20:58Z

On Wed, May 09, 2007 at 03:45:53PM +0100, Michael-Luke Jones wrote:

> No-one is saying that this driver should not be mainlined before it
> has LE support. All that I said was:
>
> > Personally I'd like LE ethernet tested and working before we push.
>
> The alternative would be to explicitly state in Kconfig that LE arm
> is broken with this driver, so that this could be fixed later.

The driver does bomb out during compile if __ARMEB__ isn't defined,
but that apparently wasn't good enough.

> Please can we not blow this out of proportion, it really isn't that
> big a deal. The irony is that fixing Krzysztof's driver to work on LE
> will probably be quite easy, given that we already have a working LE
> driver from Christian.

I'm looking forward to your patch.