From: Krzysztof Halasa <khc@pm.waw.pl>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: netdev@vger.kernel.org,
"bugme-daemon@kernel-bugs.osdl.org"
<bugme-daemon@bugzilla.kernel.org>,
loveminix@yahoo.com.cn
Subject: Re: [Bugme-new] [Bug 8107] New: dev->header_cache_update has a random value
Date: Fri, 02 Mar 2007 16:29:06 +0100 [thread overview]
Message-ID: <m3zm6vk6kd.fsf@maximus.localdomain> (raw)
In-Reply-To: <20070301143417.00b49e81.akpm@linux-foundation.org> (Andrew Morton's message of "Thu, 1 Mar 2007 14:34:17 -0800")
Andrew Morton <akpm@linux-foundation.org> writes:
>> However, in
>> drivers/net/wan/hdlc_cisco.c, in function static int cisco_ioctl(struct
>> net_device *dev, struct ifreq *ifr), where dev->hard_header is assigned a valid
>> function, and dev->hard_header_cache is assigned a known value (NULL), dev-
>> >header_cache_update is not set to a known value:
Right, it seems I was never aware of dev->header_cache_update existence.
I wonder where does the non-NULL value come from? Nevermind.
> diff -puN drivers/net/wan/hdlc_cisco.c~cisco_ioctl-initialise-header_cache_update drivers/net/wan/hdlc_cisco.c
> --- a/drivers/net/wan/hdlc_cisco.c~cisco_ioctl-initialise-header_cache_update
> +++ a/drivers/net/wan/hdlc_cisco.c
> @@ -366,6 +366,7 @@ static int cisco_ioctl(struct net_device
> dev->hard_start_xmit = hdlc->xmit;
> dev->hard_header = cisco_hard_header;
> dev->hard_header_cache = NULL;
> + dev->header_cache_update = NULL;
> dev->type = ARPHRD_CISCO;
> dev->flags = IFF_POINTOPOINT | IFF_NOARP;
> dev->addr_len = 0;
> _
ACK, I think it's the best place.
Is it OK to leave this (and hard_header_cache) set to random value
if dev->hard_header = NULL (as with other protocols)?
--
Krzysztof Halasa
next prev parent reply other threads:[~2007-03-02 15:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200703011933.l21JX5hw018666@fire-2.osdl.org>
2007-03-01 22:34 ` [Bugme-new] [Bug 8107] New: dev->header_cache_update has a random value Andrew Morton
2007-03-01 22:37 ` Stephen Hemminger
2007-03-01 22:54 ` Andrew Morton
2007-03-01 23:30 ` Stephen Hemminger
2007-03-02 1:38 ` David Miller
2007-03-02 1:33 ` David Miller
2007-03-02 15:29 ` Krzysztof Halasa [this message]
2007-03-02 19:23 ` David Miller
2007-03-02 23:38 ` Krzysztof Halasa
2007-03-02 23:43 ` David Miller
2007-03-02 23:38 ` Krzysztof Halasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3zm6vk6kd.fsf@maximus.localdomain \
--to=khc@pm.waw.pl \
--cc=akpm@linux-foundation.org \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=loveminix@yahoo.com.cn \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox