Netdev List
 help / color / mirror / Atom feed
From: "Hans Schillstrom" <hans@schillstrom.com>
To: "Patrick McHardy" <kaber@trash.net>
Cc: "Jesper Dangaard Brouer" <brouer@redhat.com>,
	netdev@vger.kernel.org, lvs-devel@vger.kernel.org,
	"Julian Anastasov" <ja@ssi.bg>,
	"Simon Horman" <horms@verge.net.au>,
	"Wensong Zhang" <wensong@linux-vs.org>,
	netfilter-devel@vger.kernel.org
Subject: Re[2]:  [PATCH 2/3] ipvs: Fix faulty IPv6 extension header handling in IPVS
Date: Mon, 27 Aug 2012 12:55:14 +0200 (CEST)	[thread overview]
Message-ID: <mdaatbj.ca5ac4e44d852a03ede087a5ed658cd9@obelix.schillstrom.com> (raw)

>
>On Mon, 20 Aug 2012, Jesper Dangaard Brouer wrote:
>
>> Based on patch from: Hans Schillstrom
>>
>> IPv6 headers must be processed in order of appearance,
>> neither can it be assumed that Upper layer headers is first.
>> If anything else than L4 is the first header IPVS will throw it.
>>
>> IPVS will write SNAT & DNAT modifications at a fixed pos which
>> will corrupt the message. Proper header position must be found
>> before writing modifying packet.
>>
>> This patch contains a lot of API changes.  This is done, to avoid
>> the costly scan of finding the IPv6 headers, via ipv6_find_hdr().
>> Finding the IPv6 headers is done as early as possible, and passed
>> on as a pointer "struct ip_vs_iphdr *" to the affected functions.
>
>How about we change netfilter to set up the skb's transport header
>at an early time so we can avoid all (most of) these header scans
>in netfilter?

I think that would be great, maybe it should be global i.e. not only a netfilter issue.


             reply	other threads:[~2012-08-27 10:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-27 10:55 Hans Schillstrom [this message]
2012-08-27 11:13 ` Re[2]: [PATCH 2/3] ipvs: Fix faulty IPv6 extension header handling in IPVS Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mdaatbj.ca5ac4e44d852a03ede087a5ed658cd9@obelix.schillstrom.com \
    --to=hans@schillstrom.com \
    --cc=brouer@redhat.com \
    --cc=horms@verge.net.au \
    --cc=ja@ssi.bg \
    --cc=kaber@trash.net \
    --cc=lvs-devel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=wensong@linux-vs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox