From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.secunet.com (mx1.secunet.com [62.96.220.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3853C23EAA6; Fri, 3 Jul 2026 17:08:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.96.220.36 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783098507; cv=none; b=ZaQnaCqLoVsZ5EvO727dPy8BjY3ESMNyKleavXDWXYQepFwVvtpq1HLJfFutn8GhIz7xIkXvpXONPDTb+tbSvhmfoB2gpsDEEwL9G/rqiM0OOZmU84nAiB5wzAz3hbVgG9HTK2qxG62wy9eSfdTZ0LjlFs0tASE+L2TQ++o0eqE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783098507; c=relaxed/simple; bh=uxIgbALiuv9RBtkDJIG+/wl3tB7G/wDRE/vwxIMy1jw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=k11RJTkTXouEGlHs/UfLJIV6Z7+qGU7k89GivUtbFe7TMJfO+4P+4xIuGVg2fvYj/KgmZAz73f6RiOlYfC97xrTdueIugJp+jHizLXh1hzAxiUemI6mLiffEFj1ihlhgdyd/inOEF/0jr8lz+MQcoSaZ/3n2xkYdh89Kdmv5abk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=secunet.com; spf=pass smtp.mailfrom=secunet.com; dkim=pass (2048-bit key) header.d=secunet.com header.i=@secunet.com header.b=TboOw8Aw; arc=none smtp.client-ip=62.96.220.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=secunet.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=secunet.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=secunet.com header.i=@secunet.com header.b="TboOw8Aw" Received: from localhost (localhost [127.0.0.1]) by mx1.secunet.com (Postfix) with ESMTP id 88F1A20758; Fri, 3 Jul 2026 19:08:24 +0200 (CEST) X-Virus-Scanned: by secunet Received: from mx1.secunet.com ([127.0.0.1]) by localhost (mx1.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8nROMnj_rz1E; Fri, 3 Jul 2026 19:08:24 +0200 (CEST) Received: from EXCH-02.secunet.de (rl2.secunet.de [10.32.0.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.secunet.com (Postfix) with ESMTPS id F363920612; Fri, 3 Jul 2026 19:08:23 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.secunet.com F363920612 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secunet.com; s=202301; t=1783098504; bh=8N5ufcHgVDorj+sCLDh+wScaVYTDyVso9JPfatWfn+Q=; h=From:To:CC:Subject:Date:In-Reply-To:References:From; b=TboOw8AwoZK0SOum0dlv/Gu2UnJmReAX+YeXYPl3xv+z67yYfjOUsyXEeDXdhz4Ke 9iAifg671dfGt86nud0bep5VPHcth6RjLXwV3bpnKfYYMM0JAfxGEUXyTRCnpAxC7M Ee+JmpJ1aoGvIiaI7pfiKbU2uGoxwTIGhA9UOIF9emftJnfeVibaTPzXECsuKwOW3H g2SU+qjpxjn2tfsM72teyT5OEelO2DZOYhORUGr6Dr7GyellbdQbZcsPF65BM74cjN 194bHDMT/0XFJGE7zZKKur+jaVo3hOMPaot9/oC9cCYiR9YVIxBG2zbgwa5PDfYAim QVX31VIkRmEXg== Received: from moon.secunet.de (172.18.149.1) by EXCH-02.secunet.de (10.32.0.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 3 Jul 2026 19:08:23 +0200 From: Antony Antony To: Antony Antony , Steffen Klassert , Herbert Xu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , David Ahern , Jamal Hadi Salim , Shuah Khan CC: Sabrina Dubroca , , Yan Yan , Tobias Brunner , Florian Westphal , , , Sashiko Subject: [PATCH ipsec 4/8] xfrm: fix use-after-free of migrated state in xfrm_do_migrate_state() Date: Fri, 3 Jul 2026 19:08:07 +0200 Message-ID: X-Mailer: git-send-email 2.39.5 In-Reply-To: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.16-dev Content-Transfer-Encoding: 8bit X-ClientProxiedBy: EXCH-01.secunet.de (10.32.0.171) To EXCH-02.secunet.de (10.32.0.172) A concurrent delete can free the migrated state before xfrm_do_migrate_state() finishes using it. Fixes: a9d155ea9b44 ("xfrm: add XFRM_MSG_MIGRATE_STATE for single SA migration") Reported-by: Sashiko Signed-off-by: Antony Antony --- net/xfrm/xfrm_user.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c index 11ec3b14a42f..29cbdc836cfc 100644 --- a/net/xfrm/xfrm_user.c +++ b/net/xfrm/xfrm_user.c @@ -3468,6 +3468,7 @@ static int xfrm_do_migrate_state(struct sk_buff *skb, struct nlmsghdr *nlh, __xfrm_state_delete(x); spin_unlock_bh(&x->lock); + xfrm_state_hold(xc); err = xfrm_state_migrate_install(x, xc, &m, extack); if (err < 0) { /* @@ -3475,6 +3476,7 @@ static int xfrm_do_migrate_state(struct sk_buff *skb, struct nlmsghdr *nlh, * free under xfrm_cfg_mutex. Both SAs are gone if it does; * restoring x would risk SN/IV reuse. */ + xfrm_state_put(xc); goto out; } @@ -3493,6 +3495,7 @@ static int xfrm_do_migrate_state(struct sk_buff *skb, struct nlmsghdr *nlh, err = 0; } + xfrm_state_put(xc); out: xfrm_state_put(x); return err; -- 2.47.3