From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.secunet.com (mx1.secunet.com [62.96.220.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E9E8233939; Fri, 3 Jul 2026 17:08:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.96.220.36 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783098517; cv=none; b=VI0pF7ucS373I3vcke1mqaX19tmOGcWmM8lrl1hVYOOF0Pd1fkGipNhTiBO4e7NRVFuJtvKCHVS64K/QRnV9svCl3C6m5A88P0q5KxLqUDjuqLuMCVUo7QbdfyCEcn0KKP6JdxSDCaAyt2gvV+zv5JbFcayMEO5FMyi/Wbe/aSo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783098517; c=relaxed/simple; bh=kOTVN0YUZSWbyJOT54upD70yX2yEyjP63PqwcKL0Rks=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=duEpfEzJODozUuT6dkrXlnlsxSJ4iBQeciK/7dfYOkgKv3hkLzcaNUz0gVGA90mbp5XgnsgyFTvNIKUz+Gi92qtXlL8OrpPAeh+EfUqgaE4NLPuDR2B8k9G4Bv2vq1Ide6wXRTvH/1w/CInUEZp44VPPMZfGh6oA0rch2uNFVmw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=secunet.com; spf=pass smtp.mailfrom=secunet.com; dkim=pass (2048-bit key) header.d=secunet.com header.i=@secunet.com header.b=w/yvFOKd; arc=none smtp.client-ip=62.96.220.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=secunet.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=secunet.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=secunet.com header.i=@secunet.com header.b="w/yvFOKd" Received: from localhost (localhost [127.0.0.1]) by mx1.secunet.com (Postfix) with ESMTP id 07E1D20758; Fri, 3 Jul 2026 19:08:35 +0200 (CEST) X-Virus-Scanned: by secunet Received: from mx1.secunet.com ([127.0.0.1]) by localhost (mx1.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fJgGPq0NXi01; Fri, 3 Jul 2026 19:08:34 +0200 (CEST) Received: from EXCH-02.secunet.de (rl2.secunet.de [10.32.0.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.secunet.com (Postfix) with ESMTPS id 7E0B120612; Fri, 3 Jul 2026 19:08:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.secunet.com 7E0B120612 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secunet.com; s=202301; t=1783098514; bh=ysNqnKDzY+RnFfgApwbfvS1ufyyGXstfm6FplbjVISk=; h=From:To:CC:Subject:Date:In-Reply-To:References:From; b=w/yvFOKduv0BezRlefzd0T1aEAInnSkoXobDVYSLfKxwVZ6VV5oXPNvCfkD6fjWBV HZhWU98x65T4sgnrUh4xc2uW5hs/YfyijxeAmgY1ep0nfIFWLuVW238SLTNY4znsAE b8I6D3Tn3D1EmzQXCP4Ek6IZGwP+0JcAdMf0NmVmiv1LjUzmDBXjqGHNZiIFWnjH0H znYcrvgvMWjLPWyiF3j7moySpe8xuzwpDUUQkz5QURevLVDVE6tVCWLFqWdJ885u8S Kklx4s4lMoeIe3rfdWasCOq3d7V/7G394hiSpw0REw6k06u5HkSHNBJFqVI4tnNQ/8 azUsYW6tIdDsw== Received: from moon.secunet.de (172.18.149.1) by EXCH-02.secunet.de (10.32.0.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 3 Jul 2026 19:08:33 +0200 From: Antony Antony To: Antony Antony , Steffen Klassert , Herbert Xu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , David Ahern , Jamal Hadi Salim , Shuah Khan CC: Sabrina Dubroca , , Yan Yan , Tobias Brunner , Florian Westphal , , , Sashiko Subject: [PATCH ipsec 5/8] xfrm: fix hw offload state leak on xfrm_do_migrate_state() error path Date: Fri, 3 Jul 2026 19:08:23 +0200 Message-ID: X-Mailer: git-send-email 2.39.5 In-Reply-To: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.16-dev Content-Transfer-Encoding: 8bit X-ClientProxiedBy: EXCH-02.secunet.de (10.32.0.172) To EXCH-02.secunet.de (10.32.0.172) In the error path, the cloned state is dropped without removing its hardware offload, leaking the offloaded SA entry. Fixes: a9d155ea9b44 ("xfrm: add XFRM_MSG_MIGRATE_STATE for single SA migration") Reported-by: Sashiko Signed-off-by: Antony Antony --- net/xfrm/xfrm_user.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c index 29cbdc836cfc..87ef198993db 100644 --- a/net/xfrm/xfrm_user.c +++ b/net/xfrm/xfrm_user.c @@ -3500,6 +3500,8 @@ static int xfrm_do_migrate_state(struct sk_buff *skb, struct nlmsghdr *nlh, xfrm_state_put(x); return err; out_xc: + if (m.xuo) + xfrm_dev_state_delete(xc); xc->km.state = XFRM_STATE_DEAD; xfrm_state_put(xc); xfrm_state_put(x); -- 2.47.3