From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.secunet.com (mx1.secunet.com [62.96.220.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD73D3BED46; Wed, 7 Oct 2026 09:35:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.96.220.36 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791365715; cv=none; b=N6LjQLEWp667MR+fbfLi6eVuOOYfpDvssfTZb8U+OsLsN/OtPbLIHO4f/rxPHUnNQSHS4yrKh0B+XhyFMVv3VbZH4Xyyaz/7NaSzygXToPEG/g/OTfqTDTONeTYMrEa78nIht0VsHid6q8gQBpg9k7jADEQcRvWyrnh5NFdmKjQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791365715; c=relaxed/simple; bh=x33GYcxgD4o9EsetcPnw3Fs+SZymPq6pfIO67pnt/WM=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bjtA8h2/Bp2Ph4xq3aUT0kwJQpZexDp7ZMpMhbnirgFNX4wtqdTBrIG8dCZy2iXpRPO9D2Un48EmIM+7g5MVJsfW86oAGMoFDQn7vShv8NEgooapb7I7zRJ1nWrjePS6qK0XcuZ6aZ5x9HKJ3eB0h5ZX5MmeOH7f2JVtSz/QqhE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=secunet.com; spf=pass smtp.mailfrom=secunet.com; dkim=pass (2048-bit key) header.d=secunet.com header.i=@secunet.com header.b=eIIFdKEM; arc=none smtp.client-ip=62.96.220.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=secunet.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=secunet.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=secunet.com header.i=@secunet.com header.b="eIIFdKEM" Received: from localhost (localhost [127.0.0.1]) by mx1.secunet.com (Postfix) with ESMTP id AB07E207E3; Wed, 7 Oct 2026 11:35:00 +0200 (CEST) X-Virus-Scanned: by secunet Received: from mx1.secunet.com ([127.0.0.1]) by localhost (mx1.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bTEAd_uf5Alu; Wed, 7 Oct 2026 11:35:00 +0200 (CEST) Received: from EXCH-02.secunet.de (rl2.secunet.de [10.32.0.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.secunet.com (Postfix) with ESMTPS id 2499C207D1; Wed, 7 Oct 2026 11:35:00 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.secunet.com 2499C207D1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secunet.com; s=202301; t=1791365700; bh=3Ihi1xxngT4BprpFxHTgTxKDTub8tuB/XUvhORPDom0=; h=From:To:CC:Subject:Date:In-Reply-To:References:From; b=eIIFdKEMWZ2Gbz0O7/7msgWa4xME4Q5AsZGlnNy8oxz5RJlmDgE1vM7tKnA6kiKkx utfwbm2eRRCyE2Y3SaH2Fz7i/r9PbEecClorLcFp75/UofwFWieUnQNyR95/Y/dp6/ 27vHuby1/vwO+KzLpMDwaZeOK48rxWzWC25TkNOQIgqRel3ZXlrL9Eae96FK609RsS xcUBW6RyV2I8LyGHep4TznMhj5KlKT99JXu3HoZELCB50JZ9XKewGYvmwwyyS9pP6j tCo0VMqQ6AMoD6OuytQH1JeuFvP23CH173Ur8uflNROLq2mKdrNuBQJoZEKqbogdDo Q/E54nVdKfJDw== Received: from moon.secunet.de (172.18.149.1) by EXCH-02.secunet.de (10.32.0.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.49; Wed, 7 Oct 2026 11:34:58 +0200 From: Antony Antony To: Antony Antony , Steffen Klassert , Herbert Xu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , David Ahern , Jamal Hadi Salim , Shuah Khan CC: Sabrina Dubroca , , Yan Yan , Tobias Brunner , Florian Westphal , , Subject: [PATCH ipsec v5 2/9] xfrm: state: reject mark with bits outside its mask on ALLOCSPI Date: Wed, 7 Oct 2026 11:34:50 +0200 Message-ID: X-Mailer: git-send-email 2.39.5 In-Reply-To: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.16-dev Content-Transfer-Encoding: 8bit X-ClientProxiedBy: EXCH-02.secunet.de (10.32.0.172) To EXCH-02.secunet.de (10.32.0.172) Like state add and policy add in this series, ALLOCSPI rejects a mark whose value has bits outside its mask. Fixes: bd55775c8dd6 ("xfrm: SA lookups signature with mark") Cc: # avoid breaking existing userspace ABI Signed-off-by: Antony Antony --- v3->v4: added this patch --- net/xfrm/xfrm_user.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c index 0723d791b8b7..6b53373168b0 100644 --- a/net/xfrm/xfrm_user.c +++ b/net/xfrm/xfrm_user.c @@ -1916,6 +1916,9 @@ static int xfrm_alloc_userspi(struct sk_buff *skb, struct nlmsghdr *nlh, x = NULL; + err = verify_mark(attrs, extack); + if (err) + goto out_noput; mark = xfrm_mark_get(attrs, &m); if (attrs[XFRMA_IF_ID]) -- 2.47.3