From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.secunet.com (mx1.secunet.com [62.96.220.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A01435CB81; Mon, 9 Mar 2026 18:45:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.96.220.36 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773081936; cv=none; b=r5m4vQ+cAYQG3K5AFmv8a2Xxf1sKRxJVUegq+V3Z4Q18gTYwMrbbggRqwQ7SGGxPL/vzsbeVIydaTy0K8AlytBo4r5dk0X6q/2o8IFMVoZiefIkNUJfLFiyKRVLefPtVa6m+gw8yLu5RroYLXNJzothBPKutdabbx7gB/91zU6c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773081936; c=relaxed/simple; bh=1R2eFwKioD8y4i/zTkeQHOgB1Z8R5YVlxcc8AIFhMBE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NHHgo8uILEKHYOyNVNLEJk9bb4lYk6LpVaXeFeoTyNi8dHI7REfoCH9BZa62lQQicdayqytRsOvP2Romap2ypbg7OyR5NVDu+uadTUSLis+lqUXDLi3xeHTKKnoOoLSbggW8tOZM+0hB0gqK86I3lLZFZJ2oGlkOjWC518pndFw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=secunet.com; spf=pass smtp.mailfrom=secunet.com; dkim=pass (2048-bit key) header.d=secunet.com header.i=@secunet.com header.b=z/9SehUl; arc=none smtp.client-ip=62.96.220.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=secunet.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=secunet.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=secunet.com header.i=@secunet.com header.b="z/9SehUl" Received: from localhost (localhost [127.0.0.1]) by mx1.secunet.com (Postfix) with ESMTP id 5EEAF206D2; Mon, 9 Mar 2026 19:45:32 +0100 (CET) X-Virus-Scanned: by secunet Received: from mx1.secunet.com ([127.0.0.1]) by localhost (mx1.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j5VHDM2n1ZSr; Mon, 9 Mar 2026 19:45:31 +0100 (CET) Received: from EXCH-02.secunet.de (rl2.secunet.de [10.32.0.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.secunet.com (Postfix) with ESMTPS id C5E72206DF; Mon, 9 Mar 2026 19:45:31 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.secunet.com C5E72206DF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secunet.com; s=202301; t=1773081931; bh=P4LZ1X8mVK1D2YiWf2L9C8phAaDU5ekzdhSohebF48o=; h=From:To:CC:Subject:Date:In-Reply-To:References:From; b=z/9SehUlHm3LEBgqXPzpPVbKuJkL/BrzNVcly99amhhV3iuMylcJ0t93Ygq+kx/Gu YmO2cA13LuQXRX/2LEMhAHH5RHk/BjY5ZH8Zp1/QVQQfA/+8EcKpgV8EBJ4DA+xVom HeMuWHsz12KEZWkQMaY1Ioa+cd5DrtaDclF75oWVy9juBpx+P6MhbFqSgVSMEiNAEu N8tiZQhtTMhw9lTYAAo3KCxIUdAC9n8kPquLx8fFgMzG0SGFVEVnVOVLVhKsqp0952 Lu/d/GqCPsw81y3qYkNIcIURfO3i7hrFKaxC111ohbhsqvo4B34ceb9B6wii7n170l 2sS8pjeOLRtHw== Received: from moon.secunet.de (172.18.149.1) by EXCH-02.secunet.de (10.32.0.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 9 Mar 2026 19:45:31 +0100 From: Antony Antony To: Antony Antony , Steffen Klassert , Herbert Xu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , David Ahern , Masahide NAKAMURA , Paul Moore , Stephen Smalley , Ondrej Mosnacek , Jonathan Corbet , Shuah Khan CC: , , , , Chiachang Wang , Yan Yan , Subject: [PATCH ipsec-next v6 01/14] xfrm: remove redundant assignments Date: Mon, 9 Mar 2026 19:44:00 +0100 Message-ID: X-Mailer: git-send-email 2.39.5 In-Reply-To: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.14.2 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: EXCH-02.secunet.de (10.32.0.172) To EXCH-02.secunet.de (10.32.0.172) These assignments are overwritten within the same function further down commit e8961c50ee9cc ("xfrm: Refactor migration setup during the cloning process") x->props.family = m->new_family; Which actually moved it in the commit e03c3bba351f9 ("xfrm: Fix xfrm migrate issues when address family changes") And the initial commit 80c9abaabf428 ("[XFRM]: Extension for dynamic update of endpoint address(es)") added x->props.saddr = orig->props.saddr; and memcpy(&xc->props.saddr, &m->new_saddr, sizeof(xc->props.saddr)); Signed-off-by: Antony Antony --- v1->v2: remove extra saddr copy, previous line --- net/xfrm/xfrm_state.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c index 98b362d518363bbc100b5446d6a327b3209fed99..3ee92f93dbd2f3e3a8807b9cbd4d0a9880e5c9a4 100644 --- a/net/xfrm/xfrm_state.c +++ b/net/xfrm/xfrm_state.c @@ -1980,8 +1980,6 @@ static struct xfrm_state *xfrm_state_clone_and_setup(struct xfrm_state *orig, x->props.mode = orig->props.mode; x->props.replay_window = orig->props.replay_window; x->props.reqid = orig->props.reqid; - x->props.family = orig->props.family; - x->props.saddr = orig->props.saddr; if (orig->aalg) { x->aalg = xfrm_algo_auth_clone(orig->aalg); -- 2.47.3