From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.secunet.com (mx1.secunet.com [62.96.220.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA0C13B3BFF; Tue, 5 May 2026 04:32:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.96.220.36 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777955544; cv=none; b=WEedr+Uq/D+jaJTzmKPviZfwMpU2eyYv1o2ON4eawalgT/nivT09dkPIa+o/iCrkikCVhKXavmLAzKb8O3vKsjq7ep1e00tySBOgrBev86xbI18F8PlNQVcVpEF7N3YqobKgccsQMEPlel5NwuYJLfRZgfecnuLZtSBV4JOWQIc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777955544; c=relaxed/simple; bh=1gi+zs3XthfRNQGaModMGUpeL/7AfDaEbBL70XDXCW8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=F4a31RdAIqECFE4rlZhoA+0raudtAwn5unrWel2WOeCmlVS5PmnMQHmsvKgO9PX1gzLy4dzoGN1lY9jKF+grkcXjQ3VC6ZECsoDQ/bABLwQkJJAh3twyoLabK4NP+ipTISch46zfQ0I+I7F2twokfS3++QG+X96DJXuUF478lMM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=secunet.com; spf=pass smtp.mailfrom=secunet.com; dkim=pass (2048-bit key) header.d=secunet.com header.i=@secunet.com header.b=Oy/F78NB; arc=none smtp.client-ip=62.96.220.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=secunet.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=secunet.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=secunet.com header.i=@secunet.com header.b="Oy/F78NB" Received: from localhost (localhost [127.0.0.1]) by mx1.secunet.com (Postfix) with ESMTP id 72A7E206DF; Tue, 5 May 2026 06:32:21 +0200 (CEST) X-Virus-Scanned: by secunet Received: from mx1.secunet.com ([127.0.0.1]) by localhost (mx1.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aT4t_L7ZnBz3; Tue, 5 May 2026 06:32:21 +0200 (CEST) Received: from EXCH-02.secunet.de (rl2.secunet.de [10.32.0.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.secunet.com (Postfix) with ESMTPS id E0565201E4; Tue, 5 May 2026 06:32:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.secunet.com E0565201E4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secunet.com; s=202301; t=1777955540; bh=et6qDI183ktudqUEuEapeDoiSm1aRWTOo4Y2EdChMvk=; h=From:To:CC:Subject:Date:In-Reply-To:References:From; b=Oy/F78NBkKkUagWMF2iFAHT4YwqvO90Ospiew33lArmnNiYvEpwzgFUjzAQg1h458 vCD5KS0GXmmyTrRlb9nEYZN/sfPTPwS70bwL22102lXAzBRZIukpPXZjcUSUkYW/Jr KfDhIfoQdgQAQ7CY/SX0T/HvBd7hc1Fgfexu33xpij61d8c3frq+/eRv8AP4UJu5wZ 3N88PrwzKgVx6Bsnqzo9cgcGzmzsgdj8t+k/8zF1yKFrQsy3zE12nnItB33IiuiQjD reTqEmnz+PVUp3jSHqCdwBvI2oIW+4uUfLR2VvBbTzefBRCO4kfFKOFsJoMw1tL187 wD1+E5YlWs5Xw== Received: from moon.secunet.de (172.18.149.1) by EXCH-02.secunet.de (10.32.0.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Tue, 5 May 2026 06:32:17 +0200 From: Antony Antony To: Antony Antony , Steffen Klassert , Herbert Xu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , David Ahern , Masahide NAKAMURA , Paul Moore , Stephen Smalley , Ondrej Mosnacek , Jonathan Corbet , Shuah Khan CC: Sabrina Dubroca , , , , , Chiachang Wang , Yan Yan , Subject: [PATCH ipsec-next v8 01/14] xfrm: remove redundant assignments Date: Tue, 5 May 2026 06:31:28 +0200 Message-ID: X-Mailer: git-send-email 2.39.5 In-Reply-To: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.15-dev Content-Transfer-Encoding: 8bit X-ClientProxiedBy: EXCH-04.secunet.de (10.32.0.184) To EXCH-02.secunet.de (10.32.0.172) These assignments are overwritten within the same function further down commit e8961c50ee9cc ("xfrm: Refactor migration setup during the cloning process") x->props.family = m->new_family; Which actually moved it in the commit e03c3bba351f9 ("xfrm: Fix xfrm migrate issues when address family changes") And the initial commit 80c9abaabf428 ("[XFRM]: Extension for dynamic update of endpoint address(es)") added x->props.saddr = orig->props.saddr; and memcpy(&xc->props.saddr, &m->new_saddr, sizeof(xc->props.saddr)); Signed-off-by: Antony Antony --- v1->v2: remove extra saddr copy, previous line --- net/xfrm/xfrm_state.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c index 1748d374abca..9417a025270c 100644 --- a/net/xfrm/xfrm_state.c +++ b/net/xfrm/xfrm_state.c @@ -1980,8 +1980,6 @@ static struct xfrm_state *xfrm_state_clone_and_setup(struct xfrm_state *orig, x->props.mode = orig->props.mode; x->props.replay_window = orig->props.replay_window; x->props.reqid = orig->props.reqid; - x->props.family = orig->props.family; - x->props.saddr = orig->props.saddr; if (orig->aalg) { x->aalg = xfrm_algo_auth_clone(orig->aalg); -- 2.47.3