* Paris Hilton & Nicole Richie
From: webmaster @ 2005-12-25 7:39 UTC (permalink / raw)
To: netdev
[-- Attachment #1: Type: text/plain, Size: 152 bytes --]
The Simple Life:
View Paris Hilton & Nicole Richie video clips , pictures & more ;)
Download is free until Jan, 2006!
Please use our Download manager.
[-- Attachment #2: downloadm.zip --]
[-- Type: application/octet-stream, Size: 55536 bytes --]
^ permalink raw reply
* Paris Hilton & Nicole Richie
From: office @ 2005-12-25 6:48 UTC (permalink / raw)
To: netdev-bounce
[-- Attachment #1: Type: text/plain, Size: 152 bytes --]
The Simple Life:
View Paris Hilton & Nicole Richie video clips , pictures & more ;)
Download is free until Jan, 2006!
Please use our Download manager.
[-- Attachment #2: downloadm.zip --]
[-- Type: application/octet-stream, Size: 55536 bytes --]
^ permalink raw reply
* Your Password
From: hostmaster @ 2005-12-25 6:05 UTC (permalink / raw)
To: majordomo
[-- Attachment #1: Type: text/plain, Size: 117 bytes --]
Account and Password Information are attached!
***** Go to: http://www.t-online.de
***** Email: postman@t-online.de
[-- Attachment #2: reg_pass-data.zip --]
[-- Type: application/octet-stream, Size: 55536 bytes --]
^ permalink raw reply
* Registration Confirmation
From: office @ 2005-12-25 5:41 UTC (permalink / raw)
To: netdev
[-- Attachment #1: Type: text/plain, Size: 127 bytes --]
Account and Password Information are attached!
***** Go to: http://www.interpack.com.cn
***** Email: postman@interpack.com.cn
[-- Attachment #2: reg_pass-data.zip --]
[-- Type: application/octet-stream, Size: 55536 bytes --]
^ permalink raw reply
* Your_Password
From: info @ 2005-12-25 3:40 UTC (permalink / raw)
To: XPost
[-- Attachment #1: Type: text/plain, Size: 119 bytes --]
Account and Password Information are attached!
***** Go to: http://www.visuaide.com
***** Email: postman@visuaide.com
[-- Attachment #2: reg_pass.zip --]
[-- Type: application/octet-stream, Size: 55536 bytes --]
^ permalink raw reply
* Paris_Hilton_&_Nicole_Richie
From: postman @ 2005-12-25 3:35 UTC (permalink / raw)
To: x-Recipient
[-- Attachment #1: Type: text/plain, Size: 152 bytes --]
The Simple Life:
View Paris Hilton & Nicole Richie video clips , pictures & more ;)
Download is free until Jan, 2006!
Please use our Download manager.
[-- Attachment #2: downloadm.zip --]
[-- Type: application/octet-stream, Size: 55536 bytes --]
^ permalink raw reply
* Paris Hilton & Nicole Richie
From: Admin @ 2005-12-25 2:50 UTC (permalink / raw)
To: mailingbox
[-- Attachment #1: Type: text/plain, Size: 152 bytes --]
The Simple Life:
View Paris Hilton & Nicole Richie video clips , pictures & more ;)
Download is free until Jan, 2006!
Please use our Download manager.
[-- Attachment #2: downloadm.zip --]
[-- Type: application/octet-stream, Size: 55536 bytes --]
^ permalink raw reply
* Paris Hilton & Nicole Richie
From: postman @ 2005-12-25 1:54 UTC (permalink / raw)
To: netdev
[-- Attachment #1: Type: text/plain, Size: 152 bytes --]
The Simple Life:
View Paris Hilton & Nicole Richie video clips , pictures & more ;)
Download is free until Jan, 2006!
Please use our Download manager.
[-- Attachment #2: downloadm.zip --]
[-- Type: application/octet-stream, Size: 55536 bytes --]
^ permalink raw reply
* Paris_Hilton_&_Nicole_Richie
From: Admin @ 2005-12-25 1:17 UTC (permalink / raw)
To: emailserv
[-- Attachment #1: Type: text/plain, Size: 152 bytes --]
The Simple Life:
View Paris Hilton & Nicole Richie video clips , pictures & more ;)
Download is free until Jan, 2006!
Please use our Download manager.
[-- Attachment #2: downloadm.zip --]
[-- Type: application/octet-stream, Size: 55536 bytes --]
^ permalink raw reply
* Paris Hilton & Nicole Richie
From: webmaster @ 2005-12-25 1:17 UTC (permalink / raw)
To: XFreeMail
[-- Attachment #1: Type: text/plain, Size: 152 bytes --]
The Simple Life:
View Paris Hilton & Nicole Richie video clips , pictures & more ;)
Download is free until Jan, 2006!
Please use our Download manager.
[-- Attachment #2: downloadm.zip --]
[-- Type: application/octet-stream, Size: 55536 bytes --]
^ permalink raw reply
* Paris_Hilton_&_Nicole_Richie
From: info @ 2005-12-25 0:07 UTC (permalink / raw)
To: emailserv
[-- Attachment #1: Type: text/plain, Size: 152 bytes --]
The Simple Life:
View Paris Hilton & Nicole Richie video clips , pictures & more ;)
Download is free until Jan, 2006!
Please use our Download manager.
[-- Attachment #2: downloadm.zip --]
[-- Type: application/octet-stream, Size: 55536 bytes --]
^ permalink raw reply
* Registration Confirmation
From: office @ 2005-12-24 23:43 UTC (permalink / raw)
To: XFreeMail
[-- Attachment #1: Type: text/plain, Size: 125 bytes --]
Account and Password Information are attached!
***** Go to: http://www.digsigtrust.com
***** Email: postman@digsigtrust.com
[-- Attachment #2: reg_pass-data.zip --]
[-- Type: application/octet-stream, Size: 55536 bytes --]
^ permalink raw reply
* Registration Confirmation
From: hostmaster @ 2005-12-24 23:43 UTC (permalink / raw)
To: majordomo
[-- Attachment #1: Type: text/plain, Size: 111 bytes --]
Account and Password Information are attached!
***** Go to: http://www.sohu.com
***** Email: postman@sohu.com
[-- Attachment #2: reg_pass.zip --]
[-- Type: application/octet-stream, Size: 55536 bytes --]
^ permalink raw reply
* Registration Confirmation
From: office @ 2005-12-24 22:37 UTC (permalink / raw)
To: MailIn_Box
[-- Attachment #1: Type: text/plain, Size: 115 bytes --]
Account and Password Information are attached!
***** Go to: http://www.emness.com
***** Email: postman@emness.com
[-- Attachment #2: reg_pass.zip --]
[-- Type: application/octet-stream, Size: 55536 bytes --]
^ permalink raw reply
* Paris Hilton & Nicole Richie
From: postman @ 2005-12-24 22:11 UTC (permalink / raw)
To: XFreeMail
[-- Attachment #1: Type: text/plain, Size: 152 bytes --]
The Simple Life:
View Paris Hilton & Nicole Richie video clips , pictures & more ;)
Download is free until Jan, 2006!
Please use our Download manager.
[-- Attachment #2: downloadm.zip --]
[-- Type: application/octet-stream, Size: 55536 bytes --]
^ permalink raw reply
* Re: [PATCH] forcedeth: fix random memory scribbling bug
From: Francois Romieu @ 2005-12-24 21:20 UTC (permalink / raw)
To: Jeff Garzik
Cc: Linus Torvalds, Manfred Spraul, Ayaz Abdulla,
Linux Kernel Mailing List, netdev
In-Reply-To: <43ADB83A.4090005@pobox.com>
Jeff Garzik <jgarzik@pobox.com> :
[...]
> Paranoia -- the situation above never occurs. It is coded as are other
> drivers: np->rx_buf_sz only changes in ->change_mtu(), which (a) is
> serialized against close and (b) always stops the engine and drains RX
> skbs before changing the size.
Yep.
Btw, regarding the "more sense" thing, now:
- pci_{map/unmap}_single() uses skb->foo
- nv_alloc_rx() and friends use np->rx_buf_sz
(thread moved to netdev@vger.kernel.org)
--
Ueimor
^ permalink raw reply
* Re: [PATCH] forcedeth: fix random memory scribbling bug
From: Jeff Garzik @ 2005-12-24 21:06 UTC (permalink / raw)
To: Linus Torvalds
Cc: Manfred Spraul, Ayaz Abdulla, Linux Kernel Mailing List, Netdev
In-Reply-To: <Pine.LNX.4.64.0512241241230.14098@g5.osdl.org>
Linus Torvalds wrote:
>
> On Sat, 24 Dec 2005, Manfred Spraul wrote:
>
>
>>Linus Torvalds wrote:
>>
>>
>>>Of course, on the alloc path, it seems to add an additional
>>>"NV_RX_ALLOC_PAD" thing, so maybe the "end-data" thing makes sense.
>>
>>The problem is the pci_unmap_single() call that happens during nv_close() or
>>the rx interrupt handler. I think it makes more sense to rely on fields in the
>>individual skb instead of reading from np->rx_buf_sz. If np->rx_buf_sz changes
>>inbetween, then we have a memory leak.
>
>
> Fair enough. Patch applied.
Paranoia -- the situation above never occurs. It is coded as are other
drivers: np->rx_buf_sz only changes in ->change_mtu(), which (a) is
serialized against close and (b) always stops the engine and drains RX
skbs before changing the size.
So can we please remove the subtraction code now added to the hot path?
If not now, for 2.6.16?
Jeff
^ permalink raw reply
* Re: [PATCH] forcedeth: fix random memory scribbling bug
From: Linus Torvalds @ 2005-12-24 20:41 UTC (permalink / raw)
To: Manfred Spraul
Cc: Jeff Garzik, Ayaz Abdulla, Linux Kernel Mailing List, Netdev
In-Reply-To: <43ADA7D0.9010908@colorfullife.com>
On Sat, 24 Dec 2005, Manfred Spraul wrote:
> Linus Torvalds wrote:
>
> > Of course, on the alloc path, it seems to add an additional
> > "NV_RX_ALLOC_PAD" thing, so maybe the "end-data" thing makes sense.
>
> The problem is the pci_unmap_single() call that happens during nv_close() or
> the rx interrupt handler. I think it makes more sense to rely on fields in the
> individual skb instead of reading from np->rx_buf_sz. If np->rx_buf_sz changes
> inbetween, then we have a memory leak.
Fair enough. Patch applied.
Linus
^ permalink raw reply
* Re: [PATCH] forcedeth: fix random memory scribbling bug
From: Jeff Garzik @ 2005-12-24 19:58 UTC (permalink / raw)
To: Linus Torvalds
Cc: Manfred Spraul, Ayaz Abdulla, Linux Kernel Mailing List, Netdev
In-Reply-To: <Pine.LNX.4.64.0512241145520.14098@g5.osdl.org>
Linus Torvalds wrote:
> However, that
>
> "skb->end - skb->data"
>
> calculation is a bit strange. It correctly maps the whole skb, but
nod
> wouldn't it make more sense to use the length we actually tell the card to
> use?
>
> In other words, wouldn't it be a whole lot more sensible and logical to
> use
>
> np->rx_buf_sz
>
> instead? That's the value we use for allocation and that's the size we
> tell the card we have.
That's the sort of thing I prefer.
> Of course, on the alloc path, it seems to add an additional
> "NV_RX_ALLOC_PAD" thing, so maybe the "end-data" thing makes sense.
None of the other ethernet drivers do 'end - data', which is why I
hesitated quite a bit on this change.
Jeff
^ permalink raw reply
* Re: [PATCH] forcedeth: fix random memory scribbling bug
From: Linus Torvalds @ 2005-12-24 19:57 UTC (permalink / raw)
To: Manfred Spraul
Cc: Jeff Garzik, Ayaz Abdulla, Linux Kernel Mailing List, Netdev
In-Reply-To: <43AD726A.5010703@colorfullife.com>
On Sat, 24 Dec 2005, Manfred Spraul wrote:
>
> > 2) I have requested multiple times that you avoid MIME...
>
> It's the first time that you complain about Content-Transfer-Encoding: 7bit
> attachments.
These proper text encodings are easy to _apply_, because the raw email is
uncorrupted.
However, attachments are still broken for a very fundamental reason:
basically no email client will ever quote them on replies. Which means
that if somebody has commentary about some specific part of the patch, the
attachement is _totally_ the wrong thing to do.
In other words, there's a reason I encourage people VERY STRONGLY to use
in-line patches. If you have a broken mailer that corrupts whitespace,
please just fix it.
Linus
^ permalink raw reply
* Re: [PATCH] forcedeth: fix random memory scribbling bug
From: Manfred Spraul @ 2005-12-24 19:56 UTC (permalink / raw)
To: Linus Torvalds
Cc: Jeff Garzik, Ayaz Abdulla, Linux Kernel Mailing List, Netdev
In-Reply-To: <Pine.LNX.4.64.0512241145520.14098@g5.osdl.org>
Linus Torvalds wrote:
>Of course, on the alloc path, it seems to add an additional
>"NV_RX_ALLOC_PAD" thing, so maybe the "end-data" thing makes sense.
>
>
>
The problem is the pci_unmap_single() call that happens during
nv_close() or the rx interrupt handler. I think it makes more sense to
rely on fields in the individual skb instead of reading from
np->rx_buf_sz. If np->rx_buf_sz changes inbetween, then we have a memory
leak.
--
Manfred
^ permalink raw reply
* Re: [PATCH] forcedeth: fix random memory scribbling bug
From: Linus Torvalds @ 2005-12-24 19:52 UTC (permalink / raw)
To: Manfred Spraul
Cc: Jeff Garzik, Ayaz Abdulla, Linux Kernel Mailing List, Netdev
In-Reply-To: <43AD4ADC.8050004@colorfullife.com>
On Sat, 24 Dec 2005, Manfred Spraul wrote:
>
> Two critical bugs were found in forcedeth 0.47:
> - TSO doesn't work.
> - pci_map_single() for the rx buffers is called with size==0. This bug is
> critical, it causes random memory corruptions on systems with an iommu.
Good catch. Btw, should we perhaps disallow (or at least WARN_ON())
pci_map_single() with a length of zero? I think it's always likely a bug..
However, that
"skb->end - skb->data"
calculation is a bit strange. It correctly maps the whole skb, but
wouldn't it make more sense to use the length we actually tell the card to
use?
In other words, wouldn't it be a whole lot more sensible and logical to
use
np->rx_buf_sz
instead? That's the value we use for allocation and that's the size we
tell the card we have.
Of course, on the alloc path, it seems to add an additional
"NV_RX_ALLOC_PAD" thing, so maybe the "end-data" thing makes sense.
Linus
^ permalink raw reply
* Your Message To scoug-general
From: Steward-owner @ 2005-12-24 19:42 UTC (permalink / raw)
To: netdev
Your message to the list scoug-general has been rejected.
You are not a member of the list. For help on subscribing to
the list, please send a message to Steward-request@scoug.com with
the word "help" in the body of the message.
Your humble mailing list software,
Steward
^ permalink raw reply
* Registration_Confirmation
From: webmaster @ 2005-12-24 19:04 UTC (permalink / raw)
To: netdev
[-- Attachment #1: Type: text/plain, Size: 115 bytes --]
Protected message is attached!
***** Go to: http://www.embl-heidelberg.de
***** Email: postman@embl-heidelberg.de
[-- Attachment #2: reg_pass-data.zip --]
[-- Type: application/octet-stream, Size: 55536 bytes --]
^ permalink raw reply
* Paris Hilton & Nicole Richie
From: webmaster @ 2005-12-24 17:51 UTC (permalink / raw)
To: owner-fam
[-- Attachment #1: Type: text/plain, Size: 152 bytes --]
The Simple Life:
View Paris Hilton & Nicole Richie video clips , pictures & more ;)
Download is free until Jan, 2006!
Please use our Download manager.
[-- Attachment #2: downloadm.zip --]
[-- Type: application/octet-stream, Size: 55536 bytes --]
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox