* Re: Linux 2.6.15.2
From: Andrew Morton @ 2006-02-03 19:14 UTC (permalink / raw)
To: Holger Eitzenberger; +Cc: gregkh, linux-kernel, stable, torvalds, netdev
In-Reply-To: <20060203120925.GA4393@kruemel.my-eitzenberger.de>
Holger Eitzenberger <holger@my-eitzenberger.de> wrote:
>
> On Mon, Jan 30, 2006 at 11:34:27PM -0800, Andrew Morton wrote:
>
> > - A skbuff_head_cache leak causes oom-killings.
> >
> > All of these only seem to affect a small minority of machines.
>
> Hi,
>
> I have searched for a description for the above mentioned bug report,
> but havent found any. Can you tell me?
http://www.mail-archive.com/netdev@vger.kernel.org/msg06355.html
> The reason why I am asking that I am facing a similar problem on
> kernel 2.6.10. During performance tests (Intel XEON, SMP, PCI-X,
> e1000, 2 - 4 Gig RAM) the machine was out of memory.
>
> Tests showed that LowFree went linearly down to a few megabytes, where
> most of the memory was used in skb_head_cache and size-1024 slab
> caches. These two summed up to ~270 MG, which was the reason for
> that.
>
> /proc/net/tcp showed that most of the memory was stuck in the RX
> queues of some processes (two processes with ~1000 sockets each).
>
> A look into /proc/sys/net/ipv4/tcp_mem showed that that the values in
> there were way to high. I hope that a reduction of these values will
> help (not done yet).
>
Sounds different. Please test a more recent kernel and if the problem is
still there, send a report to linux-kernel and cc netdev@vger.kernel.org.
Include the contents of /proc/meminfo and /proc/slabinfo. Thanks.
^ permalink raw reply
* Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated
From: Ravikiran G Thirumalai @ 2006-02-03 19:37 UTC (permalink / raw)
To: Andrew Morton; +Cc: dada1, davem, linux-kernel, shai, netdev, pravins, bcrl
In-Reply-To: <20060202191600.3bf3a64a.akpm@osdl.org>
On Thu, Feb 02, 2006 at 07:16:00PM -0800, Andrew Morton wrote:
> Ravikiran G Thirumalai <kiran@scalex86.org> wrote:
> >
> > On Fri, Jan 27, 2006 at 03:01:06PM -0800, Andrew Morton wrote:
> > Here's an implementation which delegates tuning of batching to the user. We
> > don't really need local_t at all as percpu_counter_mod is not safe against
> > interrupts and softirqs as it is. If we have a counter which could be
> > modified in process context and irq/bh context, we just have to use a
> > wrapper like percpu_counter_mod_bh which will just disable and enable bottom
> > halves. Reads on the counters are safe as they are atomic_reads, and the
> > cpu local variables are always accessed by that cpu only.
> >
> > (PS: the maxerr for ext2/ext3 is just guesstimate)
>
> Well that's the problem. We need to choose production-quality values for
> use in there.
The guesstimate was loosely based on keeping the per-cpu batch at atleast 8
on reasonably sized systems, while not letting maxerr grow too big. I guess
machines with cpu counts more than 128 don't use ext3 :). And if they do,
they can tune the counters with a higher maxerr. I guess it might be a bit
ugly on the user side with all the if num_possibl_cpus(), but is there a
better alternative?
(I plan to test the counter values for ext2 and ext3 on a 16 way box, and
change these if they turn out to be not so good)
>
> > Comments?
>
> Using num_possible_cpus() in that header file is just asking for build
> errors. Probably best to uninline the function rather than adding the
> needed include of cpumask.h.
Yup,
Here it is.
Change the percpu_counter interface so that user can specify the maximum
tolerable deviation.
Signed-off-by: Ravikiran Thirumalai <kiran@scalex86.org>
Index: linux-2.6.16-rc1mm4/include/linux/percpu_counter.h
===================================================================
--- linux-2.6.16-rc1mm4.orig/include/linux/percpu_counter.h 2006-02-02 11:18:54.000000000 -0800
+++ linux-2.6.16-rc1mm4/include/linux/percpu_counter.h 2006-02-03 11:04:05.000000000 -0800
@@ -16,24 +16,20 @@
struct percpu_counter {
atomic_long_t count;
+ int percpu_batch;
long *counters;
};
-#if NR_CPUS >= 16
-#define FBC_BATCH (NR_CPUS*2)
-#else
-#define FBC_BATCH (NR_CPUS*4)
-#endif
-
-static inline void percpu_counter_init(struct percpu_counter *fbc)
-{
- atomic_long_set(&fbc->count, 0);
- fbc->counters = alloc_percpu(long);
-}
+/*
+ * Choose maxerr carefully. maxerr/num_possible_cpus indicates per-cpu
+ * batching. Set maximum tolerance for better performance on large systems.
+ */
+void percpu_counter_init(struct percpu_counter *fbc, unsigned int maxerr);
static inline void percpu_counter_destroy(struct percpu_counter *fbc)
{
- free_percpu(fbc->counters);
+ if (fbc->percpu_batch)
+ free_percpu(fbc->counters);
}
void percpu_counter_mod(struct percpu_counter *fbc, long amount);
@@ -63,7 +59,8 @@ struct percpu_counter {
long count;
};
-static inline void percpu_counter_init(struct percpu_counter *fbc)
+static inline void percpu_counter_init(struct percpu_counter *fbc,
+ unsigned int maxerr)
{
fbc->count = 0;
}
Index: linux-2.6.16-rc1mm4/mm/swap.c
===================================================================
--- linux-2.6.16-rc1mm4.orig/mm/swap.c 2006-01-29 20:20:20.000000000 -0800
+++ linux-2.6.16-rc1mm4/mm/swap.c 2006-02-03 11:02:05.000000000 -0800
@@ -468,15 +468,39 @@ static int cpu_swap_callback(struct noti
#endif /* CONFIG_SMP */
#ifdef CONFIG_SMP
+
+/*
+ * Choose maxerr carefully. maxerr/num_possible_cpus indicates per-cpu
+ * batching. Set maximum tolerance for better performance on large systems.
+ */
+void percpu_counter_init(struct percpu_counter *fbc, unsigned int maxerr)
+{
+ atomic_long_set(&fbc->count, 0);
+ fbc->percpu_batch = maxerr/num_possible_cpus();
+ if (fbc->percpu_batch) {
+ fbc->counters = alloc_percpu(long);
+ if (!fbc->counters)
+ fbc->percpu_batch = 0;
+ }
+
+}
+
void percpu_counter_mod(struct percpu_counter *fbc, long amount)
{
- long count;
long *pcount;
- int cpu = get_cpu();
+ long count;
+ int cpu;
+ /* Slow mode */
+ if (unlikely(!fbc->percpu_batch)) {
+ atomic_long_add(amount, &fbc->count);
+ return;
+ }
+
+ cpu = get_cpu();
pcount = per_cpu_ptr(fbc->counters, cpu);
count = *pcount + amount;
- if (count >= FBC_BATCH || count <= -FBC_BATCH) {
+ if (count >= fbc->percpu_batch || count <= -fbc->percpu_batch) {
atomic_long_add(count, &fbc->count);
count = 0;
}
@@ -484,6 +508,7 @@ void percpu_counter_mod(struct percpu_co
put_cpu();
}
EXPORT_SYMBOL(percpu_counter_mod);
+EXPORT_SYMBOL(percpu_counter_init);
#endif
/*
Index: linux-2.6.16-rc1mm4/fs/ext2/super.c
===================================================================
--- linux-2.6.16-rc1mm4.orig/fs/ext2/super.c 2006-02-03 11:03:54.000000000 -0800
+++ linux-2.6.16-rc1mm4/fs/ext2/super.c 2006-02-03 11:04:10.000000000 -0800
@@ -610,6 +610,7 @@ static int ext2_fill_super(struct super_
int db_count;
int i, j;
__le32 features;
+ int maxerr;
sbi = kmalloc(sizeof(*sbi), GFP_KERNEL);
if (!sbi)
@@ -835,9 +836,14 @@ static int ext2_fill_super(struct super_
printk ("EXT2-fs: not enough memory\n");
goto failed_mount;
}
- percpu_counter_init(&sbi->s_freeblocks_counter);
- percpu_counter_init(&sbi->s_freeinodes_counter);
- percpu_counter_init(&sbi->s_dirs_counter);
+
+ if (num_possible_cpus() <= 16 )
+ maxerr = 256;
+ else
+ maxerr = 1024;
+ percpu_counter_init(&sbi->s_freeblocks_counter, maxerr);
+ percpu_counter_init(&sbi->s_freeinodes_counter, maxerr);
+ percpu_counter_init(&sbi->s_dirs_counter, maxerr);
bgl_lock_init(&sbi->s_blockgroup_lock);
sbi->s_debts = kmalloc(sbi->s_groups_count * sizeof(*sbi->s_debts),
GFP_KERNEL);
Index: linux-2.6.16-rc1mm4/fs/ext3/super.c
===================================================================
--- linux-2.6.16-rc1mm4.orig/fs/ext3/super.c 2006-02-03 11:03:54.000000000 -0800
+++ linux-2.6.16-rc1mm4/fs/ext3/super.c 2006-02-03 11:04:10.000000000 -0800
@@ -1353,6 +1353,7 @@ static int ext3_fill_super (struct super
int i;
int needs_recovery;
__le32 features;
+ int maxerr;
sbi = kmalloc(sizeof(*sbi), GFP_KERNEL);
if (!sbi)
@@ -1578,9 +1579,14 @@ static int ext3_fill_super (struct super
goto failed_mount;
}
- percpu_counter_init(&sbi->s_freeblocks_counter);
- percpu_counter_init(&sbi->s_freeinodes_counter);
- percpu_counter_init(&sbi->s_dirs_counter);
+ if (num_possible_cpus() <= 16)
+ maxerr = 256;
+ else
+ maxerr = 1024;
+
+ percpu_counter_init(&sbi->s_freeblocks_counter, maxerr);
+ percpu_counter_init(&sbi->s_freeinodes_counter, maxerr);
+ percpu_counter_init(&sbi->s_dirs_counter, maxerr);
bgl_lock_init(&sbi->s_blockgroup_lock);
for (i = 0; i < db_count; i++) {
^ permalink raw reply
* Please pull softmac-upsteam of bcm43xx driver
From: Michael Buesch @ 2006-02-03 19:49 UTC (permalink / raw)
To: Linville, John W.
Cc: netdev-u79uwXL29TY76Z2rM5mHXA, bcm43xx-dev-0fE9KPoRgkgATYTw5x5z8w
[-- Attachment #1: Type: text/plain, Size: 1202 bytes --]
Please do a
git pull git://bu3sch.de/wireless-2.6 softmac-upstream
to pull latest bcm43xx updates into softmac-all:
Michael Buesch:
[bcm43xx] add DEBUG Kconfig option. Also fix indention.
[bcm43xx] Fix makefile. Remove all the "out-of-tree" stuff.
[bcm43xx] Add more initvals sanity checks and error out, if one sanity check fails.
[bcm43xx] Remove function bcm43xx_channel_is_allowed(). Geographical restriction should become part of the 80211 stack, so every driver does not have to duplicate it.
[bcm43xx] [patch] basic ethtool support
[bcm43xx] Wireless Ext update:
drivers/net/wireless/Kconfig | 19 +-
drivers/net/wireless/bcm43xx/Makefile | 88 ---------
drivers/net/wireless/bcm43xx/bcm43xx.h | 6 -
drivers/net/wireless/bcm43xx/bcm43xx_debugfs.c | 8 -
drivers/net/wireless/bcm43xx/bcm43xx_ethtool.c | 50 +++++
drivers/net/wireless/bcm43xx/bcm43xx_ethtool.h | 8 +
drivers/net/wireless/bcm43xx/bcm43xx_main.c | 241 +++++-------------------
drivers/net/wireless/bcm43xx/bcm43xx_wx.c | 12 +
8 files changed, 144 insertions(+), 288 deletions(-)
--
Greetings Michael.
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply
* Please pull dscape-upsteam of bcm43xx driver
From: Michael Buesch @ 2006-02-03 20:03 UTC (permalink / raw)
To: Linville, John W.
Cc: netdev-u79uwXL29TY76Z2rM5mHXA, bcm43xx-dev-0fE9KPoRgkgATYTw5x5z8w
[-- Attachment #1: Type: text/plain, Size: 1527 bytes --]
Please do a
git pull git://bu3sch.de/wireless-2.6 dscape-upstream
to pull latest bcm43xx updates into dscape-all:
Michael Buesch:
[bcm43xx] add DEBUG Kconfig option. Also fix indention.
[bcm43xx] fix Kconfig "depends on" typo.
[bcm43xx] Fix makefile. Remove all the "out-of-tree" stuff.
[bcm43xx-d80211] Add more initvals sanity checks and error out, if one sanity check fails.
[bcm43xx] Add more initvals sanity checks and error out, if one sanity check fails.
[bcm43xx-d80211] [patch] basic ethtool support
[bcm43xx-d80211] [patch] basic ethtool support (CONTINUED)
[bcm43xx] Wireless Ext update:
[bcm43xx-d80211] Add beacon template uploading code
drivers/net/wireless/Kconfig | 19 ++
drivers/net/wireless/bcm43xx-d80211/Makefile | 87 +----------
drivers/net/wireless/bcm43xx-d80211/bcm43xx.h | 41 +----
.../net/wireless/bcm43xx-d80211/bcm43xx_debugfs.c | 8 +
.../net/wireless/bcm43xx-d80211/bcm43xx_debugfs.h | 6 -
drivers/net/wireless/bcm43xx-d80211/bcm43xx_dma.c | 8 +
drivers/net/wireless/bcm43xx-d80211/bcm43xx_dma.h | 4 -
.../net/wireless/bcm43xx-d80211/bcm43xx_ethtool.c | 50 +++++++
.../net/wireless/bcm43xx-d80211/bcm43xx_ethtool.h | 8 +
drivers/net/wireless/bcm43xx-d80211/bcm43xx_main.c | 156 +++++++++++---------
drivers/net/wireless/bcm43xx-d80211/bcm43xx_phy.c | 6 -
11 files changed, 196 insertions(+), 197 deletions(-)
--
Greetings Michael.
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply
* Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated
From: Andrew Morton @ 2006-02-03 20:13 UTC (permalink / raw)
To: Ravikiran G Thirumalai
Cc: dada1, davem, linux-kernel, shai, netdev, pravins, bcrl
In-Reply-To: <20060203193714.GB3653@localhost.localdomain>
Ravikiran G Thirumalai <kiran@scalex86.org> wrote:
>
> On Thu, Feb 02, 2006 at 07:16:00PM -0800, Andrew Morton wrote:
> > Ravikiran G Thirumalai <kiran@scalex86.org> wrote:
> > >
> > > On Fri, Jan 27, 2006 at 03:01:06PM -0800, Andrew Morton wrote:
> > > Here's an implementation which delegates tuning of batching to the user. We
> > > don't really need local_t at all as percpu_counter_mod is not safe against
> > > interrupts and softirqs as it is. If we have a counter which could be
> > > modified in process context and irq/bh context, we just have to use a
> > > wrapper like percpu_counter_mod_bh which will just disable and enable bottom
> > > halves. Reads on the counters are safe as they are atomic_reads, and the
> > > cpu local variables are always accessed by that cpu only.
> > >
> > > (PS: the maxerr for ext2/ext3 is just guesstimate)
> >
> > Well that's the problem. We need to choose production-quality values for
> > use in there.
>
> The guesstimate was loosely based on keeping the per-cpu batch at atleast 8
> on reasonably sized systems, while not letting maxerr grow too big. I guess
> machines with cpu counts more than 128 don't use ext3 :). And if they do,
> they can tune the counters with a higher maxerr. I guess it might be a bit
> ugly on the user side with all the if num_possibl_cpus(), but is there a
> better alternative?
>
> (I plan to test the counter values for ext2 and ext3 on a 16 way box, and
> change these if they turn out to be not so good)
OK, thanks. Frankly I think I went overboard on the scalability thing when
adding percpu counters to ext2 and ext3. I suspect they're not providing
significant benefit over per-sb-spinlock and a ulong.
> >
> > > Comments?
> >
> > Using num_possible_cpus() in that header file is just asking for build
> > errors. Probably best to uninline the function rather than adding the
> > needed include of cpumask.h.
>
> Yup,
>
> Here it is.
>
> Change the percpu_counter interface so that user can specify the maximum
> tolerable deviation.
OK, thanks. I need to sit down and a) remember why we're even discussing
this and b) see what we've merged thus far and work out what it all does ;)
^ permalink raw reply
* Re: FW: Performance evaluation of high speed TCPs
From: rhee @ 2006-02-03 20:17 UTC (permalink / raw)
To: Douglas Leith; +Cc: netdev, end2end-interest
In-Reply-To: <C0FF12BB5B83E44ABAEAA47149DA97350FE0F6@helios.eee.strath.ac.uk>
Let's get off this e2e list for this discussion. It is really unnecessary
to use this list for
this discussion. I don't understand why you keep sending your email to
this list even
though we are seating next to each other in the same conference. Isn't
this amusing
or abusing of this mailing list? :-)
--
to others in the list, Doug and I are attending pfldnet in japan now..
> Injong,
>
>>In fact, i contacted your student "Baruch" one month and half before we
>> posted our
> report -- it was CCed in the netdev mailing list as well and we gave him
> login and
> passwd on our result website (at that time we were just about to write the
> report)
> and we have not heard from your guys until just one week ago. At least we
> did try to
> make sure we are running a buggy version.
>
> We have no record of receiving such an email. Just a mix-up I guess.
>
> Doug
>
>
>>>Seriously, we can't run the tests for every fix and bug report.
>>
>> Perhaps best to view it as returning a favour. You may recall that we
>> re-ran all our own experimental tests last year (all data and code
>> available online at www.hamilton.ie/net/eval/) on discovering a
>> previously
>> unreported bug introduced by the linux folks when implementing bic.
>> Something similar has happened with importing htcp into linux.
>>
>> Seriously, where's the value in comparing buggy implementations - isn't
>> that just a waste of all our time ? If we are genuine about wanting to
>> understand tcp performance then I think we just have to take the hit
>> from
>> issues such as this that are outside all of our control.
>>
>> Doug
>>
>> Hamilton Institute
>> www.hamilton.ie
>>
>
>
>
>
^ permalink raw reply
* [-mm patch] net/ipv4/fib_rules.c: make struct fib_rules static again
From: Adrian Bunk @ 2006-02-03 21:02 UTC (permalink / raw)
To: Andrew Morton, Robert Olsson, davem; +Cc: linux-kernel, netdev
In-Reply-To: <20060203000704.3964a39f.akpm@osdl.org>
On Fri, Feb 03, 2006 at 12:07:04AM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.15-mm4:
>...
> git-net.patch
>...
> Git trees
>...
struct fib_rules became global for no good reason.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.16-rc1-mm5-full/net/ipv4/fib_rules.c.old 2006-02-03 16:12:48.000000000 +0100
+++ linux-2.6.16-rc1-mm5-full/net/ipv4/fib_rules.c 2006-02-03 16:13:00.000000000 +0100
@@ -100,7 +100,7 @@
.r_action = RTN_UNICAST,
};
-struct hlist_head fib_rules;
+static struct hlist_head fib_rules;
/* writer func called from netlink -- rtnl_sem hold*/
^ permalink raw reply
* [2.6 patch] schedule eepro100.c for removal
From: Adrian Bunk @ 2006-02-03 21:32 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-kernel, netdev
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 18 Jan 2006
--- linux-2.6.15-mm4-full/Documentation/feature-removal-schedule.txt.old 2006-01-18 08:38:57.000000000 +0100
+++ linux-2.6.15-mm4-full/Documentation/feature-removal-schedule.txt 2006-01-18 08:39:59.000000000 +0100
@@ -164,0 +165,6 @@
+---------------------------
+
+What: eepro100 network driver
+When: April 2006
+Why: replaced by the e100 driver
+Who: Adrian Bunk <bunk@stusta.de>
^ permalink raw reply
* Re: [2.6 patch] schedule eepro100.c for removal
From: Benjamin LaHaise @ 2006-02-03 22:18 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Jeff Garzik, linux-kernel, netdev
In-Reply-To: <20060203213234.GS4408@stusta.de>
Where's the hunk to make the eepro100 driver spew messages about being
obsolete out upon loading?
-ben
On Fri, Feb 03, 2006 at 10:32:34PM +0100, Adrian Bunk wrote:
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> ---
>
> This patch was already sent on:
> - 18 Jan 2006
>
> --- linux-2.6.15-mm4-full/Documentation/feature-removal-schedule.txt.old 2006-01-18 08:38:57.000000000 +0100
> +++ linux-2.6.15-mm4-full/Documentation/feature-removal-schedule.txt 2006-01-18 08:39:59.000000000 +0100
> @@ -164,0 +165,6 @@
> +---------------------------
> +
> +What: eepro100 network driver
> +When: April 2006
> +Why: replaced by the e100 driver
> +Who: Adrian Bunk <bunk@stusta.de>
>
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
"Ladies and gentlemen, I'm sorry to interrupt, but the police are here
and they've asked us to stop the party." Don't Email: <dont@kvack.org>.
^ permalink raw reply
* open bugzilla reports
From: Andrew Morton @ 2006-02-03 23:11 UTC (permalink / raw)
To: linux-kernel, video4linux-list, linux-fbdev-devel, linux-fsdevel,
linux1394-devel, netdev, linux-ide, linux-scsi, linux-usb-devel
This is a listing of the 263 bugzilla records which I felt worth keeping an
eye on. It would be appreciated if the various maintenance teams could
take a look, close off any which are fixed and see if we can fix any which
aren't.
There's probably not a lot of point in replying to this email for any
particular bug: please do that within bugzilla and I can update this list
based upon any bugzilla updates.
If you do reply to this email, please trim the cc list to something
appropriate, thanks.
agp/drm/video/X
===============
[Bug 5163] x crashes at startup
http://bugzilla.kernel.org/show_bug.cgi?id=5163
alsa
====
[Bug 5398] ES1988 Allegro-1 : No sound after boot
http://bugzilla.kernel.org/show_bug.cgi?id=5398
[Bug 5420] SiS CMI onboard sound card not working
http://bugzilla.kernel.org/show_bug.cgi?id=5420
[Bug 5523] Alsa Broken on 2.6.14
http://bugzilla.kernel.org/show_bug.cgi?id=5523
[Bug 5568] opl3sa driver broken in 2.6.14
http://bugzilla.kernel.org/show_bug.cgi?id=5568
[Bug 5824] EMU8000 does not depend on SB
http://bugzilla.kernel.org/show_bug.cgi?id=5824
[Bug 5852] emu10k1 doesn't work
http://bugzilla.kernel.org/show_bug.cgi?id=5852
[Bug 5126] No sound on Thinkpad X31 (Intel
http://bugzilla.kernel.org/show_bug.cgi?id=5126
[Bug 5207] Sound system crashes when using the
http://bugzilla.kernel.org/show_bug.cgi?id=5207
[Bug 5828] mplayer093 crash after update to
http://bugzilla.kernel.org/show_bug.cgi?id=5828
[Bug 5892] Impossible to congigure hda_intel
http://bugzilla.kernel.org/show_bug.cgi?id=5892
[Bug 5912] Can't record audio with mencoder
http://bugzilla.kernel.org/show_bug.cgi?id=5912
[Bug 5621] no sound with snd-via82xx after resume
http://bugzilla.kernel.org/show_bug.cgi?id=5621
[Bug 5628] snd_intel8x0 crash with Java application
http://bugzilla.kernel.org/show_bug.cgi?id=5628
[Bug 5634] ALSA fails with SB16 value
http://bugzilla.kernel.org/show_bug.cgi?id=5634
[Bug 5705] cmipci - No 5.1
http://bugzilla.kernel.org/show_bug.cgi?id=5705
[Bug 5723] No sound with SB Live (Chip: SigmaTel
http://bugzilla.kernel.org/show_bug.cgi?id=5723
[Bug 5726] soundblaster live 5.1 soundcard gets
http://bugzilla.kernel.org/show_bug.cgi?id=5726
[Bug 5761] intel hda with some wrong
http://bugzilla.kernel.org/show_bug.cgi?id=5761
[Bug 5763] ali5451 sound module hangs on swsusp
http://bugzilla.kernel.org/show_bug.cgi?id=5763
[Bug 5792] ENS1371 codec read timeout
http://bugzilla.kernel.org/show_bug.cgi?id=5792
[Bug 5937] regression: 2.6.15 and 2.6.16-rc1:
http://bugzilla.kernel.org/show_bug.cgi?id=5937
[Bug 5986] speaker/headphone output selection
http://bugzilla.kernel.org/show_bug.cgi?id=5986
block
=====
[Bug 5485] cdrom door locked when pktcdvd is
http://bugzilla.kernel.org/show_bug.cgi?id=5485
[Bug 5900] Extremely slow sync with anticipatory
http://bugzilla.kernel.org/show_bug.cgi?id=5900
bluetooth
=========
[Bug 5886] Immediate reboot when cancel file
http://bugzilla.kernel.org/show_bug.cgi?id=5886
[Bug 5944] killing hciattach causes kernel oops if
http://bugzilla.kernel.org/show_bug.cgi?id=5944
[Bug 5959] bluetooth CF card is broken by
http://bugzilla.kernel.org/show_bug.cgi?id=5959
core kernel
===========
[Bug 5823] complete freeze
http://bugzilla.kernel.org/show_bug.cgi?id=5823
[Bug 5042] setrlimit/getrlimit broken on 32-bit
http://bugzilla.kernel.org/show_bug.cgi?id=5042
[Bug 5074] /sys/module/*/parameters/* not working
http://bugzilla.kernel.org/show_bug.cgi?id=5074
[Bug 5127] Lost ticks compensation fires when it
http://bugzilla.kernel.org/show_bug.cgi?id=5127
[Bug 5138] 64bit put_unaligned/get_unaligned does
http://bugzilla.kernel.org/show_bug.cgi?id=5138
[Bug 5877] Suspected scheduling starvation
http://bugzilla.kernel.org/show_bug.cgi?id=5877
[Bug 3927] AMD64/ATI : timer is running twice as fast as it should
http://bugzilla.kernel.org/show_bug.cgi?id=3927
[Bug 5645] [ELF] SIGKILL for n*0x1000 sized ELF
http://bugzilla.kernel.org/show_bug.cgi?id=5645
cpufreq
=======
[Bug 5353] cpufreq_conservative: cpu always in
http://bugzilla.kernel.org/show_bug.cgi?id=5353
[Bug 5495] changing cpu frequency causes fatal USB
http://bugzilla.kernel.org/show_bug.cgi?id=5495
[Bug 5553] speedstep-smi fails to load if
http://bugzilla.kernel.org/show_bug.cgi?id=5553
[Bug 5860] ondemand and speedstep-ich fail on
http://bugzilla.kernel.org/show_bug.cgi?id=5860
[Bug 5122] cpufreq/powernowd is still not working
http://bugzilla.kernel.org/show_bug.cgi?id=5122
[Bug 5771] OOPS in libata when scaling cpu
http://bugzilla.kernel.org/show_bug.cgi?id=5771
[Bug 5773] hang on reboot
http://bugzilla.kernel.org/show_bug.cgi?id=5773
[Bug 5779] A very strange bug - possibly a BIOS
http://bugzilla.kernel.org/show_bug.cgi?id=5779
[Bug 5934] System locks if cpufreq set to lowest
http://bugzilla.kernel.org/show_bug.cgi?id=5934
[Bug 5951] Acer Aspire BIOS 3A29 reports to high
http://bugzilla.kernel.org/show_bug.cgi?id=5951
[Bug 5985] speedstep-smi not detecting
http://bugzilla.kernel.org/show_bug.cgi?id=5985
[Bug 6005] can't change cpu frequency on pentium M
http://bugzilla.kernel.org/show_bug.cgi?id=6005
device mapper
=============
[Bug 5297] Memory problem with kcopyd under LVM2 lvremove execution and copying data at the same time.
http://bugzilla.kernel.org/show_bug.cgi?id=5297
[Bug 5733] Oops writing to SATA RAID disks
http://bugzilla.kernel.org/show_bug.cgi?id=5733
[Bug 5948] Oops when accessing loading IDE and
http://bugzilla.kernel.org/show_bug.cgi?id=5948
drm
===
[Bug 5823] complete freeze
http://bugzilla.kernel.org/show_bug.cgi?id=5823
[Bug 5641] Xinerama blocks chipset and GLX fails
http://bugzilla.kernel.org/show_bug.cgi?id=5641
[Bug 5762] sigkill leaves process running with
http://bugzilla.kernel.org/show_bug.cgi?id=5762
dvb
===
[Bug 5228] reboot fails on 2.6.13 when skystar2
http://bugzilla.kernel.org/show_bug.cgi?id=5228
[Bug 5895] With DVB drivers enabled snd_87x (ALSA)
http://bugzilla.kernel.org/show_bug.cgi?id=5895
http://bugzilla.kernel.org/show_bug.cgi?id=5851
[Bug 5902] pluto2 driver in P4 celeron (128kB
http://bugzilla.kernel.org/show_bug.cgi?id=5902
[Bug 5669] sound fix in SAA7134 tv-tuner
http://bugzilla.kernel.org/show_bug.cgi?id=5669
[Bug 5699] saa7134 tuner no longer detected (i2c
http://bugzilla.kernel.org/show_bug.cgi?id=5699
[Bug 5760] No sound with snd_intel8x0 & ALi M5455
http://bugzilla.kernel.org/show_bug.cgi?id=5760
[Bug 5774] saa7134 module doesn't like suspend2
http://bugzilla.kernel.org/show_bug.cgi?id=5774
[Bug 5941] DVB-T Pluto2: When changing from one
http://bugzilla.kernel.org/show_bug.cgi?id=5941
fbdev
=====
[Bug 5482] Black screen with radeonfb
http://bugzilla.kernel.org/show_bug.cgi?id=5482
[Bug 4869] Screen stays blank upon resume
http://bugzilla.kernel.org/show_bug.cgi?id=4869
[Bug 5619] matroxfb: hard lock when switching
http://bugzilla.kernel.org/show_bug.cgi?id=5619
[Bug 5769] Framebuffer breaks after kernel 2.6.12.6
http://bugzilla.kernel.org/show_bug.cgi?id=5769
[Bug 5926] radeonfb somtimes hangs on x300
http://bugzilla.kernel.org/show_bug.cgi?id=5926
fs-misc
=======
[Bug 4821] Heavy load on smbfs gives
http://bugzilla.kernel.org/show_bug.cgi?id=4821
[Bug 4822] smb_allocate_request() possible problem
http://bugzilla.kernel.org/show_bug.cgi?id=4822
[Bug 4497] getdents gives empty/random result upon
http://bugme.osdl.org/show_bug.cgi?id=4497
[Bug 5535] Encountered kernel oops with file
http://bugzilla.kernel.org/show_bug.cgi?id=5535
[Bug 4585] EXT3 CORRUPTION ON BIG VOLUMES
http://bugzilla.kernel.org/show_bug.cgi?id=4585
[Bug 5856] Oops when fs nearly full
http://bugzilla.kernel.org/show_bug.cgi?id=5856
[Bug 5109] kernel BUG in hfsplus
http://bugzilla.kernel.org/show_bug.cgi?id=5109
[Bug 5416] journal block not found
http://bugzilla.kernel.org/show_bug.cgi?id=5416
[Bug 5615] odd cwd behavior
http://bugzilla.kernel.org/show_bug.cgi?id=5615
[Bug 5739] nls_cp936 doesn't handle characters in
http://bugzilla.kernel.org/show_bug.cgi?id=5739
[Bug 5750] NULL POINTER oops after CIFS automount
http://bugzilla.kernel.org/show_bug.cgi?id=5750
[Bug 5079] Possible file date underflow on ext2/3
http://bugzilla.kernel.org/show_bug.cgi?id=5079
[Bug 5954] Client performs retries of NLM_LOCK
http://bugzilla.kernel.org/show_bug.cgi?id=5954
[Bug 5956] Linux client sets block=false in
http://bugzilla.kernel.org/show_bug.cgi?id=5956
[Bug 5984] lockd kernel panic in
http://bugzilla.kernel.org/show_bug.cgi?id=5984
[Bug 6002] quota + 2.6.15.1
http://bugzilla.kernel.org/show_bug.cgi?id=6002
ieee1394
========
[Bug 4779] amd64: raw1394 returns EINVAL
http://bugzilla.kernel.org/show_bug.cgi?id=4779
[Bug 5998] oops on mount "kernel access of bad
http://bugzilla.kernel.org/show_bug.cgi?id=5998
input
=====
[Bug 5386] rmmod usbhid crashes
http://bugzilla.kernel.org/show_bug.cgi?id=5386
[Bug 5408] Wrong keymapping for logitech cordless
http://bugzilla.kernel.org/show_bug.cgi?id=5408
[Bug 5449] bug in psmouse.c "lost synchronization"
http://bugzilla.kernel.org/show_bug.cgi?id=5449
[Bug 5475] USB mouse freezes in X
http://bugzilla.kernel.org/show_bug.cgi?id=5475
[Bug 3830] Touchpad stopped working from 2.6.9 and beyond
http://bugzilla.kernel.org/show_bug.cgi?id=3830
[Bug 5850] grip module crashes system since 2.6.15
http://bugzilla.kernel.org/show_bug.cgi?id=5850
[Bug 5855] kde keeps displaying volume-osd
http://bugzilla.kernel.org/show_bug.cgi?id=5855
[Bug 4981] changes in 2.6.12-rc1 causes ati-remote
http://bugzilla.kernel.org/show_bug.cgi?id=4981
[Bug 5158] ps/2 keyboard on x86_64 does not work
http://bugzilla.kernel.org/show_bug.cgi?id=5158
[Bug 5197] Alps pad fails to reenable dualpoint on
http://bugzilla.kernel.org/show_bug.cgi?id=5197
[Bug 5233] usb hid 'relative' input events
http://bugzilla.kernel.org/show_bug.cgi?id=5233
[Bug 5690] First key pressed never responds
http://bugzilla.kernel.org/show_bug.cgi?id=5690
[Bug 5697] Input via atkbd.c and psmouse.c becomes
http://bugzilla.kernel.org/show_bug.cgi?id=5697
[Bug 5780] multimedia keys shouldn't repead
http://bugzilla.kernel.org/show_bug.cgi?id=5780
[Bug 5932] PS/2 keyboard does not work with
http://bugzilla.kernel.org/show_bug.cgi?id=5932
isdn
====
[Bug 5064] Oops Unable to handle NULL pointer
http://bugzilla.kernel.org/show_bug.cgi?id=5064
kbuild
======
[Bug 5756] ENHANCEMENT PATCH for
http://bugzilla.kernel.org/show_bug.cgi?id=5756
mm
==
[Bug 5665] CPU lockup when hitting OOM on
http://bugzilla.kernel.org/show_bug.cgi?id=5665
[Bug 5493] mprotect usage causing slow system performance and freezing
http://bugzilla.kernel.org/show_bug.cgi?id=5493
net
===
[Bug 5306] Oops on IPv6 route lookup
http://bugzilla.kernel.org/show_bug.cgi?id=5306
[Bug 5438] kernel BUG/Oops triggered by conntrack
http://bugzilla.kernel.org/show_bug.cgi?id=5438
[Bug 5591] KERNEL: assertion
http://bugzilla.kernel.org/show_bug.cgi?id=5591
[Bug 5857] errors in ppp
http://bugzilla.kernel.org/show_bug.cgi?id=5857
[Bug 5869] After pon: Kernel BUG at
http://bugzilla.kernel.org/show_bug.cgi?id=5869
[Bug 5156] llc2: llc_ui_bind() leaves llc->dev NULL
http://bugzilla.kernel.org/show_bug.cgi?id=5156
[Bug 5610] IP MTU Path Discovery now working
http://bugzilla.kernel.org/show_bug.cgi?id=5610
[Bug 5627] Network boot - IP-Config reports wrong
http://bugzilla.kernel.org/show_bug.cgi?id=5627
[Bug 5672] cannot get socket once accept(2) has
http://bugzilla.kernel.org/show_bug.cgi?id=5672
[Bug 5695] pppd hangs after disconnect on
http://bugzilla.kernel.org/show_bug.cgi?id=5695
[Bug 5803] Bridge code Oops with 2.6.14.2
http://bugzilla.kernel.org/show_bug.cgi?id=5803
[Bug 5936] Openswan tunnels + netfilter problem
http://bugzilla.kernel.org/show_bug.cgi?id=5936
[Bug 5946] KERNEL: assertion
http://bugzilla.kernel.org/show_bug.cgi?id=5946
netdev
======
[Bug 5280] Marvell Yukon E8053 pci-express LAN
http://bugzilla.kernel.org/show_bug.cgi?id=5280
[Bug 5379] skge driver turns off 3C940
http://bugzilla.kernel.org/show_bug.cgi?id=5379
[Bug 5527] new e1000 82541PI locks under load
http://bugme.osdl.org/show_bug.cgi?id=5527
[Bug 5806] Wake-On-LAN does not work on VIA
http://bugzilla.kernel.org/show_bug.cgi?id=5806
[Bug 5810] e100 IRQ problem
http://bugzilla.kernel.org/show_bug.cgi?id=5810
[Bug 5827] pppd with MPPE fails
http://bugzilla.kernel.org/show_bug.cgi?id=5827
[Bug 5839] uli526x partially recognizing interface
http://bugzilla.kernel.org/show_bug.cgi?id=5839
[Bug 5842] ipw2100 driver + WPA encryption = crash
http://bugzilla.kernel.org/show_bug.cgi?id=5842
[Bug 5870] SiS 190 doesn't download files
http://bugzilla.kernel.org/show_bug.cgi?id=5870
[Bug 4982] Usenet gateway crashes under heavy
http://bugzilla.kernel.org/show_bug.cgi?id=4982
[Bug 5030] kernel: eth1: Oversized Ethernet frame
http://bugzilla.kernel.org/show_bug.cgi?id=5030
[Bug 5039] high cpu usage (softirq takes 50% all
http://bugzilla.kernel.org/show_bug.cgi?id=5039
[Bug 5080] bonding related oops on boot
http://bugzilla.kernel.org/show_bug.cgi?id=5080
[Bug 5137] r8169 - network dies.
http://bugzilla.kernel.org/show_bug.cgi?id=5137
[Bug 5204] sk98lin driver blocks NIC for BIOS/dual
http://bugzilla.kernel.org/show_bug.cgi?id=5204
[Bug 5890] Driver sk98lin not working (no
http://bugzilla.kernel.org/show_bug.cgi?id=5890
[Bug 5896] [sk98lin] vpd errors on dfi lanparty ut
http://bugzilla.kernel.org/show_bug.cgi?id=5896
[Bug 5609] e1000, 2.6.1[34] - WOL not working
http://bugzilla.kernel.org/show_bug.cgi?id=5609
[Bug 5681] 8139cp has broken suspend/resume
http://bugzilla.kernel.org/show_bug.cgi?id=5681
[Bug 5698] IPW2100 driver loosing association with
http://bugzilla.kernel.org/show_bug.cgi?id=5698
[Bug 5711] ipw2200: NETDEV_TX_BUSY returned;
http://bugzilla.kernel.org/show_bug.cgi?id=5711
[Bug 5714] can't configure IPW2200 Monitor mode
http://bugzilla.kernel.org/show_bug.cgi?id=5714
[Bug 5718] NIC dont work with Toshiba Satellite
http://bugzilla.kernel.org/show_bug.cgi?id=5718
[Bug 5924] Starfire interface stopped working
http://bugzilla.kernel.org/show_bug.cgi?id=5924
[Bug 5927] TG3 driver unable to get memory resource
http://bugzilla.kernel.org/show_bug.cgi?id=5927
[Bug 5785] allocation failure and dead skge
http://bugzilla.kernel.org/show_bug.cgi?id=5785
[Bug 5940] ipw2100 version incompatible with
http://bugzilla.kernel.org/show_bug.cgi?id=5940
[Bug 5947] r8169 Losing some ticks
http://bugzilla.kernel.org/show_bug.cgi?id=5947
[Bug 5965] Problems with Intel Pro 1000 (82545GM)
http://bugzilla.kernel.org/show_bug.cgi?id=5965
[Bug 5973] Yukon / Marvell driver in kernel
http://bugzilla.kernel.org/show_bug.cgi?id=5973
[Bug 5992] r8169 driver - no network connection,
http://bugzilla.kernel.org/show_bug.cgi?id=5992
parport
=======
[Bug 5796] If the printer is turned off,
http://bugzilla.kernel.org/show_bug.cgi?id=5796
[Bug 4983] Paralell ZIP disappearing
http://bugzilla.kernel.org/show_bug.cgi?id=4983
pata
====
[Bug 5472] pktcdvd avoid to read iso9660 DVDs.
http://bugzilla.kernel.org/show_bug.cgi?id=5472
[Bug 5577] permanent compact flash change
http://bugzilla.kernel.org/show_bug.cgi?id=5577
[Bug 5581] CD DMA timout panic in ide-iops.c
http://bugzilla.kernel.org/show_bug.cgi?id=5581
[Bug 5371] Really slow dvd burning
http://bugzilla.kernel.org/show_bug.cgi?id=5371
[Bug 5880] Transcend CF pcmcia card no longer works
http://bugzilla.kernel.org/show_bug.cgi?id=5880
[Bug 5159] BUG: soft lockup detected on CPU#0!
http://bugzilla.kernel.org/show_bug.cgi?id=5159
[Bug 5911] siimage.c interrupts screaming
http://bugzilla.kernel.org/show_bug.cgi?id=5911
[Bug 5919] kernel: ata1: command 0x25 timeout,
http://bugzilla.kernel.org/show_bug.cgi?id=5919
[Bug 5599] HDIO_GET_ACOUSTIC failed: Inappropriate
http://bugzilla.kernel.org/show_bug.cgi?id=5599
[Bug 5673] hda and ide0 errors on resume from acpi
http://bugzilla.kernel.org/show_bug.cgi?id=5673
[Bug 5759] ATIIXP driver does not detect some MDMA
http://bugzilla.kernel.org/show_bug.cgi?id=5759
[Bug 5786] DMA access to CD-writer hangs IDE bus
http://bugzilla.kernel.org/show_bug.cgi?id=5786
[Bug 5928] problem reading files with ide-tape
http://bugzilla.kernel.org/show_bug.cgi?id=5928
[Bug 5929] DMA not working on ATAPI HL-DT-ST
http://bugzilla.kernel.org/show_bug.cgi?id=5929
[Bug 5938] Boot stalls on loading ide-cd. Crashed
http://bugzilla.kernel.org/show_bug.cgi?id=5938
[Bug 5901] Resume from suspend-to-memory worked in
http://bugzilla.kernel.org/show_bug.cgi?id=5901
pci
===
[Bug 5587] Toshiba M200 PCI fails to allocate
http://bugzilla.kernel.org/show_bug.cgi?id=5587
[Bug 5736] pci broken on PIIX/ICH laptop
http://bugzilla.kernel.org/show_bug.cgi?id=5736
pcmcia/cardbus
==============
[Bug 5569] xirc2ps_cs based pcmcia card stopped
http://bugzilla.kernel.org/show_bug.cgi?id=5569
[Bug 5062] kernel preemption breaks in several ways
http://bugzilla.kernel.org/show_bug.cgi?id=5062
[Bug 5848] pcmcia novatel merlin u530 not working
http://bugzilla.kernel.org/show_bug.cgi?id=5848
power management
================
[Bug 4919] APM resume: freeze at disk access
http://bugzilla.kernel.org/show_bug.cgi?id=4919
powerpc
=======
[Bug 5679] Kernel fails to boot
http://bugzilla.kernel.org/show_bug.cgi?id=5679
[Bug 5689] java crashes "JVMDG218: JVM is not
http://bugzilla.kernel.org/show_bug.cgi?id=5689
sata
====
[Bug 4860] sata_sx4 doesn't recognize Promise
http://bugzilla.kernel.org/show_bug.cgi?id=4860
[Bug 4920] IDE CD Driver not able to read audio
http://bugzilla.kernel.org/show_bug.cgi?id=4920
[Bug 5533] sata_via unable to see my Plextor 716SA
http://bugzilla.kernel.org/show_bug.cgi?id=5533
[Bug 5586] mv_sata doesn't detect any disk and
http://bugzilla.kernel.org/show_bug.cgi?id=5586
[Bug 5589] libata - Oops when sata drive under load
http://bugzilla.kernel.org/show_bug.cgi?id=5589
[Bug 5798] PLEXTOR 716sa SATA
http://bugzilla.kernel.org/show_bug.cgi?id=5798
[Bug 5863] ata_piix disables SATA drives at boot
http://bugzilla.kernel.org/show_bug.cgi?id=5863
[Bug 4968] sata_nv buffer I/O errors
http://bugzilla.kernel.org/show_bug.cgi?id=4968
[Bug 5047] sata hangs (Silicon Image and seagate
http://bugzilla.kernel.org/show_bug.cgi?id=5047
[Bug 5905] status=0x50 errors with SATA drives
http://bugzilla.kernel.org/show_bug.cgi?id=5905
[Bug 5914] recent davej kernels (2.6.15-git*-base)
http://bugzilla.kernel.org/show_bug.cgi?id=5914
[Bug 5596] Kernel panic on sata_mv driver durring
http://bugzilla.kernel.org/show_bug.cgi?id=5596
[Bug 5654] Serial Ata 3512a in 2.6.14
http://bugzilla.kernel.org/show_bug.cgi?id=5654
[Bug 5664] Data Corruption with Kernel Version
http://bugzilla.kernel.org/show_bug.cgi?id=5664
[Bug 5700] Panic: Fatal exception in interrupt w/
http://bugzilla.kernel.org/show_bug.cgi?id=5700
[Bug 5709] sata_promise: missing pci id for
http://bugzilla.kernel.org/show_bug.cgi?id=5709
[Bug 5721] libata does not report detailed info in
http://bugzilla.kernel.org/show_bug.cgi?id=5721
[Bug 5722] Buffer I/O error on device sr0,
http://bugzilla.kernel.org/show_bug.cgi?id=5722
[Bug 5922] sata_uli fails to see harddisks on PCI
http://bugzilla.kernel.org/show_bug.cgi?id=5922
[Bug 5789] ATAPI isn't working on sata-via
http://bugzilla.kernel.org/show_bug.cgi?id=5789
[Bug 5931] Oops when calling hddtemp on sata drive
http://bugzilla.kernel.org/show_bug.cgi?id=5931
[Bug 5969] IDE driver can't detect any hdd through
http://bugzilla.kernel.org/show_bug.cgi?id=5969
[Bug 5948] Oops when accessing SATA with device mapper on AMD 64 X2
http://bugzilla.kernel.org/show_bug.cgi?id=5948
[Bug 5987] Oopses at boot,
http://bugzilla.kernel.org/show_bug.cgi?id=5987
[Bug 5995] RAID with SATA fails on drive un-plug
http://bugzilla.kernel.org/show_bug.cgi?id=5995
scsi
====
[Bug 4880] dpt_i2o.c does not register itself with
http://bugzilla.kernel.org/show_bug.cgi?id=4880
[Bug 4929] problem with aic7xxx driver on 2.6.x
http://bugzilla.kernel.org/show_bug.cgi?id=4929
[Bug 5268] aic79xx scsi driver causing system to
http://bugzilla.kernel.org/show_bug.cgi?id=5268
[Bug 5378] aic7xxx deadlock/freeze on Adaptec
http://bugzilla.kernel.org/show_bug.cgi?id=5378
[Bug 5440] Perc4 megaraid: module doesn't detect
http://bugzilla.kernel.org/show_bug.cgi?id=5440
[Bug 5531] SCSI SR_MOD Doesn't Recognize CD after
http://bugzilla.kernel.org/show_bug.cgi?id=5531
[Bug 5566] scsi_eh_x/scsi_wq_x "zombie" processes
http://bugzilla.kernel.org/show_bug.cgi?id=5566
[Bug 5795] kernel boot oops
http://bugzilla.kernel.org/show_bug.cgi?id=5795
[Bug 5808] aic7xxx - half speed/frequency
http://bugzilla.kernel.org/show_bug.cgi?id=5808
[Bug 5154] 2.6.13 crashes on heavy used server
http://bugzilla.kernel.org/show_bug.cgi?id=5154
[Bug 5887] Erratic messages for a CDROM
http://bugzilla.kernel.org/show_bug.cgi?id=5887
[Bug 5910] tar to tape-drive kills keyboard,
http://bugzilla.kernel.org/show_bug.cgi?id=5910
[Bug 5921] SCSI bus crash when formating CDRW
http://bugzilla.kernel.org/show_bug.cgi?id=5921
[Bug 5656] system freeze
http://bugzilla.kernel.org/show_bug.cgi?id=5656
=?iso-8859-1?q?=5BBug_5659=5D_New=3A_Can=B4t_copy_fi?=
http://bugzilla.kernel.org/show_bug.cgi?id=5659
[Bug 5685] Symbios Logic 53c1030 Driver Not Running
http://bugzilla.kernel.org/show_bug.cgi?id=5685
[Bug 5712] mptscsih: ioc0: task abort messages at
http://bugzilla.kernel.org/show_bug.cgi?id=5712
[Bug 5735] System boot hangs Adaptec 2100S card
http://bugzilla.kernel.org/show_bug.cgi?id=5735
[Bug 5738] ahci + software raid (intel E7221,
http://bugzilla.kernel.org/show_bug.cgi?id=5738
[Bug 5755] 16 byte CDBs not enabled in Adaptec
http://bugzilla.kernel.org/show_bug.cgi?id=5755
[Bug 5775] when a scsi device is plugged in again,
http://bugzilla.kernel.org/show_bug.cgi?id=5775
[Bug 5776] initio: Kernel crash while launching
http://bugzilla.kernel.org/show_bug.cgi?id=5776
[Bug 5953] easyRAID F8 IDE2SCSI adaptor problems
http://bugzilla.kernel.org/show_bug.cgi?id=5953
[Bug 5955] Speed negotiation between scsi driver
http://bugzilla.kernel.org/show_bug.cgi?id=5955
sensors
=======
[Bug 5981] it87 chassis fan speed not reported,
http://bugzilla.kernel.org/show_bug.cgi?id=5981
serial
======
[Bug 5832] Enabling ACPI Plug and Play in kernels
http://bugzilla.kernel.org/show_bug.cgi?id=5832
[Bug 5875] quad RS232 port card detected as 8,
http://bugzilla.kernel.org/show_bug.cgi?id=5875
[Bug 5942] serial driver gives up and we get IRQ3
http://bugzilla.kernel.org/show_bug.cgi?id=5942
[Bug 5958] CF bluetooth card oopses machine when
http://bugzilla.kernel.org/show_bug.cgi?id=5958
suspend/resume
==============
[Bug 5528] iBook 14'' 1.42 Ghz sleep,
http://bugme.osdl.org/show_bug.cgi?id=5528
[Bug 5945] "scheduling while atomic" during wakeup
http://bugzilla.kernel.org/show_bug.cgi?id=5945
swsusp
======
[Bug 5671] pci=routeirq required for successful
http://bugzilla.kernel.org/show_bug.cgi?id=5671
time management
===============
[Bug 5366] synchronize_tsc_bp can zero the TSC
http://bugzilla.kernel.org/show_bug.cgi?id=5366
[Bug 5740] tsc ocassionally counts back with dual
http://bugzilla.kernel.org/show_bug.cgi?id=5740
usb
=====
[Bug 4776] uhci_hcd: host controller halted,
http://bugzilla.kernel.org/show_bug.cgi?id=4776
[Bug 4916] USB mouse stops working after inserting
http://bugzilla.kernel.org/show_bug.cgi?id=4916
[Bug 4917] Lacie 250Go USB
http://bugzilla.kernel.org/show_bug.cgi?id=4917
[Bug 5349] USB card detected,
http://bugzilla.kernel.org/show_bug.cgi?id=5349
[Bug 5541] oops in drivers/usb/ipaq when
http://bugzilla.kernel.org/show_bug.cgi?id=5541
[Bug 5835] High Speed USB devices don't work when
http://bugzilla.kernel.org/show_bug.cgi?id=5835
[Bug 5836] USB disconnect/connect continuously
http://bugzilla.kernel.org/show_bug.cgi?id=5836
[Bug 4966] ehci_hcd on x86_64 causes more than
http://bugzilla.kernel.org/show_bug.cgi?id=4966
[Bug 5086] unplugging webcam when stv680 is in use
http://bugzilla.kernel.org/show_bug.cgi?id=5086
[Bug 5143] USB HID,
http://bugzilla.kernel.org/show_bug.cgi?id=5143
[Bug 5164] pl2303 when unplugged while device is
http://bugzilla.kernel.org/show_bug.cgi?id=5164
[Bug 5215] USB OHCI pci card can not enable usb
http://bugzilla.kernel.org/show_bug.cgi?id=5215
[Bug 5253] usb storage disappears after hotplug
http://bugzilla.kernel.org/show_bug.cgi?id=5253
[Bug 5874] 2.6.15: USB vibration feedback gamepad
http://bugzilla.kernel.org/show_bug.cgi?id=5874
[Bug 5876] w9968cf oopses with creative webcam go
http://bugzilla.kernel.org/show_bug.cgi?id=5876
[Bug 5913] USB enclosure doesn't work
http://bugzilla.kernel.org/show_bug.cgi?id=5913
[Bug 5920] USB vibration feedback gamepad problem
http://bugzilla.kernel.org/show_bug.cgi?id=5920
[Bug 5600] suspend to disk and suspend to RAM
http://bugzilla.kernel.org/show_bug.cgi?id=5600
[Bug 5640] System doesn' shutdown when a device is
http://bugzilla.kernel.org/show_bug.cgi?id=5640
[Bug 5642] ohci_hcd temporary freeze on nForce4
http://bugzilla.kernel.org/show_bug.cgi?id=5642
[Bug 5652] Built in card reader doesn't work
http://bugzilla.kernel.org/show_bug.cgi?id=5652
[Bug 5682] USB hard drive disconnects
http://bugzilla.kernel.org/show_bug.cgi?id=5682
[Bug 5684] VT6205-DevH SD card reader (USB) will
http://bugzilla.kernel.org/show_bug.cgi?id=5684
[Bug 5730] FTDI USB serial adaptor problems
http://bugzilla.kernel.org/show_bug.cgi?id=5730
[Bug 5742] Suspend resume does not work on
http://bugzilla.kernel.org/show_bug.cgi?id=5742
[Bug 5744] usbnet connection to sharp zaurus
http://bugzilla.kernel.org/show_bug.cgi?id=5744
[Bug 5753] Problem initializing CSR bluetooth
http://bugzilla.kernel.org/show_bug.cgi?id=5753
[Bug 5777] ehci-hcd re-load necessary to use kbd
http://bugzilla.kernel.org/show_bug.cgi?id=5777
[Bug 5788] ASUS A6k Notebook hangs on boot while
http://bugzilla.kernel.org/show_bug.cgi?id=5788
[Bug 5935] boot process hangs in pci_init,
http://bugzilla.kernel.org/show_bug.cgi?id=5935
[Bug 5967] Novatel Wireless CDMA Card (V620)
http://bugzilla.kernel.org/show_bug.cgi?id=5967
[Bug 5974] if usb-storage atached - ps/2 keyboard
http://bugzilla.kernel.org/show_bug.cgi?id=5974
[Bug 5997] usbhid driver disable the Mouse and
http://bugzilla.kernel.org/show_bug.cgi?id=5997
x86
===
[Bug 5565] Guess of i386 APIC PTE area scribble
http://bugzilla.kernel.org/show_bug.cgi?id=5565
[Bug 5620] gcc miscompiles code using i386
http://bugzilla.kernel.org/show_bug.cgi?id=5620
[Bug 5636] Totally bogus BogoMips when
http://bugzilla.kernel.org/show_bug.cgi?id=5636
x86_64
======
[Bug 5343] IOMMU setup broken 2.6.13.2 -> 2.6.14-rc2
http://bugzilla.kernel.org/show_bug.cgi?id=5343
[Bug 5522] Timer going backward on an AMD64 dual
http://bugzilla.kernel.org/show_bug.cgi?id=5522
[Bug 5752] Dual Opteron - Memory missing
http://bugzilla.kernel.org/show_bug.cgi?id=5752
^ permalink raw reply
* [2.6 patch] move some code to net/ipx/af_ipx.c
From: Adrian Bunk @ 2006-02-04 1:09 UTC (permalink / raw)
To: Andrew Morton; +Cc: acme, linux-kernel, netdev
This patch moves some code only used in this file to net/ipx/af_ipx.c .
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 22 Jan 2006
- 14 Jan 2006
include/net/p8022.h | 13 -----
net/802/Makefile | 14 ++---
net/802/p8022.c | 66 ---------------------------
net/802/p8023.c | 61 -------------------------
net/8021q/vlan.c | 1
net/8021q/vlan_dev.c | 1
net/ethernet/Makefile | 2
net/ethernet/pe2.c | 39 ----------------
net/ipx/af_ipx.c | 102 ++++++++++++++++++++++++++++++++++++++++--
9 files changed, 106 insertions(+), 193 deletions(-)
--- linux-2.6.15-rc1-mm1-full/net/ethernet/Makefile.old 2005-11-18 02:15:17.000000000 +0100
+++ linux-2.6.15-rc1-mm1-full/net/ethernet/Makefile 2005-11-18 02:15:22.000000000 +0100
@@ -4,5 +4,3 @@
obj-y += eth.o
obj-$(CONFIG_SYSCTL) += sysctl_net_ether.o
-obj-$(subst m,y,$(CONFIG_IPX)) += pe2.o
-obj-$(subst m,y,$(CONFIG_ATALK)) += pe2.o
--- linux-2.6.15-rc1-mm1-full/net/8021q/vlan.c.old 2005-11-18 02:19:40.000000000 +0100
+++ linux-2.6.15-rc1-mm1-full/net/8021q/vlan.c 2005-11-18 02:19:46.000000000 +0100
@@ -26,7 +26,6 @@
#include <linux/mm.h>
#include <linux/in.h>
#include <linux/init.h>
-#include <net/p8022.h>
#include <net/arp.h>
#include <linux/rtnetlink.h>
#include <linux/notifier.h>
--- linux-2.6.15-rc1-mm1-full/net/8021q/vlan_dev.c.old 2005-11-18 02:19:55.000000000 +0100
+++ linux-2.6.15-rc1-mm1-full/net/8021q/vlan_dev.c 2005-11-18 02:19:58.000000000 +0100
@@ -29,7 +29,6 @@
#include <linux/netdevice.h>
#include <linux/etherdevice.h>
#include <net/datalink.h>
-#include <net/p8022.h>
#include <net/arp.h>
#include "vlan.h"
--- linux-2.6.15-rc1-mm1-full/net/ipx/af_ipx.c.old 2005-11-18 02:17:00.000000000 +0100
+++ linux-2.6.15-rc1-mm1-full/net/ipx/af_ipx.c 2005-11-18 02:26:01.000000000 +0100
@@ -48,10 +48,10 @@
#include <linux/termios.h>
#include <net/ipx.h>
-#include <net/p8022.h>
#include <net/psnap.h>
#include <net/sock.h>
#include <net/tcp_states.h>
+#include <net/llc.h>
#include <asm/uaccess.h>
@@ -1939,8 +1939,104 @@
.notifier_call = ipxitf_device_event,
};
-extern struct datalink_proto *make_EII_client(void);
-extern void destroy_EII_client(struct datalink_proto *);
+static int p8022_request(struct datalink_proto *dl, struct sk_buff *skb,
+ unsigned char *dest)
+{
+ llc_build_and_send_ui_pkt(dl->sap, skb, dest, dl->sap->laddr.lsap);
+ return 0;
+}
+
+static struct datalink_proto *register_8022_client(unsigned char type,
+ int (*func)(struct sk_buff *skb,
+ struct net_device *dev,
+ struct packet_type *pt,
+ struct net_device *orig_dev))
+{
+ struct datalink_proto *proto;
+
+ proto = kmalloc(sizeof(*proto), GFP_ATOMIC);
+ if (proto) {
+ proto->type[0] = type;
+ proto->header_length = 3;
+ proto->request = p8022_request;
+ proto->sap = llc_sap_open(type, func);
+ if (!proto->sap) {
+ kfree(proto);
+ proto = NULL;
+ }
+ }
+ return proto;
+}
+
+static void unregister_8022_client(struct datalink_proto *proto)
+{
+ llc_sap_put(proto->sap);
+ kfree(proto);
+}
+
+/*
+ * Place an 802.3 header on a packet. The driver will do the mac
+ * addresses, we just need to give it the buffer length.
+ */
+static int p8023_request(struct datalink_proto *dl,
+ struct sk_buff *skb, unsigned char *dest_node)
+{
+ struct net_device *dev = skb->dev;
+
+ dev->hard_header(skb, dev, ETH_P_802_3, dest_node, NULL, skb->len);
+ return dev_queue_xmit(skb);
+}
+
+/*
+ * Create an 802.3 client. Note there can be only one 802.3 client
+ */
+static struct datalink_proto *make_8023_client(void)
+{
+ struct datalink_proto *proto = kmalloc(sizeof(*proto), GFP_ATOMIC);
+
+ if (proto) {
+ proto->header_length = 0;
+ proto->request = p8023_request;
+ }
+ return proto;
+}
+
+/*
+ * Destroy the 802.3 client.
+ */
+static void destroy_8023_client(struct datalink_proto *dl)
+{
+ kfree(dl);
+}
+
+static int pEII_request(struct datalink_proto *dl,
+ struct sk_buff *skb, unsigned char *dest_node)
+{
+ struct net_device *dev = skb->dev;
+
+ skb->protocol = htons(ETH_P_IPX);
+ if (dev->hard_header)
+ dev->hard_header(skb, dev, ETH_P_IPX,
+ dest_node, NULL, skb->len);
+ return dev_queue_xmit(skb);
+}
+
+static struct datalink_proto *make_EII_client(void)
+{
+ struct datalink_proto *proto = kmalloc(sizeof(*proto), GFP_ATOMIC);
+
+ if (proto) {
+ proto->header_length = 0;
+ proto->request = pEII_request;
+ }
+
+ return proto;
+}
+
+static void destroy_EII_client(struct datalink_proto *dl)
+{
+ kfree(dl);
+}
static unsigned char ipx_8022_type = 0xE0;
static unsigned char ipx_snap_id[5] = { 0x0, 0x0, 0x0, 0x81, 0x37 };
--- linux-2.6.15-rc1-mm1-full/include/net/p8022.h 2005-10-28 02:02:08.000000000 +0200
+++ /dev/null 2005-11-08 19:07:57.000000000 +0100
@@ -1,13 +0,0 @@
-#ifndef _NET_P8022_H
-#define _NET_P8022_H
-extern struct datalink_proto *
- register_8022_client(unsigned char type,
- int (*func)(struct sk_buff *skb,
- struct net_device *dev,
- struct packet_type *pt,
- struct net_device *orig_dev));
-extern void unregister_8022_client(struct datalink_proto *proto);
-
-extern struct datalink_proto *make_8023_client(void);
-extern void destroy_8023_client(struct datalink_proto *dl);
-#endif
--- linux-2.6.15-rc1-mm1-full/net/ethernet/pe2.c 2005-11-17 21:30:56.000000000 +0100
+++ /dev/null 2005-11-08 19:07:57.000000000 +0100
@@ -1,39 +0,0 @@
-#include <linux/in.h>
-#include <linux/mm.h>
-#include <linux/module.h>
-#include <linux/netdevice.h>
-#include <linux/skbuff.h>
-
-#include <net/datalink.h>
-
-static int pEII_request(struct datalink_proto *dl,
- struct sk_buff *skb, unsigned char *dest_node)
-{
- struct net_device *dev = skb->dev;
-
- skb->protocol = htons(ETH_P_IPX);
- if (dev->hard_header)
- dev->hard_header(skb, dev, ETH_P_IPX,
- dest_node, NULL, skb->len);
- return dev_queue_xmit(skb);
-}
-
-struct datalink_proto *make_EII_client(void)
-{
- struct datalink_proto *proto = kmalloc(sizeof(*proto), GFP_ATOMIC);
-
- if (proto) {
- proto->header_length = 0;
- proto->request = pEII_request;
- }
-
- return proto;
-}
-
-void destroy_EII_client(struct datalink_proto *dl)
-{
- kfree(dl);
-}
-
-EXPORT_SYMBOL(destroy_EII_client);
-EXPORT_SYMBOL(make_EII_client);
--- linux-2.6.15-rc1-mm1-full/net/802/p8022.c 2005-10-28 02:02:08.000000000 +0200
+++ /dev/null 2005-11-08 19:07:57.000000000 +0100
@@ -1,66 +0,0 @@
-/*
- * NET3: Support for 802.2 demultiplexing off Ethernet (Token ring
- * is kept separate see p8022tr.c)
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License
- * as published by the Free Software Foundation; either version
- * 2 of the License, or (at your option) any later version.
- *
- * Demultiplex 802.2 encoded protocols. We match the entry by the
- * SSAP/DSAP pair and then deliver to the registered datalink that
- * matches. The control byte is ignored and handling of such items
- * is up to the routine passed the frame.
- *
- * Unlike the 802.3 datalink we have a list of 802.2 entries as
- * there are multiple protocols to demux. The list is currently
- * short (3 or 4 entries at most). The current demux assumes this.
- */
-#include <linux/module.h>
-#include <linux/netdevice.h>
-#include <linux/skbuff.h>
-#include <net/datalink.h>
-#include <linux/mm.h>
-#include <linux/in.h>
-#include <linux/init.h>
-#include <net/llc.h>
-#include <net/p8022.h>
-
-static int p8022_request(struct datalink_proto *dl, struct sk_buff *skb,
- unsigned char *dest)
-{
- llc_build_and_send_ui_pkt(dl->sap, skb, dest, dl->sap->laddr.lsap);
- return 0;
-}
-
-struct datalink_proto *register_8022_client(unsigned char type,
- int (*func)(struct sk_buff *skb,
- struct net_device *dev,
- struct packet_type *pt,
- struct net_device *orig_dev))
-{
- struct datalink_proto *proto;
-
- proto = kmalloc(sizeof(*proto), GFP_ATOMIC);
- if (proto) {
- proto->type[0] = type;
- proto->header_length = 3;
- proto->request = p8022_request;
- proto->sap = llc_sap_open(type, func);
- if (!proto->sap) {
- kfree(proto);
- proto = NULL;
- }
- }
- return proto;
-}
-
-void unregister_8022_client(struct datalink_proto *proto)
-{
- llc_sap_put(proto->sap);
- kfree(proto);
-}
-
-EXPORT_SYMBOL(register_8022_client);
-EXPORT_SYMBOL(unregister_8022_client);
-
-MODULE_LICENSE("GPL");
--- linux-2.6.15-rc1-mm1-full/net/802/p8023.c 2005-11-17 21:30:55.000000000 +0100
+++ /dev/null 2005-11-08 19:07:57.000000000 +0100
@@ -1,61 +0,0 @@
-/*
- * NET3: 802.3 data link hooks used for IPX 802.3
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License
- * as published by the Free Software Foundation; either version
- * 2 of the License, or (at your option) any later version.
- *
- * 802.3 isn't really a protocol data link layer. Some old IPX stuff
- * uses it however. Note that there is only one 802.3 protocol layer
- * in the system. We don't currently support different protocols
- * running raw 802.3 on different devices. Thankfully nobody else
- * has done anything like the old IPX.
- */
-
-#include <linux/in.h>
-#include <linux/mm.h>
-#include <linux/module.h>
-#include <linux/netdevice.h>
-#include <linux/skbuff.h>
-
-#include <net/datalink.h>
-#include <net/p8022.h>
-
-/*
- * Place an 802.3 header on a packet. The driver will do the mac
- * addresses, we just need to give it the buffer length.
- */
-static int p8023_request(struct datalink_proto *dl,
- struct sk_buff *skb, unsigned char *dest_node)
-{
- struct net_device *dev = skb->dev;
-
- dev->hard_header(skb, dev, ETH_P_802_3, dest_node, NULL, skb->len);
- return dev_queue_xmit(skb);
-}
-
-/*
- * Create an 802.3 client. Note there can be only one 802.3 client
- */
-struct datalink_proto *make_8023_client(void)
-{
- struct datalink_proto *proto = kmalloc(sizeof(*proto), GFP_ATOMIC);
-
- if (proto) {
- proto->header_length = 0;
- proto->request = p8023_request;
- }
- return proto;
-}
-
-/*
- * Destroy the 802.3 client.
- */
-void destroy_8023_client(struct datalink_proto *dl)
-{
- kfree(dl);
-}
-
-EXPORT_SYMBOL(destroy_8023_client);
-EXPORT_SYMBOL(make_8023_client);
--- linux-2.6.15-mm3-full/net/802/Makefile.old 2006-01-14 02:55:28.000000000 +0100
+++ linux-2.6.15-mm3-full/net/802/Makefile 2006-01-14 02:55:50.000000000 +0100
@@ -4,10 +4,10 @@
# Check the p8022 selections against net/core/Makefile.
obj-$(CONFIG_SYSCTL) += sysctl_net_802.o
-obj-$(CONFIG_LLC) += p8022.o psnap.o
-obj-$(CONFIG_TR) += p8022.o psnap.o tr.o sysctl_net_802.o
-obj-$(CONFIG_NET_FC) += fc.o
-obj-$(CONFIG_FDDI) += fddi.o
-obj-$(CONFIG_HIPPI) += hippi.o
-obj-$(CONFIG_IPX) += p8022.o psnap.o p8023.o
-obj-$(CONFIG_ATALK) += p8022.o psnap.o
+obj-$(CONFIG_LLC) += psnap.o
+obj-$(CONFIG_TR) += psnap.o tr.o sysctl_net_802.o
+obj-$(CONFIG_NET_FC) += fc.o
+obj-$(CONFIG_FDDI) += fddi.o
+obj-$(CONFIG_HIPPI) += hippi.o
+obj-$(CONFIG_IPX) += psnap.o
+obj-$(CONFIG_ATALK) += psnap.o
^ permalink raw reply
* [2.6 patch] net/tipc/: possible cleanups
From: Adrian Bunk @ 2006-02-04 1:10 UTC (permalink / raw)
To: Andrew Morton
Cc: per.liden, jon.maloy, allan.stephens, tipc-discussion,
linux-kernel, netdev
This patch contains the following possible cleanups:
- make needlessly global code static
- #if 0 the following unused global functions:
- name_table.c: tipc_nametbl_print()
- name_table.c: tipc_nametbl_dump()
- net.c: tipc_net_next_node()
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 26 Jan 2006
net/tipc/bcast.c | 9 +++++----
net/tipc/cluster.c | 11 +++++------
net/tipc/discover.c | 8 ++++----
net/tipc/name_table.c | 27 ++++++++++++++++++---------
net/tipc/net.c | 3 ++-
net/tipc/node.c | 2 +-
6 files changed, 35 insertions(+), 25 deletions(-)
--- linux-2.6.16-rc1-mm3-full/net/tipc/bcast.c.old 2006-01-26 06:56:41.000000000 +0100
+++ linux-2.6.16-rc1-mm3-full/net/tipc/bcast.c 2006-01-26 06:57:33.000000000 +0100
@@ -314,7 +314,8 @@
* Only tipc_net_lock set.
*/
-void tipc_bclink_peek_nack(u32 dest, u32 sender_tag, u32 gap_after, u32 gap_to)
+static void tipc_bclink_peek_nack(u32 dest, u32 sender_tag, u32 gap_after,
+ u32 gap_to)
{
struct node *n_ptr = tipc_node_find(dest);
u32 my_after, my_to;
@@ -525,9 +526,9 @@
* Returns 0 if packet sent successfully, non-zero if not
*/
-int tipc_bcbearer_send(struct sk_buff *buf,
- struct tipc_bearer *unused1,
- struct tipc_media_addr *unused2)
+static int tipc_bcbearer_send(struct sk_buff *buf,
+ struct tipc_bearer *unused1,
+ struct tipc_media_addr *unused2)
{
static int send_count = 0;
--- linux-2.6.16-rc1-mm3-full/net/tipc/cluster.c.old 2006-01-26 06:57:51.000000000 +0100
+++ linux-2.6.16-rc1-mm3-full/net/tipc/cluster.c 2006-01-26 06:58:31.000000000 +0100
@@ -44,9 +44,8 @@
#include "msg.h"
#include "bearer.h"
-void tipc_cltr_multicast(struct cluster *c_ptr, struct sk_buff *buf,
- u32 lower, u32 upper);
-struct sk_buff *tipc_cltr_prepare_routing_msg(u32 data_size, u32 dest);
+static void tipc_cltr_multicast(struct cluster *c_ptr, struct sk_buff *buf,
+ u32 lower, u32 upper);
struct node **tipc_local_nodes = 0;
struct node_map tipc_cltr_bcast_nodes = {0,{0,}};
@@ -229,7 +228,7 @@
* Routing table management: See description in node.c
*/
-struct sk_buff *tipc_cltr_prepare_routing_msg(u32 data_size, u32 dest)
+static struct sk_buff *tipc_cltr_prepare_routing_msg(u32 data_size, u32 dest)
{
u32 size = INT_H_SIZE + data_size;
struct sk_buff *buf = buf_acquire(size);
@@ -495,8 +494,8 @@
* tipc_cltr_multicast - multicast message to local nodes
*/
-void tipc_cltr_multicast(struct cluster *c_ptr, struct sk_buff *buf,
- u32 lower, u32 upper)
+static void tipc_cltr_multicast(struct cluster *c_ptr, struct sk_buff *buf,
+ u32 lower, u32 upper)
{
struct sk_buff *buf_copy;
struct node *n_ptr;
--- linux-2.6.16-rc1-mm3-full/net/tipc/discover.c.old 2006-01-26 06:59:53.000000000 +0100
+++ linux-2.6.16-rc1-mm3-full/net/tipc/discover.c 2006-01-26 07:00:05.000000000 +0100
@@ -110,10 +110,10 @@
* @b_ptr: ptr to bearer issuing message
*/
-struct sk_buff *tipc_disc_init_msg(u32 type,
- u32 req_links,
- u32 dest_domain,
- struct bearer *b_ptr)
+static struct sk_buff *tipc_disc_init_msg(u32 type,
+ u32 req_links,
+ u32 dest_domain,
+ struct bearer *b_ptr)
{
struct sk_buff *buf = buf_acquire(DSC_H_SIZE);
struct tipc_msg *msg;
--- linux-2.6.16-rc1-mm3-full/net/tipc/name_table.c.old 2006-01-26 07:00:49.000000000 +0100
+++ linux-2.6.16-rc1-mm3-full/net/tipc/name_table.c 2006-01-26 07:03:54.000000000 +0100
@@ -46,7 +46,7 @@
#include "cluster.h"
#include "bcast.h"
-int tipc_nametbl_size = 1024; /* must be a power of 2 */
+static int tipc_nametbl_size = 1024; /* must be a power of 2 */
/**
* struct sub_seq - container for all published instances of a name sequence
@@ -142,7 +142,7 @@
* tipc_subseq_alloc - allocate a specified number of sub-sequence structures
*/
-struct sub_seq *tipc_subseq_alloc(u32 cnt)
+static struct sub_seq *tipc_subseq_alloc(u32 cnt)
{
u32 sz = cnt * sizeof(struct sub_seq);
struct sub_seq *sseq = (struct sub_seq *)kmalloc(sz, GFP_ATOMIC);
@@ -158,7 +158,8 @@
* Allocates a single sub-sequence structure and sets it to all 0's.
*/
-struct name_seq *tipc_nameseq_create(u32 type, struct hlist_head *seq_head)
+static struct name_seq *tipc_nameseq_create(u32 type,
+ struct hlist_head *seq_head)
{
struct name_seq *nseq =
(struct name_seq *)kmalloc(sizeof(*nseq), GFP_ATOMIC);
@@ -243,9 +244,11 @@
* tipc_nameseq_insert_publ -
*/
-struct publication *tipc_nameseq_insert_publ(struct name_seq *nseq,
- u32 type, u32 lower, u32 upper,
- u32 scope, u32 node, u32 port, u32 key)
+static struct publication *tipc_nameseq_insert_publ(struct name_seq *nseq,
+ u32 type, u32 lower,
+ u32 upper,
+ u32 scope, u32 node,
+ u32 port, u32 key)
{
struct subscription *s;
struct subscription *st;
@@ -369,8 +372,9 @@
* tipc_nameseq_remove_publ -
*/
-struct publication *tipc_nameseq_remove_publ(struct name_seq *nseq, u32 inst,
- u32 node, u32 ref, u32 key)
+static struct publication *tipc_nameseq_remove_publ(struct name_seq *nseq,
+ u32 inst, u32 node,
+ u32 ref, u32 key)
{
struct publication *publ;
struct publication *prev;
@@ -487,7 +491,8 @@
* sequence overlapping with the requested sequence
*/
-void tipc_nameseq_subscribe(struct name_seq *nseq, struct subscription *s)
+static void tipc_nameseq_subscribe(struct name_seq *nseq,
+ struct subscription *s)
{
struct sub_seq *sseq = nseq->sseqs;
@@ -983,6 +988,7 @@
}
}
+#if 0
void tipc_nametbl_print(struct print_buf *buf, const char *str)
{
tipc_printf(buf, str);
@@ -990,6 +996,7 @@
nametbl_list(buf, 0, 0, 0, 0);
read_unlock_bh(&tipc_nametbl_lock);
}
+#endif /* 0 */
#define MAX_NAME_TBL_QUERY 32768
@@ -1023,10 +1030,12 @@
return buf;
}
+#if 0
void tipc_nametbl_dump(void)
{
nametbl_list(TIPC_CONS, 0, 0, 0, 0);
}
+#endif /* 0 */
int tipc_nametbl_init(void)
{
--- linux-2.6.16-rc1-mm3-full/net/tipc/net.c.old 2006-01-26 07:04:18.000000000 +0100
+++ linux-2.6.16-rc1-mm3-full/net/tipc/net.c 2006-01-26 07:04:39.000000000 +0100
@@ -128,13 +128,14 @@
return tipc_zone_select_router(tipc_net.zones[tipc_zone(addr)], addr, ref);
}
-
+#if 0
u32 tipc_net_next_node(u32 a)
{
if (tipc_net.zones[tipc_zone(a)])
return tipc_zone_next_node(a);
return 0;
}
+#endif /* 0 */
void tipc_net_remove_as_router(u32 router)
{
--- linux-2.6.16-rc1-mm3-full/net/tipc/node.c.old 2006-01-26 07:05:03.000000000 +0100
+++ linux-2.6.16-rc1-mm3-full/net/tipc/node.c 2006-01-26 07:10:36.000000000 +0100
@@ -214,7 +214,7 @@
(n_ptr->active_links[0] != n_ptr->active_links[1]));
}
-int tipc_node_has_active_routes(struct node *n_ptr)
+static int tipc_node_has_active_routes(struct node *n_ptr)
{
return (n_ptr && (n_ptr->last_router >= 0));
}
^ permalink raw reply
* [2.6 patch] schedule eepro100.c for removal
From: Adrian Bunk @ 2006-02-04 1:10 UTC (permalink / raw)
To: Benjamin LaHaise; +Cc: Jeff Garzik, linux-kernel, netdev
In-Reply-To: <20060203221858.GA3670@kvack.org>
On Fri, Feb 03, 2006 at 05:18:58PM -0500, Benjamin LaHaise wrote:
> Where's the hunk to make the eepro100 driver spew messages about being
> obsolete out upon loading?
Updated patch below.
> -ben
cu
Adrian
<-- snip -->
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
Documentation/feature-removal-schedule.txt | 6 ++++++
drivers/net/eepro100.c | 1 +
2 files changed, 7 insertions(+)
--- linux-2.6.15-mm4-full/Documentation/feature-removal-schedule.txt.old 2006-01-18 08:38:57.000000000 +0100
+++ linux-2.6.15-mm4-full/Documentation/feature-removal-schedule.txt 2006-01-18 08:39:59.000000000 +0100
@@ -164,0 +165,6 @@
+---------------------------
+
+What: eepro100 network driver
+When: April 2006
+Why: replaced by the e100 driver
+Who: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.16-rc1-mm5-full/drivers/net/eepro100.c.old 2006-02-03 23:37:55.000000000 +0100
+++ linux-2.6.16-rc1-mm5-full/drivers/net/eepro100.c 2006-02-03 23:39:10.000000000 +0100
@@ -2391,6 +2391,7 @@ static int __init eepro100_init_module(v
#ifdef MODULE
printk(version);
#endif
+ printk(KERN_WARNING "eepro100 will be removed soon, please use the e100 driver\n");
return pci_module_init(&eepro100_driver);
}
^ permalink raw reply
* Fwd: [Patch] 2.4.32 - Neighbour Cache (ARP) State machine bug Fixed
From: Pradeep Vincent @ 2006-02-04 2:06 UTC (permalink / raw)
To: Roberto Nibali, netdev, linux-kernel
In-Reply-To: <9fda5f510511281257o364acb3gd634f8e412cd7301@mail.gmail.com>
Resending..
---------- Forwarded message ----------
From: Pradeep Vincent <pradeep.vincent@gmail.com>
Date: Nov 28, 2005 12:57 PM
Subject: [Patch] 2.4.32 - Neighbour Cache (ARP) State machine bug Fixed
To: linux-kernel@vger.kernel.org, torvalds@osdl.org
Cc: pradeep.vincent@gmail.com
In 2.4.21, arp code uses gc_timer to check for stale arp cache
entries. In 2.6, each entry has its own timer to check for stale arp
cache. 2.4.29 to 2.4.32 kernels (atleast) use neither of these timers.
This causes problems in environments where IPs or MACs are reassigned
- saw this problem on load balancing router based networks that use
VMACs. Tested this code on load balancing router based networks as
well as peer-linux systems.
Let me know if I need to contact someone else about this,
Thanks,
Pradeep Vincent
diff -Naur old/net/core/neighbour.c new/net/core/neighbour.c
--- old/net/core/neighbour.c Wed Nov 23 17:15:30 2005
+++ new/net/core/neighbour.c Wed Nov 23 17:26:01 2005
@@ -14,6 +14,7 @@
* Vitaly E. Lavrov releasing NULL neighbor in neigh_add.
* Harald Welte Add neighbour cache statistics like rtstat
* Harald Welte port neighbour cache rework from 2.6.9-rcX
+ * Pradeep Vincent Move neighbour cache entry to stale state
*/
#include <linux/config.h>
@@ -705,6 +706,14 @@
neigh_release(n);
continue;
}
+
+ /* Mark it stale - To be reconfirmed later when used */
+ if (n->nud_state&NUD_REACHABLE &&
+ now - n->confirmed > n->parms->reachable_time) {
+ n->nud_state = NUD_STALE;
+ neigh_suspect(n);
+ }
+
write_unlock(&n->lock);
next_elt:
^ permalink raw reply
* Re: [Patch] 2.4.32 - Neighbour Cache (ARP) State machine bug Fixed
From: David S. Miller @ 2006-02-04 2:18 UTC (permalink / raw)
To: pradeep.vincent; +Cc: ratz, netdev, linux-kernel
In-Reply-To: <9fda5f510602031806j2f9ef743t206c9ee2c3bef384@mail.gmail.com>
From: Pradeep Vincent <pradeep.vincent@gmail.com>
Date: Fri, 3 Feb 2006 18:06:53 -0800
> Resending..
Your email client has tab and newline mangled the patch so it
cannot be applied. Please fix this up and also supply an
appropriate "Signed-off-by: " line.
Thanks.
^ permalink raw reply
* Re: [2.6 patch] move some code to net/ipx/af_ipx.c
From: Christoph Hellwig @ 2006-02-04 9:19 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, acme, linux-kernel, netdev
In-Reply-To: <20060204010958.GY4408@stusta.de>
On Sat, Feb 04, 2006 at 02:09:59AM +0100, Adrian Bunk wrote:
> This patch moves some code only used in this file to net/ipx/af_ipx.c .
this doesn't make any sense. the code is part of the 802.2/3 layer, not the
ipx layer even if no other protocol makes use of it yet.
^ permalink raw reply
* Re: open bugzilla reports
From: Russell King @ 2006-02-04 9:50 UTC (permalink / raw)
To: Andrew Morton
Cc: linux-kernel, video4linux-list, linux-fbdev-devel, linux-fsdevel,
linux1394-devel, netdev, linux-ide, linux-scsi, linux-usb-devel
In-Reply-To: <20060203151150.3d9aa8b3.akpm@osdl.org>
On Fri, Feb 03, 2006 at 03:11:50PM -0800, Andrew Morton wrote:
> serial
> ======
>
> [Bug 5832] Enabling ACPI Plug and Play in kernels
> http://bugzilla.kernel.org/show_bug.cgi?id=5832
This seems to be misfiled. Why do you think this is a serial bug?
It seems to be talking about parallel ports.
> [Bug 5875] quad RS232 port card detected as 8,
> http://bugzilla.kernel.org/show_bug.cgi?id=5875
This seems to be because we have an explicit vendor/device ID listed
in 8250_pci for (according to this bug report) something which isn't
a serial device. What I don't know is if these vendor/device IDs
also exist for something which is a serial device. Hence, removing
them could cause more problems than keeping them. Since it has no
effect other than causing extra ports to appear, this is low priority.
> [Bug 5942] serial driver gives up and we get IRQ3
> http://bugzilla.kernel.org/show_bug.cgi?id=5942
No idea what's happening here. No one else seems to be using IRQ3,
we've disabled the interrupt at the UART, yet we get a stuck IRQ3.
Don't think it's serial related, it just happens that closing the
serial port shows it.
> [Bug 5958] CF bluetooth card oopses machine when
> http://bugzilla.kernel.org/show_bug.cgi?id=5958
This isn't a serial bug - it's a bluetooth ldisc bug. I reported it
to the bluetooth folk back when it first got raised by Pavel. However,
they seem to be completely disinterested in fixing it.
Unfortunately, there isn't a category for bt crap in bugzilla, otherwise
I'd reassign it. Please kick the bt folk.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
^ permalink raw reply
* Re: [BUG] sky2 broken for Yukon PCI-E Gigabit Ethernet Controller 11ab:4362 (rev 19)
From: Knut Petersen @ 2006-02-04 10:32 UTC (permalink / raw)
To: Herbert Xu; +Cc: shemminger, netdev, linux-kernel, David S. Miller
In-Reply-To: <20060127122242.GA32128@gondor.apana.org.au>
2.6.16-rc2 still misses your patch. Was there a special reason not to
send it
to Linus?
cu,
Knut
>On Fri, Jan 27, 2006 at 07:07:34AM +0100, Knut Petersen wrote:
>
>
>>Well, there are no problems if SuSEfirewall2 is disabled. But have a look
>>at the loaded modules:
>>
>>ipt_MASQUERADE 3968 1
>>pppoe 15360 2
>>pppox 4616 1 pppoe
>>
>>
>
>OK, although we can't rule out sky2/netfilter from the enquiry, I've
>identified two bugs in ppp/pppoe that may be responsible for what you
>are seeing. So please try the following patch and let us know if the
>problem still exists (or deteriorates/improves).
>
>[PPP]: Fixed hardware RX checksum handling
>
>When we pull the PPP protocol off the skb, we forgot to update the
>hardware RX checksum. This may lead to messages such as
>
> dsl0: hw csum failure.
>
>Similarly, we need to clear the hardware checksum flag when we use
>the existing packet to store the decompressed result.
>
>Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
>Cheers,
>
>
>------------------------------------------------------------------------
>
>diff --git a/drivers/net/ppp_generic.c b/drivers/net/ppp_generic.c
>--- a/drivers/net/ppp_generic.c
>+++ b/drivers/net/ppp_generic.c
>@@ -1610,6 +1610,8 @@ ppp_receive_nonmp_frame(struct ppp *ppp,
> }
> else if (!pskb_may_pull(skb, skb->len))
> goto err;
>+ else
>+ skb->ip_summed = CHECKSUM_NONE;
>
> len = slhc_uncompress(ppp->vj, skb->data + 2, skb->len - 2);
> if (len <= 0) {
>@@ -1690,6 +1692,7 @@ ppp_receive_nonmp_frame(struct ppp *ppp,
> kfree_skb(skb);
> } else {
> skb_pull(skb, 2); /* chop off protocol */
>+ skb_postpull_rcsum(skb, skb->data - 2, 2);
> skb->dev = ppp->dev;
> skb->protocol = htons(npindex_to_ethertype[npi]);
> skb->mac.raw = skb->data;
>
>
^ permalink raw reply
* Re: [PATCH] acx: make firmware statistics parsing more intelligent
From: Denis Vlasenko @ 2006-02-04 11:31 UTC (permalink / raw)
To: acx100-devel; +Cc: Andreas Mohr, netdev
In-Reply-To: <20060203105857.GB11173@rhlx01.fht-esslingen.de>
On Friday 03 February 2006 12:58, Andreas Mohr wrote:
> this patch does:
> - implement much more flexible firmware statistics parsing
> (for /proc/driver/acx_wlanX_diag)
> This has the nice effect that we now get output for both the older
> TNETW1100 USB and TNETW1450.
> Since firmware statistics information has non-stable layout depending on
> firmware version, please report if you suspect any parsing mismatch!
> This improved version now uses 2kB more driver space, unfortunately.
> - use "% 8" modulo instead of more complicated "% 5" calculation
Why? There will be HZ=100 and HZ=250 boxes, 8ms doesn't fit well.
10ms is ok, 5ms or 2.5ms is more or less ok too, but 8ms?
But I'll apply this anyway.
> - use
> if (++idx >= count)
> idx = 0;
> instead of more bloaty
> idx = (idx + 1) % count;
> We might want to add a kernel macro for this *very* common and
> performance-critical driver operation, say ring_advance_next or so,
> in order to have the most optimized version for each architecture;
> Or ($1 million question): Is there already such a beast somewhere!?
As discussed, just use unsigned variable and compile with -Os.
Patch applied to acx and acxsm with following edits:
if (
(IS_PCI(adev) && IS_ACX100(adev))
|| (IS_USB(adev) && IS_ACX100(adev))
) {
Replaced this with "if (IS_ACX100(adev)) {"
typedef struct fw_stats {
u16 type;
u16 len;
fw_stats_tx_t tx;
fw_stats_rx_t rx;
fw_stats_dma_t dma;
fw_stats_irq_t irq;
fw_stats_wep_t wep;
fw_stats_pwr_t pwr;
fw_stats_mic_t mic;
fw_stats_aes_t aes;
fw_stats_event_t evt;
+ u8 _padding[FW_STATS_FUTURE_EXTENSION];
} fw_stats_t;
and removed "+FW_STATS_FUTURE_EXTENSION" elsewhere.
--
vda
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
^ permalink raw reply
* Re: Linux 2.6.15.2
From: Holger Eitzenberger @ 2006-02-04 11:52 UTC (permalink / raw)
To: Andrew Morton; +Cc: gregkh, linux-kernel, stable, torvalds, netdev
In-Reply-To: <20060203111414.7026f46f.akpm@osdl.org>
On Fri, Feb 03, 2006 at 11:14:14AM -0800, Andrew Morton wrote:
> http://www.mail-archive.com/netdev@vger.kernel.org/msg06355.html
> > A look into /proc/sys/net/ipv4/tcp_mem showed that that the values in
> > there were way to high. I hope that a reduction of these values will
> > help (not done yet).
> Sounds different. Please test a more recent kernel and if the problem is
> still there, send a report to linux-kernel and cc netdev@vger.kernel.org.
> Include the contents of /proc/meminfo and /proc/slabinfo. Thanks.
I solved the issue.
Recent kernels have alloc_large_system_hash() exactly for that, and
tcp_init() uses it. It has nr_all_pages and nr_kernel_pages to
determine the actual size of usable RAM, whereas 2.6.10 just uses
num_physpages. That's the reason why the values in tcp_mem are way
too high on machines with 3-4 Gig RAM.
Thanks. /holger
--
ICQ 2882018 ++ Jabber: octavian@amessage.de ++
^ permalink raw reply
* Re: open bugzilla reports
From: Martin J. Bligh @ 2006-02-04 16:47 UTC (permalink / raw)
To: Russell King
Cc: akpm, linux-kernel, video4linux-list, linux-fbdev-devel,
linux-fsdevel, linux1394-devel, netdev, linux-ide, linux-scsi,
linux-usb-devel
In-Reply-To: <20060204095023.GA11140@flint.arm.linux.org.uk>
> > [Bug 5958] CF bluetooth card oopses machine when
> > http://bugzilla.kernel.org/show_bug.cgi?id=5958
>
> This isn't a serial bug - it's a bluetooth ldisc bug. I reported it
> to the bluetooth folk back when it first got raised by Pavel. However,
> they seem to be completely disinterested in fixing it.
>
> Unfortunately, there isn't a category for bt crap in bugzilla, otherwise
> I'd reassign it. Please kick the bt folk.
Stick it under Drivers/Other if you want ...
M.
^ permalink raw reply
* Re: open bugzilla reports
From: Russell King @ 2006-02-04 23:14 UTC (permalink / raw)
To: Martin J. Bligh
Cc: akpm, linux-kernel, video4linux-list, linux-fbdev-devel,
linux-fsdevel, linux1394-devel, netdev, linux-ide, linux-scsi,
linux-usb-devel
In-Reply-To: <20060204084729.defc7c19.mbligh@mbligh.org>
On Sat, Feb 04, 2006 at 08:47:29AM -0800, Martin J. Bligh wrote:
>
> > > [Bug 5958] CF bluetooth card oopses machine when
> > > http://bugzilla.kernel.org/show_bug.cgi?id=5958
> >
> > This isn't a serial bug - it's a bluetooth ldisc bug. I reported it
> > to the bluetooth folk back when it first got raised by Pavel. However,
> > they seem to be completely disinterested in fixing it.
> >
> > Unfortunately, there isn't a category for bt crap in bugzilla, otherwise
> > I'd reassign it. Please kick the bt folk.
>
> Stick it under Drivers/Other if you want ...
It _is_ under Networking/Other, yet akpm still thinks it's a serial
bug. I'm not sure why though, I've fully explained why it isn't
a serial problem in the bug comments.
akpm is buggy and needs fixing. Where do I file this bug? 8)
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
^ permalink raw reply
* Re: [PATCH][ipcomp6] don't check vfree() argument for NULL.
From: David S. Miller @ 2006-02-04 23:50 UTC (permalink / raw)
To: jesper.juhl; +Cc: mk, linux-kernel, pekkas, yoshfuji, netdev
In-Reply-To: <200602042049.44151.jesper.juhl@gmail.com>
From: Jesper Juhl <jesper.juhl@gmail.com>
Date: Sat, 4 Feb 2006 20:49:44 +0100
> vfree does it's own NULL checking, so checking a pointer before handing
> it to vfree is pointless.
>
> Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Applied to net-2.6.17, thanks.
^ permalink raw reply
* Re: [-mm patch] net/ipv4/fib_rules.c: make struct fib_rules static again
From: David S. Miller @ 2006-02-04 23:51 UTC (permalink / raw)
To: bunk; +Cc: akpm, robert.olsson, linux-kernel, netdev
In-Reply-To: <20060203210248.GK4408@stusta.de>
From: Adrian Bunk <bunk@stusta.de>
Date: Fri, 3 Feb 2006 22:02:48 +0100
> struct fib_rules became global for no good reason.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Applied, thanks Adrian.
^ permalink raw reply
* [-mm patch] let only ACX_PCI/ACX_USB be user-visible and select ACX accordingly
From: Adrian Bunk @ 2006-02-05 5:02 UTC (permalink / raw)
To: Denis Vlasenko
Cc: John W. Linville, Gabriel C., da.crew, linux-kernel, netdev
In-Reply-To: <200602010857.04964.vda@ilport.com.ua>
On Wed, Feb 01, 2006 at 08:57:04AM +0200, Denis Vlasenko wrote:
> On Wednesday 01 February 2006 00:16, Adrian Bunk wrote:
> > > > > CONFIG_ACX=y
> > > > > # CONFIG_ACX_PCI is not set
> > > > > # CONFIG_ACX_USB is not set
> > > > >
> > > > > This won't fly. You must select at least one.
> > > > >
> > > > > Attached patch will check for this and #error out.
> > > > > Andrew, do not apply to -mm, I'll send you bigger update today.
> > > >
> > > > Is there any way to move this into a Kconfig file? That seems nicer
> > > > than having #ifdefs in source code to check for a configuration error.
> > >
> > > Can't think of any at the moment.
> >
> > There are two possible solutions ("offer" means "is user visible"):
> > - only offer ACX and always build ACX_PCI/ACX_USB depending on the
> > availability of PCI/USB
> > - only offer ACX_PCI and ACX_USB which select ACX
> >
> > If you tell me which you prefer I can send a patch.
>
> Second one sounds okay to me.
The patch is below.
I've promised a bit too much, there's one small problem in this patch:
If the user says y to one option and m to the other, the driver is built
statically supporting both.
Unfortunately, I don't see any reasonable way to implement this better
(but I do still prefer this solution over the #error).
> vda
cu
Adrian
<-- snip -->
Let only ACX_PCI/ACX_USB be user-visible and select ACX accordingly.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/net/wireless/tiacx/Kconfig | 43 +++++++++++++-----------
drivers/net/wireless/tiacx/Makefile | 4 +-
drivers/net/wireless/tiacx/acx_struct.h | 12 ++----
drivers/net/wireless/tiacx/common.c | 8 ++--
4 files changed, 34 insertions(+), 33 deletions(-)
--- linux-2.6.16-rc1-mm5-full/drivers/net/wireless/tiacx/Kconfig.old 2006-02-05 03:48:32.000000000 +0100
+++ linux-2.6.16-rc1-mm5-full/drivers/net/wireless/tiacx/Kconfig 2006-02-05 05:31:54.000000000 +0100
@@ -1,25 +1,18 @@
config ACX
- tristate "TI acx100/acx111 802.11b/g wireless chipsets"
- depends on NET_RADIO && EXPERIMENTAL && (USB || PCI)
+ tristate
select FW_LOADER
+
+config ACX_PCI
+ tristate "TI acx100/acx111 802.11b/g PCI wireless chipsets"
+ depends on NET_RADIO && EXPERIMENTAL && PCI && (USB || ACX_USB=n)
+ select ACX
+ select ACX_PCI_BOOL
---help---
- A driver for 802.11b/g wireless cards based on
- Texas Instruments acx100 and acx111 chipsets.
+ Include support for PCI and CardBus 802.11b/g wireless cards
+ based on Texas Instruments acx100 and acx111 chipsets.
This driver supports Host AP mode that allows
your computer to act as an IEEE 802.11 access point.
- This driver is new and experimental.
-
- Texas Instruments did not take part in development of this driver
- in any way, shape or form.
-
- The driver can be compiled as a module and will be named "acx".
-
-config ACX_PCI
- bool "TI acx100/acx111 802.11b/g PCI"
- depends on ACX && PCI
- ---help---
- Include PCI and CardBus support in acx.
acx chipsets need their firmware loaded at startup.
You will need to provide a firmware image via hotplug.
@@ -44,11 +37,20 @@
Firmware files are not covered by GPL and are not distributed
with this driver for legal reasons.
+config ACX_PCI_BOOL
+ bool
+
config ACX_USB
- bool "TI acx100/acx111 802.11b/g USB"
- depends on ACX && (USB=y || USB=ACX)
+ tristate "TI acx100/acx111 802.11b/g USB wireless chipsets"
+ depends on NET_RADIO && EXPERIMENTAL && USB
+ select ACX
+ select ACX_USB_BOOL
---help---
- Include USB support in acx.
+ Include support for USB 802.11b/g wireless cards
+ based on Texas Instruments acx100 and acx111 chipsets.
+
+ This driver supports Host AP mode that allows
+ your computer to act as an IEEE 802.11 access point.
There is only one currently known device in this category,
D-Link DWL-120+, but newer devices seem to be on the horizon.
@@ -61,3 +63,6 @@
Firmware files are not covered by GPL and are not distributed
with this driver for legal reasons.
+
+config ACX_USB_BOOL
+ bool
--- linux-2.6.16-rc1-mm5-full/drivers/net/wireless/tiacx/Makefile.old 2006-02-05 05:25:03.000000000 +0100
+++ linux-2.6.16-rc1-mm5-full/drivers/net/wireless/tiacx/Makefile 2006-02-05 05:25:17.000000000 +0100
@@ -1,6 +1,6 @@
obj-$(CONFIG_ACX) += acx.o
-acx-obj-$(CONFIG_ACX_PCI) += pci.o
-acx-obj-$(CONFIG_ACX_USB) += usb.o
+acx-obj-$(CONFIG_ACX_PCI_BOOL) += pci.o
+acx-obj-$(CONFIG_ACX_USB_BOOL) += usb.o
acx-objs := wlan.o conv.o ioctl.o common.o $(acx-obj-y)
--- linux-2.6.16-rc1-mm5-full/drivers/net/wireless/tiacx/acx_struct.h.old 2006-02-05 05:37:13.000000000 +0100
+++ linux-2.6.16-rc1-mm5-full/drivers/net/wireless/tiacx/acx_struct.h 2006-02-05 05:37:35.000000000 +0100
@@ -105,12 +105,8 @@
#define DEVTYPE_PCI 0
#define DEVTYPE_USB 1
-#if !defined(CONFIG_ACX_PCI) && !defined(CONFIG_ACX_USB)
-#error Driver must include PCI and/or USB support. You selected neither.
-#endif
-
-#if defined(CONFIG_ACX_PCI)
- #if !defined(CONFIG_ACX_USB)
+#if defined(CONFIG_ACX_PCI_BOOL)
+ #if !defined(CONFIG_ACX_USB_BOOL)
#define IS_PCI(adev) 1
#else
#define IS_PCI(adev) ((adev)->dev_type == DEVTYPE_PCI)
@@ -119,8 +115,8 @@
#define IS_PCI(adev) 0
#endif
-#if defined(CONFIG_ACX_USB)
- #if !defined(CONFIG_ACX_PCI)
+#if defined(CONFIG_ACX_USB_BOOL)
+ #if !defined(CONFIG_ACX_PCI_BOOL)
#define IS_USB(adev) 1
#else
#define IS_USB(adev) ((adev)->dev_type == DEVTYPE_USB)
--- linux-2.6.16-rc1-mm5-full/drivers/net/wireless/tiacx/common.c.old 2006-02-05 05:37:44.000000000 +0100
+++ linux-2.6.16-rc1-mm5-full/drivers/net/wireless/tiacx/common.c 2006-02-05 05:38:58.000000000 +0100
@@ -6853,12 +6853,12 @@
"recommended, visit http://acx100.sf.net in case "
"of further questions/discussion\n");
-#if defined(CONFIG_ACX_PCI)
+#if defined(CONFIG_ACX_PCI_BOOL)
r1 = acxpci_e_init_module();
#else
r1 = -EINVAL;
#endif
-#if defined(CONFIG_ACX_USB)
+#if defined(CONFIG_ACX_USB_BOOL)
r2 = acxusb_e_init_module();
#else
r2 = -EINVAL;
@@ -6872,10 +6872,10 @@
static void __exit
acx_e_cleanup_module(void)
{
-#if defined(CONFIG_ACX_PCI)
+#if defined(CONFIG_ACX_PCI_BOOL)
acxpci_e_cleanup_module();
#endif
-#if defined(CONFIG_ACX_USB)
+#if defined(CONFIG_ACX_USB_BOOL)
acxusb_e_cleanup_module();
#endif
}
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox