* Re: [patch 1/7] net_device list cleanup: core
From: Andrey Savochkin @ 2006-07-04 7:24 UTC (permalink / raw)
To: Christoph Hellwig
Cc: netdev, Kirill Korotaev, Eric W. Biederman, Alexey Kuznetsov
In-Reply-To: <20060703174650.GA22295@infradead.org>
Christoph,
On Mon, Jul 03, 2006 at 06:46:50PM +0100, Christoph Hellwig wrote:
> On Mon, Jul 03, 2006 at 12:18:51PM +0400, Andrey Savochkin wrote:
> > Cleanup of net_device list use in net_dev core and IP.
> > The cleanup consists of
> > - converting the to list_head, to make the list double-linked (thus making
> > remove operation O(1)), and list walks more readable;
> > - introducing of for_each_netdev wrapper over list_for_each.
>
> When you change all this please make sure dev_base_head is never directly
> accessed anymore, not even through macros and dev_base_head is not exported
> anymore. That's the only way to keep drivers messing with it.
>
> Yes, it's a little more work as you need to audit all drivers to see what
> they are doing and find suitable abstractions but it's a must have that
> should have been done a lot earlier.
Hiding dev_base_head can be done by converting first_netdev/next_netdev into
functions and implementing for_each_netdev loop through them.
Or are you talking about abstractions like functions
for_each_netdev/find_netdev with callbacks?
Do you think that hiding the list internals is worth the additional
complexity and substantial increase of the patch size?
Andrey
^ permalink raw reply
* Re: [PATCH] ipvs: Add sysctl documentation
From: Horms @ 2006-07-04 6:10 UTC (permalink / raw)
To: David Miller; +Cc: netdev, wensong, ja
In-Reply-To: <20060703.193647.08322498.davem@davemloft.net>
On Mon, Jul 03, 2006 at 07:36:47PM -0700, David Miller wrote:
> From: Horms <horms@verge.net.au>
> Date: Mon, 3 Jul 2006 11:31:30 +0900
>
> > * Derived from http://www.linuxvirtualserver.org/docs/sysctl.html, v1.4
> > maintained by Wensong Zhang
> >
> > * Adjusted preample to match ip-sysctl.txt
> >
> > * Sorted options into alphabetical order
> >
> > * Added expire_quiescent_template
> >
> > * Removed timeout_* which are no longer present
> >
> > * Incoporated doc/debug-levels.txt from IPVS source tree into
> > description of ipvs_debug
> >
> > * Minor spelling fixes
> >
> > * Further editing more than welcome
> >
> > Signed-Off-By: Horms <horms@verge.net.au>
>
> Applied, thanks Simon.
>
> > * DaveM, do you need a 2.4 version of this document,
> > it will likely be a slightly different list of options?
>
> I don't think it's really worthwhile, we should be touching 2.4.x
> as little as possible at this point. Changes we make in 2.4.x
> should be in the "absolutely necssary" category.
Understood, I'm more than happy to let that sleeping dog lie.
--
Horms
H: http://www.vergenet.net/~horms/
W: http://www.valinux.co.jp/en/
^ permalink raw reply
* Re: [PATCH 38 of 39] IB/ipath - More changes to support InfiniPath on PowerPC 970 systems
From: Michael S. Tsirkin @ 2006-07-04 4:55 UTC (permalink / raw)
To: Anton Blanchard
Cc: eli, David Miller, bos, akpm, Roland Dreier, openib-general,
linux-kernel, netdev, matthew, ak, ak, vojtech
In-Reply-To: <20060703222506.GD31081@krispykreme>
Quoting r. Anton Blanchard <anton@samba.org>:
> Subject: Re: [PATCH 38 of 39] IB/ipath - More changes to support InfiniPath on PowerPC 970 systems
>
>
> Hi,
>
> > Please fix the generic code if it doesn't provide the facility
> > you need at the moment. Don't shoe horn it into your driver
> > just to make up for that.
>
> Ive had 3 drivers asking for write combining recently so I agree this is
> a good idea. How about ioremap_wc as suggested by Willy:
>
> http://marc.theaimsgroup.com/?l=linux-kernel&m=114374741828040&w=2
Hmm ... I think ioremap_wc isn't sufficient by itself to make drivers using
write-combined memory, portable. Here's another thread on a related subject:
http://lkml.org/lkml/2006/2/24/347
--
MST
^ permalink raw reply
* RE: [PATCH] [2.6.17] Add tsi108 Ethernet device driver support
From: Zang Roy-r61911 @ 2006-07-04 4:47 UTC (permalink / raw)
To: Andrew Morton
Cc: jgarzik, netdev, linux-kernel, Alexandre.Bounine,
Yang Xin-Xin-r48390
> On Wed, 21 Jun 2006 12:00:40 +0800
> Zang Roy-r61911 <tie-fei.zang@freescale.com> wrote:
>
> > This patch adds a net device driver and configuration options for
> > Tundra Semiconductor Tsi108 integrated dual port Gigabit Ethernet
> > controller
>
> Your patch forgot to include these:
>
> > +#include <asm/tsi108_irq.h>
> > +#include <asm/tsi108.h>
>
> Why would a net driver have files in include/asm/?
The net driver is for a tsi108 on chip Ethernet controller. tsi108_irq provides the Ethernet IRQ number.
tsi108.h provides the hw_info structure. Now tsi108.h has been in the kernel tree. I'd like to provide
the tsi108_irq.h with tsi108 irq support in another patch. Any comment?
>
>
>
>
> Have some comments-via-diff, mainly trivial:
>
Thanks for your patch. It works OK! I will integrate it in my next version.
^ permalink raw reply
* xfrm6: move define/ifdef check order and add a Kconfig option
From: Randy.Dunlap @ 2006-07-04 4:42 UTC (permalink / raw)
To: David Miller; +Cc: netdev
In-Reply-To: <20060703.194655.38711929.davem@davemloft.net>
On Mon, 03 Jul 2006 19:46:55 -0700 (PDT) David Miller wrote:
> Yes, indeed. Nothing named CONFIG_* should be defined explicitly
> by the source files, only through Kconfig.
>
> I would rather address that than apply this patch.
by adding a Kconfig option or not? This patch adds one.
From: Randy Dunlap <rdunlap@xenotime.net>
Convert CONFIG_IPV6_XFRM6_TUNNEL_DEBUG (not a Kconfig option)
to CONFIG_INET6_XFRM6_TUNNEL_DEBUG, which is a Kconfig option.
Then #define XFRM6_TUNNEL_SPI_MAGIC before it is first used.
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
net/ipv6/Kconfig | 6 ++++++
net/ipv6/xfrm6_tunnel.c | 7 ++-----
2 files changed, 8 insertions(+), 5 deletions(-)
--- linux-2617-g20.orig/net/ipv6/xfrm6_tunnel.c
+++ linux-2617-g20/net/ipv6/xfrm6_tunnel.c
@@ -31,8 +31,9 @@
#include <linux/icmpv6.h>
#include <linux/mutex.h>
-#ifdef CONFIG_IPV6_XFRM6_TUNNEL_DEBUG
+#ifdef CONFIG_INET6_XFRM_TUNNEL_DEBUG
# define X6TDEBUG 3
+# define XFRM6_TUNNEL_SPI_MAGIC 0xdeadbeef
#else
# define X6TDEBUG 1
#endif
@@ -67,10 +68,6 @@ struct xfrm6_tunnel_spi {
#endif
};
-#ifdef CONFIG_IPV6_XFRM6_TUNNEL_DEBUG
-# define XFRM6_TUNNEL_SPI_MAGIC 0xdeadbeef
-#endif
-
static DEFINE_RWLOCK(xfrm6_tunnel_spi_lock);
static u32 xfrm6_tunnel_spi;
--- linux-2617-g20.orig/net/ipv6/Kconfig
+++ linux-2617-g20/net/ipv6/Kconfig
@@ -106,6 +106,12 @@ config INET6_TUNNEL
tristate
default n
+config INET6_XFRM_TUNNEL_DEBUG
+ bool "IPv6: xfrm tunnel debug"
+ depends on INET6_XFRM_TUNNEL
+ ---help---
+ Enable IPv6 tunnel debug code.
+
config INET6_XFRM_MODE_TRANSPORT
tristate "IPv6: IPsec transport mode"
depends on IPV6
---
^ permalink raw reply
* Re: [1/4] [IPV6]: Remove redundant length check on input
From: Herbert Xu @ 2006-07-04 4:04 UTC (permalink / raw)
To: David Miller; +Cc: Ananda.Raju, netdev
In-Reply-To: <20060704024527.GA31361@gondor.apana.org.au>
On Tue, Jul 04, 2006 at 12:45:27PM +1000, herbert wrote:
>
> That's what I meant. I meant ethtool helper functions that
> clear and set both TSO/TSO6 flags at the same time.
I think I was a bit ambiguous here. To expand on my argument, what
I'm saying is that we can't just change the existing ethtool helper
functions to set TSO6 since that'd break NICs which do not support
TSO6.
Instead of adding an ad-hoc ethtool function in the neterion driver,
we should either add a new ethtool function which sets both TSO/TSO6,
or do the following.
> Alternatively, we can add a new features bit which gives the inherent
> features of a device. That can then be used to derive the actual
> features in use. That way we won't need to invent a new ethtool
> helper function for this.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply
* Re: strict isolation of net interfaces
From: Sam Vilain @ 2006-07-04 3:00 UTC (permalink / raw)
To: Andrey Savochkin
Cc: Serge E. Hallyn, Cedric Le Goater, hadi, Herbert Poetzl,
Alexey Kuznetsov, viro, devel, dev, Andrew Morton, netdev,
linux-kernel, Daniel Lezcano, Ben Greear, Dave Hansen,
Alexey Kuznetsov, Eric W. Biederman
In-Reply-To: <20060703185350.A16826@castle.nmd.msu.ru>
Andrey Savochkin wrote:
>> Why special case loopback?
>>
>> Why not:
>>
>> host | guest 0 | guest 1 | guest2
>> ----------------------+-----------+-----------+--------------
>> | | | |
>> |-> lo | | |
>> | | | |
>> |-> vlo0 <---------+-> lo | |
>> | | | |
>> |-> vlo1 <---------+-----------+-----------+-> lo
>> | | | |
>> |-> vlo2 <--------+-----------+-> lo |
>> | | | |
>> |-> eth0 | | |
>> | | | |
>> |-> veth0 <--------+-> eth0 | |
>> | | | |
>> |-> veth1 <--------+-----------+-----------+-> eth0
>> | | | |
>> |-> veth2 <-------+-----------+-> eth0 |
>>
>
> I still can't completely understand your direction of thoughts.
> Could you elaborate on IP address assignment in your diagram, please? For
> example, guest0 wants 127.0.0.1 and 192.168.0.1 addresses on its lo
> interface, and 10.1.1.1 on its eth0 interface.
> Does this diagram assume any local IP addresses on v* interfaces in the
> "host"?
>
Well, Eric already pointed out some pretty good reasons why this thread
should die.
The idea is that each "lo" interface would have the same set of
addresses. Which would make routing on the host confusing. Yet another
reason to kill this idea. Let's just make better tools instead.
Sam.
> And the second question.
> Are vlo0, veth0, etc. devices supposed to have hard_xmit routines?
>
^ permalink raw reply
* Re: [patch] bridge: br_dump_ifinfo index fix
From: David Miller @ 2006-07-04 2:50 UTC (permalink / raw)
To: saw; +Cc: netdev, dev, greearb, shemminger
In-Reply-To: <20060703160640.A15611@castle.nmd.msu.ru>
From: Andrey Savochkin <saw@swsoft.com>
Date: Mon, 3 Jul 2006 16:06:40 +0400
> Fix for inability of br_dump_ifinfo to handle non-zero start index:
> loop index never increases when entered with non-zero start.
> Spotted by Kirill Korotaev.
>
> Signed-off-by: Andrey Savochkin <saw@swsoft.com>
> Cc: Kirill Korotaev <dev@openvz.org>
Applied, thanks Andrey.
^ permalink raw reply
* Re: [PATCH 2/2] ATM: add+use poison defines
From: David Miller @ 2006-07-04 2:48 UTC (permalink / raw)
To: rdunlap; +Cc: netdev, akpm, chas
In-Reply-To: <20060702182138.f29d484b.rdunlap@xenotime.net>
From: "Randy.Dunlap" <rdunlap@xenotime.net>
Date: Sun, 2 Jul 2006 18:21:38 -0700
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> ATM: add and use POISON define values.
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Applied, thanks Randy.
^ permalink raw reply
* Re: [PATCH] net: add+use poison defines
From: David Miller @ 2006-07-04 2:47 UTC (permalink / raw)
To: rdunlap; +Cc: netdev, akpm
In-Reply-To: <20060702164058.f8ce0ded.rdunlap@xenotime.net>
From: "Randy.Dunlap" <rdunlap@xenotime.net>
Date: Sun, 2 Jul 2006 16:40:58 -0700
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Add and use poison defines in net/.
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Applied, thanks Randy.
^ permalink raw reply
* Re: [1/4] [IPV6]: Remove redundant length check on input
From: Herbert Xu @ 2006-07-04 2:45 UTC (permalink / raw)
To: David Miller; +Cc: Ananda.Raju, netdev
In-Reply-To: <20060703.194406.23013279.davem@davemloft.net>
On Mon, Jul 03, 2006 at 07:44:06PM -0700, David Miller wrote:
>
> > I think we need some new ethtool helper functions that sets/clears both
> > TSO/TSO6.
>
> Do you really want to semantically seperate TSO and TSO6?
>
> I would think that real users who want to disable TSO, wish
> to do so unilaterally.
That's what I meant. I meant ethtool helper functions that
clear and set both TSO/TSO6 flags at the same time.
Alternatively, we can add a new features bit which gives the inherent
features of a device. That can then be used to derive the actual
features in use. That way we won't need to invent a new ethtool
helper function for this.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply
* Re: [PATCH] xfrm6: move define/ifdef check order
From: David Miller @ 2006-07-04 2:46 UTC (permalink / raw)
To: rdunlap; +Cc: netdev
In-Reply-To: <20060702143611.dffe7b15.rdunlap@xenotime.net>
From: "Randy.Dunlap" <rdunlap@xenotime.net>
Date: Sun, 2 Jul 2006 14:36:11 -0700
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> The first check for #ifdef XFRM6_TUNNEL_SPI_MAGIC needs to come after
> the optional #define of it, otherwise the variable won't be there
> for the rest of the code to use.
>
> Shouldn't that CONFIG_IPV6_XFRM6_TUNNEL_DEBUG be part of Kconfig
> or have its name changed?
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Yes, indeed. Nothing named CONFIG_* should be defined explicitly
by the source files, only through Kconfig.
I would rather address that than apply this patch.
Thanks Randy.
^ permalink raw reply
* Re: [PATCH] IOAT: fix kernel-doc in source files
From: David Miller @ 2006-07-04 2:45 UTC (permalink / raw)
To: rdunlap; +Cc: netdev, christopher.leech, akpm
In-Reply-To: <20060630170111.676d4cec.rdunlap@xenotime.net>
From: "Randy.Dunlap" <rdunlap@xenotime.net>
Date: Fri, 30 Jun 2006 17:01:11 -0700
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Fix kernel-doc warnings in drivers/dma/:
> - use correct function & parameter names
> - add descriptions where omitted
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Also applied, thanks Randy.
^ permalink raw reply
* Re: [PATCH] IOAT: fix header file kernel-doc
From: David Miller @ 2006-07-04 2:45 UTC (permalink / raw)
To: rdunlap; +Cc: netdev, akpm, christopher.leech
In-Reply-To: <20060630162830.f6c72a5a.rdunlap@xenotime.net>
From: "Randy.Dunlap" <rdunlap@xenotime.net>
Date: Fri, 30 Jun 2006 16:28:30 -0700
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Fix kernel-doc problems in include/linux/dmaengine.h:
> - add some fields/parameters
> - expand some descriptions
> - fix typos
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Applied, thanks Randy.
^ permalink raw reply
* Re: [1/4] [IPV6]: Remove redundant length check on input
From: David Miller @ 2006-07-04 2:44 UTC (permalink / raw)
To: herbert; +Cc: Ananda.Raju, netdev
In-Reply-To: <20060701033939.GC29803@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sat, 1 Jul 2006 13:39:39 +1000
> On Fri, Jun 30, 2006 at 07:44:49PM -0400, Ananda Raju wrote:
> >
> > I tested the patch, and TSO over ipv6 is working fine. But TSO disable
> > not working for IPv6.
> >
> > I tried the from tree /pub/scm/linux/kernel/git/davem/net-2.6
>
> I think we need some new ethtool helper functions that sets/clears both
> TSO/TSO6.
Do you really want to semantically seperate TSO and TSO6?
I would think that real users who want to disable TSO, wish
to do so unilaterally.
I think we should only add the TSO6 specific knob if we find
through experience that it often comes up that someone wants
to just disable ipv6 vs. ipv4 TSO.
^ permalink raw reply
* Re: [PATCH] tg3: Add ipv6 TSO feature
From: David Miller @ 2006-07-04 2:42 UTC (permalink / raw)
To: mchan; +Cc: netdev
In-Reply-To: <1151710512.3645.5.camel@rh4>
From: "Michael Chan" <mchan@broadcom.com>
Date: Fri, 30 Jun 2006 16:35:12 -0700
> Enable ipv6 TSO feature on chips that support it.
>
> Update version to 3.61.
>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied, thanks a lot Michael.
^ permalink raw reply
* Re: [PATCH] NET: Fix ipv6 GSO payload length
From: David Miller @ 2006-07-04 2:41 UTC (permalink / raw)
To: herbert; +Cc: mchan, netdev
In-Reply-To: <20060701034446.GA30258@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sat, 1 Jul 2006 13:44:46 +1000
> On Fri, Jun 30, 2006 at 03:56:47PM -0700, Michael Chan wrote:
> > Fix ipv6 GSO payload length calculation.
> >
> > The ipv6 payload length excludes the ipv6 base header length and so
> > must be subtracted.
> >
> > Signed-off-by: Michael Chan <mchan@broadcom.com>
>
> Looks good to me. Thanks for cathcing this!
Applied, thanks Michael.
^ permalink raw reply
* Re: [PATCH 1/3] [TIPC] Fixed skb_under_panic caused by tipc_link_bundle_buf
From: David Miller @ 2006-07-04 2:39 UTC (permalink / raw)
To: per.liden; +Cc: netdev, allan.stephens
In-Reply-To: <Pine.LNX.4.64.0606301032170.17932@ulinpc219.uab.ericsson.se>
From: Per Liden <per.liden@ericsson.com>
Date: Fri, 30 Jun 2006 10:49:08 +0200 (CEST)
> [TIPC] Fixed sk_buff panic caused by tipc_link_bundle_buf (REVISED)
>
> From: Allan Stephens <allan.stephens@windriver.com>
>
> The recent change to direct inspection of bundle buffer tailroom did not
> account for the possiblity of unrequested tailroom added by skb_alloc(),
> thereby allowing a bundle to be created that exceeds the current link MTU.
> An additional check now ensures that bundling works correctly no matter
> if the bundle buffer is smaller, larger, or equal to the link MTU.
>
> Signed-off-by: Allan Stephens <allan.stephens@windriver.com>
> Signed-off-by: Per Liden <per.liden@ericsson.com>
Applied, thanks a lot Per.
^ permalink raw reply
* Re: [5/4] [NET]: Verify gso_type too in gso_segment
From: David Miller @ 2006-07-04 2:38 UTC (permalink / raw)
To: herbert; +Cc: yoshfuji, Ananda.Raju, netdev
In-Reply-To: <20060630064134.GA20428@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Fri, 30 Jun 2006 16:41:34 +1000
> On Fri, Jun 30, 2006 at 04:13:50PM +1000, herbert wrote:
> >
> > [NET]: Verify gso_type too in gso_segment
>
> Here is a better version that ensures at least one of TCPV4 and TCPV6
> is set in tcp_tso_segment.
>
> [NET]: Verify gso_type too in gso_segment
>
> We don't want nasty Xen guests to pass a TCPv6 packet in with gso_type set
> to TCPv4 or even UDP (or a packet that's both TCP and UDP).
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied, thanks Herbert.
^ permalink raw reply
* Re: [PATCH] ipvs: Add sysctl documentation
From: David Miller @ 2006-07-04 2:36 UTC (permalink / raw)
To: horms; +Cc: netdev, wensong, ja
In-Reply-To: <20060703023128.GA27424@verge.net.au>
From: Horms <horms@verge.net.au>
Date: Mon, 3 Jul 2006 11:31:30 +0900
> * Derived from http://www.linuxvirtualserver.org/docs/sysctl.html, v1.4
> maintained by Wensong Zhang
>
> * Adjusted preample to match ip-sysctl.txt
>
> * Sorted options into alphabetical order
>
> * Added expire_quiescent_template
>
> * Removed timeout_* which are no longer present
>
> * Incoporated doc/debug-levels.txt from IPVS source tree into
> description of ipvs_debug
>
> * Minor spelling fixes
>
> * Further editing more than welcome
>
> Signed-Off-By: Horms <horms@verge.net.au>
Applied, thanks Simon.
> * DaveM, do you need a 2.4 version of this document,
> it will likely be a slightly different list of options?
I don't think it's really worthwhile, we should be touching 2.4.x
as little as possible at this point. Changes we make in 2.4.x
should be in the "absolutely necssary" category.
^ permalink raw reply
* Re: Off by one buglets
From: David Miller @ 2006-07-04 2:34 UTC (permalink / raw)
To: ralf; +Cc: netdev
In-Reply-To: <20060630142901.GA13898@linux-mips.org>
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 30 Jun 2006 15:29:01 +0100
> Ages ago, changeset
>
> http://www.kernel.org/git/?p=linux/kernel/git/tglx/history.git;a=commit;h=22d864d542a0b92116751186f1794c7d0f1ca1b9
>
> which converted several protocols from using open coded comparisons to
> use the helper function sk_acceptq_is_full() did introduce a bunch of
> off by one errors - sk_acceptq_is_full checks for
> sk_ack_backlog > sk_max_ack_backlog but it replaced >= or == comparisons.
>
> Below patch is really only meant to illustrate the change, not to be
> applied.
Ok, I'll try to resolve this when I get back from my vacation
unless someone beats me to it.
Thanks for the heads up Ralf.
^ permalink raw reply
* Re: [ROSE] Try all routes when establishing a ROSE connections.
From: David Miller @ 2006-07-04 2:32 UTC (permalink / raw)
To: ralf; +Cc: netdev
In-Reply-To: <20060630135316.GA12943@linux-mips.org>
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 30 Jun 2006 14:53:16 +0100
> >From Jean-Paul F6FBB:
>
> ROSE will only try to establish a route using the first route in its
> routing table. Fix to iterate through all additional routes if a
> connection attempt has failed.
>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Applied, thanks.
^ permalink raw reply
* Re: [NETROM] Use socket helpers instead of direct fiddling with struct sock
From: David Miller @ 2006-07-04 2:31 UTC (permalink / raw)
To: ralf; +Cc: netdev
In-Reply-To: <20060630134648.GA12586@linux-mips.org>
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 30 Jun 2006 14:46:48 +0100
> Signed-off-by: Ralf Baechle DL5RB <ralf@linux-mips.org>
Applied, thanks Ralf.
^ permalink raw reply
* Re: [AX.25] reference counting for AX.25 routes.
From: David Miller @ 2006-07-04 2:30 UTC (permalink / raw)
To: ralf; +Cc: netdev
In-Reply-To: <20060630133858.GA12180@linux-mips.org>
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 30 Jun 2006 14:38:58 +0100
> In the past routes could be freed even though the were possibly in use ...
>
> Signed-off-by: Ralf Baechle DL5RB <ralf@linux-mips.org>
Applied.
^ permalink raw reply
* Re: [ROSE] Fix dereference of skb pointer after free.
From: David Miller @ 2006-07-04 2:29 UTC (permalink / raw)
To: ralf; +Cc: netdev
In-Reply-To: <20060630133614.GA11735@linux-mips.org>
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 30 Jun 2006 14:36:14 +0100
> If rose_route_frame return success we'll dereference a stale pointer.
> Likely this is only going to result in bad statistics for the ROSE
> interface.
>
> This fixes coverity 946.
>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Applied, thanks Ralf.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox