* Re: [PATCH 3/3] [IrDA] TOSHIBA_FIR depends on virt_to_bus
From: David Miller @ 2007-07-22 2:08 UTC (permalink / raw)
To: samuel; +Cc: netdev, irda-users, sfr, akpm
In-Reply-To: <20070721081906.443279774@sortiz.org>
From: samuel@sortiz.org
Date: Sat, 21 Jul 2007 11:13:07 +0300
> From: Stephen Rothwell <sfr@canb.auug.org.au>
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Samuel Ortiz <samuel@sortiz.org>
Also applied, thanks.
^ permalink raw reply
* Re: [PATCH 2/3] [IrDA] EP7211 IR driver port to the latest SIR API
From: David Miller @ 2007-07-22 2:07 UTC (permalink / raw)
To: samuel; +Cc: netdev, irda-users
In-Reply-To: <20070721081906.145785934@sortiz.org>
From: samuel@sortiz.org
Date: Sat, 21 Jul 2007 11:13:06 +0300
> The EP7211 SIR driver was the only one left without a new SIR API port.
>
> Signed-off-by: Samuel Ortiz <samuel@sortiz.org>
Applied.
^ permalink raw reply
* Re: [PATCH 1/3] [IrDA] Typo fix in irnetlink.c copyright
From: David Miller @ 2007-07-22 2:07 UTC (permalink / raw)
To: samuel-jcdQHdrhKHMdnm+yROfE0A
Cc: netdev-u79uwXL29TY76Z2rM5mHXA,
irda-users-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f
In-Reply-To: <20070721081905.854286733-jcdQHdrhKHMdnm+yROfE0A@public.gmane.org>
From: samuel-jcdQHdrhKHMdnm+yROfE0A@public.gmane.org
Date: Sat, 21 Jul 2007 11:13:05 +0300
> Signed-off-by: Samuel Ortiz <samuel-jcdQHdrhKHMdnm+yROfE0A@public.gmane.org>
Applied.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
^ permalink raw reply
* Re: [PATCH]: Resurrect napi_poll patch.
From: David Miller @ 2007-07-22 1:59 UTC (permalink / raw)
To: rusty; +Cc: netdev, shemminger, jgarzik
In-Reply-To: <1185059423.6344.53.camel@localhost.localdomain>
From: Rusty Russell <rusty@rustcorp.com.au>
Date: Sun, 22 Jul 2007 09:10:23 +1000
> In five years' time, the "napi_struct for simple drivers" in net_device
> will look confusing. Since your change touches all NAPI drivers anyway,
> it'd be nice to go straight to "everyone allocates their own NAPI
> struct" in one jump.
Good point.
But note that you'd be adding a pointer deref, the current sequence:
napi_struct --> netdev --> driver_private
involves all pointer arithmetic and no derefs, whereas:
napi_struct --> driver_private --> netdev
will involve at least on deref to get to the netdev from the
driver_private.
(Ignore the fact that netdev_priv() is not currently optimized
as it used to be, that's an abberation of the current multi-queue
implementation and will be fixed).
So this suggestion does have real downsides.
^ permalink raw reply
* Re: [PATCH]: Resurrect napi_poll patch.
From: Rusty Russell @ 2007-07-21 23:10 UTC (permalink / raw)
To: David Miller; +Cc: netdev, shemminger, jgarzik
In-Reply-To: <20070721.115428.48807536.davem@davemloft.net>
On Sat, 2007-07-21 at 11:54 -0700, David Miller wrote:
> From: Rusty Russell <rusty@rustcorp.com.au>
> Date: Sat, 21 Jul 2007 18:00:11 +1000
>
> > No, I was just thinking that drivers will put the napi_struct in their
> > driver-specific struct (eg. struct e1000_adapter *adapter =
> > container_of(container_of(napi, struct e1000_adapter, napi);).
>
> That works.
>
> > Multi-queue drivers will have no use for a napi_struct in net_device,
> > right? They'll need some wrapper "my_queue" structure containing the
> > napi_struct anyway.
>
> Sure, we can eliminate the napi_struct in struct net_device
> eventually.
>
> But then again, like the statistics, if it's convenient to
> just use the in-net_device one then why not :)
Because *every* single driver can use the in-net_device stats.
In five years' time, the "napi_struct for simple drivers" in net_device
will look confusing. Since your change touches all NAPI drivers anyway,
it'd be nice to go straight to "everyone allocates their own NAPI
struct" in one jump.
Cheers,
Rusty.
^ permalink raw reply
* [PATCH] 3c59x, check return of pci_enable_device()
From: Mark Hindley @ 2007-07-21 22:13 UTC (permalink / raw)
To: linux-kernel; +Cc: netdev
commit 36d139ccebba6a1082b743fbedb53c5a5097987c
Author: Mark Hindley <mark@hindley.org.uk>
Date: Sat Jul 21 22:56:08 2007 +0100
Check return of pci_enable_device in vortex_up().
Signed-off-by: Mark Hindley <mark@hindley.org.uk>
diff --git a/drivers/net/3c59x.c b/drivers/net/3c59x.c
index f26ca33..192e74b 100644
--- a/drivers/net/3c59x.c
+++ b/drivers/net/3c59x.c
@@ -1490,13 +1490,17 @@ vortex_up(struct net_device *dev)
struct vortex_private *vp = netdev_priv(dev);
void __iomem *ioaddr = vp->ioaddr;
unsigned int config;
- int i, mii_reg1, mii_reg5;
+ int i, mii_reg1, mii_reg5, err;
if (VORTEX_PCI(vp)) {
pci_set_power_state(VORTEX_PCI(vp), PCI_D0); /* Go active */
if (vp->pm_state_valid)
pci_restore_state(VORTEX_PCI(vp));
- pci_enable_device(VORTEX_PCI(vp));
+ err = pci_enable_device(VORTEX_PCI(vp));
+ if (err) {
+ printk(KERN_WARNING "%s: Could not enable device \n",
+ dev->name);
+ }
}
/* Before initializing select the active media port. */
^ permalink raw reply related
* Re: Virtual device lo asks to queue packet! since -git15
From: Andi Kleen @ 2007-07-21 21:17 UTC (permalink / raw)
To: David Miller; +Cc: netdev
In-Reply-To: <20070721.115304.112624318.davem@davemloft.net>
On Saturday 21 July 2007 20:53:04 David Miller wrote:
> From: Andi Kleen <ak@suse.de>
> Date: Sat, 21 Jul 2007 09:49:22 +0200
>
> > Since -git15 (probably David's merge) I see a lot of
> >
> > Virtual device lo asks to queue packet!
> > Virtual device lo asks to queue packet!
> > Virtual device lo asks to queue packet!
> > Virtual device lo asks to queue packet!
> > Virtual device lo asks to queue packet!
> > Virtual device lo asks to queue packet!
> >
> > during a LTP run on a nfsroot system
>
> Yes I have a fix pending in my tree for this.
Thanks. Could this explain the firefox hangs too?
-Andi
^ permalink raw reply
* Re: Linux, tcpdump and vlan
From: Krzysztof Halasa @ 2007-07-21 21:15 UTC (permalink / raw)
To: Ben Greear
Cc: andrei radulescu-banu, Stephen Hemminger, Patrick McHardy,
linux-kernel, Linux Netdev List
In-Reply-To: <46A248FA.1050403@candelatech.com>
Ben Greear <greearb@candelatech.com> writes:
>> IOW: I think all Ethernet interfaces should always be VLAN-aware,
>> stripping the tag (only one) early on RX and adding it late on TX.
>> That means tcpdump would see packets with exactly one tag removed
>> (unless there was no tag), in both RX and TX.
>>
>> Tcpdump would need other means to get VLAN id...
>>
> What benefit will this add? It will certainly decrease performance to
> copy around
> the header for every VLAN packet, so there would have to be a good reason to
> add this logic...
I'd have to do some tests... Hopefully in this decade, forget it for
now.
The primary reason - consistency with hw VLAN cards -> simpler
code.
The performance is already decreased (not sure if it's noticeable)
most of the time, i.e., when not transparently bridging VLAN
trunks. Bridging VLAN trunks is, of course, theoretically possible,
but it's rather not a common operation when using .1Q.
That is, with header reordering, of course.
Anyway, -ENOPATCH from me for now.
--
Krzysztof Halasa
^ permalink raw reply
* [PATCH] NET: Fix sch_prio to detect the root qdisc loading
From: PJ Waskiewicz @ 2007-07-21 19:14 UTC (permalink / raw)
To: davem; +Cc: netdev, jeff, kaber
The sch->parent handle will be NULL for the scheduler that is TC_H_ROOT.
Change this check in prio_tune() so that only the root qdisc can be
multiqueue-enabled.
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
---
net/sched/sch_prio.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/net/sched/sch_prio.c b/net/sched/sch_prio.c
index 2d8c084..271051e 100644
--- a/net/sched/sch_prio.c
+++ b/net/sched/sch_prio.c
@@ -239,11 +239,13 @@ static int prio_tune(struct Qdisc *sch, struct rtattr *opt)
/* If we're multiqueue, make sure the number of incoming bands
* matches the number of queues on the device we're associating with.
* If the number of bands requested is zero, then set q->bands to
- * dev->egress_subqueue_count.
+ * dev->egress_subqueue_count. Also, the root qdisc must be the
+ * only one that is enabled for multiqueue, since it's the only one
+ * that interacts with the underlying device.
*/
q->mq = RTA_GET_FLAG(tb[TCA_PRIO_MQ - 1]);
if (q->mq) {
- if (sch->handle != TC_H_ROOT)
+ if (sch->parent != NULL)
return -EINVAL;
if (netif_is_multiqueue(sch->dev)) {
if (q->bands == 0)
^ permalink raw reply related
* RE: Question: how to detect if a qdisc is root or not?
From: Waskiewicz Jr, Peter P @ 2007-07-21 18:55 UTC (permalink / raw)
To: Patrick McHardy; +Cc: netdev
In-Reply-To: <46A18503.8000800@trash.net>
> > Anyways, I tried a few different things, and what it looks like is
> > sch->parent will be NULL (0) for the top-level device. This is
> > sch->correct,
> > and trying to mess with that screws up qdisc_graft() when unloading
> > the qdisc. I also tried adding a TCQ_F_ROOT flag to
> sch->flags when
> > classid is TC_H_ROOT, but that also screwed up unloading the qdisc.
>
>
> I dont think I understand. Whats the problem with setting
> sch->parent on initialization instead on grafting as I did in
> my example patch?
> Please explain the problems arrising on unload in detail.
sch->parent is getting set on initialization, and for the root and
ingress qdiscs, it's left at zero. If I change that value, when the
root qdisc is unloaded and pfifo_fast is put back into place, the
qdisc_destroy() walks the tree and attempts to free memory from the
handle pointed at by sch->parent. It stops when sch->parent is NULL, so
sch->parent is actually being set as intended. The only thing that
confused me is that nowhere in the qdisc is TC_H_ROOT included
explicitly, rather, the root qdisc is where sch->parent is NULL.
So I misunderstood what was actually wrong. The qdisc code is ok as-is,
it's just that the top-level qdisc (root and ingress) have a sch->parent
of NULL, which is being set correctly today.
Hope that clarifies.
Thanks,
-PJ
^ permalink raw reply
* Re: [PATCH]: Resurrect napi_poll patch.
From: David Miller @ 2007-07-21 18:54 UTC (permalink / raw)
To: rusty; +Cc: netdev, shemminger, jgarzik
In-Reply-To: <1185004811.6344.37.camel@localhost.localdomain>
From: Rusty Russell <rusty@rustcorp.com.au>
Date: Sat, 21 Jul 2007 18:00:11 +1000
> No, I was just thinking that drivers will put the napi_struct in their
> driver-specific struct (eg. struct e1000_adapter *adapter =
> container_of(container_of(napi, struct e1000_adapter, napi);).
That works.
> Multi-queue drivers will have no use for a napi_struct in net_device,
> right? They'll need some wrapper "my_queue" structure containing the
> napi_struct anyway.
Sure, we can eliminate the napi_struct in struct net_device
eventually.
But then again, like the statistics, if it's convenient to
just use the in-net_device one then why not :)
^ permalink raw reply
* Re: Virtual device lo asks to queue packet! since -git15
From: David Miller @ 2007-07-21 18:53 UTC (permalink / raw)
To: ak; +Cc: netdev
In-Reply-To: <200707210949.22880.ak@suse.de>
From: Andi Kleen <ak@suse.de>
Date: Sat, 21 Jul 2007 09:49:22 +0200
> Since -git15 (probably David's merge) I see a lot of
>
> Virtual device lo asks to queue packet!
> Virtual device lo asks to queue packet!
> Virtual device lo asks to queue packet!
> Virtual device lo asks to queue packet!
> Virtual device lo asks to queue packet!
> Virtual device lo asks to queue packet!
>
> during a LTP run on a nfsroot system
Yes I have a fix pending in my tree for this.
commit 31ce72a6b1c7635259cf522459539c0611f2c50c
Author: Patrick McHardy <kaber@trash.net>
Date: Fri Jul 20 19:45:45 2007 -0700
[NET]: Fix loopback crashes when multiqueue is enabled.
From: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 9820ca1..4a616d7 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -575,7 +575,7 @@ struct net_device
/* The TX queue control structures */
unsigned int egress_subqueue_count;
- struct net_device_subqueue egress_subqueue[0];
+ struct net_device_subqueue egress_subqueue[1];
};
#define to_net_dev(d) container_of(d, struct net_device, dev)
diff --git a/net/core/dev.c b/net/core/dev.c
index 38212c3..ee40355 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -3624,7 +3624,7 @@ struct net_device *alloc_netdev_mq(int sizeof_priv, const char *name,
/* ensure 32-byte alignment of both the device and private area */
alloc_size = (sizeof(*dev) + NETDEV_ALIGN_CONST +
- (sizeof(struct net_device_subqueue) * queue_count)) &
+ (sizeof(struct net_device_subqueue) * (queue_count - 1))) &
~NETDEV_ALIGN_CONST;
alloc_size += sizeof_priv + NETDEV_ALIGN_CONST;
@@ -3642,7 +3642,7 @@ struct net_device *alloc_netdev_mq(int sizeof_priv, const char *name,
dev->priv = ((char *)dev +
((sizeof(struct net_device) +
(sizeof(struct net_device_subqueue) *
- queue_count) + NETDEV_ALIGN_CONST)
+ (queue_count - 1)) + NETDEV_ALIGN_CONST)
& ~NETDEV_ALIGN_CONST));
}
^ permalink raw reply related
* RE: Question: how to detect if a qdisc is root or not?
From: Waskiewicz Jr, Peter P @ 2007-07-21 18:31 UTC (permalink / raw)
To: David Miller, kaber; +Cc: netdev
In-Reply-To: <20070720.223315.41635979.davem@davemloft.net>
> From: Patrick McHardy <kaber@trash.net>
> Date: Sat, 21 Jul 2007 06:01:07 +0200
>
> > Waskiewicz Jr, Peter P wrote:
> > > I just sent out a patch to fix this.
> >
> > I didn't see it yet.
>
> VGER ate it for some reason and I didn't notice it during my
> daily bounce analysis. I asked him on IRC to resend it, but
> he's away from the computer already :)
I'll get it resent today. Sorry for the delay.
-PJ
^ permalink raw reply
* Re: [PATCH 1/1] Allow LSM to use IP address/port number.
From: Casey Schaufler @ 2007-07-21 18:11 UTC (permalink / raw)
To: Tetsuo Handa, kaber, jmorris; +Cc: netdev, linux-security-module
In-Reply-To: <200707211057.ACE39835.WUNtGEPSOFF@I-love.SAKURA.ne.jp>
--- Tetsuo Handa <from-netdev@I-love.SAKURA.ne.jp> wrote:
>
> Hello.
>
> Patrick McHardy wrote:
> > Quoting Tetsuo:
> > > > So, my approach is not using security context associated with a socket
> > > > but security context associated with a process.
> > Isn't the socket context derived from the process context?
> Not so regarding my case.
>
> static int smack_sk_alloc_security(struct sock *sk, int family, gfp_t
> priority)
> {
> sk->sk_security = current->security;
> return 0;
> }
>
> will not help what I want to do.
> So, I'm not planning to use "sk->sk_security".
Before you go too far down this path please note that the quoted
code is bad* because back pointers from sockets to tasks can't be
reliable. See later versions for more reasonable behavior.
> I'm planning to use "current->security" at accept()/recvmsg() time.
The delivery of packets and the completion of these syscalls are
related but independent events. Be careful about the relationship
between the events and the placement of your checks.
----
* Stephen had good comments on the details on list earlier.
Casey Schaufler
casey@schaufler-ca.com
^ permalink raw reply
* Re: Linux, tcpdump and vlan
From: Ben Greear @ 2007-07-21 17:57 UTC (permalink / raw)
To: Krzysztof Halasa
Cc: andrei radulescu-banu, Stephen Hemminger, Patrick McHardy,
linux-kernel, Linux Netdev List
In-Reply-To: <m3sl7idmb4.fsf@maximus.localdomain>
Krzysztof Halasa wrote:
> Ben Greear <greearb@candelatech.com> writes:
>
>
>> There is already a flag you can set on vlan devices (reorder-header)
>> that strips the VLAN tag before presenting it to user-space.
>>
>
> Sure, but isn't it only valid for VLAN device (not the main ethX)?
> I.e., can you have the tag stripped from frames captured on ethX?
>
No. I don't see a good reason to strip on ethX. That hardware accel
VLANs strip
is an inconvenience in my opinion, no need to force it in software as well.
>> On tx, if it shows up on the vlan device, we add that device's VID to
>> the header if no VID is currently in the SKB. If it is in the SKB header
>> we change the VID to be the tx dev's VID (if it was different). This allows user-space
>> to send a raw ethernet frame on a vlan device and have it automatically
>> go out of the box on the correct vlan. User-space can also send raw VLAN frames
>> and have those also go out on the correct VLAN.
>>
>
> Well... I think the tag should be added unconditionally (for things like
> QinQ) but that's trivial and minor.
>
I think that for Q in Q, we would need some explicit flag on each skb to
know when to add or modify
the VID. I was never able to think of an automatic solution that worked
in all cases
(bridging, writing raw packets from user space, normal receive, normal
transmit, ...)
Modifying the bridging code would fix that path, and adding a socket opt
to deal with writing
raw packets from user-space should handle the other tricky case I believe.
> IOW: I think all Ethernet interfaces should always be VLAN-aware,
> stripping the tag (only one) early on RX and adding it late on TX.
> That means tcpdump would see packets with exactly one tag removed
> (unless there was no tag), in both RX and TX.
>
> Tcpdump would need other means to get VLAN id...
>
What benefit will this add? It will certainly decrease performance to
copy around
the header for every VLAN packet, so there would have to be a good reason to
add this logic...
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply
* [BUG] Open Kernel Bugs
From: Natalie Protasevich @ 2007-07-21 17:16 UTC (permalink / raw)
To: linux-kernel, akpm, netdev, alsa-devel, linux-ide, linux-pcmcia,
linux-input, bugme-daemon
This is the first listing of the open bugs that will be sent out and will
contain bugs on specific areas.
The bugs on the list below are about a year old and most of them confirmed
(or claimed) to still be a problem.
It would be appreciated if the corresponding maintenance team could take a
look, close off any which are fixed and see if we can fix any which aren't.
NOTE: when replying to this email, please add the bug number to the Subject in
the form [Bug 1234] so that bugzilla will capture the discussion.
Thanks.
bugzilla: timers
[BUG 7967] TIMER_ABSTIME cleared resulting in userland deadlock
http://bugzilla.kernel.org/show_bug.cgi?id=7967
bugzilla: parallel
[BUG 7492] parport doesn't work if DMA is used
http://bugzilla.kernel.org/show_bug.cgi?id=7492
bugzilla: network
[BUG 8106] tx_errors and tx_fifo_errors not updated consistantly
http://bugzilla.kernel.org/show_bug.cgi?id=8106 - error reporting
[BUG 7856] b44 WOL problem (bcm4401)
http://bugzilla.kernel.org/show_bug.cgi?id=7856
[BUG 5839] uli526x partially recognizing interface
http://bugzilla.kernel.org/show_bug.cgi?id=5839
[BUG 6613] iptables broken on 32-bit PReP (ARCH=ppc)
http://bugzilla.kernel.org/show_bug.cgi?id=6613
bugzilla: sound (ALSA)
[BUG 7195] pc doesn't correctly shut down because of hda_intel
http://bugzilla.kernel.org/show_bug.cgi?id=7195
[BUG 6244] cs46xx in Thinkapad A21m after suspend/resume doesn't play
http://bugzilla.kernel.org/process_bug.cgi?id=6244
bugzilla: scheduler
[BUG 7372] Unusable system (ie slow) when copying large files.
http://bugzilla.kernel.org/show_bug.cgi?id=7372
bugzilla: input
[BUG 7746] Support for unicode dead keys
http://bugzilla.kernel.org/show_bug.cgi?id=7746
[BUG 7941] The atkbd module makes system unusable
http://bugzilla.kernel.org/process_bug.cgi?id=7941
bugzilla: dvb-usb
[BUG 8179] Yuan ub300 card not working/tuning
http://bugzilla.kernel.org/show_bug.cgi?id=8179
bugzilla: PCI
[BUG 7528] pci=assign-busses needed on DELL Latitude D810
http://bugzilla.kernel.org/show_bug.cgi?id=7528
[BUG 8187] 2.6.20 "PCI: Quirks" patch breaks X11 on I82801
http://bugzilla.kernel.org/show_bug.cgi?id=8187
[BUG 7917] "PCI: Failed to allocate mem resource" for PCI E-to-PCI Bridge
http://bugzilla.kernel.org/show_bug.cgi?id=7917
bugzilla: i386
[BUG 5565] Guess of i386 APIC PTE area scribble
http://bugzilla.kernel.org/show_bug.cgi?id=5565
[BUG 7589] libata: does not work anymore on VIA VT8251 AHCI/SATA 4-Port
Controller
http://bugzilla.kernel.org/show_bug.cgi?id=7589
bugzilla: Interrupts
[BUG 7673] Memory card reader 5-in-1 don't working on Lenovo N100 3000
http://bugzilla.kernel.org/show_bug.cgi?id=7673
bugzilla: I/O - Storage
[BUG 7921] oops in 2.6.20-rc6-git3 &&udf && pktcdvd
http://bugzilla.kernel.org/show_bug.cgi?id=7921
[BUG 7507] pata_it821x: system freezes
http://bugzilla.kernel.org/show_bug.cgi?id=7507
[BUG 7506] it821x: long wait time due to dma_timer_expiry
http://bugzilla.kernel.org/show_bug.cgi?id=7506
[BUG 7703] hpt366 does not find drives
http://bugzilla.kernel.org/show_bug.cgi?id=7703
[BUG 6516] wrong value for avgqu-sz
http://bugzilla.kernel.org/show_bug.cgi?id=6516
bugzilla: serial
[BUG 7750] open/close loop causes disabled irq
http://bugzilla.kernel.org/show_bug.cgi?id=7750
bugzilla: PCMCIA
[BUG 7788] System freeze as soon as PCMCIA card is inserted
http://bugzilla.kernel.org/show_bug.cgi?id=7788
[BUG 8118] Wrong device identifiers returned in lspci for pccard with RL5c476
II (rev 80)
http://bugzilla.kernel.org/show_bug.cgi?id=8118
[BUG 8262] PCMCIA: socket *** DANGER *** unable to remove socket power
http://bugzilla.kernel.org/show_bug.cgi?id=8262
[BUG 7215] PCMCIA network card causes either X or kernel to freeze
http://bugzilla.kernel.org/show_bug.cgi?id=7215
bugzilla: SCSI
[BUG 4880] dpt_i2o.c does not register itself with sysfs
http://bugzilla.kernel.org/show_bug.cgi?id=4880
bugzilla: File Systems
[BUG 6124] mount of UDF fs ignores UID and GID options
http://bugzilla.kernel.org/show_bug.cgi?id=6124
bugzilla: USB
[BUG 8104] kernel floods console with "connect-debounce failed"
http://bugzilla.kernel.org/show_bug.cgi?id=8104
-----------------------------------------------------------------------------
-----------------------------------------------------------------------------
-----------------------------
-------------------------------------------------------
^ permalink raw reply
* Re: Virtual device lo asks to queue packet! since -git15 II
From: Evgeniy Polyakov @ 2007-07-21 16:54 UTC (permalink / raw)
To: Andi Kleen; +Cc: netdev
In-Reply-To: <200707211849.30469.ak@suse.de>
On Sat, Jul 21, 2007 at 06:49:30PM +0200, Andi Kleen (ak@suse.de) wrote:
> On Saturday 21 July 2007 09:49:22 Andi Kleen wrote:
> >
> > FYI
> >
> > Since -git15 (probably David's merge) I see a lot of
> >
> > Virtual device lo asks to queue packet!
> > Virtual device lo asks to queue packet!
> > Virtual device lo asks to queue packet!
> > Virtual device lo asks to queue packet!
> > Virtual device lo asks to queue packet!
> > Virtual device lo asks to queue packet!
> >
> > during a LTP run on a nfsroot system
>
>
> ... and my firefox just hung itself up trying to connect to localhost:111
> (in -git16 now)
>
> Network definitely seems to have issues
It should be in David's tree already.
Patrick fixed this with folowing patch:
[NET]: Fix loopback multiqueue bug
The loopback device is not allocated through netdev_alloc_mq and thus
has no room for the subqueue states reserved. Change the net_device
subqueue array to always include at least one element.
Signed-off-by: Patrick McHardy <kaber@trash.net>
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index da7a13c..bf9399c 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -575,7 +575,7 @@ struct net_device
/* The TX queue control structures */
unsigned int egress_subqueue_count;
- struct net_device_subqueue egress_subqueue[0];
+ struct net_device_subqueue egress_subqueue[1];
};
#define to_net_dev(d) container_of(d, struct net_device, dev)
diff --git a/net/core/dev.c b/net/core/dev.c
index 13a0d9f..4af0207 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -3619,7 +3619,7 @@ struct net_device *alloc_netdev_mq(int sizeof_priv, const char *name,
/* ensure 32-byte alignment of both the device and private area */
alloc_size = (sizeof(*dev) + NETDEV_ALIGN_CONST +
- (sizeof(struct net_device_subqueue) * queue_count)) &
+ (sizeof(struct net_device_subqueue) * (queue_count - 1))) &
~NETDEV_ALIGN_CONST;
alloc_size += sizeof_priv + NETDEV_ALIGN_CONST;
@@ -3637,7 +3637,7 @@ struct net_device *alloc_netdev_mq(int sizeof_priv, const char *name,
dev->priv = ((char *)dev +
((sizeof(struct net_device) +
(sizeof(struct net_device_subqueue) *
- queue_count) + NETDEV_ALIGN_CONST)
+ (queue_count - 1)) + NETDEV_ALIGN_CONST)
& ~NETDEV_ALIGN_CONST));
}
> -Andi
--
Evgeniy Polyakov
^ permalink raw reply related
* Re: [PATCH][12/37] Clean up duplicate includes in drivers/net/
From: Chris Snook @ 2007-07-21 16:50 UTC (permalink / raw)
To: Jesper Juhl
Cc: info, Luke Yang, Judy Fischbach, Patrick McHardy, bonding-devel,
Bryan Wu, kong.lai, Jay Vosburgh, James Morris, linuxppc-embedded,
Alexey Kuznetsov, Alex V Lasso, Ulrich Kunitz, Chad Tindel,
Amit S Kale, Jay Cliburn, Samuel Ortiz, Daniel Drake, Brian Pugh,
viro, alexandre.bounine, Pantelis Antoniou, netdev,
linux-wireless, Linux Kernel Mailing List, Ralf Baechle
In-Reply-To: <9a8748490707210948k468f8f32k718d84279aa56ce9@mail.gmail.com>
Jesper Juhl wrote:
> On 21/07/07, Chris Snook <csnook@redhat.com> wrote:
>> Jesper Juhl wrote:
>> > Hi,
>> >
>> > This patch cleans up duplicate includes in
>> > drivers/net/
>> >
>> >
>> > Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
>> > ---
>> >
>> > diff --git a/drivers/net/atl1/atl1_main.c
>> b/drivers/net/atl1/atl1_main.c
>> > index fd1e156..4a18b88 100644
>> > --- a/drivers/net/atl1/atl1_main.c
>> > +++ b/drivers/net/atl1/atl1_main.c
>> > @@ -75,7 +75,6 @@
>> > #include <linux/compiler.h>
>> > #include <linux/delay.h>
>> > #include <linux/mii.h>
>> > -#include <linux/interrupt.h>
>> > #include <net/checksum.h>
>> >
>> > #include <asm/atomic.h>
>>
>> Define "duplicate". I ask because this patch just got posted a few
>> days ago:
>>
>
> duplicate == present more than once in the same source file.
> Did you try looking at the includes in the source file the patch modifies?
Nope! Mea Culpa.
-- Chris
^ permalink raw reply
* Re: Virtual device lo asks to queue packet! since -git15 II
From: Andi Kleen @ 2007-07-21 16:49 UTC (permalink / raw)
To: netdev
In-Reply-To: <200707210949.22880.ak@suse.de>
On Saturday 21 July 2007 09:49:22 Andi Kleen wrote:
>
> FYI
>
> Since -git15 (probably David's merge) I see a lot of
>
> Virtual device lo asks to queue packet!
> Virtual device lo asks to queue packet!
> Virtual device lo asks to queue packet!
> Virtual device lo asks to queue packet!
> Virtual device lo asks to queue packet!
> Virtual device lo asks to queue packet!
>
> during a LTP run on a nfsroot system
... and my firefox just hung itself up trying to connect to localhost:111
(in -git16 now)
Network definitely seems to have issues
-Andi
^ permalink raw reply
* Re: [PATCH][12/37] Clean up duplicate includes in drivers/net/
From: Jesper Juhl @ 2007-07-21 16:48 UTC (permalink / raw)
To: Chris Snook
Cc: info, Luke Yang, Judy Fischbach, Patrick McHardy, bonding-devel,
Bryan Wu, kong.lai, Jay Vosburgh, James Morris, linuxppc-embedded,
Alexey Kuznetsov, Alex V Lasso, Ulrich Kunitz, Chad Tindel,
Amit S Kale, Jay Cliburn, Samuel Ortiz, Daniel Drake, Brian Pugh,
viro, alexandre.bounine, Pantelis Antoniou, netdev,
linux-wireless, Linux Kernel Mailing List, Ralf Baechle
In-Reply-To: <46A236FC.2080300@redhat.com>
On 21/07/07, Chris Snook <csnook@redhat.com> wrote:
> Jesper Juhl wrote:
> > Hi,
> >
> > This patch cleans up duplicate includes in
> > drivers/net/
> >
> >
> > Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
> > ---
> >
> > diff --git a/drivers/net/atl1/atl1_main.c b/drivers/net/atl1/atl1_main.c
> > index fd1e156..4a18b88 100644
> > --- a/drivers/net/atl1/atl1_main.c
> > +++ b/drivers/net/atl1/atl1_main.c
> > @@ -75,7 +75,6 @@
> > #include <linux/compiler.h>
> > #include <linux/delay.h>
> > #include <linux/mii.h>
> > -#include <linux/interrupt.h>
> > #include <net/checksum.h>
> >
> > #include <asm/atomic.h>
>
> Define "duplicate". I ask because this patch just got posted a few days ago:
>
duplicate == present more than once in the same source file.
Did you try looking at the includes in the source file the patch modifies?
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
> drivers/net/atl1/atl1_main.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/atl1/atl1_main.c b/drivers/net/atl1/atl1_main.c
> index 4a18b88..fd1e156 100644
> --- a/drivers/net/atl1/atl1_main.c
> +++ b/drivers/net/atl1/atl1_main.c
> @@ -75,6 +75,7 @@
> #include <linux/compiler.h>
> #include <linux/delay.h>
> #include <linux/mii.h>
> +#include <linux/interrupt.h>
> #include <net/checksum.h>
>
> #include <asm/atomic.h>
>
> I've always been under the impression that one should include all the files
> whose contents you use directly, because other includes that happen to include
> them might no longer need to in the future and cease including them.
I agree completely. But that's completely beside the point here.
Before Al's patch, drivers/net/atl1/atl1_main.c already contained
"#include <linux/interrupt.h>".
> You can
> fight it out with Al if you feel like it. I'm keeping the rest of the CC list
> because the other maintainers might have similar feelings about the
> appropriateness of these includes in their drivers.
>
Take a look at the file. These are the includes at the top of
drivers/net/atl1/atl1_main.c :
...
#include <linux/types.h>
#include <linux/netdevice.h>
#include <linux/pci.h>
#include <linux/spinlock.h>
#include <linux/slab.h>
#include <linux/string.h>
#include <linux/skbuff.h>
#include <linux/etherdevice.h>
#include <linux/if_vlan.h>
#include <linux/irqreturn.h>
#include <linux/workqueue.h>
#include <linux/timer.h>
#include <linux/jiffies.h>
#include <linux/hardirq.h>
#include <linux/interrupt.h> <--- Here we have linux/interrupt.h
#include <linux/irqflags.h>
#include <linux/dma-mapping.h>
#include <linux/net.h>
#include <linux/pm.h>
#include <linux/in.h>
#include <linux/ip.h>
#include <linux/tcp.h>
#include <linux/compiler.h>
#include <linux/delay.h>
#include <linux/mii.h>
#include <linux/interrupt.h> <--- And here we include it again.
#include <net/checksum.h>
#include <asm/atomic.h>
#include <asm/byteorder.h>
#include "atl1.h"
...
Now please tell me why it makes sense to include the same header twice
and why my patch that removes the duplicate does not make sense.
--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
^ permalink raw reply
* Re: [PATCH][12/37] Clean up duplicate includes in drivers/net/
From: Al Viro @ 2007-07-21 16:46 UTC (permalink / raw)
To: Chris Snook
Cc: info, Patrick McHardy, Judy Fischbach, Luke Yang, bonding-devel,
Bryan Wu, kong.lai, Jay Vosburgh, James Morris, linuxppc-embedded,
Alexey Kuznetsov, Alex V Lasso, Ulrich Kunitz, Chad Tindel,
Amit S Kale, Jay Cliburn, Samuel Ortiz, Brian Pugh, Daniel Drake,
alexandre.bounine, Pantelis Antoniou, netdev, Jesper Juhl,
linux-wireless, Linux Kernel Mailing List, Ralf Baechle <ralf@
In-Reply-To: <46A236FC.2080300@redhat.com>
On Sat, Jul 21, 2007 at 12:40:28PM -0400, Chris Snook wrote:
> Define "duplicate". I ask because this patch just got posted a few days
> ago:
... and it had been wrong - it's really a duplicate (check several lines
above). My apologies.
^ permalink raw reply
* Re: [PATCH][12/37] Clean up duplicate includes in drivers/net/
From: Chris Snook @ 2007-07-21 16:40 UTC (permalink / raw)
To: Jesper Juhl, viro
Cc: info, Patrick McHardy, Judy Fischbach, Luke Yang, bonding-devel,
Bryan Wu, kong.lai, Jay Vosburgh, James Morris, linuxppc-embedded,
Alexey Kuznetsov, Alex V Lasso, Ulrich Kunitz, Chad Tindel,
Amit S Kale, Jay Cliburn, Samuel Ortiz, Brian Pugh, Daniel Drake,
alexandre.bounine, Pantelis Antoniou, netdev, linux-wireless,
Linux Kernel Mailing List, Ralf Baechle, Vitaly Bordug <vbord
In-Reply-To: <200707211702.46375.jesper.juhl@gmail.com>
Jesper Juhl wrote:
> Hi,
>
> This patch cleans up duplicate includes in
> drivers/net/
>
>
> Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
> ---
>
> diff --git a/drivers/net/atl1/atl1_main.c b/drivers/net/atl1/atl1_main.c
> index fd1e156..4a18b88 100644
> --- a/drivers/net/atl1/atl1_main.c
> +++ b/drivers/net/atl1/atl1_main.c
> @@ -75,7 +75,6 @@
> #include <linux/compiler.h>
> #include <linux/delay.h>
> #include <linux/mii.h>
> -#include <linux/interrupt.h>
> #include <net/checksum.h>
>
> #include <asm/atomic.h>
Define "duplicate". I ask because this patch just got posted a few days ago:
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
drivers/net/atl1/atl1_main.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/atl1/atl1_main.c b/drivers/net/atl1/atl1_main.c
index 4a18b88..fd1e156 100644
--- a/drivers/net/atl1/atl1_main.c
+++ b/drivers/net/atl1/atl1_main.c
@@ -75,6 +75,7 @@
#include <linux/compiler.h>
#include <linux/delay.h>
#include <linux/mii.h>
+#include <linux/interrupt.h>
#include <net/checksum.h>
#include <asm/atomic.h>
I've always been under the impression that one should include all the files
whose contents you use directly, because other includes that happen to include
them might no longer need to in the future and cease including them. You can
fight it out with Al if you feel like it. I'm keeping the rest of the CC list
because the other maintainers might have similar feelings about the
appropriateness of these includes in their drivers.
-- Chris
^ permalink raw reply related
* [PATCH] CONFIG_NET=n - lots of link time errors
From: Jan Engelhardt @ 2007-07-21 16:27 UTC (permalink / raw)
To: netdev; +Cc: Linux Kernel Mailing List, Andrew Morton
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1430 bytes --]
Hi,
enable everything from Drivers > Networking, but deselect CONFIG_NET.
This throws a ton of linking errors (when using CONFIG_MODULES=n), and
probably unresolved symbols (MODULES=m). Happens in current -git, but I
believe it dates much farther back, because this is imo just a simple
Kconfig issue. I think we need to hand out a big 'if NET'-endif block in
drivers/net/Kconfig. The full error log is like 120 K in size, and I
doubt it would make sense to post it, given instructions above. I'll
attach my (i386) .config for anyone to see it for themselves, and a
patch proposal right below. Is it ok to add 'depends on NET' on
NETDEVICES, or are there some network devices that can live without
CONFIG_NET?
Thanks,
Jan
===
Enabling drivers from "Devices > Networking" (in menuconfig), for
example SLIP and/or PLIP, throws link time errors when CONFIG_NET itself
is =n. Have CONFIG_NETDEVICES depend on CONFIG_NET.
Signed-off-by: Jan Engelhardt <jengelh@gmx.de>
---
drivers/net/Kconfig | 1 +
1 file changed, 1 insertion(+)
Index: linux-2.6.23/drivers/net/Kconfig
===================================================================
--- linux-2.6.23.orig/drivers/net/Kconfig
+++ linux-2.6.23/drivers/net/Kconfig
@@ -5,6 +5,7 @@
menuconfig NETDEVICES
default y if UML
+ depends on NET
bool "Network device support"
---help---
You can say N here if you don't intend to connect your Linux box to
[-- Attachment #2: Type: APPLICATION/X-CONFIG, Size: 19173 bytes --]
^ permalink raw reply
* [PATCH][34/37] Clean up duplicate includes in net/xfrm/
From: Jesper Juhl @ 2007-07-21 15:04 UTC (permalink / raw)
To: Linux Kernel Mailing List
Cc: Andrew Morton, Jesper Juhl, netdev, David S Miller,
Kunihiro Ishiguro, Derek Atkins
Hi,
This patch cleans up duplicate includes in
net/xfrm/
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---
diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c
index c3a4b0a..e67489a 100644
--- a/net/xfrm/xfrm_policy.c
+++ b/net/xfrm/xfrm_policy.c
@@ -23,10 +23,9 @@
#include <linux/netfilter.h>
#include <linux/module.h>
#include <linux/cache.h>
+#include <linux/audit.h>
#include <net/xfrm.h>
#include <net/ip.h>
-#include <linux/audit.h>
-#include <linux/cache.h>
#include "xfrm_hash.h"
diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c
index 38f90ca..b2552b1 100644
--- a/net/xfrm/xfrm_state.c
+++ b/net/xfrm/xfrm_state.c
@@ -19,9 +19,8 @@
#include <linux/ipsec.h>
#include <linux/module.h>
#include <linux/cache.h>
-#include <asm/uaccess.h>
#include <linux/audit.h>
-#include <linux/cache.h>
+#include <asm/uaccess.h>
#include "xfrm_hash.h"
^ permalink raw reply related
* [PATCH][31/37] Clean up duplicate includes in net/sched/
From: Jesper Juhl @ 2007-07-21 15:03 UTC (permalink / raw)
To: Linux Kernel Mailing List
Cc: Andrew Morton, Jesper Juhl, Alexey Kuznetsov, Jamal Hadi Salim,
David S Miller, netdev
Hi,
This patch cleans up duplicate includes in
net/sched/
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---
diff --git a/net/sched/act_police.c b/net/sched/act_police.c
index bf90e60..6085be5 100644
--- a/net/sched/act_police.c
+++ b/net/sched/act_police.c
@@ -16,7 +16,6 @@
#include <linux/string.h>
#include <linux/errno.h>
#include <linux/skbuff.h>
-#include <linux/module.h>
#include <linux/rtnetlink.h>
#include <linux/init.h>
#include <net/act_api.h>
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox