* Re: [PATCH 1/3] [IPV6]: Make ipv6_frag_rcv return the same packet
From: David Miller @ 2007-10-15 8:28 UTC (permalink / raw)
To: herbert; +Cc: kaber, hadi, netdev, kuznet, yoshfuji, tgraf
In-Reply-To: <E1Ih4m7-0003rk-00@gondolin.me.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sun, 14 Oct 2007 22:49:03 +0800
> [IPV6]: Make ipv6_frag_rcv return the same packet
>
> This patch implements the same change taht was done to ip_defrag. It
> makes ipv6_frag_rcv return the last packet received of a train of fragments
> rather than the head of that sequence.
>
> This allows us to get rid of the sk_buff ** argument later.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied.
^ permalink raw reply
* Re: [PATCH 2/3] [IPV6]: Avoid skb_copy/pskb_copy/skb_realloc_headroom on input
From: David Miller @ 2007-10-15 8:29 UTC (permalink / raw)
To: herbert; +Cc: kaber, hadi, netdev, kuznet, yoshfuji, tgraf
In-Reply-To: <E1Ih4m8-0003rz-00@gondolin.me.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sun, 14 Oct 2007 22:49:04 +0800
> [IPV6]: Avoid skb_copy/pskb_copy/skb_realloc_headroom on input
>
> This patch replaces unnecessary uses of skb_copy by pskb_expand_head
> on the IPv6 input path.
>
> This allows us to remove the double pointers later.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied.
^ permalink raw reply
* Re: [PATCH 3/3] [IPV6]: Replace sk_buff ** with sk_buff * in input handlers
From: David Miller @ 2007-10-15 8:29 UTC (permalink / raw)
To: herbert; +Cc: kaber, hadi, netdev, kuznet, yoshfuji, tgraf
In-Reply-To: <E1Ih4m9-0003s7-00@gondolin.me.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sun, 14 Oct 2007 22:49:05 +0800
> [IPV6]: Replace sk_buff ** with sk_buff * in input handlers
>
> With all the users of the double pointers removed from the IPv6 input path,
> this patch converts all occurances of sk_buff ** to sk_buff * in IPv6 input
> handlers.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Also applied, thanks Herbert.
^ permalink raw reply
* Re: [PATCH 3/3] [IPV6]: Replace sk_buff ** with sk_buff * in input handlers
From: David Miller @ 2007-10-15 8:30 UTC (permalink / raw)
To: yoshfuji; +Cc: herbert, kaber, hadi, netdev, kuznet, tgraf
In-Reply-To: <20071015.004303.71155143.yoshfuji@linux-ipv6.org>
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@linux-ipv6.org>
Date: Mon, 15 Oct 2007 00:43:03 +0900 (JST)
> Herbert,
>
> I really appreciate this work.
> Thank you!
Indeed, I do too.
Thanks again Herbert!
^ permalink raw reply
* [IPV6]: Uninline netfilter okfns
From: Patrick McHardy @ 2007-10-15 8:30 UTC (permalink / raw)
To: Herbert Xu; +Cc: David Miller, hadi, netdev, kuznet
In-Reply-To: <47131D64.3080008@trash.net>
[-- Attachment #1: Type: text/plain, Size: 145 bytes --]
Turns out IPv6 only has two functions which are marked inline
and where gcc is able to generate tail-calls, bridging doesn't
have a single one.
[-- Attachment #2: x --]
[-- Type: text/plain, Size: 1718 bytes --]
[IPV6]: Uninline netfilter okfns
Uninline netfilter okfns for those cases where gcc can generate tail-calls.
Before:
text data bss dec hex filename
8994153 1016524 524652 10535329 a0c1a1 vmlinux
After:
text data bss dec hex filename
8992761 1016524 524652 10533937 a0bc31 vmlinux
-------------------------------------------------------
-1392
All cases have been verified to generate tail-calls with and without netfilter.
Signed-off-by: Patrick McHardy <kaber@trash.net>
---
commit 2a33a3e84be9c078de91ddf7496dbf026fe86ce2
tree e9401bf6eaafb1efeca6bb6f0e8ef013e1932513
parent 39533dafc9b0458fecebd2da36d682837c6ff9a2
author Patrick McHardy <kaber@trash.net> Mon, 15 Oct 2007 10:25:34 +0200
committer Patrick McHardy <kaber@trash.net> Mon, 15 Oct 2007 10:25:34 +0200
net/ipv6/ip6_input.c | 2 +-
net/ipv6/ip6_output.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv6/ip6_input.c b/net/ipv6/ip6_input.c
index af355df..fac6f7f 100644
--- a/net/ipv6/ip6_input.c
+++ b/net/ipv6/ip6_input.c
@@ -149,7 +149,7 @@ out:
*/
-static inline int ip6_input_finish(struct sk_buff *skb)
+static int ip6_input_finish(struct sk_buff *skb)
{
struct inet6_protocol *ipprot;
struct sock *raw_sk;
diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c
index 011082e..13565df 100644
--- a/net/ipv6/ip6_output.c
+++ b/net/ipv6/ip6_output.c
@@ -70,7 +70,7 @@ static __inline__ void ipv6_select_ident(struct sk_buff *skb, struct frag_hdr *f
spin_unlock_bh(&ip6_id_lock);
}
-static inline int ip6_output_finish(struct sk_buff *skb)
+static int ip6_output_finish(struct sk_buff *skb)
{
struct dst_entry *dst = skb->dst;
^ permalink raw reply related
* Re: drivers/net/niu.c: possible array overflows
From: David Miller @ 2007-10-15 8:36 UTC (permalink / raw)
To: bunk; +Cc: davem, jgarzik, netdev, linux-kernel
In-Reply-To: <20071014175024.GH4211@stusta.de>
From: Adrian Bunk <bunk@kernel.org>
Date: Sun, 14 Oct 2007 19:50:24 +0200
> The Coverity checker spotted the following in drivers/net/niu.c:
Thanks for the report Adrian, I'll fix it like this:
commit 503211a947ab13fb44d920f78f1e19057efc277f
Author: David S. Miller <davem@sunset.davemloft.net>
Date: Mon Oct 15 01:36:24 2007 -0700
[NIU]: Fix write past end of array in niu_pci_probe_sprom().
Noticed by Coverity checker and reported by Adrian Bunk.
Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/net/niu.c b/drivers/net/niu.c
index 43bfe7e..54166bd 100644
--- a/drivers/net/niu.c
+++ b/drivers/net/niu.c
@@ -6213,7 +6213,7 @@ static int __devinit niu_pci_probe_sprom(struct niu *np)
val = nr64(ESPC_MOD_STR_LEN);
niudbg(PROBE, "SPROM: MOD_STR_LEN[%llu]\n",
(unsigned long long) val);
- if (val > 8 * 4)
+ if (val >= 8 * 4)
return -EINVAL;
for (i = 0; i < val; i += 4) {
@@ -6229,7 +6229,7 @@ static int __devinit niu_pci_probe_sprom(struct niu *np)
val = nr64(ESPC_BD_MOD_STR_LEN);
niudbg(PROBE, "SPROM: BD_MOD_STR_LEN[%llu]\n",
(unsigned long long) val);
- if (val > 4 * 4)
+ if (val >= 4 * 4)
return -EINVAL;
for (i = 0; i < val; i += 4) {
^ permalink raw reply related
* Re: [2.6 patch] __inet6_csk_dst_store(): fix check-after-use
From: David Miller @ 2007-10-15 8:38 UTC (permalink / raw)
To: takamiya; +Cc: nakam, bunk, netdev, linux-kernel
In-Reply-To: <20071015.123749.497715418.takamiya@po.ntts.co.jp>
From: Noriaki TAKAMIYA <takamiya@po.ntts.co.jp>
Date: Mon, 15 Oct 2007 12:37:49 +0900 (JST)
> >
> > On Sun, 14 Oct 2007 19:52:12 +0200
> > Adrian Bunk <bunk@kernel.org> wrote:
> >
> > > The Coverity checker spotted that we have already oops'ed if "dst"
> > > was NULL.
> > >
> > > Since "dst" being NULL doesn't seem to be possible at this point this
> > > patch removes the NULL check.
> > >
> > > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> >
> > Agreed.
> >
> > Acked-by: Masahide NAKAMURA <nakam@linux-ipv6.org>
>
> I also agreed.
>
> Acked-by: Noriaki TAKAMIYA <takamiya@po.ntts.co.jp>
Patch applied, thanks everyone!
^ permalink raw reply
* Re: Don't leak 'listeners' in netlink_kernel_create()
From: David Miller @ 2007-10-15 8:39 UTC (permalink / raw)
To: ebiederm; +Cc: jesper.juhl, netdev, linux-kernel, alan, kuznet
In-Reply-To: <m1hckt5nyp.fsf@ebiederm.dsl.xmission.com>
From: ebiederm@xmission.com (Eric W. Biederman)
Date: Sun, 14 Oct 2007 16:30:06 -0600
> Jesper Juhl <jesper.juhl@gmail.com> writes:
>
> > From: Jesper Juhl <jesper.juhl@gmail.com>
> > Subject: Don't leak 'listeners' in netlink_kernel_create()
> >
> > The Coverity checker spotted that we'll leak the storage allocated
> > to 'listeners' in netlink_kernel_create() when the
> > if (!nl_table[unit].registered)
> > check is false.
> >
> > This patch avoids the leak.
> >
> >
> > Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
>
> This patch appears trivially correct to me.
> Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
Applied, thanks everyone.
^ permalink raw reply
* Re: [NET]: Fix csum_start update in pskb_expand_head
From: David Miller @ 2007-10-15 8:46 UTC (permalink / raw)
To: herbert; +Cc: guichaz, netdev
In-Reply-To: <20071015045723.GA28388@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Mon, 15 Oct 2007 12:57:23 +0800
> On Sun, Oct 14, 2007 at 08:20:37PM +0000, Guillaume Chazarain wrote:
> >
> > Just another data point, it seems that running the standard Bittorrent
> > client helps triggering the bug.
>
> Doh! It was my patch a month ago which added code to update
> csum_start if the headroom changed that broke this.
>
> We'll need this patch for stable as well.
>
> [NET]: Fix csum_start update in pskb_expand_head
>
> I got confused by the dual nature of the off variable in the
> function pskb_expand_head. The csum_start offset should use
> nhead instead of off which can change depending on whether we
> are using offsets or pointers.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied and I'll take care of the -stable submission.
^ permalink raw reply
* Re: [NET]: Avoid copying TCP packets unnecessarily
From: David Miller @ 2007-10-15 8:47 UTC (permalink / raw)
To: herbert; +Cc: guichaz, netdev
In-Reply-To: <20071015055457.GA28799@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Mon, 15 Oct 2007 13:54:57 +0800
> On Mon, Oct 15, 2007 at 12:57:23PM +0800, Herbert Xu wrote:
> >
> > However, the fact that you're triggering this code at all tells
> > us that there is another bug further up the chain that's causing
> > us to generate partial checksums even though the NIC doesn't
> > support it. Can you please give me the output of
>
> Nevermind, tcp_fragment can generate such packets out of
> convenience.
>
> Here's a little optimisation to avoid copying the packet in
> this case.
>
> [NET]: Avoid copying TCP packets unnecessarily
>
> TCP packets all have writable heads, that is, even though it's cloned, it is
> writable up to the end of the TCP header. This patch makes skb_checksum_help
> aware of this fact by using skb_clone_writable and avoiding a copy for TCP.
>
> I've also modified the BUG_ON tests to be unsigned. The only case where this
> makes a difference is if csum_start points to a location before skb->data.
> Since skb->data should always include the header where the checksum field
> is (and all currently callers adhere to that), this change is safe and may
> uncover bugs later.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied, thanks Herbert!
^ permalink raw reply
* Re: [IPV4]: Uninline netfilter okfns
From: David Miller @ 2007-10-15 8:49 UTC (permalink / raw)
To: kaber; +Cc: herbert, hadi, netdev, kuznet
In-Reply-To: <47131D64.3080008@trash.net>
From: Patrick McHardy <kaber@trash.net>
Date: Mon, 15 Oct 2007 09:57:24 +0200
> Your patches work fine so far, tested with fragments, packet
> content mangling etc. Thanks again for doing this. And they
> really do enable gcc to generate tail-calls for the NF_HOOK
> okfns, so this patch changes net/ipv4 to take advantage of
> this. IPv6 and bridge will follow ...
Applied, thanks Patrick!
^ permalink raw reply
* Re: [PATCH 6/10] [BRIDGE]: Unshare skb upon entry
From: David Miller @ 2007-10-15 8:50 UTC (permalink / raw)
To: kaber; +Cc: herbert, hadi, netdev, kuznet
In-Reply-To: <471314A0.5080500@trash.net>
From: Patrick McHardy <kaber@trash.net>
Date: Mon, 15 Oct 2007 09:20:00 +0200
> Herbert Xu wrote:
> > [BRIDGE]: Unshare skb upon entry
> >
> > Due to the special location of the bridging hook, it should never see a
> > shared packet anyway (certainly not with any in-kernel code). So it
> > makes sense to unshare the skb there if necessary as that will greatly
> > simplify the code below it (in particular, netfilter).
>
>
> I guess we can remove the unsharing from br_netfilter.c now.
>
> Signed-off-by: Patrick McHardy <kaber@trash.net>
Applied, thanks Patrick!
^ permalink raw reply
* Re: [IPV6]: Uninline netfilter okfns
From: David Miller @ 2007-10-15 8:51 UTC (permalink / raw)
To: kaber; +Cc: herbert, hadi, netdev, kuznet
In-Reply-To: <4713251B.4070208@trash.net>
From: Patrick McHardy <kaber@trash.net>
Date: Mon, 15 Oct 2007 10:30:19 +0200
> Turns out IPv6 only has two functions which are marked inline
> and where gcc is able to generate tail-calls, bridging doesn't
> have a single one.
Applied, thanks Patrick!
^ permalink raw reply
* Re: [PATCH 3/5] [IPV6]: Add skb_is_gso_v6
From: David Miller @ 2007-10-15 9:06 UTC (permalink / raw)
To: brice; +Cc: jeff, netdev, herbert
In-Reply-To: <47109EFC.3020601@myri.com>
From: Brice Goglin <brice@myri.com>
Date: Sat, 13 Oct 2007 12:33:32 +0200
> Add skb_is_gso_v6().
>
> Signed-off-by: Brice Goglin <brice@myri.com>
No objections from me:
Acked-by: David S. Miller <davem@davemloft.net>
Jeff, it's simplest if you just merge this in with the
rest of the myri10ge patches, so please do so.
Thanks!
^ permalink raw reply
* Re: [PATCH] [TCP]: high_seq parameter removed (all callers use tp->high_seq)
From: David Miller @ 2007-10-15 9:10 UTC (permalink / raw)
To: ilpo.jarvinen; +Cc: netdev
In-Reply-To: <Pine.LNX.4.64.0710121640200.3767@kivilampi-30.cs.helsinki.fi>
From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Fri, 12 Oct 2007 17:02:18 +0300 (EEST)
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
> ---
>
> Compile tested with 2.6.23 as current Linus' tree provides an
> hilarious building failure to our net-2.6 sandbox... :-)
Applied, thanks :-)
^ permalink raw reply
* Re: 2.6.23-rc8-mm2 BUG: register_netdevice() issue as (ab)used by ISDN
From: David Miller @ 2007-10-15 9:12 UTC (permalink / raw)
To: kkeil; +Cc: andi, jeff, isdn4linux, netdev, akpm, shemminger
In-Reply-To: <20071012140521.GA28413@pingi.kke.suse.de>
From: Karsten Keil <kkeil@suse.de>
Date: Fri, 12 Oct 2007 16:05:22 +0200
> This is a followup to the previous ISDN alloc_netdev() patch.
> It removes the local copy of the device name to make sure
> that device renames work.
>
> Signed-off-by: Karsten Keil <kkeil@suse.de>
Applied, thanks!
^ permalink raw reply
* Re: [TG3]: Fix performance regression on 5705.
From: David Miller @ 2007-10-15 9:14 UTC (permalink / raw)
To: mchan; +Cc: netdev, mcarlson, andy
In-Reply-To: <1192217947.6987.2.camel@dell>
From: "Michael Chan" <mchan@broadcom.com>
Date: Fri, 12 Oct 2007 12:39:07 -0700
> [TG3]: Fix performance regression on 5705.
>
> A performance regression was introduced by the following commit:
>
> commit ee6a99b539a50b4e9398938a0a6d37f8bf911550
> Author: Michael Chan <mchan@broadcom.com>
> Date: Wed Jul 18 21:49:10 2007 -0700
>
> [TG3]: Fix msi issue with kexec/kdump.
>
> In making that change, the PCI latency timer and cache line size
> registers were not restored after chip reset. On the 5705, the
> latency timer gets reset to 0 during chip reset and this causes
> very poor performance.
>
> Update version to 3.84.
>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied, thanks Michael.
This might be what was causing the 5714 performance problems I was
seeing on one of my systems, I'll go check that out when I get a
chance.
Thanks again!
^ permalink raw reply
* Re: [NET]: Fix csum_start update in pskb_expand_head
From: Guillaume Chazarain @ 2007-10-15 9:21 UTC (permalink / raw)
To: Herbert Xu; +Cc: David S. Miller, netdev
In-Reply-To: <20071015045723.GA28388@gondor.apana.org.au>
Le Mon, 15 Oct 2007 12:57:23 +0800,
Herbert Xu <herbert@gondor.apana.org.au> a écrit :
> [NET]: Fix csum_start update in pskb_expand_head
> [NET]: Avoid copying TCP packets unnecessarily
I am Bittorrenting for a few hours with these patches, and they seem to
work well. Thanks for the quick response.
> ethtool -k <IFNAME>
eth1 is an ipw2200
[root ~]# ethtool -k eth1
Offload parameters for eth1:
Cannot get device rx csum settings: Operation not supported
rx-checksumming: off
tx-checksumming: off
scatter-gather: off
tcp segmentation offload: off
udp fragmentation offload: off
generic segmentation offload: off
Just in case you get a new interest ;-)
Thanks.
--
Guillaume
^ permalink raw reply
* Re: [PATCH 1/9] Move common fields from frag_queues in one place
From: David Miller @ 2007-10-15 9:24 UTC (permalink / raw)
To: xemul; +Cc: kaber, netdev, devel
In-Reply-To: <470F6FD6.20004@openvz.org>
From: Pavel Emelyanov <xemul@openvz.org>
Date: Fri, 12 Oct 2007 17:00:06 +0400
> Introduce the struct inet_frag_queue in include/net/inet_frag.h
> file and place there all the common fields from three structs:
>
> * struct ipq in ipv4/ip_fragment.c
> * struct nf_ct_frag6_queue in nf_conntrack_reasm.c
> * struct frag_queue in ipv6/reassembly.c
>
> After this, replace these fields on appropriate structures with
> this structure instance and fix the users to use correct names
> i.e. hunks like
>
> - atomic_dec(&fq->refcnt);
> + atomic_dec(&fq->q.refcnt);
>
> (these occupy most of the patch)
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Applied.
^ permalink raw reply
* Re: [PATCH 2/9] Collect frag queues management objects together
From: David Miller @ 2007-10-15 9:32 UTC (permalink / raw)
To: xemul; +Cc: kaber, netdev, devel
In-Reply-To: <470F7145.6080707@openvz.org>
From: Pavel Emelyanov <xemul@openvz.org>
Date: Fri, 12 Oct 2007 17:06:13 +0400
> There are some objects that are common in all the places
> which are used to keep track of frag queues, they are:
>
> * hash table
> * LRU list
> * rw lock
> * rnd number for hash function
> * the number of queues
> * the amount of memory occupied by queues
> * secret timer
>
> Move all this stuff into one structure (struct inet_frags)
> to make it possible use them uniformly in the future. Like
> with the previous patch this mostly consists of hunks like
>
> - write_lock(&ipfrag_lock);
> + write_lock(&ip4_frags.lock);
>
> To address the issue with exporting the number of queues and
> the amount of memory occupied by queues outside the .c file
> they are declared in, I introduce a couple of helpers.
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Applied.
'ipfrag_secret_timer' became unused, so I deleted it in this
patch too.
^ permalink raw reply
* Re: [PATCH 3/9] Collect common sysctl variables together
From: David Miller @ 2007-10-15 9:33 UTC (permalink / raw)
To: xemul; +Cc: kaber, netdev, devel
In-Reply-To: <470F722D.90207@openvz.org>
From: Pavel Emelyanov <xemul@openvz.org>
Date: Fri, 12 Oct 2007 17:10:05 +0400
> Some sysctl variables are used to tune the frag queues
> management and it will be useful to work with them in
> a common way in the future, so move them into one
> structure, moreover they are the same for all the frag
> management codes.
>
> I don't place them in the existing inet_frags object,
> introduced in the previous patch for two reasons:
>
> 1. to keep them in the __read_mostly section;
> 2. not to export the whole inet_frags objects outside.
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Applied.
^ permalink raw reply
* Re: [PATCH 4/9] Consolidate the xxx_frag_kill
From: David Miller @ 2007-10-15 9:37 UTC (permalink / raw)
To: xemul; +Cc: kaber, netdev, devel
In-Reply-To: <470F72CB.6010109@openvz.org>
From: Pavel Emelyanov <xemul@openvz.org>
Date: Fri, 12 Oct 2007 17:12:43 +0400
> Since now all the xxx_frag_kill functions now work
> with the generic inet_frag_queue data type, this can
> be moved into a common place.
>
> The xxx_unlink() code is moved as well.
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Applied.
^ permalink raw reply
* Re: [PATCH 5/9] Consolidate xxx_the secret_rebuild
From: David Miller @ 2007-10-15 9:38 UTC (permalink / raw)
To: xemul; +Cc: kaber, netdev, devel
In-Reply-To: <470F73A9.5070102@openvz.org>
From: Pavel Emelyanov <xemul@openvz.org>
Date: Fri, 12 Oct 2007 17:16:25 +0400
> This code works with the generic data types as well, so
> move this into inet_fragment.c
>
> This move makes it possible to hide the secret_timer
> management and the secret_rebuild routine completely in
> the inet_fragment.c
>
> Introduce the ->hashfn() callback in inet_frags() to get
> the hashfun for a given inet_frag_queue() object.
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Applied.
^ permalink raw reply
* Re: [PATCH 6/9] Consolidate the xxx_frag_destroy
From: David Miller @ 2007-10-15 9:39 UTC (permalink / raw)
To: xemul; +Cc: kaber, netdev, devel
In-Reply-To: <470F74C2.9060301@openvz.org>
From: Pavel Emelyanov <xemul@openvz.org>
Date: Fri, 12 Oct 2007 17:21:06 +0400
> To make in possible we need to know the exact frag queue
> size for inet_frags->mem management and two callbacks:
>
> * to destoy the skb (optional, used in conntracks only)
> * to free the queue itself (mandatory, but later I plan to
> move the allocation and the destruction of frag_queues
> into the common place, so this callback will most likely
> be optional too).
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Applied.
^ permalink raw reply
* Re: [PATCH 7/9] Consolidate the xxx_evictor
From: David Miller @ 2007-10-15 9:40 UTC (permalink / raw)
To: xemul; +Cc: kaber, netdev, devel
In-Reply-To: <470F758B.5090508@openvz.org>
From: Pavel Emelyanov <xemul@openvz.org>
Date: Fri, 12 Oct 2007 17:24:27 +0400
> The evictors collect some statistics for ipv4 and ipv6,
> so make it return the number of evicted queues and account
> them all at once in the caller.
>
> The XXX_ADD_STATS_BH() macros are just for this case,
> but maybe there are places in code, that can make use of
> them as well.
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Applied, thanks!
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox