* Re: [patch 1/1][NETNS][IPV6] protect addrconf from loopback registration
From: YOSHIFUJI Hideaki / 吉藤英明 @ 2007-11-13 1:52 UTC (permalink / raw)
To: ebiederm
Cc: dlezcano, den, davem, netdev, xemul, containers, benjamin.thery,
yoshfuji
In-Reply-To: <m16407450i.fsf@ebiederm.dsl.xmission.com>
In article <m16407450i.fsf@ebiederm.dsl.xmission.com> (at Mon, 12 Nov 2007 12:50:53 -0700), ebiederm@xmission.com (Eric W. Biederman) says:
> My opinion is that both your analysis is slightly off (as to the cause
> of your problems) and that your approach to fix your problem is wrong
> because you don't untangle the knot you keep it.
:
> I have register_pernet_subsys and register_per_net_device to ensure
> that when we create a new network namespace all of the subsystems are
> initialized before the network devices are initialize. So ipv6 should
> be ready before we initialize the new loopback device comes into
> existence.
User may not load ipv6.ko at boot, and then do "modprobe ipv6".
Do you take this into account?
--yoshfuji
^ permalink raw reply
* Re: [PATCH] - drivers/net/ppp_* - remove ptr comparisons to 0
From: David Miller @ 2007-11-13 2:07 UTC (permalink / raw)
To: joe; +Cc: paulus, linux-ppp, netdev, jgarzik, akpm
In-Reply-To: <1194910431.9407.53.camel@localhost>
From: Joe Perches <joe@perches.com>
Date: Mon, 12 Nov 2007 15:33:51 -0800
> fix sparse warnings "Using plain integer as NULL pointer"
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied, thanks Joe.
^ permalink raw reply
* Re: [PATCH] sungem: fix suspend regression due to NAPI changes
From: David Miller @ 2007-11-13 2:09 UTC (permalink / raw)
To: benh; +Cc: johannes, netdev, linuxppc-dev, shemminger
In-Reply-To: <1194906766.18185.79.camel@pasglop>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Tue, 13 Nov 2007 09:32:46 +1100
>
> On Mon, 2007-11-12 at 18:45 +0100, Johannes Berg wrote:
> > Commit bea3348e (the NAPI changes) made sungem unconditionally enable
> > NAPI when resuming and unconditionally disable when suspending, this,
> > however, makes napi_disable() hang when suspending when the interface
> > was taken down before suspend because taking the interface down also
> > disables NAPI. This patch makes touching the napi struct in
> > suspend/resume code paths depend on having the interface up, thereby
> > fixing the hang on suspend.
> >
> > The patch also moves the napi_disable() in gem_close() under the lock so
> > that the NAPI state is always modified atomically together with the
> > "opened" variable.
> >
> > Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
>
> Thanks for fixing that !
>
> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Indeed, thanks a lot Johannes.
Patch applied.
^ permalink raw reply
* Re: [PATCH][RESEND] NET: Add the helper kernel_sock_shutdown()
From: David Miller @ 2007-11-13 2:10 UTC (permalink / raw)
To: Trond.Myklebust; +Cc: netdev
In-Reply-To: <1194898764.7465.65.camel@heimdal.trondhjem.org>
From: Trond Myklebust <Trond.Myklebust@netapp.com>
Date: Mon, 12 Nov 2007 15:19:24 -0500
> ...and fix a couple of bugs in the NBD, CIFS and OCFS2 socket handlers.
>
> Looking at the sock->op->shutdown() handlers, it looks as if all of them
> take a SHUT_RD/SHUT_WR/SHUT_RDWR argument instead of the
> RCV_SHUTDOWN/SEND_SHUTDOWN arguments.
> Add a helper, and then define the SHUT_* enum to ensure that kernel users
> of shutdown() don't get confused.
>
> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
> Cc: Paul Clements <Paul.Clements@steeleye.com>
> Acked-by: Mark Fasheh <mark.fasheh@oracle.com>
> Cc: Steve French <sfrench@samba.org>
> Acked-by: David Howells <dhowells@redhat.com>
> Cc: David S. Miller <davem@davemloft.net>
Applied, thanks Trond.
^ permalink raw reply
* [PATCH] bonding: Fix resource use after free
From: Jay Vosburgh @ 2007-11-13 2:15 UTC (permalink / raw)
To: netdev; +Cc: davem, jgarzik, monis, Jay Vosburgh
Fix bond_destroy and bond_free_all to not reference the
struct net_device after calling unregister_netdevice.
Bug and offending change reported by Moni Shoua <monis@voltaire.com>
Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
---
Copying DaveM since Jeff is out this week; please apply for 2.6.24.
-J
drivers/net/bonding/bond_main.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index a198404..423298c 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -1847,9 +1847,9 @@ int bond_release(struct net_device *bond_dev, struct net_device *slave_dev)
*/
void bond_destroy(struct bonding *bond)
{
- unregister_netdevice(bond->dev);
bond_deinit(bond->dev);
bond_destroy_sysfs_entry(bond);
+ unregister_netdevice(bond->dev);
}
/*
@@ -4475,8 +4475,8 @@ static void bond_free_all(void)
bond_mc_list_destroy(bond);
/* Release the bonded slaves */
bond_release_all(bond_dev);
- unregister_netdevice(bond_dev);
bond_deinit(bond_dev);
+ unregister_netdevice(bond_dev);
}
#ifdef CONFIG_PROC_FS
--
1.5.3.1
^ permalink raw reply related
* Re: [GIT PATCHES v2] SCTP bug fixes
From: David Miller @ 2007-11-13 5:01 UTC (permalink / raw)
To: vladislav.yasevich; +Cc: netdev, lksctp-developers
In-Reply-To: <11948855091808-git-send-email-vladislav.yasevich@hp.com>
From: Vlad Yasevich <vladislav.yasevich@hp.com>
Date: Mon, 12 Nov 2007 11:38:15 -0500
> I've updated the series of SCTP bugfixes. These pass all of the regression
> tests.
>
> You can pull the changes from:
> master.kernel.org:/pub/scm/linux/kernel/git/vxy/lksctp-dev.git pending
Pulled, thanks a lot Vlad.
^ permalink raw reply
* Re: [PATCH 1/1] [INET]: Remove leftover prototypes from include/net/inet_common.h
From: David Miller @ 2007-11-13 5:03 UTC (permalink / raw)
To: acme; +Cc: netdev
In-Reply-To: <20071107192016.GB32752@ghostprotocols.net>
From: Arnaldo Carvalho de Melo <acme@redhat.com>
Date: Wed, 7 Nov 2007 17:20:16 -0200
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Applied, thanks Arnaldo!
^ permalink raw reply
* Re: [2.6 patch] remove references to net-modules.txt
From: David Miller @ 2007-11-13 5:04 UTC (permalink / raw)
To: bunk; +Cc: jgarzik, netdev, linux-kernel
In-Reply-To: <20071109060141.GM26163@stusta.de>
From: Adrian Bunk <bunk@kernel.org>
Date: Fri, 9 Nov 2007 07:01:41 +0100
> When I removed net-modules.txt because it only contained ancient
> information I missed that many Kconfig entries pointed to this ancient
> information.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
Applied, thanks Adrian.
^ permalink raw reply
* Re: [PATCH] [AF_PACKET] Fix minor code duplication
From: David Miller @ 2007-11-13 5:05 UTC (permalink / raw)
To: urs.thuermann; +Cc: netdev
In-Reply-To: <ygfpryjaoe9.fsf@janus.isnogud.escape.de>
From: Urs Thuermann <urs.thuermann@gmx.de>
Date: 09 Nov 2007 08:06:38 +0100
> Simplify some code by eliminating duplicate if-else clauses in
> packet_do_bind().
>
> Signed-off-by: Urs Thuermann <urs@isnogud.escape.de>
Applied, thanks Urs.
^ permalink raw reply
* Re: [PATCH 1/13] tg3: Fix 5761 PXEboot crash
From: David Miller @ 2007-11-13 5:07 UTC (permalink / raw)
To: mcarlson; +Cc: netdev, andy, mchan
In-Reply-To: <1194655117.5745.263.camel@teletran1>
From: "Matt Carlson" <mcarlson@broadcom.com>
Date: Fri, 09 Nov 2007 16:38:37 -0800
> When 5761 devices boot the machine using PXEboot, PXE leaves the device
> active when it terminates. The tg3 driver has code to detect this
> condition and resets the device during initialization. On 5761 devices,
> device resets involve sending a driver state update message to the APE
> on the 5761. However, during this initialization stage, communications
> to the APE registers have not yet been set up. The driver then
> dereferences a NULL pointer and crashes the machine. The fix is to move
> the APE register access setup earlier in the initialization code to
> cover this condition.
>
> Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Patch applied.
^ permalink raw reply
* Re: [PATCH 2/13] tg3: 5784 / 5764 GPHY power down fix
From: David Miller @ 2007-11-13 5:08 UTC (permalink / raw)
To: mcarlson; +Cc: netdev, andy, mchan
In-Reply-To: <1194655120.5745.264.camel@teletran1>
From: "Matt Carlson" <mcarlson@broadcom.com>
Date: Fri, 09 Nov 2007 16:38:40 -0800
> 5784 and 5764 devices fail to link / pass traffic after one load /
> unload cycle. This happens because of a hardware bug in the new CPMU.
> During normal operation, the MAC depends on the PHY clock being
> available. When the PHY is powered down, the clock the MAC depends on
> is disabled. The fix is to switch the MAC clock to an alternate source
> before powering down the PHY, and to restore the MAC clock to the PHY
> source upon device resume.
>
> Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied, thanks Matt.
^ permalink raw reply
* Re: [PATCH 3/13] tg3: APE flag fix
From: David Miller @ 2007-11-13 5:09 UTC (permalink / raw)
To: mcarlson; +Cc: netdev, andy, mchan
In-Reply-To: <1194655123.5745.265.camel@teletran1>
From: "Matt Carlson" <mcarlson@broadcom.com>
Date: Fri, 09 Nov 2007 16:38:43 -0800
> This patch corrects a bug where the ENABLE_APE flag was tested against
> the wrong flag variable.
>
> Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Good catch, patch applied. Thanks Matt.
^ permalink raw reply
* Re: [PATCH 4/13] tg3: 5784 / 5764 DMA engine lockup fix
From: David Miller @ 2007-11-13 5:10 UTC (permalink / raw)
To: mcarlson; +Cc: netdev, andy, mchan
In-Reply-To: <1194655126.5745.266.camel@teletran1>
From: "Matt Carlson" <mcarlson@broadcom.com>
Date: Fri, 09 Nov 2007 16:38:46 -0800
> 5784 and 5764 devices lock up when the link speed is 10Mbps, the CPMU
> link speed mode is enabled, and the MAC clock is running at 1.5Mhz. The
> fix is to run the MAC clock at faster speeds.
>
> Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Patch applied, thanks!
^ permalink raw reply
* Re: [PATCH 5/13] tg3: Fix nvram selftest failures
From: David Miller @ 2007-11-13 5:11 UTC (permalink / raw)
To: mcarlson; +Cc: netdev, andy, mchan
In-Reply-To: <1194655129.5745.267.camel@teletran1>
From: "Matt Carlson" <mcarlson@broadcom.com>
Date: Fri, 09 Nov 2007 16:38:49 -0800
> Newer devices contain bootcode in the chip's private ROM area. This
> bootcode is called selfboot. Selfboot can be patched in the device's
> NVRAM and the patches can have several formats. In one particular
> format, the checksum calculation needs to be slightly modified. This
> patch adjusts the NVRAM test code for that case, and add support for the
> missing formats.
>
> Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied, thanks Matt.
^ permalink raw reply
* Re: [PATCH 6/13] tg3: CPMU adjustments for loopback tests
From: David Miller @ 2007-11-13 5:12 UTC (permalink / raw)
To: mcarlson; +Cc: netdev, andy, mchan
In-Reply-To: <1194655132.5745.268.camel@teletran1>
From: "Matt Carlson" <mcarlson@broadcom.com>
Date: Fri, 09 Nov 2007 16:38:52 -0800
> This patch adds the LINK_SPEED mode to the list of CPMU modes that can
> cause the loopback tests to fail. These bugs are planned to be fixed in
> future revisions of the chip, so the patch qualifies the fixes as such.
>
> Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied, thanks!
^ permalink raw reply
* Re: [PATCH 7/13] tg3: Disable GPHY autopowerdown
From: David Miller @ 2007-11-13 5:16 UTC (permalink / raw)
To: mcarlson; +Cc: netdev, andy, mchan
In-Reply-To: <1194655134.5745.269.camel@teletran1>
From: "Matt Carlson" <mcarlson@broadcom.com>
Date: Fri, 09 Nov 2007 16:38:54 -0800
> New CPMU devices contend with the GPHY for power management. The GPHY
> autopowerdown feature is enabled by default in the PHY and thus needs to
> be disabled after every PHY reset.
>
> Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Patch applied, thanks.
^ permalink raw reply
* Re: [PATCH 8/13] tg3: Limit 5784 / 5764 to MAC LED mode
From: David Miller @ 2007-11-13 5:17 UTC (permalink / raw)
To: mcarlson; +Cc: netdev, andy, mchan
In-Reply-To: <1194655137.5745.270.camel@teletran1>
From: "Matt Carlson" <mcarlson@broadcom.com>
Date: Fri, 09 Nov 2007 16:38:56 -0800
> Most 5784 / 5764 LED modes do not work as expected because of a hardware
> bug. This patch forces the LED mode to be in MAC LED mode.
>
> Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Patch applied, thanks Matt.
^ permalink raw reply
* Re: [PATCH 9/13] tg3: Prescaler fix
From: David Miller @ 2007-11-13 5:18 UTC (permalink / raw)
To: mcarlson; +Cc: netdev, andy, mchan
In-Reply-To: <1194655139.5745.271.camel@teletran1>
From: "Matt Carlson" <mcarlson@broadcom.com>
Date: Fri, 09 Nov 2007 16:38:59 -0800
> Internal hardware timers become inaccurate after link events. Clock
> frequency switches performed by the CPMU fail to adjust timer
> prescalers. The fix is to detect core clock frequency changes during
> link events and adjust the timer prescalers accordingly.
>
> Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
This CPMU seems very sensitive in it's MAC/PHY interactions.
:-)
Patch applied, thanks!
^ permalink raw reply
* Re: [PATCH 10/13] tg3: Increase the PCI MRRS
From: David Miller @ 2007-11-13 5:21 UTC (permalink / raw)
To: mcarlson; +Cc: netdev, andy, mchan
In-Reply-To: <1194655141.5745.272.camel@teletran1>
From: "Matt Carlson" <mcarlson@broadcom.com>
Date: Fri, 09 Nov 2007 16:39:01 -0800
> Previous devices hardcoded the PCI Maximum Read Request Size to 4K. To
> better comply with the PCI spec, the hardware now defaults the MRRS to
> 512 bytes. This will yield poor driver performance if left untouched.
> This patch increases the MRRS to 4K on driver initialization.
>
> Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
I've applied this patch, but...
I sense that the PCI spec wants devices to use an MRRS value of 512 in
order to get better fairness on a PCI-E segment amongst multiple
devices.
>From that perspective, jacking up the MRRS to 4096 unilaterally seems
like a very bad idea. If this was necessary for good performance, I'm
sure the PCI spec folks would have choosen a higher value.
Or is this some tg3 specific performance issue?
^ permalink raw reply
* Re: [PATCH 11/13] tg3: Add A1 revs
From: David Miller @ 2007-11-13 5:22 UTC (permalink / raw)
To: mcarlson; +Cc: netdev, andy, mchan
In-Reply-To: <1194655144.5745.273.camel@teletran1>
From: "Matt Carlson" <mcarlson@broadcom.com>
Date: Fri, 09 Nov 2007 16:39:04 -0800
> This patch adds the A1 revision of 5784, 5764, and 5761, and applies all
> previous bugfixes. In places where the list of devices gets too long,
> the patch uses a new TG3_FLG3_5761_5784_AX_FIXES flag instead.
>
> Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied, thanks Matt.
^ permalink raw reply
* Re: [PATCH 12/13] tg3: MII => TP
From: David Miller @ 2007-11-13 5:22 UTC (permalink / raw)
To: mcarlson; +Cc: netdev, andy, mchan
In-Reply-To: <1194655147.5745.274.camel@teletran1>
From: "Matt Carlson" <mcarlson@broadcom.com>
Date: Fri, 09 Nov 2007 16:39:07 -0800
> This patch changes the PHY type reported through ethtool for copper
> devices from MII to TP. The latter is more accurate.
>
> Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Patch applied, thanks.
^ permalink raw reply
* Re: [PATCH 13/13] tg3: Update version to 3.86
From: David Miller @ 2007-11-13 5:23 UTC (permalink / raw)
To: mcarlson; +Cc: netdev, andy, mchan
In-Reply-To: <1194655150.5745.275.camel@teletran1>
From: "Matt Carlson" <mcarlson@broadcom.com>
Date: Fri, 09 Nov 2007 16:39:10 -0800
> This patch updates the version number to 3.86
>
> Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Also applied, thanks a lot.
^ permalink raw reply
* Re: [2.6 patch] unexport sysctl_{r,w}mem_max
From: David Miller @ 2007-11-13 5:24 UTC (permalink / raw)
To: bunk; +Cc: netdev
In-Reply-To: <20071111064837.GI21669@stusta.de>
From: Adrian Bunk <bunk@kernel.org>
Date: Sun, 11 Nov 2007 07:48:37 +0100
> sysctl_{r,w}mem_max can now be unexported.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
Applied, thanks Adrian.
^ permalink raw reply
* Re: [2.6 patch] net/ipv4/ipvs/: remove unused exports
From: David Miller @ 2007-11-13 5:25 UTC (permalink / raw)
To: bunk; +Cc: rumen, wensong, horms, ja, netdev, linux-kernel
In-Reply-To: <20071111064840.GJ21669@stusta.de>
From: Adrian Bunk <bunk@kernel.org>
Date: Sun, 11 Nov 2007 07:48:40 +0100
> This patch removes the following unused EXPORT_SYMBOL's:
> - ip_vs_try_bind_dest
> - ip_vs_find_dest
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
Applied.
^ permalink raw reply
* Re: [PATCH] (resubmit) Use list_head-s in inetpeer.c
From: David Miller @ 2007-11-13 5:27 UTC (permalink / raw)
To: xemul; +Cc: netdev, devel
In-Reply-To: <473862B1.206@openvz.org>
From: Pavel Emelyanov <xemul@openvz.org>
Date: Mon, 12 Nov 2007 17:26:57 +0300
> The inetpeer.c tracks the LRU list of inet_perr-s, but makes
> it by hands. Use the list_head-s for this.
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Applied, thanks Pavel.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).