Netdev List
 help / color / mirror / Atom feed
* Re: [PATCH 8/8][BNX2]: Update version to 1.6.9.
From: David Miller @ 2007-12-12 19:20 UTC (permalink / raw)
  To: mchan; +Cc: netdev
In-Reply-To: <1197486022.16386.33.camel@dell>

From: "Michael Chan" <mchan@broadcom.com>
Date: Wed, 12 Dec 2007 11:00:22 -0800

> [BNX2]: Update version to 1.6.9.
> 
> Signed-off-by: Michael Chan <mchan@broadcom.com>

Applied, thanks.

^ permalink raw reply

* Re: [PATCH 7/8][BNX2]: Enable S/G for jumbo RX.
From: David Miller @ 2007-12-12 19:20 UTC (permalink / raw)
  To: mchan; +Cc: netdev
In-Reply-To: <1197486011.16386.32.camel@dell>

From: "Michael Chan" <mchan@broadcom.com>
Date: Wed, 12 Dec 2007 11:00:11 -0800

> [BNX2]: Enable S/G for jumbo RX.
> 
> If the MTU requires more than 1 page for the SKB, enable the page ring
> and calculate the size of the page ring.  This will guarantee order-0
> allocation regardless of the MTU size.
> 
> Fixup loopback test packet size so that we don't deal with the pages
> during loopback test.
> 
> Signed-off-by: Michael Chan <mchan@broadcom.com>

Applied.

^ permalink raw reply

* Re: [PATCH 6/8][BNX2]: Add fast path code to handle RX pages.
From: David Miller @ 2007-12-12 19:19 UTC (permalink / raw)
  To: mchan; +Cc: netdev
In-Reply-To: <1197486000.16386.31.camel@dell>

From: "Michael Chan" <mchan@broadcom.com>
Date: Wed, 12 Dec 2007 11:00:00 -0800

> [BNX2]: Add fast path code to handle RX pages.
> 
> Add function to reuse a page in case of allocation or other errors.
> Add code to construct the completed SKB with the additional data in
> the pages.
> 
> Signed-off-by: Michael Chan <mchan@broadcom.com>

Applied.

^ permalink raw reply

* Re: [PATCH 5/8][BNX2]: Add init. code to handle RX pages.
From: David Miller @ 2007-12-12 19:19 UTC (permalink / raw)
  To: mchan; +Cc: netdev
In-Reply-To: <1197485979.16386.30.camel@dell>

From: "Michael Chan" <mchan@broadcom.com>
Date: Wed, 12 Dec 2007 10:59:39 -0800

> [BNX2]: Add init. code to handle RX pages.
> 
> Add new fields to keep track of the pages and the page rings.
> Add functions to allocate and free pages.
> 
> Signed-off-by: Michael Chan <mchan@broadcom.com>

Applied.

^ permalink raw reply

* Re: [PATCH 3/8][BNX2]: Restructure RX ring init. code.
From: David Miller @ 2007-12-12 19:17 UTC (permalink / raw)
  To: mchan; +Cc: netdev
In-Reply-To: <1197485945.16386.28.camel@dell>

From: "Michael Chan" <mchan@broadcom.com>
Date: Wed, 12 Dec 2007 10:59:05 -0800

> [BNX2]: Restructure RX ring init. code.
> 
> Factor out the common functions that will be used to initialize the
> normal RX rings and the page rings.
> 
> Change the copybreak constant RX_COPY_THRESH to 128.  This same
> constant will be used for the max. size of the linear SKB when pages
> are used.  Copybreak will be turned off when pages are used.
> 
> Signed-off-by: Michael Chan <mchan@broadcom.com>

Applied.

^ permalink raw reply

* Re: [PATCH 2/8][BNX2]: Restructure RX fast path handling.
From: David Miller @ 2007-12-12 19:17 UTC (permalink / raw)
  To: mchan; +Cc: netdev
In-Reply-To: <1197485923.16386.27.camel@dell>

From: "Michael Chan" <mchan@broadcom.com>
Date: Wed, 12 Dec 2007 10:58:43 -0800

> [BNX2]: Restructure RX fast path handling.
> 
> Add a new function to handle new SKB allocation and to prepare the
> completed SKB.  This makes it easier to add support for non-linear
> SKB.
>  
> Signed-off-by: Michael Chan <mchan@broadcom.com>

Applied.

^ permalink raw reply

* Re: [PATCH 1/8][BNX2]: Add ring constants.
From: David Miller @ 2007-12-12 19:16 UTC (permalink / raw)
  To: mchan; +Cc: netdev
In-Reply-To: <1197485902.16386.26.camel@dell>

From: "Michael Chan" <mchan@broadcom.com>
Date: Wed, 12 Dec 2007 10:58:22 -0800

> [BNX2]: Add ring constants.
> 
> Define the various ring constants to make the code cleaner.
> 
> Signed-off-by: Michael Chan <mchan@broadcom.com>

Applied to net-2.6.25

^ permalink raw reply

* Re: [PATCH] netfilter : xt_hashlimit should use time_after_eq()
From: David Miller @ 2007-12-12 19:11 UTC (permalink / raw)
  To: kaber; +Cc: dada1, netdev
In-Reply-To: <47603147.90008@trash.net>

From: Patrick McHardy <kaber@trash.net>
Date: Wed, 12 Dec 2007 20:06:47 +0100

> Eric Dumazet wrote:
> > Hi David & Patrick
> > 
> > I believe this patch is needed for linux-2.6.24
> > 
> > Thank you
> > 
> > [PATCH] netfilter : xt_hashlimit should use time_after_eq()
> > 
> > In order to avoid jiffies wraparound and its effect, special care must 
> > be taken
> > when doing comparisons ...
> 
> 
> Looks good, thanks Eric. Dave, please apply.

Applied, thanks.

^ permalink raw reply

* Re: [PATCH] XFRM: Display the audited SPI value in host byte order
From: David Miller @ 2007-12-12 19:10 UTC (permalink / raw)
  To: paul.moore; +Cc: netdev, linux-audit
In-Reply-To: <20071212190542.20699.96051.stgit@flek.americas.hpqcorp.net>

From: Paul Moore <paul.moore@hp.com>
Date: Wed, 12 Dec 2007 14:05:42 -0500

> Currently the IPsec protocol SPI values are written to the audit log in
> network byte order which is different from almost all other values which
> are recorded in host byte order.  This patch corrects this inconsistency
> by writing the SPI values to the audit record in host byte order.
> 
> Signed-off-by: Paul Moore <paul.moore@hp.com>

Applied to net-2.6, thanks Paul.

^ permalink raw reply

* Re: [Bugme-new] [Bug 9543] New: RTNL: assertion failed at net/ipv6/addrconf.c (2164)/RTNL: assertion failed at net/ipv4/devinet.c (1055)
From: Andy Gospodarek @ 2007-12-12 19:07 UTC (permalink / raw)
  To: Jay Vosburgh
  Cc: Herbert Xu, Andrew Morton, olel, bugme-daemon, shemminger, davem,
	netdev, andy
In-Reply-To: <28503.1197481615@death>

On Wed, Dec 12, 2007 at 09:46:55AM -0800, Jay Vosburgh wrote:
> Herbert Xu <herbert@gondor.apana.org.au> wrote:
> 
> >> diff -puN drivers/net/bonding/bond_sysfs.c~bonding-locking-fix drivers/net/bonding/bond_sysfs.c
> >> --- a/drivers/net/bonding/bond_sysfs.c~bonding-locking-fix
> >> +++ a/drivers/net/bonding/bond_sysfs.c
> >> @@ -1111,8 +1111,6 @@ static ssize_t bonding_store_primary(str
> >> out:
> >>        write_unlock_bh(&bond->lock);
> >> 
> >> -       rtnl_unlock();
> >> -
> >
> >Looking at the changeset that added this perhaps the intention
> >is to hold the lock? If so we should add an rtnl_lock to the start
> >of the function.
> 
> 	Yes, this function needs to hold locks, and more than just
> what's there now.  I believe the following should be correct; I haven't
> tested it, though (I'm supposedly on vacation right now).
> 
> 	The following change should be correct for the
> bonding_store_primary case discussed in this thread, and also corrects
> the bonding_store_active case which performs similar functions.
> 
> 	The bond_change_active_slave and bond_select_active_slave
> functions both require rtnl, bond->lock for read and curr_slave_lock for
> write_bh, and no other locks.  This is so that the lower level
> mode-specific functions can release locks down to just rtnl in order to
> call, e.g., dev_set_mac_address with the locks it expects (rtnl only).
> 
> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>

This looks good to me as well....

Signed-off-by: Andy Gospodarek <andy@greyhouse.net>


^ permalink raw reply

* Re: [PATCH] netfilter : xt_hashlimit should use time_after_eq()
From: Patrick McHardy @ 2007-12-12 19:06 UTC (permalink / raw)
  To: Eric Dumazet; +Cc: David S. Miller, netdev
In-Reply-To: <47602AE6.6060908@cosmosbay.com>

Eric Dumazet wrote:
> Hi David & Patrick
> 
> I believe this patch is needed for linux-2.6.24
> 
> Thank you
> 
> [PATCH] netfilter : xt_hashlimit should use time_after_eq()
> 
> In order to avoid jiffies wraparound and its effect, special care must 
> be taken
> when doing comparisons ...


Looks good, thanks Eric. Dave, please apply.

^ permalink raw reply

* [PATCH] XFRM: Display the audited SPI value in host byte order
From: Paul Moore @ 2007-12-12 19:05 UTC (permalink / raw)
  To: netdev; +Cc: linux-audit

Currently the IPsec protocol SPI values are written to the audit log in
network byte order which is different from almost all other values which
are recorded in host byte order.  This patch corrects this inconsistency
by writing the SPI values to the audit record in host byte order.

Signed-off-by: Paul Moore <paul.moore@hp.com>
---

 net/xfrm/xfrm_state.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c
index cf43c49..1af522b 100644
--- a/net/xfrm/xfrm_state.c
+++ b/net/xfrm/xfrm_state.c
@@ -2028,6 +2028,7 @@ void
 xfrm_audit_state_add(struct xfrm_state *x, int result, u32 auid, u32 sid)
 {
 	struct audit_buffer *audit_buf;
+	u32 spi;
 	extern int audit_enabled;
 
 	if (audit_enabled == 0)
@@ -2037,8 +2038,8 @@ xfrm_audit_state_add(struct xfrm_state *x, int result, u32 auid, u32 sid)
 		return;
 	audit_log_format(audit_buf, " op=SAD-add res=%u",result);
 	xfrm_audit_common_stateinfo(x, audit_buf);
-	audit_log_format(audit_buf, " spi=%lu(0x%lx)",
-			 (unsigned long)x->id.spi, (unsigned long)x->id.spi);
+	spi = ntohl(x->id.spi);
+	audit_log_format(audit_buf, " spi=%u(0x%x)", spi, spi);
 	audit_log_end(audit_buf);
 }
 EXPORT_SYMBOL_GPL(xfrm_audit_state_add);
@@ -2047,6 +2048,7 @@ void
 xfrm_audit_state_delete(struct xfrm_state *x, int result, u32 auid, u32 sid)
 {
 	struct audit_buffer *audit_buf;
+	u32 spi;
 	extern int audit_enabled;
 
 	if (audit_enabled == 0)
@@ -2056,8 +2058,8 @@ xfrm_audit_state_delete(struct xfrm_state *x, int result, u32 auid, u32 sid)
 		return;
 	audit_log_format(audit_buf, " op=SAD-delete res=%u",result);
 	xfrm_audit_common_stateinfo(x, audit_buf);
-	audit_log_format(audit_buf, " spi=%lu(0x%lx)",
-			 (unsigned long)x->id.spi, (unsigned long)x->id.spi);
+	spi = ntohl(x->id.spi);
+	audit_log_format(audit_buf, " spi=%u(0x%x)", spi, spi);
 	audit_log_end(audit_buf);
 }
 EXPORT_SYMBOL_GPL(xfrm_audit_state_delete);

^ permalink raw reply related

* Re: [PATCH]: remove netif_running() check from myri10ge_poll()
From: David Miller @ 2007-12-12 19:02 UTC (permalink / raw)
  To: gallatin; +Cc: jeff, netdev, linux-kernel
In-Reply-To: <47602AAA.8060204@myri.com>

From: Andrew Gallatin <gallatin@myri.com>
Date: Wed, 12 Dec 2007 13:38:34 -0500

> Remove the bogus netif_running() check from myri10ge_poll().
> 
> This eliminates any chance that myri10ge_poll() can trigger
> an oops by calling netif_rx_complete() and returning
> with work_done == budget.
> 
> Signed-off-by: Andrew Gallatin <gallatin@myri.com>

Acked-by: David S. Miller <davem@davemloft.net>

^ permalink raw reply

* Re: [PATCH] IPIP: Allow rebinding the tunnel to another interface
From: David Miller @ 2007-12-12 19:02 UTC (permalink / raw)
  To: mschmidt; +Cc: kaber, netdev, mmaslano
In-Reply-To: <20071212172933.178cf78e@brian.englab.brq.redhat.com>

From: Michal Schmidt <mschmidt@redhat.com>
Date: Wed, 12 Dec 2007 17:29:33 +0100

> On Wed, 12 Dec 2007 17:00:14 +0100
> Patrick McHardy <kaber@trash.net> wrote:
> 
> > If you change dev->iflink this should trigger a rtnetlink
> > notification.
> 
> OK, I've added netdev_state_change(dev). Here's the new patch.

Applied to net-2.6.25, thanks.

^ permalink raw reply

* Re: [PATCH] Remove unused define from loopback driver
From: David Miller @ 2007-12-12 19:00 UTC (permalink / raw)
  To: xemul; +Cc: netdev, devel
In-Reply-To: <475FF3E6.9030507@openvz.org>

From: Pavel Emelyanov <xemul@openvz.org>
Date: Wed, 12 Dec 2007 17:44:54 +0300

> The LOOPBACK_OVERHEAD is not used in this file at all.
> 
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>

Applied to net-2.6.25, thanks.

^ permalink raw reply

* Re: [PATCH 2.6.25] IPv4: thresholds in fib_trie.c are not modified, make them const
From: David Miller @ 2007-12-12 18:58 UTC (permalink / raw)
  To: den; +Cc: containers, devel, netdev
In-Reply-To: <20071212110555.GA11638@iris.sw.ru>

From: "Denis V. Lunev" <den@openvz.org>
Date: Wed, 12 Dec 2007 14:05:55 +0300

> -static int halve_threshold = 25;
> -static int inflate_threshold = 50;
> -static int halve_threshold_root = 15;
> -static int inflate_threshold_root = 25;

halve_threshold_root and inflate_threshold_root have different
values in the net-2.6.25 tree.

What tree are you patching against?  These were changed way
back in:

commit 965ffea43d4ebe8cd7b9fee78d651268dd7d23c5
Author: Robert Olsson <robert.olsson@its.uu.se>
Date:   Mon Mar 19 16:29:58 2007 -0700

    [IPV4]: fib_trie root node settings
    
    The threshold for root node can be more aggressive set to get
    better tree compression. The new setting mekes the root grow
    from 16 to 19 bits and substansial improvemnt in Aver depth
    this with the current table of 214393 prefixes
    
    But really the dynamic resize should need more investigation
    both in terms convergence and performance and maybe it should
    be possible to change...
    
    Maybe just for the brave to start with or we may have to back
    this out.

Please don't waste my time like this.  Always submit patches
against the current tree, even if you "think" the files
you are patching haven't changed.

^ permalink raw reply

* Re: "ip neigh show" not showing arp cache entries?
From: Eric Dumazet @ 2007-12-12 18:52 UTC (permalink / raw)
  To: Chris Friesen; +Cc: netdev, linux-kernel
In-Reply-To: <4760279E.1080203@nortel.com>

Chris Friesen a écrit :
> Eric Dumazet wrote:
>> Chris Friesen a écrit :
>>> Is this expected behaviour?
>>
>> Probably not... Still a 2.6.14 kernel ?
>
> Yep.  Embedded hardware, so I'm unable to test with a more recent kernel.
>

And what is the version of "ip" command you have on this machine ?

ip -V

You may try other versions of this command

http://devresources.linux-foundation.org/dev/iproute2/download/






^ permalink raw reply

* Re: [PATCH 2.6.25] netns: network namespace was passed into dev_getbyhwaddr but not used
From: David Miller @ 2007-12-12 18:50 UTC (permalink / raw)
  To: den; +Cc: containers, devel, netdev
In-Reply-To: <20071212110517.GA11626@iris.sw.ru>

From: "Denis V. Lunev" <den@openvz.org>
Date: Wed, 12 Dec 2007 14:05:17 +0300

> netns: network namespace was passed into dev_getbyhwaddr but not used
> 
> Signed-off-by: Denis V. Lunev <den@openvz.org>

Applied.

Please always put the subsystem name in the headline in
all capitals and surround it with brackets, like this:

[NETNS]: Blah blah blah.

Also treat the description line as a true English sentence, this means
capitalize the first word and put a period at the end of it.  This is
a changelog message for a professional piece of software, not some
"innanet" slang talk on some IRC channel. :-)

I make these edits to every one of your patch submissions and it's
getting tiring, I hoped you would notice this yourself before my
needing to tell you about it explicitly :-)

^ permalink raw reply

* Re: [PATCH] Net: Remove FASTCALL macro
From: David Miller @ 2007-12-12 18:47 UTC (permalink / raw)
  To: harvey.harrison; +Cc: netdev, mingo, linux-kernel
In-Reply-To: <1197446943.5745.9.camel@brick>

From: Harvey Harrison <harvey.harrison@gmail.com>
Date: Wed, 12 Dec 2007 00:09:03 -0800

> X86_32 was the last user of the FASTCALL macro, now that it
> uses regparm(3) by default, this macro expands to nothing.
> 
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>

Applied to net-2.6.25, thanks.

^ permalink raw reply

* Re: [PATCH] HDLC driver: use unregister_netdev instead of unregister_netdevice
From: David Miller @ 2007-12-12 18:46 UTC (permalink / raw)
  To: wangchen; +Cc: jgarzik, khc, netdev
In-Reply-To: <475F490C.2020305@cn.fujitsu.com>

From: Wang Chen <wangchen@cn.fujitsu.com>
Date: Wed, 12 Dec 2007 10:35:56 +0800

> [PATCH] HDLC driver: use unregister_netdev instead of unregister_netdevice
> 
> Since the caller and the upper caller doesn't hod the rtnl semaphore.
> We should use unregister_netdev instead of unregister_netdevice.
> 
> Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>

Applied, thanks for finding and fixing this bug.

^ permalink raw reply

* Re: [PATCH 3/3] [IPSEC]: Add ICMP host relookup support
From: David Miller @ 2007-12-12 18:45 UTC (permalink / raw)
  To: herbert; +Cc: netdev
In-Reply-To: <E1J2GrJ-0005Se-00@gondolin.me.apana.org.au>

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Wed, 12 Dec 2007 09:58:01 +0800

> [IPSEC]: Add ICMP host relookup support
> 
> RFC 4301 requires us to relookup ICMP traffic that does not match any
> policies using the reverse of its payload.  This patch implements this
> for ICMP traffic that originates from or terminates on localhost.
> 
> This is activated on outbound with the new policy flag XFRM_POLICY_ICMP,
> and on inbound by the new state flag XFRM_STATE_ICMP.
> 
> On inbound the policy check is now performed by the ICMP protocol so
> that it can repeat the policy check where necessary.
> 
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
 ...
> @@ -268,6 +268,7 @@ extern void		dst_init(void);
>  /* Flags for xfrm_lookup flags argument. */
>  enum {
>  	XFRM_LOOKUP_WAIT = 1 << 0,
> +	XFRM_LOOKUP_ICMP = 1 << 1,
>  };
>  
>  struct flowi;

Sigh :-(  Applied.

^ permalink raw reply

* Re: [RFC] net: napi fix
From: Kok, Auke @ 2007-12-12 18:41 UTC (permalink / raw)
  To: David Miller
  Cc: gallatin, joonwpark81, netdev, linux-kernel, jgarzik, shemminger,
	Jesse Brandeburg
In-Reply-To: <20071212.093819.205755031.davem@davemloft.net>

David Miller wrote:
> From: Andrew Gallatin <gallatin@myri.com>
> Date: Wed, 12 Dec 2007 12:29:23 -0500
> 
>> Is the netif_running() check even required?
> 
> No, it is not.
> 
> When a device is brought down, one of the first things
> that happens is that we wait for all pending NAPI polls
> to complete, then block any new polls from starting.

I think this was previously (pre-2.6.24) not the case, which is why e1000 et al
has this check as well and that's exactly what is causing most of the
net_rx_action oopses in the first place. Without the netif_running() check
previously the drivers were just unusable with NAPI and prone to many races with
down (i.e. touching some ethtool ioctl which wants to do a reset while routing
small packets at high numbers). that's why we added the netif_running() check in
the first place :)

There might be more drivers lurking that need this change...

Auke

^ permalink raw reply

* Re: [PATCH 2/3] [IPSEC]: Added xfrm_decode_session_reverse and xfrmX_policy_check_reverse
From: David Miller @ 2007-12-12 18:44 UTC (permalink / raw)
  To: herbert; +Cc: netdev
In-Reply-To: <E1J2GrI-0005SX-00@gondolin.me.apana.org.au>

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Wed, 12 Dec 2007 09:58:00 +0800

> [IPSEC]: Added xfrm_decode_session_reverse and xfrmX_policy_check_reverse
> 
> RFC 4301 requires us to relookup ICMP traffic that does not match any
> policies using the reverse of its payload.  This patch adds the functions
> xfrm_decode_session_reverse and xfrmX_policy_check_reverse so we can get
> the reverse flow to perform such a lookup.
> 
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Applied.

^ permalink raw reply

* Re: [PATCH 1/3] [IPSEC]: Make xfrm_lookup flags argument a bit-field
From: David Miller @ 2007-12-12 18:43 UTC (permalink / raw)
  To: herbert; +Cc: netdev
In-Reply-To: <E1J2GrH-0005SK-00@gondolin.me.apana.org.au>

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Wed, 12 Dec 2007 09:57:59 +0800

> [IPSEC]: Make xfrm_lookup flags argument a bit-field
> 
> This patch introduces an enum for bits in the flags argument of xfrm_lookup.
> This is so that we can cram more information into it later.
> 
> Since all current users use just the values 0 and 1, XFRM_LOOKUP_WAIT has
> been added with the value 1 << 0 to represent the current meaning of flags.
> 
> The test in __xfrm_lookup has been changed accordingly.
> 
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Begrudgingly, I've applied this, but only to make the merging of your
work easier.  I think this flag is totally wrong and you need to
fix this up.

This value is not an __xfrm_lookup() flag at all, and this issue would
have been clear had you tried to fix up the __xfrm_lookup() call
sites.  There is no point in adding the named constant, if you keep
the magic constants around, so it's wrong that you didn't hit all
the call sites when you added this flag.

This flag propages from a level before __xfrm_lookup() in many cases,
therefore it is a generic route lookup flag, not an XFRM layer
specific one.  ip_route_output_flow() is one of several example cases.

It is going to get even more ugly when you add the other XFRM lookup
flag in the followon changeset.  Now we'll have a mixture of the magic
constants '1' and '0', the named version XFRM_LOOKUP_WAIT, and this
new XFRM_LOOKUP_* flag for reverse resolution.

These values all exist in different contextual namespaces, yet you are
allocating and naming them purely from the context of __xfrm_lookup()
and that just isn't right.

^ permalink raw reply

* Re: [RFC] mac80211: clean up frame receive handling
From: drago01 @ 2007-12-12 18:39 UTC (permalink / raw)
  To: Johannes Berg
  Cc: linux-wireless, netdev, Michael Wu, Tomas Winkler, Jouni Malinen
In-Reply-To: <1197483844.6558.158.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>

On Dec 12, 2007 7:24 PM, Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org> wrote:
> [comments welcome. I really need a refresher on what the frame formats
> mean but I think I did the right thing with skb->protocol here, I also
> think we had a bug with rfc2042 header frames bigger than 15xx bytes and
> eth_type_trans()]
>
> This cleans up the frame receive handling. After this patch
>  * EAPOL frames addressed to us or the EAPOL group address are
>    always accepted regardless of whether they are encrypted or not

why? userspace (wap_supplicant) tryes to control this depending on the
network settings.
(I don't really know why thought)
maybe it should be handled like drop_unencrypted with default to accept all?

^ permalink raw reply


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox