* Re: [PATCH 0/4] [UDP]: memory accounting and limitation (take 10)
From: Hideo AOKI @ 2007-12-16 21:21 UTC (permalink / raw)
To: David Miller
Cc: herbert, netdev, tyasui, mhiramat, satoshi.oshima.fk, billfink,
andi, johnpol, shemminger, yoshfuji, yumiko.sugita.yf, haoki
In-Reply-To: <20071215.213426.257974943.davem@davemloft.net>
David Miller wrote:
> From: Hideo AOKI <haoki@redhat.com>
> Date: Sat, 15 Dec 2007 00:07:44 -0500
>
>> Changelog take 9 -> take 10:
>> * supported using sk_forward_alloc
>> * introduced several memory accounting functions with spin lock
>> * changed detagram receive functions to be able to customize
>> destructor
>> * fixed accounting bugs in previous takes
>
> This is not what Herbert and I meant with our suggestion.
>
> We meant to convert all of UDP and datagram handling to lock
> sockets precisely like TCP does, by calling lock_sock()
> on entry to functions like udp_recvmsg() and release_sock()
> on exit from those functions.
>
> Then in the packet input processing, a sequence, just like
> TCP, such as:
>
> bh_lock_sock_nested(sk);
> if (!sock_owned_by_user(sk)) {
> udp_do_rcv(sk, skb);
> } else
> sk_add_backlog(sk, skb);
>
> Then a suitably defined ->backlog_rcv is hooked up for these
> protocols as well.
>
> Again, use TCP as a guide.
>
> There is much more work involved to implement this properly,
> and make the accounting code sharable with TCP, than the
> simplistic and minimal spin lock code you added here.
>
> Please do this correctly, thank you.
Hello,
I appreciate your suggestions.
I'll try to re-implement locking mechanism like TCP.
Regards,
Hideo
--
Hitachi Computer Products (America) Inc.
^ permalink raw reply
* Re: [PATCH net-2.6.25 1/7] Add the netns_ipv4 struct
From: David Miller @ 2007-12-16 21:29 UTC (permalink / raw)
To: xemul; +Cc: netdev, containers, devel
In-Reply-To: <475ECCD6.4080205@openvz.org>
From: Pavel Emelyanov <xemul@openvz.org>
Date: Tue, 11 Dec 2007 20:45:58 +0300
> The ipv4 will store its parameters inside this structure.
> This one is empty now, but it will be eventually filled.
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Applied.
^ permalink raw reply
* Re: [PATCH net-2.6.25 2/7] Make __devinet_sysctl_register return an error
From: David Miller @ 2007-12-16 21:30 UTC (permalink / raw)
To: xemul; +Cc: netdev, containers, devel
In-Reply-To: <475ECD7C.8050905@openvz.org>
From: Pavel Emelyanov <xemul@openvz.org>
Date: Tue, 11 Dec 2007 20:48:44 +0300
> Currently, this function is void, so failures in creating
> sysctls for new/renamed devices are not reported to anywhere.
>
> Fixing this is another complex (needed?) task, but this
> return value is needed during the namespaces creation to
> handle the case, when we failed to create "all" and "default"
> entries.
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Applied.
^ permalink raw reply
* Re: [PATCH net-2.6.25 3/7] Pass the net pointer to the arp_req_set_proxy()
From: David Miller @ 2007-12-16 21:30 UTC (permalink / raw)
To: xemul-GEFAQzZX7r8dnm+yROfE0A
Cc: containers-qjLDD68F18O7TbgM5vRIOg, netdev-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <475ECE03.2040402-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
From: Pavel Emelyanov <xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
Date: Tue, 11 Dec 2007 20:50:59 +0300
> This one will need to set the IPV4_DEVCONF_ALL(PROXY_ARP), but
> there's no ways to get the net right in place, so we have to
> pull one from the inet_ioctl's struct sock.
>
> Signed-off-by: Pavel Emelyanov <xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
Applied.
^ permalink raw reply
* Re: [PATCH net-2.6.25 4/7] Store the net pointer on devinet's ctl tables
From: David Miller @ 2007-12-16 21:31 UTC (permalink / raw)
To: xemul; +Cc: netdev, containers, devel
In-Reply-To: <475ECEB3.7060502@openvz.org>
From: Pavel Emelyanov <xemul@openvz.org>
Date: Tue, 11 Dec 2007 20:53:55 +0300
> Some handers and strategies of devinet sysctl tables need
> to know the net to propagate the ctl change to all the
> net devices.
>
> I use the (currently unused) extra2 pointer on the tables
> to get it.
>
> Holding the reference on the struct net is not possible,
> because otherwise we'll get a net->ctl_table->net circular
> dependency. But since the ctl tables are unregistered during
> the net destruction, this is safe to get it w/o additional
> protection.
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Applied.
^ permalink raw reply
* Re: [PATCH net-2.6.25 5/7] Move the devinet pointers on the struct net
From: David Miller @ 2007-12-16 21:31 UTC (permalink / raw)
To: xemul; +Cc: netdev, containers, devel
In-Reply-To: <475ECF7E.2060103@openvz.org>
From: Pavel Emelyanov <xemul@openvz.org>
Date: Tue, 11 Dec 2007 20:57:18 +0300
> This is the core.
>
> Add all and default pointers on the netns_ipv4 and register
> a new pernet subsys to initialize them.
>
> Also add the ctl_table_header to register the
> net.ipv4.ip_forward ctl.
>
> I don't allocate additional memory for init_net, but use
> global devinets.
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Applied.
^ permalink raw reply
* Re: [PATCH net-2.6.25 6/7] Switch users of ipv4_devconf_dflt to use the pernet one
From: David Miller @ 2007-12-16 21:32 UTC (permalink / raw)
To: xemul; +Cc: netdev, containers, devel
In-Reply-To: <475ED01E.5020505@openvz.org>
From: Pavel Emelyanov <xemul@openvz.org>
Date: Tue, 11 Dec 2007 20:59:58 +0300
> They are all collected in the net/ipv4/devinet.c file and
> mostly use the IPV4_DEVCONF_DFLT macro.
>
> So I add the net parameter to it and patch users accordingly.
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Applied.
^ permalink raw reply
* Re: [PATCH net-2.6.25 7/7] Switch users of ipv4_devconf(_all) to use the pernet one
From: David Miller @ 2007-12-16 21:32 UTC (permalink / raw)
To: xemul; +Cc: netdev, containers, devel
In-Reply-To: <475ED0AA.5080106@openvz.org>
From: Pavel Emelyanov <xemul@openvz.org>
Date: Tue, 11 Dec 2007 21:02:18 +0300
> These are scattered over the code, but almost all the
> "critical" places already have the proper struct net
> at hand except for snmp proc showing function and routing
> rtnl handler.
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Applied.
^ permalink raw reply
* Re: [PATCH] [NET]: Fix Ooops of napi net_rx_action.
From: David Miller @ 2007-12-16 21:35 UTC (permalink / raw)
To: shemminger
Cc: joonwpark81, jesse.brandeburg, netdev, linux-kernel, herbert,
auke-jan.h.kok
In-Reply-To: <20071211154222.0aec68fc@freepuppy.rosehill>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Tue, 11 Dec 2007 15:42:22 -0800
> Perhaps we should change the warning to identify the guilty device.
Applied.
Stephen, you often don't supply a proper signoff line
for one-off changes like this and I find it very irritating.
It doesn't cost you anything to hit one or two keys in your
outgoing email editor to include the signoff line.
So please do so, or I'll silently drop patches without them
in the future.
Thanks.
^ permalink raw reply
* Re: [PATCH] bridge: assign random address
From: David Miller @ 2007-12-16 21:37 UTC (permalink / raw)
To: shemminger; +Cc: akpm, netdev, bugme-daemon, berrange, jeff, herbert, rjw
In-Reply-To: <20071211154835.75ace6bc@freepuppy.rosehill>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Tue, 11 Dec 2007 15:48:35 -0800
> Subject: Re: [PATCH] bridge: assign random address
"bridge" should all-caps and in brackets, "assign random address"
should be capitalized like a proper english sentence with a period at
the end.
These are changelog messages for a mature and professional software
project, not random comments amongst teenagers on an IRC channel.
> Assigning a valid random address to bridge device solves problems
> when bridge device is brought up before adding real device to bridge.
> When the first real device is added to the bridge, it's address
> will overide the bridges random address.
>
> Note: any device added to a bridge must already have a valid
> ethernet address.
> br_add_if -> br_fdb_insert -> fdb_insert -> is_valid_ether_addr
>
> Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
Applied to net-2.6, thanks.
^ permalink raw reply
* Re: [RFT] tehuti: napi fix
From: David Miller @ 2007-12-16 21:38 UTC (permalink / raw)
To: shemminger; +Cc: joonwpark81, netdev, jgarzik, baum, andy
In-Reply-To: <20071212135852.3369c820@freepuppy.rosehill>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Wed, 12 Dec 2007 13:58:52 -0800
> This should fix the tehuti napi fence post problems by getting
> rid of priv->napi_stop, and setting weight to 32 (like other 10G).
>
> Also, used the wierd entry/exit macro's like rest of driver.
It fixes the fench-post problem, but like the comments you
removed explain:
> - /* from time to time we exit to let NAPI layer release
> - * device lock and allow waiting tasks (eg rmmod) to advance) */
> - priv->napi_stop = 0;
> -
We now hang on rmmod during constant packet load.
This change just trades one bug for another, we have to
get the device close issue sorted out before we can go
around removing these things.
^ permalink raw reply
* Re: [PATCH] IPv6: Fix the return value of ipv6_getsockopt
From: David Miller @ 2007-12-16 21:40 UTC (permalink / raw)
To: yjwei; +Cc: netdev
In-Reply-To: <4760C6A0.4000300@cn.fujitsu.com>
From: Wei Yongjun <yjwei@cn.fujitsu.com>
Date: Thu, 13 Dec 2007 14:44:00 +0900
> If CONFIG_NETFILTER if not selected when compile the kernel source code,
> ipv6_getsockopt will returen an EINVAL error if optname is not supported by
> the kernel. But if CONFIG_NETFILTER is selected, ENOPROTOOPT error will
> be return.
> This patch fix to always return ENOPROTOOPT error if optname argument of
> ipv6_getsockopt is not supported by the kernel.
>
> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Patch applied to net-2.6, thanks for this bug fix.
^ permalink raw reply
* Re: [PATCH 1/2] tulip: napi full quantum bug
From: David Miller @ 2007-12-16 21:40 UTC (permalink / raw)
To: shemminger; +Cc: kristjan.ugrin, jgarzik, netdev
In-Reply-To: <20071213093545.436b8f8e@freepuppy.rosehill>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Thu, 13 Dec 2007 09:35:45 -0800
> This should fix the kernel warn/oops reported while routing.
>
> The tulip driver has a fencepost bug with new NAPI in 2.6.24
> It has an off by one bug if a full quantum is reached.
>
> Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
Acked-by: David S. Miller <davem@davemloft.net>
Jeff, please apply if you haven't already.
> --- a/drivers/net/tulip/interrupt.c 2007-12-13 09:20:27.000000000 -0800
> +++ b/drivers/net/tulip/interrupt.c 2007-12-13 09:23:34.000000000 -0800
> @@ -151,7 +151,8 @@ int tulip_poll(struct napi_struct *napi,
> if (tulip_debug > 5)
> printk(KERN_DEBUG "%s: In tulip_rx(), entry %d %8.8x.\n",
> dev->name, entry, status);
> - if (work_done++ >= budget)
> +
> + if (++work_done >= budget)
> goto not_done;
>
> if ((status & 0x38008300) != 0x0300) {
^ permalink raw reply
* Re: [PATCH net-2.6.25 1/8] Create ipv4_is_<type>(__be32 addr) functions
From: David Miller @ 2007-12-16 21:42 UTC (permalink / raw)
To: joe; +Cc: netdev, linux-kernel
In-Reply-To: <1197589141-7020-1-git-send-email-joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Thu, 13 Dec 2007 15:38:54 -0800
> Change IPV4 specific macros LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET
> macros to inline functions ipv4_is_<type>(__be32 addr)
>
> Adds type safety and arguably some readability.
>
> Changes since last submission:
>
> Removed ipv4_addr_octets function
> Used hex constants
> Converted recently added rfc3330 macros
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-2.6.25 2/8] include/net: Use ipv4_is_<type>
From: David Miller @ 2007-12-16 21:43 UTC (permalink / raw)
To: joe; +Cc: netdev
In-Reply-To: <1197589141-7020-2-git-send-email-joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Thu, 13 Dec 2007 15:38:55 -0800
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-2.6.25 3/8] net/core: Use ipv4_is_<type>
From: David Miller @ 2007-12-16 21:44 UTC (permalink / raw)
To: joe; +Cc: netdev
In-Reply-To: <1197589141-7020-3-git-send-email-joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Thu, 13 Dec 2007 15:38:56 -0800
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-2.6.25 4/8] net/ipv4: Use ipv4_is_<type>
From: David Miller @ 2007-12-16 21:45 UTC (permalink / raw)
To: joe; +Cc: netdev, pekkas, kuznet, yoshfuji, jmorris, kaber
In-Reply-To: <1197589141-7020-4-git-send-email-joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Thu, 13 Dec 2007 15:38:57 -0800
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-2.6.25 5/8] net/netfilter: Use ipv4_is_<type>
From: David Miller @ 2007-12-16 21:46 UTC (permalink / raw)
To: joe; +Cc: netdev, kaber, coreteam, netfilter-devel, netfilter
In-Reply-To: <1197589141-7020-5-git-send-email-joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Thu, 13 Dec 2007 15:38:58 -0800
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-2.6.25 6/8] sctp: Use ipv4_is_<type>
From: David Miller @ 2007-12-16 21:47 UTC (permalink / raw)
To: joe; +Cc: netdev, sri, vladislav.yasevich, lksctp-developers
In-Reply-To: <1197589141-7020-6-git-send-email-joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Thu, 13 Dec 2007 15:38:59 -0800
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-2.6.25 7/8] drivers/infiniband: Use ipv4_is_<type>
From: David Miller @ 2007-12-16 21:47 UTC (permalink / raw)
To: joe; +Cc: netdev, hal.rosenstock, rolandd, mshefty, general
In-Reply-To: <1197589141-7020-7-git-send-email-joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Thu, 13 Dec 2007 15:39:00 -0800
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-2.6.25 8/8] Remove unused IPV4TYPE macros
From: David Miller @ 2007-12-16 21:48 UTC (permalink / raw)
To: joe; +Cc: netdev, linux-kernel
In-Reply-To: <1197589141-7020-8-git-send-email-joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Thu, 13 Dec 2007 15:39:01 -0800
> Signed-off-by: Joe Perches <joe@perches.com>
Applied, thanks for doing this work Joe.
^ permalink raw reply
* Re: 2.6.24-rc5-mm1 -- inconsistent {in-softirq-W} -> {softirq-on-R} usage.
From: David Miller @ 2007-12-16 21:59 UTC (permalink / raw)
To: akpm; +Cc: miles.lane, linux-kernel, netdev, mingo, a.p.zijlstra
In-Reply-To: <20071214153633.5d8f609a.akpm@linux-foundation.org>
From: Andrew Morton <akpm@linux-foundation.org>
Date: Fri, 14 Dec 2007 15:36:33 -0800
> The networking bug looks to be around sock_i_ino()'s taking of
> sk_callback_lock with softirq's enabled. Perhaps this will fix it.
One should be suspicious of any case where write_lock is performed
on sk->sk_callback_lock in softint context. And that's the only
way this can trigger, so this patch is wrong.
Generally, sock_orphan() and sock_graft() are the only primary
places where sk->sk_callback_lock is acquired as a writer. And
these should be invoked only from process context.
Perhaps there is some exception to this in some specialized layer such
as SUNRPC, which are the only other spots I see potentially doing
sk->sk_callback_lock write acquires in softint context, which as
stated should not be done.
OCFS2 and ISCSI seem to be following the rules in it's write lock
calls on this lock.
^ permalink raw reply
* Re: [PATCH] [IPV4]: Make tcp_input_metrics() get minimum RTO via tcp_rto_min()
From: David Miller @ 2007-12-16 22:00 UTC (permalink / raw)
To: satoru.satoh; +Cc: netdev
In-Reply-To: <d72b7ace0712141844x6392ceb6y5cb39d9a81f950e6@mail.gmail.com>
From: "Satoru SATOH" <satoru.satoh@gmail.com>
Date: Sat, 15 Dec 2007 11:44:46 +0900
> tcp_input_metrics() refers to the built-time constant TCP_RTO_MIN
> regardless of configured minimum RTO with iproute2.
>
> The following fixes that.
>
>
> Signed-off-by: Satoru SATOH <satoru.satoh@gmail.com>
Thanks for this bug fix, patch applied.
^ permalink raw reply
* Re: [PATCH take2] [AX25] circular locking with AX25 connection timeout
From: David Miller @ 2007-12-16 22:02 UTC (permalink / raw)
To: jarkao2; +Cc: pidoux, ralf, netdev
In-Reply-To: <20071215101810.GA3143@ami.dom.local>
From: Jarek Poplawski <jarkao2@gmail.com>
Date: Sat, 15 Dec 2007 11:18:10 +0100
> On Fri, Dec 14, 2007 at 11:29:28PM +0100, Bernard Pidoux wrote:
> > Hi,
> >
> > This patch cancels a circular locking conflict that appeared with a timeout
> > of an AX25 connection.
> >
> > signed off by Jarek Poplawski
>
> One spurious space less here, and maybe a few more words to the changelog.
Patch applied, thanks Jarek.
^ permalink raw reply
* Re: [PACKET]: Fix /proc/net/packet crash due to bogus private pointer
From: David Miller @ 2007-12-16 22:04 UTC (permalink / raw)
To: herbert; +Cc: m.kozlowski, akpm, jgarzik, linux-kernel, netdev, den, xemul
In-Reply-To: <20071216034119.GA1491@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sun, 16 Dec 2007 11:41:20 +0800
> [PACKET]: Fix /proc/net/packet crash due to bogus private pointer
>
> The seq_open_net patch changed the meaning of seq->private.
> Unfortunately it missed two spots in AF_PACKET, which still
> used the old way of dereferencing seq->private, thus causing
> weird and wonderful crashes when reading /proc/net/packet.
>
> This patch fixes them.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied to net-2.6.25, thanks Herbert.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox