* Re: [FIB]: removes a memset() call in tnode_new()
From: David Miller @ 2008-01-13 8:43 UTC (permalink / raw)
To: dada1; +Cc: netdev
In-Reply-To: <4789BF2B.3040103@cosmosbay.com>
From: Eric Dumazet <dada1@cosmosbay.com>
Date: Sun, 13 Jan 2008 08:35:07 +0100
> tnode_alloc() already clears allocated memory, using kcalloc()
> or alloc_pages(GFP_KERNEL|__GFP_ZERO, ...)
>
> Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Applied, thanks Eric.
^ permalink raw reply
* sky2 driver stopped working after upgrading from 2.6.18-4
From: Andrew Paprocki @ 2008-01-13 8:24 UTC (permalink / raw)
To: netdev; +Cc: Stephen Hemminger
I have never been able to get my Yukon-EC Ultra (0xb4) rev 2 working
on anything past 2.6.18-4 that I've tried. (All ~.20+)
Below is the debug output from the driver on both versions. Notice the
'phy interrupt status' that each version prints out in case it is
involved in the problem:
2.6.18-4: sky2 eth0: phy interrupt status 0x1c40 0xbf48
2.6.23.13: sky2 eth0: phy interrupt status 0x1c40 0xbf08
Things I've tried:
- disabling MSI
- building git head (2.4.24-rc7) to get the latest driver (same problem)
- manually changing some sky2.c code back to 18-4 code to see if I
could produce different behavior
Things I see:
- the right-hand green LED never lights up using the new code, it
blinks under the old code
- when I manually config an IP and ping, it reports a single packet
response w/ 0.000ms time and then nothing else
I added a printk into gm_phy_write() and this is what prints out under
2.6.23.13:
ACPI: PCI Interrupt 0000:02:00.0[A] -> GSI 18 (level, low) -> IRQ 20
PCI: Setting latency timer of device 0000:02:00.0 to 64
sky2 0000:02:00.0: v1.18 addr 0xfddfc000 irq 20 Yukon-EC Ultra (0xb4) rev 2
<NULL>: reg 0x0012 val 0x0000
sky2 eth0: addr 00:0a:48:00:0a:53
sky2 eth0: enabling interface
eth0: reg 0x0010 val 0x2860
eth0: reg 0x0009 val 0x0300
eth0: reg 0x0004 val 0x0de1
eth0: reg 0x0000 val 0x9200
eth0: reg 0x0016 val 0x0003
eth0: reg 0x0010 val 0x1877
eth0: reg 0x0012 val 0x4100
eth0: reg 0x0016 val 0x0000
eth0: reg 0x0016 val 0x00ff
eth0: reg 0x0018 val 0xaa99
eth0: reg 0x0017 val 0x2011
eth0: reg 0x0018 val 0xa204
eth0: reg 0x0017 val 0x2002
eth0: reg 0x0016 val 0x0000
eth0: reg 0x0012 val 0x0800
sky2 eth0: phy interrupt status 0x1c40 0xbf48
eth0: reg 0x0012 val 0x6400
eth0: reg 0x0016 val 0x0003
eth0: reg 0x0010 val 0x1007
eth0: reg 0x0016 val 0x0000
sky2 eth0: Link is up at 1000 Mbps, full duplex, flow control both
Please let me know if there is any more useful information I can dig up.
Thanks,
-Andrew
------------------------------------------------------------------------
Linux 2.6.18-4
$ modprobe -r sky2
sky2 eth0: disabling interface
ACPI: PCI interrupt for device 0000:02:00.0 disabled
$ modprobe sky2 debug=16
PCI: Enabling device 0000:02:00.0 (0000 -> 0003)
ACPI: PCI Interrupt 0000:02:00.0[A] -> GSI 18 (level, low) -> IRQ 201
PCI: Setting latency timer of device 0000:02:00.0 to 64
sky2 v1.5 addr 0xfddfc000 irq 201 Yukon-EC Ultra (0xb4) rev 2
sky2 eth0: addr 00:0a:48:00:0a:53
sky2 eth0: enabling interface
ADDRCONF(NETDEV_UP): eth0: link is not ready
sky2 eth0: phy interrupt status 0x1c40 0xbf48
sky2 eth0: Link is up at 1000 Mbps, full duplex, flow control both
ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
eth0: tx queued, slot 0, len 90
eth0: tx done, up to 1
eth0: tx queued, slot 1, len 342
eth0: tx done, up to 2
sky2 eth0: rx slot 0 status 0x1560100 len 342
eth0: tx queued, slot 2, len 42
sky2 eth0: rx slot 1 status 0x3c0100 len 60
eth0: tx queued, slot 3, len 81
eth0: tx done, up to 3
sky2 eth0: rx slot 2 status 0x6d0100 len 109
eth0: tx done, up to 5
eth0: tx queued, slot 5, len 81
sky2 eth0: rx slot 3 status 0xbd0100 len 189
eth0: tx done, up to 7
... <continues for pages>
------------------------------------------------------------------------
Linux 2.6.23.13
$ modprobe -r sky2
sky2 eth0: disabling interface
ACPI: PCI interrupt for device 0000:02:00.0 disabled
$ modprobe sky2 debug=16
ACPI: PCI Interrupt 0000:02:00.0[A] -> GSI 18 (level, low) -> IRQ 20
PCI: Setting latency timer of device 0000:02:00.0 to 64
sky2 0000:02:00.0: v1.18 addr 0xfddfc000 irq 20 Yukon-EC Ultra (0xb4) rev 2
sky2 eth0: addr 00:0a:48:00:0a:53
sky2 eth0: enabling interface
sky2 eth0: phy interrupt status 0x1c40 0xbf08
sky2 eth0: Link is up at 1000 Mbps, full duplex, flow control both
sky2 eth0: rx slot 0 status 0x3c0300 len 60
sky2 eth0: rx slot 1 status 0xf30300 len 243
sky2 eth0: rx slot 2 status 0xf30300 len 243
sky2 eth0: rx slot 3 status 0x3c0300 len 60
sky2 eth0: rx slot 4 status 0x3c0300 len 60
... <hangs here, nothing else prints out from sky2>
------------------------------------------------------------------------
(printed from under 2.6.18-4)
# lspci -vv -s 02:00.0
02:00.0 Ethernet controller: Marvell Technology Group Ltd. Unknown
device 4364 (rev 12)
Subsystem: Marvell Technology Group Ltd. Unknown device 5621
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop-
ParErr- Stepping- SERR- FastB2B-
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR-
Latency: 0, Cache Line Size: 4 bytes
Interrupt: pin A routed to IRQ 225
Region 0: Memory at fddfc000 (64-bit, non-prefetchable) [size=16K]
Region 2: I/O ports at ee00 [size=256]
[virtual] Expansion ROM at fdc00000 [disabled] [size=128K]
Capabilities: [48] Power Management version 3
Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA
PME(D0+,D1+,D2+,D3hot+,D3cold+)
Status: D0 PME-Enable- DSel=0 DScale=1 PME-
Capabilities: [50] Vital Product Data
Capabilities: [5c] Message Signalled Interrupts: Mask- 64bit+
Queue=0/0 Enable+
Address: 00000000fee00000 Data: 40e1
Capabilities: [e0] Express Legacy Endpoint IRQ 0
Device: Supported: MaxPayload 128 bytes, PhantFunc 0, ExtTag-
Device: Latency L0s unlimited, L1 unlimited
Device: AtnBtn- AtnInd- PwrInd-
Device: Errors: Correctable- Non-Fatal- Fatal- Unsupported-
Device: RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop-
Device: MaxPayload 128 bytes, MaxReadReq 512 bytes
Link: Supported Speed 2.5Gb/s, Width x1, ASPM L0s L1, Port 3
Link: Latency L0s <256ns, L1 unlimited
Link: ASPM Disabled RCB 128 bytes CommClk+ ExtSynch-
Link: Speed 2.5Gb/s, Width x1
Capabilities: [100] Advanced Error Reporting
^ permalink raw reply
* 2.6.24-rc6-mm1 - oddness with IPv4/v6 mapped sockets hanging...
From: Valdis.Kletnieks @ 2008-01-13 7:35 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, netdev
[-- Attachment #1: Type: text/plain, Size: 4632 bytes --]
I'm seeing problems with Sendmail on 24-rc6-mm1, where the main Sendmail is
listening on ::1/25, and Fetchmail connects to 127.0.0.1:25 to inject mail it
has just fetched from an outside server via IMAP - it will often just hang and
not make any further progress. Looking at netstat shows something interesting:
% netstat -n -a -A inet | grep 25
tcp 0 5108 127.0.0.1:59355 127.0.0.1:25 ESTABLISHED
% netstat -n -a -A inet6 | grep 25
tcp 0 0 :::25 :::* LISTEN
tcp 0 0 ::ffff:127.0.0.1:25 ::ffff:127.0.0.1:59355 ESTABLISHED
% netstat -n -a -A inet | grep 25
tcp 0 5108 127.0.0.1:59355 127.0.0.1:25 ESTABLISHED
% netstat -n -a -A inet6 | grep 25
tcp 0 0 :::25 :::* LISTEN
tcp 0 0 ::ffff:127.0.0.1:25 ::ffff:127.0.0.1:59355 ESTABLISHED
% netstat -n -a -A inet | grep 25
tcp 0 5108 127.0.0.1:59355 127.0.0.1:25 ESTABLISHED
% netstat -n -a -A inet6 | grep 25
tcp 0 0 :::25 :::* LISTEN
tcp 0 0 ::ffff:127.0.0.1:25 ::ffff:127.0.0.1:59355 ESTABLISHED
On the IPv4 side, it thinks it's got 5108 bytes in the send queue - but on
the IPv6 side of that same connection, it's showing 0 in the receive queue,
and we're stuck there.
It's not consistent - sometimes Fetchmail will wedge on the very first mail,
and do so several times in a row. Other times, it will do well for a while -
at the moment, it's gone through 471 of the 1,470 currently queued mails just
fine, only to get wedged again on number 472.
For what it's worth, here's what 'echo w > /proc/sysrq-trigger' got, although I
don't see anything that looks odd to me given the netstat output above -
procmail has sent data, and is waiting for a response back, and sendmail is
waiting for data to arrive:
fetchmail S ffffffff8053c520 5360 17612 9902
ffff81007d37bb08 0000000000000086 0000000000000000 000200d000000000
ffff81006bf826c0 ffffffff80687360 ffff81006bf82918 0000000000000001
0000000000000003 ffff81007d37bb88 0000000000000000 0000000000000000
Call Trace:
[<ffffffff80522682>] schedule_timeout+0x22/0xb4
[<ffffffff80523bd3>] _spin_lock_bh+0x11/0x38
[<ffffffff80523ac4>] _spin_unlock_bh+0x1e/0x20
[<ffffffff8047cec6>] release_sock+0xa3/0xac
[<ffffffff8047d98f>] sk_wait_data+0x8a/0xcf
[<ffffffff80249b99>] autoremove_wake_function+0x0/0x38
[<ffffffff804abdca>] tcp_recvmsg+0x35a/0x86b
[<ffffffff8047c7be>] sock_common_recvmsg+0x32/0x47
[<ffffffff803288be>] selinux_socket_recvmsg+0x1d/0x1f
[<ffffffff8047af38>] sock_recvmsg+0x10e/0x12f
[<ffffffff80249b99>] autoremove_wake_function+0x0/0x38
[<ffffffff8032425d>] avc_has_perm+0x4c/0x5e
[<ffffffff803ac952>] pty_write+0x3a/0x44
[<ffffffff80249dd8>] remove_wait_queue+0x2f/0x3b
[<ffffffff8047c06b>] sys_recvfrom+0xa4/0xf5
[<ffffffff8024c850>] hrtimer_start+0x11f/0x131
[<ffffffff8023aa6e>] do_setitimer+0x184/0x326
[<ffffffff8020c03b>] system_call_after_swapgs+0x7b/0x80
sendmail S ffff81007d30a400 5360 17613 16992
ffff81006bc419e8 0000000000000086 ffff81006bc41998 ffffffff8023f6a5
ffff81007d30a400 ffff81007d24f200 ffff81007d30a658 0000000100000286
ffff81006bc419e8 ffffffff8023f851 000000004789b768 ffff81000100eb20
Call Trace:
[<ffffffff8023f6a5>] lock_timer_base+0x26/0x4a
[<ffffffff8023f851>] __mod_timer+0xc4/0xd6
[<ffffffff805226ed>] schedule_timeout+0x8d/0xb4
[<ffffffff8023f37c>] process_timeout+0x0/0xb
[<ffffffff805226e8>] schedule_timeout+0x88/0xb4
[<ffffffff8029cd26>] do_select+0x4a9/0x50b
[<ffffffff8029d22d>] __pollwait+0x0/0xdf
[<ffffffff8022d7b9>] default_wake_function+0x0/0xf
[<ffffffff80523bd3>] _spin_lock_bh+0x11/0x38
[<ffffffff8047cf74>] lock_sock_nested+0xa5/0xb2
[<ffffffff80523bd3>] _spin_lock_bh+0x11/0x38
[<ffffffff80523ac4>] _spin_unlock_bh+0x1e/0x20
[<ffffffff8047cec6>] release_sock+0xa3/0xac
[<ffffffff804ac1c9>] tcp_recvmsg+0x759/0x86b
[<ffffffff8047c7be>] sock_common_recvmsg+0x32/0x47
[<ffffffff803288be>] selinux_socket_recvmsg+0x1d/0x1f
[<ffffffff8047a924>] sock_aio_read+0x121/0x139
[<ffffffff8032425d>] avc_has_perm+0x4c/0x5e
[<ffffffff8029cf7a>] core_sys_select+0x1f2/0x2a0
[<ffffffff80282f50>] page_add_new_anon_rmap+0x20/0x22
[<ffffffff803251f5>] file_has_perm+0xa5/0xb4
[<ffffffff80249b99>] autoremove_wake_function+0x0/0x38
[<ffffffff8029d45c>] sys_select+0x150/0x17b
[<ffffffff8020c03b>] system_call_after_swapgs+0x7b/0x80
Any ideas?
[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]
^ permalink raw reply
* [FIB]: removes a memset() call in tnode_new()
From: Eric Dumazet @ 2008-01-13 7:35 UTC (permalink / raw)
To: David S. Miller; +Cc: Linux Netdev List
[-- Attachment #1: Type: text/plain, Size: 158 bytes --]
tnode_alloc() already clears allocated memory, using kcalloc()
or alloc_pages(GFP_KERNEL|__GFP_ZERO, ...)
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
[-- Attachment #2: fib_trie.patch --]
[-- Type: text/plain, Size: 355 bytes --]
diff --git a/net/ipv4/fib_trie.c b/net/ipv4/fib_trie.c
index a418498..f26ba31 100644
--- a/net/ipv4/fib_trie.c
+++ b/net/ipv4/fib_trie.c
@@ -391,7 +391,6 @@ static struct tnode* tnode_new(t_key key, int pos, int bits)
struct tnode *tn = tnode_alloc(sz);
if (tn) {
- memset(tn, 0, sz);
tn->parent = T_TNODE;
tn->pos = pos;
tn->bits = bits;
^ permalink raw reply related
* Re: [PATCH 4/9] statistics improvements
From: David Miller @ 2008-01-13 5:44 UTC (permalink / raw)
To: shemminger; +Cc: robert.olsson, netdev, stephen.hemminger
In-Reply-To: <4789A29C.6080000@linux-foundation.org>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Sat, 12 Jan 2008 21:33:16 -0800
> The size field is added to /proc/net/fib_triestat that was the point.
Not from what I can see.
davem@sunset:~/src/GIT/net-2.6.25$ git grep -e "->size" net/ipv4/fib_trie.c
net/ipv4/fib_trie.c: t->size++;
net/ipv4/fib_trie.c: t->size--;
davem@sunset:~/src/GIT/net-2.6.25$ git grep -e "\.size" net/ipv4/fib_trie.c
davem@sunset:~/src/GIT/net-2.6.25$
Nothing uses the field, it is merely incremented and decremented.
trie_show_stats() and trie_show_usage() do not access this field.
^ permalink raw reply
* Re: [PATCH] fib_semantics: prevent long hash chains in access server config
From: David Miller @ 2008-01-13 5:38 UTC (permalink / raw)
To: bcrl; +Cc: netdev
In-Reply-To: <20080112185819.GA12775@kvack.org>
From: Benjamin LaHaise <bcrl@kvack.org>
Date: Sat, 12 Jan 2008 13:58:19 -0500
> This is a patch from a while ago that I'm resending. Basically, in
> access server configurations, a lot of routes have the same local ip
> address but on different devices. This fixes the long chains that
> result from not including the device index in the hash.
I'm not applying this for the same reason I didn't apply it last time.
Please listen to the reason this time, and do not resubmit this until
the problem with this patch is resolved.
The fib_dev is an attribute of the first nexthop, ie. the
fib_info->fib_nh[0] member.
There can be multiple nexthops.
It is pointless to salt the hash with one of the nexthop
device indexes if you do not also compare the index in the
hash lookup comparisons.
And guess why we don't do this? Because it's not part of
the key. Other aspects of the base fib_info and nexthops
provide the uniqueness, not the devindex of the first hop.
So you'll need to find another way to do this.
^ permalink raw reply
* Re: [PATCH 4/9] statistics improvements
From: Stephen Hemminger @ 2008-01-13 5:33 UTC (permalink / raw)
To: David Miller; +Cc: robert.olsson, netdev, stephen.hemminger
In-Reply-To: <20080112.205520.55747078.davem@davemloft.net>
David Miller wrote:
> From: Stephen Hemminger <shemminger@linux-foundation.org>
> Date: Fri, 11 Jan 2008 22:45:17 -0800
>
>
>> Turn the unused size field into a useful counter for the number
>> of routes.
>>
>> Signed-off-by: Stephen Hemminger <stephen.hemminger@vyatta.com>
>>
>
> It's not useful if nothing reports it's value. I'm dropping
> this.
>
> Unless you add code to provide this information via procfs
> or similar, better to just remove it.
>
The size field is added to /proc/net/fib_triestat that was the point.
^ permalink raw reply
* [PATCH v2] Documentation: add a guideline for hard_start_xmit method
From: Matti Linnanvuori @ 2008-01-13 5:33 UTC (permalink / raw)
To: jgarzik, netdev
From: Matti Linnanvuori <mattilinnanvuori@yahoo.com>
Add a guideline for hard_start_xmit method not to
modify SKB.
Signed-off-by: Matti Linnanvuori <mattilinnanvuori@yahoo.com>
---
--- a/Documentation/networking/driver.txt 2008-01-13 07:14:01.608291500 +0200
+++ b/Documentation/networking/driver.txt 2008-01-13 07:13:40.535421500 +0200
@@ -61,7 +61,9 @@
2) Do not forget to update netdev->trans_start to jiffies after
each new tx packet is given to the hardware.
-3) Do not forget that once you return 0 from your hard_start_xmit
+3) A hard_start_xmit method must not modify the shared parts of the SKB.
+
+4) Do not forget that once you return 0 from your hard_start_xmit
method, it is your driver's responsibility to free up the SKB
and in some finite amount of time.
____________________________________________________________________________________
Looking for last minute shopping deals?
Find them fast with Yahoo! Search. http://tools.search.yahoo.com/newsearch/category.php?category=shopping
^ permalink raw reply
* Re: [XFRM]: alg_key_len should be unsigned to avoid integer divides
From: David Miller @ 2008-01-13 5:32 UTC (permalink / raw)
To: dada1; +Cc: netdev
In-Reply-To: <4788F8FC.3010001@cosmosbay.com>
From: Eric Dumazet <dada1@cosmosbay.com>
Date: Sat, 12 Jan 2008 18:29:32 +0100
> alg_key_len is currently defined as 'signed int'. This unfortunatly leads
> to integer divides in several paths.
>
> Converting it to unsigned is safe and saves 208 bytes of text on i386.
>
> Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Applied.
I realigned the struct members in a follow-on changeset.
commit 7305e737926be49e09718df53f4285bf69cc3755
Author: David S. Miller <davem@davemloft.net>
Date: Sat Jan 12 21:31:29 2008 -0800
[XFRM]: Fix struct xfrm_algo code formatting.
Realign struct members.
Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/include/linux/xfrm.h b/include/linux/xfrm.h
index f8507ee..9b5b00c 100644
--- a/include/linux/xfrm.h
+++ b/include/linux/xfrm.h
@@ -91,9 +91,9 @@ struct xfrm_replay_state
};
struct xfrm_algo {
- char alg_name[64];
+ char alg_name[64];
unsigned int alg_key_len; /* in bits */
- char alg_key[0];
+ char alg_key[0];
};
struct xfrm_stats {
^ permalink raw reply related
* Re: [PATCH 2/2] [HTB]: htb_classid is dead static inline
From: David Miller @ 2008-01-13 5:29 UTC (permalink / raw)
To: ilpo.jarvinen; +Cc: netdev
In-Reply-To: <12001388163255-git-send-email-ilpo.jarvinen@helsinki.fi>
From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Sat, 12 Jan 2008 13:53:36 +0200
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Applied.
^ permalink raw reply
* Re: [PATCH 1/2] [NET] core/utils.c: digit2bin is dead static inline
From: David Miller @ 2008-01-13 5:28 UTC (permalink / raw)
To: ilpo.jarvinen; +Cc: netdev
In-Reply-To: <1200138816244-git-send-email-ilpo.jarvinen@helsinki.fi>
From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Sat, 12 Jan 2008 13:53:35 +0200
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Applied.
^ permalink raw reply
* Re: [PATCH 9/9] fix sparse warnings
From: David Miller @ 2008-01-13 5:28 UTC (permalink / raw)
To: stephen.hemminger; +Cc: dada1, robert.olsson, netdev
In-Reply-To: <20080112130946.4d83eca7@deepthought>
From: Stephen Hemminger <stephen.hemminger@vyatta.com>
Date: Sat, 12 Jan 2008 13:09:46 -0800
> On Sat, 12 Jan 2008 12:16:13 +0100
> Eric Dumazet <dada1@cosmosbay.com> wrote:
>
> > [FIB]: Reduce text size of net/ipv4/fib_trie.o
> >
> > In struct tnode, we use two fields of 5 bits for 'pos' and 'bits'.
> > Switching to plain 'unsigned char' (8 bits) take the same space
> > because of compiler alignments, and reduce text size by 435 bytes
> > on i386.
> >
> > On i386 :
> > $ size net/ipv4/fib_trie.o.before_patch net/ipv4/fib_trie.o
> > text data bss dec hex filename
> > 13714 4 64 13782 35d6 net/ipv4/fib_trie.o.before
> > 13279 4 64 13347 3423 net/ipv4/fib_trie.o
> >
> > Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
> >
>
> I agree they should not have been bitfields in the first place.
Applied.
^ permalink raw reply
* Re: [PATCH 6/8] [NETFILTER] xt_policy.c: kill some bloat
From: David Miller @ 2008-01-13 5:26 UTC (permalink / raw)
To: kaber; +Cc: ilpo.jarvinen, netdev, netfilter-devel
In-Reply-To: <47890F03.5080503@trash.net>
From: Patrick McHardy <kaber@trash.net>
Date: Sat, 12 Jan 2008 20:03:31 +0100
> David Miller wrote:
> > From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
> > Date: Sat, 12 Jan 2008 11:34:27 +0200
> >
> > Ilpo, please post netfilter patches to netfilter-devel,
> > CC:'ing Patrick McHardy.
> >
> > Patrick, please review, thanks.
>
> This looks fine to me, thanks Ilpo.
Applied, thanks.
^ permalink raw reply
* Re: [PATCH 9/9] fix sparse warnings
From: David Miller @ 2008-01-13 5:25 UTC (permalink / raw)
To: shemminger; +Cc: robert.olsson, netdev, stephen.hemminger
In-Reply-To: <20080112064646.659443238@linux-foundation.org>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Fri, 11 Jan 2008 22:45:22 -0800
> Make FIB TRIE go through sparse checker without warnings.
>
> Signed-off-by: Stephen Hemminger <stephen.hemminger@vyatta.com>
Also applied, thanks.
^ permalink raw reply
* Re: [PATCH 8/9] add statistics
From: David Miller @ 2008-01-13 5:23 UTC (permalink / raw)
To: shemminger; +Cc: robert.olsson, netdev, stephen.hemminger
In-Reply-To: <20080112064646.583836190@linux-foundation.org>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Fri, 11 Jan 2008 22:45:21 -0800
> The FIB TRIE code has a bunch of statistics, but the code is hidden
> behind an ifdef that was never implemented. Since it was dead code,
> it was broken as well.
>
> This patch fixes that by making it a config option.
>
> Signed-off-by: Stephen Hemminger <stephen.hemminger@vyatta.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH 7/9] printk related cleanups
From: David Miller @ 2008-01-13 4:58 UTC (permalink / raw)
To: shemminger; +Cc: robert.olsson, netdev
In-Reply-To: <20080112064646.507015655@linux-foundation.org>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Fri, 11 Jan 2008 22:45:20 -0800
> printk related cleanups:
> * Get rid of unused printk wrappers.
> * Make bug checks into KERN_WARNING because KERN_DEBUG gets ignored
> * Turn one cryptic old message into something real
> * Make sure all messages have KERN_XXX
Applied, thanks.
^ permalink raw reply
* Re: [PATCH 6/9] : fib_insert_node cleanup
From: David Miller @ 2008-01-13 4:57 UTC (permalink / raw)
To: shemminger; +Cc: robert.olsson, netdev, stephen.hemminger
In-Reply-To: <20080112064646.432200237@linux-foundation.org>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Fri, 11 Jan 2008 22:45:19 -0800
> The only error from fib_insert_node is if memory allocation fails,
> so instead of passing by reference, just use the convention of returning
> NULL.
>
> Signed-off-by: Stephen Hemminger <stephen.hemminger@vyatta.com>
I'd be a hypocrite if I didn't apply this one :-)
Applied, thanks.
^ permalink raw reply
* Re: [PATCH 5/9] use %u for unsigned printfs
From: David Miller @ 2008-01-13 4:56 UTC (permalink / raw)
To: shemminger; +Cc: robert.olsson, netdev, stephen.hemminger
In-Reply-To: <20080112064646.356466158@linux-foundation.org>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Fri, 11 Jan 2008 22:45:18 -0800
> Use %u instead of %d when printing unsigned values.
>
> Signed-off-by: Stephen Hemminger <stephen.hemminger@vyatta.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH 4/9] statistics improvements
From: David Miller @ 2008-01-13 4:55 UTC (permalink / raw)
To: shemminger; +Cc: robert.olsson, netdev, stephen.hemminger
In-Reply-To: <20080112064646.282104074@linux-foundation.org>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Fri, 11 Jan 2008 22:45:17 -0800
> Turn the unused size field into a useful counter for the number
> of routes.
>
> Signed-off-by: Stephen Hemminger <stephen.hemminger@vyatta.com>
It's not useful if nothing reports it's value. I'm dropping
this.
Unless you add code to provide this information via procfs
or similar, better to just remove it.
^ permalink raw reply
* Re: [PATCH 3/9] move size information to pr_debug()
From: David Miller @ 2008-01-13 4:53 UTC (permalink / raw)
To: shemminger; +Cc: robert.olsson, netdev, stephen.hemminger
In-Reply-To: <20080112064646.207183428@linux-foundation.org>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Fri, 11 Jan 2008 22:45:16 -0800
> The size of structures is a debug thing, not something that needs to
> be part of a /proc api.
>
> Signed-off-by: Stephen Hemminger <stephen.hemminger@vyatta.com>
I don't necessarily agree with this one, the size of the
structures is an important inherent attribute contributing
directly to memory usage and performance of the algorithms.
So knowing those values are necessary to diagnose problems.
^ permalink raw reply
* Re: [PATCH 2/9] get rid of unused revision element
From: David Miller @ 2008-01-13 4:50 UTC (permalink / raw)
To: shemminger; +Cc: robert.olsson, netdev, stephen.hemminger
In-Reply-To: <20080112064646.132747871@linux-foundation.org>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Fri, 11 Jan 2008 22:45:15 -0800
> The revision element must of been part of an earlier design,
> because currently it is set but never used.
>
> Signed-off-by: Stephen Hemminger <stephen.hemminger@vyatta.com>
Applied.
I suspect Robert wanted to play around with some generation
ID optimizations but never got around to it.
^ permalink raw reply
* Re: [PATCH 1/9] get rid of trie_init
From: David Miller @ 2008-01-13 4:49 UTC (permalink / raw)
To: shemminger; +Cc: robert.olsson, netdev, stephen.hemminger
In-Reply-To: <20080112064646.056241123@linux-foundation.org>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Fri, 11 Jan 2008 22:45:14 -0800
> trie_init is worthless it is just zeroing stuff that is already
> zero! Move the memset() down to make it obvious.
>
> Signed-off-by: Stephen Hemminger <stephen.hemminger@vyatta.com>
Applied.
^ permalink raw reply
* Re: [RFC PATCH 8/8] [PKTGEN]: uninline getCurUs
From: David Miller @ 2008-01-13 4:24 UTC (permalink / raw)
To: ilpo.jarvinen; +Cc: herbert, netdev
In-Reply-To: <Pine.LNX.4.64.0801121420220.19333@kivilampi-30.cs.helsinki.fi>
From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Sat, 12 Jan 2008 14:59:50 +0200 (EET)
> ...Maybe I just fall-back to changing my last name, it's the only
> full-proof solution... ;-)
Don't do this! Otherwise I won't have a frequent test case to make
sure my patch applying scripts are working properly. :-))))
^ permalink raw reply
* Re: [RFC PATCH 8/8] [PKTGEN]: uninline getCurUs
From: David Miller @ 2008-01-13 4:22 UTC (permalink / raw)
To: herbert; +Cc: ilpo.jarvinen, netdev
In-Reply-To: <20080112121740.GA4555@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sat, 12 Jan 2008 23:17:40 +1100
> Your emails are now using UTF-8 encoding but it's still declaring
> ISO-8859-1 as the charset. So you probably want to fix that up or
> your name may show up as Jävinen on the reader's screen.
Yes, for people using the GIT email patch applying tools, it might do
that. However I believe there are options to git-am and friends to
force it to put things into UTF-8.
I ran into some problems with encoding because I apply stuff by hand
using scripts I wrote.
But those problem won't happen any more for me.
I'm now saving the commit message and patch into files explicitly in
emacs, and verifying the coding (with "C-h C RET") and if it's wrong I
fix it before saving with "C-x RET f mule-utf-8"
Then I feed those into my patch applying scripts.
^ permalink raw reply
* Re: [PATCH net-2.6.25] [XFRM] Remove unused XFRM_STATE_VOID and typos (net/xfrm.h)
From: David Miller @ 2008-01-13 4:12 UTC (permalink / raw)
To: ramirose; +Cc: netdev
In-Reply-To: <eb3ff54b0801120337w2b49ef4bsfb805ac8d28dc712@mail.gmail.com>
From: "Rami Rosen" <ramirose@gmail.com>
Date: Sat, 12 Jan 2008 13:37:34 +0200
> In net/xfrm.h:
> - remove XFRM_STATE_VOID (not in use)
> - correct 3 typos
>
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
XFRM_STATE_VOID is there so that a freshly initialized
object does not have a valid state. So we should not
remove this.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox