* Re: [PATCH 0/6] preparations to enable netdevice notifiers inside a namespace (resend)
From: Daniel Lezcano @ 2008-01-31 14:58 UTC (permalink / raw)
To: Denis V. Lunev; +Cc: David Miller, Linux Containers, netdev
In-Reply-To: <47A1B835.7050600@sw.ru>
Denis V. Lunev wrote:
> Here are some preparations and cleanups to enable network device/inet
> address notifiers inside a namespace.
>
> This set of patches has been originally sent last Friday. One cleanup
> patch from the original series is dropped as wrong, thanks to Daniel
> Lezcano.
Can you explain please.
^ permalink raw reply
* Re: NET: AX88796 use dev_dbg() instead of printk()
From: Jeff Garzik @ 2008-01-31 14:58 UTC (permalink / raw)
To: Ben Dooks; +Cc: netdev, davem
In-Reply-To: <20080131112531.187305225@fluff.org.uk>
On Thu, Jan 31, 2008 at 11:25:31AM +0000, Ben Dooks wrote:
> Change to using dev_dbg() and the other dev_xxx()
> macros instead of printk, and update to use the
> print_mac() helper.
>
> Signed-off-by: Ben Dooks <ben-linux@fluff.org>
Please send to jgarzik@pobox.com or jeff@garzik.org, the email addresses
I've always used for communication.
The redhat.com address is only for legal sign-offs, not actual
communication.
Thanks,
Jeff
^ permalink raw reply
* Re: e1000 full-duplex TCP performance well below wire speed
From: David Acker @ 2008-01-31 14:50 UTC (permalink / raw)
To: Bill Fink
Cc: SANGTAE HA, Bruce Allen, Linux Kernel Mailing List, netdev,
Stephen Hemminger
In-Reply-To: <20080131064533.ef0ae932.billfink@mindspring.com>
Bill Fink wrote:
> If the receive direction uses a different GigE NIC that's part of the
> same quad-GigE, all is fine:
>
> [bill@chance4 ~]$ nuttcp -f-beta -Itx -w2m 192.168.6.79 & nuttcp -f-beta -Irx -r -w2m 192.168.5.79
> tx: 1186.5051 MB / 10.05 sec = 990.2250 Mbps 12 %TX 13 %RX 0 retrans
> rx: 1186.7656 MB / 10.05 sec = 990.5204 Mbps 15 %TX 14 %RX 0 retrans
Could this be an issue with pause frames? At a previous job I remember
having issues with a similar configuration using two broadcom sb1250 3
gigE port devices. If I ran bidirectional tests on a single pair of
ports connected via cross over, it was slower than when I gave each
direction its own pair of ports. The problem turned out to be that
pause frame generation and handling was not configured correctly.
-Ack
^ permalink raw reply
* Re: [PATCH] [VLAN] vlan_dev: Initialize dev pointer only when it is being used
From: Patrick McHardy @ 2008-01-31 14:06 UTC (permalink / raw)
To: Benjamin Li; +Cc: netdev
In-Reply-To: <1201762524-28403-1-git-send-email-ben@wenli.org>
Benjamin Li wrote:
> Signed-off-by: Benjamin Li <ben@wenli.org>
> ---
> net/8021q/vlan_dev.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
> index 8059fa4..2fa5d68 100644
> --- a/net/8021q/vlan_dev.c
> +++ b/net/8021q/vlan_dev.c
> @@ -49,7 +49,7 @@
> */
> static int vlan_dev_rebuild_header(struct sk_buff *skb)
> {
> - struct net_device *dev = skb->dev;
> + struct net_device *dev;
> struct vlan_ethhdr *veth = (struct vlan_ethhdr *)(skb->data);
>
> switch (veth->h_vlan_encapsulated_proto) {
> @@ -60,6 +60,7 @@ static int vlan_dev_rebuild_header(struct sk_buff *skb)
> return arp_find(veth->h_dest, skb);
> #endif
> default:
> + dev = skb->dev;
> pr_debug("%s: unable to resolve type %X addresses.\n",
> dev->name, ntohs(veth->h_vlan_encapsulated_proto));
This seems pretty pointless to me.
^ permalink raw reply
* Re: hard hang through qdisc
From: Patrick McHardy @ 2008-01-31 14:02 UTC (permalink / raw)
To: Andi Kleen; +Cc: hadi, netdev
In-Reply-To: <47A1CD4E.7050701@trash.net>
Patrick McHardy wrote:
> Andi Kleen wrote:
>>> ---------
>>> lilsol:~# tc qdisc add dev eth0 root tbf rate 1000 burst 10 limit 100
>>> lilsol:~# uname -a
>>> Linux lilsol 2.6.24 #1 PREEMPT Sun Jan 27 09:22:00 EST 2008 i686
>>
>> Can you try it again with current git mainline?
>
>
> I'll look into it.
Works for me:
qdisc tbf 8001: root rate 1000bit burst 10b/8 mpu 0b lat 720.0ms
Sent 0 bytes 0 pkt (dropped 9, overlimits 0 requeues 0)
rate 0bit 0pps backlog 0b 0p requeues 0
Packets are dropped as expected.
^ permalink raw reply
* Re: [PATCH 2/6][INET]: Consolidate inet(6)_hash_connect.
From: Arnaldo Carvalho de Melo @ 2008-01-31 13:39 UTC (permalink / raw)
To: Pavel Emelyanov
Cc: Arnaldo Carvalho de Melo, David Miller, Linux Netdev List, devel
In-Reply-To: <47A1CABB.8050805@openvz.org>
Em Thu, Jan 31, 2008 at 04:18:51PM +0300, Pavel Emelyanov escreveu:
> Arnaldo Carvalho de Melo wrote:
> > Em Thu, Jan 31, 2008 at 03:32:09PM +0300, Pavel Emelyanov escreveu:
> >> These two functions are the same except for what they call
> >> to "check_established" and "hash" for a socket.
> >>
> >> This saves half-a-kilo for ipv4 and ipv6.
> >
> > Good stuff!
> >
> > Yesterday I was perusing tcp_hash and I think we could have the hashinfo
> > pointer stored perhaps in sk->sk_prot.
> >
> > That way we would be able to kill tcp_hash(), inet_put_port() could
> > receive just sk, etc.
>
> But each proto will still have its own hashfn, so proto's
> callbacks will be called to hash/unhash sockets, so this will
> give us just one extra dereference. No?
>
> > What do you think?
>
> Hmmm... Even raw_hash, etc may become simpler. On the other hand
> maybe this is a good idea, but I'm not very common with this code
> yet to foresee such things in advance... I think that we should
> try to prepare a patch and look, but if you have smth ready, then
> it's better to review your stuff first.
gimme some minutes
- Arnaldo
^ permalink raw reply
* Re: [PATCH 6/6][NETNS]: Udp sockets per-net lookup.
From: YOSHIFUJI Hideaki / 吉藤英明 @ 2008-01-31 13:40 UTC (permalink / raw)
To: davem; +Cc: xemul, netdev, devel, yoshfuji
In-Reply-To: <20080131.052007.165146562.davem@davemloft.net>
In article <20080131.052007.165146562.davem@davemloft.net> (at Thu, 31 Jan 2008 05:20:07 -0800 (PST)), David Miller <davem@davemloft.net> says:
> The networking devices are even per-namespace already,
> so you can even say that each namespace is even
> physically different.
Ah, okay, we are splitting "weak" domains...
--yoshfuji
^ permalink raw reply
* Re: [PATCH] cls_u32 u32_classify() +
From: jamal @ 2008-01-31 13:30 UTC (permalink / raw)
To: mahatma; +Cc: netdev
In-Reply-To: <47A07C3B.7030203@bspu.unibel.by>
On Wed, 2008-30-01 at 11:31 -0200, Dzianis Kahanovich wrote:
> Currently fine u32 "hashkey ... at ..." not work with relative offsets.
> There are simpliest fix to use "eat".
> (sorry, v2)
>
Hi,
Please send me the commands you are trying to run that motivated this
patch.
cheers,
jamal
^ permalink raw reply
* Re: hard hang through qdisc
From: Patrick McHardy @ 2008-01-31 13:29 UTC (permalink / raw)
To: Andi Kleen; +Cc: hadi, netdev
In-Reply-To: <200801311428.48175.ak@suse.de>
Andi Kleen wrote:
>> ---------
>> lilsol:~# tc qdisc add dev eth0 root tbf rate 1000 burst 10 limit 100
>> lilsol:~# uname -a
>> Linux lilsol 2.6.24 #1 PREEMPT Sun Jan 27 09:22:00 EST 2008 i686
>
> Can you try it again with current git mainline?
I'll look into it.
^ permalink raw reply
* Re: hard hang through qdisc
From: Andi Kleen @ 2008-01-31 13:28 UTC (permalink / raw)
To: hadi; +Cc: netdev
In-Reply-To: <1201782841.4732.11.camel@localhost>
> ---------
> lilsol:~# tc qdisc add dev eth0 root tbf rate 1000 burst 10 limit 100
> lilsol:~# uname -a
> Linux lilsol 2.6.24 #1 PREEMPT Sun Jan 27 09:22:00 EST 2008 i686
Can you try it again with current git mainline?
> GNU/Linux
> lilsol:~# tc qdisc ls dev eth0
> qdisc tbf 8001: root rate 1000bit burst 10b lat 737.3ms
> lilsol:~#
> -------
>
> What do your patches do?
Nothing really related to qdiscs. I suspect it came from the git mainline patch
I had (but forgot to mention in the first email)
-Andi
^ permalink raw reply
* Re: hard hang through qdisc
From: jamal @ 2008-01-31 12:34 UTC (permalink / raw)
To: Andi Kleen; +Cc: netdev
In-Reply-To: <200801311321.01015.ak@suse.de>
On Thu, 2008-31-01 at 13:21 +0100, Andi Kleen wrote:
>
> I just managed to hang a 2.6.24 (+ some non network patches) kernel
> with the following (non sensical) command
>
> tc qdisc add dev eth0 root tbf rate 1000 burst 10 limit 100
>
> No oops or anything just hangs. While I understand root can
> do bad things just hanging like this seems a little extreme.
>
---------
lilsol:~# tc qdisc add dev eth0 root tbf rate 1000 burst 10 limit 100
lilsol:~# uname -a
Linux lilsol 2.6.24 #1 PREEMPT Sun Jan 27 09:22:00 EST 2008 i686
GNU/Linux
lilsol:~# tc qdisc ls dev eth0
qdisc tbf 8001: root rate 1000bit burst 10b lat 737.3ms
lilsol:~#
-------
What do your patches do?
cheers,
jamal
^ permalink raw reply
* Re: [PATCH 6/6][NETNS]: Udp sockets per-net lookup.
From: David Miller @ 2008-01-31 13:20 UTC (permalink / raw)
To: yoshfuji; +Cc: xemul, netdev, devel
In-Reply-To: <20080201.001138.95019632.yoshfuji@wide.ad.jp>
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@wide.ad.jp>
Date: Fri, 01 Feb 2008 00:11:38 +1100 (EST)
> In article <47A1C216.9000303@openvz.org> (at Thu, 31 Jan 2008 15:41:58 +0300), Pavel Emelyanov <xemul@openvz.org> says:
>
> > Add the net parameter to udp_get_port family of calls and
> > udp_lookup one and use it to filter sockets.
>
> I may miss something, but I'm afraid that I have to disagree.
> Port is identified only by family, address, protocol and port,
> and should not be split by name space.
It is like being on a totally different system.
Without sockets in namespaces, there is no point.
The networking devices are even per-namespace already,
so you can even say that each namespace is even
physically different.
^ permalink raw reply
* Re: [PATCH 2/6][INET]: Consolidate inet(6)_hash_connect.
From: Pavel Emelyanov @ 2008-01-31 13:18 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo; +Cc: David Miller, Linux Netdev List, devel
In-Reply-To: <20080131130153.GP1819@ghostprotocols.net>
Arnaldo Carvalho de Melo wrote:
> Em Thu, Jan 31, 2008 at 03:32:09PM +0300, Pavel Emelyanov escreveu:
>> These two functions are the same except for what they call
>> to "check_established" and "hash" for a socket.
>>
>> This saves half-a-kilo for ipv4 and ipv6.
>
> Good stuff!
>
> Yesterday I was perusing tcp_hash and I think we could have the hashinfo
> pointer stored perhaps in sk->sk_prot.
>
> That way we would be able to kill tcp_hash(), inet_put_port() could
> receive just sk, etc.
But each proto will still have its own hashfn, so proto's
callbacks will be called to hash/unhash sockets, so this will
give us just one extra dereference. No?
> What do you think?
Hmmm... Even raw_hash, etc may become simpler. On the other hand
maybe this is a good idea, but I'm not very common with this code
yet to foresee such things in advance... I think that we should
try to prepare a patch and look, but if you have smth ready, then
it's better to review your stuff first.
> - Arnaldo
>
Thanks,
Pavel
^ permalink raw reply
* Re: Null pointer dereference when bringing up bonding device on kernel-2.6.24-2.fc9.i686
From: Siim Põder @ 2008-01-31 12:51 UTC (permalink / raw)
To: Jay Vosburgh; +Cc: netdev
In-Reply-To: <7908.1201551451@death>
Yo!
Jay Vosburgh wrote:
> Benny Amorsen <benny+usenet@amorsen.dk> wrote:
>
>> https://bugzilla.redhat.com/show_bug.cgi?id=430391
>
> I know what this is, I'll fix it.
do you know when this happend, so we would know which kernel is ok to
use (not to start trying blindly)?
Siim
^ permalink raw reply
* Re: [PATCH 2/6][INET]: Consolidate inet(6)_hash_connect.
From: David Miller @ 2008-01-31 13:15 UTC (permalink / raw)
To: acme; +Cc: xemul, netdev, devel
In-Reply-To: <20080131130153.GP1819@ghostprotocols.net>
From: Arnaldo Carvalho de Melo <acme@redhat.com>
Date: Thu, 31 Jan 2008 11:01:53 -0200
> Em Thu, Jan 31, 2008 at 03:32:09PM +0300, Pavel Emelyanov escreveu:
> > These two functions are the same except for what they call
> > to "check_established" and "hash" for a socket.
> >
> > This saves half-a-kilo for ipv4 and ipv6.
>
> Good stuff!
>
> Yesterday I was perusing tcp_hash and I think we could have the hashinfo
> pointer stored perhaps in sk->sk_prot.
>
> That way we would be able to kill tcp_hash(), inet_put_port() could
> receive just sk, etc.
>
> What do you think?
Sounds good to me.
^ permalink raw reply
* Re: [PATCH 1/6] [IPV4]: Fix memory leak on error path during FIB initialization.
From: David Miller @ 2008-01-31 13:14 UTC (permalink / raw)
To: den; +Cc: netdev, linux-kernel, devel
In-Reply-To: <1201780850-22216-1-git-send-email-den@openvz.org>
From: "Denis V. Lunev" <den@openvz.org>
Date: Thu, 31 Jan 2008 15:00:45 +0300
> commit c8050bf6d84785a7edd2e81591e8f833231477e8
> Author: Denis V. Lunev <den@openvz.org>
> Date: Thu Jan 10 03:28:24 2008 -0800
I am fixing it up for you this time, but please do not
reference the commit this way.
Say something like:
blah blah blah in commit $(SHA1_HASH) ("commit head line").
The author and date give no real useful information in
this context, the important part is giving the reader
enough information to find the commit should they wish
to gain more information.
If they have the commit hash they can usually find the
commit, but if that fails they can search the commit
messages for the head line text string.
I feel like I've had to explain this 10 times in the past week...
:-/
^ permalink raw reply
* Re: [PATCH 6/6][NETNS]: Udp sockets per-net lookup.
From: YOSHIFUJI Hideaki / 吉藤英明 @ 2008-01-31 13:11 UTC (permalink / raw)
To: xemul; +Cc: davem, netdev, devel, yoshfuji
In-Reply-To: <47A1C216.9000303@openvz.org>
In article <47A1C216.9000303@openvz.org> (at Thu, 31 Jan 2008 15:41:58 +0300), Pavel Emelyanov <xemul@openvz.org> says:
> Add the net parameter to udp_get_port family of calls and
> udp_lookup one and use it to filter sockets.
I may miss something, but I'm afraid that I have to disagree.
Port is identified only by family, address, protocol and port,
and should not be split by name space.
--yoshfuji
^ permalink raw reply
* Re: [PATCH retry] bluetooth : add conn add/del workqueues to avoid connection fail
From: Jens Axboe @ 2008-01-31 13:09 UTC (permalink / raw)
To: Dave Young; +Cc: marcel, davem, linux-kernel, bluez-devel, netdev
In-Reply-To: <20080130022354.GA3132@darkstar.te-china.tietoenator.com>
On Wed, Jan 30 2008, Dave Young wrote:
>
> The bluetooth hci_conn sysfs add/del executed in the default workqueue.
> If the del_conn is executed after the new add_conn with same target,
> add_conn will failed with warning of "same kobject name".
>
> Here add btaddconn & btdelconn workqueues,
> flush the btdelconn workqueue in the add_conn function to avoid the issue.
>
> Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
>
> ---
> diff -upr a/net/bluetooth/hci_sysfs.c b/net/bluetooth/hci_sysfs.c
> --- a/net/bluetooth/hci_sysfs.c 2008-01-30 10:14:27.000000000 +0800
> +++ b/net/bluetooth/hci_sysfs.c 2008-01-30 10:14:14.000000000 +0800
> @@ -12,6 +12,8 @@
> #undef BT_DBG
> #define BT_DBG(D...)
> #endif
> +static struct workqueue_struct *btaddconn;
> +static struct workqueue_struct *btdelconn;
>
> static inline char *typetostr(int type)
> {
> @@ -279,6 +281,7 @@ static void add_conn(struct work_struct
> struct hci_conn *conn = container_of(work, struct hci_conn, work);
> int i;
>
> + flush_workqueue(btdelconn);
> if (device_add(&conn->dev) < 0) {
> BT_ERR("Failed to register connection device");
> return;
> @@ -313,6 +316,7 @@ void hci_conn_add_sysfs(struct hci_conn
>
> INIT_WORK(&conn->work, add_conn);
>
> + queue_work(btaddconn, &conn->work);
> schedule_work(&conn->work);
> }
So you queue &conn->work on both btaddconn and keventd_wq?
--
Jens Axboe
^ permalink raw reply
* Re: [PATCH 6/6][NETNS]: Udp sockets per-net lookup.
From: David Miller @ 2008-01-31 13:08 UTC (permalink / raw)
To: xemul; +Cc: netdev, devel
In-Reply-To: <47A1C216.9000303@openvz.org>
From: Pavel Emelyanov <xemul@openvz.org>
Date: Thu, 31 Jan 2008 15:41:58 +0300
> Add the net parameter to udp_get_port family of calls and
> udp_lookup one and use it to filter sockets.
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Applied.
^ permalink raw reply
* Re: [PATCH 5/6][NETNS]: Tcp-v6 sockets per-net lookup.
From: David Miller @ 2008-01-31 13:07 UTC (permalink / raw)
To: xemul; +Cc: netdev, devel
In-Reply-To: <47A1C1B0.3020807@openvz.org>
From: Pavel Emelyanov <xemul@openvz.org>
Date: Thu, 31 Jan 2008 15:40:16 +0300
> Add a net argument to inet6_lookup and propagate it further.
> Actually, this is tcp-v6 implementation of what was done for
> tcp-v4 sockets in a previous patch.
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Applied.
^ permalink raw reply
* Re: [PATCH 4/6][NETNS]: Tcp-v4 sockets per-net lookup.
From: David Miller @ 2008-01-31 13:06 UTC (permalink / raw)
To: xemul; +Cc: netdev, devel
In-Reply-To: <47A1C137.4030306@openvz.org>
From: Pavel Emelyanov <xemul@openvz.org>
Date: Thu, 31 Jan 2008 15:38:15 +0300
> Add a net argument to inet_lookup and propagate it further
> into lookup calls. Plus tune the __inet_check_established.
>
> The dccp and inet_diag, which use that lookup functions
> pass the init_net into them.
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Applied.
^ permalink raw reply
* Re: [PATCH 3/6][NETNS]: Make bind buckets live in net namespaces.
From: David Miller @ 2008-01-31 13:06 UTC (permalink / raw)
To: xemul; +Cc: netdev, devel
In-Reply-To: <47A1C09B.6090202@openvz.org>
From: Pavel Emelyanov <xemul@openvz.org>
Date: Thu, 31 Jan 2008 15:35:39 +0300
> This tags the inet_bind_bucket struct with net pointer,
> initializes it during creation and makes a filtering
> during lookup.
>
> A better hashfn, that takes the net into account is to
> be done in the future, but currently all bind buckets
> with similar port will be in one hash chain.
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Applied.
^ permalink raw reply
* Re: [PATCH 2/6][INET]: Consolidate inet(6)_hash_connect.
From: David Miller @ 2008-01-31 13:04 UTC (permalink / raw)
To: xemul; +Cc: netdev, devel
In-Reply-To: <47A1BFC9.2030603@openvz.org>
From: Pavel Emelyanov <xemul@openvz.org>
Date: Thu, 31 Jan 2008 15:32:09 +0300
> These two functions are the same except for what they call
> to "check_established" and "hash" for a socket.
>
> This saves half-a-kilo for ipv4 and ipv6.
>
> add/remove: 1/0 grow/shrink: 1/4 up/down: 582/-1128 (-546)
> function old new delta
> __inet_hash_connect - 577 +577
> arp_ignore 108 113 +5
> static.hint 8 4 -4
> rt_worker_func 376 372 -4
> inet6_hash_connect 584 25 -559
> inet_hash_connect 586 25 -561
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Applied.
^ permalink raw reply
* Re: [PATCH 0/6][IPV6]: Introduce the INET6_TW_MATCH macro.
From: David Miller @ 2008-01-31 13:03 UTC (permalink / raw)
To: xemul; +Cc: netdev, devel
In-Reply-To: <47A1BF20.7070509@openvz.org>
From: Pavel Emelyanov <xemul@openvz.org>
Date: Thu, 31 Jan 2008 15:29:20 +0300
"0/6"? :-)
> We have INET_MATCH, INET_TW_MATCH and INET6_MATCH to test
> sockets and twbuckets for matching, but ipv6 twbuckets are
> tested manually.
>
> Here's the INET6_TW_MATCH to help with it.
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH 2/6][INET]: Consolidate inet(6)_hash_connect.
From: Arnaldo Carvalho de Melo @ 2008-01-31 13:01 UTC (permalink / raw)
To: Pavel Emelyanov; +Cc: David Miller, Linux Netdev List, devel
In-Reply-To: <47A1BFC9.2030603@openvz.org>
Em Thu, Jan 31, 2008 at 03:32:09PM +0300, Pavel Emelyanov escreveu:
> These two functions are the same except for what they call
> to "check_established" and "hash" for a socket.
>
> This saves half-a-kilo for ipv4 and ipv6.
Good stuff!
Yesterday I was perusing tcp_hash and I think we could have the hashinfo
pointer stored perhaps in sk->sk_prot.
That way we would be able to kill tcp_hash(), inet_put_port() could
receive just sk, etc.
What do you think?
- Arnaldo
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox