Netdev List
 help / color / mirror / Atom feed
* Re: fanotify as syscalls
From: Eric Paris @ 2009-09-22 21:06 UTC (permalink / raw)
  To: Andreas Gruenbacher
  Cc: Jamie Lokier, Linus Torvalds, Evgeniy Polyakov, David Miller,
	linux-kernel, linux-fsdevel, netdev, viro, alan, hch
In-Reply-To: <200909212204.51077.agruen@suse.de>

On Mon, 2009-09-21 at 22:04 +0200, Andreas Gruenbacher wrote:
> On Saturday, 19 September 2009 5:04:31 Eric Paris wrote:
> > Let me start by saying I am agreeing I should pursue subtree
> > notification.  It's what I think everyone really wants.  It's a great
> > idea, and I think you might have a simple way to get close.  Clearly
> > these are avenues I'm willing and hoping to pursue.  Also I say it
> > again, I believe the interface as proposed (except maybe some of my
> > exclusion stuff) is flexible enough to implement any of these ideas.
> > Does anyone disagree?
> 
> It does seem flexible enough. However, the current interface assumes "global" 
> listeners (the mask argument of fanotify_init):
> 
>   int fanotify_init(int flags, int f_flags, __u64 mask,
> 		    unsigned int priority);
> 
> Once subtree support is added, this parameter becomes obsolete. That's pretty 
> broken for a syscall yet to be introduced.

Absolutely not obsolete.  Subtree notification cannot do fscking all
notification.  

> > BUT to solve one of the main problems fanotify is intending to solve it
> > needs a way to be the 'fscking all notifier.'  It needs to be the whole
> > damn system.
> 
> Think of a system after boot, with a single global namespace. Whatever you 
> access by filename is reachable from the namespace root. At this point, 
> nothing more global exists. A listener can watch the mount points of 
> interest, and everything's fine.

this is true, if there is only one namespace subtree notification works
the same as global notification.

> What's a bit more tricky is to ensure that this listener will continue to 
> receive all events from whatever else is mounted anywhere, irrespective of 
> namespaces. I think we can get there.

Lets say I want the subtree under / to get every event on the system.  A
process comes along and clones the namespace.  Then lets say that
process mounts something inside his new namespace.  There is absolutely
no path between my / and that new mount.  How can subtree checking
possibly find and indicate it wants notification about this mount?  I
don't see how subtree checking could do it.  There can be completely
disjoint trees with no overlap.

mount -t tmpfs none /to_umount
clone namespace
mount -t tmpfs none /to_umount/private
pivot_root /tmp_umount/private
Something else umounts /to_umount

That process is in an completely detached namespace?  right?

Heck, there could be operations on files that aren't in ANY namespace.

a = open(/path/to/dir/);
umount -l /path/to/
openat(a, "filename");

I don't see how subtree notification can possibly solve the global
notification problem.

I've been thinking that checking CAP_SYS_RAWIO as well as CAP_SYS_ADMIN
might be reasonable when trying to use a global listener.  If you can
CAP_SYS_RAWIO I sorta feel like you can break out of a namespace anyway,
right?

-Eric

^ permalink raw reply

* Re: [PATCH 1/2] netxen: fix minor tx timeout bug
From: David Miller @ 2009-09-22 21:14 UTC (permalink / raw)
  To: dhananjay; +Cc: netdev
In-Reply-To: <1253510439-28464-1-git-send-email-dhananjay@netxen.com>

From: Dhananjay Phadke <dhananjay@netxen.com>
Date: Sun, 20 Sep 2009 22:20:38 -0700

> Fix minor bug in netdev tx timeout handling which could
> always lead to firmware reset instead of pci function reset.
> 
> netxen_nic_reset_context() requires __NX_RESETTING bit
> cleared.
> 
> Signed-off-by: Dhananjay Phadke <dhananjay@netxen.com>

Applied.

^ permalink raw reply

* Re: [PATCH 2/2] netxen: fix firmware init after resume
From: David Miller @ 2009-09-22 21:14 UTC (permalink / raw)
  To: dhananjay; +Cc: netdev
In-Reply-To: <1253510439-28464-2-git-send-email-dhananjay@netxen.com>

From: Dhananjay Phadke <dhananjay@netxen.com>
Date: Sun, 20 Sep 2009 22:20:39 -0700

> After successful firmware init, return instead of
> falling to error path (leading to detach) after
> resuming to D0 state. This was broken in recent
> firmware reset rehaul.
> 
> Signed-off-by: Dhananjay Phadke <dhananjay@netxen.com>

Applied.

^ permalink raw reply

* Re: [RFC][PATCH] pcmcia: pcnet_cs.c removing useless condition
From: David Miller @ 2009-09-22 21:17 UTC (permalink / raw)
  To: jaswinder; +Cc: jeff, netdev, linux-pcmcia, linux
In-Reply-To: <1252782529.3687.26.camel@ht.satnam>

From: Jaswinder Singh Rajput <jaswinder@kernel.org>
Date: Sun, 13 Sep 2009 00:38:49 +0530

> [This is untested]
> 
> 'if (i < NR_INFO)' will only true if we breaks from 'for (i = 0; i < NR_INFO; i++)'
> So removing useless 'if (i < NR_INFO)'
> 
> This also fixed following compilation warning :
> 
>   CC [M]  drivers/net/pcmcia/pcnet_cs.o
> drivers/net/pcmcia/pcnet_cs.c: In function ‘get_hwinfo’:
> drivers/net/pcmcia/pcnet_cs.c:321: warning: ‘base’ may be used uninitialized in this function
> 
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>

Looks good to me, applied.

^ permalink raw reply

* Re: [PATCH] net: xilinx_emaclite: Fix problem with first incoming packet
From: David Miller @ 2009-09-22 21:17 UTC (permalink / raw)
  To: John.Linn; +Cc: grant.likely, netdev, linuxppc-dev, jwboyer, sadanan, monstr
In-Reply-To: <20090922165612.584554A8052@mail195-sin.bigfish.com>

From: John Linn <John.Linn@xilinx.com>
Date: Tue, 22 Sep 2009 10:56:27 -0600

> Thanks Grant, I wondered about that myself.

I've applied this patch, thanks.

^ permalink raw reply

* Re: [PATCH] lib/vsprintf.c: Avoid possible unaligned accesses in %pI6c
From: David Miller @ 2009-09-22 21:17 UTC (permalink / raw)
  To: joe; +Cc: netdev, me
In-Reply-To: <1253315046.2543.475.camel@Joe-Laptop.home>

From: Joe Perches <joe@perches.com>
Date: Fri, 18 Sep 2009 16:04:06 -0700

> Jens Rosenboom noticed that a possibly unaligned const char*
> is cast to a const struct in6_addr *.
> 
> Avoid this at the cost of a struct in6_addr copy on the stack.
> 
> Signed-off-by: Joe Perches <joe@perches.com>

Applied, thanks.

^ permalink raw reply

* Re: [PATCH] smsc95xx: fix transmission where ZLP is expected
From: David Miller @ 2009-09-22 21:19 UTC (permalink / raw)
  To: steve.glendinning; +Cc: netdev, ian.saturley, vlad.lyalikov
In-Reply-To: <1253628027-2704-1-git-send-email-steve.glendinning@smsc.com>

From: Steve Glendinning <steve.glendinning@smsc.com>
Date: Tue, 22 Sep 2009 15:00:27 +0100

> Usbnet framework assumes USB hardware doesn't handle zero length
> packets, but SMSC LAN95xx requires these to be sent for correct
> operation.
> 
> This patch fixes an easily reproducible tx lockup when sending a frame
> that results in exactly 512 bytes in a USB transmission (e.g. a UDP
> frame with 458 data bytes, due to IP headers and our USB headers).  It
> adds an extra flag to usbnet for the hardware driver to indicate that
> it can handle and requires the zero length packets.
> 
> This patch should not affect other usbnet users, please also consider
> for -stable.
> 
> Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>

Applied, thanks.

^ permalink raw reply

* Re: [PATCH] smsc95xx: add additional USB product IDs
From: David Miller @ 2009-09-22 21:20 UTC (permalink / raw)
  To: steve.glendinning; +Cc: netdev, ian.saturley, vlad.lyalikov
In-Reply-To: <1253632382-18458-1-git-send-email-steve.glendinning@smsc.com>

From: Steve Glendinning <steve.glendinning@smsc.com>
Date: Tue, 22 Sep 2009 16:13:02 +0100

> Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>

Applied.

^ permalink raw reply

* Re: [PATCH 2/5] drivers/net: remove duplicate structure field initialization
From: David Miller @ 2009-09-22 21:21 UTC (permalink / raw)
  To: julia; +Cc: netdev, linux-kernel, kernel-janitors
In-Reply-To: <Pine.LNX.4.64.0909192148180.27171@ask.diku.dk>

From: Julia Lawall <julia@diku.dk>
Date: Sat, 19 Sep 2009 21:48:41 +0200 (CEST)

> From: Julia Lawall <julia@diku.dk>
> 
> The definitions of vnet_ops and ehea_netdev_ops have initializations of a
> local function and eth_change_mtu for their respective ndo_change_mtu
> fields.  This change uses only the local function.
> 
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
 ...
> Signed-off-by: Julia Lawall <julia@diku.dk>

Applied.

^ permalink raw reply

* Re: [PATCH] sky2: Set SKY2_HW_RAM_BUFFER in sky2_init
From: David Miller @ 2009-09-22 21:21 UTC (permalink / raw)
  To: mikem; +Cc: shemminger, netdev
In-Reply-To: <4AB788F4.90503@ring3k.org>

From: Mike McCormack <mikem@ring3k.org>
Date: Mon, 21 Sep 2009 23:08:52 +0900

> The SKY2_HW_RAM_BUFFER bit in hw->flags was checked in sky2_mac_init(),
>  before being set later in sky2_up().
> 
> Setting SKY2_HW_RAM_BUFFER in sky2_init() where other hw->flags are set
>  should avoid this problem recurring.
> 
> Signed-off-by: Mike McCormack <mikem@ring3k.org>

Applied and queued up for -stable, thanks.

^ permalink raw reply

* Re: [Patch net-next]atl1c:remove compiling warning
From: David Miller @ 2009-09-22 21:21 UTC (permalink / raw)
  To: jie.yang; +Cc: akpm, jirislaby, jcliburn, netdev, linux-kernel
In-Reply-To: <12535093181069-git-send-email-jie.yang@atheros.com>

From: <jie.yang@atheros.com>
Date: Mon, 21 Sep 2009 13:01:58 +0800

> Set wol_ctrl_data to value 0, to remove compiling warning.
> 
> Signed-off-by: Jie Yang <jie.yang@atheros.com>

Applied.

^ permalink raw reply

* Re: [PATCH 1/2] pktgen: check for link down
From: David Miller @ 2009-09-22 21:24 UTC (permalink / raw)
  To: shemminger; +Cc: robert, jdb, netdev
In-Reply-To: <20090921225543.44d2d5c4@nehalam>

From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 21 Sep 2009 22:55:43 -0700

> You can hold off on these two patches, I have better version
> which fixes some other issues. But testing time is limited this week.

Ok

^ permalink raw reply

* Re: [PATCH] ax25: Fix SIOCAX25GETINFO ioctl
From: David Miller @ 2009-09-22 21:25 UTC (permalink / raw)
  To: eric.dumazet; +Cc: jr+netfilter-devel, netdev
In-Reply-To: <4AB65937.8010508@gmail.com>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sun, 20 Sep 2009 18:32:55 +0200

> [PATCH] ax25: Fix SIOCAX25GETINFO ioctl
> 
> rcv_q & snd_q initializations were reversed in commit
> 31e6d363abcd0d05766c82f1a9c905a4c974a199
> (net: correct off-by-one write allocations reports)
> 
> Signed-off-by: Jan Rafaj <jr+netfilter-devel@cedric.unob.cz>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>

Applied and I'll make sure to check if it needs -stable
treatment too.

Thanks.

^ permalink raw reply

* Re: [PATCH] atm: dereference of he_dev->rbps_virt in he_init_group()
From: David Miller @ 2009-09-22 21:25 UTC (permalink / raw)
  To: roel.kluin; +Cc: joe, chas, linux-atm-general, netdev, akpm
In-Reply-To: <4AB66240.6060703@gmail.com>

From: Roel Kluin <roel.kluin@gmail.com>
Date: Sun, 20 Sep 2009 19:11:28 +0200

> he_dev->rbps_virt or he_dev->rbpl_virt allocation may fail, s
> them. Make sure that he_init_group() cleans up after errors.
> 
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>

Applied.

^ permalink raw reply

* Re: [PATCH] 8139cp: fix duplicate loglevel in module load message
From: David Miller @ 2009-09-22 21:25 UTC (permalink / raw)
  To: alan-jenkins; +Cc: netdev, linux-kernel, a.beregalov
In-Reply-To: <4AB8D9B3.4010805@tuffmail.co.uk>

From: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Date: Tue, 22 Sep 2009 15:05:39 +0100

> This was introduced by b93d58 "8139*: convert printk() to pr_<foo>()":
> 
> [ 2256252443 ] <6>8139cp: 10/100 PCI Ethernet driver v1.3 (Mar 22, 2004)
> 
> The "version" string is printed using pr_info(), so it doesn't need to
> include a loglevel.
> 
> Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
> CC: Alexander Beregalov <a.beregalov@gmail.com>

Applied.

^ permalink raw reply

* Re: tun: Return -EINVAL if neither IFF_TUN nor IFF_TAP is set.
From: David Miller @ 2009-09-22 21:26 UTC (permalink / raw)
  To: paul.moore; +Cc: slash, netdev, linux-kernel
In-Reply-To: <200909180754.05817.paul.moore@hp.com>

From: Paul Moore <paul.moore@hp.com>
Date: Fri, 18 Sep 2009 07:54:05 -0400

> On Thursday 17 September 2009 03:36:13 am Kusanagi Kouichi wrote:
>> After commit 2b980dbd77d229eb60588802162c9659726b11f4
>> ("lsm: Add hooks to the TUN driver") tun_set_iff doesn't
>> return -EINVAL though neither IFF_TUN nor IFF_TAP is set.
>> 
>> Signed-off-by: Kusanagi Kouichi <slash@ma.neweb.ne.jp>
> 
> Sorry about that, my mistake, thanks for finding and fixing this.
> 
> Reviewed-by: Paul Moore <paul.moore@hp.com>

Applied.

^ permalink raw reply

* Re: [patch 1/6] isdn: hisax, fix lock imbalance
From: David Miller @ 2009-09-22 21:34 UTC (permalink / raw)
  To: akpm; +Cc: isdn, netdev, jirislaby, Karsten-Keil
In-Reply-To: <200909181953.n8IJr1Wl026154@imap1.linux-foundation.org>


I'm hoping Karsten will pick these up.

But I'm not optimistic as I've been waiting weeks for some
other ISDN fixes to get looked at :-/

^ permalink raw reply

* Re: fanotify as syscalls
From: Andreas Gruenbacher @ 2009-09-22 21:38 UTC (permalink / raw)
  To: Eric Paris
  Cc: Jamie Lokier, Linus Torvalds, Evgeniy Polyakov, David Miller,
	linux-kernel, linux-fsdevel, netdev, viro, alan, hch
In-Reply-To: <1253653576.2747.27.camel@dhcp231-106.rdu.redhat.com>

On Tuesday, 22 September 2009 23:06:16 Eric Paris wrote:
> this is true, if there is only one namespace subtree notification works
> the same as global notification.
>
> [...]
>
> I don't see how subtree notification can possibly solve the global
> notification problem.

I'm thinking of is something like this: A listener registers interest in "/", 
recursively. The kernel sets a FSNOTIFY_WATCH_RECURSIVE flag on "/" and each 
mount point below. Afterwards when something is mounted anywhere, same 
namespace or not, the kernel sets the new mount's FSNOTIFY_WATCH_RECURSIVE 
flag if the parent mount has this flag set.

(Of course we need per fsnotify_group flags and not global ones, but this 
doesn't change the principle.)

Andreas

^ permalink raw reply

* [PATCH][RESEND 3] IPv6: 6rd tunnel mode
From: Alexandre Cassen @ 2009-09-22 22:02 UTC (permalink / raw)
  To: netdev

This patch add support to 6rd tunnel mode as described into
draft-despres-6rd-03.

Patch history :
* http://patchwork.ozlabs.org/patch/26870/
* http://patchwork.ozlabs.org/patch/34026/
* http://patchwork.ozlabs.org/patch/34045/

IPv6 rapid deployment (draft-despres-6rd-03) builds upon mechanisms
of 6to4 (RFC3056) to enable a service provider to rapidly deploy IPv6
unicast service to IPv4 sites to which it provides customer premise
equipment. Like 6to4, it utilizes stateless IPv6 in IPv4 encapsulation
in order to transit IPv4-only network infrastructure. Unlike 6to4, a
6rd service provider uses an IPv6 prefix of its own in place of the
fixed 6to4 prefix.

Signed-off-by: Alexandre Cassen <acassen@freebox.fr>
---
 include/linux/if_tunnel.h |   10 +++++
 include/net/ipip.h        |    2 +
 net/ipv6/Kconfig          |   13 +++++++
 net/ipv6/sit.c            |   84 +++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 109 insertions(+), 0 deletions(-)

diff --git a/include/linux/if_tunnel.h b/include/linux/if_tunnel.h
index 5eb9b0f..0d44376 100644
--- a/include/linux/if_tunnel.h
+++ b/include/linux/if_tunnel.h
@@ -15,6 +15,10 @@
 #define SIOCADDPRL      (SIOCDEVPRIVATE + 5)
 #define SIOCDELPRL      (SIOCDEVPRIVATE + 6)
 #define SIOCCHGPRL      (SIOCDEVPRIVATE + 7)
+#define SIOCGET6RD      (SIOCDEVPRIVATE + 8)
+#define SIOCADD6RD      (SIOCDEVPRIVATE + 9)
+#define SIOCDEL6RD      (SIOCDEVPRIVATE + 10)
+#define SIOCCHG6RD      (SIOCDEVPRIVATE + 11)
 
 #define GRE_CSUM	__cpu_to_be16(0x8000)
 #define GRE_ROUTING	__cpu_to_be16(0x4000)
@@ -51,6 +55,12 @@ struct ip_tunnel_prl {
 /* PRL flags */
 #define	PRL_DEFAULT		0x0001
 
+/* 6RD parms */
+struct ip_tunnel_6rd {
+	struct in6_addr		addr;
+	__u8			prefixlen;
+};
+
 enum
 {
 	IFLA_GRE_UNSPEC,
diff --git a/include/net/ipip.h b/include/net/ipip.h
index 5d3036f..fa92c41 100644
--- a/include/net/ipip.h
+++ b/include/net/ipip.h
@@ -26,6 +26,8 @@ struct ip_tunnel
 
 	struct ip_tunnel_prl_entry	*prl;		/* potential router list */
 	unsigned int			prl_count;	/* # of entries in PRL */
+
+	struct ip_tunnel_6rd	ip6rd_prefix;	/* 6RD SP prefix */
 };
 
 /* ISATAP: default interval between RS in secondy */
diff --git a/net/ipv6/Kconfig b/net/ipv6/Kconfig
index ead6c7a..8b779f7 100644
--- a/net/ipv6/Kconfig
+++ b/net/ipv6/Kconfig
@@ -170,6 +170,19 @@ config IPV6_SIT
 
 	  Saying M here will produce a module called sit. If unsure, say Y.
 
+config IPV6_SIT_6RD
+	bool "IPv6: 6rd tunnel mode (EXPERIMENTAL)"
+	depends on IPV6_SIT && EXPERIMENTAL
+	default n
+	---help---
+	IPv6 rapid deployment (draft-despres-6rd-03) builds upon mechanisms
+	of 6to4 (RFC3056) to enable a service provider to rapidly deploy IPv6
+	unicast service to IPv4 sites to which it provides customer premise
+	equipment. Like 6to4, it utilizes stateless IPv6 in IPv4 encapsulation
+	in order to transit IPv4-only network infrastructure. Unlike 6to4, a
+	6rd service provider uses an IPv6 prefix of its own in place of the
+	fixed 6to4 prefix.
+
 config IPV6_NDISC_NODETYPE
 	bool
 
diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c
index 0ae4f64..3587149 100644
--- a/net/ipv6/sit.c
+++ b/net/ipv6/sit.c
@@ -604,6 +604,30 @@ static inline __be32 try_6to4(struct in6_addr *v6dst)
 	return dst;
 }
 
+#ifdef CONFIG_IPV6_SIT_6RD
+/* Returns the embedded IPv4 address if the IPv6 address comes from
+   6rd rule */
+
+static inline __be32 try_6rd(struct in6_addr *addr, u8 prefix_len, struct in6_addr *v6dst)
+{
+	__be32 dst = 0;
+
+	/* isolate addr according to mask */
+	if (ipv6_prefix_equal(v6dst, addr, prefix_len)) {
+		unsigned int d32_off, bits;
+
+		d32_off = prefix_len >> 5;
+		bits = (prefix_len & 0x1f);
+
+		dst = (ntohl(v6dst->s6_addr32[d32_off]) << bits);
+		if (bits)
+			dst |= ntohl(v6dst->s6_addr32[d32_off + 1]) >> (32 - bits);
+		dst = htonl(dst);
+	}
+	return dst;
+}
+#endif
+
 /*
  *	This function assumes it is being called from dev_queue_xmit()
  *	and that skb is filled properly by that function.
@@ -657,6 +681,13 @@ static netdev_tx_t ipip6_tunnel_xmit(struct sk_buff *skb,
 			goto tx_error;
 	}
 
+#ifdef CONFIG_IPV6_SIT_6RD
+	if (!dst && tunnel->ip6rd_prefix.prefixlen)
+		dst = try_6rd(&tunnel->ip6rd_prefix.addr,
+			      tunnel->ip6rd_prefix.prefixlen,
+			      &iph6->daddr);
+	else
+#endif
 	if (!dst)
 		dst = try_6to4(&iph6->daddr);
 
@@ -848,6 +879,9 @@ ipip6_tunnel_ioctl (struct net_device *dev, struct ifreq *ifr, int cmd)
 	int err = 0;
 	struct ip_tunnel_parm p;
 	struct ip_tunnel_prl prl;
+#ifdef CONFIG_IPV6_SIT_6RD
+	struct ip_tunnel_6rd ip6rd;
+#endif
 	struct ip_tunnel *t;
 	struct net *net = dev_net(dev);
 	struct sit_net *sitn = net_generic(net, sit_net_id);
@@ -987,6 +1021,56 @@ ipip6_tunnel_ioctl (struct net_device *dev, struct ifreq *ifr, int cmd)
 		netdev_state_change(dev);
 		break;
 
+#ifdef CONFIG_IPV6_SIT_6RD
+	case SIOCGET6RD:
+		err = -EINVAL;
+		if (dev == sitn->fb_tunnel_dev)
+			goto done;
+		err = -ENOENT;
+		if (!(t = netdev_priv(dev)))
+			goto done;
+		memcpy(&ip6rd, &t->ip6rd_prefix, sizeof(ip6rd));
+		if (copy_to_user(ifr->ifr_ifru.ifru_data, &ip6rd, sizeof(ip6rd)))
+			err = -EFAULT;
+		else
+			err = 0;
+		break;
+
+	case SIOCADD6RD:
+	case SIOCDEL6RD:
+	case SIOCCHG6RD:
+		err = -EPERM;
+		if (!capable(CAP_NET_ADMIN))
+			goto done;
+		err = -EINVAL;
+		if (dev == sitn->fb_tunnel_dev)
+			goto done;
+		err = -EFAULT;
+		if (copy_from_user(&ip6rd, ifr->ifr_ifru.ifru_data, sizeof(ip6rd)))
+			goto done;
+		err = -ENOENT;
+		if (!(t = netdev_priv(dev)))
+			goto done;
+
+		err = 0;
+		switch (cmd) {
+		case SIOCDEL6RD:
+			memset(&t->ip6rd_prefix, 0, sizeof(ip6rd));
+			break;
+		case SIOCADD6RD:
+		case SIOCCHG6RD:
+			if (ip6rd.prefixlen >= 95) {
+				err = -EINVAL;
+				goto done;
+			}
+			ipv6_addr_copy(&t->ip6rd_prefix.addr, &ip6rd.addr);
+			t->ip6rd_prefix.prefixlen = ip6rd.prefixlen;
+			break;
+		}
+		netdev_state_change(dev);
+		break;
+#endif
+
 	default:
 		err = -EINVAL;
 	}
-- 
1.6.0.4


^ permalink raw reply related

* Re: [PATCH V2 0/3] at91_can: add support for Atmel's CAN controller on AT91SAM9263
From: Marc Kleine-Budde @ 2009-09-22 22:07 UTC (permalink / raw)
  To: Andrew Victor
  Cc: Socketcan-core-0fE9KPoRgkgATYTw5x5z8w,
	netdev-u79uwXL29TY76Z2rM5mHXA, Andrew Victor, Wolfgang Grandegger,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
In-Reply-To: <cd73a99e0909211431k37429a70o4efaac7104f7d526-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hey Andrew,

Andrew Victor wrote:
>>>> Marc Kleine-Budde (3):
>>>>       at91sam9263: add at91_can device to generic device definition
>>>>       at91sam9263ek: activate at91 CAN controller
>>>>       at91_can: add driver for Atmel's CAN controller on AT91SAM9263
>>> I have just added my "signed-off-by" for the Socket-CAN patch #3. Don't
>>> known who will take care of the other patches.
>> Thanks Wolfgang.
>>
>> Andrew, are the first two going throught the arm tree?
> 
> That would be best.
> Please submit them to Russell King's patch system.

done as:

5722	at91sam9263: add at91_can device to generic device definition
5723	at91sam9263ek: activate at91 CAN controller

Cheers, Marc

- --
Pengutronix e.K.                         | Marc Kleine-Budde           |
Linux Solutions for Science and Industry | Phone: +49-231-2826-924     |
Vertretung West/Dortmund                 | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686         | http://www.pengutronix.de   |
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkq5Sr4ACgkQjTAFq1RaXHNrLgCfeVy7xmi1UzdxGeWK3z4XRqMC
rjYAn2EK0LKhOe/S890W2bq6ElzPDNQL
=phat
-----END PGP SIGNATURE-----

^ permalink raw reply

* Re: [PATCH 1/3] at91sam9263: add at91_can device to generic device definition
From: David Miller @ 2009-09-22 22:08 UTC (permalink / raw)
  To: wg; +Cc: mkl, netdev, Socketcan-core, linux, linux-arm-kernel
In-Reply-To: <4AB2362E.3070509@grandegger.com>

From: Wolfgang Grandegger <wg@grandegger.com>
Date: Thu, 17 Sep 2009 15:14:22 +0200

> Marc Kleine-Budde wrote:
>> This patch adds the device definition for the at91_can device to
>> the generic device definiton file for the at91sam9263.
>> 
>> Signed-off-by: Hans J. Koch <hjk@linutronix.de>
>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
 ...
> Acked-by: Wolfgang Grandegger <wg@grandegger.com>

Applied.

^ permalink raw reply

* Re: [PATCH 2/3] at91sam9263ek: activate at91 CAN controller
From: David Miller @ 2009-09-22 22:09 UTC (permalink / raw)
  To: wg; +Cc: mkl, netdev, Socketcan-core, linux, linux-arm-kernel
In-Reply-To: <4AB2364F.60700@grandegger.com>

From: Wolfgang Grandegger <wg@grandegger.com>
Date: Thu, 17 Sep 2009 15:14:55 +0200

> Marc Kleine-Budde wrote:
>> This patch activates the at91 CAN controller for the at91sam9263ek
>> development board.
>> 
>> Signed-off-by: Hans J. Koch <hjk@linutronix.de>
>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
 ...
> Acked-by: Wolfgang Grandegger <wg@grandegger.com>

Applied.

^ permalink raw reply

* Re: [PATCH 3/3] at91_can: add driver for Atmel's CAN controller on AT91SAM9263
From: David Miller @ 2009-09-22 22:09 UTC (permalink / raw)
  To: wg; +Cc: mkl, netdev, Socketcan-core, linux, linux-arm-kernel
In-Reply-To: <4AB205E9.3090902@grandegger.com>

From: Wolfgang Grandegger <wg@grandegger.com>
Date: Thu, 17 Sep 2009 11:48:25 +0200

> Marc Kleine-Budde wrote:
>> This patch add the driver for the SoC CAN controller in Atmel's AT91SAM9263.
>> 
>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> 
> Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
> 
> Thanks for your contribution.

Applied.

^ permalink raw reply

* Re: [PATCH] cnic: Shutdown iSCSI ring during uio_close.
From: David Miller @ 2009-09-22 22:09 UTC (permalink / raw)
  To: mchan; +Cc: netdev, michaelc, benli
In-Reply-To: <1253583577-8027-1-git-send-email-mchan@broadcom.com>

From: "Michael Chan" <mchan@broadcom.com>
Date: Mon, 21 Sep 2009 18:39:37 -0700

> The iSCSI ring should be shutdown during uio_close instead of uio_open
> for proper operations.  This fixes the problem of the ring getting
> stuck intermittently.
> 
> Signed-off-by: Michael Chan <mchan@broadcom.com>
> Signed-off-by: Benjamin Li <benli@broadcom.com>

Applied.

^ permalink raw reply

* Re: [PATCH] fec: Add FEC support for MX25 processor
From: David Miller @ 2009-09-22 22:09 UTC (permalink / raw)
  To: fabioestevam; +Cc: netdev, s.hauer
In-Reply-To: <123584.91508.qm@web51002.mail.re2.yahoo.com>

From: Fabio Estevam <fabioestevam@yahoo.com>
Date: Mon, 21 Sep 2009 17:41:21 -0700 (PDT)

> Add FEC support for MX25 processor.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Applied.

^ permalink raw reply


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox