* Re: [PATCH kernel 2.6.32-rc1] pcnet_cs: add cis of National Semicondoctor's multifunction pcmcia card
From: David Miller @ 2009-10-05 7:40 UTC (permalink / raw)
To: ken_kawasaki; +Cc: netdev
In-Reply-To: <20091004073257.52a6624b.ken_kawasaki@spring.nifty.jp>
From: Ken Kawasaki <ken_kawasaki@spring.nifty.jp>
Date: Sun, 4 Oct 2009 07:32:57 +0900
>
> pcnet_cs,serial_cs:
>
> add cis of National Semicondoctor's lan&modem mulitifunction pcmcia card,
> NE2K, tamarack ethernet card,
> and some serial card(COMpad2, COMpad4).
>
>
> Signed-off-by: Ken Kawasaki <ken_kawasaki@spring.nifty.jp>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH] inet_peer: Optimize inet_getid()
From: Eric Dumazet @ 2009-10-05 7:38 UTC (permalink / raw)
To: David Miller; +Cc: shemminger, netdev
In-Reply-To: <20091005.000818.95127796.davem@davemloft.net>
David Miller a écrit :
>
> I can't apply this, it's going to break the build on some
> architectures.
>
> For example, sparc64 only supports cmpxchg on u32 and u64
> objects, but you're trying to use it on a u16 here.
Oops, thanks for the info David !
^ permalink raw reply
* Re: [PATCH] TCPCT+1: initial SYN exchange with SYNACK data
From: David Miller @ 2009-10-05 7:27 UTC (permalink / raw)
To: william.allen.simpson; +Cc: netdev
In-Reply-To: <4AC79905.1030904@gmail.com>
From: William Allen Simpson <william.allen.simpson@gmail.com>
Date: Sat, 03 Oct 2009 14:33:41 -0400
> @@ -406,6 +454,32 @@ struct tcp_sock {
...
> + struct tcp_s_data_payload *s_data_payload;
...
> + struct tcp_cookie_pair *cookie_pair;
...
> + u16 s_data_desired; /* bytes */
...
> + u8 cookie_desired; /* bytes */
> + u8 s_data_in:1,
> + s_data_out:1,
> + cookie_in_always:1,
> + cookie_out_never:1;
struct tcp_sock is already WAY TOO BIG on 64-bit systems, adding 20
more bytes to it for some odd-ball feature is not something I'm
willing to do, sorry.
^ permalink raw reply
* Re: [PATCH] net: Support inclusion of <linux/socket.h> before <sys/socket.h>
From: David Miller @ 2009-10-05 7:24 UTC (permalink / raw)
To: ben; +Cc: netdev, waldi, manuel, 538372
In-Reply-To: <1254627764.2395.48.camel@localhost>
From: Ben Hutchings <ben@decadent.org.uk>
Date: Sun, 04 Oct 2009 04:42:44 +0100
> From: Bastian Blank <waldi@debian.org>
>
> The following user-space program fails to compile:
>
> #include <linux/socket.h>
> #include <sys/socket.h>
> int main() { return 0; }
>
> The reason is that <linux/socket.h> tests __GLIBC__ to decide whether it
> should define various structures and macros that are now defined for
> user-space by <sys/socket.h>, but __GLIBC__ is not defined if no libc
> headers have yet been included.
>
> It seems safe to drop support for libc 5 now.
>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Fair enough, applied to net-2.6, thanks.
^ permalink raw reply
* Re: [PATCH 21/21] drivers/net/tlan.h: Convert printk(KERN_DEBUG to pr_dbg(
From: David Miller @ 2009-10-05 7:20 UTC (permalink / raw)
To: joe; +Cc: linux-kernel, chessman, netdev
In-Reply-To: <1254726974.1799.315.camel@Joe-Laptop.home>
From: Joe Perches <joe@perches.com>
Date: Mon, 05 Oct 2009 00:16:14 -0700
> On Mon, 2009-10-05 at 00:12 -0700, David Miller wrote:
>> From: Joe Perches <joe@perches.com>
>> Date: Sun, 4 Oct 2009 17:53:48 -0700
>> > Removed "TLAN: " prefix from debug printks, it's added by pr_fmt
>> > Signed-off-by: Joe Perches <joe@perches.com>
>> Applied to net-next-2.6
>
> Patches 20 and 21 depend on patch 1, which introduces pr_dbg
> to kernel.h. Compile failure otherwise.
Ok, I'll toss them then.
Someone else merge this stuff:
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply
* Re: [PATCH 21/21] drivers/net/tlan.h: Convert printk(KERN_DEBUG to pr_dbg(
From: Joe Perches @ 2009-10-05 7:16 UTC (permalink / raw)
To: David Miller; +Cc: linux-kernel, chessman, netdev
In-Reply-To: <20091005.001240.111554671.davem@davemloft.net>
On Mon, 2009-10-05 at 00:12 -0700, David Miller wrote:
> From: Joe Perches <joe@perches.com>
> Date: Sun, 4 Oct 2009 17:53:48 -0700
> > Removed "TLAN: " prefix from debug printks, it's added by pr_fmt
> > Signed-off-by: Joe Perches <joe@perches.com>
> Applied to net-next-2.6
Patches 20 and 21 depend on patch 1, which introduces pr_dbg
to kernel.h. Compile failure otherwise.
^ permalink raw reply
* Re: [PATCH] TI DaVinci EMAC: Minor macro related updates
From: David Miller @ 2009-10-05 7:14 UTC (permalink / raw)
To: chaithrika; +Cc: netdev, davinci-linux-open-source
In-Reply-To: <1254428719-13960-1-git-send-email-chaithrika@ti.com>
From: Chaithrika U S <chaithrika@ti.com>
Date: Thu, 1 Oct 2009 16:25:19 -0400
> Use BIT for macro definitions wherever possible, remove
> unused and redundant macros.
>
> Signed-off-by: Chaithrika U S <chaithrika@ti.com>
Applied to net-next-2.6
^ permalink raw reply
* Re: [PATCH 4/4] ethtool: Remove support for obsolete string query operations
From: David Miller @ 2009-10-05 7:13 UTC (permalink / raw)
To: bhutchings; +Cc: netdev
In-Reply-To: <1254432783.2735.29.camel@achroite>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Thu, 01 Oct 2009 22:33:03 +0100
> The in-tree implementations have all been converted to
> get_sset_count().
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Applied to net-next-2.6
^ permalink raw reply
* Re: [PATCH 2/4] tehuti: Convert ethtool get_stats_count() ops to get_sset_count()
From: David Miller @ 2009-10-05 7:13 UTC (permalink / raw)
To: bhutchings; +Cc: andy, baum, netdev
In-Reply-To: <1254432479.2735.24.camel@achroite>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Thu, 01 Oct 2009 22:27:59 +0100
> This string query operation was supposed to be replaced by the
> generic get_sset_count() starting in 2007. Convert tehuti's
> implementation.
>
> Also remove the dummy self-test name which was not used since tehuti
> does not advertise any self-tests.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Applied to net-next-2.6
^ permalink raw reply
* Re: [PATCH 1/4] qeth: Convert ethtool get_stats_count() ops to get_sset_count()
From: David Miller @ 2009-10-05 7:13 UTC (permalink / raw)
To: bhutchings; +Cc: ursula.braun, frank.blaschka, linux-s390, netdev
In-Reply-To: <1254432272.2735.20.camel@achroite>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Thu, 01 Oct 2009 22:24:32 +0100
> This string query operation was supposed to be replaced by the
> generic get_sset_count() starting in 2007. Convert qeth's
> implementation.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Applied to net-next-2.6
^ permalink raw reply
* Re: [PATCH 3/4] net: Convert ethtool {get_stats,self_test}_count() ops to get_sset_count()
From: David Miller @ 2009-10-05 7:12 UTC (permalink / raw)
To: eilong
Cc: bhutchings, chien.tin.tung, faisal.latif, subbus, sathyap, benh,
jwboyer, alexander.h.duyck, netdev
In-Reply-To: <1254668841.2642.3.camel@lb-tlvb-eilong>
From: "Eilon Greenstein" <eilong@broadcom.com>
Date: Sun, 4 Oct 2009 17:07:21 +0200
> On Thu, 2009-10-01 at 14:32 -0700, Ben Hutchings wrote:
>> These string query operations were supposed to be replaced by the
>> generic get_sset_count() starting in 2007. Convert the remaining
>> implementations.
>>
>> Also remove calls to these operations to initialise drvinfo->n_stats.
>> The ethtool core code already does that.
>>
>> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
>> ---
>> drivers/infiniband/hw/nes/nes_nic.c | 12 ++++---
>> drivers/net/benet/be_ethtool.c | 11 +++++--
>> drivers/net/bnx2x_main.c | 60 ++++++++++++++++++-----------------
>> drivers/net/ibm_newemac/core.c | 10 +++--
>> drivers/net/igbvf/ethtool.c | 25 +++++++-------
>> drivers/net/niu.c | 7 +++-
>> 6 files changed, 70 insertions(+), 55 deletions(-)
>>
> Thanks Ben, bnx2x tested and works just fine with this patch.
> Acked-by: Eilon Greenstein <eilong@broadcom.com>
Applied to net-next-2.6
^ permalink raw reply
* Re: [PATCH 21/21] drivers/net/tlan.h: Convert printk(KERN_DEBUG to pr_dbg(
From: David Miller @ 2009-10-05 7:12 UTC (permalink / raw)
To: joe; +Cc: linux-kernel, chessman, netdev
In-Reply-To: <29c66ee0bae26a0c352b4605e3f1fcbe0612f3a5.1254701151.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Sun, 4 Oct 2009 17:53:48 -0700
> Removed "TLAN: " prefix from debug printks, it's added by pr_fmt
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied to net-next-2.6
^ permalink raw reply
* Re: [PATCH 20/21] drivers/net/tlan: use pr_<level> and add pr_fmt(fmt)
From: David Miller @ 2009-10-05 7:12 UTC (permalink / raw)
To: joe; +Cc: linux-kernel, chessman, netdev
In-Reply-To: <d4468c1b062875f4b88ba94f4631232ecff9c27b.1254701151.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Sun, 4 Oct 2009 17:53:47 -0700
> Added #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> Converted printk(KERN_<level> to pr_<level>(
> Removed "TLAN: " prefixes
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied to net-next-2.6
^ permalink raw reply
* Re: [PATCH 19/21] drivers/net/bonding/: : use pr_fmt
From: David Miller @ 2009-10-05 7:12 UTC (permalink / raw)
To: joe; +Cc: linux-kernel, fubar, bonding-devel, netdev
In-Reply-To: <ec7e258261ac67ba496f96d04c270cf89fc24deb.1254701151.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Sun, 4 Oct 2009 17:53:46 -0700
> Add #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> Remove DRV_NAME from pr_<level>s
> Consolidate long format strings
> Remove some extra tab indents
> Remove some unnecessary ()s from pr_<level>s arguments
> Align pr_<level> arguments
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied to net-next-2.6
^ permalink raw reply
* Re: [PATCH] icmp: No need to call sk_write_space()
From: David Miller @ 2009-10-05 7:12 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
In-Reply-To: <4ABBEFD3.6060407@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 25 Sep 2009 00:16:51 +0200
> We can make icmp messages tx completion callback a litle bit faster.
>
> Setting SOCK_USE_WRITE_QUEUE sk flag tells sock_wfree() to
> not call sk_write_space() on a socket we know no thread is posssibly
> waiting for write space. (on per cpu kernel internal icmp sockets only)
>
> This avoids the sock_def_write_space() call and
> read_lock(&sk->sk_callback_lock)/read_unlock(&sk->sk_callback_lock) calls
> as well.
>
> We avoid three atomic ops.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied to net-next-2.6
^ permalink raw reply
* Re: [PATCH] tunnels: Optimize tx path
From: David Miller @ 2009-10-05 7:12 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
In-Reply-To: <4ABB233E.5050503@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 24 Sep 2009 09:43:58 +0200
> We currently dirty a cache line to update tunnel device stats
> (tx_packets/tx_bytes). We better use the txq->tx_bytes/tx_packets
> counters that already are present in cpu cache, in the cache
> line shared with txq->_xmit_lock
>
> This patch extends IPTUNNEL_XMIT() macro to use txq pointer
> provided by the caller.
>
> Also &tunnel->dev->stats can be replaced by &dev->stats
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied to net-next-2.6
^ permalink raw reply
* Re: [PATCH] ipv4: fib table algorithm performance improvement
From: David Miller @ 2009-10-05 7:11 UTC (permalink / raw)
To: shemminger; +Cc: netdev
In-Reply-To: <20090920133536.1511a2ad@s6510>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Sun, 20 Sep 2009 13:35:36 -0700
> The FIB algorithim for IPV4 is set at compile time, but kernel goes through
> the overhead of function call indirection at runtime. Save some
> cycles by turning the indirect calls to direct calls to either
> hash or trie code.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied to net-next-2.6
^ permalink raw reply
* Re: [PATCH] inet_peer: Optimize inet_getid()
From: David Miller @ 2009-10-05 7:08 UTC (permalink / raw)
To: eric.dumazet; +Cc: shemminger, netdev
In-Reply-To: <4ABBDA45.2040109@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 24 Sep 2009 22:44:53 +0200
> [PATCH] inet_peer: Optimize inet_getid()
>
> While investigating for network latencies, I found inet_getid() was a contention point
> for some workloads.
>
> If __HAVE_ARCH_CMPXCHG is defined, we can use cmpxchg() instead of
> a spin_lock_bh()/spin_unlock_bh() pair on a central lock.
>
> On other arches, we can use an atomic_t instead of a u16,
> and atomic_add_return(). This might grow memory usage a bit, unless
> someone invents atomic16_t :)
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
I can't apply this, it's going to break the build on some
architectures.
For example, sparc64 only supports cmpxchg on u32 and u64
objects, but you're trying to use it on a u16 here.
^ permalink raw reply
* Re: [PATCH] pktgen: restore nanosec delays
From: David Miller @ 2009-10-05 4:09 UTC (permalink / raw)
To: eric.dumazet; +Cc: shemminger, netdev
In-Reply-To: <4AC737E6.1050809@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sat, 03 Oct 2009 13:39:18 +0200
> Commit fd29cf72 (pktgen: convert to use ktime_t)
> inadvertantly converted "delay" parameter from nanosec to microsec.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
^ permalink raw reply
* Re: [BUG net-2.6] bluetooth/rfcomm : sleeping function called from invalid context at mm/slub.c:1719
From: Dave Young @ 2009-10-05 4:08 UTC (permalink / raw)
To: Gustavo F. Padovan
Cc: Oliver Hartkopp, Marcel Holtmann, Linux Netdev List,
linux-bluetooth, Gustavo F. Padovan
In-Reply-To: <20091004180635.GA11272@vigoh>
On Mon, Oct 5, 2009 at 2:06 AM, Gustavo F. Padovan <gustavo@padovan.org> wrote:
>
> Hi all,
>
> * Dave Young <hidave.darkstar@gmail.com> [2009-10-04 11:26:17 +0800]:
>
>>
>> I can reproduce the bug.
>>
>> It's probably caused by the l2cap changes by Gustavo F. Padovan
>> <gustavo@las.ic.unicamp.br>, I didn't see such problem after reverting
>> Gustavo's patch series.
>
> I can't reproduce the bug. I'm trying to reproduce it to figure out what of
> my changes cause it.
>
> I' running
>
> $ dund -snu -i 00:11:67:CD:0F:CB # to pretend to be dialup/telephone
>
> and on the other side
>
> $ rfcomm bind 0 00:11:67:CD:0F:CB 1
> $ wvdial # wvdial to /dev/rfcomm0
>
> Both sides are on the same machine. Do you see any real difference
> between my try and the call that get the bug?
Just try connecting to a mobile phone with bluetooth on, then set rfcomm.conf
I did:
rfcomm connect 0;
after connection ok, press ctrl+C to hangup
>
>
> --
> Gustavo F. Padovan
>
--
Regards
dave
^ permalink raw reply
* Re: [PATCH] pktgen: Fix multiqueue handling
From: David Miller @ 2009-10-05 4:09 UTC (permalink / raw)
To: robert; +Cc: eric.dumazet, robert.olsson, netdev, shemminger
In-Reply-To: <19143.42215.379289.481809@gargle.gargle.HOWL>
From: Robert Olsson <robert@herjulf.net>
Date: Sat, 3 Oct 2009 21:24:23 +0200
>
>
> Thanks yes is seems right. We can chose a single arbitrary TX queue with the patch.
> BTW Noticed you and Stephen discussed to reduce dirtying skb->users, maybe the idea
> to bump up skb->users to clone_skb is not so bad. I'll think the code will be pretty
> straight-forward.
>
> Cheers
> --ro
>
>
> Signed-off-by: Robert Olsson <robert.olsson@its.uu.se>
Applied, thanks everyone.
^ permalink raw reply
* Re: [net-2.6 PATCH] e1000e: swap max hw supported frame size between 82574 and 82583
From: David Miller @ 2009-10-05 4:09 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, rjw, alexander.h.duyck
In-Reply-To: <20091002223042.4191.43767.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Fri, 02 Oct 2009 15:30:42 -0700
> From: Alexander Duyck <alexander.h.duyck@intel.com>
>
> There appears to have been a mixup in the max supported jumbo frame size
> between 82574 and 82583 which ended up disabling jumbo frames on the 82574
> as a result. This patch swaps the two so that this issue is resolved.
>
> This patch fixes http://bugzilla.kernel.org/show_bug.cgi?id=14261
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-2.6 PATCH 2/2] ixgbe: add support for 82599 based X520 10G Dual KX4 Mezz card
From: David Miller @ 2009-10-05 4:09 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, donald.c.skidmore, peter.p.waskiewicz.jr
In-Reply-To: <20091002185825.8771.50867.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Fri, 02 Oct 2009 11:58:25 -0700
> From: Don Skidmore <donald.c.skidmore@intel.com>
>
> This patch adds device support for the 82599 based X520 10GbE
> Dual Port KX4 Mezzanine card.
>
> Signed-off-by: Don Skidmore<donald.c.skidmore@intel.com>
> Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-2.6 PATCH 1/2] ixgbe: add support for 82599 Combined Backplane
From: David Miller @ 2009-10-05 4:08 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, donald.c.skidmore, peter.p.waskiewicz.jr
In-Reply-To: <20091002185803.8771.46655.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Fri, 02 Oct 2009 11:58:04 -0700
> This patch will add support for the 82599 Dual port Backplane
> device (0x10f8). This device has the ability to link in serial (KR) and
> parallel (KX4/KX) modes, depending on what the switch capabilities are in
> the blade chassis.
>
> Signed-off-by: Don Skidmore <donald.c.skidmore@intel.com>
> Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* [PATCH 21/21] drivers/net/tlan.h: Convert printk(KERN_DEBUG to pr_dbg(
From: Joe Perches @ 2009-10-05 0:53 UTC (permalink / raw)
To: linux-kernel; +Cc: Samuel Chessman, netdev
In-Reply-To: <cover.1254701151.git.joe@perches.com>
Removed "TLAN: " prefix from debug printks, it's added by pr_fmt
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/net/tlan.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/tlan.h b/drivers/net/tlan.h
index 4b82f28..c5a4ad5 100644
--- a/drivers/net/tlan.h
+++ b/drivers/net/tlan.h
@@ -44,7 +44,7 @@
#define TLAN_RECORD 1
#define TLAN_DBG(lvl, format, args...) \
- do { if (debug&lvl) printk(KERN_DEBUG "TLAN: " format, ##args ); } while(0)
+ do { if (debug & lvl) pr_dbg(format, ##args); } while (0)
#define TLAN_DEBUG_GNRL 0x0001
#define TLAN_DEBUG_TX 0x0002
--
1.6.3.1.10.g659a0.dirty
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox