* Re: [net-next-2.6 PATCH 01/15] igb: remove unused temp variable from stats clearing path
From: David Miller @ 2009-10-06 22:20 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, alexander.h.duyck
In-Reply-To: <20091005163058.32487.10125.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon, 05 Oct 2009 09:31:25 -0700
> From: Alexander Duyck <alexander.h.duyck@intel.com>
>
> There is a temp variable in the stats clearing path that isn't needed since
> the results from the stats read can be immediately discared. Since it
> isn't needed we might as well just drop it from the function call.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 02/15] igb: update comments for serdes config and update to handle duplex
From: David Miller @ 2009-10-06 22:20 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, alexander.h.duyck
In-Reply-To: <20091005163146.32487.7079.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon, 05 Oct 2009 09:31:47 -0700
> From: Alexander Duyck <alexander.h.duyck@intel.com>
>
> This update corrects the driver so that it handles duplex for serdes links
> correctly instead of just forcing full duplex always.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 03/15] igb: update the approach taken to acquiring and releasing the phy lock
From: David Miller @ 2009-10-06 22:20 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, alexander.h.duyck
In-Reply-To: <20091005163206.32487.22702.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon, 05 Oct 2009 09:32:07 -0700
> From: Alexander Duyck <alexander.h.duyck@intel.com>
>
> The current approach is just using a ?: type mechanism to set the phy
> locking bit. This if fine for now but limits us to only 2. Switch to a
> nested if statement for future compatiblity with more than 2 phys.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 04/15] igb: add locking to reads of the i2c interface
From: David Miller @ 2009-10-06 22:20 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, alexander.h.duyck
In-Reply-To: <20091005163226.32487.91764.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon, 05 Oct 2009 09:32:27 -0700
> From: Alexander Duyck <alexander.h.duyck@intel.com>
>
> The current implementation of sgmii support isn't correctly locking the
> interfaces for reads/writes. This change pulls the read/write
> functionality out of 82575.c and moves it to phy.c. In addition it
> replaces the implementation in 82575.c with one that uses locking around
> the relocated i2c interface calls.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 05/15] igb: add combined function for setting rar and pool bits
From: David Miller @ 2009-10-06 22:21 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, alexander.h.duyck
In-Reply-To: <20091005163248.32487.51010.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon, 05 Oct 2009 09:32:49 -0700
> From: Alexander Duyck <alexander.h.duyck@intel.com>
>
> This patch adds igb_rar_qsel which sets the mac address and pool bits for a
> given mac address in the receive address register table.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 06/15] igb: make use of the uta to allow for promiscous mode filter
From: David Miller @ 2009-10-06 22:21 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, alexander.h.duyck
In-Reply-To: <20091005163307.32487.75656.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon, 05 Oct 2009 09:33:08 -0700
> From: Alexander Duyck <alexander.h.duyck@intel.com>
>
> In order to support functions such as vlan tag stripping when SR-IOV is
> enabled any given packet must match at least one filter. However in the
> case of promiscous mode being enabled on the PF the traffic routed to it
> may not match any filters and is just sent to the PF by default. In order
> to make certain that this traffic is processed we can set all bits in the
> UTA registers to create a pseudo promiscous mode filter that accepts all
> packets.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 07/15] igb: add support for 82576NS SerDes adapter
From: David Miller @ 2009-10-06 22:21 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, alexander.h.duyck
In-Reply-To: <20091005163326.32487.27297.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon, 05 Oct 2009 09:33:27 -0700
> From: Alexander Duyck <alexander.h.duyck@intel.com>
>
> This patch adds the device ID necessary to support the 82576NS SerDes
> adapter.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 08/15] igb: add function to handle mailbox lock
From: David Miller @ 2009-10-06 22:21 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, alexander.h.duyck
In-Reply-To: <20091005163345.32487.58098.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon, 05 Oct 2009 09:33:46 -0700
> From: Alexander Duyck <alexander.h.duyck@intel.com>
>
> Both the read and write mailbox functions need to acquire the mailbox lock.
> Since that is the case we might as well combine both of the procedures into
> one function so it is easier to maintain.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 09/15] igb: fix a few items where weren't correctly setup for mbx timeout
From: David Miller @ 2009-10-06 22:21 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, alexander.h.duyck
In-Reply-To: <20091005163404.32487.88572.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon, 05 Oct 2009 09:34:05 -0700
> From: Alexander Duyck <alexander.h.duyck@intel.com>
>
> The mailbox timeout routines need to be updated as they were not correctly
> handling the case of a mailbox timeout and could cause issues with long
> delays when used.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 10/15] igb: change how we handle alternate mac addresses
From: David Miller @ 2009-10-06 22:21 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, alexander.h.duyck
In-Reply-To: <20091005163424.32487.97223.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon, 05 Oct 2009 09:34:25 -0700
> From: Alexander Duyck <alexander.h.duyck@intel.com>
>
> This patch allows us to treat the alternate mac address as though it is the
> physical address on the adapter. This is accomplished by letting the
> alt_mac_address function to only fail on an NVM error. If no errors occur
> and the alternate mac address is not present then RAR0 is read as the
> default mac address.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 11/15] igb: remove microwire support from igb
From: David Miller @ 2009-10-06 22:21 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, alexander.h.duyck
In-Reply-To: <20091005163443.32487.94787.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon, 05 Oct 2009 09:34:44 -0700
> From: Alexander Duyck <alexander.h.duyck@intel.com>
>
> igb doesn't have any devices that use a microwire interface for NVM. As
> such the code related to this can be removed.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 12/15] igb: move the generic copper link setup code into e1000_phy.c
From: David Miller @ 2009-10-06 22:21 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, alexander.h.duyck
In-Reply-To: <20091005163502.32487.1493.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon, 05 Oct 2009 09:35:03 -0700
> From: Alexander Duyck <alexander.h.duyck@intel.com>
>
> This patch moves the generic portion of the copper link setup into a
> seperate function in e1000_phy.c. This helps to reduce the size of
> copper_link_setup_82575 and make it a bit more readable.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 13/15] igb: add code to retry a phy read in the event of failure on link check
From: David Miller @ 2009-10-06 22:21 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, alexander.h.duyck
In-Reply-To: <20091005163522.32487.5411.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon, 05 Oct 2009 09:35:23 -0700
> From: Alexander Duyck <alexander.h.duyck@intel.com>
>
> This patch adds a retry to phy reads in the event of failure. The original
> code broke out of the loop on failure and this is a mistake as we should be
> trying to do the read twice.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 14/15] igb: add additional error handling to the phy code
From: David Miller @ 2009-10-06 22:22 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, alexander.h.duyck
In-Reply-To: <20091005163541.32487.2008.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon, 05 Oct 2009 09:35:42 -0700
> From: Alexander Duyck <alexander.h.duyck@intel.com>
>
> This update adds additional exception handling to the phy code to handle
> situations where it may be called incorrectly. In addition it adds some
> bounds checking to the cable length checks to prevent an array overrun in
> the event that the hardware returned a different value than expected.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 15/15] igb: add flushes between RAR writes when setting mac address
From: David Miller @ 2009-10-06 22:22 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, alexander.h.duyck
In-Reply-To: <20091005163601.32487.87871.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon, 05 Oct 2009 09:36:01 -0700
> From: Alexander Duyck <alexander.h.duyck@intel.com>
>
> There are some switches that will do write combining when they see two
> sequential regions written. In order to avoid any possible write combining
> issues it is necessary to add a flush after writing each piece of a rar
> register.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 1/9] vxge: Modify __vxge_hw_device_is_privilaged() to not assume function-0 as the privileged function: Resubmit#1
From: David Miller @ 2009-10-06 22:22 UTC (permalink / raw)
To: Sreenivasa.Honnur; +Cc: netdev, support
In-Reply-To: <Pine.GSO.4.10.10910050749130.9377-100000@guinness>
So I'm going to apply this patch set to net-next-2.6, omitting patch
#8 from the series.
Thanks.
^ permalink raw reply
* Re: [Bugme-new] [Bug 14336] New: [Pardus] Soft Lockup Problem with Attansic Ethernet Card
From: Andrew Morton @ 2009-10-06 22:55 UTC (permalink / raw)
To: badibere
Cc: bugzilla-daemon, bugme-daemon, netdev, linux-acpi, Jesse Barnes,
Jay Cliburn, Chris Snook, Jie Yang
In-Reply-To: <bug-14336-10286@http.bugzilla.kernel.org/>
(switched to email. Please respond via emailed reply-to-all, not via the
bugzilla web interface).
On Tue, 6 Oct 2009 22:37:13 GMT
bugzilla-daemon@bugzilla.kernel.org wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=14336
>
> Summary: [Pardus] Soft Lockup Problem with Attansic Ethernet
> Card
> Product: Networking
> Version: 2.5
> Kernel Version: 2.6.30.8
> Platform: All
> OS/Version: Linux
> Tree: Mainline
> Status: NEW
> Severity: high
> Priority: P1
> Component: IPV4
> AssignedTo: shemminger@linux-foundation.org
> ReportedBy: badibere@gmail.com
> Regression: No
>
>
> I have soft lockup problem with attansic ethernet card while activating eth0
> interface.
>
> My ethernet card is 09:00.0 Ethernet controller: Attansic Technology Corp.
> Device 1063 (rev c0)
>
> If I try to activate eth0 interface while network cable is pluged in, then
> everything freezes.
>
> If I try to activate eth0 interface while network cable isn't pluged in, then
> no problem. But, if i plug in, again freezes.
>
> My /var/log/syslog is in attachment.
>
>From the dmesg output it appears that this card is driven by the atl1c
driver:
Oct 7 00:55:57 baDibere kernel: [ 169.943463] atl1c 0000:09:00.0: Unable to allocate MSI interrupt Error: -22
Oct 7 00:55:57 baDibere kernel: [ 169.943576] atl1c 0000:09:00.0: atl1c: eth0 NIC Link is Up<100 Mbps Full Duplex>
Oct 7 00:56:22 baDibere kernel: [ 194.849361] NVRM: Xid (0001:00): 16, Head 00000000 Count 00003651
Oct 7 00:56:31 baDibere kernel: [ 203.849307] NVRM: Xid (0001:00): 16, Head 00000000 Count 00003653
Oct 7 00:56:36 baDibere kernel: [ 208.849339] NVRM: Xid (0001:00): 8, Channel 00000003
Oct 7 00:56:41 baDibere kernel: [ 213.852320] NVRM: Xid (0001:00): 16, Head 00000000 Count 00003655
The "Unable to allocate MSI interrupt" might be the immediate problem.
Who belongs to MSI interrupt allocation? PCI? ACPI?
However the driver does attempt to handle and recover from the MSI
interrupt allocation error so perhaps that's no the cause at all.
^ permalink raw reply
* [RFC net-next-2.6] net: speedup sk_wake_async()
From: Eric Dumazet @ 2009-10-06 23:08 UTC (permalink / raw)
To: David S. Miller; +Cc: Linux Netdev List
Latency works, part 1
An incoming datagram must bring into cpu cache *lot* of cache lines,
in particular : (other parts omitted (hash chains, ip route cache...))
On 32bit arches :
offsetof(struct sock, sk_rcvbuf) =0x30 (read)
offsetof(struct sock, sk_lock) =0x34 (rw)
offsetof(struct sock, sk_sleep) =0x50 (read)
offsetof(struct sock, sk_rmem_alloc) =0x64 (rw)
offsetof(struct sock, sk_receive_queue)=0x74 (rw)
offsetof(struct sock, sk_forward_alloc)=0x98 (rw)
offsetof(struct sock, sk_callback_lock)=0xcc (rw)
offsetof(struct sock, sk_drops) =0xd8 (read if we add dropcount support, rw if frame dropped)
offsetof(struct sock, sk_filter) =0xf8 (read)
offsetof(struct sock, sk_socket) =0x138 (read)
offsetof(struct sock, sk_data_ready) =0x15c (read)
We can avoid sk->sk_socket and socket->fasync_list referencing on sockets
with no fasync() structures. (socket->fasync_list ptr is probably already in cache
because it shares a cache line with socket->wait, ie location pointed by sk->sk_sleep)
This avoids one cache line load per incoming packet for common cases (no fasync())
We can leave (or even move in a future patch) sk->sk_socket in a cold location
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
include/net/sock.h | 3 ++-
net/socket.c | 3 +++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/include/net/sock.h b/include/net/sock.h
index 1621935..98398bd 100644
--- a/include/net/sock.h
+++ b/include/net/sock.h
@@ -504,6 +504,7 @@ enum sock_flags {
SOCK_TIMESTAMPING_SOFTWARE, /* %SOF_TIMESTAMPING_SOFTWARE */
SOCK_TIMESTAMPING_RAW_HARDWARE, /* %SOF_TIMESTAMPING_RAW_HARDWARE */
SOCK_TIMESTAMPING_SYS_HARDWARE, /* %SOF_TIMESTAMPING_SYS_HARDWARE */
+ SOCK_FASYNC, /* fasync() active */
};
static inline void sock_copy_flags(struct sock *nsk, struct sock *osk)
@@ -1396,7 +1397,7 @@ static inline unsigned long sock_wspace(struct sock *sk)
static inline void sk_wake_async(struct sock *sk, int how, int band)
{
- if (sk->sk_socket && sk->sk_socket->fasync_list)
+ if (sock_flag(sk, SOCK_FASYNC))
sock_wake_async(sk->sk_socket, how, band);
}
diff --git a/net/socket.c b/net/socket.c
index 7565536..d53ad11 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -1100,11 +1100,14 @@ static int sock_fasync(int fd, struct file *filp, int on)
fna->fa_next = sock->fasync_list;
write_lock_bh(&sk->sk_callback_lock);
sock->fasync_list = fna;
+ sock_set_flag(sk, SOCK_FASYNC);
write_unlock_bh(&sk->sk_callback_lock);
} else {
if (fa != NULL) {
write_lock_bh(&sk->sk_callback_lock);
*prev = fa->fa_next;
+ if (!sock->fasync_list)
+ sock_reset_flag(sk, SOCK_FASYNC);
write_unlock_bh(&sk->sk_callback_lock);
kfree(fa);
}
^ permalink raw reply related
* alt1c: ethernet driver bug
From: Stephen Hemminger @ 2009-10-06 23:10 UTC (permalink / raw)
To: Jie Yang; +Cc: netdev
> http://bugzilla.kernel.org/show_bug.cgi?id=14336
>
> Summary: [Pardus] Soft Lockup Problem with Attansic Ethernet
> Card
> Product: Networking
> Version: 2.5
> Kernel Version: 2.6.30.8
> Platform: All
> OS/Version: Linux
> Tree: Mainline
> Status: NEW
> Severity: high
> Priority: P1
> Component: IPV4
> AssignedTo: shemminger@linux-foundation.org
> ReportedBy: badibere@gmail.com
> Regression: No
>
>
> I have soft lockup problem with attansic ethernet card while activating eth0
> interface.
>
> My ethernet card is 09:00.0 Ethernet controller: Attansic Technology Corp.
> Device 1063 (rev c0)
>
> If I try to activate eth0 interface while network cable is pluged in, then
> everything freezes.
>
> If I try to activate eth0 interface while network cable isn't pluged in, then
> no problem. But, if i plug in, again freezes.
>
> My /var/log/syslog is in attachment.
>
this is what was in the bug attachment
Oct 7 00:53:33 baDibere kernel: [ 16.162099] atl1c 0000:09:00.0: enabling device (0000 -> 0002)
Oct 7 00:53:33 baDibere kernel: [ 16.162117] atl1c 0000:09:00.0: PCI INT A -> GSI 17 (level, low) -> IRQ 17
Oct 7 00:53:33 baDibere kernel: [ 16.162141] atl1c 0000:09:00.0: setting latency timer to 64
Oct 7 00:53:33 baDibere kernel: [ 16.162247] atl1c 0000:09:00.0: PME# disabled
Oct 7 00:53:33 baDibere kernel: [ 16.162266] atl1c 0000:09:00.0: PME# disabled
Oct 7 00:53:33 baDibere kernel: [ 16.230835] atl1c 0000:09:00.0: version 1.0.0.1-NAPI
Oct 7 00:55:57 baDibere kernel: [ 169.943463] atl1c 0000:09:00.0: Unable to allocate MSI interrupt Error: -22
Oct 7 00:55:57 baDibere kernel: [ 169.943576] atl1c 0000:09:00.0: atl1c: eth0 NIC Link is Up<100 Mbps Full Duplex>
^ permalink raw reply
* RE: [net-next-2.6 PATCH 1/9] vxge: Modify __vxge_hw_device_is_privilaged() to not assume function-0 as the privileged function: Resubmit#1
From: Ramkrishna Vepa @ 2009-10-06 23:22 UTC (permalink / raw)
To: David Miller, Sreenivasa Honnur; +Cc: netdev, support
In-Reply-To: <20091006.152241.159698718.davem@davemloft.net>
> So I'm going to apply this patch set to net-next-2.6, omitting patch
> #8 from the series.
[Ram] Thanks!
Ram
^ permalink raw reply
* Re: [Bugme-new] [Bug 14336] New: [Pardus] Soft Lockup Problem with Attansic Ethernet Card
From: J. K. Cliburn @ 2009-10-06 23:33 UTC (permalink / raw)
To: Erdem ARTAN
Cc: Andrew Morton, bugzilla-daemon, bugme-daemon, netdev, linux-acpi,
Jesse Barnes, Chris Snook, Jie Yang
In-Reply-To: <3d54862b0910061601iba25b87hfba151f71d6ce4ef@mail.gmail.com>
On Oct 6, 2009, at 6:01 PM, Erdem ARTAN wrote:
> Yesterday, there wasn't any problem but 3 days ago there was same
> problem.
>
> While there wasn't any problem, if I'm not wrong, both atl1c and
> atl1e modules were loaded on boot. But, If I try to load atl1e now,
> nothing changes.
The pci_id says your chip is an L1c. Jie Yang is the maintainer of
the atl1c driver and is cc'd.
Jay
^ permalink raw reply
* Re: [Bugme-new] [Bug 14336] New: [Pardus] Soft Lockup Problem with Attansic Ethernet Card
From: J. K. Cliburn @ 2009-10-06 23:39 UTC (permalink / raw)
To: Andrew Morton
Cc: badibere, bugzilla-daemon, bugme-daemon, netdev, linux-acpi,
Jesse Barnes, Chris Snook, Jie Yang
In-Reply-To: <20091006155502.f3fc86d9.akpm@linux-foundation.org>
On Oct 6, 2009, at 5:55 PM, Andrew Morton wrote:
>
> (switched to email. Please respond via emailed reply-to-all, not
> via the
> bugzilla web interface).
>
> On Tue, 6 Oct 2009 22:37:13 GMT
> bugzilla-daemon@bugzilla.kernel.org wrote:
>
>> http://bugzilla.kernel.org/show_bug.cgi?id=14336
>>
>> Summary: [Pardus] Soft Lockup Problem with Attansic
>> Ethernet
>> Card
>> Product: Networking
>> Version: 2.5
>> Kernel Version: 2.6.30.8
>> Platform: All
>> OS/Version: Linux
>> Tree: Mainline
>> Status: NEW
>> Severity: high
>> Priority: P1
>> Component: IPV4
>> AssignedTo: shemminger@linux-foundation.org
>> ReportedBy: badibere@gmail.com
>> Regression: No
>>
>>
>> I have soft lockup problem with attansic ethernet card while
>> activating eth0
>> interface.
>>
>> My ethernet card is 09:00.0 Ethernet controller: Attansic
>> Technology Corp.
>> Device 1063 (rev c0)
>>
>> If I try to activate eth0 interface while network cable is pluged
>> in, then
>> everything freezes.
>>
>> If I try to activate eth0 interface while network cable isn't
>> pluged in, then
>> no problem. But, if i plug in, again freezes.
>>
>> My /var/log/syslog is in attachment.
>>
>
> From the dmesg output it appears that this card is driven by the atl1c
> driver:
>
> Oct 7 00:55:57 baDibere kernel: [ 169.943463] atl1c 0000:09:00.0:
> Unable to allocate MSI interrupt Error: -22
> Oct 7 00:55:57 baDibere kernel: [ 169.943576] atl1c 0000:09:00.0:
> atl1c: eth0 NIC Link is Up<100 Mbps Full Duplex>
> Oct 7 00:56:22 baDibere kernel: [ 194.849361] NVRM: Xid
> (0001:00): 16, Head 00000000 Count 00003651
> Oct 7 00:56:31 baDibere kernel: [ 203.849307] NVRM: Xid
> (0001:00): 16, Head 00000000 Count 00003653
> Oct 7 00:56:36 baDibere kernel: [ 208.849339] NVRM: Xid
> (0001:00): 8, Channel 00000003
> Oct 7 00:56:41 baDibere kernel: [ 213.852320] NVRM: Xid
> (0001:00): 16, Head 00000000 Count 00003655
>
>
> The "Unable to allocate MSI interrupt" might be the immediate problem.
>
> Who belongs to MSI interrupt allocation? PCI? ACPI?
>
> However the driver does attempt to handle and recover from the MSI
> interrupt allocation error so perhaps that's no the cause at all.
>
I'd be curious to know if the lockup occurs when booted with pci=nomsi.
Jay
^ permalink raw reply
* Re: [PATCH net-next] myri10ge: add adaptive coalescing
From: David Miller @ 2009-10-07 0:25 UTC (permalink / raw)
To: brice; +Cc: netdev, gallatin
In-Reply-To: <4ACB75DB.4060003@myri.com>
From: Brice Goglin <brice@myri.com>
Date: Tue, 06 Oct 2009 18:52:43 +0200
> This patch adds support for adaptive interrupt coalescing to the
> myri10ge driver. It is based on the host periodically look at
> statistics and update the NIC coalescing accordingly.
>
> The NIC only provides packet throughput and we feel that it is a
> better heuristics than the packet rate heuristics currently used
> in ethtool. Also, assuming that the packet packet rate heuristics
> uses what is actually sent on the wire when using TSO, it would be
> much more expensive to implement correctly, as the driver would
> need to calculate how many packets were sent.
>
> Signed-off-by: Andrew Gallatin <gallatin@myri.com>
> Signed-off-by: Brice Goglin <brice@myri.com>
Drivers tried to do this as far back as 6 years ago (tg3) and we don't
recommend doing this with NAPI drivers.
You detection code can never respond quick enough in response to
changes in traffic conditions. By the time you program the new values
into the registers things on the wire can change a lot.
It's also very easy to flap and hit the settings a lot.
That's why we recommend using low hw mitigation settings and simply
leaving it like that.
^ permalink raw reply
* Re: [RFC net-next-2.6] net: speedup sk_wake_async()
From: David Miller @ 2009-10-07 0:28 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
In-Reply-To: <4ACBCDD8.5000306@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 07 Oct 2009 01:08:08 +0200
> An incoming datagram must bring into cpu cache *lot* of cache lines,
> in particular : (other parts omitted (hash chains, ip route cache...))
>
> On 32bit arches :
...
> We can avoid sk->sk_socket and socket->fasync_list referencing on sockets
> with no fasync() structures. (socket->fasync_list ptr is probably already in cache
> because it shares a cache line with socket->wait, ie location pointed by sk->sk_sleep)
>
> This avoids one cache line load per incoming packet for common cases (no fasync())
>
> We can leave (or even move in a future patch) sk->sk_socket in a cold location
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
I like it, applied to net-next-2.6, thanks!
^ permalink raw reply
* Re: [net-2.6 PATCH 0/3] qlge: Fixes for qlge.
From: David Miller @ 2009-10-07 0:35 UTC (permalink / raw)
To: ron.mercer; +Cc: netdev
In-Reply-To: <1254779209-15174-1-git-send-email-ron.mercer@qlogic.com>
All 3 patches applied, thanks Ron.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox