* Re: [PATCH] ipv4: arp_notify address list bug
From: David Miller @ 2009-10-07 10:18 UTC (permalink / raw)
To: eric.dumazet; +Cc: hannes, shemminger, netdev
In-Reply-To: <4ACAD393.5080909@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 06 Oct 2009 07:20:19 +0200
> From: Stephen Hemminger <shemminger@vyatta.com>
>
> This fixes a bug with arp_notify.
>
> If arp_notify is enabled, kernel will crash if address is changed
> and no IP address is assigned.
> http://bugzilla.kernel.org/show_bug.cgi?id=14330
>
> Reported-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks everyone.
^ permalink raw reply
* Re: [PATCH net-next-2.6] be2net: Get rid of net_device_stats from adapter.
From: David Miller @ 2009-10-07 10:11 UTC (permalink / raw)
To: ajitk, ajitkhaparde; +Cc: netdev
In-Reply-To: <20091007090903.GA18843@serverengines.com>
From: Ajit Khaparde <ajitkhaparde@gmail.com>
Date: Wed, 7 Oct 2009 14:39:16 +0530
> adapter doesnot need to maintain a copy of net_device_stats.
> Use the one already available in net_device. This patch takes care of the same.
>
> Signed-off-by: Ajit Khaparde <ajitk@serverengines.com>
Applied, thank you.
^ permalink raw reply
* Re: [PATCH] include/netdevice.h: fix nanodoc mismatch
From: David Miller @ 2009-10-07 10:10 UTC (permalink / raw)
To: w.sang; +Cc: netdev, trivial
In-Reply-To: <20091007091803.GD3177@pengutronix.de>
From: Wolfram Sang <w.sang@pengutronix.de>
Date: Wed, 7 Oct 2009 11:18:03 +0200
> On Wed, Aug 12, 2009 at 10:16:25PM -0700, David Miller wrote:
>> From: Wolfram Sang <w.sang@pengutronix.de>
>> Date: Mon, 10 Aug 2009 13:04:49 +0200
>>
>> > nanodoc was missing an ndo_-prefix.
>> >
>> > Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
>>
>> I'll apply this, thanks.
>
> I can't find it in your trees. Slipped through?
Looks that way.
Sorry about that, could you please resend?
Thanks!
^ permalink raw reply
* Re: [PATCH] include/netdevice.h: fix nanodoc mismatch
From: Wolfram Sang @ 2009-10-07 9:18 UTC (permalink / raw)
To: David Miller; +Cc: netdev, trivial
In-Reply-To: <20090812.221625.138548183.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 500 bytes --]
On Wed, Aug 12, 2009 at 10:16:25PM -0700, David Miller wrote:
> From: Wolfram Sang <w.sang@pengutronix.de>
> Date: Mon, 10 Aug 2009 13:04:49 +0200
>
> > nanodoc was missing an ndo_-prefix.
> >
> > Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
>
> I'll apply this, thanks.
I can't find it in your trees. Slipped through?
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply
* Re: skb_shinfo(skb)->nr_frags > 0 while skb_is_gso(skb) == 0?
From: John Wright @ 2009-10-07 9:04 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev, Michael Chan, Bob Montgomery
In-Reply-To: <20091006182131.484d6e5a@nehalam>
Hi Stephen,
On Tue, Oct 06, 2009 at 06:21:31PM -0700, Stephen Hemminger wrote:
> On Tue, 6 Oct 2009 19:03:15 -0600
> John Wright <john.wright@hp.com> wrote:
> > Bob Montgomery and I are debugging an OOPS in the bnx2 driver. The
> > driver OOPSes in bnx2_tx_int(), getting a NULL pointer dereference when
> > checking if the skb is GSO. (This is on 2.6.29, before is_gso was
> > cached in the tx_buf (commit d62fda08), but bear with me - while kernels
> > with that commit might not crash in the same place, I think we have
> > discovered a bug that would manifest itself another way.)
> >
> > So, first, a question for someone who knows more about sk_buff's than I:
> > is it reasonable/legal for an skb for which skb_is_gso(skb) == 0 to also
> > have skb_shinfo(skb)->nr_frags > 0?
>
> Yes, if driver support Scatter/Gather and Checksum offload,
> TCP (especially splice) will hand fragmented frames to device.
Is there a good way to generate lots of these types of packets? Is
disabling tso and gso with ethtool and sendmsg()ing big chunks of data
enough?
--
+----------------------------------------------------------+
| John Wright <john.wright@hp.com> |
| HP Mission Critical OS Enablement & Solution Test (MOST) |
+----------------------------------------------------------+
^ permalink raw reply
* [PATCH net-next-2.6] be2net: Get rid of net_device_stats from adapter.
From: Ajit Khaparde @ 2009-10-07 9:09 UTC (permalink / raw)
To: davem, netdev
adapter doesnot need to maintain a copy of net_device_stats.
Use the one already available in net_device. This patch takes care of the same.
Signed-off-by: Ajit Khaparde <ajitk@serverengines.com>
---
drivers/net/benet/be.h | 1 -
drivers/net/benet/be_ethtool.c | 2 +-
drivers/net/benet/be_main.c | 6 ++----
3 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/net/benet/be.h b/drivers/net/benet/be.h
index a80da0e..4b61a91 100644
--- a/drivers/net/benet/be.h
+++ b/drivers/net/benet/be.h
@@ -181,7 +181,6 @@ struct be_drvr_stats {
struct be_stats_obj {
struct be_drvr_stats drvr_stats;
- struct net_device_stats net_stats;
struct be_dma_mem cmd;
};
diff --git a/drivers/net/benet/be_ethtool.c b/drivers/net/benet/be_ethtool.c
index 77c66da..333729b 100644
--- a/drivers/net/benet/be_ethtool.c
+++ b/drivers/net/benet/be_ethtool.c
@@ -234,7 +234,7 @@ be_get_ethtool_stats(struct net_device *netdev,
struct be_rxf_stats *rxf_stats = &hw_stats->rxf;
struct be_port_rxf_stats *port_stats =
&rxf_stats->port[adapter->port_num];
- struct net_device_stats *net_stats = &adapter->stats.net_stats;
+ struct net_device_stats *net_stats = &netdev->stats;
struct be_erx_stats *erx_stats = &hw_stats->erx;
void *p = NULL;
int i;
diff --git a/drivers/net/benet/be_main.c b/drivers/net/benet/be_main.c
index 6d5e81f..0e92a1f 100644
--- a/drivers/net/benet/be_main.c
+++ b/drivers/net/benet/be_main.c
@@ -141,7 +141,7 @@ void netdev_stats_update(struct be_adapter *adapter)
struct be_rxf_stats *rxf_stats = &hw_stats->rxf;
struct be_port_rxf_stats *port_stats =
&rxf_stats->port[adapter->port_num];
- struct net_device_stats *dev_stats = &adapter->stats.net_stats;
+ struct net_device_stats *dev_stats = &adapter->netdev->stats;
struct be_erx_stats *erx_stats = &hw_stats->erx;
dev_stats->rx_packets = port_stats->rx_total_frames;
@@ -269,9 +269,7 @@ static void be_rx_eqd_update(struct be_adapter *adapter)
static struct net_device_stats *be_get_stats(struct net_device *dev)
{
- struct be_adapter *adapter = netdev_priv(dev);
-
- return &adapter->stats.net_stats;
+ return &dev->stats;
}
static u32 be_calc_rate(u64 bytes, unsigned long ticks)
--
1.6.0.4
^ permalink raw reply related
* Re: [PATCH 00/11] Gigaset driver patches for 2.6.32 (v3)
From: David Miller @ 2009-10-07 8:30 UTC (permalink / raw)
To: kkeil-iHCpqvpFUx0uJkBD2foKsQ
Cc: isdn-iHCpqvpFUx0uJkBD2foKsQ, netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, tilman-ZTO5kqT2PaM,
hjlipp-S0/GAf8tV78, isdn4linux-JX7+OpRa80SjiSfgN6Y1Ib39b6g2fGNp,
keil-shG/GajIFYqbacvFa/9K2g,
i4ldeveloper-JX7+OpRa80SjiSfgN6Y1Ib39b6g2fGNp
In-Reply-To: <1254904188.9411@nb-hp>
From: Karsten Keil <kkeil-iHCpqvpFUx0uJkBD2foKsQ@public.gmane.org>
Date: Wed, 7 Oct 2009 10:29:48 +0200
> Since the project hard deadlines are end of this month, I hope I
> have more time for ISDN work then again.
Ok, thanks for the update.
^ permalink raw reply
* Re: [PATCH] dcb: data center bridging ops should be r/o
From: David Miller @ 2009-10-07 8:30 UTC (permalink / raw)
To: peter.p.waskiewicz.jr
Cc: shemminger, jeffrey.t.kirsher, jesse.brandeburg, netdev,
e1000-devel
In-Reply-To: <1254773298.2667.27.camel@localhost.localdomain>
From: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Date: Mon, 05 Oct 2009 13:08:18 -0700
> On Mon, 2009-10-05 at 09:01 -0700, Stephen Hemminger wrote:
>> The data center bridging ops structure can be const
>>
>> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>>
>
> Thanks Stephen, that was an oversight.
>
> Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Applied.
^ permalink raw reply
* Re: [PATCH v2] net: mark net_proto_ops as const
From: David Miller @ 2009-10-07 8:30 UTC (permalink / raw)
To: shemminger; +Cc: netdev
In-Reply-To: <20091005085839.2b3f82df@s6510>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 5 Oct 2009 08:58:39 -0700
> All usages of structure net_proto_ops should be declared const.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied.
^ permalink raw reply
* Re: [PATCH] make TLLAO option for NA packets configurable
From: David Miller @ 2009-10-07 8:29 UTC (permalink / raw)
To: opurdila; +Cc: shemminger, cratiu, netdev
In-Reply-To: <200910030039.15952.opurdila@ixiacom.com>
From: Octavian Purdila <opurdila@ixiacom.com>
Date: Sat, 3 Oct 2009 00:39:15 +0300
> Subject: [PATCH] ipv6: new sysctl for sending TLLAO with unicast NAs
>
> Neighbor advertisements responding to unicast neighbor solicitations
> did not include the target link-layer address option. This patch adds
> a new sysctl option (disabled by default) which controls whether this
> option should be sent even with unicast NAs.
>
> The need for this arose because certain routers expect the TLLAO in
> some situations even as a response to unicast NS packets.
>
> Moreover, RFC 2461 recommends sending this to avoid a race condition
> (section 4.4, Target link-layer address)
>
> Signed-off-by: Cosmin Ratiu <cratiu@ixiacom.com>
> Signed-off-by: Octavian Purdila <opurdila@ixiacom.com>
Applied, thanks!
^ permalink raw reply
* Re: [PATCH] Use sk_mark for IPv6 routing lookups
From: David Miller @ 2009-10-07 8:29 UTC (permalink / raw)
To: brian.haley; +Cc: zenczykowski, eric.dumazet, atis, panther, netdev
In-Reply-To: <4AC64419.6020202@hp.com>
From: Brian Haley <brian.haley@hp.com>
Date: Fri, 02 Oct 2009 14:19:05 -0400
> Add support for IPv6 route lookups using sk_mark.
>
> Signed-off-by: Brian Haley <brian.haley@hp.com>
Applied, thanks!
^ permalink raw reply
* Re: [PATCH] ethtool: Add reset operation
From: David Miller @ 2009-10-07 8:29 UTC (permalink / raw)
To: bhutchings; +Cc: netdev, linux-net-drivers
In-Reply-To: <1254776398.2789.7.camel@achroite>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Mon, 05 Oct 2009 21:59:58 +0100
> After updating firmware stored in flash, users may wish to reset the
> relevant hardware and start the new firmware immediately. This should
> not be completely automatic as it may be disruptive.
>
> A selective reset may also be useful for debugging or diagnostics.
>
> This adds a separate reset operation which takes flags indicating the
> components to be reset. Drivers are allowed to reset only a subset of
> those requested, and must indicate the actual subset. This allows the
> use of generic component masks and some future expansion.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> ---
> This differs from the previous (RFC) version only in the semantics of
> the output value of the reset flags: they should indicate the components
> which were *not* reset. This should be slightly less error-prone as it
> means implementations do not need to maintain the input and output flags
> separately.
Just so my previous reply doesn't confuse, I did apply this version
of the patch.
^ permalink raw reply
* Re: [RFC][PATCH] ethtool: Add reset operation
From: David Miller @ 2009-10-07 8:28 UTC (permalink / raw)
To: bhutchings; +Cc: ajitk, netdev, linux-net-drivers
In-Reply-To: <1254481219.23350.77.camel@localhost>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Fri, 02 Oct 2009 12:00:19 +0100
> On Fri, 2009-10-02 at 16:10 +0530, Ajit Khaparde wrote:
> [...]
>> Can you tell the intention behind this copy_to_user?
>> Do you envision drivers sending back some data to the userland - may be
>> sometime in future?
>
> This allows userland to see which components were actually reset.
Patch applied, thanks.
^ permalink raw reply
* Re: [PATCH] net/ppp: fix comments - ppp_{sync,asynctty}_receive() may sleep
From: David Miller @ 2009-10-07 8:28 UTC (permalink / raw)
To: tilman; +Cc: alan, alan, paulus, linux-ppp, netdev, jarkao2, linux-kernel
In-Reply-To: <20091001142844.C50E511186D@xenon.ts.pxnet.com>
From: Tilman Schmidt <tilman@imap.cc>
Date: Thu, 1 Oct 2009 16:28:44 +0200 (CEST)
> The receive_buf methods of the N_PPP and N_SYNC_PPP line disciplines,
> ppp_asynctty_receive() and ppp_sync_receive(), call tty_unthrottle()
> which may sleep. Fix the comments claiming otherwise.
>
> Impact: documentation
> Signed-off-by: Tilman Schmidt <tilman@imap.cc>
Applied, thanks.
^ permalink raw reply
* Re: [RFC take2] pkt_sched: gen_estimator: Dont report fake rate estimators
From: David Miller @ 2009-10-07 8:27 UTC (permalink / raw)
To: eric.dumazet; +Cc: jarkao2, kaber, netdev
In-Reply-To: <4AC66352.8050500@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 02 Oct 2009 22:32:18 +0200
> Jarek Poplawski a écrit :
>>
>>
>> Hmm... So you made me to do some "real" work here, and guess what?:
>> there is one serious checkpatch warning! ;-) Plus, this new parameter
>> should be added to the function description. Otherwise:
>> Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
>>
>> Thanks,
>> Jarek P.
>>
>> PS: I guess full "Don't" would show we really mean it...
>
> Okay :) Here is the last round, before the night !
>
> Thanks again
>
>
> [RFC] pkt_sched: gen_estimator: Don't report fake rate estimators
Applied, thanks!
^ permalink raw reply
* Re: [PATCH] Use sk_mark for routing lookup in more places
From: David Miller @ 2009-10-07 8:27 UTC (permalink / raw)
To: eric.dumazet; +Cc: atis, panther, netdev
In-Reply-To: <4AC58C46.8080408@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 02 Oct 2009 07:14:46 +0200
> Here is a followup on this area, thanks.
>
> [RFC] af_packet: fill skb->mark at xmit
>
> skb->mark may be used by classifiers, so fill it in case user
> set a SO_MARK option on socket.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Looks fine, applied, thanks!
^ permalink raw reply
* Re: [PATCH net-next-2.6 v2] bonding: introduce primary_reselect option
From: David Miller @ 2009-10-07 8:25 UTC (permalink / raw)
To: jpirko; +Cc: fubar, netdev, bonding-devel, nicolas.2p.debian
In-Reply-To: <20090925132803.GB3657@psychotron.redhat.com>
From: Jiri Pirko <jpirko@redhat.com>
Date: Fri, 25 Sep 2009 15:28:09 +0200
> Subject: [PATCH net-2.6 v3] bonding: introduce primary_reselect option
>
> In some cases there is not desirable to switch back to primary interface when
> it's link recovers and rather stay with currently active one. We need to avoid
> packetloss as much as we can in some cases. This is solved by introducing
> primary_reselect option. Note that enslaved primary slave is set as current
> active no matter what.
>
> Patch modified by Jay Vosburgh as follows: fixed bug in action
> after change of option setting via sysfs, revised the documentation
> update, and bumped the bonding version number.
>
> Signed-off-by: Jiri Pirko <jpirko@redhat.com>
> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH][RESEND 3] IPv6: 6rd tunnel mode
From: David Miller @ 2009-10-07 8:24 UTC (permalink / raw)
To: yoshfuji; +Cc: acassen, netdev
In-Reply-To: <20090923184314.a2a2701d.yoshfuji@linux-ipv6.org>
From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Date: Wed, 23 Sep 2009 18:43:14 +0900
> Subject: [PATCH] ipv6 sit: 6rd (IPv6 Rapid Deployment) Support.
>
> IPv6 Rapid Deployment (6rd; draft-ietf-softwire-ipv6-6rd) builds upon
> mechanisms of 6to4 (RFC3056) to enable a service provider to rapidly
> deploy IPv6 unicast service to IPv4 sites to which it provides
> customer premise equipment. Like 6to4, it utilizes stateless IPv6 in
> IPv4 encapsulation in order to transit IPv4-only network
> infrastructure. Unlike 6to4, a 6rd service provider uses an IPv6
> prefix of its own in place of the fixed 6to4 prefix.
>
> With this option enabled, the SIT driver offers 6rd functionality by
> providing additional ioctl API to configure the IPv6 Prefix for in
> stead of static 2002::/16 for 6to4.
>
> Original patch was done by Alexandre Cassen <acassen@freebox.fr>
> based on old Internet-Draft.
>
> Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Applied, thanks everyone.
^ permalink raw reply
* Re: [PATCH] add vif using local interface index instead of IP
From: David Miller @ 2009-10-07 8:23 UTC (permalink / raw)
To: mail4ilia; +Cc: opurdila, netdev
In-Reply-To: <1b9338490909160853u4d90093fg56453ffff5a67ced@mail.gmail.com>
From: "Ilia K." <mail4ilia@gmail.com>
Date: Wed, 16 Sep 2009 18:53:07 +0300
> When routing daemon wants to enable forwarding of multicast traffic it
> performs something like:
...
> This leads (in the kernel) to calling vif_add() function call which
> search the (physical) device using assigned IP address:
> dev = ip_dev_find(net, vifc->vifc_lcl_addr.s_addr);
>
> The current API (struct vifctl) does not allow to specify an
> interface other way than using it's IP, and if there are more than a
> single interface with specified IP only the first one will be found.
>
> The attached patch (against 2.6.30.4) allows to specify an interface
> by its index, instead of IP address:
...
> Signed-off-by: Ilia K. <mail4ilia@gmail.com>
Applied, thank you.
^ permalink raw reply
* Re: [PATCH net-next-2.6] bonding: remove useless assignment
From: David Miller @ 2009-10-07 8:05 UTC (permalink / raw)
To: nicolas.2p.debian; +Cc: netdev, fubar, bonding-devel
In-Reply-To: <4AB67242.6060803@free.fr>
From: Nicolas de Pesloüan <nicolas.2p.debian@free.fr>
Date: Sun, 20 Sep 2009 20:19:46 +0200
> The variable old_active is first set to bond->curr_active_slave.
> Then, it is unconditionally set to new_active, without being used in
> between.
>
> The first assignment, having no side effect, is useless.
>
> Signed-off-by: Nicolas de Pesloüan <nicolas.2p.debian@free.fr>
Nicolas, all of your patches are corrupts by your email client.
It breaks up long lines and transforms tab characters into spaces.
Please correct this, and resubmit all of your pending patches.
Thank you.
^ permalink raw reply
* Re: [net-next-2.6 PATCH V2] can: add TI CAN (HECC) driver
From: Wolfgang Grandegger @ 2009-10-07 7:15 UTC (permalink / raw)
To: Anant Gole
Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w,
netdev-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-xIg/pKzrS19vn6HldHNs0ANdhmdF6hFW
In-Reply-To: <1254892544-28194-1-git-send-email-anantgole-l0cyMroinI0@public.gmane.org>
Anant Gole wrote:
> TI HECC (High End CAN Controller) module is found on many TI devices. It
> has 32 hardware mailboxes with full implementation of CAN protocol 2.0B
> with bus speeds up to 1Mbps. Specifications of the module are available
> on TI web <http://www.ti.com>
>
> Signed-off-by: Anant Gole <anantgole-l0cyMroinI0@public.gmane.org>
Signed-off-by: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
Thanks for your contribution.
Wolfgang.
^ permalink raw reply
* Re: [PATCH 00/11] Gigaset driver patches for 2.6.32 (v3)
From: David Miller @ 2009-10-07 6:39 UTC (permalink / raw)
To: tilman-ZTO5kqT2PaM
Cc: isdn-iHCpqvpFUx0uJkBD2foKsQ, netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
isdn4linux-JX7+OpRa80SjiSfgN6Y1Ib39b6g2fGNp, hjlipp-S0/GAf8tV78,
keil-shG/GajIFYqbacvFa/9K2g,
i4ldeveloper-JX7+OpRa80SjiSfgN6Y1Ib39b6g2fGNp
In-Reply-To: <20091006-patch-gigaset-00.tilman-ZTO5kqT2PaM@public.gmane.org>
From: Tilman Schmidt <tilman-ZTO5kqT2PaM@public.gmane.org>
Date: Wed, 7 Oct 2009 00:18:21 +0200 (CEST)
> This is the third release of the series of patches for the Gigaset
> drivers I first submitted on 2009-09-06. I have dropped the first patch
> "gigaset: really fix chars_in_buffer" because it has now been merged
> through the tty tree, and folded into the last one the fixes I posted on
> 2009-09-25 and 2009-10-01. Apart from that, the series is unchanged from
> the second submission on 2009-09-19. It would be great if this could
> still make it into release 2.6.32 as one more step on the way to get rid
> of the deprecated ISDN4Linux subsystem.
I applied patches 1-8 to net-2.6, merged net-2.6 into net-next-2.6,
then added patches 9-11 into net-next-2.6
Thanks!
^ permalink raw reply
* Re: [PATCH 0/4] ISDN patches for 2.6.32 (v3)
From: David Miller @ 2009-10-07 6:38 UTC (permalink / raw)
To: tilman; +Cc: netdev, linux-kernel, isdn, keil, isdn4linux, i4ldeveloper
In-Reply-To: <20091006-patch-capi-0.tilman@imap.cc>
From: Tilman Schmidt <tilman@imap.cc>
Date: Wed, 7 Oct 2009 00:17:55 +0200 (CEST)
> Here is a respin of the four patches for the Kernel CAPI subsystem I
> first submitted on 2009-09-06. I have folded into patch 1 the amendment
> I posted as "patch 5/4" on 2009-09-25, and re-added to patches 2 and 3
> Karsten's original Acked-by that came out of the discussion on the
> isdn4linux mailing list. Apart from that, the series is unchanged from
> the second submission on 2009-09-19.
All applied to net-2.6, thanks!
^ permalink raw reply
* Re: [PATCH] udp: extend hash tables to 256 slots
From: David Miller @ 2009-10-07 5:35 UTC (permalink / raw)
To: eric.dumazet; +Cc: rick.jones2, netdev
In-Reply-To: <4ACC2815.7010101@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 07 Oct 2009 07:33:09 +0200
> David Miller a écrit :
>>
>> That's incredible that it's been that low for so long :-)
>>
>> Bug please, dynamically size this thing, maybe with a cap of say 64K
>> to start with. If you don't have time for it I'll take care of this.
>
>
> Well, we can not exceed 65536 slots, given the nature of UDP protocol :)
>
> Do you mean a static allocation at boot time with a size that can be
> overidden in cmdline(like tcp and ip route),
>
> or something that can dynamically extends hash table at runtime ?
I mean dynamically size it between 256 and 65536 slots at boot time,
based upon memory size.
^ permalink raw reply
* RE: [PATCH] netxen: Fix Unlikely(x) > y
From: Dhananjay Phadke @ 2009-10-07 5:34 UTC (permalink / raw)
To: Roel Kluin, netdev@vger.kernel.org, Andrew Morton
In-Reply-To: <4ACB44DA.1010300@gmail.com>
Oh sure, that was a typo. Thanks for catching it.
Acked-by: Dhananjay Phadke <dhananjay@netxen.com>
-----Original Message-----
From: Roel Kluin [mailto:roel.kluin@gmail.com]
Sent: Tuesday, October 06, 2009 06:24
To: Dhananjay Phadke; netdev@vger.kernel.org; Andrew Morton
Subject: [PATCH] netxen: Fix Unlikely(x) > y
The closing parenthesis was not on the right location.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
This was intended, I think?
diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c
index b5aa974..9b9eab1 100644
--- a/drivers/net/netxen/netxen_nic_main.c
+++ b/drivers/net/netxen/netxen_nic_main.c
@@ -1714,7 +1714,7 @@ netxen_nic_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
/* 4 fragments per cmd des */
no_of_desc = (frag_count + 3) >> 2;
- if (unlikely(no_of_desc + 2) > netxen_tx_avail(tx_ring)) {
+ if (unlikely(no_of_desc + 2 > netxen_tx_avail(tx_ring))) {
netif_stop_queue(netdev);
return NETDEV_TX_BUSY;
}
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox