* RE: PATCH: Network Device Naming mechanism and policy
From: Narendra_K @ 2009-11-04 14:23 UTC (permalink / raw)
To: bryan
Cc: dannf, bhutchings, netdev, linux-hotplug, Matt_Domsch,
Jordan_Hargrave, Charles_Rose, Sandeep_K_Shandilya
In-Reply-To: <4ADC906E.2050909@kadzban.is-a-geek.net>
>>> Matt, Ben and I talked about a few other possibilities on IRC. The
>>> one I like the most at the moment is an idea Ben had to creat dummy
>>> files named after the ifindex. Then, use symlinks for the
>kernel name
>>> and the various by-$property subdirectories. This means the KOBJ
>>> events will need to expose the ifindex.
>>>
>>
>> I suppose the KOBJ events already expose the ifindex of a network
>> interface. The file "/sys/class/net/ethN/uevent" contains
>> INTERFACE=ethN and IFINDEX=n already. But it looks like udev doesn't
>> use it in any way.
>
>Right; it could simply do the equivalent of:
>
>touch /dev/netdev/$env{IFINDEX}
>
>instead of its normal mknod(2), and then do normal SYMLINK processing.
>That last part is what would link
>/dev/netdev/by-name/$env{INTERFACE} to that device, along with
>/dev/netdev/by-mac/*, /dev/netdev/by-path/*, etc., etc., in as
>many different ways as people want to add rules.
>
>(Or /dev/net/by-* instead of netdev; I'm mostly ambivalent
>about the first-level directory under /dev. Looks like
>libnetdevname requires /dev/netdev though.)
>
>> For example, with the kernel patch the "/sys/class/net/ethN/uevent"
>> contains in addition to the above details, MAJOR=M and MINOR=m which
>> the udev knows how to make use of with a rule like
>>
>> SUBSYSTEM=="net", KERNEL!="tun", NAME="netdev/%k", MODE="0600".
>
>And if the only point is to get the ifindex via stat(2) on the
>resulting symlinks, but people don't like device files, then
>why not get the ifindex via readlink(2) (and a bit of string
>parsing, and a strtol(3) or
>strtoul(3) call) instead? :-)
I suppose this issue can also be addressed in another way. Currently,
the sysfs contains various attributes of a network interface under the
directory "/sys/class/net/ethN", for example
"/sys/class/net/ethN/address". This will be used by udev as below -
SUBSYSTEM=="net", ACTION=="add", DRIVERS=="?*",
ATTR{address}=="00:1d:09:6a:78:ec", ATTR{type}=="1", KERNEL=="eth*",
NAME="eth1".
Similarly, export an attribute named "smbios_name" to sysfs, i.e
"/sys/class/net/eth0/smbios_name". "Cat /sys/class/net/eth0/smbios_name"
would show "Embedded_NIC_1[23..]" and this can be used by udev in
70-persistent-net.rules as
SUBSYSTEM=="net", ACTION=="add", DRIVERS=="?*",
ATTR{smbios_name}=="Embedded_NIC_1", ATTR{type}=="1", KERNEL=="eth*",
NAME="eth0".
I suppose this would not need any changes to the udev code and existing
udev infrastructure can be used as udev is capable handling
ATTR{something}.
This would also ensure that whichever device is "Embedded_NIC_1" as per
the BIOS, will also be "eth0" in the os.
Netdev, What are your views on this idea ?
With regards,
Narendra K
^ permalink raw reply
* virtio-net: new section mismatch warning. revert patch?
From: Michael S. Tsirkin @ 2009-11-04 14:17 UTC (permalink / raw)
To: Uwe Kleine-König, Sam Ravnborg
Cc: David S. Miller, Rusty Russell, Alex Williamson, Mark McLoughlin,
netdev, linux-kernel
With v2.6.32-rcX I started getting section mismatch warnings for
virtio_net.
make with CONFIG_DEBUG_SECTION_MISMATCH=y shows:
WARNING: drivers/net/virtio_net.o(.data+0x90): Section mismatch in
reference from the variable virtio_net to the function
.devexit.text:virtnet_remove()
The variable virtio_net references
the function __devexit virtnet_remove()
If the reference is valid then annotate the
variable with __exit* (see linux/init.h) or name the variable:
*driver, *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,
virtnet_remove was converted to devexit by this commit:
commit 3d1285beff2e8467b8c3884d83b7a91a99aa9fcd
Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Wed Sep 30 22:28:34 2009 +0000
move virtnet_remove to .devexit.text
We didn't have these warnings in v2.6.31, so this is a regression.
revert?
--
MST
^ permalink raw reply
* Re: [PATCH 1/1] DaVinci EMAC: correct param for ISR
From: David Miller @ 2009-11-04 13:45 UTC (permalink / raw)
To: Bo.Liu; +Cc: khilman, davinci-linux-open-source-bounces, netdev
In-Reply-To: <4AEF8CD6.9060804@windriver.com>
From: Tonyliu <Bo.Liu@windriver.com>
Date: Tue, 03 Nov 2009 09:52:22 +0800
> Subject: [PATCH 1/1] DaVinci EMAC: correct param for ISR
>
> emac_irq is declared as:
>
> static irqreturn_t emac_irq(int irq, void *dev_id)
> {
> struct net_device *ndev = (struct net_device *)dev_id;
> struct emac_priv *priv = netdev_priv(ndev);
> ...
>
> Clearly emac_irq() needs "struct net_device *" as "void *dev_id", so correct this.
>
> Signed-off-by: Tonyliu <Bo.Liu@windriver.com>
Applied to net-2.6, thank you.
^ permalink raw reply
* Re: [PATCH net-next-2.6] net: Introduce for_each_netdev_rcu() iterator
From: David Miller @ 2009-11-04 13:43 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
In-Reply-To: <4AEEF908.8070900@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 02 Nov 2009 16:21:44 +0100
> [PATCH net-next-2.6 take2] net: Introduce for_each_netdev_rcu() iterator
...
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Looks great Eric, applied.
^ permalink raw reply
* Re: [PATCHv7 3/3] vhost_net: a kernel-level virtio server
From: Michael S. Tsirkin @ 2009-11-04 13:41 UTC (permalink / raw)
To: Andi Kleen
Cc: netdev, virtualization, kvm, linux-kernel, mingo, linux-mm, akpm
In-Reply-To: <20091104133728.GN31511@one.firstfloor.org>
On Wed, Nov 04, 2009 at 02:37:28PM +0100, Andi Kleen wrote:
> On Wed, Nov 04, 2009 at 03:17:36PM +0200, Michael S. Tsirkin wrote:
> > On Wed, Nov 04, 2009 at 02:15:33PM +0100, Andi Kleen wrote:
> > > On Wed, Nov 04, 2009 at 03:08:28PM +0200, Michael S. Tsirkin wrote:
> > > > On Wed, Nov 04, 2009 at 01:59:57PM +0100, Andi Kleen wrote:
> > > > > > Fine?
> > > > >
> > > > > I cannot say -- are there paths that could drop the device beforehand?
> > > >
> > > > Do you mean drop the mm reference?
> > >
> > > No the reference to the device, which owns the mm for you.
> >
> > The device is created when file is open and destroyed
> > when file is closed. So I think the fs code handles the
> > reference counting for me: it won't call file cleanup
> > callback while some userspace process has the file open.
> > Right?
>
> Yes.
>
> But the semantics when someone inherits such a fd through exec
> or through file descriptor passing would be surely "interesting"
> You would still do IO on the old VM.
>
> I guess it would be a good way to confuse memory accounting schemes
> or administrators @)
> It would be all saner if this was all a single atomic step.
>
> -Andi
I have this atomic actually. A child process will first thing
do SET_OWNER: this is required before any other operation.
SET_OWNER atomically (under mutex) does two things:
- check that there is no other owner
- get mm and set current process as owner
I hope this addresses your concern?
--
MST
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply
* Re: HTB accuracy on 10GbE
From: Jarek Poplawski @ 2009-11-04 13:39 UTC (permalink / raw)
To: Eric Dumazet
Cc: Ryousei Takano, Stephen Hemminger, Patrick McHardy,
Linux Netdev List, takano-ryousei
In-Reply-To: <4AF1660E.1080401@gmail.com>
On 04-11-2009 12:31, Eric Dumazet wrote:
....
> Maybe you can try changing class mtu to 40000 instead of 9000, and quantum to 60000 too
>
> tc class add dev $DEV parent 1: classid 1:1 htb rate ${rate}mbit mtu 40000 quantum 60000
>
> (because your tcp stack sends large buffers ( ~ 60000 bytes) as your NIC can offload tcp segmentation)
>
Hmm..., testing htb scheduling exactness with tso/gso on seems kind of
weather reporting. On the other hand, depending on hardware, these
rates could be available with mtu 9000 and tso/gso off, unless I
miss something. So maybe such a test would be interesting too?
Then I'd suggest this one, erlier mentioned, patch to iproute2:
http://marc.info/?l=linux-netdev&m=124453482324409&w=2
Best regards,
Jarek P.
^ permalink raw reply
* Re: [PATCHv7 3/3] vhost_net: a kernel-level virtio server
From: Andi Kleen @ 2009-11-04 13:37 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Andi Kleen, netdev, virtualization, kvm, linux-kernel, mingo,
linux-mm, akpm
In-Reply-To: <20091104131735.GD8920@redhat.com>
On Wed, Nov 04, 2009 at 03:17:36PM +0200, Michael S. Tsirkin wrote:
> On Wed, Nov 04, 2009 at 02:15:33PM +0100, Andi Kleen wrote:
> > On Wed, Nov 04, 2009 at 03:08:28PM +0200, Michael S. Tsirkin wrote:
> > > On Wed, Nov 04, 2009 at 01:59:57PM +0100, Andi Kleen wrote:
> > > > > Fine?
> > > >
> > > > I cannot say -- are there paths that could drop the device beforehand?
> > >
> > > Do you mean drop the mm reference?
> >
> > No the reference to the device, which owns the mm for you.
>
> The device is created when file is open and destroyed
> when file is closed. So I think the fs code handles the
> reference counting for me: it won't call file cleanup
> callback while some userspace process has the file open.
> Right?
Yes.
But the semantics when someone inherits such a fd through exec
or through file descriptor passing would be surely "interesting"
You would still do IO on the old VM.
I guess it would be a good way to confuse memory accounting schemes
or administrators @)
It would be all saner if this was all a single atomic step.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply
* Re: CLONE_NEWNET requires CAP_NET_RAW (and the intended CAP_SYS_ADMIN)
From: David Miller @ 2009-11-04 13:33 UTC (permalink / raw)
To: eparis; +Cc: netdev, nhorman, acme, dwalsh
In-Reply-To: <1257279352.2891.202.camel@dhcp231-106.rdu.redhat.com>
From: Eric Paris <eparis@redhat.com>
Date: Tue, 03 Nov 2009 15:15:52 -0500
> Do people see an issue with me passing kern down to create?
This sounds fine.
> Anyone have problems with me ripping out the half ass unused
> security infrastructure?
If you can simplify it as you describe, indeed this sounds
like a great change to make.
^ permalink raw reply
* Re: [PATCHv7 1/3] tun: export underlying socket
From: David Miller @ 2009-11-04 13:30 UTC (permalink / raw)
To: mst
Cc: netdev, virtualization, kvm, linux-kernel, mingo, linux-mm, akpm,
hpa, gregory.haskins, rusty, s.hetze
In-Reply-To: <20091103172400.GB5591@redhat.com>
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Tue, 3 Nov 2009 19:24:00 +0200
> Assuming it's okay with davem, I think it makes sense to merge this
> patch through Rusty's tree because vhost is the first user of the new
> interface. Posted here for completeness.
I'm fine with that, please add my:
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply
* Re: [PATCH 1/1] Use defaults when no route options are available
From: David Miller @ 2009-11-04 13:28 UTC (permalink / raw)
To: gilad; +Cc: Valdis.Kletnieks, netdev, ori, linux-kernel, akpm
In-Reply-To: <1257276085-13681-1-git-send-email-gilad@codefidence.com>
From: Gilad Ben-Yossef <gilad@codefidence.com>
Date: Tue, 3 Nov 2009 21:21:25 +0200
> Trying to parse the option of a SYN packet that we have
> no route entry for should just use global wide defaults
> for route entry options.
>
> Signed-off-by: Gilad Ben-Yossef <gilad@codefidence.com>
The tester has indicated that this doesn't solve things
for them. I suspect there is another dependency on 'dst'
not being NULL in another path somewhere.
So until this is fully resolved I'm holding off on applying
this patch.
^ permalink raw reply
* Re: [PATCH torvalds-2.6] cdc_ether: additional Ericsson MBM PID's to the whitelist
From: David Miller @ 2009-11-04 13:25 UTC (permalink / raw)
To: torgny.johansson; +Cc: netdev, saurin.shah
In-Reply-To: <200911032228.05527.torgny.johansson@gmail.com>
From: Torgny Johansson <torgny.johansson@gmail.com>
Date: Tue, 3 Nov 2009 22:28:05 +0100
> Trying with another e-mail client to see if that works better. I've
> sent it to my own gmail first and if I "view original" in gmail the
> patch works and applies cleanly after downloading it so I'm hoping
> it will work for you guys too.
Looks good, applied to net-2.6, thanks!
^ permalink raw reply
* Re: [PATCH net-next-2.6] em_meta: avoid one dev_put()
From: David Miller @ 2009-11-04 13:23 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
In-Reply-To: <4AF0A2E9.1080505@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 03 Nov 2009 22:38:49 +0100
> Another rcu conversion to avoid one dev_hold()/dev_put() pair
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks Eric.
^ permalink raw reply
* Re: [PATCH] TI DaVinci EMAC: Add suspend/resume capability
From: David Miller @ 2009-11-04 13:22 UTC (permalink / raw)
To: ranjithl; +Cc: netdev, davinci-linux-open-source, chaithrika
In-Reply-To: <1257338991-19792-1-git-send-email-ranjithl@ti.com>
From: Ranjith Lohithakshan <ranjithl@ti.com>
Date: Wed, 4 Nov 2009 18:19:51 +0530
> Add suspend/resume capability to TI DaVinci EMAC driver.
>
> Signed-off-by: Ranjith Lohithakshan <ranjithl@ti.com>
> Signed-off-by: Chaithrika U S <chaithrika@ti.com>
> ---
> Applies to net-next-2.6
I don't think the CONFIG_PM CPP ifdefs are necessary.
Drivers generally don't do this, and they build just fine
on sparc64 which never sets CONFIG_PM ;-)
^ permalink raw reply
* Re: [PATCHv7 3/3] vhost_net: a kernel-level virtio server
From: Michael S. Tsirkin @ 2009-11-04 13:17 UTC (permalink / raw)
To: Andi Kleen
Cc: netdev, virtualization, kvm, linux-kernel, mingo, linux-mm, akpm
In-Reply-To: <20091104131533.GM31511@one.firstfloor.org>
On Wed, Nov 04, 2009 at 02:15:33PM +0100, Andi Kleen wrote:
> On Wed, Nov 04, 2009 at 03:08:28PM +0200, Michael S. Tsirkin wrote:
> > On Wed, Nov 04, 2009 at 01:59:57PM +0100, Andi Kleen wrote:
> > > > Fine?
> > >
> > > I cannot say -- are there paths that could drop the device beforehand?
> >
> > Do you mean drop the mm reference?
>
> No the reference to the device, which owns the mm for you.
The device is created when file is open and destroyed
when file is closed. So I think the fs code handles the
reference counting for me: it won't call file cleanup
callback while some userspace process has the file open.
Right?
> >
> > > (as in do you hold a reference to it?)
> >
> > By design I think I always have a reference to mm before I use it.
> >
> > This works like this:
> > ioctl SET_OWNER - calls get_task_mm, I think this gets a reference to mm
> > ioctl SET_BACKEND - checks that SET_OWNER was run, starts virtqueue
> > ioctl RESET_OWNER - stops virtqueues, drops the reference to mm
> > file close - stops virtqueues, if we still have it then drops mm
> >
> > This is why I think I can call use_mm/unuse_mm while virtqueue is running,
> > safely.
> > Makes sense?
>
> Do you protect against another thread doing RESET_OWNER in parallel while
> RESET_OWNER runs?
Yes, I have a mutex in the device for that. Same with SET_BACKEND.
> -Andi
>
> --
> ak@linux.intel.com -- Speaking for myself only.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply
* Re: [PATCHv7 3/3] vhost_net: a kernel-level virtio server
From: Andi Kleen @ 2009-11-04 13:15 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Andi Kleen, netdev, virtualization, kvm, linux-kernel, mingo,
linux-mm, akpm
In-Reply-To: <20091104130828.GC8920@redhat.com>
On Wed, Nov 04, 2009 at 03:08:28PM +0200, Michael S. Tsirkin wrote:
> On Wed, Nov 04, 2009 at 01:59:57PM +0100, Andi Kleen wrote:
> > > Fine?
> >
> > I cannot say -- are there paths that could drop the device beforehand?
>
> Do you mean drop the mm reference?
No the reference to the device, which owns the mm for you.
>
> > (as in do you hold a reference to it?)
>
> By design I think I always have a reference to mm before I use it.
>
> This works like this:
> ioctl SET_OWNER - calls get_task_mm, I think this gets a reference to mm
> ioctl SET_BACKEND - checks that SET_OWNER was run, starts virtqueue
> ioctl RESET_OWNER - stops virtqueues, drops the reference to mm
> file close - stops virtqueues, if we still have it then drops mm
>
> This is why I think I can call use_mm/unuse_mm while virtqueue is running,
> safely.
> Makes sense?
Do you protect against another thread doing RESET_OWNER in parallel while
RESET_OWNER runs?
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
^ permalink raw reply
* Re: [PATCHv7 3/3] vhost_net: a kernel-level virtio server
From: Michael S. Tsirkin @ 2009-11-04 13:08 UTC (permalink / raw)
To: Andi Kleen
Cc: netdev, virtualization, kvm, linux-kernel, mingo, linux-mm, akpm
In-Reply-To: <20091104125957.GL31511@one.firstfloor.org>
On Wed, Nov 04, 2009 at 01:59:57PM +0100, Andi Kleen wrote:
> > Fine?
>
> I cannot say -- are there paths that could drop the device beforehand?
Do you mean drop the mm reference?
> (as in do you hold a reference to it?)
By design I think I always have a reference to mm before I use it.
This works like this:
ioctl SET_OWNER - calls get_task_mm, I think this gets a reference to mm
ioctl SET_BACKEND - checks that SET_OWNER was run, starts virtqueue
ioctl RESET_OWNER - stops virtqueues, drops the reference to mm
file close - stops virtqueues, if we still have it then drops mm
This is why I think I can call use_mm/unuse_mm while virtqueue is running,
safely.
Makes sense?
> -Andi
> --
> ak@linux.intel.com -- Speaking for myself only.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply
* Re: [PATCH net-next-2.6] bnx2: avoid compiler warnings
From: David Miller @ 2009-11-04 13:08 UTC (permalink / raw)
To: mchan; +Cc: eric.dumazet, netdev
In-Reply-To: <1257271294.8625.9.camel@HP1>
From: "Michael Chan" <mchan@broadcom.com>
Date: Tue, 3 Nov 2009 10:01:34 -0800
>
> On Tue, 2009-11-03 at 01:17 -0800, Eric Dumazet wrote:
>> drivers/net/bnx2.c: In function ‘bnx2_enable_forced_2g5’:
>> drivers/net/bnx2.c:1447: warning: ‘bmcr’ may be used uninitialized in this function
>> drivers/net/bnx2.c: In function ‘bnx2_disable_forced_2g5’:
>> drivers/net/bnx2.c:1482: warning: ‘bmcr’ may be used uninitialized in this function
>>
>> One fix would be to have an initial value, but a plain return might be better.
>
> I agree that plain return is better. Thanks.
>
> Acked-by: Michael Chan <mchan@broadcom.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH net-next] Phonet: remove tautologies
From: David Miller @ 2009-11-04 13:08 UTC (permalink / raw)
To: remi; +Cc: netdev, remi.denis-courmont
In-Reply-To: <1257237688-19068-1-git-send-email-remi@remlab.net>
From: Rémi Denis-Courmont <remi@remlab.net>
Date: Tue, 3 Nov 2009 10:41:28 +0200
> From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
>
> These checks don't make sense anymore since rtnl_notify() cannot fail.
>
> Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
Applied, thanks!
^ permalink raw reply
* Re: [PATCH] trivial: remove duplicated MIN macro from tehuti.
From: David Miller @ 2009-11-04 13:07 UTC (permalink / raw)
To: tfransosi
Cc: trivial, yanghy, baum, andy, shemminger, apkm, ben, netdev,
linux-kernel
In-Reply-To: <1257253829-4531-1-git-send-email-tfransosi@gmail.com>
From: Thiago Farina <tfransosi@gmail.com>
Date: Tue, 3 Nov 2009 08:10:29 -0500
> Since the kernel api already has the macro "min",
> just use it instead of declaring another one.
>
> Signed-off-by: Thiago Farina <tfransosi@gmail.com>
Applied to net-next-2.6, thanks!
^ permalink raw reply
* Re: [PATCH net-next-2.6] net: cleanup include/net
From: David Miller @ 2009-11-04 13:07 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
In-Reply-To: <4AF02F6B.6040405@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 03 Nov 2009 14:26:03 +0100
> This cleanup patch puts struct/union/enum opening braces,
> in first line to ease grep games.
>
> struct something
> {
>
> becomes :
>
> struct something {
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH] cnic: ensure ulp_type is not negative
From: David Miller @ 2009-11-04 13:07 UTC (permalink / raw)
To: mchan; +Cc: roel.kluin, netdev, akpm, linux-kernel
In-Reply-To: <1257184619.31958.3.camel@HP1>
From: "Michael Chan" <mchan@broadcom.com>
Date: Mon, 2 Nov 2009 09:56:59 -0800
>
> On Mon, 2009-11-02 at 08:53 -0800, Roel Kluin wrote:
>> `ulp_type' is signed, make sure it is not negative
>> when we read the array element.
>>
>> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
>
> Looks good to me. Thanks.
> Acked-by: Michael Chan <mchan@broadcom.com>
Applied to net-next-2.6
^ permalink raw reply
* Re: pull request: wireless-next-2.6 2009-10-28
From: Jiri Kosina @ 2009-11-04 13:03 UTC (permalink / raw)
To: Pavel Machek
Cc: Luis Correia, John W. Linville, Ingo Molnar, Johannes Berg,
Jarek Poplawski, Bartlomiej Zolnierkiewicz, Pekka Enberg,
David Miller, linux-wireless, netdev, linux-kernel
In-Reply-To: <20091102211629.GA1322@ucw.cz>
On Mon, 2 Nov 2009, Pavel Machek wrote:
> > I've searched on my GMail archives and the only patch Bart has
> > provided so far for the rt2x00 project is this:
> >
> > [PATCH] MAINTAINERS: rt2x00 list is moderated
> >
> > Which, while technically correct, adds nothing to the project.
> >
> > So, I will personally continue to ignore Bart's comments, regards and
> > rants, until he provides patches for rt2x00 that actually make the
> > driver better.
>
> Well, he provided review feedback... he should be thanked for that,
> not flamed for it.
He has actually written real patches (and quite non-trivial both in amount
and in functionality), see
http://lkml.org/lkml/2009/11/3/372
But yes, he got flamed for this for some odd reason. I got the impression
that the community around rt2x00 doesn't like (or understand) the way how
opensource development happens.
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply
* Re: [net-next PATCH 0/3] qlge: Clean up and firmware subcommands.
From: David Miller @ 2009-11-04 13:03 UTC (permalink / raw)
To: ron.mercer; +Cc: netdev
In-Reply-To: <1257292171-11683-1-git-send-email-ron.mercer@qlogic.com>
From: Ron Mercer <ron.mercer@qlogic.com>
Date: Tue, 3 Nov 2009 15:49:28 -0800
> Patch #1 is a respin per your request from yesterday.
> Patch #2 adds handling for more firmware events.
> Patch #3 cleans up netdev statistics handling.
Looks good, applied, thanks Ron.
^ permalink raw reply
* Re: [PATCHv7 3/3] vhost_net: a kernel-level virtio server
From: Andi Kleen @ 2009-11-04 12:59 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Andi Kleen, netdev, virtualization, kvm, linux-kernel, mingo,
linux-mm, akpm
In-Reply-To: <20091104121009.GF8398@redhat.com>
> Fine?
I cannot say -- are there paths that could drop the device beforehand?
(as in do you hold a reference to it?)
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply
* [PATCH] TI DaVinci EMAC: Add suspend/resume capability
From: Ranjith Lohithakshan @ 2009-11-04 12:49 UTC (permalink / raw)
To: netdev
Cc: davem, davinci-linux-open-source, Ranjith Lohithakshan,
Chaithrika U S
Add suspend/resume capability to TI DaVinci EMAC driver.
Signed-off-by: Ranjith Lohithakshan <ranjithl@ti.com>
Signed-off-by: Chaithrika U S <chaithrika@ti.com>
---
Applies to net-next-2.6
drivers/net/davinci_emac.c | 35 ++++++++++++++++++++++++++++++++---
1 files changed, 32 insertions(+), 3 deletions(-)
diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c
index a876dce..cace49f 100644
--- a/drivers/net/davinci_emac.c
+++ b/drivers/net/davinci_emac.c
@@ -2806,11 +2806,38 @@ static int __devexit davinci_emac_remove(struct platform_device *pdev)
return 0;
}
+#ifdef CONFIG_PM
+static
+int davinci_emac_suspend(struct platform_device *pdev, pm_message_t state)
+{
+ struct net_device *dev = platform_get_drvdata(pdev);
+
+ if (netif_running(dev))
+ emac_dev_stop(dev);
+
+ clk_disable(emac_clk);
+
+ return 0;
+}
+
+static int davinci_emac_resume(struct platform_device *pdev)
+{
+ struct net_device *dev = platform_get_drvdata(pdev);
+
+ clk_enable(emac_clk);
+
+ if (netif_running(dev))
+ emac_dev_open(dev);
+
+ return 0;
+}
+#else
+#define davinci_emac_suspend NULL
+#define davinci_emac_resume NULL
+#endif
+
/**
* davinci_emac_driver: EMAC platform driver structure
- *
- * We implement only probe and remove functions - suspend/resume and
- * others not supported by this module
*/
static struct platform_driver davinci_emac_driver = {
.driver = {
@@ -2819,6 +2846,8 @@ static struct platform_driver davinci_emac_driver = {
},
.probe = davinci_emac_probe,
.remove = __devexit_p(davinci_emac_remove),
+ .suspend = davinci_emac_suspend,
+ .resume = davinci_emac_resume,
};
/**
--
1.5.6
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox