Netdev List
 help / color / mirror / Atom feed
* [PATCH 11/16] drivers/net/via-velocity.c: remove exceptional & on function name
From: Julia Lawall @ 2009-11-18 18:24 UTC (permalink / raw)
  To: Francois Romieu, netdev, arnd, joe, linux-kernel, kernel-janitors

From: Julia Lawall <julia@diku.dk>

In this file, function names are otherwise used as pointers without &.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r@
identifier f;
@@

f(...) { ... }

@@
identifier r.f;
@@

- &f
+ f
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---
 drivers/net/via-velocity.c          |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/via-velocity.c b/drivers/net/via-velocity.c
index 158f411..1e6b395 100644
--- a/drivers/net/via-velocity.c
+++ b/drivers/net/via-velocity.c
@@ -2176,7 +2176,7 @@ static int velocity_open(struct net_device *dev)
 
 	velocity_init_registers(vptr, VELOCITY_INIT_COLD);
 
-	ret = request_irq(vptr->pdev->irq, &velocity_intr, IRQF_SHARED,
+	ret = request_irq(vptr->pdev->irq, velocity_intr, IRQF_SHARED,
 			  dev->name, dev);
 	if (ret < 0) {
 		/* Power down the chip */

^ permalink raw reply related

* [PATCH 10/16] drivers/net/via-rhine.c: remove exceptional & on function name
From: Julia Lawall @ 2009-11-18 18:23 UTC (permalink / raw)
  To: Roger Luethi, netdev, arnd, joe, linux-kernel, kernel-janitors

From: Julia Lawall <julia@diku.dk>

In this file, function names are otherwise used as pointers without &.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r@
identifier f;
@@

f(...) { ... }

@@
identifier r.f;
@@

- &f
+ f
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---
 drivers/net/via-rhine.c             |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/via-rhine.c b/drivers/net/via-rhine.c
index 4535e89..ec94ddf 100644
--- a/drivers/net/via-rhine.c
+++ b/drivers/net/via-rhine.c
@@ -1150,7 +1150,7 @@ static int rhine_open(struct net_device *dev)
 	void __iomem *ioaddr = rp->base;
 	int rc;
 
-	rc = request_irq(rp->pdev->irq, &rhine_interrupt, IRQF_SHARED, dev->name,
+	rc = request_irq(rp->pdev->irq, rhine_interrupt, IRQF_SHARED, dev->name,
 			dev);
 	if (rc)
 		return rc;

^ permalink raw reply related

* [PATCH 9/16] drivers/net/typhoon.c: remove exceptional & on function name
From: Julia Lawall @ 2009-11-18 18:23 UTC (permalink / raw)
  To: David Dillow, netdev, arnd, joe, linux-kernel, kernel-janitors

From: Julia Lawall <julia@diku.dk>

In this file, function names are otherwise used as pointers without &.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r@
identifier f;
@@

f(...) { ... }

@@
identifier r.f;
@@

- &f
+ f
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---
 drivers/net/typhoon.c               |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/typhoon.c b/drivers/net/typhoon.c
index 5921f5b..079a970 100644
--- a/drivers/net/typhoon.c
+++ b/drivers/net/typhoon.c
@@ -2151,7 +2151,7 @@ typhoon_open(struct net_device *dev)
 		goto out_sleep;
 	}
 
-	err = request_irq(dev->irq, &typhoon_interrupt, IRQF_SHARED,
+	err = request_irq(dev->irq, typhoon_interrupt, IRQF_SHARED,
 				dev->name, dev);
 	if(err < 0)
 		goto out_sleep;

^ permalink raw reply related

* [PATCH 8/16] drivers/net/smsc9420.c: remove exceptional & on function name
From: Julia Lawall @ 2009-11-18 18:23 UTC (permalink / raw)
  To: Steve Glendinning, netdev, arnd, joe, linux-kernel,
	kernel-janitors

From: Julia Lawall <julia@diku.dk>

In this file, function names are otherwise used as pointers without &.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r@
identifier f;
@@

f(...) { ... }

@@
identifier r.f;
@@

- &f
+ f
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---
 drivers/net/smsc9420.c              |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/smsc9420.c b/drivers/net/smsc9420.c
index b4909a2..92e2bbe 100644
--- a/drivers/net/smsc9420.c
+++ b/drivers/net/smsc9420.c
@@ -1161,7 +1161,7 @@ static int smsc9420_mii_probe(struct net_device *dev)
 		phydev->phy_id);
 
 	phydev = phy_connect(dev, dev_name(&phydev->dev),
-		&smsc9420_phy_adjust_link, 0, PHY_INTERFACE_MODE_MII);
+		smsc9420_phy_adjust_link, 0, PHY_INTERFACE_MODE_MII);
 
 	if (IS_ERR(phydev)) {
 		pr_err("%s: Could not attach to PHY\n", dev->name);

^ permalink raw reply related

* [PATCH 7/16] drivers/net/r6040.c: remove exceptional & on function name
From: Julia Lawall @ 2009-11-18 18:23 UTC (permalink / raw)
  To: Florian Fainelli, netdev, arnd, joe, linux-kernel,
	kernel-janitors

From: Julia Lawall <julia@diku.dk>

In this file, function names are otherwise used as pointers without &.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r@
identifier f;
@@

f(...) { ... }

@@
identifier r.f;
@@

- &f
+ f
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---
 drivers/net/r6040.c                 |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/r6040.c b/drivers/net/r6040.c
index 7dfcb58..91ebef0 100644
--- a/drivers/net/r6040.c
+++ b/drivers/net/r6040.c
@@ -842,7 +842,7 @@ static int r6040_open(struct net_device *dev)
 	int ret;
 
 	/* Request IRQ and Register interrupt handler */
-	ret = request_irq(dev->irq, &r6040_interrupt,
+	ret = request_irq(dev->irq, r6040_interrupt,
 		IRQF_SHARED, dev->name, dev);
 	if (ret)
 		return ret;

^ permalink raw reply related

* RE: NETLINK sockets dont honor SO_RCVLOWAT?
From: Jeff Haran @ 2009-11-18 18:22 UTC (permalink / raw)
  To: David Miller, netdev@vger.kernel.org
In-Reply-To: <20091117.231706.125598146.davem@davemloft.net>

> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net] 
> Sent: Tuesday, November 17, 2009 11:17 PM
> To: Jeff Haran
> Cc: netdev@vger.kernel.org
> Subject: Re: NETLINK sockets dont honor SO_RCVLOWAT?
> 
> From: Jeff Haran <jharan@Brocade.COM>
> Date: Tue, 17 Nov 2009 17:54:59 -0800
> 
> > Am I correct in my observation that the SO_RCVLOWAT socket option is
> > not honored when one calls readv() on a PF_NETLINK socket?
> 
> That's correct.
> 
> SO_RCVLOWAT is only available on stream based sockets such as TCP and
> UNIX.
> 

David,

Thanks for the prompt response.

So is this a bug or a feature?

When I call setsockopt() to set this option on a NETLINK socket, setsockopt() appears to return 0 to indicate success. If it's not going to be supported, shouldn't setsockopt() return -1 with ENOPROTOOPT in errno in this case?

This is the behavior I would assume from reading the setsockopt() man page.

I am running this on a 2.6.14 kernel, so perhaps this had been corrected in later versions.

Jeff Haran
Brocade Communications

^ permalink raw reply

* [PATCH 6/16] drivers/net/pppol2tp.c: remove exceptional & on function name
From: Julia Lawall @ 2009-11-18 18:22 UTC (permalink / raw)
  To: James Chapman, netdev, arnd, joe, linux-kernel, kernel-janitors

From: Julia Lawall <julia@diku.dk>

In this file, function names are otherwise used as pointers without &.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r@
identifier f;
@@

f(...) { ... }

@@
identifier r.f;
@@

- &f
+ f
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---
 drivers/net/pppol2tp.c              |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/pppol2tp.c b/drivers/net/pppol2tp.c
index 849cc9c..8dcc26f 100644
--- a/drivers/net/pppol2tp.c
+++ b/drivers/net/pppol2tp.c
@@ -1537,7 +1537,7 @@ static struct sock *pppol2tp_prepare_tunnel_socket(struct net *net,
 	 * if the tunnel socket goes away.
 	 */
 	tunnel->old_sk_destruct = sk->sk_destruct;
-	sk->sk_destruct = &pppol2tp_tunnel_destruct;
+	sk->sk_destruct = pppol2tp_tunnel_destruct;
 
 	tunnel->sock = sk;
 	sk->sk_allocation = GFP_ATOMIC;

^ permalink raw reply related

* [PATCH 5/16] drivers/net/irda: remove exceptional & on function name
From: Julia Lawall @ 2009-11-18 18:22 UTC (permalink / raw)
  To: Samuel Ortiz, netdev, arnd, joe, linux-kernel, kernel-janitors

From: Julia Lawall <julia@diku.dk>

In this file, function names are otherwise used as pointers without &.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r@
identifier f;
@@

f(...) { ... }

@@
identifier r.f;
@@

- &f
+ f
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---
 drivers/net/irda/irda-usb.c         |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/irda/irda-usb.c b/drivers/net/irda/irda-usb.c
index 5e462b9..e591b36 100644
--- a/drivers/net/irda/irda-usb.c
+++ b/drivers/net/irda/irda-usb.c
@@ -852,7 +852,7 @@ static void irda_usb_receive(struct urb *urb)
 		 * hot unplug of the dongle...
 		 * Lowest effective timer is 10ms...
 		 * Jean II */
-		self->rx_defer_timer.function = &irda_usb_rx_defer_expired;
+		self->rx_defer_timer.function = irda_usb_rx_defer_expired;
 		self->rx_defer_timer.data = (unsigned long) urb;
 		mod_timer(&self->rx_defer_timer, jiffies + (10 * HZ / 1000));
 		return;

^ permalink raw reply related

* [PATCH 4/16] drivers/net/ipg.c: remove exceptional & on function name
From: Julia Lawall @ 2009-11-18 18:21 UTC (permalink / raw)
  To: Francois Romieu, Sorbica Shieh, Jesse Huang, netdev, arnd, joe,
	linux-kernel@

From: Julia Lawall <julia@diku.dk>

In this file, function names are otherwise used as pointers without &.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r@
identifier f;
@@

f(...) { ... }

@@
identifier r.f;
@@

- &f
+ f
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---
 drivers/net/ipg.c                   |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ipg.c b/drivers/net/ipg.c
index 63056e7..ba8d246 100644
--- a/drivers/net/ipg.c
+++ b/drivers/net/ipg.c
@@ -1751,7 +1751,7 @@ static int ipg_nic_open(struct net_device *dev)
 	/* Register the interrupt line to be used by the IPG within
 	 * the Linux system.
 	 */
-	rc = request_irq(pdev->irq, &ipg_interrupt_handler, IRQF_SHARED,
+	rc = request_irq(pdev->irq, ipg_interrupt_handler, IRQF_SHARED,
 			 dev->name, dev);
 	if (rc < 0) {
 		printk(KERN_INFO "%s: Error when requesting interrupt.\n",

^ permalink raw reply related

* Re: large packet loss take2 2.6.31.x
From: Caleb Cushing @ 2009-11-18 18:21 UTC (permalink / raw)
  To: Jarek Poplawski; +Cc: Frans Pop, Andi Kleen, linux-kernel, netdev
In-Reply-To: <20091118135136.GA9224@ff.dom.local>

> Actually, I'm a little bit surprised. Maybe I missed something from
> your previous messages, but I expected something more similar to the
> first wireshark dump, which suggested to me there was only this mtr
> traffic. Now there is a lot more (plus we know it's not all).

probably just me lazy at 5 am? did I do the dump on the router right
so it wasn't showing traffic that's just idling from other computers
(windows likes to make a lot of noise). I could do it by ip...

> So, there is a basic question: can this mtr loss be seen while no
> other traffic is present? After looking into these current dumps I
> doubt. There are e.g. 3 pings unanswered between 09:21:50 and
> 09:21:52 (21:31:34 to 21:31:38 router time), but a lot of tcp
> packets to and from 192.168.1.3, so looks like simply dropped and
> we can guess the reason.

yes. this was at a fairly low traffic time of day. 5am only 2 people
were up, and I was using the other computer during. I've had everyone
actively doing one or more of downloading/uploading/video/voip/gaming
stuff on this network with no noticeable packet loss. if really,
really needed I can probably restrict this network to 2 machines for
the duration of the test.

> Since this patch from the bisection is really limited to this one
> module I doubt we should follow this direction. IMHO it shows the
> test wasn't reproducible enough. Probably the amount and/or kind of
> other traffic really matter. If I'm wrong and missed something again
> let me know. Btw, could you try if changing with ifconfig the
> txqueuelen of desktop's eth0 from 100 to 1000 changes anything
> in this mtr test?

yeah testing it under my known working config first. I'll get back w/ you later.
-- 
Caleb Cushing

http://xenoterracide.blogspot.com

^ permalink raw reply

* [PATCH 3/16] drivers/net: remove exceptional & on function name
From: Julia Lawall @ 2009-11-18 18:21 UTC (permalink / raw)
  To: netdev, arnd, joe, linux-kernel, kernel-janitors

From: Julia Lawall <julia@diku.dk>

In this file, function names are otherwise used as pointers without &.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r@
identifier f;
@@

f(...) { ... }

@@
identifier r.f;
@@

- &f
+ f
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---
 drivers/net/ethoc.c             |    2 +-
 drivers/net/pcmcia/fmvj18x_cs.c |    2 +-
 drivers/net/pcmcia/nmclan_cs.c  |    2 +-
 drivers/net/tokenring/3c359.c   |    3 +--
 drivers/net/tokenring/olympic.c |    4 ++--
 5 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/drivers/net/ethoc.c b/drivers/net/ethoc.c
index 50f1923..bd1db92 100644
--- a/drivers/net/ethoc.c
+++ b/drivers/net/ethoc.c
@@ -641,7 +641,7 @@ static int ethoc_mdio_probe(struct net_device *dev)
 		return -ENXIO;
 	}
 
-	phy = phy_connect(dev, dev_name(&phy->dev), &ethoc_mdio_poll, 0,
+	phy = phy_connect(dev, dev_name(&phy->dev), ethoc_mdio_poll, 0,
 			PHY_INTERFACE_MODE_GMII);
 	if (IS_ERR(phy)) {
 		dev_err(&dev->dev, "could not attach to PHY\n");
diff --git a/drivers/net/pcmcia/fmvj18x_cs.c b/drivers/net/pcmcia/fmvj18x_cs.c
index fdec5c3..d3a81ad 100644
--- a/drivers/net/pcmcia/fmvj18x_cs.c
+++ b/drivers/net/pcmcia/fmvj18x_cs.c
@@ -257,7 +257,7 @@ static int fmvj18x_probe(struct pcmcia_device *link)
     /* Interrupt setup */
     link->irq.Attributes = IRQ_TYPE_DYNAMIC_SHARING|IRQ_HANDLE_PRESENT;
     link->irq.IRQInfo1 = IRQ_LEVEL_ID;
-    link->irq.Handler = &fjn_interrupt;
+    link->irq.Handler = fjn_interrupt;
     link->irq.Instance = dev;
 
     /* General socket configuration */
diff --git a/drivers/net/pcmcia/nmclan_cs.c b/drivers/net/pcmcia/nmclan_cs.c
index a536348..8fda8a4 100644
--- a/drivers/net/pcmcia/nmclan_cs.c
+++ b/drivers/net/pcmcia/nmclan_cs.c
@@ -465,7 +465,7 @@ static int nmclan_probe(struct pcmcia_device *link)
     link->io.IOAddrLines = 5;
     link->irq.Attributes = IRQ_TYPE_EXCLUSIVE | IRQ_HANDLE_PRESENT;
     link->irq.IRQInfo1 = IRQ_LEVEL_ID;
-    link->irq.Handler = &mace_interrupt;
+    link->irq.Handler = mace_interrupt;
     link->irq.Instance = dev;
     link->conf.Attributes = CONF_ENABLE_IRQ;
     link->conf.IntType = INT_MEMORY_AND_IO;
diff --git a/drivers/net/tokenring/3c359.c b/drivers/net/tokenring/3c359.c
index 7241589..cf552d1 100644
--- a/drivers/net/tokenring/3c359.c
+++ b/drivers/net/tokenring/3c359.c
@@ -610,9 +610,8 @@ static int xl_open(struct net_device *dev)
 
 	u16 switchsettings, switchsettings_eeprom  ;
  
-	if(request_irq(dev->irq, &xl_interrupt, IRQF_SHARED , "3c359", dev)) {
+	if (request_irq(dev->irq, xl_interrupt, IRQF_SHARED , "3c359", dev))
 		return -EAGAIN;
-	}
 
 	/* 
 	 * Read the information from the EEPROM that we need.
diff --git a/drivers/net/tokenring/olympic.c b/drivers/net/tokenring/olympic.c
index d9ec7f0..df32025 100644
--- a/drivers/net/tokenring/olympic.c
+++ b/drivers/net/tokenring/olympic.c
@@ -445,9 +445,9 @@ static int olympic_open(struct net_device *dev)
 
 	olympic_init(dev);
 
-	if(request_irq(dev->irq, &olympic_interrupt, IRQF_SHARED , "olympic", dev)) {
+	if (request_irq(dev->irq, olympic_interrupt, IRQF_SHARED , "olympic",
+			dev))
 		return -EAGAIN;
-	}
 
 #if OLYMPIC_DEBUG
 	printk("BMCTL: %x\n",readl(olympic_mmio+BMCTL_SUM));

^ permalink raw reply related

* [PATCH 2/16] drivers/net/can: remove exceptional & on function name
From: Julia Lawall @ 2009-11-18 18:20 UTC (permalink / raw)
  To: Urs Thuermann, Oliver Hartkopp, netdev, arnd, joe, linux-kernel,
	ker

From: Julia Lawall <julia@diku.dk>

In this file, function names are otherwise used as pointers without &.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r@
identifier f;
@@

f(...) { ... }

@@
identifier r.f;
@@

- &f
+ f
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---
 drivers/net/can/sja1000/sja1000.c   |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/can/sja1000/sja1000.c b/drivers/net/can/sja1000/sja1000.c
index 782a47f..b4ba88a 100644
--- a/drivers/net/can/sja1000/sja1000.c
+++ b/drivers/net/can/sja1000/sja1000.c
@@ -516,7 +516,7 @@ static int sja1000_open(struct net_device *dev)
 
 	/* register interrupt handler, if not done by the device driver */
 	if (!(priv->flags & SJA1000_CUSTOM_IRQ_HANDLER)) {
-		err = request_irq(dev->irq, &sja1000_interrupt, priv->irq_flags,
+		err = request_irq(dev->irq, sja1000_interrupt, priv->irq_flags,
 				  dev->name, (void *)dev);
 		if (err) {
 			close_candev(dev);

^ permalink raw reply related

* Re: [net-next-2.6 PATCH 2/3] ixgbe: Set MSI-X vectors to NOBALANCING and set affinity
From: David Miller @ 2009-11-18 18:10 UTC (permalink / raw)
  To: peter.p.waskiewicz.jr; +Cc: jeffrey.t.kirsher, gospo, netdev
In-Reply-To: <F86E8680A7D9D74A99DC6345E35A69293E3D4171@orsmsx503.amr.corp.intel.com>

From: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>
Date: Thu, 12 Nov 2009 11:12:22 -0800

> Jesse Brandeburg and I talked with Arjan yesterday regarding these patches.

Thanks for the update.

> We also discussed the need for irqbalance to distinguish between Rx
> and Tx queue vectors.  Right now, irqbalance can identify an
> interrupt belong to an Ethernet device, but it stops there.  It
> needs to also distinguish the directional vectors, and make sure to
> balance the right queue vector with its paired queue (i.e. make sure
> Tx queue 0's vector lines up with Rx queue 0's vector).

Why don't you just simply use the same MSI-X vector for both TX
queue 0 and RX queue 0, can't your hardware do that?

That's what I plan on doing in the NIU driver soon.

^ permalink raw reply

* Re: [RFC] [PATCH net-next] Phonet: convert devices list to RCU
From: David Miller @ 2009-11-18 18:08 UTC (permalink / raw)
  To: remi; +Cc: netdev, remi.denis-courmont
In-Reply-To: <1258462956-31549-1-git-send-email-remi@remlab.net>

From: Rémi Denis-Courmont <remi@remlab.net>
Date: Tue, 17 Nov 2009 15:02:36 +0200

> From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
> 
> Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>

Looks good, applied, thanks.

^ permalink raw reply

* Re: [RFC PATCH iproute2] ip: Add support for setting MAC and VLAN on hardware queues
From: David Miller @ 2009-11-18 18:07 UTC (permalink / raw)
  To: shemminger; +Cc: jeffrey.t.kirsher, netdev, gospo, mitch.a.williams
In-Reply-To: <20091117140641.7f8c8ac0@nehalam>

From: Stephen Hemminger <shemminger@vyatta.com>
Date: Tue, 17 Nov 2009 14:06:41 -0800

> On Tue, 17 Nov 2009 13:55:07 -0800
> Jeff Kirsher <jeffrey.t.kirsher@intel.com> wrote:
> 
>> From: Williams, Mitch A <mitch.a.williams@intel.com>
>> 
>> This patch adds support to the "ip" tool for setting the MAC address and
>> VLAN filter for hardware device queues. This is most immediately useful for
>> SR-IOV; for VF devices to be usable in the real world, the hypervisor or VM
>> manager must be able to set these parameters before the VF device is
>> assigned to any VM.
>> 
>> Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
>> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> 
> Is there anything to avoid prevent this from being misused by users who
> are doing multiqueue. Maybe we need equivalent of "mounted" flag that block
> devices have?

It's a privileged config operation as far as I can tell.

Given that, what could we possibly need to protect?

This stuff looks basically fine to me.


^ permalink raw reply

* Re: Patches for hso driver
From: David Miller @ 2009-11-18 18:01 UTC (permalink / raw)
  To: mschiller; +Cc: netdev
In-Reply-To: <DDA9430807DF40968BE983465235D580@mschille2>

From: "Martin Schiller" <mschiller@tdt.de>
Date: Wed, 18 Nov 2009 08:35:30 +0100

> Have a look at the "hso-memleak.patch" file to see what I mean.

Hmmm...

Please make sure this all works properly, considering
the games that hso_kick_transmit() plays wherein it
swaps ->tx_data and ->tx_buffer every packet send.

Also, please submit your patches sperately and numbered
with changelog and signoffs specific to each change as
described in  linux/Documentation/SubmittingPatches 

Thanks.

^ permalink raw reply

* Re: [net-next-2.6 PATCH v2] allow access to sysfs_groups member
From: David Miller @ 2009-11-18 17:57 UTC (permalink / raw)
  To: kurt.van.dijck; +Cc: shemminger, netdev
In-Reply-To: <20091118164126.GF325@e-circ.dyndns.org>

From: Kurt Van Dijck <kurt.van.dijck@eia.be>
Date: Wed, 18 Nov 2009 17:41:26 +0100

> This patch allows adding sysfs attribute groups during netdevice registration.
> The idea is that before the register_netdev call, several calls to
> netdev_sysfs_add_group can be done. These attributes are accessible (by
> udev) during the uevent.
> 
> Signed-off-by: Kurt Van Dijck <kurt.van.dijck@eia.be>
> Acked-by: Stephen Hemminger <shemminger@vyatta.com>

Patch is corrupted by your email client.  Tab characters have
been turned into spaces, etc.

Please fix this up and resubmit.

Thanks.

^ permalink raw reply

* Re: [PATCH 0/3] TI EMAC driver : Make driver re-usable on non-davinci platforms.
From: Kevin Hilman @ 2009-11-18 17:53 UTC (permalink / raw)
  To: Sriramakrishnan; +Cc: netdev, davinci-linux-open-source
In-Reply-To: <1258537328-31527-1-git-send-email-srk@ti.com>

Sriramakrishnan <srk@ti.com> writes:

> The Davinci EMAC peripheral is also available on other TI platforms -
> notably TI AM3517 SoC. The following series of patches modify the driver 
> suitably to make it platform agnostic.
>
> Sriramakrishnan (3):
>   TI Davinci EMAC : Re-use driver for other platforms.
>   TI Davinci EMAC : add platform specific interrupt enable/disable
>     logic.
>   TI Davinci EMAC : Abstract Buffer address translation logic.
>

As David proposed, this should go upstream via the ARM/DaVinci route.

Can you please re-submit against current DaVinci git?  This series
doesn't apply there currently.

Kevin

^ permalink raw reply

* [PATCH] veth: Fix veth_get_stats()
From: Eric Dumazet @ 2009-11-18 17:09 UTC (permalink / raw)
  To: David S. Miller; +Cc: Linux Netdev List

veth_get_stats() can be called in parallel on several cpus.

It's better to not reset dev->stats as it could give wrong result on
one cpu. Use temporary variables, then store the final results.

Also, we should loop on every possible cpus, not only online cpus,
or cpu hotplug can suddenly give wrong veth stats.

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
 drivers/net/veth.c |   35 ++++++++++++++++-------------------
 1 files changed, 16 insertions(+), 19 deletions(-)

diff --git a/drivers/net/veth.c b/drivers/net/veth.c
index ade5b34..52af501 100644
--- a/drivers/net/veth.c
+++ b/drivers/net/veth.c
@@ -210,32 +210,29 @@ rx_drop:
 static struct net_device_stats *veth_get_stats(struct net_device *dev)
 {
 	struct veth_priv *priv;
-	struct net_device_stats *dev_stats;
 	int cpu;
-	struct veth_net_stats *stats;
+	struct veth_net_stats *stats, total = {0};
 
 	priv = netdev_priv(dev);
-	dev_stats = &dev->stats;
-
-	dev_stats->rx_packets = 0;
-	dev_stats->tx_packets = 0;
-	dev_stats->rx_bytes = 0;
-	dev_stats->tx_bytes = 0;
-	dev_stats->tx_dropped = 0;
-	dev_stats->rx_dropped = 0;
 
-	for_each_online_cpu(cpu) {
+	for_each_possible_cpu(cpu) {
 		stats = per_cpu_ptr(priv->stats, cpu);
 
-		dev_stats->rx_packets += stats->rx_packets;
-		dev_stats->tx_packets += stats->tx_packets;
-		dev_stats->rx_bytes += stats->rx_bytes;
-		dev_stats->tx_bytes += stats->tx_bytes;
-		dev_stats->tx_dropped += stats->tx_dropped;
-		dev_stats->rx_dropped += stats->rx_dropped;
+		total.rx_packets += stats->rx_packets;
+		total.tx_packets += stats->tx_packets;
+		total.rx_bytes   += stats->rx_bytes;
+		total.tx_bytes   += stats->tx_bytes;
+		total.tx_dropped += stats->tx_dropped;
+		total.rx_dropped += stats->rx_dropped;
 	}
-
-	return dev_stats;
+	dev->stats.rx_packets = total.rx_packets;
+	dev->stats.tx_packets = total.tx_packets;
+	dev->stats.rx_bytes   = total.rx_bytes;
+	dev->stats.tx_bytes   = total.tx_bytes;
+	dev->stats.tx_dropped = total.tx_dropped;
+	dev->stats.rx_dropped = total.rx_dropped;
+
+	return &dev->stats;
 }
 
 static int veth_open(struct net_device *dev)

^ permalink raw reply related

* Re: [PATCH 04/10] AOE: use rcu to find network device
From: Ed Cashin @ 2009-11-18 16:49 UTC (permalink / raw)
  To: shemminger, karaluh, ecashin, roel.kluin, harvey.harrison,
	bzolnier, netdev
In-Reply-To: <20091110155316.2c3d7b6e@nehalam>

On Tue Nov 10 18:53:43 EST 2009, shemminger@vyatta.com wrote:

...
> --- a/drivers/block/aoe/aoecmd.c	2009-11-10 15:13:25.673859220 -0800
> +++ b/drivers/block/aoe/aoecmd.c	2009-11-10 15:49:20.009047132 -0800
...
> @@ -424,12 +426,29 @@ static void
>  ejectif(struct aoetgt *t, struct aoeif *ifp)
>  {
>  	struct aoeif *e;
> +	struct net_device *nd;
>  	ulong n;
>  
>  	e = t->ifs + NAOEIFS - 1;
> +	nd = e->nd;
>  	n = (e - ifp) * sizeof *ifp;
>  	memmove(ifp, ifp+1, n);
>  	e->nd = NULL;
> +	dev_put(nd);
> +}

I didn't notice this before, but e->nd will be the net_device pointer
from the last ifp in the allocated array, whether it's NULL or not,
and usually won't be ifp->nd, the one we need to give to dev_put.  I
think that's why I see an oops when testing the version of the patch
that I sent last.  The test is doing rmmod on the interface that's
being used to create an ext2 fs on an AoE target.

I'll use ifp->nd instead of e->nd and test again tomorrow.  I have to
step away from the computer today.

-- 
  Ed

^ permalink raw reply

* Re: [net-next-2.6 PATCH v2] allow access to sysfs_groups member
From: Kurt Van Dijck @ 2009-11-18 16:41 UTC (permalink / raw)
  To: David Miller; +Cc: shemminger, netdev
In-Reply-To: <20091118.080849.196755366.davem@davemloft.net>

This patch allows adding sysfs attribute groups during netdevice registration.
The idea is that before the register_netdev call, several calls to
netdev_sysfs_add_group can be done. These attributes are accessible (by
udev) during the uevent.

Signed-off-by: Kurt Van Dijck <kurt.van.dijck@eia.be>
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
---
 include/linux/netdevice.h |    2 ++
 net/core/net-sysfs.c      |   29 ++++++++++++++++++++++++-----
 2 files changed, 26 insertions(+), 5 deletions(-)

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 8380009..ebfc789 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -1115,6 +1115,8 @@ extern int                dev_open(struct net_device *dev);
 extern int             dev_close(struct net_device *dev);
 extern void            dev_disable_lro(struct net_device *dev);
 extern int             dev_queue_xmit(struct sk_buff *skb);
+extern int             netdev_sysfs_add_group(struct net_device *net,
+                               const struct attribute_group *grp);
 extern int             register_netdevice(struct net_device *dev);
 extern void            unregister_netdevice(struct net_device *dev);
 extern void            free_netdev(struct net_device *dev);
diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
index 753c420..6451e9a 100644
--- a/net/core/net-sysfs.c
+++ b/net/core/net-sysfs.c
@@ -527,27 +527,46 @@ void netdev_unregister_kobject(struct net_device * net)
        device_del(dev);
 }

+/* Add a sysfs group to the netdev groups */
+int netdev_sysfs_add_group(struct net_device *net,
+               const struct attribute_group *grp)
+{
+       struct attribute_group **groups = net->sysfs_groups;
+       struct attribute_group **end;
+
+       BUG_ON(net->reg_state >= NETREG_REGISTERED);
+       /* end pointer, with room for null terminator */
+       end = &net->sysfs_groups[ARRAY_SIZE(net->sysfs_groups) - 1];
+       for (; groups < end; ++groups) {
+               if (!*groups) {
+                       *groups = grp;
+                       return 0;
+               }
+       }
+       return -ENOSPC;
+}
+EXPORT_SYMBOL_GPL(netdev_sysfs_add_group);
+
 /* Create sysfs entries for network device. */
 int netdev_register_kobject(struct net_device *net)
 {
        struct device *dev = &(net->dev);
-       const struct attribute_group **groups = net->sysfs_groups;

        dev->class = &net_class;
        dev->platform_data = net;
-       dev->groups = groups;
+       dev->groups = net->sysfs_groups;

        dev_set_name(dev, "%s", net->name);

 #ifdef CONFIG_SYSFS
-       *groups++ = &netstat_group;
+       netdev_sysfs_add_group(net, &netstat_group);

 #ifdef CONFIG_WIRELESS_EXT_SYSFS
        if (net->ieee80211_ptr)
-               *groups++ = &wireless_group;
+               netdev_sysfs_add_group(net, &wireless_group);
 #ifdef CONFIG_WIRELESS_EXT
        else if (net->wireless_handlers)
-               *groups++ = &wireless_group;
+               netdev_sysfs_add_group(net, &wireless_group);
 #endif
 #endif
 #endif /* CONFIG_SYSFS */


^ permalink raw reply related

* Re: [ewg] [PATCHv6 0/10] RDMAoE support
From: Or Gerlitz @ 2009-11-18 16:34 UTC (permalink / raw)
  To: Eli Cohen; +Cc: Roland Dreier, Linux RDMA list, netdev, ewg
In-Reply-To: <20091116155302.GA2463@mtls03>

Eli Cohen wrote:
> This new series reflects changes based on feedback from the community on the previous set of patches, and is tagged v6. Previous series were posted to the openfabrics general list only.
>
> Changes from v5:
> 1. Bug fixes.
How do you expect a reviewer to learn what were the bugs and what are 
the fixes and if there are bugs that are known and weren't fixed yet? is 
one expected to do a diff between patches? where is the listing of 
changes from vX for X=1,2,3,4?

Or.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply

* Re: [net-next-2.6 PATCH v2] allow access to sysfs_groups member
From: David Miller @ 2009-11-18 16:08 UTC (permalink / raw)
  To: kurt.van.dijck; +Cc: shemminger, netdev
In-Reply-To: <20091118154313.GE325@e-circ.dyndns.org>

From: Kurt Van Dijck <kurt.van.dijck@eia.be>
Date: Wed, 18 Nov 2009 16:43:13 +0100

> Is there anything I'm supposed to do/deliver to get the patch committed?

Please just resubmit it fully with full changelog and signoffs.

Thanks.

^ permalink raw reply

* Re: [net-next-2.6 PATCH v2] allow access to sysfs_groups member
From: Kurt Van Dijck @ 2009-11-18 15:43 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: netdev, David Miller
In-Reply-To: <20091116084612.3654bdd1@nehalam>

On Mon, Nov 16, 2009 at 08:46:12AM -0800, Stephen Hemminger wrote:
> 
> Okay by me.
> 
Sorry for asking.
I'm not very experienced yet with git etc.
Is there anything I'm supposed to do/deliver to get the patch committed?

kind regards,
Kurt


^ permalink raw reply

* [GIT]: Networking
From: David Miller @ 2009-11-18 15:25 UTC (permalink / raw)
  To: torvalds; +Cc: akpm, netdev, linux-kernel


1) Device refcount leak fixes in ROSE and DecNET from Eric Dumazet.

2) IXGBE TX hang fix from Don Skidmore.

3) CXGB3 unmaps DMA buffer too early, fix from Divy Le Ray

4) Wireless fixes via John Linville, in particular a revert of
   the cfg80211 conversion of the ipw2xxx driver as it simply
   broke too much and fixing it is not worth the hassle and risk
   this late in the -rc series.  Also revert the "fix oops on
   missing firmware" change as that broke more than it fixed.

5) Fragmentation disabling busted in IPIP driver when not using
   PMTU discovery, fix from Herbert Xu.

6) Fix SunGEM serdes PHY detection on Sparc.

7) IPMR leaks devices, fix from Dan Carpenter.

8) GRO can merge packets illegally in some circumstances.  Fix from
   Herbert Xu.

9) Locking and error handling fixes in ISDN and Cassini driver from
   Jiri Slaby.

10) CQE_STATUS_EXTD_SHIFT in be2net driver is wrong, fix from Sathya Perla.
    Also be2net fails to reprogram flow control properly on resume, from
    Ajit Khaparde.

11) Endian fix in ems_usb from Sebastian Haas.

12) Randomized MAC address is busted in forcedeth driver, use the
    standard interface we provide to do this to fix it.  From
    Stanislav O. Bezzubtsev.

13) Missing driver license tag in fsl_pq_mdio driver leads to taint,
    from Sebastian Siewior.

14) All of bridging code assumes 6 byte addressing, like ethernet,
    so make sure we don't allow configuring bridging on devices that
    use something else otherwise we'll explode.  Fix from Stephen
    Hemminger.

15) Add some new IDs to cdc_ether, from Torgny Johansson.

16) DaVinci EMAC driver passes wrong device pointer to IRQ handler
    from ->poll_controller(), from Tonyliu.

17) SCTP bug fixes pertaining to source address handling and a regression
    added by the new sctp_conntectx APIs, from Vlad Yasevich.

18) CAN protocol must provide ->get_stats_size() and ->get_xstats_size()
    netlink callbacks, from Wolfgang Grandegger.

19) IXGBE's ->gso_max_size setting is wrong in some circumstances.  Also
    TXOFF status checking is busted when DCB is enabled.  Both from
    Yi Zou.

20) NAT bug fix from Jozsef Kadlecsik.  xt_connlimit regression fix
    from Jan Engelhardt.

21) Non-linear SKBs causes crashes in multilink PPP receive, fix from
    Ben McKeegan.

22) Bluetooth fixes via Marcel Holtmann.

23) Bit shift defines in ibm_newemac driver are completely wrong,
    fix from Dave Mitchell.

Please pull, thanks a lot!

The following changes since commit 7c9abfb884b8737f0afdc8a88bcea77526f0da87:
  Linus Torvalds (1):
        Merge branch 'kvm-updates/2.6.32' of git://git.kernel.org/pub/scm/virt/kvm/kvm

are available in the git repository at:

  master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.git master

Ajit Khaparde (2):
      be2net: fix to set proper flow control on resume
      be2net: Bug fix to send config commands to hardware after netdev_register

Andrei Emeltchenko (1):
      Bluetooth: Set general bonding security for ACL by default

Ben McKeegan (1):
      ppp: fix BUG on non-linear SKB (multilink receive)

Bing Zhao (2):
      Libertas: coding style cleanup in ethtool.c
      Libertas: fix issues while configuring host sleep using ethtool wol

Bob Copeland (3):
      ath5k: don't reset mcast filter when configuring the mode
      ath5k: add LED support for HP Compaq CQ60
      ath5k: add LED definition for BenQ Joybook R55v

Breno Leitao (2):
      s2io: fixing a ethtool test that is broken
      ixgbe: Fixing EEH handler to handle more than one error

Dan Carpenter (2):
      misdn: Fix reversed 'if' in st_own_ctrl
      ipmr: missing dev_put() on error path in vif_add()

Dave Mitchell (1):
      ibm_newemac: Fix EMACx_TRTR[TRT] bit shifts

David S. Miller (5):
      Merge branch 'master' of git://git.kernel.org/.../linville/wireless-2.6
      Merge branch 'master' of git://git.kernel.org/.../holtmann/bluetooth-2.6
      Revert "isdn: isdn_ppp: Use SKB list facilities instead of home-grown implementation."
      Merge branch 'master' of git://git.kernel.org/.../linville/wireless-2.6
      sungem: Fix Serdes detection.

Divy Le Ray (1):
      cxgb3: fix premature page unmap

Don Skidmore (1):
      ixgbe: fix traffic hangs on Tx with ioatdma loaded

Eric Dumazet (5):
      rose: device refcount leak
      decnet: netdevice refcount leak
      can: should not use __dev_get_by_index() without locks
      net: Fix the rollback test in dev_change_name()
      vlan: Fix register_vlan_dev() error path

Felix Fietkau (1):
      b43: work around a locking issue in ->set_tim()

Finn Thain (1):
      macsonic: fix crash on PowerBook 520

Florian Fainelli (1):
      r6040: fix version printing

Gertjan van Wingerde (1):
      rt2x00: Update MAINTAINERS

Gustavo F. Padovan (2):
      Bluetooth: Select Basic Mode as default for SOCK_SEQPACKET
      Bluetooth: Fix regression with L2CAP configuration in Basic Mode

Herbert Xu (2):
      ipip: Fix handling of DF packets when pmtudisc is OFF
      gro: Fix illegal merging of trailer trash

Ilpo Järvinen (1):
      tcp: provide more information on the tcp receive_queue bugs

Ivo van Doorn (1):
      rt2x00: update MAINTAINERS

Jan Engelhardt (1):
      netfilter: xt_connlimit: fix regression caused by zero family value

Jiri Slaby (4):
      isdn: hisax: Fix lock imbalance.
      isdn: eicon: Use offsetof
      isdn: eicon: Return on error
      NET: cassini, fix lock imbalance

Joe Perches (2):
      MAINTAINERS: Add git net-next-2.6
      MAINTAINERS: RFKILL - Fix pattern entry missing colon

John W. Linville (2):
      Revert "ipw2200: fix oops on missing firmware"
      Revert "libipw: initiate cfg80211 API conversion"

Jozsef Kadlecsik (1):
      netfilter: nf_nat: fix NAT issue in 2.6.30.4+

Larry Finger (3):
      rtl8187: Fix kernel oops when device is removed when LEDS enabled
      rtl8187: Fix sparse warnings
      p54usb: Remove DMA buffer from stack

Martin Fuzzey (1):
      ssb-pcmcia: Fix 32bit register access in early bus scanning

Martin Michlmayr (1):
      hisax: remove bad udelay call to fix build error on ARM

Oliver Hartkopp (1):
      can: Fix driver Kconfig structure

Raimonds Cicans (1):
      r8169: Fix receive buffer length when MTU is between 1515 and 1536

Roel Kluin (3):
      isdn: hisax: Fix test in waitforxfw
      isdn: hfc_usb: Fix read buffer overflow
      mISDN: fix error return in HFCmulti_init()

Ron Mercer (2):
      qlge: Fix early exit from mbox cmd complete wait.
      qlge: Set PCIe reset type for EEH to fundamental.

Sathya Perla (1):
      be2net: Fix CQE_STATUS_EXTD_SHIFT define

Sean Cross (1):
      rt2x00: Don't queue ieee80211 work after USB removal

Sebastian Haas (1):
      ems_usb: Fix byte order issues on big endian machines

Sebastian Siewior (1):
      net/fsl_pq_mdio: add module license GPL

Sriram (2):
      smsc911x: Fix Console Hang when bringing the interface down.
      TI Davinci EMAC : Fix Console Hang when bringing the interface down

Stanislav O. Bezzubtsev (1):
      forcedeth: mac address fix

Stephen Hemminger (1):
      bridge: prevent bridging wrong device

Stephen Rothwell (1):
      net: fix mdio section mismatch warning

Tonyliu (1):
      DaVinci EMAC: correct param for ISR

Torgny Johansson (1):
      cdc_ether: additional Ericsson MBM PID's to the whitelist

Uwe Kleine-König (1):
      virtio_net: rename driver struct to please modpost

Vlad Yasevich (3):
      sctp: Set source addresses on the association before adding transports
      sctp: Fix regression introduced by new sctp_connectx api
      sctp: Set socket source address when additing first transport

Wey-Yi Guy (2):
      iwlwifi: Use RTS/CTS as the preferred protection mechanism for 6000 series
      iwlwifi: Fix issue on file transfer stalled in HT mode

Wolfgang Grandegger (2):
      can: fix WARN_ON dump in net/core/rtnetlink.c:rtmsg_ifinfo()
      can: add the missing netlink get_xstats_size callback

Yi Zou (2):
      ixgbe: Fix gso_max_size for 82599 when DCB is enabled
      ixgbe: Fix checking TFCS register for TXOFF status when DCB is enabled

 MAINTAINERS                                   |    5 +-
 drivers/isdn/hardware/eicon/maintidi.c        |    5 +-
 drivers/isdn/hardware/eicon/message.c         |   18 +-
 drivers/isdn/hardware/mISDN/hfcmulti.c        |    2 +-
 drivers/isdn/hisax/amd7930_fn.c               |    1 +
 drivers/isdn/hisax/diva.c                     |    2 +-
 drivers/isdn/hisax/elsa_ser.c                 |   22 +-
 drivers/isdn/hisax/hfc_usb.c                  |    4 +-
 drivers/isdn/hisax/hscx_irq.c                 |    2 +-
 drivers/isdn/hisax/icc.c                      |    1 +
 drivers/isdn/i4l/isdn_ppp.c                   |  352 ++++++++++++-------------
 drivers/isdn/mISDN/stack.c                    |    2 +-
 drivers/net/benet/be.h                        |    2 +
 drivers/net/benet/be_cmds.h                   |    2 +-
 drivers/net/benet/be_ethtool.c                |    8 +-
 drivers/net/benet/be_main.c                   |   28 ++-
 drivers/net/can/Kconfig                       |   60 +----
 drivers/net/can/dev.c                         |   23 ++
 drivers/net/can/sja1000/Kconfig               |   47 ++++
 drivers/net/can/usb/Kconfig                   |   10 +
 drivers/net/can/usb/Makefile                  |    2 +
 drivers/net/can/usb/ems_usb.c                 |    5 +-
 drivers/net/cassini.c                         |    5 +-
 drivers/net/cxgb3/sge.c                       |    4 +-
 drivers/net/davinci_emac.c                    |    5 +-
 drivers/net/forcedeth.c                       |    5 +-
 drivers/net/fsl_pq_mdio.c                     |    1 +
 drivers/net/ibm_newemac/emac.h                |    4 +-
 drivers/net/ixgbe/ixgbe_main.c                |   85 ++++++-
 drivers/net/macsonic.c                        |  117 +++++----
 drivers/net/phy/mdio-gpio.c                   |    2 +-
 drivers/net/ppp_generic.c                     |   11 +-
 drivers/net/qlge/qlge_main.c                  |    2 +
 drivers/net/qlge/qlge_mpi.c                   |    2 +-
 drivers/net/r6040.c                           |    2 +-
 drivers/net/r8169.c                           |    4 +-
 drivers/net/s2io.c                            |    1 +
 drivers/net/smsc911x.c                        |    2 +-
 drivers/net/sungem.c                          |   10 +-
 drivers/net/usb/Kconfig                       |    2 +-
 drivers/net/usb/cdc_ether.c                   |   42 +++-
 drivers/net/virtio_net.c                      |    6 +-
 drivers/net/wireless/ath/ath5k/base.c         |    1 -
 drivers/net/wireless/ath/ath5k/led.c          |    4 +
 drivers/net/wireless/b43/main.c               |    3 +-
 drivers/net/wireless/ipw2x00/ipw2100.c        |   11 +-
 drivers/net/wireless/ipw2x00/ipw2200.c        |  143 ++--------
 drivers/net/wireless/ipw2x00/libipw.h         |    9 +-
 drivers/net/wireless/ipw2x00/libipw_module.c  |   46 +---
 drivers/net/wireless/iwlwifi/iwl-1000.c       |    1 +
 drivers/net/wireless/iwlwifi/iwl-6000.c       |    5 +
 drivers/net/wireless/iwlwifi/iwl-agn-rs.c     |    9 +
 drivers/net/wireless/iwlwifi/iwl-agn.c        |   10 +-
 drivers/net/wireless/iwlwifi/iwl-core.h       |    2 +
 drivers/net/wireless/libertas/ethtool.c       |   17 +-
 drivers/net/wireless/p54/p54usb.c             |   10 +-
 drivers/net/wireless/rt2x00/rt2x00dev.c       |    4 +-
 drivers/net/wireless/rt2x00/rt2x00link.c      |   11 +-
 drivers/net/wireless/rt2x00/rt2x00usb.c       |    9 +-
 drivers/net/wireless/rtl818x/rtl8187_leds.c   |    4 +-
 drivers/net/wireless/rtl818x/rtl8187_rfkill.c |    1 +
 drivers/ssb/scan.c                            |    6 +-
 include/linux/isdn_ppp.h                      |    2 +-
 include/net/netfilter/nf_conntrack.h          |    8 +-
 include/net/netfilter/nf_nat_helper.h         |    4 +
 include/net/sctp/structs.h                    |    2 +-
 net/8021q/vlan.c                              |    7 +-
 net/bluetooth/hci_conn.c                      |    1 +
 net/bluetooth/l2cap.c                         |   13 +-
 net/bridge/br_if.c                            |    6 +-
 net/can/bcm.c                                 |   19 +-
 net/core/dev.c                                |   11 +-
 net/core/skbuff.c                             |    3 +-
 net/decnet/sysctl_net_decnet.c                |    7 +-
 net/ipv4/ipip.c                               |   32 ++-
 net/ipv4/ipmr.c                               |    4 +-
 net/ipv4/netfilter/nf_nat_core.c              |    3 +
 net/ipv4/netfilter/nf_nat_helper.c            |   34 ++-
 net/ipv4/tcp.c                                |   19 +-
 net/netfilter/nf_conntrack_core.c             |    8 +
 net/netfilter/nf_conntrack_proto_tcp.c        |   64 ++---
 net/netfilter/xt_connlimit.c                  |   10 +-
 net/rose/rose_route.c                         |   16 +-
 net/sctp/associola.c                          |    4 +-
 net/sctp/sm_statefuns.c                       |   15 +-
 net/sctp/socket.c                             |   40 ++-
 net/sctp/transport.c                          |    3 +-
 87 files changed, 834 insertions(+), 722 deletions(-)
 create mode 100644 drivers/net/can/sja1000/Kconfig
 create mode 100644 drivers/net/can/usb/Kconfig

^ permalink raw reply


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox