* Re: tulip : kernel BUG in tulip_up/tulip_resume
From: Jarek Poplawski @ 2009-11-29 11:36 UTC (permalink / raw)
To: Philippe De Muyter; +Cc: grundler, kyle, netdev, linux-kernel
In-Reply-To: <20091129001710.GA4055@ami.dom.local>
On Sun, Nov 29, 2009 at 01:17:10AM +0100, Jarek Poplawski wrote:
> Philippe De Muyter wrote, On 11/08/2009 11:33 PM:
> > Does someone know what could be wrong and have a fix or should I look myself ?
>
> Don't know, guess only...
...And maybe a second guess btw. (to try together or separate).
Jarek P.
---
diff --git a/drivers/net/tulip/tulip_core.c b/drivers/net/tulip/tulip_core.c
index 6b2330e..fd32601 100644
--- a/drivers/net/tulip/tulip_core.c
+++ b/drivers/net/tulip/tulip_core.c
@@ -1749,9 +1749,9 @@ static int tulip_suspend (struct pci_dev *pdev, pm_message_t state)
if (!netif_running(dev))
goto save_state;
+ netif_device_detach(dev);
tulip_down(dev);
- netif_device_detach(dev);
free_irq(dev->irq, dev);
save_state:
^ permalink raw reply related
* Re: [ethtool PATCH] ethtool: Add Direct Attach to the available connector ports
From: Jeff Garzik @ 2009-11-29 11:03 UTC (permalink / raw)
To: Jeff Kirsher; +Cc: davem, shemminger, netdev, gospo, Peter P Waskiewicz Jr
In-Reply-To: <20091125101315.24481.11759.stgit@localhost.localdomain>
On 11/25/2009 05:13 AM, Jeff Kirsher wrote:
> From: PJ Waskiewicz<peter.p.waskiewicz.jr@intel.com>
>
> This adds Direct Attach SFP+ types to the connector ports
> for the GSET mode.
>
> Signed-off-by: Peter P Waskiewicz Jr<peter.p.waskiewicz.jr@intel.com>
> Signed-off-by: Jeff Kirsher<jeffrey.t.kirsher@intel.com>
> ---
>
> ethtool-copy.h | 3 +++
> ethtool.c | 6 ++++++
> 2 files changed, 9 insertions(+), 0 deletions(-)
applied
^ permalink raw reply
* Re: [ethtool PATCH] ethtool: Add Direct Attach to the available connector ports
From: Jeff Garzik @ 2009-11-29 10:42 UTC (permalink / raw)
To: David Miller
Cc: jeffrey.t.kirsher, shemminger, netdev, gospo,
peter.p.waskiewicz.jr
In-Reply-To: <20091129.003601.253425360.davem@davemloft.net>
On 11/29/2009 03:36 AM, David Miller wrote:
> From: Jeff Kirsher<jeffrey.t.kirsher@intel.com>
> Date: Wed, 25 Nov 2009 02:13:15 -0800
>
>> From: PJ Waskiewicz<peter.p.waskiewicz.jr@intel.com>
>>
>> This adds Direct Attach SFP+ types to the connector ports
>> for the GSET mode.
>>
>> Signed-off-by: Peter P Waskiewicz Jr<peter.p.waskiewicz.jr@intel.com>
>> Signed-off-by: Jeff Kirsher<jeffrey.t.kirsher@intel.com>
>
> Jeff Garzik, ping?
These days, unless I have some massive objection, I merge stuff into
ethtool when the kernel bits hit net-next. ethtool should be current as
of net-next 24 hrs ago.
I queued the ethtool patch in $subject, and was waiting on your kernel
merge verdict.
> Also, do you plan on doing any ethtool releases this century? :-)
I've been trying to think of what would be a good versioning scheme for
ethtool. Even though it is [essentially] a user-friendly kernel
interface, its releases have never really been closely synchronized with
the kernel releases. And unlike a lot of other software, ethtool is so
simple it does not really go through any release-candidate or beta period.
The current scheme just increments a release number: 5->6, 6->7, etc.
But with so few kernel releases (and thus ethtool releases), I was
leaning towards either yearly release naming ("ethtool-2009"), kernel
release naming ("ethtool-2.6.33"), or the release scheme proposed for
glibc: snapshot directly from the git repository.
If people want one, I could do a release right now. Or, we could move
to an alternate scheme like git snapshots. I think git snapshots are
viable because ethtool has historically had next to zero bugs in the
actual userland utility. Fedora already imports git snapshots, for example.
Preferences?
Jeff
^ permalink raw reply
* MERGE check, net-next-2.6...
From: David Miller @ 2009-11-29 9:17 UTC (permalink / raw)
To: netdev; +Cc: jeffrey.t.kirsher, linville, amit
I just merged net-2.6 into net-next-2.6, there were several
conflicts.
They happened in e1000e, ath9k, generic ieee80211, and the
netxen driver.
Please check my work and send any necessary fixes.
Thanks!
^ permalink raw reply
* Re: [PATCH net-next-2.6] pktgen: NUMA aware
From: David Miller @ 2009-11-29 8:44 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev, andi
In-Reply-To: <4B0D46AE.3070700@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 25 Nov 2009 16:01:02 +0100
> [PATCH net-next-2.6] pktgen: NUMA aware
>
> pktgen threads are bound to given CPU, we can allocate memory for
> these threads in a NUMA aware way.
>
> After a pktgen session on two threads, we can check flows memory was
> allocated on right node, instead of a not related one.
>
> # grep pktgen_thread_write /proc/vmallocinfo
> 0xffffc90007204000-0xffffc90007385000 1576960 pktgen_thread_write+0x3a4/0x6b0 [pktgen] pages=384 vmalloc N0=384
> 0xffffc90007386000-0xffffc90007507000 1576960 pktgen_thread_write+0x3a4/0x6b0 [pktgen] pages=384 vmalloc N1=384
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks Eric.
^ permalink raw reply
* Re: [ethtool PATCH] ethtool: Add Direct Attach to the available connector ports
From: David Miller @ 2009-11-29 8:36 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: jeff, shemminger, netdev, gospo, peter.p.waskiewicz.jr
In-Reply-To: <20091125101315.24481.11759.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 25 Nov 2009 02:13:15 -0800
> From: PJ Waskiewicz <peter.p.waskiewicz.jr@intel.com>
>
> This adds Direct Attach SFP+ types to the connector ports
> for the GSET mode.
>
> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Jeff Garzik, ping?
Also, do you plan on doing any ethtool releases this century? :-)
^ permalink raw reply
* Re: [net-next-2.6 PATCH 2/2] ixgbe: Display currently attached PHY through ethtool
From: David Miller @ 2009-11-29 8:35 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: jeff, shemminger, netdev, gospo, peter.p.waskiewicz.jr
In-Reply-To: <20091125101153.24430.45252.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 25 Nov 2009 02:11:54 -0800
> From: PJ Waskiewicz <peter.p.waskiewicz.jr@intel.com>
>
> This patch extends the ethtool interface to display what PHY
> is currently connected to a NIC. The results can be viewed in
> ethtool ethX output.
>
> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 1/2] ethtool: Add Direct Attach support to connector port reporting
From: David Miller @ 2009-11-29 8:35 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: jeff, shemminger, netdev, gospo, peter.p.waskiewicz.jr
In-Reply-To: <20091125101128.24430.89112.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 25 Nov 2009 02:11:30 -0800
> From: PJ Waskiewicz <peter.p.waskiewicz.jr@intel.com>
>
> This patch allows a base driver to specify Direct Attach as the
> type of port through the ethtool interface.
>
> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 4/4] ixgbe: Fix Receive Address Register (RAR) cleaning and accounting
From: David Miller @ 2009-11-29 8:34 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, shannon.nelson, peter.p.waskiewicz.jr
In-Reply-To: <20091125045209.23932.59410.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Tue, 24 Nov 2009 20:52:10 -0800
> From: Shannon Nelson <shannon.nelson@intel.com>
>
> This fixes an issue when clearing out the RAR entries. If RAR[0]
> is the only address in use, don't clear the others.
>
> Signed-off-by: Shannon Nelson <shannon.nelson@intel.com>
> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 3/4] ixgbe: LINKS2 is not a valid register for 82598
From: David Miller @ 2009-11-29 8:34 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, donald.c.skidmore, peter.p.waskiewicz.jr
In-Reply-To: <20091125045147.23932.39966.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Tue, 24 Nov 2009 20:51:48 -0800
> From: Don Skidmore <donald.c.skidmore@intel.com>
>
> 82598 shouldn't try and access LINKS2 while configuring
> link and flow control. This is an 82599-only register.
>
> Signed-off-by: Don Skidmore <donald.c.skidmore@intel.com>
> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 2/4] ixgbe: Disable Flow Control for certain devices
From: David Miller @ 2009-11-29 8:34 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, peter.p.waskiewicz.jr
In-Reply-To: <20091125045127.23932.79040.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Tue, 24 Nov 2009 20:51:28 -0800
> From: PJ Waskiewicz <peter.p.waskiewicz.jr@intel.com>
>
> Flow Control autoneg should be disabled for certain adapters
> that don't support autonegotiation of Flow Control at 10 gigabit.
> These interfaces are the 10GBASE-T devices, CX4, and SFP+, all
> running at 10 gigabit only. 1 gigabit is fine.
>
> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 1/4] ixgbe: handle parameters for tx and rx EITR, no div0
From: David Miller @ 2009-11-29 8:34 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, jesse.brandeburg, shannon.nelson
In-Reply-To: <20091125045059.23932.10997.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Tue, 24 Nov 2009 20:51:06 -0800
> From: Shannon Nelson <shannon.nelson@intel.com>
>
> The driver was doing a divide by zero when adjusting tx-usecs.
> This patch removes the divide by zero code and changes the logic slightly
> to ignore tx-usecs in the case of shared TxRx vectors.
>
> Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Signed-off-by: Shannon Nelson <shannon.nelson@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: dmfe/tulip device id overlap
From: David Miller @ 2009-11-29 8:30 UTC (permalink / raw)
To: grundler; +Cc: brandon, tobias, kyle, netdev, grundler
In-Reply-To: <da824cf30911250924i31f77033r7f60027ed74b2cd@mail.gmail.com>
From: Grant Grundler <grundler@google.com>
Date: Wed, 25 Nov 2009 09:24:54 -0800
> I'm ok with this patch except the mention of Ubuntu in the comment is
> superfluous. All the distro's will share this problem. I trust davem
> to rewrite the comment and plase add my:
> Signed-off-by: Grant Grundler <grundler@parisc-linux.org>
Please remove the comment and the __sparc__ ifdef.
If tulip doesn't work on some sparc systems we simply need to fix it.
Thanks.
^ permalink raw reply
* Re: [PATCH] r8169: restore mac addr in rtl8169_remove_one and rtl_shutdown
From: David Miller @ 2009-11-29 8:21 UTC (permalink / raw)
To: ivecera; +Cc: netdev, romieu
In-Reply-To: <1259087166-14558-1-git-send-email-ivecera@redhat.com>
From: Ivan Vecera <ivecera@redhat.com>
Date: Tue, 24 Nov 2009 19:26:06 +0100
> The newer chipsets (all PCI-E) are known that they need full power cycle
> (AC or battery removal) to reset MAC address to a hardwired one. Previous
> patch to address this problem loads the original MAC address from EEPROM.
> But it brought other problem for which it is necessary to introduce a new
> module parameter.
> However, it might suffice to restore the initial MAC address before
> shutdown/reboot/kexec and when removing the module.
>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Francois, any comments?
^ permalink raw reply
* Re: [PATCH] NET: smc91x: convert to dev_pm_ops
From: David Miller @ 2009-11-29 8:21 UTC (permalink / raw)
To: nico; +Cc: khilman, netdev, linux-kernel
In-Reply-To: <alpine.LFD.2.00.0911242012500.2059@xanadu.home>
From: Nicolas Pitre <nico@fluxnic.net>
Date: Tue, 24 Nov 2009 20:13:15 -0500 (EST)
> On Tue, 24 Nov 2009, Kevin Hilman wrote:
>
>> Convert smc91x driver from legacy PM hooks over to using dev_pm_ops.
>>
>> Tested on OMAP3 platform.
>>
>> Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
>
> Acked-by: Nicolas Pitre <nico@fluxnic.net>
Applied to net-next-2.6, thanks.
^ permalink raw reply
* Re: ixgbe question
From: David Miller @ 2009-11-29 8:18 UTC (permalink / raw)
To: john.r.fastabend
Cc: peter.p.waskiewicz.jr, eric.dumazet, robert, hawk, netdev
In-Reply-To: <4B0BDC24.1060401@intel.com>
From: John Fastabend <john.r.fastabend@intel.com>
Date: Tue, 24 Nov 2009 13:14:12 +0000
> Believe the below patch will break DCB and FCoE though, both features
> have the potential to set real_num_tx_queues to greater then the
> number of CPUs. This could result in real_num_tx_queues >
> num_tx_queues.
>
> The current solution isn't that great though, maybe we should set to
> the minimum of MAX_TX_QUEUES and num_possible_cpus() * 2 + 8.
>
> That should cover the maximum possible queues for DCB, FCoE and their
> combinations.
>
> general multiq = num_possible_cpus()
> DCB = 8 tx queue's
> FCoE = 2*num_possible_cpus()
> FCoE + DCB = 8 tx queues + num_possible_cpus
Eric, I'm tossing your patch because of this problem, just FYI.
^ permalink raw reply
* Re: [patch]reset_resume for cdc-ether
From: David Miller @ 2009-11-29 8:18 UTC (permalink / raw)
To: oliver; +Cc: david-b, netdev, linux-usb
In-Reply-To: <200911241159.02098.oliver@neukum.org>
From: Oliver Neukum <oliver@neukum.org>
Date: Tue, 24 Nov 2009 11:59:02 +0100
> commit 31deb426ccea8faf91f4373c1f12c98bb0d82c73
> Author: Oliver Neukum <oliver@neukum.org>
> Date: Tue Nov 24 08:30:41 2009 +0100
>
> cdc-ether:imlement reset_resume()
>
> Normal resume can do double duty as reset_resume() for this driver
David B., ACK, NACK, indifferent?
^ permalink raw reply
* Re: pull request: SCTP updates for net-next
From: David Miller @ 2009-11-29 8:17 UTC (permalink / raw)
To: vladislav.yasevich; +Cc: linux-sctp, netdev
In-Reply-To: <4B0AF96A.3050709@hp.com>
From: Vlad Yasevich <vladislav.yasevich@hp.com>
Date: Mon, 23 Nov 2009 16:06:50 -0500
> Hi David
>
> Here is a set of SCTP patches for net-next. Please pull.
>
> The following changes since commit dc63d3771cc6492220f53caf5fded6090d45d9ce:
> Alexander Duyck (1):
> ixgbe: Only set/clear VFE in ixgbe_set_rx_mode
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/vxy/lksctp-dev.git net-next
Pulled, thanks a lot Vlad.
^ permalink raw reply
* Re: [PATCH] sctp: on T3_RTX retransmit all the in-flight chunks
From: David Miller @ 2009-11-29 8:15 UTC (permalink / raw)
To: vladislav.yasevich; +Cc: netdev, linux-sctp, andrei
In-Reply-To: <1259004833-23267-1-git-send-email-vladislav.yasevich@hp.com>
From: Vlad Yasevich <vladislav.yasevich@hp.com>
Date: Mon, 23 Nov 2009 14:33:53 -0500
> Signed-off-by: Andrei Pelinescu-Onciul <andrei@iptel.org>
> Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Applied to net-2.6, thanks.
^ permalink raw reply
* Re: [PATCH 12/12] sfc: Clean up RX event handling
From: David Miller @ 2009-11-29 8:01 UTC (permalink / raw)
To: bhutchings; +Cc: netdev, linux-net-drivers
In-Reply-To: <1259422589.3709.13.camel@localhost>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Sat, 28 Nov 2009 15:36:29 +0000
> Add 'likely' hint to test of rx_checksum_enabled.
> Don't count IP fragments; the IP stack can do that.
> Do count non-matching multicast packets.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Applied.
^ permalink raw reply
* Re: [PATCH 11/12] sfc: Allow for additional checksum offload features
From: David Miller @ 2009-11-29 8:01 UTC (permalink / raw)
To: bhutchings; +Cc: netdev, linux-net-drivers
In-Reply-To: <1259422579.3709.12.camel@localhost>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Sat, 28 Nov 2009 15:36:19 +0000
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
You can add this patch when you actually have a chance in your
set that adds a value of ->offload_features other than NETIF_IP_CSUM.
So I'm setting aside this change for now, resubmit it along with
the change that actually needs to use different values.
Thanks.
^ permalink raw reply
* Re: [PATCH 10/12] sfc: Move descriptor cache base addresses to struct efx_nic_type
From: David Miller @ 2009-11-29 8:00 UTC (permalink / raw)
To: bhutchings; +Cc: netdev, linux-net-drivers
In-Reply-To: <1259422572.3709.11.camel@localhost>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Sat, 28 Nov 2009 15:36:12 +0000
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Applied.
^ permalink raw reply
* Re: [PATCH 09/12] sfc: Decouple NIC revision number from Falcon PCI revision number
From: David Miller @ 2009-11-29 7:59 UTC (permalink / raw)
To: bhutchings; +Cc: netdev, linux-net-drivers
In-Reply-To: <1259422564.3709.10.camel@localhost>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Sat, 28 Nov 2009 15:36:04 +0000
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Applied.
^ permalink raw reply
* Re: [PATCH 08/12] sfc: Remove some redundant whitespace
From: David Miller @ 2009-11-29 7:59 UTC (permalink / raw)
To: bhutchings; +Cc: netdev, linux-net-drivers
In-Reply-To: <1259422536.3709.9.camel@localhost>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Sat, 28 Nov 2009 15:35:36 +0000
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Applied.
^ permalink raw reply
* Re: [PATCH 07/12] sfc: Remove another unused workaround macro
From: David Miller @ 2009-11-29 7:59 UTC (permalink / raw)
To: bhutchings; +Cc: netdev, linux-net-drivers
In-Reply-To: <1259422530.3709.8.camel@localhost>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Sat, 28 Nov 2009 15:35:30 +0000
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Applied.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox