* Re: [PATCH net-next-2.6] net: use helpers to access uc list
From: David Miller @ 2010-01-25 10:06 UTC (permalink / raw)
To: jpirko; +Cc: netdev
In-Reply-To: <20100125083450.GA2902@psychotron.redhat.com>
From: Jiri Pirko <jpirko@redhat.com>
Date: Mon, 25 Jan 2010 09:34:52 +0100
> Well I use "unsigned char *" as iterator because it would allow
> smooth thansition to list_head in case of mc_list. Currently "struct
> dev_addr_list" is used to store address in the list but in the end
> "struct netdev_hw_addr *" will be used. To use "struct list_head *"
> or "struct netdev_hw_addr *" as an iterator it would be needed to
> convert all drivers at once and that's not doable. Therefore I see
> "unsigned char *" cursor as the best option.
But it's not what you want to use in the end, at all.
If you're going to use a very ugly and opaque iterator type merely to
ease transition, that's not a good reason.
^ permalink raw reply
* Re: [PATCH net-next-2.6] net: use helpers to access uc list
From: Jiri Pirko @ 2010-01-25 8:34 UTC (permalink / raw)
To: David Miller; +Cc: netdev
In-Reply-To: <20100124.230251.177086043.davem@davemloft.net>
Mon, Jan 25, 2010 at 08:02:51AM CET, davem@davemloft.net wrote:
>From: Jiri Pirko <jpirko@redhat.com>
>Date: Sun, 24 Jan 2010 11:42:45 +0100
>
>> +#define netdev_uc_count(dev) ((dev)->uc.count)
>> +
>> +#define netdev_get_list_by_addr(a) \
>> + (container_of((void *) a, struct netdev_hw_addr, addr)->list)
>> +
>> +#define netdev_get_addr_by_list(l) \
>> + (list_entry(l, struct netdev_hw_addr, list)->addr)
>> +
>> +#define netdev_for_each_addr(a, head) \
>> + for (a = netdev_get_addr_by_list((head)->next); \
>> + prefetch(netdev_get_list_by_addr(a).next), \
>> + &netdev_get_list_by_addr(a) != (head); \
>> + a = netdev_get_addr_by_list(netdev_get_list_by_addr(a).next))
>> +
>> +#define netdev_for_each_uc_addr(a, dev) \
>> + netdev_for_each_addr(a, &dev->uc.list)
>> +
>
>I should have mentioned this the other day, but I don't like
>having "unsigned char *" being the type of the element iterator.
>
>Sure it allows you, I guess, to eliminate one local variable
>in the places the iterate, but it definitely is at the cost
>of aestetics.
>
>Please use some normal iterating object for the iterator, such as
>"struct list_head *" or "struct netdev_hw_addr *". Probably the
>latter would work best.
Well I use "unsigned char *" as iterator because it would allow smooth thansition
to list_head in case of mc_list. Currently "struct dev_addr_list" is used to
store address in the list but in the end "struct netdev_hw_addr *" will be used.
To use "struct list_head *" or "struct netdev_hw_addr *" as an iterator it would
be needed to convert all drivers at once and that's not doable. Therefore I see
"unsigned char *" cursor as the best option.
Jirka
>
^ permalink raw reply
* Re: [PATCH v2]IP: Send an ICMP "Fragment Reassembly Timeout" message when enabling connection track
From: Shan Wei @ 2010-01-25 8:18 UTC (permalink / raw)
To: Patrick McHardy; +Cc: David Miller, netdev@vger.kernel.org, netfilter-devel
In-Reply-To: <4B599084.1060406@trash.net>
Patrick McHardy wrote, at 01/22/2010 07:48 PM:
> Looks good to me. Would you mind adding a similar change to IPv6
> (net/ipv6/netfilter/nf_conntrack_reasm.c)?
Sorry to reply to you so late.
I'm grade to send a patch to change IPv6 conntrack.
I also find that reassembly queues of IPv6 conntrack are broken
when be initialed by ip6_frag_init(). After testing, I will send all patches.
--
Best Regards
-----
Shan Wei
^ permalink raw reply
* Re: Problems Receiving UDP Broadcasts on Some Versions of Linux
From: Eric Dumazet @ 2010-01-25 8:10 UTC (permalink / raw)
To: Curt Sampson, linux-kernel, Linux Netdev List
In-Reply-To: <20100125072749.GG21419@analytic.cynic.net>
Le 25/01/2010 08:27, Curt Sampson a écrit :
> I'm posting this here because it smells as if it may be something
> a where a kernel network code developer might just say, "oh yeah,
> obviously your problem is this."
>
> I'm not subscribed to this list, so please cc me on any replies. (The
> Mail-followup-to header may do this automatically for you.)
>
> The short summary is that on two very similar servers on the same
> network, an application that listens for broadcast UDP packets on a
> given port works fine on the Ubuntu 8.04/Linux 2.6.24-26-server box but
> does not receive the packets on the Ubuntu 9.04/Linux 2.6.28-17-server
> box. I have confirmed that tcpdump sees identical packets being received
> on both hosts.
>
> Did something change between these two kernel revisions that I need to
> listen differently?
>
> Full details, including sample code, are available at:
>
> http://stackoverflow.com/questions/2130563/udp-broadcast-reception-problems-with-ubuntu-9-04-but-not-8-04
>
> Thanks for any help you can give me. Even if you're not sure, but have
> clues I should consider following up, feel free to e-mail me. I'm
> also happy to take pointers to kernel code I should read, if there's
> enlightenment there.
>
> cjs
Hi Curt
Could you post a sample of tcpdump trafic you receive on the 9.04 host, and your network config ?
"ifconfig -a"
^ permalink raw reply
* Re: [PATCH net-next-2.6] net: use helpers to access uc list
From: David Miller @ 2010-01-25 7:02 UTC (permalink / raw)
To: jpirko; +Cc: netdev
In-Reply-To: <20100124104239.GA21371@psychotron.redhat.com>
From: Jiri Pirko <jpirko@redhat.com>
Date: Sun, 24 Jan 2010 11:42:45 +0100
> +#define netdev_uc_count(dev) ((dev)->uc.count)
> +
> +#define netdev_get_list_by_addr(a) \
> + (container_of((void *) a, struct netdev_hw_addr, addr)->list)
> +
> +#define netdev_get_addr_by_list(l) \
> + (list_entry(l, struct netdev_hw_addr, list)->addr)
> +
> +#define netdev_for_each_addr(a, head) \
> + for (a = netdev_get_addr_by_list((head)->next); \
> + prefetch(netdev_get_list_by_addr(a).next), \
> + &netdev_get_list_by_addr(a) != (head); \
> + a = netdev_get_addr_by_list(netdev_get_list_by_addr(a).next))
> +
> +#define netdev_for_each_uc_addr(a, dev) \
> + netdev_for_each_addr(a, &dev->uc.list)
> +
I should have mentioned this the other day, but I don't like
having "unsigned char *" being the type of the element iterator.
Sure it allows you, I guess, to eliminate one local variable
in the places the iterate, but it definitely is at the cost
of aestetics.
Please use some normal iterating object for the iterator, such as
"struct list_head *" or "struct netdev_hw_addr *". Probably the
latter would work best.
^ permalink raw reply
* Re: [PATCH] netns xfrm: deal with dst entries in netns
From: David Miller @ 2010-01-25 6:48 UTC (permalink / raw)
To: adobriyan; +Cc: herbert, netdev
In-Reply-To: <20100124154014.GA6124@x200>
From: Alexey Dobriyan <adobriyan@gmail.com>
Date: Sun, 24 Jan 2010 17:40:14 +0200
> GC is non-existent in netns, so after you hit GC threshold, no new
> dst entries will be created until someone triggers cleanup in init_net.
>
> Make xfrm4_dst_ops and xfrm6_dst_ops per-netns.
> This is not done in a generic way, because it woule waste
> (AF_MAX - 2) * sizeof(struct dst_ops) bytes per-netns.
>
> Reorder GC threshold initialization so it'd be done before registering
> XFRM policies.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Applied, thanks Alexey.
^ permalink raw reply
* Re: [PATCH] tcp_probe: avoid modulus operation and wrap fix
From: David Miller @ 2010-01-25 6:41 UTC (permalink / raw)
To: shemminger; +Cc: netdev
In-Reply-To: <20100124215001.78251e25@nehalam>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Sun, 24 Jan 2010 21:50:01 -0800
> @@ -75,12 +75,12 @@ static struct {
>
> static inline int tcp_probe_used(void)
> {
> - return (tcp_probe.head - tcp_probe.tail) % bufsize;
> + return (tcp_probe.head - tcp_probe.tail) & (bufsize - 1);
> }
>
> static inline int tcp_probe_avail(void)
> {
> - return bufsize - tcp_probe_used();
> + return bufsize - tcp_probe_used() - 1;
> }
>
> /*
Hmmm... When the ring is full head==tail, which means
tcp_probe_used() returns 0. Which would now make tcp_probe_avail()
return "bufsize - 0 - 1".
Is that right?
^ permalink raw reply
* Re: [PATCH] sky2: revert config space change
From: David Miller @ 2010-01-25 6:36 UTC (permalink / raw)
To: shemminger; +Cc: rjw, tino.keitel, netdev, linux-kernel
In-Reply-To: <20100124204606.2760d34e@nehalam>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Sun, 24 Jan 2010 20:46:06 -0800
> Obviously, this register had some other impact that is causing
> the regression. Either it is masking some other access or needs
> to be reset in some path.
>
> Either, way it is best to just revert the change for 2.6.33
>
>
> This reverts commit 166a0fd4c788ec7f10ca8194ec6d526afa12db75.
I'll apply this, thanks Stephen.
^ permalink raw reply
* Re: [net-next-2.6 PATCH] ixgbe: only process one ixgbe_watchdog_task at a time.
From: John Fastabend @ 2010-01-25 6:24 UTC (permalink / raw)
To: David Miller; +Cc: Kirsher, Jeffrey T, netdev@vger.kernel.org, gospo@redhat.com
In-Reply-To: <20100123.021941.134608202.davem@davemloft.net>
David Miller wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Date: Sat, 23 Jan 2010 02:17:31 -0800
>
>
>> diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
>> index 8d206f7..cbc62db 100644
>> --- a/drivers/net/ixgbe/ixgbe_main.c
>> +++ b/drivers/net/ixgbe/ixgbe_main.c
>> @@ -5013,7 +5013,8 @@ static void ixgbe_watchdog_task(struct work_struct *work)
>> struct ixgbe_ring *tx_ring;
>> int some_tx_pending = 0;
>>
>> - adapter->flags |= IXGBE_FLAG_IN_WATCHDOG_TASK;
>> + while (test_and_set_bit(__IXGBE_IN_WATCHDOG_TASK, &adapter->state))
>> + msleep(1);
>>
>>
>
> I think using a mutex() would better serve you here.
>
I'll make this change and resubmit. Thanks.
^ permalink raw reply
* [PATCH] tcp_probe: avoid modulus operation and wrap fix
From: Stephen Hemminger @ 2010-01-25 5:50 UTC (permalink / raw)
To: David Miller; +Cc: netdev
By rounding up the buffer size to power of 2, several expensive
modulus operations can be avoided. This patch also solves a bug where
the gap need when ring gets full was not being accounted for.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/net/ipv4/tcp_probe.c 2010-01-24 21:43:07.069894439 -0800
+++ b/net/ipv4/tcp_probe.c 2010-01-24 21:46:15.301153066 -0800
@@ -39,9 +39,9 @@ static int port __read_mostly = 0;
MODULE_PARM_DESC(port, "Port to match (0=all)");
module_param(port, int, 0);
-static int bufsize __read_mostly = 4096;
+static unsigned int bufsize __read_mostly = 4096;
MODULE_PARM_DESC(bufsize, "Log buffer size in packets (4096)");
-module_param(bufsize, int, 0);
+module_param(bufsize, uint, 0);
static int full __read_mostly;
MODULE_PARM_DESC(full, "Full log (1=every ack packet received, 0=only cwnd changes)");
@@ -75,12 +75,12 @@ static struct {
static inline int tcp_probe_used(void)
{
- return (tcp_probe.head - tcp_probe.tail) % bufsize;
+ return (tcp_probe.head - tcp_probe.tail) & (bufsize - 1);
}
static inline int tcp_probe_avail(void)
{
- return bufsize - tcp_probe_used();
+ return bufsize - tcp_probe_used() - 1;
}
/*
@@ -116,7 +116,7 @@ static int jtcp_rcv_established(struct s
p->ssthresh = tcp_current_ssthresh(sk);
p->srtt = tp->srtt >> 3;
- tcp_probe.head = (tcp_probe.head + 1) % bufsize;
+ tcp_probe.head = (tcp_probe.head + 1) & (bufsize - 1);
}
tcp_probe.lastcwnd = tp->snd_cwnd;
spin_unlock(&tcp_probe.lock);
@@ -149,7 +149,7 @@ static int tcpprobe_open(struct inode *
static int tcpprobe_sprint(char *tbuf, int n)
{
const struct tcp_log *p
- = tcp_probe.log + tcp_probe.tail % bufsize;
+ = tcp_probe.log + tcp_probe.tail;
struct timespec tv
= ktime_to_timespec(ktime_sub(p->tstamp, tcp_probe.start));
@@ -192,7 +192,7 @@ static ssize_t tcpprobe_read(struct file
width = tcpprobe_sprint(tbuf, sizeof(tbuf));
if (cnt + width < len)
- tcp_probe.tail = (tcp_probe.tail + 1) % bufsize;
+ tcp_probe.tail = (tcp_probe.tail + 1) & (bufsize - 1);
spin_unlock_bh(&tcp_probe.lock);
@@ -222,9 +222,10 @@ static __init int tcpprobe_init(void)
init_waitqueue_head(&tcp_probe.wait);
spin_lock_init(&tcp_probe.lock);
- if (bufsize < 0)
+ if (bufsize == 0)
return -EINVAL;
+ bufsize = roundup_pow_of_two(bufsize);
tcp_probe.log = kcalloc(bufsize, sizeof(struct tcp_log), GFP_KERNEL);
if (!tcp_probe.log)
goto err0;
@@ -236,7 +237,7 @@ static __init int tcpprobe_init(void)
if (ret)
goto err1;
- pr_info("TCP probe registered (port=%d)\n", port);
+ pr_info("TCP probe registered (port=%d) bufsize=%u\n", port, bufsize);
return 0;
err1:
proc_net_remove(&init_net, procname);
^ permalink raw reply
* RE: Bug#565404: linux-image-2.6.26-2-amd64: atl1e: TSO is broken
From: Jie Yang @ 2010-01-25 5:41 UTC (permalink / raw)
To: Anders Boström
Cc: ben@decadent.org.uk, netdev@vger.kernel.org,
565404@bugs.debian.org, Xiong Huang
In-Reply-To: <20100121.174247.769487074466946522.anders@netinsight.net>
Anders Boström <anders@netinsight.net> wrote:
> Cc: ben@decadent.org.uk; netdev@vger.kernel.org;
> 565404@bugs.debian.org; Xiong Huang
> Subject: Re: Bug#565404: linux-image-2.6.26-2-amd64: atl1e:
> TSO is broken
> One strange observation is that I can only reproduce this
> problem when transmitting data from a NFS-server using TCP
> with Atheros AR8121/AR8113/AR8114.
>
> I've tried to reproduce the problem using test-programs, like
> nttcp and netpipe, without any success. One observation is
> that the test-programs *only* generates 1500 bytes
> IP-packets. When the NFS-server sends data, a sequence of
> 1500 bytes IP-packets are generated, ending with a shorter
> packet. And this last packet in the sequence has 1500 in the
> IP-header length field, but is shorter.
>
following is my test cese,
a nfs server server with ar8131chip, device id 1063. export /tmp/ dir as the nfs share directory,
the client, mount the server_ip:/tmp to local dir /mnt/nfs, ust a python script to write and read data on the
/mnt/nfs/testnfs.log. it works fine.
Can you give me some advice on how to reproduce this bug??
Best wishes
jie
^ permalink raw reply
* [PATCH] sky2: revert config space change
From: Stephen Hemminger @ 2010-01-25 4:46 UTC (permalink / raw)
To: Rafael J. Wysocki, David S. Miller
Cc: Tino Keitel, netdev, linux-kernel, netdev
In-Reply-To: <201001242135.29309.rjw@sisk.pl>
Obviously, this register had some other impact that is causing
the regression. Either it is masking some other access or needs
to be reset in some path.
Either, way it is best to just revert the change for 2.6.33
This reverts commit 166a0fd4c788ec7f10ca8194ec6d526afa12db75.
---
drivers/net/sky2.c | 13 +++++++++++++
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c
index f8f50f7..64b441c 100644
--- a/drivers/net/sky2.c
+++ b/drivers/net/sky2.c
@@ -644,6 +644,7 @@ static void sky2_phy_power_up(struct sky2_hw *hw, unsigned port)
{
u32 reg1;
+ sky2_write8(hw, B2_TST_CTRL1, TST_CFG_WRITE_ON);
reg1 = sky2_pci_read32(hw, PCI_DEV_REG1);
reg1 &= ~phy_power[port];
@@ -651,6 +652,7 @@ static void sky2_phy_power_up(struct sky2_hw *hw, unsigned port)
reg1 |= coma_mode[port];
sky2_pci_write32(hw, PCI_DEV_REG1, reg1);
+ sky2_write8(hw, B2_TST_CTRL1, TST_CFG_WRITE_OFF);
sky2_pci_read32(hw, PCI_DEV_REG1);
if (hw->chip_id == CHIP_ID_YUKON_FE)
@@ -707,9 +709,11 @@ static void sky2_phy_power_down(struct sky2_hw *hw, unsigned port)
gm_phy_write(hw, port, PHY_MARV_CTRL, PHY_CT_PDOWN);
}
+ sky2_write8(hw, B2_TST_CTRL1, TST_CFG_WRITE_ON);
reg1 = sky2_pci_read32(hw, PCI_DEV_REG1);
reg1 |= phy_power[port]; /* set PHY to PowerDown/COMA Mode */
sky2_pci_write32(hw, PCI_DEV_REG1, reg1);
+ sky2_write8(hw, B2_TST_CTRL1, TST_CFG_WRITE_OFF);
}
/* Force a renegotiation */
@@ -2149,7 +2153,9 @@ static void sky2_qlink_intr(struct sky2_hw *hw)
/* reset PHY Link Detect */
phy = sky2_pci_read16(hw, PSM_CONFIG_REG4);
+ sky2_write8(hw, B2_TST_CTRL1, TST_CFG_WRITE_ON);
sky2_pci_write16(hw, PSM_CONFIG_REG4, phy | 1);
+ sky2_write8(hw, B2_TST_CTRL1, TST_CFG_WRITE_OFF);
sky2_link_up(sky2);
}
@@ -2640,6 +2646,7 @@ static void sky2_hw_intr(struct sky2_hw *hw)
if (status & (Y2_IS_MST_ERR | Y2_IS_IRQ_STAT)) {
u16 pci_err;
+ sky2_write8(hw, B2_TST_CTRL1, TST_CFG_WRITE_ON);
pci_err = sky2_pci_read16(hw, PCI_STATUS);
if (net_ratelimit())
dev_err(&pdev->dev, "PCI hardware error (0x%x)\n",
@@ -2647,12 +2654,14 @@ static void sky2_hw_intr(struct sky2_hw *hw)
sky2_pci_write16(hw, PCI_STATUS,
pci_err | PCI_STATUS_ERROR_BITS);
+ sky2_write8(hw, B2_TST_CTRL1, TST_CFG_WRITE_OFF);
}
if (status & Y2_IS_PCI_EXP) {
/* PCI-Express uncorrectable Error occurred */
u32 err;
+ sky2_write8(hw, B2_TST_CTRL1, TST_CFG_WRITE_ON);
err = sky2_read32(hw, Y2_CFG_AER + PCI_ERR_UNCOR_STATUS);
sky2_write32(hw, Y2_CFG_AER + PCI_ERR_UNCOR_STATUS,
0xfffffffful);
@@ -2660,6 +2669,7 @@ static void sky2_hw_intr(struct sky2_hw *hw)
dev_err(&pdev->dev, "PCI Express error (0x%x)\n", err);
sky2_read32(hw, Y2_CFG_AER + PCI_ERR_UNCOR_STATUS);
+ sky2_write8(hw, B2_TST_CTRL1, TST_CFG_WRITE_OFF);
}
if (status & Y2_HWE_L1_MASK)
@@ -3038,6 +3048,7 @@ static void sky2_reset(struct sky2_hw *hw)
}
sky2_power_on(hw);
+ sky2_write8(hw, B2_TST_CTRL1, TST_CFG_WRITE_OFF);
for (i = 0; i < hw->ports; i++) {
sky2_write8(hw, SK_REG(i, GMAC_LINK_CTRL), GMLC_RST_SET);
@@ -3074,6 +3085,7 @@ static void sky2_reset(struct sky2_hw *hw)
reg <<= PSM_CONFIG_REG4_TIMER_PHY_LINK_DETECT_BASE;
/* reset PHY Link Detect */
+ sky2_write8(hw, B2_TST_CTRL1, TST_CFG_WRITE_ON);
sky2_pci_write16(hw, PSM_CONFIG_REG4,
reg | PSM_CONFIG_REG4_RST_PHY_LINK_DETECT);
sky2_pci_write16(hw, PSM_CONFIG_REG4, reg);
@@ -3091,6 +3103,7 @@ static void sky2_reset(struct sky2_hw *hw)
/* restore the PCIe Link Control register */
sky2_pci_write16(hw, cap + PCI_EXP_LNKCTL, reg);
}
+ sky2_write8(hw, B2_TST_CTRL1, TST_CFG_WRITE_OFF);
/* re-enable PEX PM in PEX PHY debug reg. 8 (clear bit 12) */
sky2_write32(hw, Y2_PEX_PHY_DATA, PEX_DB_ACCESS | (0x08UL << 16));
--
1.6.3.3
^ permalink raw reply related
* Re: Regression: Wake on LAN doesn't work in sky2 with 2.6.33-rc4-git2
From: Stephen Hemminger @ 2010-01-25 4:42 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Tino Keitel, netdev, linux-kernel, David S. Miller
In-Reply-To: <201001242135.29309.rjw@sisk.pl>
On Sun, 24 Jan 2010 21:35:29 +0100
"Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> On Tuesday 19 January 2010, Tino Keitel wrote:
> > On Tue, Jan 19, 2010 at 10:51:05 -0800, Stephen Hemminger wrote:
> > > Is this better worse or the same? It make sure that some
> > > registers are set on resume that might matter.
> >
> > I see not difference.
>
> Hmm. Perhaps it's better to revert commit 166a0fd4c788ec7f10ca8194ec6d526afa12db75
> for now, so that 2.6.33 works on the Tino's machine, and figure out why it
> broke the WoL before (eventually) re-applying it?
>
> Rafael
Agreed
--
^ permalink raw reply
* Re: [PATCH] vlan: fix vlan_skb_recv()
From: David Miller @ 2010-01-25 3:52 UTC (permalink / raw)
To: eric.dumazet; +Cc: bonbons, xiyou.wangcong, netdev, linux-kernel
In-Reply-To: <4B5CA2CA.4040307@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sun, 24 Jan 2010 20:43:06 +0100
> [PATCH] vlan: fix vlan_skb_recv()
>
> Bruno Prémont found commit 9793241fe92f7d930
> (vlan: Precise RX stats accounting) added a regression for non
> hw accelerated vlans.
>
> [ 26.390576] BUG: unable to handle kernel NULL pointer dereference at (null)
> [ 26.396369] IP: [<df856b89>] vlan_skb_recv+0x89/0x280 [8021q]
>
> vlan_dev_info() was used with original device, instead of
> skb->dev. Also spotted by Américo Wang.
>
> Reported-By: Bruno Prémont <bonbons@linux-vserver.org>
> Tested-By: Bruno Prémont <bonbons@linux-vserver.org>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks everyone.
^ permalink raw reply
* Re: [PATCH v2]IP: Send an ICMP "Fragment Reassembly Timeout" message when enabling connection track
From: Yasuyuki KOZAKAI @ 2010-01-25 0:57 UTC (permalink / raw)
To: kaber
Cc: shanwei, davem, kuznet, pekkas, jmorris, yoshfuji, eric.dumazet,
david, jorge, opurdila, netdev, netfilter-devel
In-Reply-To: <4B599084.1060406@trash.net>
Hi,
From: Patrick McHardy <kaber@trash.net>
Date: Fri, 22 Jan 2010 12:48:20 +0100
> Shan Wei wrote:
> > [PATCH v2]IP: Send an ICMP "Fragment Reassembly Timeout" message when enabling connection track
> >
> > No matter whether connection track is enabled, an end host should send
> > an ICMPv4 "Fragment Reassembly Timeout" message when defrag timeout.
> > The reasons are following two points:
> >
> > 1. RFC 792 says:
> > >>>> >> > > If a host reassembling a fragmented datagram cannot complete the
> > >>>> >> > > reassembly due to missing fragments within its time limit it
> > >>>> >> > > discards the datagram, and it may send a time exceeded message.
> > >>>> >> > >
> > >>>> >> > > If fragment zero is not available then no time exceeded need be
> > >>>> >> > > sent at all.
> > >>>> >> > >
> > >>>> >> > > Read more: http://www.faqs.org/rfcs/rfc792.html#ixzz0aOXRD7Wp
> >
> > 2. Patrick McHardy also agrees with this opinion. :-)
> > About the discussion of this opinion, refer to http://patchwork.ozlabs.org/patch/41649
> >
> > The patch fixed the problem like this:
> > When enabling connection track, fragments are received at PRE_ROUTING HOOK.
> > If they are failed to reassemble, ip_expire() will be called.
> > Before sending an ICMP "Fragment Reassembly Timeout" message,
> > the patch searches router table to get the destination entry only for host type.
> >
> > The patch has been tested on both host type and route type.
>
> Looks good to me. Would you mind adding a similar change to IPv6
> (net/ipv6/netfilter/nf_conntrack_reasm.c)?
It sounds good. Please take care that IPv6 router does not reassemble
fragmented packets. IIRC the current nf_conntrack_{ipv6,reasm}.c
reassembles the cloned skbs for tracking, discard the cloned skbs after
tracking and forward the original skbs to IPv6 stack to keep the size of
fragmented packets.
-- Yasuyuki Kozakai
^ permalink raw reply
* [PATCH] tc: add new queue discipline: head drop fifo
From: Hagen Paul Pfeifer @ 2010-01-24 22:31 UTC (permalink / raw)
To: netdev; +Cc: shemminger
This adds the required changes to gain access to
the head drop classfull queuing discipline named
pfifo_head_drop. In difference to pfifo or pfifo_fast
this queuing discipline will drop the first packet
in the case of queue congestion. As a result the queue
contain always the freshest packets.
To replace the current a root queueing discipline
for eth0:
$ tc qdisc replace dev eth0 root pfifo_head_drop
And show statistics:
$ tc -s qdisc show dev eth0
Signed-off-by: Hagen Paul Pfeifer <hagen@jauu.net>
---
tc/q_fifo.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/tc/q_fifo.c b/tc/q_fifo.c
index f561752..6242a98 100644
--- a/tc/q_fifo.c
+++ b/tc/q_fifo.c
@@ -25,7 +25,7 @@
static void explain(void)
{
- fprintf(stderr, "Usage: ... [p|b]fifo [ limit NUMBER ]\n");
+ fprintf(stderr, "Usage: ... <[p|b]fifo | pfifo_head_drop> [ limit NUMBER ]\n");
}
static int fifo_parse_opt(struct qdisc_util *qu, int argc, char **argv, struct nlmsghdr *n)
@@ -89,6 +89,12 @@ struct qdisc_util pfifo_qdisc_util = {
.print_qopt = fifo_print_opt,
};
+struct qdisc_util pfifo_head_drop_qdisc_util = {
+ .id = "pfifo_head_drop",
+ .parse_qopt = fifo_parse_opt,
+ .print_qopt = fifo_print_opt,
+};
+
extern int prio_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt);
struct qdisc_util pfifo_fast_qdisc_util = {
.id = "pfifo_fast",
--
1.6.6.196.g1f735.dirty
^ permalink raw reply related
* [PATCH] sched: add head drop fifo queue
From: Hagen Paul Pfeifer @ 2010-01-24 22:30 UTC (permalink / raw)
To: netdev; +Cc: kaber, davem
This adds an additional queuing strategy, called pfifo_head_drop,
to remove the oldest skb in the case of an overflow within the queue -
the head element - instead of the last skb (tail). To remove the oldest
skb in congested situations is useful for sensor network environments
where newer packets reflect the superior information.
Reviewed-by: Florian Westphal <fw@strlen.de>
Acked-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: Hagen Paul Pfeifer <hagen@jauu.net>
---
include/net/pkt_sched.h | 1 +
include/net/sch_generic.h | 19 +++++++++++++++++++
net/sched/sch_api.c | 1 +
net/sched/sch_fifo.c | 34 ++++++++++++++++++++++++++++++++++
4 files changed, 55 insertions(+), 0 deletions(-)
diff --git a/include/net/pkt_sched.h b/include/net/pkt_sched.h
index 2d56726..b6cdc33 100644
--- a/include/net/pkt_sched.h
+++ b/include/net/pkt_sched.h
@@ -71,6 +71,7 @@ extern void qdisc_watchdog_cancel(struct qdisc_watchdog *wd);
extern struct Qdisc_ops pfifo_qdisc_ops;
extern struct Qdisc_ops bfifo_qdisc_ops;
+extern struct Qdisc_ops pfifo_head_drop_qdisc_ops;
extern int fifo_set_limit(struct Qdisc *q, unsigned int limit);
extern struct Qdisc *fifo_create_dflt(struct Qdisc *sch, struct Qdisc_ops *ops,
diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h
index dad558b..67dc08e 100644
--- a/include/net/sch_generic.h
+++ b/include/net/sch_generic.h
@@ -427,6 +427,25 @@ static inline struct sk_buff *qdisc_dequeue_head(struct Qdisc *sch)
return __qdisc_dequeue_head(sch, &sch->q);
}
+static inline unsigned int __qdisc_queue_drop_head(struct Qdisc *sch,
+ struct sk_buff_head *list)
+{
+ struct sk_buff *skb = __qdisc_dequeue_head(sch, list);
+
+ if (likely(skb != NULL)) {
+ unsigned int len = qdisc_pkt_len(skb);
+ kfree_skb(skb);
+ return len;
+ }
+
+ return 0;
+}
+
+static inline unsigned int qdisc_queue_drop_head(struct Qdisc *sch)
+{
+ return __qdisc_queue_drop_head(sch, &sch->q);
+}
+
static inline struct sk_buff *__qdisc_dequeue_tail(struct Qdisc *sch,
struct sk_buff_head *list)
{
diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
index 75fd1c6..6cd4910 100644
--- a/net/sched/sch_api.c
+++ b/net/sched/sch_api.c
@@ -1707,6 +1707,7 @@ static int __init pktsched_init(void)
{
register_qdisc(&pfifo_qdisc_ops);
register_qdisc(&bfifo_qdisc_ops);
+ register_qdisc(&pfifo_head_drop_qdisc_ops);
register_qdisc(&mq_qdisc_ops);
proc_net_fops_create(&init_net, "psched", 0, &psched_fops);
diff --git a/net/sched/sch_fifo.c b/net/sched/sch_fifo.c
index 69188e8..4b0a6cc 100644
--- a/net/sched/sch_fifo.c
+++ b/net/sched/sch_fifo.c
@@ -43,6 +43,26 @@ static int pfifo_enqueue(struct sk_buff *skb, struct Qdisc* sch)
return qdisc_reshape_fail(skb, sch);
}
+static int pfifo_tail_enqueue(struct sk_buff *skb, struct Qdisc* sch)
+{
+ struct sk_buff *skb_head;
+ struct fifo_sched_data *q = qdisc_priv(sch);
+
+ if (likely(skb_queue_len(&sch->q) < q->limit))
+ return qdisc_enqueue_tail(skb, sch);
+
+ /* queue full, remove one skb to fulfill the limit */
+ skb_head = qdisc_dequeue_head(sch);
+ sch->bstats.bytes -= qdisc_pkt_len(skb_head);
+ sch->bstats.packets--;
+ sch->qstats.drops++;
+ kfree_skb(skb_head);
+
+ qdisc_enqueue_tail(skb, sch);
+
+ return NET_XMIT_CN;
+}
+
static int fifo_init(struct Qdisc *sch, struct nlattr *opt)
{
struct fifo_sched_data *q = qdisc_priv(sch);
@@ -108,6 +128,20 @@ struct Qdisc_ops bfifo_qdisc_ops __read_mostly = {
};
EXPORT_SYMBOL(bfifo_qdisc_ops);
+struct Qdisc_ops pfifo_head_drop_qdisc_ops __read_mostly = {
+ .id = "pfifo_head_drop",
+ .priv_size = sizeof(struct fifo_sched_data),
+ .enqueue = pfifo_tail_enqueue,
+ .dequeue = qdisc_dequeue_head,
+ .peek = qdisc_peek_head,
+ .drop = qdisc_queue_drop_head,
+ .init = fifo_init,
+ .reset = qdisc_reset_queue,
+ .change = fifo_init,
+ .dump = fifo_dump,
+ .owner = THIS_MODULE,
+};
+
/* Pass size change message down to embedded FIFO */
int fifo_set_limit(struct Qdisc *q, unsigned int limit)
{
--
1.6.6.196.g1f735.dirty
^ permalink raw reply related
* 2.6.33-rc5: Reported regressions 2.6.31 -> 2.6.32
From: Rafael J. Wysocki @ 2010-01-24 22:15 UTC (permalink / raw)
To: Linux Kernel Mailing List
Cc: Andrew Morton, Linus Torvalds, Natalie Protasevich,
Kernel Testers List, Network Development, Linux ACPI,
Linux PM List, Linux SCSI List, Linux Wireless List, DRI
[NOTES:
* This is worrisome. Regressions from 2.6.31 are still being reported and we
are not fixing them. Even the ones that have been bisected don't seem to
be taken care of.]
This message contains a list of some regressions introduced between 2.6.31 and
2.6.32, for which there are no fixes in the mainline I know of. If any of them
have been fixed already, please let me know.
If you know of any other unresolved regressions introduced between 2.6.31
and 2.6.32, please let me know either and I'll add them to the list.
Also, please let me know if any of the entries below are invalid.
Each entry from the list will be sent additionally in an automatic reply to
this message with CCs to the people involved in reporting and handling the
issue.
Listed regressions statistics:
Date Total Pending Unresolved
----------------------------------------
2010-01-24 140 45 43
2010-01-10 130 44 40
2009-12-29 124 60 57
2009-11-21 86 29 25
2009-11-16 84 46 41
2009-10-26 66 42 37
2009-10-12 48 31 27
2009-10-02 22 15 9
Unresolved regressions
----------------------
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15135
Subject : Kernel 2.6.32.x hangs during boot process
Submitter : François Figarola <francois.figarola-lUrpeit6/WqB4Ue4x7It+g@public.gmane.org>
Date : 2010-01-16 9:58 (9 days old)
References : http://marc.info/?l=linux-kernel&m=126363593817261&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15127
Subject : Bluetooth: sleeping function called from invalid context
Submitter : David John <davidjon-XRr60H37pjdAfugRpC6u6w@public.gmane.org>
Date : 2010-01-12 9:19 (13 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=9e726b17422bade75fba94e625cd35fd1353e682
References : http://marc.info/?l=linux-kernel&m=126328727021949&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15096
Subject : Resume lock up -- bisected, commit 3a1151e3f124fd1a2c54b8153f510f1a7c715369
Submitter : Rafał Miłecki <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-01-20 23:15 (5 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15071
Subject : IBM/Lenovo Trackpoint speed, sensitivity reset after suspend if set via sysfs
Submitter : Marten Vance <kernel-srgEi2D3yJHR7s880joybQ@public.gmane.org>
Date : 2010-01-16 16:19 (9 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15042
Subject : socket(PF_INET6 hangs when ipv6 not yet initialized
Submitter : Marc Haber <mh+linux-kernel-ciUMMiFYEj8OIzVOb1FTxg@public.gmane.org>
Date : 2010-01-10 14:28 (15 days old)
References : http://marc.info/?l=linux-kernel&m=126313553029280&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15021
Subject : agpgart sometimes fails to initialize sometimes
Submitter : Maciej Piechotka <uzytkownik2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-01-09 23:31 (16 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15015
Subject : blank screen at random times in laptop when sitting idle
Submitter : Jithin Emmanuel <jithin1987-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-01-09 16:48 (16 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15004
Subject : i915: *ERROR* Execbuf while wedged
Submitter : tomas m <tmezzadra-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-01-07 18:53 (18 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14998
Subject : Caught 32-bit read from uninitialized memory in acpi_system_read_event
Submitter : Christian Casteyde <casteyde.christian-GANU6spQydw@public.gmane.org>
Date : 2010-01-06 21:40 (19 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14997
Subject : Closing and re-opening the lid does not reactivate the backlight
Submitter : o. meijer <meijer.o-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-01-06 15:38 (19 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14943
Subject : nfs regression?
Submitter : Nikola Ciprich <extmaillist-Jp3n8lUXroTtwjQa/ONI9g@public.gmane.org>
Date : 2009-12-28 12:10 (28 days old)
References : http://marc.info/?l=linux-kernel&m=126200276223524&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14939
Subject : drm: random hang with i915
Submitter : Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Date : 2009-12-07 17:30 (49 days old)
References : http://marc.info/?l=linux-kernel&m=126020704125723&w=4
Handled-By : Jesse Barnes <jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14933
Subject : OOM killer unexpectedly called
Submitter : A. Boulan <arnaud.boulan-TDf4sKD1mxeHlu7OokbhRg@public.gmane.org>
Date : 2009-12-24 23:42 (32 days old)
References : http://marc.info/?l=linux-kernel&m=126169821317492&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14922
Subject : 2.6.32 seemed to have broken nVidia MCP7A sata controller
Submitter : Mike Cui <cuicui-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2009-12-19 6:13 (37 days old)
References : http://marc.info/?l=linux-ide&m=126120323407742&w=4
Handled-By : Jeff Garzik <jeff-o2qLIJkoznsdnm+yROfE0A@public.gmane.org>
Robert Hancock <hancockrwd-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14898
Subject : ksoftirqd problem
Submitter : Nico <segfault2-PkbjNfxxIARBDgjK7y7TUQ@public.gmane.org>
Date : 2009-12-13 19:05 (43 days old)
References : http://marc.info/?l=linux-kernel&m=126073114325690&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14897
Subject : i915: Commit 0e442c60 causes flickering
Submitter : David John <davidjon-XRr60H37pjdAfugRpC6u6w@public.gmane.org>
Date : 2009-12-09 17:26 (47 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=0e442c60dd39ac6924b11a20497734bd2303744c
References : http://marc.info/?l=linux-kernel&m=126037889600769&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14895
Subject : BUG in kernel 2.6.32 when using luks encrypted root and RAID0..
Submitter : r4 <mk_4-aRb0bU7PRFPrBKCeMvbIDA@public.gmane.org>
Date : 2009-12-03 18:24 (53 days old)
References : http://marc.info/?l=linux-kernel&m=125986664904751&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14894
Subject : pohmelfs: NULL pointer dereference
Submitter : Alexander Beregalov <a.beregalov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2009-12-02 1:11 (54 days old)
References : http://marc.info/?l=linux-kernel&m=125971633107940&w=4
Handled-By : Evgeniy Polyakov <zbr-i6C2adt8DTjR7s880joybQ@public.gmane.org>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14891
Subject : Deadlock regression related to NFS root
Submitter : Stephen R. van den Berg <srb-PCMv+cxZuL0@public.gmane.org>
Date : 2009-11-24 0:24 (62 days old)
References : http://marc.info/?l=linux-kernel&m=125902279909452&w=4
Handled-By : Trond Myklebust <Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14886
Subject : Asus P2B-DS not detected as SMP moterboard
Submitter : Lorenzo Buzzi <flinco-VGgt2q2+T+FeoWH0uzbU5w@public.gmane.org>
Date : 2009-12-27 17:20 (29 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14868
Subject : flood of "don't try to register things with the same name in the same directory." on upgrade to 2.6.32
Submitter : Rich Ercolani <rercola-YxllIAoeIHiVc3sceRu5cw@public.gmane.org>
Date : 2009-12-24 02:44 (32 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14817
Subject : When is system under load, then freeze/HD fail
Submitter : okias <d.okias-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2009-12-15 11:12 (41 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14783
Subject : Unhandled IRQ on Thinkpad R61i: "irq 16: nobody cared"
Submitter : Stefan Zegenhagen <sz-QdrG9jWwCLEAvxtiuMwx3w@public.gmane.org>
Date : 2009-12-10 19:14 (46 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14782
Subject : Suspend hangs Lenovo SL300 after gdm login
Submitter : Gary Trakhman <gary.trakhman-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2009-12-10 18:53 (46 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=03ba3782e8dcc5b0e1efe440d33084f066e38cae
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14748
Subject : e1000e NIC not working after reboot
Submitter : Maciek Sitarz <macieks-yngNwrTfnRnVItvQsEIGlw@public.gmane.org>
Date : 2009-12-06 13:04 (50 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14742
Subject : 2.6.32 new menu idle governor causes very high CPU temp
Submitter : <akwatts-DaQTI0RpDDMAvxtiuMwx3w@public.gmane.org>
Date : 2009-12-05 17:24 (51 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14695
Subject : regression in karmic thermal control
Submitter : Bugie <public-ZA6dAAr5zYM@public.gmane.org>
Date : 2009-11-26 08:45 (60 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14670
Subject : i915: playing video via XVideo extension makes the screen flicker
Submitter : Thomas Meyer <thomas-VsYtu1Qij5c@public.gmane.org>
Date : 2009-11-23 13:15 (63 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=b42d4c5c6a872815d711e5d51a600f5122c38eee
References : http://lkml.org/lkml/2010/1/11/150
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14667
Subject : bisected 2.6.32 EC regression - Temperatures not correctly detected after suspend - Dell Studio XPS 16 laptop
Submitter : Federico Chiacchiaretta <federico.chia-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2009-11-22 20:42 (64 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14657
Subject : perf subsystem breakage in 2.6.32-rc7
Submitter : Arjan van de Ven <arjan-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Date : 2009-11-19 19:50 (67 days old)
References : http://marc.info/?l=linux-kernel&m=125866013419738&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14656
Subject : Oops at __rmqueue+0x98 with 2.6.32-rc6
Submitter : Lucas C. Villa Real <lucasvr-9gmU7qdNRpmhPH1hqNUYSQ@public.gmane.org>
Date : 2009-11-19 3:48 (67 days old)
References : http://marc.info/?l=linux-kernel&m=125860255229092&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14625
Subject : Commit d451564 breaks ARM
Submitter : Russell King <rmk+lkml-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
Date : 2009-11-13 15:11 (73 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=d4515646699b6ad7b1a98ceb871296b957f3ef47
References : http://marc.info/?l=linux-kernel&m=125812520315835&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14624
Subject : ath9k: BUG kmalloc-8192: Poison overwritten
Submitter : Miles Lane <miles.lane-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2009-11-12 4:58 (74 days old)
References : http://marc.info/?l=linux-kernel&m=125800196520396&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14621
Subject : specjbb2005 and aim7 regression with 2.6.32-rc kernels
Submitter : Zhang, Yanmin <yanmin_zhang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Date : 2009-11-06 7:38 (80 days old)
References : http://marc.info/?l=linux-kernel&m=125749310413174&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14504
Subject : intermittent hibernation problem again
Submitter : Ferenc Wágner <wferi-eEbw3PyuezQ@public.gmane.org>
Date : 2009-10-28 23:49 (89 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14487
Subject : PANIC: early exception 08 rip 246:10 error ffffffff810251b5 cr2 0
Submitter : Justin P. Mattock <justinmattock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2009-10-23 16:45 (94 days old)
References : http://lkml.org/lkml/2009/10/23/252
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14482
Subject : kernel BUG at fs/dcache.c:670 +lvm +md +ext3
Submitter : Alexander Clouter <alex-L4GPcECwBoDe9xe1eoZjHA@public.gmane.org>
Date : 2009-10-23 10:30 (94 days old)
References : http://lkml.org/lkml/2009/10/23/50
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14442
Subject : resume after hibernate: /dev/sdb drops and returns as /dev/sde
Submitter : Duncan <1i5t5.duncan-j9pdmedNgrk@public.gmane.org>
Date : 2009-10-20 01:52 (97 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14426
Subject : CE: hpet increasing min_delta_ns flood
Submitter : Thibault Mondary <thibm-GANU6spQydw@public.gmane.org>
Date : 2009-10-17 09:29 (100 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14417
Subject : [Regression] Wireless driver iwlagn+iwlcore doesn't work after resume (needs reloading)
Submitter : Eddy Petrișor <eddy.petrisor+linbug-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2009-10-16 11:07 (101 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14376
Subject : Kernel NULL pointer dereference/ kvm subsystem
Submitter : Don Dupuis <dondster-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2009-10-06 14:38 (111 days old)
References : http://marc.info/?l=linux-kernel&m=125484025021737&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14298
Subject : warning at manage.c:361 (set_irq_wake), matrix-keypad related?
Submitter : Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
Date : 2009-09-30 20:07 (117 days old)
References : http://marc.info/?l=linux-kernel&m=125434130703538&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14297
Subject : console resume broken since ba15ab0e8d
Submitter : Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Date : 2009-09-30 15:11 (117 days old)
References : http://marc.info/?l=linux-kernel&m=125432349404060&w=4
Regressions with patches
------------------------
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15134
Subject : gobi_loader hangs after commit 8e8dce065088
Submitter : Matthew Garrett <mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
Date : 2010-01-17 2:55 (8 days old)
References : http://marc.info/?l=linux-kernel&m=126369696509502&w=4
Handled-By : Oliver Neukum <oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
Alan Cox <alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>
Patch : http://patchwork.kernel.org/patch/73878/
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15040
Subject : High cpu temperature with 2.6.32
Submitter : Dimitrios Apostolou <jimis-hi6Y0CQ0nG0@public.gmane.org>
Date : 2010-01-06 17:39 (19 days old)
References : http://marc.info/?l=linux-kernel&m=126279952723036&w=4
Handled-By : Arjan van de Ven <arjan-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Patch : http://patchwork.kernel.org/patch/71962/
For details, please visit the bug entries and follow the links given in
references.
As you can see, there is a Bugzilla entry for each of the listed regressions.
There also is a Bugzilla entry used for tracking the regressions introduced
between 2.6.31 and 2.6.32, unresolved as well as resolved, at:
http://bugzilla.kernel.org/show_bug.cgi?id=14230
Please let me know if there are any Bugzilla entries that should be added to
the list in there.
Thanks,
Rafael
^ permalink raw reply
* 2.6.33-rc5: Reported regressions from 2.6.32
From: Rafael J. Wysocki @ 2010-01-24 21:54 UTC (permalink / raw)
To: Linux Kernel Mailing List
Cc: Adrian Bunk, Andrew Morton, Linus Torvalds, Natalie Protasevich,
Kernel Testers List, Network Development, Linux ACPI,
Linux PM List, Linux SCSI List, Linux Wireless List, DRI
This message contains a list of some regressions from 2.6.32, for which there
are no fixes in the mainline I know of. If any of them have been fixed already,
please let me know.
If you know of any other unresolved regressions from 2.6.32, please let me know
either and I'll add them to the list. Also, please let me know if any of the
entries below are invalid.
Each entry from the list will be sent additionally in an automatic reply to
this message with CCs to the people involved in reporting and handling the
issue.
Listed regressions statistics:
Date Total Pending Unresolved
----------------------------------------
2010-01-24 75 29 23
2010-01-10 55 33 21
2009-12-29 36 34 27
Unresolved regressions
----------------------
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15139
Subject : e1000: transmit queue 0 timed out
Submitter : Alexander Beregalov <a.beregalov@gmail.com>
Date : 2010-01-23 15:37 (2 days old)
References : http://marc.info/?l=linux-netdev&m=126426149306083&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15138
Subject : evdev regression on macbook
Submitter : Guillaume Chazarain <guichaz@gmail.com>
Date : 2010-01-23 18:53 (2 days old)
References : http://marc.info/?l=linux-kernel&m=126427286219235&w=4
Handled-By : Dmitry Torokhov <dmitry.torokhov@gmail.com>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15133
Subject : Wake on LAN doesn't work in sky2
Submitter : Tino Keitel <tino.keitel@tikei.de>
Date : 2010-01-15 9:10 (10 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=166a0fd4c788ec7f10ca8194ec6d526afa12db75
References : http://marc.info/?l=linux-kernel&m=126354704815848&w=4
Handled-By : Stephen Hemminger <shemminger@vyatta.com>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15132
Subject : OOPS's with large initramfs
Submitter : Nigel Kukard <nkukard@lbsd.net>
Date : 2010-01-16 11:12 (9 days old)
References : http://marc.info/?l=linux-kernel&m=126364100321603&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15129
Subject : [drm:i915_gem_execbuffer] *ERROR* i915_gem_do_execbuffer returns -512
Submitter : Miles Lane <miles.lane@gmail.com>
Date : 2010-01-14 23:18 (11 days old)
References : http://lkml.org/lkml/2010/1/14/570
Handled-By : Chris Wilson <chris@chris-wilson.co.uk>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15126
Subject : REGRESSION for RT2561/RT61 in 2.6.33
Submitter : Alan Stern <stern@rowland.harvard.edu>
Date : 2010-01-11 14:54 (14 days old)
References : http://marc.info/?l=linux-kernel&m=126322167427159&w=4
Handled-By : Johannes Berg <johannes@sipsolutions.net>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15125
Subject : hung task - jbd2/dm-1-8 (during raid rebuild)
Submitter : Michael Breuer <mbreuer@majjas.com>
Date : 2010-01-10 21:47 (15 days old)
References : http://marc.info/?l=linux-kernel&m=126316012025978&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15124
Subject : PCI host bridge windows ignored (works with pci=use_crs)
Submitter : Jeff Garrett <jeff@jgarrett.org>
Date : 2010-01-13 5:37 (12 days old)
References : http://marc.info/?l=linux-kernel&m=126336296600307&w=4
Handled-By : Yinghai Lu <yinghai@kernel.org>
Bjorn Helgaas <bjorn.helgaas@hp.com>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15076
Subject : System panic under load with clockevents_program_event
Submitter : okias <d.okias@gmail.com>
Date : 2010-01-17 13:03 (8 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15043
Subject : Display goes off with i915.powersave=1
Submitter : Soeren Sonnenburg <sonne@debian.org>
Date : 2010-01-10 20:09 (15 days old)
References : http://marc.info/?l=linux-kernel&m=126315457519505&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15038
Subject : drm/ksm: fbdev blanking regression
Submitter : Johan Hovold <jhovold@gmail.com>
Date : 2010-01-06 17:00 (19 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=731b5a15a3b1474a41c2ca29b4c32b0f21bc852e
References : http://marc.info/?l=linux-kernel&m=126279726418748&w=4
Handled-By : James Simmons <jsimmons@infradead.org>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15036
Subject : soft lockup in dmesg after suspend/resume
Submitter : ykzhao <yakui.zhao@intel.com>
Date : 2010-01-04 5:36 (21 days old)
References : http://marc.info/?l=linux-kernel&m=126258356202722&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15032
Subject : Oops in uart_resume_port() on resume
Submitter : Zdenek Kabelac <zdenek.kabelac@gmail.com>
Date : 2010-01-04 15:47 (21 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=ba15ab0e8de0d4439a91342ad52d55ca9e313f3d
References : http://marc.info/?l=linux-kernel&m=126262008815689&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15025
Subject : Oops in ext4 driver
Submitter : Steinar H. Gunderson <sgunderson@bigfoot.com>
Date : 2010-01-10 13:09 (15 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15017
Subject : kexec regression, radeon/kms irq related (bisected)
Submitter : Markus Trippelsdorf <markus@trippelsdorf.de>
Date : 2010-01-09 18:49 (16 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=d8f60cfc93452d0554f6a701aa8e3236cbee4636
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15000
Subject : Thinkpad dock button no longer works
Submitter : Paul Martin <pm@debian.org>
Date : 2010-01-07 02:11 (18 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14999
Subject : possible circular locking dependency detected in rfkill at suspend
Submitter : Christian Casteyde <casteyde.christian@free.fr>
Date : 2010-01-06 21:52 (19 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14950
Subject : tbench regression with 2.6.33-rc1
Submitter : Lin Ming <ming.m.lin@intel.com>
Date : 2009-12-25 11:11 (31 days old)
References : http://marc.info/?l=linux-kernel&m=126174044213172&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14946
Subject : All kernels after 2.6.32-git10 show only 1 CPU
Submitter : Sid Boyce <sboyce@blueyonder.co.uk>
Date : 2009-12-23 16:55 (33 days old)
References : http://marc.info/?l=linux-kernel&m=126158734326801&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14937
Subject : WARNING: at kernel/lockdep.c:2830
Submitter : Grant Wilson <grant.wilson@zen.co.uk>
Date : 2009-12-27 13:35 (29 days old)
References : http://marc.info/?l=linux-kernel&m=126192220404829&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14924
Subject : Weird hard hangs when rendering 'some' web-sites in Firefox
Submitter : David <david@unsolicited.net>
Date : 2009-12-21 21:53 (35 days old)
References : http://marc.info/?l=linux-kernel&m=126143375823340&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14859
Subject : System timer firing too much without cause
Submitter : Shawn Starr <shawn.starr@rogers.com>
Date : 2009-12-21 19:16 (35 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14792
Subject : Misdetection of the TV output
Submitter : Santi <santi@agolina.net>
Date : 2009-12-12 13:28 (44 days old)
Regressions with patches
------------------------
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15137
Subject : NULL pointer dereference in vlan_skb_recv
Submitter : Bruno Prémont <bonbons@linux-vserver.org>
Date : 2010-01-23 15:56 (2 days old)
References : http://marc.info/?l=linux-kernel&m=126426286507497&w=4
Handled-By : Eric Dumazet <eric.dumazet@gmail.com>
Patch : http://patchwork.kernel.org/patch/74999/
http://patchwork.kernel.org/patch/75002/
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15131
Subject : [OOPS] radeon kms
Submitter : John Kacur <jkacur@redhat.com>
Date : 2010-01-15 15:45 (10 days old)
References : http://lkml.org/lkml/2010/1/15/129
Handled-By : Jerome Glisse <glisse@freedesktop.org>
Patch : http://git.kernel.org/?p=linux/kernel/git/airlied/drm-2.6.git;a=patch;h=30d2d9a54d48e4fefede0389ded1b6fc2d44a522
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15128
Subject : Boot regression on AMD
Submitter : Gene Heskett <gene.heskett@verizon.net>
Date : 2010-01-13 20:21 (12 days old)
References : http://marc.info/?l=linux-kernel&m=126341413213017&w=4
Handled-By : Andreas Herrmann <andreas.herrmann3@amd.com>
Patch : http://patchwork.kernel.org/patch/74883/
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15039
Subject : leds_alix2: can't allocate I/O for GPIO
Submitter : Arnd Hannemann <hannemann@nets.rwth-aachen.de>
Date : 2010-01-07 10:26 (18 days old)
References : http://marc.info/?l=linux-kernel&m=126286001106257&w=4
Handled-By : Daniel Mack <daniel@caiaq.de>
Patch : http://patchwork.kernel.org/patch/72006/
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14949
Subject : drm_vm.c:drm_mmap: possible circular locking dependency detected
Submitter : Borislav Petkov <petkovbb@googlemail.com>
Date : 2009-12-26 9:45 (30 days old)
References : http://marc.info/?l=linux-kernel&m=126182073616279&w=4
Handled-By : Eric W. Biederman <ebiederm@aristanetworks.com>
Patch : http://patchwork.kernel.org/patch/70461/
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14791
Subject : Something has been broken in the network stack this week
Submitter : Delete This Account <speedyboyinovator@hotmail.com>
Date : 2009-12-12 13:06 (44 days old)
Handled-By : Ben Hutchings <ben@decadent.org.uk>
Patch : http://patchwork.kernel.org/patch/72073/
For details, please visit the bug entries and follow the links given in
references.
As you can see, there is a Bugzilla entry for each of the listed regressions.
There also is a Bugzilla entry used for tracking the regressions from 2.6.32,
unresolved as well as resolved, at:
http://bugzilla.kernel.org/show_bug.cgi?id=14885
Please let me know if there are any Bugzilla entries that should be added to
the list in there.
Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: Regression: Wake on LAN doesn't work in sky2 with 2.6.33-rc4-git2
From: Rafael J. Wysocki @ 2010-01-24 20:35 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Tino Keitel, netdev, linux-kernel, David S. Miller
In-Reply-To: <20100119193745.GA5797@x61.home>
On Tuesday 19 January 2010, Tino Keitel wrote:
> On Tue, Jan 19, 2010 at 10:51:05 -0800, Stephen Hemminger wrote:
> > Is this better worse or the same? It make sure that some
> > registers are set on resume that might matter.
>
> I see not difference.
Hmm. Perhaps it's better to revert commit 166a0fd4c788ec7f10ca8194ec6d526afa12db75
for now, so that 2.6.33 works on the Tino's machine, and figure out why it
broke the WoL before (eventually) re-applying it?
Rafael
^ permalink raw reply
* [PATCH] vlan: fix vlan_skb_recv()
From: Eric Dumazet @ 2010-01-24 19:43 UTC (permalink / raw)
To: Bruno Prémont, David S. Miller
Cc: Américo Wang, netdev, linux-kernel
In-Reply-To: <20100124201808.2bbbf0b0@neptune.home>
Le 24/01/2010 20:18, Bruno Prémont a écrit :
> Yep, works fine and RX stats look right as well.
>
> So
> Reported-By: Bruno Prémont <bonbons@linux-vserver.org>
> Tested-By: Bruno Prémont <bonbons@linux-vserver.org>
>
> Thanks,
Thanks very much Bruno, here is the official patch submission then.
[PATCH] vlan: fix vlan_skb_recv()
Bruno Prémont found commit 9793241fe92f7d930
(vlan: Precise RX stats accounting) added a regression for non
hw accelerated vlans.
[ 26.390576] BUG: unable to handle kernel NULL pointer dereference at (null)
[ 26.396369] IP: [<df856b89>] vlan_skb_recv+0x89/0x280 [8021q]
vlan_dev_info() was used with original device, instead of
skb->dev. Also spotted by Américo Wang.
Reported-By: Bruno Prémont <bonbons@linux-vserver.org>
Tested-By: Bruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
net/8021q/vlan_dev.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
index b788978..c1b92ca 100644
--- a/net/8021q/vlan_dev.c
+++ b/net/8021q/vlan_dev.c
@@ -163,7 +163,7 @@ int vlan_skb_recv(struct sk_buff *skb, struct net_device *dev,
goto err_unlock;
}
- rx_stats = per_cpu_ptr(vlan_dev_info(dev)->vlan_rx_stats,
+ rx_stats = per_cpu_ptr(vlan_dev_info(skb->dev)->vlan_rx_stats,
smp_processor_id());
rx_stats->rx_packets++;
rx_stats->rx_bytes += skb->len;
^ permalink raw reply related
* Re: [2.6.33-rc5 regression] NULL pointer dereference in vlan_skb_recv - probably introduced by commit 9793241fe92f7d9303fb221e43fc598eb065f267
From: Bruno Prémont @ 2010-01-24 19:18 UTC (permalink / raw)
To: Eric Dumazet; +Cc: Américo Wang, David S. Miller, netdev, linux-kernel
In-Reply-To: <4B5C74BF.5060604@gmail.com>
Yep, works fine and RX stats look right as well.
So
Reported-By: Bruno Prémont <bonbons@linux-vserver.org>
Tested-By: Bruno Prémont <bonbons@linux-vserver.org>
Thanks,
Bruno
On Sun, 24 January 2010 Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Ok, I believe I found the problem :)
>
> Please try following patch, if it works I'll submit with appropriate
> Changelog and signatures
>
> Thanks
>
>
> diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
> index b788978..c1b92ca 100644
> --- a/net/8021q/vlan_dev.c
> +++ b/net/8021q/vlan_dev.c
> @@ -163,7 +163,7 @@ int vlan_skb_recv(struct sk_buff *skb, struct net_device *dev,
> goto err_unlock;
> }
>
> - rx_stats = per_cpu_ptr(vlan_dev_info(dev)->vlan_rx_stats,
> + rx_stats = per_cpu_ptr(vlan_dev_info(skb->dev)->vlan_rx_stats,
> smp_processor_id());
> rx_stats->rx_packets++;
> rx_stats->rx_bytes += skb->len;
^ permalink raw reply
* Re: [net-next-2.6 PATCH 2/3] fs_enet: Add support for MPC512x to fs_enet driver
From: Wolfgang Denk @ 2010-01-24 16:41 UTC (permalink / raw)
To: Wolfgang Grandegger
Cc: Arnd Bergmann, linuxppc-dev, David Miller, dzu, netdev,
linuxppc-dev, agust, kosmo
In-Reply-To: <4B5C5BDF.6020001@grandegger.com>
Dear Wolfgang & Arnd,
In message <4B5C5BDF.6020001@grandegger.com> you wrote:
>
> Arnd Bergmann wrote:
...
> > Is there any chance of building a kernel that runs on both mpc8xx and
> > mpc5121? AFAIK, the 5121 is built on a 6xx core which is fundamentally
> > incompatible with 8xx due to different memory management etc.
It is my understanding as well that you cannot have a single image
that boots both on 8xx and on 6xx cores. The focus was more on things
like supporting MPC5200 and MPC512x with the same image.
> > Since this makes it all a compile-time decision, it should be solvable
> > with a very small number of carefully placed #ifdef in the header files
> > an no runtime detection at all.
> >
> > Obviously this approach would not work for drivers that want to be portable
> > across different register layouts on otherwise compatible platforms.
>
> You are probably right and your proposal would likely result in more
> transparent (less ugly) code. There has been some discussion about
> unifying FEC drivers when the patches (with the same subject) have been
> submitted for the first time in May last year, but it was not about 512x
> and 8xx, IIRC.
You can re-read this discussion here:
http://patchwork.ozlabs.org/patch/26927/
ee especiall Grant's note of 2009-05-21 15:36:11: "If it looks too
ugly, then just fork the driver."
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Immortality consists largely of boredom.
-- Zefrem Cochrane, "Metamorphosis", stardate 3219.8
^ permalink raw reply
* Re: [2.6.33-rc5 regression] NULL pointer dereference in vlan_skb_recv - probably introduced by commit 9793241fe92f7d9303fb221e43fc598eb065f267
From: Eric Dumazet @ 2010-01-24 16:27 UTC (permalink / raw)
To: Américo Wang
Cc: Bruno Prémont, David S. Miller, netdev, linux-kernel
In-Reply-To: <20100124162523.GC11037@hack>
Le 24/01/2010 17:25, Américo Wang a écrit :
> On Sun, Jan 24, 2010 at 04:25:49PM +0100, Bruno Prémont wrote:
>> On Sun, 24 January 2010 Eric Dumazet <eric.dumazet@gmail.com> wrote:
>>> Le 23/01/2010 22:31, Bruno Prémont a écrit :
>>>>> Above part of code did change between 2.6.32 and 2.6.33-rc5 with
>>>>> commit 9793241fe92f7d9303fb221e43fc598eb065f267 (vlan: Precise RX
>>>>> stats accounting)
>>>>> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=9793241fe92f7d9303fb221e43fc598eb065f267
>>>>
>>>> Reverting just that commit gets the system running correctly.
>>>>
>>>> Bruno
>>>
>>> I have no idea how this patch can break vlan networking.
>>>
>>> Your disassembly and .config seems to show your machine is not SMP
>>
>> Exact
>>
>>> Maybe something is broken on UP and alloc_percpu() ?
>>
>> Apparently not, see below and previous mail
>>
>>> Could you add a debug in vlan_dev_init()
>>
>> In addition to previous mail, I'm also dumping the result of
>> vlan_dev_info(dev) shows that the returned pointer is not the same
>> during vlan_dev_init() and vlan_skb_recv() ...
>>
>> diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
>> index b788978..f370ce1 100644
>> --- a/net/8021q/vlan_dev.c
>> +++ b/net/8021q/vlan_dev.c
>> @@ -165,8 +165,11 @@ int vlan_skb_recv(struct sk_buff *skb, struct net_device *dev,
>>
>> rx_stats = per_cpu_ptr(vlan_dev_info(dev)->vlan_rx_stats,
>> smp_processor_id());
>
>
> I am thinking if vlan_dev_info(dev) here should be
> vlan_dev_info(skb->dev)...
>
>
Yes, I came to same conclusion :)
Thanks
^ permalink raw reply
* Re: [2.6.33-rc5 regression] NULL pointer dereference in vlan_skb_recv - probably introduced by commit 9793241fe92f7d9303fb221e43fc598eb065f267
From: Eric Dumazet @ 2010-01-24 16:26 UTC (permalink / raw)
To: Bruno Prémont; +Cc: Eric Dumazet, David S. Miller, netdev, linux-kernel
In-Reply-To: <20100124162549.2b39b222@neptune.home>
Le 24/01/2010 16:25, Bruno Prémont a écrit :
>
> In addition to previous mail, I'm also dumping the result of
> vlan_dev_info(dev) shows that the returned pointer is not the same
> during vlan_dev_init() and vlan_skb_recv() ...
>
>
> This might explain the NULL rx_stats pointer, but why do there exist
> two distinct vlan_dev_info(dev)? (unless in one case dev would be
> the physical network device and in the other case it would be vlan device?
> that is lan versus lan.658 in my case...)
>
Ok, I believe I found the problem :)
Please try following patch, if it works I'll submit with appropriate Changelog and signatures
Thanks
diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
index b788978..c1b92ca 100644
--- a/net/8021q/vlan_dev.c
+++ b/net/8021q/vlan_dev.c
@@ -163,7 +163,7 @@ int vlan_skb_recv(struct sk_buff *skb, struct net_device *dev,
goto err_unlock;
}
- rx_stats = per_cpu_ptr(vlan_dev_info(dev)->vlan_rx_stats,
+ rx_stats = per_cpu_ptr(vlan_dev_info(skb->dev)->vlan_rx_stats,
smp_processor_id());
rx_stats->rx_packets++;
rx_stats->rx_bytes += skb->len;
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox