* Re: [PATCH] vhost-net: switch to smp barriers
From: Avi Kivity @ 2010-02-07 9:56 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Rusty Russell, kvm, virtualization, netdev, linux-kernel,
David Miller
In-Reply-To: <20100207094441.GA20271@redhat.com>
On 02/07/2010 11:44 AM, Michael S. Tsirkin wrote:
> On Sun, Feb 07, 2010 at 11:42:29AM +0200, Avi Kivity wrote:
>
>> On 02/01/2010 07:21 PM, Michael S. Tsirkin wrote:
>>
>>> vhost-net only uses memory barriers to control SMP effects
>>> (communication with userspace potentially running on a different CPU),
>>> so it should use SMP barriers and not mandatory barriers for memory
>>> access ordering, as suggested by Documentation/memory-barriers.txt
>>>
>>>
>>>
>> A UP guest running on an SMP host still needs those barriers.
>>
> Correct. And since vhost net is running host-side, smp_XX
> barriers will do exactly the right thing, right?
>
Right, of course. Mixed up virtio and vhost.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply
* Re: [PATCH 2/2] sky2: Allocate initial skbs in sky2_alloc_buffers
From: Mike McCormack @ 2010-02-07 9:56 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev
In-Reply-To: <20100205221246.6fdb3632@s6510>
On 6 February 2010 15:12, Stephen Hemminger <shemminger@vyatta.com> wrote:
> On Fri, 5 Feb 2010 18:10:45 -0800
> Stephen Hemminger <shemminger@vyatta.com> wrote:
>
>> On Sat, 06 Feb 2010 10:22:59 +0900
>> Mike McCormack <mikem@ring3k.org> wrote:
>>
>> > Allocating everything in one place means there's a single point
>> > of failure in sky2_up, and sky2_rx_start can no longer fail.
>>
>> If ring is never allocated, how then it must fail in up.
>> Plus if the initial ring allocation is partial it should fail.
>
> Let me put that clearer...
> When dev_open is called, the system might be very short of memory
> and unable to allocate the number of receive buffers; in that case,
> I would prefer that an error was returned to the application.
> Yes, this is a corner case; but it is better to fail with a noisy
> error than limp along with a dead device.
Hi Stephen,
I think you've misread my patch. I have not attempted to change the
way allocation failure is handled, just to move all allocations to the
same place.
The end goal is to refactor sky2_up into a piece that initializes
hardware following memory allocation (say sky2_start) so we can do
sky2_reset() without free'ing and allocating memory, or detaching the
device.
thanks,
Mike
^ permalink raw reply
* Re: [PATCH] tcp: fix ICMP-RTO war
From: Denys Fedoryshchenko @ 2010-02-07 10:28 UTC (permalink / raw)
To: Damian Lukowski; +Cc: Ilpo Järvinen, Netdev, David Miller
In-Reply-To: <op.u7cmcnxvp498uc@nexus>
On Saturday 30 January 2010 15:56:37 Damian Lukowski wrote:
> > On Friday 29 January 2010 23:45:35 Damian Lukowski wrote:
> >> Denys Fedoryshchenko schrieb:
> >> > On Friday 29 January 2010 14:13:18 Damian Lukowski wrote:
> >> >> Denys Fedoryshchenko schrieb:
> >> >>> On Wednesday 27 January 2010 14:36:18 you wrote:
> >> >>>> Unless they are for a different connection? We might have to print
> >>
> >> sk
> >>
> >> >>>> (%p) in all those printouts to be sure which maps to which. If a
> >>
> >> peer
> >>
> >> >>>> becomes unreachable, it may well have multiple connections open
> >>
> >> (this
> >>
> >> >>>> was a proxy, iirc?).
> >> >>>
> >> >>> Ok i will try to do that today.
> >> >>>
> >> >>> Most probably different connections, on this proxy i have 10-15k
> >> >>> established connections at peak time.
> >> >
> >> > http://www.nuclearcat.com/files/report1.txt
> >> > http://www.nuclearcat.com/files/report2.txt
> >> >
> >> > Here with %p and sk.
> >>
> >> Ok, thanks for testing.
> >> So it is ec0f3440 causing the trouble. Are there still objections
> >> on the lower bound check in __tcp_set_rto()? Well, I will submit
> >> an updated patch and you can make comments there.
> >
> > There is another sk also. I can catch for more time - there is many
> > different
> > pointers to sk appearing (but not in same time, it is rare case even
> > with my thousands of connections).
>
> Hmm, I shouldn't have posted so late yesterday, as I forgot to CC
> you and the others when submitting the patch, amongst the grammar error. :/
> Can you test the patch in
> http://marc.info/?l=linux-netdev&m=126480336216898
> please?
>
> Damian
>
Seems no more lower bound violation.
Thanks a lot!
^ permalink raw reply
* [PATCH 1/3] sky2: resume clocks
From: Stephen Hemminger @ 2010-02-07 16:23 UTC (permalink / raw)
To: David Miller, netdev
Change the resume path to use pci write config for a couple of reasons:
1. pci_write_config_dword() allows for more error
checking of PCI health after resume.
2. better to toggle this register on all chip types, since that
is what vendor driver does.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/drivers/net/sky2.c 2010-02-03 09:17:01.602741445 -0800
+++ b/drivers/net/sky2.c 2010-02-03 09:24:17.943679463 -0800
@@ -4859,10 +4859,11 @@ static int sky2_resume(struct pci_dev *p
pci_enable_wake(pdev, PCI_D0, 0);
/* Re-enable all clocks */
- if (hw->chip_id == CHIP_ID_YUKON_EX ||
- hw->chip_id == CHIP_ID_YUKON_EC_U ||
- hw->chip_id == CHIP_ID_YUKON_FE_P)
- sky2_pci_write32(hw, PCI_DEV_REG3, 0);
+ err = pci_write_config_dword(pdev, PCI_DEV_REG3, 0);
+ if (err) {
+ dev_err(&pdev->dev, "PCI write config failed\n");
+ goto out;
+ }
sky2_reset(hw);
sky2_write32(hw, B0_IMSK, Y2_IS_BASE);
^ permalink raw reply
* [PATCH 3/3] sky2: receive checksum refactoring
From: Stephen Hemminger @ 2010-02-07 16:28 UTC (permalink / raw)
To: David Miller; +Cc: netdev
In-Reply-To: <20100207082353.2d0c6a93@nehalam>
Break the largish case for handling receive checksum into a separate
function, and if there is a problem use dev_XXX routines to
show which hardware is the problem.
Turn one corner case into a BUG(). This only happens if the driver
is expecting one behavior but the chip does the old behavior;
only ever saw this when bringing up a new chip type and driver
was buggy.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/drivers/net/sky2.c 2010-02-03 09:24:19.203992300 -0800
+++ b/drivers/net/sky2.c 2010-02-03 09:24:19.933679365 -0800
@@ -2484,6 +2484,32 @@ static inline void sky2_rx_done(struct s
}
}
+static void sky2_rx_checksum(struct sky2_port *sky2, u32 status)
+{
+ /* If this happens then driver assuming wrong format for chip type */
+ BUG_ON(sky2->hw->flags & SKY2_HW_NEW_LE);
+
+ /* Both checksum counters are programmed to start at
+ * the same offset, so unless there is a problem they
+ * should match. This failure is an early indication that
+ * hardware receive checksumming won't work.
+ */
+ if (likely((u16)(status >> 16) == (u16)status)) {
+ struct sk_buff *skb = sky2->rx_ring[sky2->rx_next].skb;
+ skb->ip_summed = CHECKSUM_COMPLETE;
+ skb->csum = le16_to_cpu(status);
+ } else {
+ dev_notice(&sky2->hw->pdev->dev,
+ "%s: receive checksum problem (status = %#x)\n",
+ sky2->netdev->name, status);
+
+ /* Disable checksum offload */
+ sky2->flags &= ~SKY2_FLAG_RX_CHECKSUM;
+ sky2_write32(sky2->hw, Q_ADDR(rxqaddr[sky2->port], Q_CSR),
+ BMU_DIS_RX_CHKSUM);
+ }
+}
+
/* Process status response ring */
static int sky2_status_intr(struct sky2_hw *hw, int to_do, u16 idx)
{
@@ -2552,37 +2578,8 @@ static int sky2_status_intr(struct sky2_
/* fall through */
#endif
case OP_RXCHKS:
- if (!(sky2->flags & SKY2_FLAG_RX_CHECKSUM))
- break;
-
- /* If this happens then driver assuming wrong format */
- if (unlikely(hw->flags & SKY2_HW_NEW_LE)) {
- if (net_ratelimit())
- printk(KERN_NOTICE "%s: unexpected"
- " checksum status\n",
- dev->name);
- break;
- }
-
- /* Both checksum counters are programmed to start at
- * the same offset, so unless there is a problem they
- * should match. This failure is an early indication that
- * hardware receive checksumming won't work.
- */
- if (likely(status >> 16 == (status & 0xffff))) {
- skb = sky2->rx_ring[sky2->rx_next].skb;
- skb->ip_summed = CHECKSUM_COMPLETE;
- skb->csum = le16_to_cpu(status);
- } else {
- printk(KERN_NOTICE PFX "%s: hardware receive "
- "checksum problem (status = %#x)\n",
- dev->name, status);
- sky2->flags &= ~SKY2_FLAG_RX_CHECKSUM;
-
- sky2_write32(sky2->hw,
- Q_ADDR(rxqaddr[port], Q_CSR),
- BMU_DIS_RX_CHKSUM);
- }
+ if (likely(sky2->flags & SKY2_FLAG_RX_CHECKSUM))
+ sky2_rx_checksum(sky2, status);
break;
case OP_TXINDEXLE:
^ permalink raw reply
* [PATCH 2/3]: sky2: disable ASF on Yukon Supreme
From: Stephen Hemminger @ 2010-02-07 16:24 UTC (permalink / raw)
To: David Miller; +Cc: netdev
In-Reply-To: <20100207082353.2d0c6a93@nehalam>
Clone of vendor code to disable ASF on Extreme and Supreme chips.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/drivers/net/sky2.c 2010-02-03 09:24:17.943679463 -0800
+++ b/drivers/net/sky2.c 2010-02-03 09:24:19.203992300 -0800
@@ -3035,11 +3035,20 @@ static void sky2_reset(struct sky2_hw *h
u32 hwe_mask = Y2_HWE_ALL_MASK;
/* disable ASF */
- if (hw->chip_id == CHIP_ID_YUKON_EX) {
+ if (hw->chip_id == CHIP_ID_YUKON_EX
+ || hw->chip_id == CHIP_ID_YUKON_SUPR) {
+ sky2_write32(hw, CPU_WDOG, 0);
status = sky2_read16(hw, HCU_CCSR);
status &= ~(HCU_CCSR_AHB_RST | HCU_CCSR_CPU_RST_MODE |
HCU_CCSR_UC_STATE_MSK);
+ /*
+ * CPU clock divider shouldn't be used because
+ * - ASF firmware may malfunction
+ * - Yukon-Supreme: Parallel FLASH doesn't support divided clocks
+ */
+ status &= ~HCU_CCSR_CPU_CLK_DIVIDE_MSK;
sky2_write16(hw, HCU_CCSR, status);
+ sky2_write32(hw, CPU_WDOG, 0);
} else
sky2_write8(hw, B28_Y2_ASF_STAT_CMD, Y2_ASF_RESET);
sky2_write16(hw, B0_CTST, Y2_ASF_DISABLE);
^ permalink raw reply
* [RFC]: xfrm by mark
From: jamal @ 2010-02-07 18:32 UTC (permalink / raw)
To: Herbert Xu, David Miller; +Cc: Timo Teräs, netdev
Hi,
While catching up with old netdev threads I noticed this one:
http://marc.info/?l=linux-netdev&m=125621829709171&w=2
I had a chat with Timo and he is too busy on other things at
the moment. I have some cycles to burn and would like to pursue
this unless there is objection to the general idea. I am interested
because I would like to see most of the net stack capable of
reference by mark. I am posting this so i can get a general
pulse before i go off coding.
Approach:
- introduce attribute XFRMA_MARK
- both SPD and SAD will have new entries ->mark
- by default mark is 0, so backward compat for
control add/get/del as well as fast path lookup continues.
I dont plan to touch pfkey i.e anything injected by pfkey
will use default mark of 0.
- a sysctl to turn off this feature doesnt seem necessary
since the cycles added by the fast path lookup dont seem
to be much more..
Timo, please chime in with anything i may have missed.
cheers,
jamal
^ permalink raw reply
* rps: question
From: jamal @ 2010-02-07 18:42 UTC (permalink / raw)
To: Tom Herbert; +Cc: Eric Dumazet, netdev, robert, David Miller
Hi Tom,
First off: Kudos on the numbers you are seeing; they are
impressive. Do you have any numbers on a forwarding path test?
My first impression when i saw the numbers was one of suprise.
Back in the days when we tried to split stack processing the way
you did(it was one of the experiments on early NAPI), IPIs were
_damn_ expensive. What changed in current architecture that makes
this more palatable? IPIs are still synchronous AFAIK (and the more
IPI receiver there are, the worse the ACK latency). Did you test this
across other archs or say 3-4 year old machines?
cheers,
jamal
^ permalink raw reply
* [2.6.33-rc only] kerneloops.org report for the week of Feb 7 2010 for the 2.6.33-rc kernel series
From: Arjan van de Ven @ 2010-02-07 19:38 UTC (permalink / raw)
To: linux-kernel; +Cc: torvalds, netdev, agk, airlied, mingo, peterz, akpm
With the 2.6.33 kernel around the kernel, this report covers ONLY the 2.6.33-rc series;
the oopes/warning in this report are rather "fresh" in that sense... and unfixed issues
will be seen in a much wider audience once .33 gets released.
This week, a total of 1118 oopses and warnings have been reported for the 2.6.33-rc series.
Per file statistics
400 net/core/iovec.c
242 drivers/md/dm-snap-persistent.c
72 drivers/gpu/drm/drm_crtc.c
54 kernel/lockdep.c
41 drivers/pci/intel-iommu.c
30 kernel/futex.c (P)
15 arch/x86/kernel/process_32.c
14 drivers/acpi/processor_idle.c
13 lib/parser.c
12 lib/debugobjects.c
11 include/linux/kernel.h
11 arch/x86/kernel/hpet.c
Rank 1: memcpy_toiovecend (warning)
Reported 391 times (394 total reports)
This warning was last seen in version 2.6.33-rc5, and first seen in 2.6.33-rc5.
More info: http://www.kerneloops.org/searchweek.php?search=memcpy_toiovecend
Rank 2: chunk_io (warning)
Reported 242 times (478 total reports)
This warning was last seen in version 2.6.33-rc6-git1, and first seen in 2.6.33-rc4-git3.
More info: http://www.kerneloops.org/searchweek.php?search=chunk_io
Rank 3: drm_fb_release (oops)
Reported 72 times
This oops was last seen in version 2.6.33-rc7-git0, and first seen in 2.6.33-rc5-git1.
More info: http://www.kerneloops.org/searchweek.php?search=drm_fb_release
Rank 4: lockstat_clock (oops)
Reported 45 times (46 total reports)
This oops was last seen in version 2.6.33-rc6-git1, and first seen in 2.6.33-rc5-git1.
More info: http://www.kerneloops.org/searchweek.php?search=lockstat_clock
Rank 5: macvtap_ioctl (warning)
Reported 41 times (44 total reports)
This warning was last seen in version 2.6.33-rc5, and first seen in 2.6.33-rc5.
More info: http://www.kerneloops.org/searchweek.php?search=macvtap_ioctl
Rank 6: lookup_pi_state (warning)
Reported 30 times (60 total reports)
warning only shows up in tainted kernels
This warning was last seen in version 2.6.33-rc6, and first seen in 2.6.24.
More info: http://www.kerneloops.org/searchweek.php?search=lookup_pi_state
Rank 7: init_dmars (warning)
Reported 25 times (673 total reports)
This warning was last seen in version 2.6.33-rc7, and first seen in 2.6.31.5.
More info: http://www.kerneloops.org/searchweek.php?search=init_dmars
Rank 8: i915_gem_do_execbuffer (oops)
Reported 17 times (18 total reports)
This oops was last seen in version 2.6.33-rc6, and first seen in 2.6.33-rc4.
More info: http://www.kerneloops.org/searchweek.php?search=i915_gem_do_execbuffer
Rank 9: iommu_prepare_identity_map (warning)
Reported 16 times (3223 total reports)
This warning was last seen in version 2.6.33-rc6-git1, and first seen in 2.6.31.5.
More info: http://www.kerneloops.org/searchweek.php?search=iommu_prepare_identity_map
Rank 10: cpu_idle (warning)
Reported 15 times (214 total reports)
This warning was last seen in version 2.6.33-rc5-git0, and first seen in 2.6.18-rc4.
More info: http://www.kerneloops.org/searchweek.php?search=cpu_idle
Rank 11: acpi_idle_enter_bm (warning)
Reported 14 times (5906 total reports)
Dell Laptops oops in idle
This warning was last seen in version 2.6.33-rc6-git0, and first seen in 2.6.23.8.
More info: http://www.kerneloops.org/searchweek.php?search=acpi_idle_enter_bm
Rank 12: match_number (warning)
Reported 13 times (35 total reports)
This warning was last seen in version 2.6.33-rc7, and first seen in 2.6.27.15.
More info: http://www.kerneloops.org/searchweek.php?search=match_number
--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
^ permalink raw reply
* Re: [PATCH] net/sched: Fix module name in Kconfig
From: jamal @ 2010-02-07 20:25 UTC (permalink / raw)
To: Jan Luebbe; +Cc: netdev
In-Reply-To: <1265478049-29736-1-git-send-email-jluebbe@debian.org>
On Sat, 2010-02-06 at 18:40 +0100, Jan Luebbe wrote:
> The action modules have been prefixed with 'act_', but the Kconfig
> description was not changed.
>
> Signed-off-by: Jan Luebbe <jluebbe@debian.org>
Acked-by: Jamal Hadi Salim <hadi@cyberus.ca>
cheers,
jamal
^ permalink raw reply
* 2.6.33-rc7: Reported regressions from 2.6.32
From: Rafael J. Wysocki @ 2010-02-07 22:16 UTC (permalink / raw)
To: Linux Kernel Mailing List
Cc: Maciej Rutecki, Andrew Morton, Linus Torvalds,
Kernel Testers List, Network Development, Linux ACPI,
Linux PM List, Linux SCSI List, Linux Wireless List, DRI
[ANNOUNCEMENT:
Maciej Rutecki has generously volunteered to work on the tracking of kernel
regressions with me, so now there are two people doing this and I'm going
to call us "the tracking team". Please be friendly to Maciej, he's doing his
best to help. If you have any information about kernel regressions you want
to share with us, please feel free to contact Maciej as well as me.]
This message contains a list of some regressions from 2.6.32,
for which there are no fixes in the mainline known to the tracking team.
If any of them have been fixed already, please let us know.
If you know of any other unresolved regressions from 2.6.32, please let us
know either and we'll add them to the list. Also, please let us know
if any of the entries below are invalid.
Each entry from the list will be sent additionally in an automatic reply
to this message with CCs to the people involved in reporting and handling
the issue.
Listed regressions statistics:
Date Total Pending Unresolved
----------------------------------------
2010-02-07 97 27 20
2010-02-01 85 26 21
2010-01-24 75 29 23
2010-01-10 55 33 21
2009-12-29 36 34 27
Unresolved regressions
----------------------
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15246
Subject : BUG: Bad page state in process portageq
Submitter : Johannes Hirte <johannes.hirte@fem.tu-ilmenau.de>
Date : 2010-02-07 0:45 (1 days old)
References : http://marc.info/?l=linux-kernel&m=126550356515887&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15245
Subject : [2.6.33-rc6 fc76be4 w/ drm-radon-testing and KMS enabled] Weird JCPU times?
Submitter : Shawn Starr <shawn.starr@rogers.com>
Date : 2010-02-06 7:24 (2 days old)
References : http://marc.info/?l=linux-kernel&m=126544107816889&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15207
Subject : Pineview - only cursor on black screen visible, "GPU hung" in dmesg
Submitter : Christian Friedemann <dawn2k@gmail.com>
Date : 2010-02-01 20:15 (7 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15202
Subject : lockdep warning during elevator_switch
Submitter : Hugh Dickins <hugh.dickins@tiscali.co.uk>
Date : 2010-01-31 23:55 (8 days old)
References : http://marc.info/?l=linux-kernel&m=126498212613051&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15200
Subject : NFS problems in 2.6.33-rc6: Unknown error 526
Submitter : J.A. Magallón <jamagallon@ono.com>
Date : 2010-01-31 22:46 (8 days old)
References : http://marc.info/?l=linux-kernel&m=126497800408928&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15199
Subject : sata_nv and no /dev files
Submitter : Bartłomiej Zimoń <uzi18@o2.pl>
Date : 2010-01-31 23:45 (8 days old)
Message-ID : <1f9bac08.1a5266d6.4b66012a.5a11a@o2.pl>
References : http://marc.info/?l=linux-kernel&m=126498153112488&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15192
Subject : netperf ~50% regression with 2.6.33-rc1, bisect to 1b9508f
Submitter : Lin Ming <ming.m.lin@intel.com>
Date : 2010-01-25 10:03 (14 days old)
First-Bad-Commit: http://git.kernel.org/git/linus/1b9508f6831e10d53256825de8904caa22d1ca2c
References : http://marc.info/?l=linux-kernel&m=126441481427331&w=4
Handled-By : Mike Galbraith <efault@gmx.de>
Peter Zijlstra <peterz@infradead.org>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15177
Subject : Asynchronous writes up to 30% slower than in previous kernel versions
Submitter : Bart Van Assche <bart.vanassche@gmail.com>
Date : 2010-01-30 16:38 (9 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15142
Subject : sysfs-related lockdep warning in __blkdev_get
Submitter : Matti Aarnio <matti.aarnio--kernel-bugzilla@zmailer.org>
Date : 2010-01-25 13:38 (14 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15139
Subject : e1000: transmit queue 0 timed out
Submitter : Alexander Beregalov <a.beregalov@gmail.com>
Date : 2010-01-23 15:37 (16 days old)
References : http://marc.info/?l=linux-netdev&m=126426149306083&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15114
Subject : X.org hang with [drm:i915_gem_do_execbuffer] *ERROR* in dmesg
Submitter : Matej Laitl <strohel@gmail.com>
Date : 2010-01-23 19:54 (16 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15076
Subject : System panic under load with clockevents_program_event
Submitter : okias <d.okias@gmail.com>
Date : 2010-01-17 13:03 (22 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15044
Subject : Much higher wakeups for "<kernel IPI> : Rescheduling interrupts" since 2.6.32.2
Submitter : Roman Mamedov <roman@rm.pp.ru>
Date : 2010-01-11 02:58 (28 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15043
Subject : Display goes off with i915.powersave=1 after suspend-resume
Submitter : Soeren Sonnenburg <sonne@debian.org>
Date : 2010-01-10 20:09 (29 days old)
References : http://marc.info/?l=linux-kernel&m=126315457519505&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15036
Subject : soft lockup in dmesg after suspend/resume
Submitter : ykzhao <yakui.zhao@intel.com>
Date : 2010-01-04 5:36 (35 days old)
References : http://marc.info/?l=linux-kernel&m=126258356202722&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15025
Subject : Oops in ext4 driver
Submitter : Steinar H. Gunderson <sgunderson@bigfoot.com>
Date : 2010-01-10 13:09 (29 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14999
Subject : possible circular locking dependency detected in rfkill at suspend
Submitter : Christian Casteyde <casteyde.christian@free.fr>
Date : 2010-01-06 21:52 (33 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14950
Subject : tbench regression with 2.6.33-rc1
Submitter : Lin Ming <ming.m.lin@intel.com>
Date : 2009-12-25 11:11 (45 days old)
References : http://marc.info/?l=linux-kernel&m=126174044213172&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14937
Subject : WARNING: at kernel/lockdep.c:2830
Submitter : Grant Wilson <grant.wilson@zen.co.uk>
Date : 2009-12-27 13:35 (43 days old)
References : http://marc.info/?l=linux-kernel&m=126192220404829&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14792
Subject : Misdetection of the TV output
Submitter : Santi <santi@agolina.net>
Date : 2009-12-12 13:28 (58 days old)
First-Bad-Commit: http://git.kernel.org/git/linus/27dfaf4f5825a119305db1bc63bef30ed400e376
Handled-By : Zhao Yakui <yakui.zhao@intel.com>
Regressions with patches
------------------------
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15251
Subject : ioctl32(mdadm:2243): Unknown cmd fd(3) cmd(800c0910){t:09;sz:12} arg(ffb7f9c4)
Submitter : Michael S. Tsirkin <m.s.tsirkin@gmail.com>
Date : 2010-01-30 22:02 (9 days old)
Message-ID : <201001302302.10574.arnd@arndb.de>
References : http://marc.info/?l=linux-kernel&m=126489038709553&w=4
Handled-By : Arnd Bergmann <arnd@arndb.de>
Patch : http://patchwork.kernel.org/patch/75931/
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15250
Subject : "drm/i915: implement new pm ops" disables irq on aborted s2disk
Submitter : Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Date : 2010-02-03 03:18 (5 days old)
First-Bad-Commit: http://git.kernel.org/git/linus/cbda12d77ea590082edb6d30bd342a67ebc459e0
Message-ID : <4B695BA0.4000007@tuffmail.co.uk>
References : https://lists.linux-foundation.org/pipermail/linux-pm/2010-February/024200.html
Handled-By : Rafael J. Wysocki <rjw@sisk.pl>
Patch : http://patchwork.kernel.org/patch/77640/
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15244
Subject : PROBLEM: hda-intel divide by zero kernel crash in azx_position_ok()
Submitter : Jody Bruchon <jody@nctritech.com>
Date : 2010-02-06 0:32 (2 days old)
References : http://marc.info/?l=linux-kernel&m=126541276028173&w=2
Handled-By : Takashi Iwai <tiwai@suse.de>
Jody Bruchon <jody@nctritech.com>
Patch : http://marc.info/?l=linux-kernel&m=126547145614070&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15196
Subject : kmem_cache_create: duplicate cache ccid2_h
Submitter : Heinz Diehl <htd@fancy-poultry.org>
Date : 2010-01-30 18:33 (9 days old)
References : http://marc.info/?l=linux-kernel&m=126487640324942&w=4
Handled-By : Xiaotian Feng <xtfeng@gmail.com>
Patch : http://patchwork.kernel.org/patch/77601/
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15195
Subject : kernel BUG at include/net/netns/generic.h:41, pfkey_create+0x36/0x18b [af_key]
Submitter : Luca Tettamanti <kronos.it@gmail.com>
Date : 2010-01-30 13:23 (9 days old)
References : http://marc.info/?l=linux-netdev&m=126485785004775&w=4
Handled-By : Alexey Dobriyan <adobriyan@gmail.com>
Patch : http://patchwork.kernel.org/patch/75891/
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15039
Subject : leds_alix2: can't allocate I/O for GPIO
Submitter : Arnd Hannemann <hannemann@nets.rwth-aachen.de>
Date : 2010-01-07 10:26 (32 days old)
References : http://marc.info/?l=linux-kernel&m=126286001106257&w=4
Handled-By : Daniel Mack <daniel@caiaq.de>
Patch : http://patchwork.kernel.org/patch/72006/
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14949
Subject : drm_vm.c:drm_mmap: possible circular locking dependency detected
Submitter : Borislav Petkov <petkovbb@googlemail.com>
Date : 2009-12-26 9:45 (44 days old)
References : http://marc.info/?l=linux-kernel&m=126182073616279&w=4
Handled-By : Eric W. Biederman <ebiederm@aristanetworks.com>
Patch : http://patchwork.kernel.org/patch/70461/
For details, please visit the bug entries and follow the links given in
references.
As you can see, there is a Bugzilla entry for each of the listed regressions.
There also is a Bugzilla entry used for tracking the regressions from 2.6.32,
unresolved as well as resolved, at:
http://bugzilla.kernel.org/show_bug.cgi?id=14885
Please let the tracking team know if there are any Bugzilla entries that
should be added to the list in there.
Thanks!
^ permalink raw reply
* 2.6.33-rc7: Reported regressions 2.6.31 -> 2.6.32
From: Rafael J. Wysocki @ 2010-02-08 0:13 UTC (permalink / raw)
To: Linux Kernel Mailing List
Cc: Maciej Rutecki, Andrew Morton, Linus Torvalds,
Kernel Testers List, Network Development, Linux ACPI,
Linux PM List, Linux SCSI List, Linux Wireless List, DRI
This message contains a list of some post-2.6.31 regressions introduced before
2.6.32, for which there are no fixes in the mainline known to the tracking team.
If any of them have been fixed already, please let us know.
If you know of any other unresolved post-2.6.31 regressions, please let us know
either and we'll add them to the list. Also, please let us know if any
of the entries below are invalid.
Each entry from the list will be sent additionally in an automatic reply to
this message with CCs to the people involved in reporting and handling the
issue.
Listed regressions statistics:
Date Total Pending Unresolved
----------------------------------------
2010-02-08 155 47 37
2010-02-01 149 50 45
2010-01-24 140 45 43
2010-01-10 130 44 40
2009-12-29 124 60 57
2009-11-21 86 29 25
2009-11-16 84 46 41
2009-10-26 66 42 37
2009-10-12 48 31 27
2009-10-02 22 15 9
Unresolved regressions
----------------------
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15220
Subject : Kernel freezes when playing DVB stream and having 3D acceleration in the same time
Submitter : Cijoml Cijomlovic Cijomlov <cijoml-VIXq6x/3rUk@public.gmane.org>
Date : 2010-02-03 20:34 (5 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15206
Subject : uvcvideo fails to work since 2.6.32
Submitter : Rich Ercolani <rercola-YxllIAoeIHiVc3sceRu5cw@public.gmane.org>
Date : 2010-02-01 12:51 (7 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15205
Subject : blank screen with KMS if lid is closed before kernel boots
Submitter : Sven Joachim <svenjoac-Mmb7MZpHnFY@public.gmane.org>
Date : 2010-02-01 09:08 (7 days old)
First-Bad-Commit: http://git.kernel.org/git/linus/b42d4c5c6a872815d711e5d51a600f5122c38eee
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15193
Subject : kswapd continuously active
Submitter : Jan Engelhardt <jengelh-nopoi9nDyk+ELgA04lAiVw@public.gmane.org>
Date : 2010-01-22 23 (17 days old)
References : http://marc.info/?l=linux-kernel&m=126420434519039&w=4
Handled-By : Jens Axboe <jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15190
Subject : second suspend fails and system freezes in hp 6910P laptop
Submitter : Jithin Emmanuel <jithin1987-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-01-31 15:53 (8 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15188
Subject : Graphic subsystem freeze
Submitter : aix27249 <i27249-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-01-31 12:13 (8 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15158
Subject : oops related to i915_gem_object_save_bit_17_swizzle
Submitter : Werner Lemberg <wl-mXXj517/zsQ@public.gmane.org>
Date : 2010-01-28 08:26 (11 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15156
Subject : 2.6.32.6 hang at boot with ati x1600
Submitter : Alexey Kuznetsov <ak-b7SOpcJQXxU@public.gmane.org>
Date : 2010-01-28 05:02 (11 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15100
Subject : X11 is black after resume from s2ram if my T400 was previous in docking station before
Submitter : Toralf Förster <toralf.foerster-Mmb7MZpHnFY@public.gmane.org>
Date : 2010-01-21 08:56 (18 days old)
First-Bad-Commit: http://git.kernel.org/git/linus/c1c7af60892070e4b82ad63bbfb95ae745056de0
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15096
Subject : Resume lock up -- bisected, commit 3a1151e3f124fd1a2c54b8153f510f1a7c715369
Submitter : Rafał Miłecki <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-01-20 23:15 (19 days old)
First-Bad-Commit: http://git.kernel.org/git/linus/3a1151e3f124fd1a2c54b8153f510f1a7c715369
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15042
Subject : socket(PF_INET6 hangs when ipv6 not yet initialized
Submitter : Marc Haber <mh+linux-kernel-ciUMMiFYEj8OIzVOb1FTxg@public.gmane.org>
Date : 2010-01-10 14:28 (29 days old)
References : http://marc.info/?l=linux-kernel&m=126313553029280&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15021
Subject : agpgart sometimes fails to initialize sometimes
Submitter : Maciej Piechotka <uzytkownik2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-01-09 23:31 (30 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15015
Subject : blank screen at random times in laptop when sitting idle
Submitter : Jithin Emmanuel <jithin1987-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-01-09 16:48 (30 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15004
Subject : i915: *ERROR* Execbuf while wedged
Submitter : tomas m <tmezzadra-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-01-07 18:53 (32 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14998
Subject : Caught 32-bit read from uninitialized memory in acpi_system_read_event -- 2.6.31 regression
Submitter : Christian Casteyde <casteyde.christian-GANU6spQydw@public.gmane.org>
Date : 2010-01-06 21:40 (33 days old)
First-Bad-Commit: http://git.kernel.org/git/linus/eca6f534e61919b28fb21aafbd1c2983deae75be
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14997
Subject : Closing and re-opening the lid does not reactivate the backlight
Submitter : o. meijer <meijer.o-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-01-06 15:38 (33 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14939
Subject : drm: random hang with i915
Submitter : Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Date : 2009-12-07 17:30 (63 days old)
References : http://marc.info/?l=linux-kernel&m=126020704125723&w=4
Handled-By : Jesse Barnes <jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14922
Subject : 2.6.32 seemed to have broken nVidia MCP7A sata controller
Submitter : Mike Cui <cuicui-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2009-12-19 6:13 (51 days old)
References : http://marc.info/?l=linux-ide&m=126120323407742&w=4
Handled-By : Jeff Garzik <jeff-o2qLIJkoznsdnm+yROfE0A@public.gmane.org>
Robert Hancock <hancockrwd-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14898
Subject : ksoftirqd problem
Submitter : Nico <segfault2-PkbjNfxxIARBDgjK7y7TUQ@public.gmane.org>
Date : 2009-12-13 19:05 (57 days old)
References : http://marc.info/?l=linux-kernel&m=126073114325690&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14895
Subject : BUG in kernel 2.6.32 when using luks encrypted root and RAID0..
Submitter : r4 <mk_4-aRb0bU7PRFPrBKCeMvbIDA@public.gmane.org>
Date : 2009-12-03 18:24 (67 days old)
References : http://marc.info/?l=linux-kernel&m=125986664904751&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14891
Subject : Deadlock regression related to NFS root
Submitter : Stephen R. van den Berg <srb-PCMv+cxZuL0@public.gmane.org>
Date : 2009-11-24 0:24 (76 days old)
References : http://marc.info/?l=linux-kernel&m=125902279909452&w=4
Handled-By : Trond Myklebust <Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14868
Subject : flood of "don't try to register things with the same name in the same directory." on upgrade to 2.6.32
Submitter : Rich Ercolani <rercola-YxllIAoeIHiVc3sceRu5cw@public.gmane.org>
Date : 2009-12-24 02:44 (46 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14817
Subject : When is system under load, then freeze/HD fail
Submitter : okias <d.okias-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2009-12-15 11:12 (55 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14782
Subject : Suspend hangs Lenovo SL300 after gdm login
Submitter : Gary Trakhman <gary.trakhman-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2009-12-10 18:53 (60 days old)
First-Bad-Commit: http://git.kernel.org/git/linus/03ba3782e8dcc5b0e1efe440d33084f066e38cae
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14748
Subject : e1000e NIC not working after reboot
Submitter : Maciek Sitarz <macieks-yngNwrTfnRnVItvQsEIGlw@public.gmane.org>
Date : 2009-12-06 13:04 (64 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14695
Subject : regression in karmic thermal control
Submitter : Bugie <public-ZA6dAAr5zYM@public.gmane.org>
Date : 2009-11-26 08:45 (74 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14667
Subject : bisected 2.6.32 EC regression - Temperatures not correctly detected after suspend
Submitter : Federico Chiacchiaretta <federico.chia-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2009-11-22 20:42 (78 days old)
First-Bad-Commit: http://git.kernel.org/git/linus/6a63b06f3c494cc87eade97f081300bda60acec7
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14657
Subject : perf subsystem breakage in 2.6.32-rc7
Submitter : Arjan van de Ven <arjan-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Date : 2009-11-19 19:50 (81 days old)
References : http://marc.info/?l=linux-kernel&m=125866013419738&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14656
Subject : Oops at __rmqueue+0x98 with 2.6.32-rc6
Submitter : Lucas C. Villa Real <lucasvr-9gmU7qdNRpmhPH1hqNUYSQ@public.gmane.org>
Date : 2009-11-19 3:48 (81 days old)
References : http://marc.info/?l=linux-kernel&m=125860255229092&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14624
Subject : ath9k: BUG kmalloc-8192: Poison overwritten
Submitter : Miles Lane <miles.lane-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2009-11-12 4:58 (88 days old)
References : http://marc.info/?l=linux-kernel&m=125800196520396&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14621
Subject : specjbb2005 and aim7 regression with 2.6.32-rc kernels
Submitter : Zhang, Yanmin <yanmin_zhang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Date : 2009-11-06 7:38 (94 days old)
References : http://marc.info/?l=linux-kernel&m=125749310413174&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14504
Subject : intermittent hibernation problem again
Submitter : Ferenc Wágner <wferi-eEbw3PyuezQ@public.gmane.org>
Date : 2009-10-28 23:49 (103 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14442
Subject : resume after hibernate: /dev/sdb drops and returns as /dev/sde
Submitter : Duncan <1i5t5.duncan-j9pdmedNgrk@public.gmane.org>
Date : 2009-10-20 01:52 (111 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14426
Subject : CE: hpet increasing min_delta_ns flood
Submitter : Thibault Mondary <thibm-GANU6spQydw@public.gmane.org>
Date : 2009-10-17 09:29 (114 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14376
Subject : Kernel NULL pointer dereference/ kvm subsystem
Submitter : Don Dupuis <dondster-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2009-10-06 14:38 (125 days old)
References : http://marc.info/?l=linux-kernel&m=125484025021737&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14298
Subject : warning at manage.c:361 (set_irq_wake), matrix-keypad related?
Submitter : Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
Date : 2009-09-30 20:07 (131 days old)
References : http://marc.info/?l=linux-kernel&m=125434130703538&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14297
Subject : console resume broken since ba15ab0e8d
Submitter : Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Date : 2009-09-30 15:11 (131 days old)
First-Bad-Commit: http://git.kernel.org/git/linus/ba15ab0e8de0d4439a91342ad52d55ca9e313f3d
References : http://marc.info/?l=linux-kernel&m=125432349404060&w=4
Regressions with patches
------------------------
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15134
Subject : gobi_loader hangs after commit 8e8dce065088
Submitter : Matthew Garrett <mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
Date : 2010-01-17 2:55 (22 days old)
References : http://marc.info/?l=linux-kernel&m=126369696509502&w=4
Handled-By : Oliver Neukum <oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
Alan Cox <alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>
Patch : http://patchwork.kernel.org/patch/73878/
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15127
Subject : Bluetooth: sleeping function called from invalid context
Submitter : David John <davidjon-XRr60H37pjdAfugRpC6u6w@public.gmane.org>
Date : 2010-01-12 9:19 (27 days old)
First-Bad-Commit: http://git.kernel.org/git/linus/9e726b17422bade75fba94e625cd35fd1353e682
References : http://marc.info/?l=linux-kernel&m=126328727021949&w=4
Handled-By : Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
Patch : http://patchwork.kernel.org/patch/76019/
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15108
Subject : Blank screen with KMS enabled (on clevo M5xN laptop)
Submitter : Jérémy Lal <kapouer-QATUhw8NPUbYtjvyW6yDsg@public.gmane.org>
Date : 2010-01-22 20:30 (17 days old)
Handled-By : Zhang Rui <rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Patch : http://bugzilla.kernel.org/attachment.cgi?id=24740
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15071
Subject : IBM/Lenovo Trackpoint speed, sensitivity reset after suspend
Submitter : Marten Vance <kernel-srgEi2D3yJHR7s880joybQ@public.gmane.org>
Date : 2010-01-16 16:19 (23 days old)
Handled-By : Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Patch : http://bugzilla.kernel.org/attachment.cgi?id=24889
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15040
Subject : High cpu temperature with 2.6.32 - bisected to cpuidle menu update
Submitter : Dimitrios Apostolou <jimis-hi6Y0CQ0nG0@public.gmane.org>
Date : 2010-01-06 17:39 (33 days old)
References : http://marc.info/?l=linux-kernel&m=126279952723036&w=4
Handled-By : Arjan van de Ven <arjan-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Patch : http://patchwork.kernel.org/patch/71962/
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15000
Subject : Thinkpad dock button no longer works
Submitter : Paul Martin <pm-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
Date : 2010-01-07 02:11 (32 days old)
Handled-By : Chris Mason <chris.mason-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Patch : http://patchwork.kernel.org/patch/76110/
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14894
Subject : pohmelfs: NULL pointer dereference
Submitter : Alexander Beregalov <a.beregalov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2009-12-02 1:11 (68 days old)
References : http://marc.info/?l=linux-kernel&m=125971633107940&w=4
Handled-By : Evgeniy Polyakov <zbr-i6C2adt8DTjR7s880joybQ@public.gmane.org>
Jens Axboe <jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Patch : http://patchwork.kernel.org/patch/70211/
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14886
Subject : Asus P2B-DS not detected as SMP moterboard
Submitter : Lorenzo Buzzi <flinco-VGgt2q2+T+FeoWH0uzbU5w@public.gmane.org>
Date : 2009-12-27 17:20 (43 days old)
First-Bad-Commit: http://git.kernel.org/git/linus/e5b8fc6ac158f65598f58dba2c0d52ba3b412f52
Handled-By : Matthew Garrett <mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
Patch : http://patchwork.kernel.org/patch/76089/
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14742
Subject : 2.6.32 new menu idle governor causes very high CPU temp
Submitter : <akwatts-DaQTI0RpDDMAvxtiuMwx3w@public.gmane.org>
Date : 2009-12-05 17:24 (65 days old)
Handled-By : Arjan van de Ven <arjan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Patch : http://bugzilla.kernel.org/show_bug.cgi?id=14742#c7
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14487
Subject : PANIC: early exception 08 rip 246:10 error ffffffff810251b5 cr2 0
Submitter : Justin P. Mattock <justinmattock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2009-10-23 16:45 (108 days old)
References : http://lkml.org/lkml/2009/10/23/252
Handled-By : Jan Beulich <jbeulich-Et1tbQHTxzrQT0dZR+AlfA@public.gmane.org>
Patch : http://patchwork.kernel.org/patch/68719/
For details, please visit the bug entries and follow the links given in
references.
As you can see, there is a Bugzilla entry for each of the listed regressions.
There also is a Bugzilla entry used for tracking the regressions introduced
between 2.6.31 and 2.6.32, unresolved as well as resolved, at:
http://bugzilla.kernel.org/show_bug.cgi?id=14230
Please let the tracking teak know if there are any Bugzilla entries that
should be added to the list in there.
Thanks!
^ permalink raw reply
* linux-next: build failure after merge of the net tree
From: Stephen Rothwell @ 2010-02-08 2:22 UTC (permalink / raw)
To: David Miller, netdev; +Cc: linux-next, linux-kernel, Sridhar Samudrala
[-- Attachment #1: Type: text/plain, Size: 668 bytes --]
Hi Dave,
After merging the net tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
net/packet/af_packet.c: In function 'packet_setsockopt':
net/packet/af_packet.c:1977: error: 'struct packet_sock' has no member named 'rx_ring'
net/packet/af_packet.c:1977: error: 'struct packet_sock' has no member named 'tx_ring'
Caused by commit bfd5f4a3d605e0f6054df0b59fe0907ff7e696d3 ("packet: Add
GSO/csum offload support"). This build has CONFIG_PACKET_MMAP unset.
I used the version of the net tree from next-20100205 for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply
* Re: [PATCH 1/3] fec: fix uninitialized rx buffer usage
From: Greg Ungerer @ 2010-02-08 2:55 UTC (permalink / raw)
To: Amit Kucheria
Cc: List Linux Kernel, Rob Herring, davem, netdev, s.hauer, gerg,
u.kleine-koenig, amit.kucheria
In-Reply-To: <39ec69d1e3af809dcf210f4757ca2385efb5f9bc.1265396105.git.amit.kucheria@canonical.com>
Amit Kucheria wrote:
> From: Rob Herring <r.herring@freescale.com>
>
> The fec driver was enabling receive buffer descriptor without allocating
> the buffers. Make sure the buffer descriptors are initialized to not
> start receiving packets.
>
> Open also calls fec_restart after the rx buffers are allocated. With the code
> in fec_restart, it zeroes out the buffer descriptors that have just been
> setup.
>
> Signed-off-by: Rob Herring <r.herring@freescale.com>
> Signed-off-by: Amit Kucheria <amit.kucheria@canonical.com>
> Acked-by: Grant Likely <grant.likely@secretlab.ca>
Acked-by: Greg Ungerer <gerg@uclinux.org>
> ---
> drivers/net/fec.c | 57 +++++++++++++++++++++++++++--------------------------
> 1 files changed, 29 insertions(+), 28 deletions(-)
>
> diff --git a/drivers/net/fec.c b/drivers/net/fec.c
> index 16a1d58..9a8743d 100644
> --- a/drivers/net/fec.c
> +++ b/drivers/net/fec.c
> @@ -1658,6 +1658,7 @@ static int fec_enet_init(struct net_device *dev, int index)
> {
> struct fec_enet_private *fep = netdev_priv(dev);
> struct bufdesc *cbd_base;
> + struct bufdesc *bdp;
> int i;
>
> /* Allocate memory for buffer descriptors. */
> @@ -1710,6 +1711,34 @@ static int fec_enet_init(struct net_device *dev, int index)
> /* Set MII speed to 2.5 MHz */
> fep->phy_speed = ((((clk_get_rate(fep->clk) / 2 + 4999999)
> / 2500000) / 2) & 0x3F) << 1;
> +
> + /* Initialize the receive buffer descriptors. */
> + bdp = fep->rx_bd_base;
> + for (i = 0; i < RX_RING_SIZE; i++) {
> +
> + /* Initialize the BD for every fragment in the page. */
> + bdp->cbd_sc = 0;
> + bdp++;
> + }
> +
> + /* Set the last buffer to wrap */
> + bdp--;
> + bdp->cbd_sc |= BD_SC_WRAP;
> +
> + /* ...and the same for transmit */
> + bdp = fep->tx_bd_base;
> + for (i = 0; i < TX_RING_SIZE; i++) {
> +
> + /* Initialize the BD for every fragment in the page. */
> + bdp->cbd_sc = 0;
> + bdp->cbd_bufaddr = 0;
> + bdp++;
> + }
> +
> + /* Set the last buffer to wrap */
> + bdp--;
> + bdp->cbd_sc |= BD_SC_WRAP;
> +
> fec_restart(dev, 0);
>
> /* Queue up command to detect the PHY and initialize the
> @@ -1730,7 +1759,6 @@ static void
> fec_restart(struct net_device *dev, int duplex)
> {
> struct fec_enet_private *fep = netdev_priv(dev);
> - struct bufdesc *bdp;
> int i;
>
> /* Whack a reset. We should wait for this. */
> @@ -1768,33 +1796,6 @@ fec_restart(struct net_device *dev, int duplex)
> }
> }
>
> - /* Initialize the receive buffer descriptors. */
> - bdp = fep->rx_bd_base;
> - for (i = 0; i < RX_RING_SIZE; i++) {
> -
> - /* Initialize the BD for every fragment in the page. */
> - bdp->cbd_sc = BD_ENET_RX_EMPTY;
> - bdp++;
> - }
> -
> - /* Set the last buffer to wrap */
> - bdp--;
> - bdp->cbd_sc |= BD_SC_WRAP;
> -
> - /* ...and the same for transmit */
> - bdp = fep->tx_bd_base;
> - for (i = 0; i < TX_RING_SIZE; i++) {
> -
> - /* Initialize the BD for every fragment in the page. */
> - bdp->cbd_sc = 0;
> - bdp->cbd_bufaddr = 0;
> - bdp++;
> - }
> -
> - /* Set the last buffer to wrap */
> - bdp--;
> - bdp->cbd_sc |= BD_SC_WRAP;
> -
> /* Enable MII mode */
> if (duplex) {
> /* MII enable / FD enable */
--
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
^ permalink raw reply
* Re: [RFC Patch v2] net: reserve ports for applications using fixedport numbers
From: Cong Wang @ 2010-02-08 3:15 UTC (permalink / raw)
To: Tetsuo Handa
Cc: linux-kernel, linux-security-module, opurdila, eric.dumazet,
linux-rdma, netdev, nhorman, linux-sctp, davem
In-Reply-To: <201002052021.CIC81776.QVSMJOLtFOFFHO@I-love.SAKURA.ne.jp>
Tetsuo Handa wrote:
> Cong Wang wrote:
>> Oh, IIUC, TOMOYO is something like SELinux?
>
> Yes. It is a policy based mandatory access control implementation which is
> applied to not only non root users but also root user. If MAC is enabled,
> root user cannot freely modify via sysctl() or /proc/sys interface.
>
>> So, it is somewhat weird to let users to use TOMOYO to reserve
>> the ports with MAC.
>
> To add reserved port
>
> echo deny_autobind 0-1023 | ccs-loadpolicy -e
> echo deny_autobind 3128 | ccs-loadpolicy -e
> echo deny_autobind 8080 | ccs-loadpolicy -e
>
> and to delete reserved port
>
> echo delete deny_autobind 0-1023 | ccs-loadpolicy -e
> echo delete deny_autobind 3128 | ccs-loadpolicy -e
> echo delete deny_autobind 8080 | ccs-loadpolicy -e
>
> That's all. Quite easy.
Hmm, but you are solving a non-security problem with a security
tool, doesn't this look weird? ;-)
>
>> For normal users /proc interface seems more friendly.
>
> I think /proc/sys/net/ipv4/ip_local_reserved_ports interface wants
> "struct list_head" for handling multiple sets of min/max pairs. I'm using
> http://tomoyo.sourceforge.jp/cgi-bin/lxr/source/security/ccsecurity/autobind.c#L29
> for that purpose.
Yes, but I didn't plan to add multiple range support for
ip_local_reserved_ports, like ip_local_port_range.
Having that will be better but needs more efforts.
Thanks.
^ permalink raw reply
* Re: [RFC Patch] net: reserve ports for applications using fixed port numbers
From: Cong Wang @ 2010-02-08 3:21 UTC (permalink / raw)
To: Octavian Purdila
Cc: David Miller, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w,
linux-rdma-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA,
nhorman-2XuSBdqkA4R54TAoqtyWWQ, linux-sctp-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <201002051405.54029.opurdila-+zzKsuq53OdBDgjK7y7TUQ@public.gmane.org>
Octavian Purdila wrote:
> On Friday 05 February 2010 06:45:38 you wrote:
>
>> Again, using bitmap algorithm is not a problem and it's better, the
>> problem is sysctl interface, how would you plan to interact with users
>> via sysctl/proc if you use bitmap to handle this? I would like to hear
>> more details about this.
>>
>
> We could use something like positive values for setting and negative for reset
> (e.g. 3 would set the port in the bitmap and -3 would reset it).
Hmm, then how do you output the info of those ports? Arrays of bitmaps?
>
> But we would need new sysctl and proc handlers to handle the bitmap case (e.g.
> sysctl_bitmap, proc_dobitmap_minmax).
Maybe.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* inet: Remove bogus IGMPv3 report handling
From: Herbert Xu @ 2010-02-08 3:26 UTC (permalink / raw)
To: David S. Miller, netdev
Hi:
inet: Remove bogus IGMPv3 report handling
Currently we treat IGMPv3 reports as if it were an IGMPv2/v1 report.
This is broken as IGMPv3 reports are formatted differently. So we
end up suppressing a bogus multicast group (which should be harmless
as long as the leading reserved field is zero).
In fact, IGMPv3 does not allow membership report suppression so
we should simply ignore IGMPv3 membership reports as a host.
This patch does exactly that. I kept the case statement for it
so people won't accidentally add it back thinking that we overlooked
this case.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c
index 76c0840..a42f658 100644
--- a/net/ipv4/igmp.c
+++ b/net/ipv4/igmp.c
@@ -946,7 +946,6 @@ int igmp_rcv(struct sk_buff *skb)
break;
case IGMP_HOST_MEMBERSHIP_REPORT:
case IGMPV2_HOST_MEMBERSHIP_REPORT:
- case IGMPV3_HOST_MEMBERSHIP_REPORT:
/* Is it our report looped back? */
if (skb_rtable(skb)->fl.iif == 0)
break;
@@ -960,6 +959,7 @@ int igmp_rcv(struct sk_buff *skb)
in_dev_put(in_dev);
return pim_rcv_v1(skb);
#endif
+ case IGMPV3_HOST_MEMBERSHIP_REPORT:
case IGMP_DVMRP:
case IGMP_TRACE:
case IGMP_HOST_LEAVE_MESSAGE:
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply related
* Re: linux-next: build failure after merge of the net tree
From: David Miller @ 2010-02-08 3:40 UTC (permalink / raw)
To: sfr; +Cc: netdev, linux-next, linux-kernel, sri
In-Reply-To: <20100208132243.ab967d9c.sfr@canb.auug.org.au>
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 8 Feb 2010 13:22:43 +1100
> After merging the net tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
...
> Caused by commit bfd5f4a3d605e0f6054df0b59fe0907ff7e696d3 ("packet: Add
> GSO/csum offload support"). This build has CONFIG_PACKET_MMAP unset.
>
> I used the version of the net tree from next-20100205 for today.
Known problem, I'm fixing it by killing the config option,
everyone should have that thing enabled by now.
^ permalink raw reply
* Re: linux-next: build failure after merge of the net tree
From: Stephen Rothwell @ 2010-02-08 3:58 UTC (permalink / raw)
To: David Miller; +Cc: netdev, linux-next, linux-kernel, sri
In-Reply-To: <20100207.194022.53074897.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 334 bytes --]
Hi Dave,
On Sun, 07 Feb 2010 19:40:22 -0800 (PST) David Miller <davem@davemloft.net> wrote:
>
> Known problem, I'm fixing it by killing the config option,
> everyone should have that thing enabled by now.
OK, thanks.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply
* Re: rps: question
From: Tom Herbert @ 2010-02-08 5:58 UTC (permalink / raw)
To: hadi; +Cc: Eric Dumazet, netdev, robert, David Miller
In-Reply-To: <1265568122.3688.36.camel@bigi>
On Sun, Feb 7, 2010 at 10:42 AM, jamal <hadi@cyberus.ca> wrote:
>
> Hi Tom,
>
> First off: Kudos on the numbers you are seeing; they are
> impressive. Do you have any numbers on a forwarding path test?
>
I don't have specific numbers, although we are using this on
application doing forwarding and numbers seem in line with what we see
for an end host.
> My first impression when i saw the numbers was one of suprise.
> Back in the days when we tried to split stack processing the way
> you did(it was one of the experiments on early NAPI), IPIs were
> _damn_ expensive. What changed in current architecture that makes
> this more palatable? IPIs are still synchronous AFAIK (and the more
> IPI receiver there are, the worse the ACK latency). Did you test this
> across other archs or say 3-4 year old machines?
>
No, the cost of the IPIs hasn't been an issue for us performance-wise.
We are using them extensively-- up to one per core per device
interrupt.
We're calling __smp_call_function_single which is asynchronous in that
the caller provides the call structure and there is not waiting for
the IPI to complete. A flag is used with each call structure that is
set when the IPI is in progress, this prevents simultaneous use of a
call structure.
I haven't seen any architectural specific issues with the IPIs, I
believe they are completing in < 2 usecs on platforms we're running
(some opteron systems that are over 3yrs old).
Tom
> cheers,
> jamal
>
^ permalink raw reply
* [PATCH 1/1] dccp: allow probing of CCID-array length
From: Gerrit Renker @ 2010-02-08 6:20 UTC (permalink / raw)
To: dccp; +Cc: netdev
This fixes a problem in the DCCP getsockopt() API: currently there is no way
for a user to a priori know the number of built-in CCIDs, other than trying
DCCP_SOCKOPT_AVAILABLE_CCIDS in a loop, incrementing the option length until
EINVAL is no longer returned.
This patch truncates the array to the user-provided length. No copy is made
when the length is <= 0.
Due to the length restriction in do_dccp_getsockopt() to sizeof(int), the
minimum array length remains 4, which is a reasonable default (only 3
CCIDs, CCID-2..4, are currently defined).
Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
---
Documentation/networking/dccp.txt | 6 ++++--
net/dccp/ccid.c | 9 ++++-----
2 files changed, 8 insertions(+), 7 deletions(-)
--- a/Documentation/networking/dccp.txt
+++ b/Documentation/networking/dccp.txt
@@ -58,8 +58,10 @@ DCCP_SOCKOPT_GET_CUR_MPS is read-only and retrieves the current maximum packet
size (application payload size) in bytes, see RFC 4340, section 14.
DCCP_SOCKOPT_AVAILABLE_CCIDS is also read-only and returns the list of CCIDs
-supported by the endpoint (see include/linux/dccp.h for symbolic constants).
-The caller needs to provide a sufficiently large (> 2) array of type uint8_t.
+supported by the endpoint. The option value is an array of type uint8_t whose
+size is passed as option length. The minimum array size is 4 elements, the
+value returned in the optlen argument always reflects the true number of
+built-in CCIDs.
DCCP_SOCKOPT_CCID is write-only and sets both the TX and RX CCIDs at the same
time, combining the operation of the next two socket options. This option is
--- a/net/dccp/ccid.c
+++ b/net/dccp/ccid.c
@@ -63,14 +63,13 @@ int ccid_getsockopt_builtin_ccids(struct sock *sk, int len,
u8 *ccid_array, array_len;
int err = 0;
- if (len < ARRAY_SIZE(ccids))
- return -EINVAL;
-
if (ccid_get_builtin_ccids(&ccid_array, &array_len))
return -ENOBUFS;
- if (put_user(array_len, optlen) ||
- copy_to_user(optval, ccid_array, array_len))
+ if (put_user(array_len, optlen))
+ err = -EFAULT;
+ else if (len > 0 && copy_to_user(optval, ccid_array,
+ len > array_len ? array_len : len))
err = -EFAULT;
kfree(ccid_array);
^ permalink raw reply
* Re: [PATCH] vhost-net: switch to smp barriers
From: Rusty Russell @ 2010-02-08 8:19 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: kvm, virtualization, netdev, linux-kernel, David Miller
In-Reply-To: <20100207090749.GA12968@redhat.com>
On Sun, 7 Feb 2010 07:37:49 pm Michael S. Tsirkin wrote:
> On Mon, Feb 01, 2010 at 07:21:02PM +0200, Michael S. Tsirkin wrote:
> > vhost-net only uses memory barriers to control SMP effects
> > (communication with userspace potentially running on a different CPU),
> > so it should use SMP barriers and not mandatory barriers for memory
> > access ordering, as suggested by Documentation/memory-barriers.txt
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
>
> Rusty, any feedback on this one?
> Thanks!
Yep. barrier() is correct on UP to guard against preemption.
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Thanks,
Rusty.
^ permalink raw reply
* smsc911x suspend/resume
From: Mike Rapoport @ 2010-02-08 9:42 UTC (permalink / raw)
To: Steve Glendinning; +Cc: netdev, LAKML
Hi all,
I'm trying to make suspend/resume work on OMAP3-based system and I'm
encountering issues with resume of SMSC 9220 chip.
After resume the interface is unusable unless I do 'ifconfig eth0 down'
and 'ifconfig eth0 up'.
I would expect that 'ping <some host>' would work right after resume
without need to bring the interface down and up, but probably I miss
something.
Any help would be appreciated.
--
Sincerely yours,
Mike.
^ permalink raw reply
* MAX_SKB_FRAGS and GRO
From: Anton Blanchard @ 2010-02-08 10:03 UTC (permalink / raw)
To: herbert
Cc: Jeff Kirsher, Jesse Brandeburg, Bruce Allan, Alex Duyck,
PJ Waskiewicz, John Ronciak, divy, netdev
[-- Attachment #1: Type: text/plain, Size: 1762 bytes --]
Hi Herbert,
I was looking through the hardware GRO support in various drivers and I think
we have a couple of issues with PAGE_SIZE > 4k. For example, if we have a 64kB
page size then MAX_SKB_FRAGS ends up as 3:
#define MAX_SKB_FRAGS (65536/PAGE_SIZE + 2)
This should be fine for hardware and software GSO, but we encounter issues
with hardware GRO (not sure about software GRO).
In the ixgbe case we use MAX_SKB_FRAGS to program the max number of GRO
descriptors, even though we assemble GRO packets using ->frag_list:
#if (MAX_SKB_FRAGS > 16)
rscctrl |= IXGBE_RSCCTL_MAXDESC_16;
#elif (MAX_SKB_FRAGS > 8)
rscctrl |= IXGBE_RSCCTL_MAXDESC_8;
#elif (MAX_SKB_FRAGS > 4)
rscctrl |= IXGBE_RSCCTL_MAXDESC_4;
#else
rscctrl |= IXGBE_RSCCTL_MAXDESC_1;
#endif
With MAX_SKB_FRAGS = 3 it looks like we only allow 1 GRO descriptor, and since
the card can only do DMAs of 16kB that will be our maximum GRO packet.
I don't have a hardware GRO capable ixgbe to try this out yet, but I think
we want to do something like the attached (completely untested) patch, dividing
GSO_MAX_SIZE by our per packet maximum.
In the cxgb3 case we build GRO packets via ->frags. (FYI I had a look through
the driver but I wasn't able to see where it caps GRO assembly to
MAX_SKB_FRAGS, probably missing something). cxgb3 may be able to do 64kB
DMAs (again not sure), but you could imagine a card with DMA restrictions,
perhaps as bad as 4kB per descriptor. In this case MAX_SKB_FRAGS is sized way
too small.
Thinking out aloud, would setting a pessimistic value for MAX_SKB_FRAGS
be one way to fix this? ie:
#define MAX_SKB_FRAGS (65536/4096 + 2)
I'm not sure if that would break the tx side of some adapters.
Anton
[-- Attachment #2: ixgbe_hw_gro.patch --]
[-- Type: text/x-diff, Size: 1769 bytes --]
diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
index b5f64ad..283f6cc 100644
--- a/drivers/net/ixgbe/ixgbe_main.c
+++ b/drivers/net/ixgbe/ixgbe_main.c
@@ -644,6 +644,13 @@ static inline void ixgbe_release_rx_desc(struct ixgbe_hw *hw,
IXGBE_WRITE_REG(hw, IXGBE_RDT(rx_ring->reg_idx), val);
}
+/* The maximum DMA the card can do is 16kB, so cap it if required */
+#if (PAGE_SIZE / 2) > IXGBE_MAX_RXBUFFER
+#define IXGBE_RXBUFFER_SIZE IXGBE_MAX_RXBUFFER
+#else
+#define IXGBE_RXBUFFER_SIZE (PAGE_SIZE / 2)
+#endif
+
/**
* ixgbe_alloc_rx_buffers - Replace used receive buffers; packet split
* @adapter: address of board private structure
@@ -2032,11 +2039,7 @@ static void ixgbe_configure_srrctl(struct ixgbe_adapter *adapter,
IXGBE_SRRCTL_BSIZEHDR_MASK;
if (rx_ring->flags & IXGBE_RING_RX_PS_ENABLED) {
-#if (PAGE_SIZE / 2) > IXGBE_MAX_RXBUFFER
- srrctl |= IXGBE_MAX_RXBUFFER >> IXGBE_SRRCTL_BSIZEPKT_SHIFT;
-#else
- srrctl |= (PAGE_SIZE / 2) >> IXGBE_SRRCTL_BSIZEPKT_SHIFT;
-#endif
+ srrctl |= IXGBE_RXBUFFER_SIZE >> IXGBE_SRRCTL_BSIZEPKT_SHIFT;
srrctl |= IXGBE_SRRCTL_DESCTYPE_HDR_SPLIT_ALWAYS;
} else {
srrctl |= ALIGN(rx_ring->rx_buf_len, 1024) >>
@@ -2101,11 +2104,11 @@ static void ixgbe_configure_rscctl(struct ixgbe_adapter *adapter, int index)
* than 65535
*/
if (rx_ring->flags & IXGBE_RING_RX_PS_ENABLED) {
-#if (MAX_SKB_FRAGS > 16)
+#if (GSO_MAX_SIZE / IXGBE_RXBUFFER_SIZE) >= 16
rscctrl |= IXGBE_RSCCTL_MAXDESC_16;
-#elif (MAX_SKB_FRAGS > 8)
+#elif (GSO_MAX_SIZE / IXGBE_RXBUFFER_SIZE) >= 8
rscctrl |= IXGBE_RSCCTL_MAXDESC_8;
-#elif (MAX_SKB_FRAGS > 4)
+#elif (GSO_MAX_SIZE / IXGBE_RXBUFFER_SIZE) >= 4
rscctrl |= IXGBE_RSCCTL_MAXDESC_4;
#else
rscctrl |= IXGBE_RSCCTL_MAXDESC_1;
^ permalink raw reply related
* Re: smsc911x suspend/resume
From: Daniel Mack @ 2010-02-08 10:11 UTC (permalink / raw)
To: Mike Rapoport; +Cc: Steve Glendinning, netdev, LAKML
In-Reply-To: <4B6FDC83.9090205@compulab.co.il>
On Mon, Feb 08, 2010 at 11:42:27AM +0200, Mike Rapoport wrote:
> I'm trying to make suspend/resume work on OMAP3-based system and I'm
> encountering issues with resume of SMSC 9220 chip.
> After resume the interface is unusable unless I do 'ifconfig eth0 down'
> and 'ifconfig eth0 up'.
> I would expect that 'ping <some host>' would work right after resume
> without need to bring the interface down and up, but probably I miss
> something.
> Any help would be appreciated.
What happens to your supply voltages when going to suspend? When I
implemented the code for the smsc driver, I could only test scenarios
where AVDD remains stable during suspend. So the driver might need some
tweaks if that assumption is not true in your case. The SMSC datasheet
is quite comprehensive about this topic IIRC.
Also have a look at the Raumfeld device patches which use exactly this
chip and which can suspend and resume just fine. You'll need to check
out Eric's devel branch for that.
Daniel
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox