* Re: [patch 4/5] obsolete config in kernel source: USE_INTERNAL_TIMER
From: David Miller @ 2010-03-15 23:05 UTC (permalink / raw)
To: akpm; +Cc: netdev, siccegge, roel.kluin
In-Reply-To: <201003112207.o2BM7rlU013495@imap1.linux-foundation.org>
From: akpm@linux-foundation.org
Date: Thu, 11 Mar 2010 14:07:52 -0800
> From: Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>
>
> CONFIG_USE_INTERNAL_TIMER seems to be the remainings of some experiment.
> It is explicitely #undef-ed as not working, only referenced from one
> source file and rather aged.
>
> Hereby cleaning it from the kernel tree.
>
> Signed-off-by: Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>
> Acked-by: Roel Kluin <roel.kluin@gmail.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Applied.
^ permalink raw reply
* Re: [patch 3/5] LL TEMAC driver: add non-Virtex 5 support
From: David Miller @ 2010-03-15 23:05 UTC (permalink / raw)
To: akpm; +Cc: netdev, jtyner, afleming, grant.likely
In-Reply-To: <201003112207.o2BM7qhv013492@imap1.linux-foundation.org>
From: akpm@linux-foundation.org
Date: Thu, 11 Mar 2010 14:07:51 -0800
> From: John Tyner <jtyner@cs.ucr.edu>
>
> Add support for using the LL TEMAC Ethernet driver on non-Virtex 5
> platforms by adding support for accessing the Soft DMA registers as if
> they were memory mapped instead of solely through the DCR's (available on
> the Virtex 5).
>
> Signed-off-by: John Tyner <jtyner@cs.ucr.edu>
> Cc: Andy Fleming <afleming@freescale.com>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: David S. Miller <davem@davemloft.net>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This is still going through revision, so I'm holding off
on this.
^ permalink raw reply
* Re: [patch 2/5] atm: use for_each_set_bit()
From: David Miller @ 2010-03-15 23:05 UTC (permalink / raw)
To: akpm; +Cc: netdev, akinobu.mita, chas
In-Reply-To: <201003112207.o2BM7o2e013489@imap1.linux-foundation.org>
From: akpm@linux-foundation.org
Date: Thu, 11 Mar 2010 14:07:50 -0800
> From: Akinobu Mita <akinobu.mita@gmail.com>
>
> Replace open-coded loop with for_each_set_bit().
>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> Cc: Chas Williams <chas@cmf.nrl.navy.mil>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Applied.
^ permalink raw reply
* Re: [patch 1/5] phonet: use for_each_set_bit()
From: David Miller @ 2010-03-15 23:05 UTC (permalink / raw)
To: akpm; +Cc: netdev, akinobu.mita
In-Reply-To: <201003112207.o2BM7nQn013486@imap1.linux-foundation.org>
From: akpm@linux-foundation.org
Date: Thu, 11 Mar 2010 14:07:49 -0800
> From: Akinobu Mita <akinobu.mita@gmail.com>
>
> Replace open-coded loop with for_each_set_bit().
>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Applied.
^ permalink raw reply
* Re: [PATCH] timestamping: fix example build
From: David Miller @ 2010-03-15 23:05 UTC (permalink / raw)
To: randy.dunlap; +Cc: netdev, patrick.ohly
In-Reply-To: <4B9B214F.4040005@oracle.com>
From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Fri, 12 Mar 2010 21:23:27 -0800
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix Makefiles so that Documentation/networking/timestamping/timestamping.c
> will build when using the CONFIG_BUILD_DOCSRC kconfig option.
> (timestamping.c does not build currently with its simple Makefile.)
>
> Also fix printf format warnings.
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Patrick Ohly <patrick.ohly@intel.com>
Applied, thanks Randy.
^ permalink raw reply
* Re: [PATCH] ISDN: Add PCI ID for HFC-2S/4S Beronet Card PCIe
From: David Miller @ 2010-03-15 23:01 UTC (permalink / raw)
To: keil; +Cc: torvalds, lars.ellenberg, netdev, andreas, akpm, linux-kernel
In-Reply-To: <1268668176.12629@pingi>
From: Karsten Keil <keil@b1-systems.de>
Date: Mon, 15 Mar 2010 14:18:41 +0100
> A few subdevice IDs seem to have been dropped when hfc_multi was
> included upstream, just compare the list at
> http://www.openvox.cn/viewvc/misdn/trunk/hfc_multi.c?revision=75&view=annotate#l175
> with the IDs in drivers/isdn/hardware/mISDN/hfcmulti.c
>
> Added PCIe 2 Port card and LED settings (same as PCI) /KKe
>
> Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
> Signed-off-by: Karsten Keil <keil@b1-systems.de>
We don't add new defines to linux/pci_ids.h, it is deprecated.
Simply add the device ID constants to the table.
The only exception is the case where a device ID is used in
more than one driver, but even that scenerio is heavily
discouraged.
^ permalink raw reply
* Re: [PATCH net-2.6 2/3] jme: Adding lock to protect vlgrp structure.
From: David Miller @ 2010-03-15 22:54 UTC (permalink / raw)
To: cooldavid; +Cc: netdev, ethanhsiao
In-Reply-To: <1268630108-10374-2-git-send-email-cooldavid@cooldavid.org>
Please respin this whole patch set when you fix this
vlgrp locking the way I told you to.
Also, please don't submit a seperate series for 2.6.33 it only creates
confusion. Just add a "CC: stable@kernel.org" right after your
signoff line and it'll get sorted out automatically once the patch
reaches Linus's tree.
^ permalink raw reply
* Re: [PATCH v2.6.33 2/2] jme: Adding lock to protect vlgrp structure.
From: David Miller @ 2010-03-15 22:53 UTC (permalink / raw)
To: cooldavid; +Cc: chavey, ethanhsiao, netdev
In-Reply-To: <20100315191339.M2560@cooldavid.org>
From: "Guo-Fu Tseng" <cooldavid@cooldavid.org>
Date: Tue, 16 Mar 2010 03:13:33 +0800
> The vlan_rx_register is called through ioctl.
> And the packet feeding is called in the tasklet.
> I see no lock in register_vlan_dev(), register_vlan_device(), and vlan_ioctl_handler()
> which is related to the vlan_hwaccel_receive_skb(), vlan_hwaccel_rx().
>
> It prevents the vlgrp pointer be modified while trying to feed the packet.
This is not how you fix this. Adding a new lock to your hot code
path of packet receiving is the last thing you should be doing.
Instead, do what other drivers do, take down the device and bring it
back up again when changing the ->vlgrp pointer.
See drivers/net/tg3.c:tg3_vlan_rx_register() for an example.
^ permalink raw reply
* Re: [patch 3/3] i4l: change magic numbers in Eicon DIVA ISDN driver to symbolic names
From: David Miller @ 2010-03-15 22:48 UTC (permalink / raw)
To: akpm; +Cc: isdn, netdev, imunsie, mac, sgayda2
In-Reply-To: <201003112207.o2BM7PlG013464@imap1.linux-foundation.org>
From: akpm@linux-foundation.org
Date: Thu, 11 Mar 2010 14:07:25 -0800
> From: Ian Munsie <imunsie@au.ibm.com>
>
> Replace references to the '20' magic number found throughout the Eicon
> ISDN driver for the length of the station_id field in the T30_INFO struct
> with the T30_MAX_STATION_ID_LENGTH symbolic constant.
>
> Signed-off-by: Ian Munsie <imunsie@au.ibm.com>
> Cc: Armin Schindler <mac@melware.de>
> Cc: Karsten Keil <isdn@linux-pingi.de>
> Cc: Stoyan Gaydarov <sgayda2@uiuc.edu>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Applied.
^ permalink raw reply
* Re: [patch 2/3] i4l: silence compiler warnings for array access in Eicon DIVA ISDN driver
From: David Miller @ 2010-03-15 22:48 UTC (permalink / raw)
To: akpm; +Cc: isdn, netdev, imunsie, mac, sgayda2
In-Reply-To: <201003112207.o2BM7OZg013459@imap1.linux-foundation.org>
From: akpm@linux-foundation.org
Date: Thu, 11 Mar 2010 14:07:24 -0800
> From: Ian Munsie <imunsie@au.ibm.com>
>
> When compiling this driver, the compiler throws the following warnings:
>
> drivers/isdn/hardware/eicon/message.c:8426: warning: array subscript is above array bounds
> drivers/isdn/hardware/eicon/message.c:8427: warning: array subscript is above array bounds
> drivers/isdn/hardware/eicon/message.c:8434: warning: array subscript is above array bounds
> drivers/isdn/hardware/eicon/message.c:8435: warning: array subscript is above array bounds
> drivers/isdn/hardware/eicon/message.c:8436: warning: array subscript is above array bounds
> drivers/isdn/hardware/eicon/message.c:8447: warning: array subscript is above array bounds
>
> This arises from the particular semantics the driver is using to write to
> the nlc array (static byte[256]). The array has a length in byte 0
> followed by a T30_INFO struct starting at byte 1.
>
> The T30_INFO struct has a number of variable length strings after the
> station_id entry, which cannot be explicitly defined in the struct and the
> driver accesses them with an array index to station_id beyond the length
> of station_id.
>
> This patch merely changes the semantics that the driver uses to access the
> entries after the station_id entry to use the original 256 byte nlc array
> taking the offset and length of the station_id entry to calculate where to
> write in the array, thereby silencing the warning.
>
> Signed-off-by: Ian Munsie <imunsie@au.ibm.com>
> Cc: Armin Schindler <mac@melware.de>
> Cc: Karsten Keil <isdn@linux-pingi.de>
> Cc: Stoyan Gaydarov <sgayda2@uiuc.edu>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Applied.
^ permalink raw reply
* Re: [patch 1/3] isdn: misplaced parenthesis in pof_handle_data()
From: David Miller @ 2010-03-15 22:48 UTC (permalink / raw)
To: akpm; +Cc: isdn, netdev, roel.kluin
In-Reply-To: <201003112207.o2BM7M3U013456@imap1.linux-foundation.org>
From: akpm@linux-foundation.org
Date: Thu, 11 Mar 2010 14:07:22 -0800
> From: Roel Kluin <roel.kluin@gmail.com>
>
> The parenthesis was misplaced.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> Cc: Karsten Keil <isdn@linux-pingi.de>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Applied.
^ permalink raw reply
* Re: [PATCH net-2.6] be2net: fix mccq create for big endian architectures
From: David Miller @ 2010-03-15 22:48 UTC (permalink / raw)
To: ajitk; +Cc: netdev
In-Reply-To: <20100311113548.GA12029@serverengines.com>
From: Ajit Khaparde <ajitk@serverengines.com>
Date: Thu, 11 Mar 2010 17:05:59 +0530
> The request to create an mccq was being dispatched without
> doing a byte swap of num_pages. This byte swap is necessary
> for Big Endian systems like PPC. Not having this fix leads
> mccq create to fail on BE ASICs running newer version of
> firmware, thereby causing driver initialization failure.
>
> Signed-off-by: Ajit Khaparde <ajitk@serverengines.com>
Applied.
^ permalink raw reply
* Re: [PATCH] TI DaVinci EMAC: Convert to dev_pm_ops
From: David Miller @ 2010-03-15 22:48 UTC (permalink / raw)
To: khilman; +Cc: chaithrika, netdev, davinci-linux-open-source
In-Reply-To: <87zl2d3ys0.fsf@deeprootsystems.com>
From: Kevin Hilman <khilman@deeprootsystems.com>
Date: Fri, 12 Mar 2010 15:28:47 -0800
> Chaithrika U S <chaithrika@ti.com> writes:
>
>> Migrate from the legacy PM hooks to use dev_pm_ops structure.
>>
>> Signed-off-by: Chaithrika U S <chaithrika@ti.com>
>
> Acked-by: Kevin Hilman <khilman@deeprootsystems.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH] net: davinci emac: use dma_{map, unmap}_single API for cache coherency
From: David Miller @ 2010-03-15 22:47 UTC (permalink / raw)
To: khilman; +Cc: nsekhar, netdev, srk, davinci-linux-open-source
In-Reply-To: <87eijqbh8e.fsf@deeprootsystems.com>
From: Kevin Hilman <khilman@deeprootsystems.com>
Date: Thu, 11 Mar 2010 14:56:01 -0800
> Sekhar Nori <nsekhar@ti.com> writes:
>
>> The davinci emac driver uses some ARM specific DMA APIs
>> for cache coherency which have been removed from kernel
>> with the 2.6.34 merge.
>>
>> Modify the driver to use the dma_{map, unmap}_single() APIs
>> defined in dma-mapping.h
>>
>> Without this fix, the driver fails to compile on Linus's
>> tree.
>>
>> Tested on DM365 and OMAP-L138 EVMs.
>>
>> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
>
> Acked-by: Kevin Hilman <khilman@deeprootsystems.com>
>
> Verified that this is compiling/running again with v2.6.34-rc1.
Applied, thanks.
^ permalink raw reply
* Re: [PATCH 3/4] bnx2x: change smp_mb() comment to conform the true
From: David Miller @ 2010-03-15 22:47 UTC (permalink / raw)
To: eilong; +Cc: sgruszka, netdev, vladz, mchan
In-Reply-To: <1268236876.30985.3.camel@lb-tlvb-eilong.il.broadcom.com>
From: "Eilon Greenstein" <eilong@broadcom.com>
Date: Wed, 10 Mar 2010 18:01:16 +0200
> On Tue, 2010-03-09 at 08:55 -0800, Stanislaw Gruszka wrote:
>> Access to fp->tx_bp_prod is protected by __netif_tx_lock,
>> smp_mb() is not needed for that.
>>
>> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Applied.
^ permalink raw reply
* Re: [PATCH 2/5] drivers/net: drop redundant memset
From: David Miller @ 2010-03-15 22:47 UTC (permalink / raw)
To: julia
Cc: ram.vepa, santosh.rastapur, sivakumar.subramani,
sreenivasa.honnur, anil.murthy, netdev, linux-kernel,
kernel-janitors
In-Reply-To: <Pine.LNX.4.64.1003092213500.4974@ask.diku.dk>
From: Julia Lawall <julia@diku.dk>
Date: Tue, 9 Mar 2010 22:14:11 +0100 (CET)
> From: Julia Lawall <julia@diku.dk>
>
> The region set by the call to memset is immediately overwritten by the
> subsequent call to memcpy.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression e1,e2,e3,e4;
> @@
>
> - memset(e1,e2,e3);
> memcpy(e1,e4,e3);
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied, thanks!
^ permalink raw reply
* Re: [PATCH 2/4] bnx2x: remove not necessary compiler barrier
From: David Miller @ 2010-03-15 22:47 UTC (permalink / raw)
To: eilong; +Cc: sgruszka, netdev, vladz, mchan
In-Reply-To: <1268236857.30985.2.camel@lb-tlvb-eilong.il.broadcom.com>
From: "Eilon Greenstein" <eilong@broadcom.com>
Date: Wed, 10 Mar 2010 18:00:57 +0200
> On Tue, 2010-03-09 at 08:55 -0800, Stanislaw Gruszka wrote:
>> Access to fp->tx_bd_prod is protected by __netif_tx_lock, so we do not
>> need any barrier for that.
>>
>> Update of fp->tx_bd_cons in bnx2x_tx_int() is not protected by lock, but
>> barrier() nor smb_mb() in bnx2x_tx_avail() not guarantee we will see
>> values that is written on other cpu. Ordering issues between
>> netif_tx_stop_queue(), netif_tx_queue_stopped(), fp->tx_bd_cons = bd_cons
>> and bnx2x_tx_avail() are already handled by smp_mb() in bnx2x_tx_int()
>> and bnx2x_start_xmit().
>>
>> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Applied.
^ permalink raw reply
* Re: [PATCH 1/4] bnx2x: use smp_mb() to keep ordering of read write operations
From: David Miller @ 2010-03-15 22:47 UTC (permalink / raw)
To: eilong; +Cc: sgruszka, netdev, vladz, mchan
In-Reply-To: <1268236784.30985.0.camel@lb-tlvb-eilong.il.broadcom.com>
From: "Eilon Greenstein" <eilong@broadcom.com>
Date: Wed, 10 Mar 2010 17:59:44 +0200
> On Tue, 2010-03-09 at 08:55 -0800, Stanislaw Gruszka wrote:
>> Since we want to keep ordering of write to fp->bd_tx_cons and
>> netif_tx_queue_stopped(txq), what is read of txq->state, we have to use
>> general memory barrier.
>>
>> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> Singed-of-by: Eilon Greenstein <eilong@broadcom.com>
Applied.
^ permalink raw reply
* Re: [PATCH 0/4] SMSC LAN75xx USB gigabit ethernet adapter driver
From: David Miller @ 2010-03-15 22:40 UTC (permalink / raw)
To: steve.glendinning; +Cc: netdev
In-Reply-To: <1268245617-13698-1-git-send-email-steve.glendinning@smsc.com>
From: Steve Glendinning <steve.glendinning@smsc.com>
Date: Wed, 10 Mar 2010 18:26:53 +0000
> This patchset adds a driver for SMSC's new LAN7500 USB 2.0 to Gigabit
> Ethernet controller.
Please combine all of these changes into one big commit that simply
adds the new driver. It's just commit noice the way you have
submitted this currently.
Thanks.
^ permalink raw reply
* Re: [PATCH 3/6] smsc95xx: add constant definition for SMSC USB vendor id
From: David Miller @ 2010-03-15 22:39 UTC (permalink / raw)
To: steve.glendinning; +Cc: netdev
In-Reply-To: <1268245959-13861-4-git-send-email-steve.glendinning@smsc.com>
From: Steve Glendinning <steve.glendinning@smsc.com>
Date: Wed, 10 Mar 2010 18:32:36 +0000
> Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>
I don't see any real need for this, really. It's a constant,
device ID tables are constants and people know how to go lookup
a vendor ID if they really want to know who it is. This doesn't
add any readability to the driver at all.
Also you're mixing cleanups and bug fixes into your patch
set. Please seperate out the pure bug fixes so I can apply
them to net-2.6 The rest can go in later when net-next-2.6
opens up.
^ permalink raw reply
* Re: [1/1] ARC vmac ethernet driver.
From: David Miller @ 2010-03-15 22:35 UTC (permalink / raw)
To: andreas.fenkart; +Cc: netdev
This needs some changes.
First, you'll need to add some proper dependencies to the Kconfig for
this driver before we can apply it.
At a minimum you have to depend upon HAS_DMA otherwise the
dma_*() interface calls won't link on platforms such as s390.
Also:
+static char *mac_addr;
+module_param(mac_addr, charp, 0644);
+MODULE_PARM_DESC(mac_addr, "MAC address as colon separated hexadecimals");
Please remove this, we have interfaces for setting the ethernet
address. If the device address can't be probed, use
a random ethernet address as a default (by using linux/etherdevice.h's
random_ether_addr())
If the user wants to override they can do so with the 'ifconfig'
command.
This is how we consistently handle this situation in every ethernet
driver, so please don't try to make arguments as to why your driver
should handle this differently.
Thanks.
^ permalink raw reply
* Re: [PATCH net-next-2.6 v6 08/12] net-caif: add CAIF socket implementation
From: Marcel Holtmann @ 2010-03-15 21:53 UTC (permalink / raw)
To: sjur.brandeland
Cc: netdev, davem, daniel.martensson, kaber, stefano.babic,
randy.dunlap
In-Reply-To: <1267445559-1911-9-git-send-email-sjur.brandeland@stericsson.com>
Hi Sjur,
> + /*
> + * The sock->type specifies the socket type to use. The CAIF socket is
> + * a packet stream in the sence that it is packet based.
> + * CAIF trusts the reliability of the link, no resending is implemented.
> + */
> + if (sock->type != SOCK_SEQPACKET)
> + return -ESOCKTNOSUPPORT;
we came to an interesting detail here when testing with a STE modem. Why
is this SEQPACKET and not a STREAM. Especially with the AT command
channels it is kinda weird that you have an MTU. The AT specification
doesn't really have any defined behavior when using a sequential packet
transport. It is more a stream based socket.
Regards
Marcel
^ permalink raw reply
* Re: [1/3] gigaset: avoid registering CAPI driver more than once
From: David Miller @ 2010-03-15 21:20 UTC (permalink / raw)
To: isdn; +Cc: tilman, netdev, linux-kernel, stable, isdn4linux, hjlipp,
i4ldeveloper
In-Reply-To: <1268664986.25524@pingi>
Karsten the way you reforward patches does not work.
And I've told you about this last time you submitted ISDN patches.
You don't add an extra "From: " line in the message body, so when the
patch gets applied the author gets set to _you_ instead of the person
who actually wrote the change.
All you're doing is ACK'ing this person's work, so simply reply to the
patch they posted and with your "Acked-by" line. This way patchwork
and friends will figure out the rest when the patch gets integrated
into the net-2.6 tree.
By reposting the patches the way you are we're losing information.
Add to this the fact that you never have the time to properly take
care of ISDN patches, and when you do finally "get to it" you make all
kinds of submission errors.
This is not the first time either, it happens over and over again.
It's incredibly frustrating, especially for me.
Please seriously consider handing ISDN maintainership over to someone
who unlike you 1) has the time and the desire and 2) knows how to
submit patches properly. Probably Tilman is the person who most meets
these criteria based upon what I've seen.
Meanwhile, I'm going to apply the original patches as posted by
Tilman so that the proper authorship gets set.
^ permalink raw reply
* Re: [PATCH 0/4] Some typo fixing
From: Randy Dunlap @ 2010-03-15 21:09 UTC (permalink / raw)
To: Thomas Weber
Cc: Karsten Keil, Lin Ming, Takashi Iwai, Benjamin Herrenschmidt,
Jaroslav Kysela, Pavel Machek, David Brownell,
linux-acpi-u79uwXL29TY76Z2rM5mHXA, KOSAKI Motohiro, Bjorn Helgaas,
Rusty Russell, John W. Linville, Steve Conklin, Ralph Campbell,
Anton Vorontsov, cbe-oss-dev-mnsaURCQ41sdnm+yROfE0A,
Liam Girdwood, Anthony Liguori, Jiri Kosina,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Joe Perches
In-Reply-To: <1268686558-28171-1-git-send-email-swirl-EOsNSARiLbg@public.gmane.org>
On 03/15/10 13:55, Thomas Weber wrote:
> I have fixed some typos.
Acked-by: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
Jiri, can you merge these, please, unless someone objects (?).
> Thomas Weber (4):
> Fix typo: [Ss]ytem => [Ss]ystem
> Fix typo: udpate => update
> Fix typo: paramters => parameters
> Fix typo: orginal => original
>
> Documentation/cgroups/cgroups.txt | 2 +-
> Documentation/kbuild/kconfig.txt | 2 +-
> Documentation/sysfs-rules.txt | 2 +-
> Documentation/trace/events.txt | 8 ++++----
> drivers/acpi/osl.c | 4 ++--
> drivers/ata/ata_piix.c | 2 +-
> drivers/firewire/ohci.c | 2 +-
> drivers/gpu/drm/drm_bufs.c | 2 +-
> drivers/infiniband/hw/ipath/ipath_iba6110.c | 2 +-
> drivers/infiniband/hw/ipath/ipath_iba6120.c | 4 ++--
> drivers/infiniband/hw/ipath/ipath_iba7220.c | 2 +-
> drivers/isdn/hisax/hfc4s8s_l1.c | 2 +-
> drivers/macintosh/windfarm_pm81.c | 2 +-
> drivers/media/dvb/dvb-usb/friio-fe.c | 2 +-
> drivers/net/smsc911x.c | 4 ++--
> drivers/pci/hotplug/cpqphp_core.c | 2 +-
> drivers/pci/pci.c | 2 +-
> drivers/ps3/ps3-sys-manager.c | 2 +-
> drivers/regulator/core.c | 2 +-
> drivers/s390/char/sclp_cpi_sys.c | 2 +-
> drivers/scsi/bfa/include/defs/bfa_defs_cee.h | 2 +-
> drivers/scsi/bfa/include/defs/bfa_defs_status.h | 4 ++--
> drivers/spi/spi_mpc8xxx.c | 2 +-
> drivers/staging/iio/Documentation/overview.txt | 2 +-
> drivers/staging/rt2860/rtmp.h | 2 +-
> drivers/staging/rtl8187se/r8180_core.c | 4 ++--
> drivers/staging/rtl8187se/r8180_dm.c | 2 +-
> drivers/staging/rtl8187se/r8185b_init.c | 2 +-
> drivers/virtio/virtio_pci.c | 2 +-
> fs/jfs/jfs_dmap.c | 2 +-
> kernel/cgroup.c | 2 +-
> mm/page_alloc.c | 2 +-
> net/wimax/op-rfkill.c | 2 +-
> sound/pci/emu10k1/emu10k1_main.c | 2 +-
> 34 files changed, 42 insertions(+), 42 deletions(-)
>
Thanks.
--
~Randy
^ permalink raw reply
* Re: inconsistent lock state
From: David Miller @ 2010-03-15 21:09 UTC (permalink / raw)
To: eric.dumazet
Cc: oleg, mingo, sergey.senozhatsky, romieu, a.p.zijlstra, netdev,
linux-kernel
In-Reply-To: <1268686865.2824.4.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 15 Mar 2010 22:01:05 +0100
> Also, this driver schedules a reset in case a fifo error is reported in
> rtl8169_rx_interrupt()
>
> if (status & RxFOVF) {
> rtl8169_schedule_work(dev, rtl8169_reset_task);
> dev->stats.rx_fifo_errors++;
> }
>
>
> This seems very strange too : In case of a RX spike, we reset card ?
It's possible that this has been found to hang the card.
If so, it should be documented because otherwise yes we
should not be doing this.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox