* Re: [PATCH] bnx2x: Fix check to get RX hash
From: David Miller @ 2010-05-06 7:14 UTC (permalink / raw)
To: therbert; +Cc: netdev
In-Reply-To: <alpine.DEB.1.00.1005052054590.27018@pokey.mtv.corp.google.com>
From: Tom Herbert <therbert@google.com>
Date: Wed, 5 May 2010 20:57:16 -0700 (PDT)
> Flag used in check to get rxhash out of the descriptor is incorrect one.
> Fix to use the proper features flag.
>
> Signed-off-by: Tom Herbert <therbert@google.com>
Applied.
^ permalink raw reply
* Re: [PATCH] forcedeth: Account for consumed budget in napi poll
From: David Miller @ 2010-05-06 7:14 UTC (permalink / raw)
To: therbert; +Cc: netdev
In-Reply-To: <alpine.DEB.1.00.1005052111440.31888@pokey.mtv.corp.google.com>
From: Tom Herbert <therbert@google.com>
Date: Wed, 5 May 2010 21:15:21 -0700 (PDT)
> Repeated calls to nv_rx_process in napi poll routine do not take
> portion of budget that has been consumed in previous calls. Fix by
> subtracting the number of packets processed.
>
> Signed-off-by: Tom Herbert <therbert@google.com>
Applied.
^ permalink raw reply
* Re: [PATCH 1/6] netdev: octeon_mgmt: Use proper MAC addresses.
From: David Miller @ 2010-05-06 7:18 UTC (permalink / raw)
To: ddaney; +Cc: netdev, linux-mips
In-Reply-To: <1273100593-11043-2-git-send-email-ddaney@caviumnetworks.com>
From: David Daney <ddaney@caviumnetworks.com>
Date: Wed, 5 May 2010 16:03:08 -0700
> The original implementation incorrectly uses netdev->dev_addrs.
>
> Use netdev->uc instead. Also use netdev_for_each_uc_addr to iterate
> over the addresses. Fix comment.
>
> Signed-off-by: David Daney <ddaney@caviumnetworks.com>
Applied.
^ permalink raw reply
* Re: [PATCH 2/6] netdev: octeon_mgmt: Fix race condition freeing TX buffers.
From: David Miller @ 2010-05-06 7:18 UTC (permalink / raw)
To: ddaney; +Cc: netdev, linux-mips
In-Reply-To: <1273100593-11043-3-git-send-email-ddaney@caviumnetworks.com>
From: David Daney <ddaney@caviumnetworks.com>
Date: Wed, 5 May 2010 16:03:09 -0700
> Under heavy load the TX cleanup tasklet and xmit threads would race
> and try to free too many buffers.
>
> Signed-off-by: David Daney <ddaney@caviumnetworks.com>
Applied.
^ permalink raw reply
* Re: [PATCH 3/6] netdev: octeon_mgmt: Fix race manipulating irq bits.
From: David Miller @ 2010-05-06 7:18 UTC (permalink / raw)
To: ddaney; +Cc: netdev, linux-mips
In-Reply-To: <1273100593-11043-4-git-send-email-ddaney@caviumnetworks.com>
From: David Daney <ddaney@caviumnetworks.com>
Date: Wed, 5 May 2010 16:03:10 -0700
> Don't re-read the interrupt status register, clear the exact bits we
> will be testing.
>
> Signed-off-by: David Daney <ddaney@caviumnetworks.com>
Applied.
^ permalink raw reply
* Re: [PATCH 4/6] netdev: octeon_mgmt: Free TX skbufs in a timely manner.
From: David Miller @ 2010-05-06 7:19 UTC (permalink / raw)
To: ddaney; +Cc: netdev, linux-mips
In-Reply-To: <1273100593-11043-5-git-send-email-ddaney@caviumnetworks.com>
From: David Daney <ddaney@caviumnetworks.com>
Date: Wed, 5 May 2010 16:03:11 -0700
> We also reduce the high water mark to 1 so skbufs are not stranded for
> long periods of time. Since we are cleaning after each packet, no
> need to do it in the transmit path.
>
> Signed-off-by: David Daney <ddaney@caviumnetworks.com>
Applied.
^ permalink raw reply
* Re: [PATCH 5/6] netdev: octeon_mgmt: Try not to drop TX packets when stopping the queue.
From: David Miller @ 2010-05-06 7:19 UTC (permalink / raw)
To: ddaney; +Cc: netdev, linux-mips
In-Reply-To: <1273100593-11043-6-git-send-email-ddaney@caviumnetworks.com>
From: David Daney <ddaney@caviumnetworks.com>
Date: Wed, 5 May 2010 16:03:12 -0700
> Stop the queue when we add the packet that will fill it instead of dropping the packet
>
> Signed-off-by: David Daney <ddaney@caviumnetworks.com>
Applied.
^ permalink raw reply
* Re: [PATCH 6/6] netdev: octeon_mgmt: Remove some gratuitous blank lines.
From: David Miller @ 2010-05-06 7:19 UTC (permalink / raw)
To: ddaney; +Cc: netdev, linux-mips
In-Reply-To: <1273100593-11043-7-git-send-email-ddaney@caviumnetworks.com>
From: David Daney <ddaney@caviumnetworks.com>
Date: Wed, 5 May 2010 16:03:13 -0700
> Signed-off-by: David Daney <ddaney@caviumnetworks.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 1/4] e1000e: save skb counts in TX to avoid cache misses
From: David Miller @ 2010-05-06 7:19 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, therbert, bruce.w.allan
In-Reply-To: <20100506000221.8042.64794.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 05 May 2010 17:02:27 -0700
> From: Tom Herbert <therbert@google.com>
>
> In e1000_tx_map, precompute number of segements and bytecounts which
> are derived from fields in skb; these are stored in buffer_info. When
> cleaning tx in e1000_clean_tx_irq use the values in the associated
> buffer_info for statistics counting, this eliminates cache misses
> on skb fields.
>
> Signed-off-by: Tom Herbert <therbert@google.com>
> Acked-by: Bruce Allan <bruce.w.allan@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 2/4] e1000e: reduce writes of RX producer ptr
From: David Miller @ 2010-05-06 7:19 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, therbert, bruce.w.allan
In-Reply-To: <20100506000247.8042.97827.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 05 May 2010 17:02:49 -0700
> From: Tom Herbert <therbert@google.com>
>
> Reduce number of writes to RX producer pointer. When alloc'ing RX
> buffers, only write the RX producer pointer once every
> E1000_RX_BUFFER_WRITE (16) buffers created.
>
> Signed-off-by: Tom Herbert <therbert@google.com>
> Acked-by: Bruce Allan <bruce.w.allan@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 3/4] e1000e: Remove unnessary log message
From: David Miller @ 2010-05-06 7:19 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, therbert, bruce.w.allan
In-Reply-To: <20100506000309.8042.9387.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 05 May 2010 17:03:11 -0700
> From: Tom Herbert <therbert@google.com>
>
> Remove e_info message printed whenever TSO is enabled or disabled.
> This is not very useful and just clutters dmesg.
>
> Signed-off-by: Tom Herbert <therbert@google.com>
> Acked-by: Bruce Allan <bruce.w.allan@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 4/4] e1000e: Save irq into netdev structure
From: David Miller @ 2010-05-06 7:19 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, therbert, bruce.w.allan
In-Reply-To: <20100506000330.8042.91540.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 05 May 2010 17:03:32 -0700
> From: Tom Herbert <therbert@google.com>
>
> Set net->devirq to pdev->irq. This should be consistent with other
> drivers.
>
> Signed-off-by: Tom Herbert <therbert@google.com>
> Acked-by: Bruce Allan <bruce.w.allan@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [PATCH 1/4 v2] ks8851: Add caching of CCR register
From: David Miller @ 2010-05-06 7:20 UTC (permalink / raw)
To: s-jan; +Cc: netdev, linux-omap, x0066660, ben-linux, Tristram.Ha
In-Reply-To: <1273085155-1260-2-git-send-email-s-jan@ti.com>
From: Sebastien Jan <s-jan@ti.com>
Date: Wed, 5 May 2010 20:45:52 +0200
> CCR register contains information on companion eeprom availability.
>
> Signed-off-by: Sebastien Jan <s-jan@ti.com>
APplied.
^ permalink raw reply
* Re: [PATCH 2/4 v2] ks8851: Low level functions for read/write to companion eeprom
From: David Miller @ 2010-05-06 7:20 UTC (permalink / raw)
To: s-jan; +Cc: netdev, linux-omap, x0066660, ben-linux, Tristram.Ha
In-Reply-To: <1273085155-1260-3-git-send-email-s-jan@ti.com>
From: Sebastien Jan <s-jan@ti.com>
Date: Wed, 5 May 2010 20:45:53 +0200
> Low-level functions provide 16bits words read and write capability
> to ks8851 companion eeprom.
>
> Signed-off-by: Sebastien Jan <s-jan@ti.com>
Applied.
^ permalink raw reply
* Re: [PATCH 3/4 v2] ks8851: companion eeprom access through ethtool
From: David Miller @ 2010-05-06 7:20 UTC (permalink / raw)
To: s-jan; +Cc: netdev, linux-omap, x0066660, ben-linux, Tristram.Ha
In-Reply-To: <1273085155-1260-4-git-send-email-s-jan@ti.com>
From: Sebastien Jan <s-jan@ti.com>
Date: Wed, 5 May 2010 20:45:54 +0200
> Accessing ks8851 companion eeprom permits modifying the ks8851 stored
> MAC address.
>
> Example how to change the MAC address using ethtool, to set the
> 01:23:45:67:89:AB MAC address:
> $ echo "0:AB8976452301" | xxd -r > mac.bin
> $ sudo ethtool -E eth0 magic 0x8870 offset 2 < mac.bin
>
> Signed-off-by: Sebastien Jan <s-jan@ti.com>
Applied.
^ permalink raw reply
* Re: [PATCH 4/4 v2] ks8851: read/write MAC address on companion eeprom through debugfs
From: David Miller @ 2010-05-06 7:25 UTC (permalink / raw)
To: s-jan; +Cc: netdev, linux-omap, x0066660, ben-linux, Tristram.Ha
In-Reply-To: <1273085155-1260-5-git-send-email-s-jan@ti.com>
From: Sebastien Jan <s-jan@ti.com>
Date: Wed, 5 May 2010 20:45:55 +0200
> A more elegant alternative to ethtool for updating the ks8851
> MAC address stored on its companion eeprom.
> Using this debugfs interface does not require any knowledge on the
> ks8851 companion eeprom organization to update the MAC address.
>
> Example to write 01:23:45:67:89:AB MAC address to the companion
> eeprom (assuming debugfs is mounted in /sys/kernel/debug):
> $ echo "01:23:45:67:89:AB" > /sys/kernel/debug/ks8851/mac_eeprom
>
> Signed-off-by: Sebastien Jan <s-jan@ti.com>
Elegant? This commit message is the biggest lie ever told.
What makes your ethernet driver so god-damn special that it deserves
to have a private, completely unique, and obscure interface for
setting the permanent ethernet address of a network device?
Tell me how damn elegant it is that users have to learn about this
special, unique, and common with no other driver, interface for
performing this task?
Tell me how damn elegant it is when another driver wants to provide
users with a way to do this too, and they (like you) come up with
their own unique and different interface for doing this.
No, this is the most inelegant patch ever conceived because it totally
ignores the way in which we handle issues like this.
There is no way in the world I'm applying this garbage patch, sorry.
We have an ETHTOOL_GPERMADDR, add a new ETHTOOL_SPERMADDR operation
and then any driver (not just your's) can portably provide this
facility and users will have one, and only one, way of performing this
task.
^ permalink raw reply
* RE: [Pv-drivers] RFC: Network Plugin Architecture (NPA) for vmxnet3
From: Shreyas Bhatewara @ 2010-05-06 7:25 UTC (permalink / raw)
To: Scott Feldman, Arnd Bergmann, Dmitry Torokhov
Cc: Christoph Hellwig, pv-drivers@vmware.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, Pankaj Thakkar
In-Reply-To: <C807719A.2E910%scofeldm@cisco.com>
> -----Original Message-----
> From: Scott Feldman [mailto:scofeldm@cisco.com]
> Sent: Wednesday, May 05, 2010 7:04 PM
> To: Shreyas Bhatewara; Arnd Bergmann; Dmitry Torokhov
> Cc: Christoph Hellwig; pv-drivers@vmware.com; netdev@vger.kernel.org;
> linux-kernel@vger.kernel.org; virtualization@lists.linux-
> foundation.org; Pankaj Thakkar
> Subject: Re: [Pv-drivers] RFC: Network Plugin Architecture (NPA) for
> vmxnet3
>
> On 5/5/10 10:29 AM, "Dmitry Torokhov" <dtor@vmware.com> wrote:
>
> > It would not be a binary blob but software properly released under
> GPL.
> > The current plan is for the shell to enforce GPL requirement on the
> > plugin code, similar to what module loaded does for regular kernel
> > modules.
>
> On 5/5/10 3:05 PM, "Shreyas Bhatewara" <sbhatewara@vmware.com> wrote:
>
> > The plugin image is not linked against Linux kernel. It is OS
> agnostic infact
> > (Eg. same plugin works for Linux and Windows VMs)
>
> Are there any issues with injecting the GPL-licensed plug-in into the
> Windows vmxnet3 NDIS driver?
>
> -scott
Scott,
Thanks for pointing out. This issue can be resolved by adding exception to the plugin license which allows it to link to a non-free program .(http://www.gnu.org/licenses/gpl-faq.html#GPLPluginsInNF)
->Shreyas
^ permalink raw reply
* RE: [Pv-drivers] RFC: Network Plugin Architecture (NPA) for vmxnet3
From: Shreyas Bhatewara @ 2010-05-06 7:25 UTC (permalink / raw)
To: Scott Feldman, Arnd Bergmann, Dmitry Torokhov
Cc: Christoph Hellwig, pv-drivers@vmware.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, Pankaj Thakkar
In-Reply-To: <C807719A.2E910%scofeldm@cisco.com>
> -----Original Message-----
> From: Scott Feldman [mailto:scofeldm@cisco.com]
> Sent: Wednesday, May 05, 2010 7:04 PM
> To: Shreyas Bhatewara; Arnd Bergmann; Dmitry Torokhov
> Cc: Christoph Hellwig; pv-drivers@vmware.com; netdev@vger.kernel.org;
> linux-kernel@vger.kernel.org; virtualization@lists.linux-
> foundation.org; Pankaj Thakkar
> Subject: Re: [Pv-drivers] RFC: Network Plugin Architecture (NPA) for
> vmxnet3
>
> On 5/5/10 10:29 AM, "Dmitry Torokhov" <dtor@vmware.com> wrote:
>
> > It would not be a binary blob but software properly released under
> GPL.
> > The current plan is for the shell to enforce GPL requirement on the
> > plugin code, similar to what module loaded does for regular kernel
> > modules.
>
> On 5/5/10 3:05 PM, "Shreyas Bhatewara" <sbhatewara@vmware.com> wrote:
>
> > The plugin image is not linked against Linux kernel. It is OS
> agnostic infact
> > (Eg. same plugin works for Linux and Windows VMs)
>
> Are there any issues with injecting the GPL-licensed plug-in into the
> Windows vmxnet3 NDIS driver?
>
> -scott
^ permalink raw reply
* Re: [net-next-2.6 PATCH 1/2] ixgbe: Add boolean parameter to ixgbe_set_vmolr
From: David Miller @ 2010-05-06 7:25 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, gregory.v.rose
In-Reply-To: <20100505081129.5709.39430.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 05 May 2010 01:11:46 -0700
> From: Greg Rose <gregory.v.rose@intel.com>
>
> Add a boolean parameter to ixgbe-set_vmolr so that the caller can
> specify whether the pool should accept untagged packets. Required
> for a follow on patch to enable administrative configuration of port
> VLAN for virtual functions.
>
> Signed-off-by: Greg Rose <gregory.v.rose@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 2/2] ixgbe: Add support for VF MAC and VLAN configuration
From: David Miller @ 2010-05-06 7:25 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, gregory.v.rose
In-Reply-To: <20100505081204.5709.63340.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 05 May 2010 01:12:06 -0700
> From: Greg Rose <gregory.v.rose@intel.com>
>
> Add support for the "ip link set" and "ip link show" commands that allow
> configuration of the virtual functions' MAC and port VLAN via user space
> command line.
>
> Signed-off-by: Greg Rose <gregory.v.rose@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 1/2] e1000e: increase rx fifo size to 36K on 82574 and 82583
From: David Miller @ 2010-05-06 7:25 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, alexander.h.duyck
In-Reply-To: <20100505082537.5956.86868.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 05 May 2010 01:25:42 -0700
> From: Alexander Duyck <alexander.h.duyck@intel.com>
>
> This change increases the RX fifo size to 36K for standard frames and
> decreases the TX fifo size to 4K. The reason for this change is that on
> slower systems the RX is much more likely to backfill and need space than
> the TX is. As long as the TX fifo is twice the size of the MTU we should
> have more than enough TX fifo.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 2/2] e1000/e1000e: implement a simple interrupt moderation
From: David Miller @ 2010-05-06 7:25 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, jesse.brandeburg
In-Reply-To: <20100505082601.5956.29024.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 05 May 2010 01:26:03 -0700
> From: Jesse Brandeburg <jesse.brandeburg@intel.com>
>
> Back before e1000-7.3.20, the e1000 driver had a simple algorithm that
> managed interrupt moderation. The driver was updated in 7.3.20 to
> have the new "adaptive" interrupt moderation but we have customer
> requests to redeploy the old way as an option. This patch adds the
> old functionality back. The new functionality can be enabled via
> module parameter or at runtime via ethtool.
> Module parameter: (InterruptThrottleRate=4) to use this new
> moderation method.
> Ethtool method: ethtool -C ethX rx-usecs 4
>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [PATCH v2] net/gianfar: drop recycled skbs on MTU change
From: David Miller @ 2010-05-06 7:26 UTC (permalink / raw)
To: afleming; +Cc: sebastian, afleming, netdev
In-Reply-To: <C4C9C232-1DA6-43BE-A9FF-4A591E3FF672@freescale.com>
From: Andy Fleming <afleming@freescale.com>
Date: Wed, 5 May 2010 10:18:40 -0500
>
> On May 5, 2010, at 3:30 AM, Sebastian Andrzej Siewior wrote:
>
>> From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>>
>> The size for skbs which is added to the recycled list is using the
>> current descriptor size which is current MTU. gfar_new_skb() is also
>> using this size. So after changing or alteast increasing the MTU all
>> recycled skbs should be dropped.
>>
>> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
...
> Acked-by: Andy Fleming <afleming@freescale.com>
Applied, thanks everyone.
^ permalink raw reply
* Re: [GIT PULL] amended: first round of vhost-net enhancements for net-next
From: David Miller @ 2010-05-06 7:29 UTC (permalink / raw)
To: mst; +Cc: kvm, virtualization, netdev, linux-kernel
In-Reply-To: <20100504112100.GA22172@redhat.com>
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Tue, 4 May 2010 14:21:01 +0300
> This is an amended pull request: I have rebased the tree to the
> correct patches. This has been through basic tests and seems
> to work fine here.
>
> The following tree includes a couple of enhancements that help vhost-net.
> Please pull them for net-next. Another set of patches is under
> debugging/testing and I hope to get them ready in time for 2.6.35,
> so there may be another pull request later.
Pulled, thanks Michael.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 1/3] ixgbe: Remove unneeded register writes in VF VLAN setup
From: David Miller @ 2010-05-06 7:32 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, gregory.v.rose
In-Reply-To: <20100506055703.8482.16515.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 05 May 2010 22:57:10 -0700
> From: Greg Rose <gregory.v.rose@intel.com>
>
> The driver is unnecessarily writing values to VLAN control registers.
> These writes already done elsewhere and are superfluous here.
>
> Signed-off-by: Greg Rose <gregory.v.rose@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox