* Re: [PATCH 1/2] ipv6: Store ndisc_nodeid in IP6CB().
From: David Miller @ 2010-05-24 6:58 UTC (permalink / raw)
To: bmb; +Cc: tgraf, nhorman, nhorman, eric.dumazet, herbert, netdev
In-Reply-To: <20100519.195536.32704411.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Wed, 19 May 2010 19:55:36 -0700 (PDT)
>
> There is no reason we need to use up space in the generic
> SKB area for this. All packet input paths in ipv6 explicitly
> clear out the IP6CB() area and therefore the default value
> for ndisc_nodeid will be correct.
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
Turns out the patch doesn't build, because it throws the
DCCP control block beyond the skb->cb[] size of 48 bytes
with ipv6 enabled on 64-bit.
Ho hum...
^ permalink raw reply
* Re: cls_cgroup: Store classid in struct sock
From: David Miller @ 2010-05-24 6:55 UTC (permalink / raw)
To: herbert; +Cc: nhorman, eric.dumazet, bmb, tgraf, nhorman, netdev
In-Reply-To: <20100523.234441.66200781.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Sun, 23 May 2010 23:44:41 -0700 (PDT)
> From: Herbert Xu <herbert@gondor.apana.org.au>
> Date: Sat, 22 May 2010 11:49:57 +1000
>
>> On Fri, May 21, 2010 at 12:40:54PM -0400, Neil Horman wrote:
>>>
>>> There may also be an issue with the setting of the classid (possible use of the
>>> wrong subsys id value when grabbing our cgroup_subsys_state), but I'm checking
>>> on that now.
>>
>> Actually, I think it's because my patch mistook CONFIG_CGROUP
>> for CONFIG_CGROUPS.
>>
>> Here is a fixed version (also includes a build fix on sk->classid).
>>
>> cls_cgroup: Store classid in struct sock
>
> BTW I made sure to apply this version.
Actually I had to revert, doesn't build:
CC [M] drivers/net/pppoe.o
In file included from net/socket.c:97:
include/net/cls_cgroup.h:22: error: field ‘css’ has incomplete type
make[1]: *** [net/socket.o] Error 1
make: *** [net] Error 2
make: *** Waiting for unfinished jobs....
Probably you only tested the build with cgroups enabled?
^ permalink raw reply
* Re: [PATCH] net/irda: bfin_sir: IRDA is not affected by anomaly 05000230
From: David Miller @ 2010-05-24 6:54 UTC (permalink / raw)
To: vapier; +Cc: netdev, uclinux-dist-devel, graf.yang
In-Reply-To: <1274601610-882-1-git-send-email-vapier@gentoo.org>
From: Mike Frysinger <vapier@gentoo.org>
Date: Sun, 23 May 2010 04:00:10 -0400
> From: Graf Yang <graf.yang@analog.com>
>
> Anomaly 05000230 (over sampling of the UART STOP bit) applies only when
> the peripheral is operating in UART mode. So drop the anomaly handling
> in the IRDA code.
>
> Signed-off-by: Graf Yang <graf.yang@analog.com>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH 0/2] ISDN fixes for 2.6.35
From: David Miller @ 2010-05-24 6:52 UTC (permalink / raw)
To: isdn; +Cc: tilman, hjlipp, i4ldeveloper, netdev, linux-kernel, keil
In-Reply-To: <201005231301.50967.isdn@linux-pingi.de>
From: Karsten Keil <isdn@linux-pingi.de>
Date: Sun, 23 May 2010 13:01:50 +0200
> On Sonntag, 23. Mai 2010 03:14:43 Tilman Schmidt wrote:
>> Karsten, David,
>>
>> following are two patches to the CAPI subsystem and the Gigaset
>> driver I'd like to see included in kernel release 2.6.35.
>> Together they fix a reported hang of the userspace command
>> "capiinit stop".
>
> Acked-by: Karsten Keil <isdn@linux-pingi.de>
All applied, thanks everyone.
^ permalink raw reply
* Re: [patch] pppoe: uninitialized variable in pppoe_flush_dev()
From: David Miller @ 2010-05-24 6:50 UTC (permalink / raw)
To: error27; +Cc: mostrows, eric.dumazet, jpirko, denys, netdev, kernel-janitors
In-Reply-To: <20100522202534.GO22515@bicker>
From: Dan Carpenter <error27@gmail.com>
Date: Sat, 22 May 2010 22:27:48 +0200
> This assignment got deleted along with the checks by mistake. This
> comes from: 8753d29fd "pppoe: remove unnecessary checks in
> pppoe_flush_dev"
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Applied, thanks Dan.
^ permalink raw reply
* Re: cls_cgroup: Store classid in struct sock
From: David Miller @ 2010-05-24 6:44 UTC (permalink / raw)
To: herbert; +Cc: nhorman, eric.dumazet, bmb, tgraf, nhorman, netdev
In-Reply-To: <20100522014957.GA8779@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sat, 22 May 2010 11:49:57 +1000
> On Fri, May 21, 2010 at 12:40:54PM -0400, Neil Horman wrote:
>>
>> There may also be an issue with the setting of the classid (possible use of the
>> wrong subsys id value when grabbing our cgroup_subsys_state), but I'm checking
>> on that now.
>
> Actually, I think it's because my patch mistook CONFIG_CGROUP
> for CONFIG_CGROUPS.
>
> Here is a fixed version (also includes a build fix on sk->classid).
>
> cls_cgroup: Store classid in struct sock
BTW I made sure to apply this version.
^ permalink raw reply
* Re: tun: Use netif_receive_skb instead of netif_rx
From: David Miller @ 2010-05-24 6:44 UTC (permalink / raw)
To: herbert; +Cc: nhorman, eric.dumazet, bmb, tgraf, nhorman, netdev
In-Reply-To: <20100521011632.GA23849@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Fri, 21 May 2010 11:16:32 +1000
> tun: Update classid on packet injection
>
> This patch makes tun update its socket classid every time we
> inject a packet into the network stack. This is so that any
> updates made by the admin to the process writing packets to
> tun is effected.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied.
^ permalink raw reply
* Re: tun: Use netif_receive_skb instead of netif_rx
From: David Miller @ 2010-05-24 6:44 UTC (permalink / raw)
To: herbert; +Cc: eric.dumazet, bmb, tgraf, nhorman, nhorman, netdev
In-Reply-To: <20100520065242.GA8719@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Thu, 20 May 2010 16:52:42 +1000
> cls_cgroup: Store classid in struct sock
...
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied.
^ permalink raw reply
* Re: [PATCH net-2.6 6/6] caif: Bugfix - use MSG_TRUNC in receive
From: David Miller @ 2010-05-24 6:40 UTC (permalink / raw)
To: sjur.brandeland; +Cc: netdev, sjurbr, linus.walleij, marcel
In-Reply-To: <1274444172-31969-6-git-send-email-sjur.brandeland@stericsson.com>
From: sjur.brandeland@stericsson.com
Date: Fri, 21 May 2010 14:16:12 +0200
> From: Sjur Braendeland <sjur.brandeland@stericsson.com>
>
> Fixed handling when skb don't fit in user buffer,
> instead of returning -EMSGSIZE, the buffer is truncated (just
> as unix seqpakcet does).
>
> Signed-off-by: Sjur Braendeland <sjur.brandeland@stericsson.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-2.6 5/6] caif: Bugfix - missing spin_unlock
From: David Miller @ 2010-05-24 6:40 UTC (permalink / raw)
To: sjur.brandeland; +Cc: netdev, sjurbr, linus.walleij, marcel
In-Reply-To: <1274444172-31969-5-git-send-email-sjur.brandeland@stericsson.com>
From: sjur.brandeland@stericsson.com
Date: Fri, 21 May 2010 14:16:11 +0200
> From: Sjur Braendeland <sjur.brandeland@stericsson.com>
>
> Splint found missing spin_unlock.
> Corrected this an some other trivial split warnings.
>
> Signed-off-by: Sjur Braendeland <sjur.brandeland@stericsson.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-2.6 4/6] caif: Bugfix - Poll can't return POLLHUP while connecting.
From: David Miller @ 2010-05-24 6:40 UTC (permalink / raw)
To: sjur.brandeland; +Cc: netdev, sjurbr, linus.walleij, marcel
In-Reply-To: <1274444172-31969-4-git-send-email-sjur.brandeland@stericsson.com>
From: sjur.brandeland@stericsson.com
Date: Fri, 21 May 2010 14:16:10 +0200
> From: Sjur Braendeland <sjur.brandeland@stericsson.com>
>
> Discovered bug when testing async connect.
> While connecting poll should not return POLLHUP,
> but POLLOUT when connected.
> Also fixed the sysfs flow-control-counters.
>
> Signed-off-by: Sjur Braendeland <sjur.brandeland@stericsson.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-2.6 3/6] caif: Bugfix - handle mem-allocation failures
From: David Miller @ 2010-05-24 6:40 UTC (permalink / raw)
To: sjur.brandeland; +Cc: netdev, sjurbr, linus.walleij, marcel
In-Reply-To: <1274444172-31969-3-git-send-email-sjur.brandeland@stericsson.com>
From: sjur.brandeland@stericsson.com
Date: Fri, 21 May 2010 14:16:09 +0200
> From: Sjur Braendeland <sjur.brandeland@stericsson.com>
>
> Discovered bugs when injecting slab allocation failures.
> Add checks on all memory allocation.
>
> Signed-off-by: Sjur Braendeland <sjur.brandeland@stericsson.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-2.6 2/6] caif: Bugfix - use standard Linux lists
From: David Miller @ 2010-05-24 6:40 UTC (permalink / raw)
To: sjur.brandeland; +Cc: netdev, sjurbr, linus.walleij, marcel
In-Reply-To: <1274444172-31969-2-git-send-email-sjur.brandeland@stericsson.com>
From: sjur.brandeland@stericsson.com
Date: Fri, 21 May 2010 14:16:08 +0200
> From: Sjur Braendeland <sjur.brandeland@stericsson.com>
>
> Discovered bug when running high number of parallel connect requests.
> Replace buggy home brewed list with linux/list.h.
>
> Signed-off-by: Sjur Braendeland <sjur.brandeland@stericsson.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-2.6 1/6] caif: Bugfix - wait_ev*_timeout returns long.
From: David Miller @ 2010-05-24 6:40 UTC (permalink / raw)
To: sjur.brandeland; +Cc: netdev, sjurbr, linus.walleij, marcel
In-Reply-To: <1274444172-31969-1-git-send-email-sjur.brandeland@stericsson.com>
From: sjur.brandeland@stericsson.com
Date: Fri, 21 May 2010 14:16:07 +0200
> From: Sjur Braendeland <sjur.brandeland@stericsson.com>
>
> Discovered bug when testing on 64bit architecture.
> Fixed by using long to store result from wait_event_interruptible_timeout.
>
> Signed-off-by: Sjur Braendeland <sjur.brandeland@stericsson.com>
Applied.
^ permalink raw reply
* Re: [PATCH 0/2] fixes to arp_notify for virtual machine migration use case
From: David Miller @ 2010-05-24 6:37 UTC (permalink / raw)
To: Ian.Campbell; +Cc: netdev, shemminger, jeremy.fitzhardinge, stable
In-Reply-To: <1273671554.7572.11190.camel@zakaz.uk.xensource.com>
From: Ian Campbell <Ian.Campbell@citrix.com>
Date: Wed, 12 May 2010 14:39:14 +0100
> Ian Campbell (2):
> arp_notify: generate broadcast ARP reply not request.
> arp_notify: generate arp_notify event on NETDEV_CHANGE too
I don't agree with these changes.
For the first one, I think the documentation is just wrong and the
code is what expresses the intent. The idea is not to spam the
world with a broadcast, only interested parties.
Patch #2 I have major issues with, carriers flapping occaisionally is
very common. I have several interfaces which do this even on lightly
loaded networks. Iff we decide to do something like this (big "if")
it would need to be rate limited so that it doesn't trigger due to
normal flapping.
If you want your VM networking devices to trigger this event maybe
the best thing to do is to create a special notification which
allows us to prevent from doing this ARP notify for spurious physical
network device carrier flaps.
^ permalink raw reply
* Re: fec: add support for PHY interface platform data
From: David Miller @ 2010-05-24 6:32 UTC (permalink / raw)
To: baruch; +Cc: netdev
This patch not longer applied cleanly at all.
Pretty much in every portion of the FEC driver your patch touches, the
code looks totally different in the current tree.
You'll need to respin this against Linus's current tree if you still
want me to apply it.
Thanks.
^ permalink raw reply
* Re: [PATCH] net-2.6 : V2 - fix dev_get_valid_name
From: David Miller @ 2010-05-24 6:25 UTC (permalink / raw)
To: opurdila; +Cc: daniel.lezcano, netdev
In-Reply-To: <201005211625.06234.opurdila@ixiacom.com>
From: Octavian Purdila <opurdila@ixiacom.com>
Date: Fri, 21 May 2010 16:25:06 +0300
> On Friday 21 May 2010 16:10:13 you wrote:
>> On 05/19/2010 10:12 PM, Daniel Lezcano wrote:
>> > Signed-off-by: Daniel Lezcano<daniel.lezcano@free.fr>
...
> Reviewed-by: Octavian Purdila <opurdila@ixiacom.com>
Applied, thanks everyone.
^ permalink raw reply
* Re: [PATCH] net: Fix definition of netif_vdbg() when VERBOSE_DEBUG is not defined
From: David Miller @ 2010-05-24 6:21 UTC (permalink / raw)
To: bhutchings; +Cc: netdev, linux-net-drivers, joe
In-Reply-To: <1274201792.2113.3.camel@achroite.uk.solarflarecom.com>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Tue, 18 May 2010 17:56:32 +0100
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Applied, thanks Ben.
^ permalink raw reply
* Re: [PATCH 1/3] ethoc: Write bus addresses to registers
From: David Miller @ 2010-05-24 6:17 UTC (permalink / raw)
To: jonas; +Cc: netdev
In-Reply-To: <1274161166-18521-2-git-send-email-jonas@southpole.se>
From: Jonas Bonn <jonas@southpole.se>
Date: Tue, 18 May 2010 07:39:24 +0200
> The ethoc driver should be writing bus addresses to the ethoc registers, not
> virtual addresses.
>
> Also, use bus_to_virt instead of phys_to_virt to make this explicit.
Portable drivers must not use bus_to_virt().
You should keep track of the virtual addresses of the mapped RX
packets in your RX ring datastructure.
^ permalink raw reply
* Re: [PATCH] net-caif: drop redundant Kconfig entries
From: David Miller @ 2010-05-24 6:12 UTC (permalink / raw)
To: vapier; +Cc: netdev, sjur.brandeland
In-Reply-To: <1274474720-9865-1-git-send-email-vapier@gentoo.org>
From: Mike Frysinger <vapier@gentoo.org>
Date: Fri, 21 May 2010 16:45:20 -0400
> There is already a submenu entry that is always displayed, so there is
> no need to also show a dedicated CAIF comment.
>
> Drop dead commented code while we're here, and change the submenu text
> to better match the style everyone else is using.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Applied.
^ permalink raw reply
* Re: [PATCH] rtnetlink: Fix error handling in do_setlink()
From: David Miller @ 2010-05-24 6:12 UTC (permalink / raw)
To: chrisw; +Cc: dhowells, netdev
In-Reply-To: <20100522065212.GW8301@sequoia.sous-sol.org>
From: Chris Wright <chrisw@sous-sol.org>
Date: Fri, 21 May 2010 23:52:12 -0700
> * David Howells (dhowells@redhat.com) wrote:
>> Commit c02db8c6290bb992442fec1407643c94cc414375:
>>
>> Author: Chris Wright <chrisw@sous-sol.org>
>> Date: Sun May 16 01:05:45 2010 -0700
>> Subject: rtnetlink: make SR-IOV VF interface symmetric
>>
>> adds broken error handling to do_setlink() in net/core/rtnetlink.c. The
>> problem is the following chunk of code:
>>
>> if (tb[IFLA_VFINFO_LIST]) {
>> struct nlattr *attr;
>> int rem;
>> nla_for_each_nested(attr, tb[IFLA_VFINFO_LIST], rem) {
>> if (nla_type(attr) != IFLA_VF_INFO)
>> ----> goto errout;
>> err = do_setvfinfo(dev, attr);
>> if (err < 0)
>> goto errout;
>> modified = 1;
>> }
>> }
>>
>> which can get to errout without setting err, resulting in the following error:
>>
>> net/core/rtnetlink.c: In function 'do_setlink':
>> net/core/rtnetlink.c:904: warning: 'err' may be used uninitialized in this function
>>
>> Change the code to return -EINVAL in this case. Note that this might not be
>> the appropriate error though.
>>
>> Signed-off-by: David Howells <dhowells@redhat.com>
>
> Acked-by: Chris Wright <chrisw@sous-sol.org>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH] ieee802154: Fix possible NULL pointer dereference in wpan_phy_alloc
From: David Miller @ 2010-05-24 6:12 UTC (permalink / raw)
To: dkirjanov; +Cc: dbaryshkov, netdev
In-Reply-To: <20100523154545.GA22578@hera.kernel.org>
From: Denis Kirjanov <dkirjanov@hera.kernel.org>
Date: Sun, 23 May 2010 15:45:45 +0000
> Check for NULL pointer after kzalloc
>
> Signed-off-by: Denis Kirjanov <dkirjanov@kernel.org>
Applied.
^ permalink raw reply
* Re: [PATCH] net_sched: Fix qdisc_notify()
From: David Miller @ 2010-05-24 6:11 UTC (permalink / raw)
To: eric.dumazet; +Cc: hadi, kaber, blp, netdev
In-Reply-To: <1274596664.5020.40.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sun, 23 May 2010 08:37:44 +0200
> [PATCH] net_sched: Fix qdisc_notify()
>
> Ben Pfaff reported a kernel oops and provided a test program to
> reproduce it.
>
> https://kerneltrap.org/mailarchive/linux-netdev/2010/5/21/6277805
>
> tc_fill_qdisc() should not be called for builtin qdisc, or it
> dereference a NULL pointer to get device ifindex.
>
> Fix is to always use tc_qdisc_dump_ignore() before calling
> tc_fill_qdisc().
>
> Reported-by: Ben Pfaff <blp@nicira.com>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied and queued up for -stable.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 2/2] enic: Use random mac addr when associating port-profile
From: David Miller @ 2010-05-24 6:11 UTC (permalink / raw)
To: scofeldm; +Cc: netdev, chrisw
In-Reply-To: <20100523032957.20200.59700.stgit@savbu-pc100.cisco.com>
From: Scott Feldman <scofeldm@cisco.com>
Date: Sat, 22 May 2010 20:29:58 -0700
> From: Scott Feldman <scofeldm@cisco.com>
>
> Use random mac addr for interface when associating port-profile to
> dynamic enic device, in the case no mac addr was previous assigned.
>
> Signed-off-by: Scott Feldman <scofeldm@cisco.com>
Applied.
^ permalink raw reply
* Re: [PATCH] ethoc: fix null dereference in ethoc_probe
From: David Miller @ 2010-05-24 6:11 UTC (permalink / raw)
To: thomas; +Cc: netdev, linux-kernel, thierry.reding, nios2-dev, error27
In-Reply-To: <1274669042-1901-1-git-send-email-thomas@wytron.com.tw>
From: Thomas Chou <thomas@wytron.com.tw>
Date: Mon, 24 May 2010 10:44:02 +0800
> Dan reported the patch 0baa080c75c: "ethoc: use system memory
> as buffer" introduced a potential null dereference.
>
> 1060 free:
> 1061 if (priv->dma_alloc)
> ^^^^^^^^^^^^^^^
> priv can be null here.
>
> He also suggested that the error handling is not complete.
>
> This patch fixes the null priv issue and improves resources
> releasing in ethoc_probe() and ethoc_remove().
>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
Applied.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox