Netdev List
 help / color / mirror / Atom feed
* Re: [PATCH 2/3] cgroups: Add an API to attach a task to current task's cgroup
From: Tejun Heo @ 2010-05-31  7:00 UTC (permalink / raw)
  To: Li Zefan
  Cc: Michael S. Tsirkin, Oleg Nesterov, Sridhar Samudrala, netdev,
	lkml, kvm@vger.kernel.org, Andrew Morton, Dmitri Vorobiev,
	Jiri Kosina, Thomas Gleixner, Ingo Molnar, Andi Kleen
In-Reply-To: <4C030BC1.6000607@cn.fujitsu.com>

On 05/31/2010 03:07 AM, Li Zefan wrote:
> 04:24, Tejun Heo wrote:
>> From: Sridhar Samudrala <samudrala.sridhar@gmail.com>
>>
>> Add a new kernel API to attach a task to current task's cgroup
>> in all the active hierarchies.
>>
>> Signed-off-by: Sridhar Samudrala <sri@us.ibm.com>
> 
> Acked-by: Li Zefan <lizf@cn.fujitsu.com>
> 
> btw: you lost the reviewed-by tag given by Paul Menage.

I only got bounced the original posting.  Michael, can you please add
it if/when you commit these?

Thank you.

-- 
tejun

^ permalink raw reply

* Re: [PATCH] mac8390: change an error return code and some cleanup, take 4
From: David Miller @ 2010-05-31  7:19 UTC (permalink / raw)
  To: fthain; +Cc: joe, p_gortmaker, netdev, linux-kernel, linux-m68k
In-Reply-To: <alpine.OSX.2.00.1005290255580.691@localhost>

From: Finn Thain <fthain@telegraphics.com.au>
Date: Sat, 29 May 2010 03:29:01 +1000 (EST)

> @@ -662,7 +665,7 @@ static void mac8390_no_reset(struct net_
>  {
>  	ei_status.txing = 0;
>  	if (ei_debug > 1)
> -		pr_info("reset not supported\n");
> +		printk(KERN_DEBUG pr_fmt("reset not supported\n"));
>  	return;

Use pr_debug() or pr_devel().   Anything which explicitly codes
out a "printk(KERN_*" is suspect, we have interfaces for this. The
whole point of defining pr_fmt at the top of the driver is so
that in the driver, we use pr_foo() which includes the pr_fmt
string at the beginning.  If you bypass it you avoid the intended
effect of that pr_fmt define.

This is getting tiring Finn.

So we're already past 4 iterations of this silly simple patch, and I
want to remind you yet again what an incredibly hard time you gave Joe
Perches for his changes to this file which in the end were entirely
correct and well formed, and he got it right on his first attempt.

I advise you to think twice before snapping at another developer's
work in the future.

^ permalink raw reply

* Re: [PATCH] drivers/net/arcnet/capmode.c: clean up code
From: David Miller @ 2010-05-31  7:24 UTC (permalink / raw)
  To: daniel; +Cc: linux-kernel, tj, jkosina, cl, joe, netdev
In-Reply-To: <1274284857-21932-1-git-send-email-daniel@caiaq.de>

From: Daniel Mack <daniel@caiaq.de>
Date: Wed, 19 May 2010 18:00:57 +0200

>  - shuffle around functions to get rid of forward declarations
>  - fix some CodingStyle and indentation issues
>  - last but not least, get rid of the following CONFIG_MODULE=n warning:
> 
> 	drivers/net/arcnet/capmode.c:52: warning: ‘capmode_proto’ defined but not used
> 
> Signed-off-by: Daniel Mack <daniel@caiaq.de>

This does not apply cleanly to the current tree.   Please respin
this.

^ permalink raw reply

* Re: [PATCH 1/2] qlcnic: NIC Partitioning
From: David Miller @ 2010-05-31  7:25 UTC (permalink / raw)
  To: anirban.chakraborty; +Cc: netdev, amit.salecha, ameen.rahman
In-Reply-To: <alpine.OSX.2.00.1005241617080.27371@macintosh-2.qlogic.org>


These two patches do not even come close to applying to the
current tree, please respin.

^ permalink raw reply

* Re: [PATCH net-next-2.6] [PPP] cleanup: remove MIN_FRAG_SIZE definition.
From: David Miller @ 2010-05-31  7:29 UTC (permalink / raw)
  To: ramirose; +Cc: netdev
In-Reply-To: <AANLkTilPBlMQJsKaY8Ksa2GzQ1by9H8HMyXZCDoHcNPE@mail.gmail.com>

From: Rami Rosen <ramirose@gmail.com>
Date: Tue, 25 May 2010 23:00:46 +0300

>  - This patch removes MIN_FRAG_SIZE definition in
> drivers/net/ppp_generic.c as it is unneeded.
>
> Signed-off-by: Rami Rosen <ramirose@gmail.com>

Applied.

^ permalink raw reply

* Re: [PATCH] net: Use __this_cpu_inc() in fast path
From: David Miller @ 2010-05-31  7:30 UTC (permalink / raw)
  To: eric.dumazet; +Cc: netdev
In-Reply-To: <1274342843.4046.16.camel@edumazet-laptop>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 20 May 2010 10:07:23 +0200

> This patch saves 224 bytes of text on my machine.
> 
> __this_cpu_inc() generates a single instruction, using no scratch
> registers :
> 
>   65 ff 04 25 a8 30 01 00      incl   %gs:0x130a8
> 
> instead of :
> 
>   48 c7 c2 80 30 01 00         mov    $0x13080,%rdx
>   65 48 8b 04 25 88 ea 00 00   mov    %gs:0xea88,%rax
>   83 44 10 28 01               addl   $0x1,0x28(%rax,%rdx,1)
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>

Applied.

^ permalink raw reply

* Re: [PATCH] net: remove zap_completion_queue
From: David Miller @ 2010-05-31  7:30 UTC (permalink / raw)
  To: eric.dumazet; +Cc: netdev
In-Reply-To: <1274346963.4046.25.camel@edumazet-laptop>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 20 May 2010 11:16:03 +0200

> netpoll does an interesting work in zap_completion_queue(), but this was
> before we did skb orphaning before delivering packets to device.
> 
> It now makes sense to add a test in dev_kfree_skb_irq() to not queue a
> skb if already orphaned, and to remove netpoll zap_completion_queue() as
> a bonus.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>

Applied.

^ permalink raw reply

* Re: [PATCH] tcp: tcp_md5_hash_skb_data() frag_list handling
From: David Miller @ 2010-05-31  7:30 UTC (permalink / raw)
  To: eric.dumazet; +Cc: netdev
In-Reply-To: <1274164851.2567.39.camel@edumazet-laptop>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 18 May 2010 08:40:51 +0200

> Le lundi 17 mai 2010 à 23:14 -0700, David Miller a écrit :
>> Eric, would you please formally submit that tcp md5 fraglist
>> fix to net/ipv4/tcp.c with proper signoffs?
> 
> Here it is, thanks !
> 
> 
> [PATCH] tcp: tcp_md5_hash_skb_data() frag_list handling
> 
> tcp_md5_hash_skb_data() should handle skb->frag_list, and eventually
> recurse.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>

Applied.

^ permalink raw reply

* Re: [PATCH 2/27] drivers/net: Use memdup_user
From: David Miller @ 2010-05-31  7:30 UTC (permalink / raw)
  To: julia; +Cc: paulus, linux-ppp, netdev, linux-kernel, kernel-janitors
In-Reply-To: <Pine.LNX.4.64.1005221018350.13021@ask.diku.dk>

From: Julia Lawall <julia@diku.dk>
Date: Sat, 22 May 2010 10:18:59 +0200 (CEST)

> From: Julia Lawall <julia@diku.dk>
> 
> Use memdup_user when user data is immediately copied into the
> allocated region.
> 
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
 ..
> Signed-off-by: Julia Lawall <julia@diku.dk>

Applied.

^ permalink raw reply

* Re: [PATCH 6/27] drivers/net/cxgb3: Use memdup_user
From: David Miller @ 2010-05-31  7:30 UTC (permalink / raw)
  To: julia; +Cc: divy, netdev, linux-kernel, kernel-janitors
In-Reply-To: <Pine.LNX.4.64.1005221019530.13021@ask.diku.dk>

From: Julia Lawall <julia@diku.dk>
Date: Sat, 22 May 2010 10:20:10 +0200 (CEST)

> From: Julia Lawall <julia@diku.dk>
> 
> Use memdup_user when user data is immediately copied into the
> allocated region.
> 
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
 ...
> Signed-off-by: Julia Lawall <julia@diku.dk>

Applied.

^ permalink raw reply

* Re: [PATCH 7/27] drivers/net/wan: Use memdup_user
From: David Miller @ 2010-05-31  7:30 UTC (permalink / raw)
  To: julia; +Cc: mike.mclagan, netdev, linux-kernel, kernel-janitors
In-Reply-To: <Pine.LNX.4.64.1005221020110.13021@ask.diku.dk>

From: Julia Lawall <julia@diku.dk>
Date: Sat, 22 May 2010 10:20:26 +0200 (CEST)

> From: Julia Lawall <julia@diku.dk>
> 
> Use memdup_user when user data is immediately copied into the
> allocated region.
> 
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
 ...
> Signed-off-by: Julia Lawall <julia@diku.dk>

Applied.

^ permalink raw reply

* Re: [PATCH 22/27] net/dccp: Use memdup_user
From: David Miller @ 2010-05-31  7:31 UTC (permalink / raw)
  To: julia; +Cc: acme, dccp, netdev, linux-kernel, kernel-janitors
In-Reply-To: <Pine.LNX.4.64.1005221025040.13021@ask.diku.dk>

From: Julia Lawall <julia@diku.dk>
Date: Sat, 22 May 2010 10:25:19 +0200 (CEST)

> From: Julia Lawall <julia@diku.dk>
> 
> Use memdup_user when user data is immediately copied into the
> allocated region.
> 
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
 ...
> Signed-off-by: Julia Lawall <julia@diku.dk>

Applied.

^ permalink raw reply

* [PATCH] drivers/net/arcnet/capmode.c: clean up code
From: Daniel Mack @ 2010-05-31  7:31 UTC (permalink / raw)
  To: linux-kernel
  Cc: davem, Daniel Mack, Tejun Heo, Jiri Kosina, Christoph Lameter,
	Joe Perches, netdev
In-Reply-To: <20100531.002429.71095599.davem@davemloft.net>

 - shuffle around functions to get rid of forward declarations
 - fix some CodingStyle and indentation issues
 - last but not least, get rid of the following CONFIG_MODULE=n warning:

	drivers/net/arcnet/capmode.c:52: warning: ‘capmode_proto’ defined but not used

Signed-off-by: Daniel Mack <daniel@caiaq.de>
Cc: Tejun Heo <tj@kernel.org>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: Christoph Lameter <cl@linux-foundation.org>
Cc: Joe Perches <joe@perches.com>
Cc: netdev@vger.kernel.org
---
 drivers/net/arcnet/capmode.c |  178 +++++++++++++++++++-----------------------
 1 files changed, 79 insertions(+), 99 deletions(-)

diff --git a/drivers/net/arcnet/capmode.c b/drivers/net/arcnet/capmode.c
index 355797f..e1810a3 100644
--- a/drivers/net/arcnet/capmode.c
+++ b/drivers/net/arcnet/capmode.c
@@ -37,69 +37,6 @@
 
 #define VERSION "arcnet: cap mode (`c') encapsulation support loaded.\n"
 
-
-static void rx(struct net_device *dev, int bufnum,
-	       struct archdr *pkthdr, int length);
-static int build_header(struct sk_buff *skb,
-			struct net_device *dev,
-			unsigned short type,
-			uint8_t daddr);
-static int prepare_tx(struct net_device *dev, struct archdr *pkt, int length,
-		      int bufnum);
-static int ack_tx(struct net_device *dev, int acked);
-
-
-static struct ArcProto capmode_proto =
-{
-	'r',
-	XMTU,
-	0,
-       	rx,
-	build_header,
-	prepare_tx,
-	NULL,
-	ack_tx
-};
-
-
-static void arcnet_cap_init(void)
-{
-	int count;
-
-	for (count = 1; count <= 8; count++)
-		if (arc_proto_map[count] == arc_proto_default)
-			arc_proto_map[count] = &capmode_proto;
-
-	/* for cap mode, we only set the bcast proto if there's no better one */
-	if (arc_bcast_proto == arc_proto_default)
-		arc_bcast_proto = &capmode_proto;
-
-	arc_proto_default = &capmode_proto;
-	arc_raw_proto = &capmode_proto;
-}
-
-
-#ifdef MODULE
-
-static int __init capmode_module_init(void)
-{
-	printk(VERSION);
-	arcnet_cap_init();
-	return 0;
-}
-
-static void __exit capmode_module_exit(void)
-{
-	arcnet_unregister_proto(&capmode_proto);
-}
-module_init(capmode_module_init);
-module_exit(capmode_module_exit);
-
-MODULE_LICENSE("GPL");
-#endif				/* MODULE */
-
-
-
 /* packet receiver */
 static void rx(struct net_device *dev, int bufnum,
 	       struct archdr *pkthdr, int length)
@@ -231,65 +168,108 @@ static int prepare_tx(struct net_device *dev, struct archdr *pkt, int length,
 	BUGMSG(D_DURING, "prepare_tx: length=%d ofs=%d\n",
 	       length,ofs);
 
-	// Copy the arcnet-header + the protocol byte down:
+	/* Copy the arcnet-header + the protocol byte down: */
 	lp->hw.copy_to_card(dev, bufnum, 0, hard, ARC_HDR_SIZE);
 	lp->hw.copy_to_card(dev, bufnum, ofs, &pkt->soft.cap.proto,
 			    sizeof(pkt->soft.cap.proto));
 
-	// Skip the extra integer we have written into it as a cookie
-	// but write the rest of the message:
+	/* Skip the extra integer we have written into it as a cookie
+	   but write the rest of the message: */
 	lp->hw.copy_to_card(dev, bufnum, ofs+1,
 			    ((unsigned char*)&pkt->soft.cap.mes),length-1);
 
 	lp->lastload_dest = hard->dest;
 
-	return 1;		/* done */
+	return 1;	/* done */
 }
 
-
 static int ack_tx(struct net_device *dev, int acked)
 {
-  struct arcnet_local *lp = netdev_priv(dev);
-  struct sk_buff *ackskb;
-  struct archdr *ackpkt;
-  int length=sizeof(struct arc_cap);
+	struct arcnet_local *lp = netdev_priv(dev);
+	struct sk_buff *ackskb;
+	struct archdr *ackpkt;
+	int length=sizeof(struct arc_cap);
 
-  BUGMSG(D_DURING, "capmode: ack_tx: protocol: %x: result: %d\n",
-	 lp->outgoing.skb->protocol, acked);
+	BUGMSG(D_DURING, "capmode: ack_tx: protocol: %x: result: %d\n",
+		lp->outgoing.skb->protocol, acked);
 
-  BUGLVL(D_SKB) arcnet_dump_skb(dev, lp->outgoing.skb, "ack_tx");
+	BUGLVL(D_SKB) arcnet_dump_skb(dev, lp->outgoing.skb, "ack_tx");
 
-  /* Now alloc a skb to send back up through the layers: */
-  ackskb = alloc_skb(length + ARC_HDR_SIZE , GFP_ATOMIC);
-  if (ackskb == NULL) {
-	  BUGMSG(D_NORMAL, "Memory squeeze, can't acknowledge.\n");
-	  goto free_outskb;
-  }
+	/* Now alloc a skb to send back up through the layers: */
+	ackskb = alloc_skb(length + ARC_HDR_SIZE , GFP_ATOMIC);
+	if (ackskb == NULL) {
+		BUGMSG(D_NORMAL, "Memory squeeze, can't acknowledge.\n");
+		goto free_outskb;
+	}
 
-  skb_put(ackskb, length + ARC_HDR_SIZE );
-  ackskb->dev = dev;
+	skb_put(ackskb, length + ARC_HDR_SIZE );
+	ackskb->dev = dev;
 
-  skb_reset_mac_header(ackskb);
-  ackpkt = (struct archdr *)skb_mac_header(ackskb);
-  /* skb_pull(ackskb, ARC_HDR_SIZE); */
+	skb_reset_mac_header(ackskb);
+	ackpkt = (struct archdr *)skb_mac_header(ackskb);
+	/* skb_pull(ackskb, ARC_HDR_SIZE); */
 
+	skb_copy_from_linear_data(lp->outgoing.skb, ackpkt,
+				  ARC_HDR_SIZE + sizeof(struct arc_cap));
+	ackpkt->soft.cap.proto = 0; /* using protocol 0 for acknowledge */
+	ackpkt->soft.cap.mes.ack=acked;
 
-  skb_copy_from_linear_data(lp->outgoing.skb, ackpkt,
-		ARC_HDR_SIZE + sizeof(struct arc_cap));
-  ackpkt->soft.cap.proto=0; /* using protocol 0 for acknowledge */
-  ackpkt->soft.cap.mes.ack=acked;
+	BUGMSG(D_PROTO, "Ackknowledge for cap packet %x.\n",
+			*((int*)&ackpkt->soft.cap.cookie[0]));
 
-  BUGMSG(D_PROTO, "Ackknowledge for cap packet %x.\n",
-	 *((int*)&ackpkt->soft.cap.cookie[0]));
+	ackskb->protocol = cpu_to_be16(ETH_P_ARCNET);
 
-  ackskb->protocol = cpu_to_be16(ETH_P_ARCNET);
+	BUGLVL(D_SKB) arcnet_dump_skb(dev, ackskb, "ack_tx_recv");
+	netif_rx(ackskb);
 
-  BUGLVL(D_SKB) arcnet_dump_skb(dev, ackskb, "ack_tx_recv");
-  netif_rx(ackskb);
+free_outskb:
+	dev_kfree_skb_irq(lp->outgoing.skb);
+	lp->outgoing.proto = NULL; /* We are always finished when in this protocol */
+
+	return 0;
+}
+
+static struct ArcProto capmode_proto =
+{
+	'r',
+	XMTU,
+	0,
+	rx,
+	build_header,
+	prepare_tx,
+	NULL,
+	ack_tx
+};
 
- free_outskb:
-  dev_kfree_skb_irq(lp->outgoing.skb);
-  lp->outgoing.proto = NULL; /* We are always finished when in this protocol */
+static void arcnet_cap_init(void)
+{
+	int count;
 
-  return 0;
+	for (count = 1; count <= 8; count++)
+		if (arc_proto_map[count] == arc_proto_default)
+			arc_proto_map[count] = &capmode_proto;
+
+	/* for cap mode, we only set the bcast proto if there's no better one */
+	if (arc_bcast_proto == arc_proto_default)
+		arc_bcast_proto = &capmode_proto;
+
+	arc_proto_default = &capmode_proto;
+	arc_raw_proto = &capmode_proto;
 }
+
+static int __init capmode_module_init(void)
+{
+	printk(VERSION);
+	arcnet_cap_init();
+	return 0;
+}
+
+static void __exit capmode_module_exit(void)
+{
+	arcnet_unregister_proto(&capmode_proto);
+}
+module_init(capmode_module_init);
+module_exit(capmode_module_exit);
+
+MODULE_LICENSE("GPL");
+
-- 
1.7.1

^ permalink raw reply related

* Re: [PATCH 24/27] drivers/net/wan: Use memdup_user
From: David Miller @ 2010-05-31  7:31 UTC (permalink / raw)
  To: julia; +Cc: kevin.curtis, netdev, linux-kernel, kernel-janitors
In-Reply-To: <Pine.LNX.4.64.1005221025450.13021@ask.diku.dk>

From: Julia Lawall <julia@diku.dk>
Date: Sat, 22 May 2010 10:26:04 +0200 (CEST)

> From: Julia Lawall <julia@diku.dk>
> 
> Use memdup_user when user data is immediately copied into the
> allocated region.
> 
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
 ...
> Signed-off-by: Julia Lawall <julia@diku.dk>

Applied.

^ permalink raw reply

* Re: [PATCH 26/27] drivers/isdn: Use memdup_user
From: David Miller @ 2010-05-31  7:31 UTC (permalink / raw)
  To: julia; +Cc: isdn, netdev, linux-kernel, kernel-janitors
In-Reply-To: <Pine.LNX.4.64.1005221026230.13021@ask.diku.dk>

From: Julia Lawall <julia@diku.dk>
Date: Sat, 22 May 2010 10:26:42 +0200 (CEST)

> From: Julia Lawall <julia@diku.dk>
> 
> Use memdup_user when user data is immediately copied into the
> allocated region.
> 
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
 ...
> Signed-off-by: Julia Lawall <julia@diku.dk>

Applied.

^ permalink raw reply

* Re: [patch v2] caif: cleanup: remove duplicate checks
From: David Miller @ 2010-05-31  7:32 UTC (permalink / raw)
  To: sjurbren; +Cc: error27, wharms, netdev, sjur.brandeland, sfr, kernel-janitors
In-Reply-To: <AANLkTilHv7m-oJSlXHJRLT9BLKscGLSFnGVCOB9U0kic@mail.gmail.com>

From: Sjur Brændeland <sjurbren@gmail.com>
Date: Mon, 24 May 2010 22:47:41 +0200

>  Dan Carpenter <error27@gmail.com> wrote:
>> "phyinfo" can never be null here because we assigned it an address, so I
>> removed both the assert and the second check inside the if statement.  I
>> removed the "phyinfo->phy_layer != NULL" check as well because that was
>> asserted earlier.
>>
>> Walter Harms suggested I move the "phyinfo->phy_ref_count++;" outside
>> the if condition for readability, so I have done that.
>>
>> Signed-off-by: Dan Carpenter <error27@gmail.com>
> Acked-by: Sjur Braendeland <sjur.brandeland@stericsson.com>
> Thanks, this looks good.

Applied.

^ permalink raw reply

* Re: [patch] caif: remove unneeded null check in caif_connect()
From: David Miller @ 2010-05-31  7:32 UTC (permalink / raw)
  To: sjurbren
  Cc: error27, sjur.brandeland, eric.dumazet, linux-kernel, netdev,
	kernel-janitors
In-Reply-To: <AANLkTikM6_-YgLcBtcxN_TA1ISHkRk6fCEJVOS7pRZel@mail.gmail.com>

From: Sjur Brændeland <sjurbren@gmail.com>
Date: Mon, 24 May 2010 21:56:01 +0200

> Dan Carpenter <error27@gmail.com> wrote:
>> We already dereferenced uaddr towards the start of the function when we
>> checked that "uaddr->sa_family != AF_CAIF".  Both the check here and the
>> earlier check were added in bece7b2398d0: "caif: Rewritten socket
>> implementation".  Before that patch, we assumed that we recieved a valid
>> pointer for uaddr, and based on that, I have removed this check.
>>
>> Signed-off-by: Dan Carpenter <error27@gmail.com>
> Thanks Looks good,
> Acked-by: Sjur Braendeland <sjur.brandeland@stericsson.com>

Applied.

^ permalink raw reply

* Re: [PATCH 0/2] fixes to arp_notify for virtual machine migration use case
From: David Miller @ 2010-05-31  7:32 UTC (permalink / raw)
  To: Ian.Campbell; +Cc: netdev, shemminger, Jeremy.Fitzhardinge, stable
In-Reply-To: <1274868492.24218.7350.camel@zakaz.uk.xensource.com>

From: Ian Campbell <Ian.Campbell@citrix.com>
Date: Wed, 26 May 2010 11:08:12 +0100

> Ian Campbell (3):
>       arp_notify: document that a gratuitous ARP request is sent when this option is enabled
>       arp_notify: allow drivers to explicitly request a notification event.
>       xen: netfront: explicitly generate arp_notify event after migration.

Applied to net-next-2.6, there was a new bonding notifier added meanwhile
and I changed the number of your new notifier to fix the conflict.

^ permalink raw reply

* Re: [PATCH] mlx4_en: use net_device dev_id to indicate port number
From: David Miller @ 2010-05-31  7:33 UTC (permalink / raw)
  To: eli-VPRAkNaXOzVS1MOuV/RT9w
  Cc: netdev-u79uwXL29TY76Z2rM5mHXA, linux-rdma-u79uwXL29TY76Z2rM5mHXA,
	rdreier-FYB4Gu1CFyUAvxtiuMwx3w, yevgenyp-VPRAkNaXOzVS1MOuV/RT9w,
	shemminger-ZtmgI6mnKB3QT0dZR+AlfA
In-Reply-To: <20100527055624.GA18736-8YAHvHwT2UEvbXDkjdHOrw/a8Rv0c6iv@public.gmane.org>

From: Eli Cohen <eli-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
Date: Thu, 27 May 2010 08:56:24 +0300

> Today, there are no means to know which port of a hardware device a netdev
> interface uses. struct net_device conatins a field, dev_id, that can be used
> for that. Use this field to save the port number in ConnectX that is being used
> by the net device; port numbers are zero based.
> 
> Signed-off-by: Eli Cohen <eli-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply

* Re: [PATCH net-next-2.6 1/4] atm: [nicstar] reformatted with Lindent
From: David Miller @ 2010-05-31  7:33 UTC (permalink / raw)
  To: chas; +Cc: netdev
In-Reply-To: <201005291903.o4TJ3iFh004998@thirdoffive.cmf.nrl.navy.mil>

From: "chas williams - CONTRACTOR" <chas@cmf.nrl.navy.mil>
Date: Sat, 29 May 2010 15:03:44 -0400

> From: chas williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
> 
> Author: chas williams - CONTRACTOR <chas@relax.cmf.nrl.navy.mil>
> Date:   Fri May 28 18:43:47 2010 -0400
> 
>     atm: [nicstar] reformatted with Lindent
>     
>     Signed-off-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
> 

Applied.

^ permalink raw reply

* Re: [PATCH net-next-2.6 2/4] atm: [nicstar] remove virt_to_bus() and support 64-bit platforms
From: David Miller @ 2010-05-31  7:33 UTC (permalink / raw)
  To: chas; +Cc: netdev
In-Reply-To: <201005291904.o4TJ4Pgo005114@thirdoffive.cmf.nrl.navy.mil>

From: "chas williams - CONTRACTOR" <chas@cmf.nrl.navy.mil>
Date: Sat, 29 May 2010 15:04:25 -0400

> From: chas williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
> 
> Author: chas williams - CONTRACTOR <chas@relax.cmf.nrl.navy.mil>
> Date:   Fri May 28 18:48:16 2010 -0400
> 
>     atm: [nicstar] remove virt_to_bus() and support 64-bit platforms
>     
>     Signed-off-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>

Applied.

^ permalink raw reply

* Re: [PATCH net-next-2.6 3/4] atm: [he] remove small buffer allocation/handling code
From: David Miller @ 2010-05-31  7:33 UTC (permalink / raw)
  To: chas; +Cc: netdev
In-Reply-To: <201005291904.o4TJ4xEl006158@thirdoffive.cmf.nrl.navy.mil>

From: "chas williams - CONTRACTOR" <chas@cmf.nrl.navy.mil>
Date: Sat, 29 May 2010 15:04:59 -0400

> From: chas williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
> 
> Author: chas williams - CONTRACTOR <chas@relax.cmf.nrl.navy.mil>
> Date:   Fri May 28 19:45:59 2010 -0400
> 
>     atm: [he] remove small buffer allocation/handling code
>     
>     Signed-off-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>

Applied.

^ permalink raw reply

* Re: [PATCH net-next-2.6 4/4] atm: [he] rewrite buffer handling in receive path
From: David Miller @ 2010-05-31  7:33 UTC (permalink / raw)
  To: chas; +Cc: netdev
In-Reply-To: <201005291905.o4TJ5XrX006431@thirdoffive.cmf.nrl.navy.mil>

From: "chas williams - CONTRACTOR" <chas@cmf.nrl.navy.mil>
Date: Sat, 29 May 2010 15:05:33 -0400

> From: chas williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
> 
> Author: chas williams - CONTRACTOR <chas@relax.cmf.nrl.navy.mil>
> Date:   Fri May 28 19:50:47 2010 -0400
> 
>     atm: [he] rewrite buffer handling in receive path
>     
>     Instead of a fixed list of buffers, use the buffer pool correctly and
>     keep track of the outstanding buffer indexes using a fixed table.
>     Resolves reported HBUF_ERR's -- failures due to lack of receive buffers.
>     
>     Signed-off-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>

Applied.

^ permalink raw reply

* Re: [Patch]8139too: remove unnecessary cast of ioread32()'s return value
From: David Miller @ 2010-05-31  7:33 UTC (permalink / raw)
  To: junchangwang; +Cc: romieu, netdev
In-Reply-To: <20100530122213.GB1146@host-a-55.ustcsz.edu.cn>

From: Junchang Wang <junchangwang@gmail.com>
Date: Sun, 30 May 2010 20:22:14 +0800

> ioread32() returns a 32-bit integer on all platforms.
> There is no need to cast its return value.
> 
> Signed-off-by: Junchang Wang <junchangwang@gmail.com>

Applied.

^ permalink raw reply

* Re: [Patch]r8169: remove unnecessary cast of readl()'s return value
From: David Miller @ 2010-05-31  7:33 UTC (permalink / raw)
  To: junchangwang; +Cc: romieu, netdev
In-Reply-To: <20100530122606.GC1146@host-a-55.ustcsz.edu.cn>

From: Junchang Wang <junchangwang@gmail.com>
Date: Sun, 30 May 2010 20:26:07 +0800

> readl() returns a 32-bit integer on all platforms.
> There is no need to cast its return value.
> 
> Signed-off-by: Junchang Wang <junchangwang@gmail.com>

Applied.

^ permalink raw reply


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox