Netdev List
 help / color / mirror / Atom feed
* Re: [PATCH 1/2] r6040: implement phylib
From: David Miller @ 2010-06-01  7:18 UTC (permalink / raw)
  To: florian; +Cc: netdev
In-Reply-To: <201005312118.58728.florian@openwrt.org>

From: Florian Fainelli <florian@openwrt.org>
Date: Mon, 31 May 2010 21:18:57 +0200

> This patch adds support for using phylib and adds the required mdiobus driver
> stubs. This allows for less code to be present in the driver and removes
> the PHY status specific timer which is now handled by phylib directly.
> 
> Signed-off-by: Florian Fainelli <florian@openwrt.org>

Applied to net-next-2.6

^ permalink raw reply

* Re: [PATCH 2/2] tulip: implement wake-on-lan support
From: David Miller @ 2010-06-01  7:18 UTC (permalink / raw)
  To: stevenrwalter; +Cc: grundler, kyle, netdev
In-Reply-To: <1275345283-10650-2-git-send-email-stevenrwalter@gmail.com>

From: Steven Walter <stevenrwalter@gmail.com>
Date: Mon, 31 May 2010 18:34:43 -0400

> Based on a patch from http://simon.baatz.info/wol-support-for-an983b/
> 
> Tested to resume from suspend by magic packet.
> 
> Signed-off-by: Steven Walter <stevenrwalter@gmail.com>

Applied.

^ permalink raw reply

* Re: [PATCH 1/2] tulip: explicity set to D0 power state during init
From: David Miller @ 2010-06-01  7:18 UTC (permalink / raw)
  To: stevenrwalter; +Cc: grundler, kyle, netdev
In-Reply-To: <1275361913-5630-1-git-send-email-stevenrwalter@gmail.com>

From: Steven Walter <stevenrwalter@gmail.com>
Date: Mon, 31 May 2010 23:11:53 -0400

> During the first suspend the chip would refuse to enter D3.  Subsequent
> suspends worked okay.  During resume the chip is commanded into D0.
> Doing so during initialization fixes the initial suspend.
> 
> Signed-off-by: Steven Walter <stevenrwalter@gmail.com>
> Signed-off-by: Grant Grundler <grundler@parisc-linux.org>

Applied.

^ permalink raw reply

* Re: [PATCH 11/21] drivers/net/tulip/eeprom.c: Remove unnecessary kmalloc casts
From: David Miller @ 2010-06-01  7:17 UTC (permalink / raw)
  To: joe; +Cc: linux-kernel, grundler, kyle, netdev
In-Reply-To: <4fc0e008a2fc826c5696c07bf25a68440e36353b.1275360951.git.joe@perches.com>

From: Joe Perches <joe@perches.com>
Date: Mon, 31 May 2010 20:23:13 -0700

> Signed-off-by: Joe Perches <joe@perches.com>

Applied.

^ permalink raw reply

* Re: [PATCH 10/21] drivers/net/gianfar.c: Remove unnecessary kmalloc casts
From: David Miller @ 2010-06-01  7:17 UTC (permalink / raw)
  To: joe; +Cc: linux-kernel, netdev
In-Reply-To: <787b5a04a6f7f854b0809c4358671d3d69f70efc.1275360951.git.joe@perches.com>

From: Joe Perches <joe@perches.com>
Date: Mon, 31 May 2010 20:23:12 -0700

> Signed-off-by: Joe Perches <joe@perches.com>

Applied.

^ permalink raw reply

* Re: [PATCH 20/21] net/ipv6/mcast.c: Remove unnecessary kmalloc casts
From: David Miller @ 2010-06-01  7:17 UTC (permalink / raw)
  To: joe; +Cc: linux-kernel, kuznet, pekkas, jmorris, yoshfuji, kaber, netdev
In-Reply-To: <52b8781064af8d4b1051f5ac175f7b7f175ff1ed.1275360951.git.joe@perches.com>

From: Joe Perches <joe@perches.com>
Date: Mon, 31 May 2010 20:23:22 -0700

> Signed-off-by: Joe Perches <joe@perches.com>

Applied.

^ permalink raw reply

* Re: [PATCH 19/21] net/ipv4/igmp.c: Remove unnecessary kmalloc casts
From: David Miller @ 2010-06-01  7:17 UTC (permalink / raw)
  To: joe; +Cc: linux-kernel, kuznet, pekkas, jmorris, yoshfuji, kaber, netdev
In-Reply-To: <cac9f44ad085db78698681859236a7c3a0983e49.1275360951.git.joe@perches.com>

From: Joe Perches <joe@perches.com>
Date: Mon, 31 May 2010 20:23:21 -0700

> Signed-off-by: Joe Perches <joe@perches.com>

Applied.

^ permalink raw reply

* Re: [PATCH] can: mpc5xxx_can.c: Fix build failure
From: David Miller @ 2010-06-01  7:11 UTC (permalink / raw)
  To: wg; +Cc: agust, socketcan-core, netdev, grant.likely
In-Reply-To: <4C04A6C2.2090705@grandegger.com>

From: Wolfgang Grandegger <wg@grandegger.com>
Date: Tue, 01 Jun 2010 08:20:50 +0200

> On 05/31/2010 08:27 PM, Wolfgang Grandegger wrote:
>> Hi Anatolij,
>> 
>> On 05/31/2010 06:31 PM, Anatolij Gustschin wrote:
>>> Fixes build error caused by the OF device_node pointer
>>> being moved into struct device.
>>>
>>> Signed-off-by: Anatolij Gustschin <agust@denx.de>
>>> Cc: Wolfgang Grandegger <wg@grandegger.com>
>>> Cc: Grant Likely <grant.likely@secretlab.ca>
> 
> Acked-by: Wolfgang Grandegger <wg@grandegger.com>

Applied, thanks.

^ permalink raw reply

* [PATCH] greth: Fix build after OF device conversions.
From: David Miller @ 2010-06-01  7:10 UTC (permalink / raw)
  To: grant.likely; +Cc: netdev


Signed-off-by: David S. Miller <davem@davemloft.net>
---

I've pushed this to net-2.6

 drivers/net/greth.c |   11 +++++------
 1 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/net/greth.c b/drivers/net/greth.c
index f37a4c1..3a029d0 100644
--- a/drivers/net/greth.c
+++ b/drivers/net/greth.c
@@ -1607,14 +1607,13 @@ static struct of_device_id greth_of_match[] = {
 MODULE_DEVICE_TABLE(of, greth_of_match);
 
 static struct of_platform_driver greth_of_driver = {
-	.name = "grlib-greth",
-	.match_table = greth_of_match,
+	.driver = {
+		.name = "grlib-greth",
+		.owner = THIS_MODULE,
+		.of_match_table = greth_of_match,
+	},
 	.probe = greth_of_probe,
 	.remove = __devexit_p(greth_of_remove),
-	.driver = {
-		   .owner = THIS_MODULE,
-		   .name = "grlib-greth",
-		   },
 };
 
 static int __init greth_init(void)
-- 
1.7.0.4


^ permalink raw reply related

* [patch 2/2] caif: add newlines after declarations in caif_serial.c
From: Dan Carpenter @ 2010-06-01  7:09 UTC (permalink / raw)
  To: Sjur Braendeland; +Cc: netdev, kernel-janitors, David S. Miller

I added newlines after the declarations in caif_serial.c.  This is
normal kernel style, although I can't see anywhere it's documented.

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/drivers/net/caif/caif_serial.c b/drivers/net/caif/caif_serial.c
index f30a6a0..3e706f0 100644
--- a/drivers/net/caif/caif_serial.c
+++ b/drivers/net/caif/caif_serial.c
@@ -174,6 +174,7 @@ static void ldisc_receive(struct tty_struct *tty, const u8 *data,
 	struct ser_device *ser;
 	int ret;
 	u8 *p;
+
 	ser = tty->disc_data;
 
 	/*
@@ -221,6 +222,7 @@ static int handle_tx(struct ser_device *ser)
 	struct tty_struct *tty;
 	struct sk_buff *skb;
 	int tty_wr, len, room;
+
 	tty = ser->tty;
 	ser->tx_started = true;
 
@@ -281,6 +283,7 @@ error:
 static int caif_xmit(struct sk_buff *skb, struct net_device *dev)
 {
 	struct ser_device *ser;
+
 	BUG_ON(dev == NULL);
 	ser = netdev_priv(dev);
 
@@ -299,6 +302,7 @@ static int caif_xmit(struct sk_buff *skb, struct net_device *dev)
 static void ldisc_tx_wakeup(struct tty_struct *tty)
 {
 	struct ser_device *ser;
+
 	ser = tty->disc_data;
 	BUG_ON(ser == NULL);
 	BUG_ON(ser->tty != tty);
@@ -348,6 +352,7 @@ static void ldisc_close(struct tty_struct *tty)
 	struct ser_device *ser = tty->disc_data;
 	/* Remove may be called inside or outside of rtnl_lock */
 	int islocked = rtnl_is_locked();
+
 	if (!islocked)
 		rtnl_lock();
 	/* device is freed automagically by net-sysfs */
@@ -374,6 +379,7 @@ static struct tty_ldisc_ops caif_ldisc = {
 static int register_ldisc(void)
 {
 	int result;
+
 	result = tty_register_ldisc(N_CAIF, &caif_ldisc);
 	if (result < 0) {
 		pr_err("cannot register CAIF ldisc=%d err=%d\n", N_CAIF,
@@ -391,6 +397,7 @@ static const struct net_device_ops netdev_ops = {
 static void caifdev_setup(struct net_device *dev)
 {
 	struct ser_device *serdev = netdev_priv(dev);
+
 	dev->features = 0;
 	dev->netdev_ops = &netdev_ops;
 	dev->type = ARPHRD_CAIF;
@@ -423,6 +430,7 @@ static int caif_net_close(struct net_device *dev)
 static int __init caif_ser_init(void)
 {
 	int ret;
+
 	ret = register_ldisc();
 	debugfsdir = debugfs_create_dir("caif_serial", NULL);
 	return ret;
@@ -433,6 +441,7 @@ static void __exit caif_ser_exit(void)
 	struct ser_device *ser = NULL;
 	struct list_head *node;
 	struct list_head *_tmp;
+
 	list_for_each_safe(node, _tmp, &ser_list) {
 		ser = list_entry(node, struct ser_device, node);
 		dev_close(ser->dev);

^ permalink raw reply related

* [patch 1/2] caif: remove unneeded variable from caif_net_open()
From: Dan Carpenter @ 2010-06-01  7:08 UTC (permalink / raw)
  To: Sjur Braendeland; +Cc: netdev, David S. Miller, kernel-janitors

We don't use the "ser" variable so I've removed it.

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/drivers/net/caif/caif_serial.c b/drivers/net/caif/caif_serial.c
index 09257ca..f30a6a0 100644
--- a/drivers/net/caif/caif_serial.c
+++ b/drivers/net/caif/caif_serial.c
@@ -410,8 +410,6 @@ static void caifdev_setup(struct net_device *dev)
 
 static int caif_net_open(struct net_device *dev)
 {
-	struct ser_device *ser;
-	ser = netdev_priv(dev);
 	netif_wake_queue(dev);
 	return 0;
 }

^ permalink raw reply related

* [PATCH] be2net: convert hdr.timeout in be_cmd_loopback_test() to le32
From: Sathya Perla @ 2010-06-01  7:01 UTC (permalink / raw)
  To: netdev

The current code fails on ppc as hdr.timeout is not being converted
to le32.

Pls apply to net-2.6.

Signed-off-by: Sathya Perla <sathyap@serverengines.com>
---
 drivers/net/benet/be_cmds.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/benet/be_cmds.c b/drivers/net/benet/be_cmds.c
index 9e305d7..b9ad799 100644
--- a/drivers/net/benet/be_cmds.c
+++ b/drivers/net/benet/be_cmds.c
@@ -1593,7 +1593,7 @@ int be_cmd_loopback_test(struct be_adapter *adapter, u32 port_num,
 
 	be_cmd_hdr_prepare(&req->hdr, CMD_SUBSYSTEM_LOWLEVEL,
 			OPCODE_LOWLEVEL_LOOPBACK_TEST, sizeof(*req));
-	req->hdr.timeout = 4;
+	req->hdr.timeout = cpu_to_le32(4);
 
 	req->pattern = cpu_to_le64(pattern);
 	req->src_port = cpu_to_le32(port_num);
-- 
1.6.5.2


^ permalink raw reply related

* Re: [PATCH] net/ipv4/tcp_input.c: fix compilation breakage when FASTRETRANS_DEBUG > 1
From: David Miller @ 2010-06-01  6:48 UTC (permalink / raw)
  To: joe; +Cc: netdev, eric.dumazet
In-Reply-To: <1275330055.14079.8.camel@Joe-Laptop.home>

From: Joe Perches <joe@perches.com>
Date: Mon, 31 May 2010 11:20:55 -0700

> Commit: c720c7e8383aff1cb219bddf474ed89d850336e3 missed these.
> 
> Signed-off-by: Joe Perches <joe@perches.com>

Applied, thanks Joe.

^ permalink raw reply

* Re: [PATCH 0/2] netfilter: netfilter fixes
From: David Miller @ 2010-06-01  6:45 UTC (permalink / raw)
  To: kaber; +Cc: netfilter-devel, netdev
In-Reply-To: <1275322487-19026-1-git-send-email-kaber@trash.net>

From: kaber@trash.net
Date: Mon, 31 May 2010 18:14:45 +0200

> the following two patches fix two problems with the recent introduction of
> a seperately allocated jumpstack for xtables rulesets:
> 
> - a memory leak when registering new tables, from Xiaotian Feng
> 
> - performance degradation caused by not using per-CPU allocations
>   for the jumpstack, from Eric
> 
> Please apply or pull from:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/kaber/nf-2.6.git master

Pulled, thanks Patrick.

^ permalink raw reply

* Re: [PATCH] net: sock_queue_err_skb() dont mess with sk_forward_alloc
From: David Miller @ 2010-06-01  6:44 UTC (permalink / raw)
  To: eric.dumazet; +Cc: anton, netdev
In-Reply-To: <1275321766.3291.100.camel@edumazet-laptop>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 31 May 2010 18:02:46 +0200

> There is also a problem in ip_recv_error(), not called with socket
> locked, skb freed -> potential corruption.
> 
> If current socket is 'owned' by a user thread, then we can still corrupt
> sk_forward_alloc, even if we use bh_lock_sock()
> 
> I dont think we need to have another backlog for such case, maybe we
> could account for skb->truesize in sk_rmem_alloc (this is atomic), and
> not account for sk_mem_charge ?

That sounds fine to me.

> [PATCH] net: sock_queue_err_skb() dont mess with sk_forward_alloc
> 
> Correct sk_forward_alloc handling for error_queue would need to use a
> backlog of frames that softirq handler could not deliver because socket
> is owned by user thread. Or extend backlog processing to be able to
> process normal and error packets.
> 
> Another possibility is to not use mem charge for error queue, this is
> what I implemented in this patch.
> 
> Note: this reverts commit 29030374
> (net: fix sk_forward_alloc corruptions), since we dont need to lock
> socket anymore.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>

Looks good, applied, thanks Eric.

^ permalink raw reply

* Re: [PATCH] can: mpc5xxx_can.c: Fix build failure
From: Wolfgang Grandegger @ 2010-06-01  6:20 UTC (permalink / raw)
  To: Anatolij Gustschin
  Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w,
	netdev-u79uwXL29TY76Z2rM5mHXA, David S. Miller, Grant Likely
In-Reply-To: <4C03FF75.3010208-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>

On 05/31/2010 08:27 PM, Wolfgang Grandegger wrote:
> Hi Anatolij,
> 
> On 05/31/2010 06:31 PM, Anatolij Gustschin wrote:
>> Fixes build error caused by the OF device_node pointer
>> being moved into struct device.
>>
>> Signed-off-by: Anatolij Gustschin <agust-ynQEQJNshbs@public.gmane.org>
>> Cc: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
>> Cc: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>

Acked-by: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>

Thanks,

Wolfgang.

^ permalink raw reply

* Re: DDoS attack causing bad effect on conntrack searches
From: Changli Gao @ 2010-06-01  5:48 UTC (permalink / raw)
  To: Eric Dumazet
  Cc: hawk, Jesper Dangaard Brouer, paulmck, Patrick McHardy,
	Linux Kernel Network Hackers, Netfilter Developers
In-Reply-To: <1275368732.2478.88.camel@edumazet-laptop>

On Tue, Jun 1, 2010 at 1:05 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Le mardi 01 juin 2010 à 08:28 +0800, Changli Gao a écrit :
>> On Tue, Jun 1, 2010 at 5:21 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>> >
>> > I had a look at current conntrack and found the 'unconfirmed' list was
>> > maybe a candidate for a potential blackhole.
>> >
>> > That is, if a reader happens to hit an entry that is moved from regular
>> > hash table slot 'hash' to unconfirmed list,
>>
>> Sorry, but I can't find where we do this things. unconfirmed list is
>> used to track the unconfirmed cts, whose corresponding skbs are still
>> in path from the first to the last netfilter hooks. As soon as the
>> skbs end their travel in netfilter, the corresponding cts will be
>> confirmed(moving ct from unconfirmed list to regular hash table).
>>
>
> So netfilter is a monolithic thing.
>
> When a packet begins its travel into netfilter, you guarantee that no
> other packet can also begin its travel and find an unconfirmed
> conntrack ?
>
> I wonder why we use atomic ops then to track the confirmed bit :)

seems no need.

>
>
>> unconfirmed list should be small, as networking receiving is in BH.
>
> So according to you, netfilter/ct runs only in input path ?

No. there are another entrances: local out and nf_reinject. If there
isn't any packet queued, as netfilter is in atomic context, the nubmer
of unconfirmed cts should be small( at most, 2 * nr_cpu?).

>
> So I assume a packet is handled by CPU X, creates a new conntrack
> (possibly early droping an old entry that was previously in a standard
> hash chain), inserted in unconfirmed list.
>

Oh, Thanks, I got it.

> _You_ guarantee another CPU
> Y, handling another packet, possibly sent by a hacker reading your
> netdev mails, cannot find the conntrack that was early dropped ?
>
>> How about implementing unconfirmed list as a per cpu variable?
>
> I first implemented such a patch to reduce cache line contention, then I
> asked to myself : What is exactly an unconfirmed conntrack ? Can their
> number be unbounded ? If yes, we have a problem, even on a two cpus
> machine. Using two lists instead of one wont solve the fundamental
> problem.
>
> The real question is, why do we need this unconfirmed 'list' in the
> first place. Is it really a private per cpu thing ?

No, it isn't really private. But most of time, it is accessed locally,
if it is implemented as a per cpu var.

> Can you prove this,
> in respect of lockless lookups, and things like NFQUEUE ?
>
> Each conntrack object has two list anchors. One for IP_CT_DIR_ORIGINAL,
> one for IP_CT_DIR_REPLY.
>
> Unconfirmed list use the first anchor. This means another cpu can
> definitely find an unconfirmed item in a regular hash chain, since we
> dont respect an RCU grace period before re-using an object.
>
> If memory was not a problem, we probably would use a third anchor to
> avoid this, or regular RCU instead of SLAB_DESTROY_BY_RCU variant.
>

thanks for your explaining.


-- 
Regards,
Changli Gao(xiaosuo@gmail.com)

^ permalink raw reply

* Re: DDoS attack causing bad effect on conntrack searches
From: Eric Dumazet @ 2010-06-01  5:05 UTC (permalink / raw)
  To: Changli Gao
  Cc: hawk, Jesper Dangaard Brouer, paulmck, Patrick McHardy,
	Linux Kernel Network Hackers, Netfilter Developers
In-Reply-To: <AANLkTikw3uonDB4nPXg8FVFN_07F_wq0SA_ayyAHL6VM@mail.gmail.com>

Le mardi 01 juin 2010 à 08:28 +0800, Changli Gao a écrit :
> On Tue, Jun 1, 2010 at 5:21 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> >
> > I had a look at current conntrack and found the 'unconfirmed' list was
> > maybe a candidate for a potential blackhole.
> >
> > That is, if a reader happens to hit an entry that is moved from regular
> > hash table slot 'hash' to unconfirmed list,
> 
> Sorry, but I can't find where we do this things. unconfirmed list is
> used to track the unconfirmed cts, whose corresponding skbs are still
> in path from the first to the last netfilter hooks. As soon as the
> skbs end their travel in netfilter, the corresponding cts will be
> confirmed(moving ct from unconfirmed list to regular hash table).
> 

So netfilter is a monolithic thing.

When a packet begins its travel into netfilter, you guarantee that no
other packet can also begin its travel and find an unconfirmed
conntrack ?

I wonder why we use atomic ops then to track the confirmed bit :)


> unconfirmed list should be small, as networking receiving is in BH.

So according to you, netfilter/ct runs only in input path ?

So I assume a packet is handled by CPU X, creates a new conntrack
(possibly early droping an old entry that was previously in a standard
hash chain), inserted in unconfirmed list. _You_ guarantee another CPU
Y, handling another packet, possibly sent by a hacker reading your
netdev mails, cannot find the conntrack that was early dropped ?

> How about implementing unconfirmed list as a per cpu variable?

I first implemented such a patch to reduce cache line contention, then I
asked to myself : What is exactly an unconfirmed conntrack ? Can their
number be unbounded ? If yes, we have a problem, even on a two cpus
machine. Using two lists instead of one wont solve the fundamental
problem.

The real question is, why do we need this unconfirmed 'list' in the
first place. Is it really a private per cpu thing ? Can you prove this,
in respect of lockless lookups, and things like NFQUEUE ? 

Each conntrack object has two list anchors. One for IP_CT_DIR_ORIGINAL,
one for IP_CT_DIR_REPLY.

Unconfirmed list use the first anchor. This means another cpu can
definitely find an unconfirmed item in a regular hash chain, since we
dont respect an RCU grace period before re-using an object.

If memory was not a problem, we probably would use a third anchor to
avoid this, or regular RCU instead of SLAB_DESTROY_BY_RCU variant.



--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply

* [PATCH 19/21] net/ipv4/igmp.c: Remove unnecessary kmalloc casts
From: Joe Perches @ 2010-06-01  3:23 UTC (permalink / raw)
  To: linux-kernel
  Cc: David S. Miller, Alexey Kuznetsov, Pekka Savola (ipv6),
	James Morris, Hideaki YOSHIFUJI, Patrick McHardy, netdev
In-Reply-To: <cover.1275360951.git.joe@perches.com>

Signed-off-by: Joe Perches <joe@perches.com>
---
 net/ipv4/igmp.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c
index 5fff865..250cb5e 100644
--- a/net/ipv4/igmp.c
+++ b/net/ipv4/igmp.c
@@ -1646,8 +1646,7 @@ static int sf_setstate(struct ip_mc_list *pmc)
 				if (dpsf->sf_inaddr == psf->sf_inaddr)
 					break;
 			if (!dpsf) {
-				dpsf = (struct ip_sf_list *)
-					kmalloc(sizeof(*dpsf), GFP_ATOMIC);
+				dpsf = kmalloc(sizeof(*dpsf), GFP_ATOMIC);
 				if (!dpsf)
 					continue;
 				*dpsf = *psf;
-- 
1.7.0.3.311.g6a6955


^ permalink raw reply related

* [PATCH 11/21] drivers/net/tulip/eeprom.c: Remove unnecessary kmalloc casts
From: Joe Perches @ 2010-06-01  3:23 UTC (permalink / raw)
  To: linux-kernel; +Cc: Grant Grundler, Kyle McMartin, netdev
In-Reply-To: <cover.1275360951.git.joe@perches.com>

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/net/tulip/eeprom.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/net/tulip/eeprom.c b/drivers/net/tulip/eeprom.c
index 6002e65..3031ed9 100644
--- a/drivers/net/tulip/eeprom.c
+++ b/drivers/net/tulip/eeprom.c
@@ -120,8 +120,8 @@ static void __devinit tulip_build_fake_mediatable(struct tulip_private *tp)
 			  0x00, 0x06  /* ttm bit map */
 			};
 
-		tp->mtable = (struct mediatable *)
-			kmalloc(sizeof(struct mediatable) + sizeof(struct medialeaf), GFP_KERNEL);
+		tp->mtable = kmalloc(sizeof(struct mediatable) +
+				     sizeof(struct medialeaf), GFP_KERNEL);
 
 		if (tp->mtable == NULL)
 			return; /* Horrible, impossible failure. */
@@ -227,9 +227,9 @@ subsequent_board:
 		        return;
 		}
 
-		mtable = (struct mediatable *)
-			kmalloc(sizeof(struct mediatable) + count*sizeof(struct medialeaf),
-					GFP_KERNEL);
+		mtable = kmalloc(sizeof(struct mediatable) +
+				 count * sizeof(struct medialeaf),
+				 GFP_KERNEL);
 		if (mtable == NULL)
 			return;				/* Horrible, impossible failure. */
 		last_mediatable = tp->mtable = mtable;
-- 
1.7.0.3.311.g6a6955


^ permalink raw reply related

* [PATCH 20/21] net/ipv6/mcast.c: Remove unnecessary kmalloc casts
From: Joe Perches @ 2010-06-01  3:23 UTC (permalink / raw)
  To: linux-kernel
  Cc: David S. Miller, Alexey Kuznetsov, Pekka Savola (ipv6),
	James Morris, Hideaki YOSHIFUJI, Patrick McHardy, netdev
In-Reply-To: <cover.1275360951.git.joe@perches.com>

Signed-off-by: Joe Perches <joe@perches.com>
---
 net/ipv6/mcast.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c
index 59f1881..7b5fb43 100644
--- a/net/ipv6/mcast.c
+++ b/net/ipv6/mcast.c
@@ -1995,8 +1995,7 @@ static int sf_setstate(struct ifmcaddr6 *pmc)
 				    &psf->sf_addr))
 					break;
 			if (!dpsf) {
-				dpsf = (struct ip6_sf_list *)
-					kmalloc(sizeof(*dpsf), GFP_ATOMIC);
+				dpsf = kmalloc(sizeof(*dpsf), GFP_ATOMIC);
 				if (!dpsf)
 					continue;
 				*dpsf = *psf;
-- 
1.7.0.3.311.g6a6955

^ permalink raw reply related

* [PATCH 10/21] drivers/net/gianfar.c: Remove unnecessary kmalloc casts
From: Joe Perches @ 2010-06-01  3:23 UTC (permalink / raw)
  To: linux-kernel; +Cc: netdev
In-Reply-To: <cover.1275360951.git.joe@perches.com>

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/net/gianfar.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c
index 1830f31..ab54821 100644
--- a/drivers/net/gianfar.c
+++ b/drivers/net/gianfar.c
@@ -681,8 +681,8 @@ static int gfar_of_init(struct of_device *ofdev, struct net_device **pdev)
 		priv->rx_queue[i] = NULL;
 
 	for (i = 0; i < priv->num_tx_queues; i++) {
-		priv->tx_queue[i] =  (struct gfar_priv_tx_q *)kzalloc(
-				sizeof (struct gfar_priv_tx_q), GFP_KERNEL);
+		priv->tx_queue[i] = kzalloc(sizeof(struct gfar_priv_tx_q),
+					    GFP_KERNEL);
 		if (!priv->tx_queue[i]) {
 			err = -ENOMEM;
 			goto tx_alloc_failed;
@@ -694,8 +694,8 @@ static int gfar_of_init(struct of_device *ofdev, struct net_device **pdev)
 	}
 
 	for (i = 0; i < priv->num_rx_queues; i++) {
-		priv->rx_queue[i] = (struct gfar_priv_rx_q *)kzalloc(
-					sizeof (struct gfar_priv_rx_q), GFP_KERNEL);
+		priv->rx_queue[i] = kzalloc(sizeof(struct gfar_priv_rx_q),
+					    GFP_KERNEL);
 		if (!priv->rx_queue[i]) {
 			err = -ENOMEM;
 			goto rx_alloc_failed;
-- 
1.7.0.3.311.g6a6955

^ permalink raw reply related

* [PATCH 1/2] tulip: explicity set to D0 power state during init
From: Steven Walter @ 2010-06-01  3:11 UTC (permalink / raw)
  To: grundler, kyle, netdev; +Cc: Steven Walter
In-Reply-To: <AANLkTilr33y7rlJpjto5blK4wXKaVst1O4IM0JgPNP7B@mail.gmail.com>

During the first suspend the chip would refuse to enter D3.  Subsequent
suspends worked okay.  During resume the chip is commanded into D0.
Doing so during initialization fixes the initial suspend.

Signed-off-by: Steven Walter <stevenrwalter@gmail.com>
Signed-off-by: Grant Grundler <grundler@parisc-linux.org>
---
 drivers/net/tulip/tulip_core.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/drivers/net/tulip/tulip_core.c b/drivers/net/tulip/tulip_core.c
index 3810db9..ec013c2 100644
--- a/drivers/net/tulip/tulip_core.c
+++ b/drivers/net/tulip/tulip_core.c
@@ -1380,6 +1380,13 @@ static int __devinit tulip_init_one (struct pci_dev *pdev,
 		return i;
 	}
 
+	/* The chip will fail to enter a low-power state later unless
+	 * first explicitly commanded into D0 */
+	if (pci_set_power_state(pdev, PCI_D0)) {
+		printk (KERN_NOTICE PFX
+			"Failed to set power state to D0\n");
+	}
+
 	irq = pdev->irq;
 
 	/* alloc_etherdev ensures aligned and zeroed private structures */
-- 
1.6.3.3


^ permalink raw reply related

* Re: Bug#583935: linux-image-2.6.32-5-amd64: kernel trace in net/ipv4/tcp_input.c:2540 tcp_ack
From: Ben Hutchings @ 2010-06-01  1:45 UTC (permalink / raw)
  To: Ritesh Raj Sarraf, 583935; +Cc: netdev
In-Reply-To: <20100531175508.13357.50413.reportbug@champaran.hq.netapp.com>

[-- Attachment #1: Type: text/plain, Size: 43132 bytes --]

On Mon, 2010-05-31 at 23:25 +0530, Ritesh Raj Sarraf wrote:
> Package: linux-2.6
> Version: 2.6.32-14
> Severity: normal
> Tags: squeeze
> 
> I haven't noticed a stability issue as such but saw this kernel trace
> logged into dmesg.

I'm forwarding this to the 'netdev' list to see if the upstream
developers can debug it.

Debian kernel version 2.6.32-14 is closely based on stable kernel
2.6.32.14.

Ben.

> -- Package-specific info:
> ** Version:
> Linux version 2.6.32-5-amd64 (Debian 2.6.32-14) (ben@decadent.org.uk) (gcc version 4.3.5 (Debian 4.3.5-1) ) #1 SMP Sun May 30 17:20:42 UTC 2010
> 
> ** Command line:
> BOOT_IMAGE=/vmlinuz-2.6.32-5-amd64 root=/dev/mapper/LocalDisk-ROOT ro quiet security=tomoyo splash
> 
> ** Tainted: W (512)
>  * Taint on warning.
> 
> ** Kernel log:
> [   28.406886] iwlagn 0000:03:00.0: firmware: requesting iwlwifi-5000-2.ucode
> [   28.548635] iwlagn 0000:03:00.0: loaded firmware version 8.24.2.12
> [   28.692813] Registered led device: iwl-phy0::radio
> [   28.692830] Registered led device: iwl-phy0::assoc
> [   28.692847] Registered led device: iwl-phy0::RX
> [   28.692863] Registered led device: iwl-phy0::TX
> [   28.705588] ADDRCONF(NETDEV_UP): wlan0: link is not ready
> [   28.977787] ip_tables: (C) 2000-2006 Netfilter Core Team
> [   29.974096] CPU0 attaching NULL sched-domain.
> [   29.974107] CPU1 attaching NULL sched-domain.
> [   30.000216] CPU0 attaching sched-domain:
> [   30.000225]  domain 0: span 0-1 level MC
> [   30.000231]   groups: 0 1
> [   30.000243] CPU1 attaching sched-domain:
> [   30.000248]  domain 0: span 0-1 level MC
> [   30.000253]   groups: 1 0
> [   30.752068] CE: hpet increasing min_delta_ns to 15000 nsec
> [   34.129035] e1000e 0000:00:19.0: irq 28 for MSI/MSI-X
> [   34.184125] e1000e 0000:00:19.0: irq 28 for MSI/MSI-X
> [   34.185657] ADDRCONF(NETDEV_UP): eth0: link is not ready
> [   40.052965] Registered led device: iwl-phy0::radio
> [   40.053013] Registered led device: iwl-phy0::assoc
> [   40.053057] Registered led device: iwl-phy0::RX
> [   40.053099] Registered led device: iwl-phy0::TX
> [   40.062505] ADDRCONF(NETDEV_UP): wlan0: link is not ready
> [   40.456244] e1000e 0000:00:19.0: irq 28 for MSI/MSI-X
> [   40.512218] e1000e 0000:00:19.0: irq 28 for MSI/MSI-X
> [   40.513753] ADDRCONF(NETDEV_UP): eth0: link is not ready
> [   40.820920] Registered led device: iwl-phy0::radio
> [   40.820972] Registered led device: iwl-phy0::assoc
> [   40.821016] Registered led device: iwl-phy0::RX
> [   40.821067] Registered led device: iwl-phy0::TX
> [   40.838420] ADDRCONF(NETDEV_UP): wlan0: link is not ready
> [   46.301012] wlan0: direct probe to AP 00:16:b6:a5:e7:1c (try 1)
> [   46.303662] wlan0: direct probe responded
> [   46.303669] wlan0: authenticate with AP 00:16:b6:a5:e7:1c (try 1)
> [   46.305533] wlan0: authenticated
> [   46.305566] wlan0: associate with AP 00:16:b6:a5:e7:1c (try 1)
> [   46.308078] wlan0: RX AssocResp from 00:16:b6:a5:e7:1c (capab=0x411 status=0 aid=2)
> [   46.308084] wlan0: associated
> [   46.322057] ADDRCONF(NETDEV_CHANGE): wlan0: link becomes ready
> [   46.393592] padlock: VIA PadLock not detected.
> [   50.772185] tun: Universal TUN/TAP device driver, 1.6
> [   50.772191] tun: (C) 1999-2004 Max Krasnyansky <maxk@qualcomm.com>
> [   50.775190] tun0: Disabled Privacy Extensions
> [   57.217677] CPU0 attaching NULL sched-domain.
> [   57.217681] CPU1 attaching NULL sched-domain.
> [   57.240126] CPU0 attaching sched-domain:
> [   57.240130]  domain 0: span 0-1 level MC
> [   57.240133]   groups: 0 1
> [   57.240139] CPU1 attaching sched-domain:
> [   57.240141]  domain 0: span 0-1 level MC
> [   57.240144]   groups: 1 0
> [   85.004087] hrtimer: interrupt took 544273 ns
> [   86.926725] TOMOYO-WARNING: Domain '<kernel> /etc/init.d/kdm /sbin/start-stop-daemon /usr/bin/kdm /etc/kde4/kdm/Xsession /bin/bash /usr/bin/ssh-agent /usr/bin/gpg-agent /usr/bin/dbus-launch /usr/bin/startkde /usr/lib/kde4/libexec/start_kdeinit_wrapper /usr/lib/kde4/libexec/start_kdeinit /usr/bin/kdeinit4 /usr/bin/plasma-desktop' has so many ACLs to hold. Stopped learning mode.
> [  174.886226] padlock: VIA PadLock Hash Engine not detected.
> [  364.553852] TOMOYO-WARNING: Domain '<kernel> /etc/init.d/kdm /sbin/start-stop-daemon /usr/bin/kdm /etc/kde4/kdm/Xsession /bin/bash /usr/bin/ssh-agent /usr/bin/gpg-agent /usr/bin/dbus-launch /usr/bin/startkde /usr/lib/kde4/libexec/start_kdeinit_wrapper /usr/lib/kde4/libexec/start_kdeinit /usr/bin/kdeinit4 /usr/bin/kontact' has so many ACLs to hold. Stopped learning mode.
> [ 1107.492423] EXT4-fs (dm-2): mounted filesystem with ordered data mode
> [ 2099.365512] TOMOYO-WARNING: Domain '<kernel> /etc/init.d/kdm /sbin/start-stop-daemon /usr/bin/kdm /etc/kde4/kdm/Xsession /bin/bash /usr/bin/ssh-agent /usr/bin/gpg-agent /usr/bin/dbus-launch /usr/bin/startkde /usr/lib/kde4/libexec/start_kdeinit_wrapper /usr/lib/kde4/libexec/start_kdeinit /usr/bin/kdeinit4 /usr/bin/konsole /bin/bash /usr/bin/sudo /usr/bin/aptitude /usr/bin/dpkg' has so many ACLs to hold. Stopped learning mode.
> [ 3497.934021] TOMOYO-WARNING: Domain '<kernel> /etc/init.d/kdm /sbin/start-stop-daemon /usr/bin/kdm /etc/kde4/kdm/Xsession /bin/bash /usr/bin/ssh-agent /usr/bin/gpg-agent /usr/bin/dbus-launch /usr/bin/startkde /usr/lib/kde4/libexec/start_kdeinit_wrapper /usr/lib/kde4/libexec/start_kdeinit /usr/bin/kdeinit4 /usr/bin/ktorrent' has so many ACLs to hold. Stopped learning mode.
> [ 6794.222126] TOMOYO-WARNING: Domain '<kernel> /etc/init.d/kdm /sbin/start-stop-daemon /usr/bin/kdm /etc/kde4/kdm/Xsession /bin/bash /usr/bin/ssh-agent /usr/bin/gpg-agent /usr/bin/dbus-launch /usr/bin/startkde /usr/lib/kde4/libexec/start_kdeinit_wrapper /usr/lib/kde4/libexec/start_kdeinit /usr/bin/kdeinit4 /usr/bin/krunner /usr/lib/kde4/libexec/kscreenlocker /usr/bin/plasma-overlay' has so many ACLs to hold. Stopped learning mode.
> [ 7716.171410] ------------[ cut here ]------------
> [ 7716.171420] WARNING: at /build/buildd-linux-2.6_2.6.32-14-amd64-yRQD2k/linux-2.6-2.6.32/debian/build/source_amd64_none/net/ipv4/tcp_input.c:2540 tcp_ack+0x160e/0x1952()
> [ 7716.171424] Hardware name: 6475KH8
> [ 7716.171426] Modules linked in: sha256_generic cbc tun aes_x86_64 aes_generic xt_state iptable_filter ip_tables nf_conntrack_ipv4 nf_defrag_ipv4 nf_conntrack_tftp nf_conntrack_proto_dccp nf_conntrack_pptp xt_conntrack x_tables nf_conntrack_ftp nf_conntrack_sane ts_kmp nf_conntrack_amanda nf_conntrack_h323 nf_conntrack_proto_gre nf_conntrack_sip nf_conntrack_proto_sctp nf_conntrack_irc nf_conntrack_proto_udplite nf_conntrack_netlink nfnetlink nf_conntrack_netbios_ns nf_conntrack_ipv6 nf_conntrack ppdev lp parport sco bridge stp bnep rfcomm l2cap acpi_cpufreq cpufreq_stats cpufreq_userspace cpufreq_conservative cpufreq_powersave hdaps thinkpad_ec kvm_intel kvm uinput binfmt_misc fuse ext3 jbd loop firewire_sbp2 dm_crypt snd_hda_codec_conexant snd_hda_intel snd_hda_codec arc4 snd_pcsp snd_hwdep ecb snd_pcm_oss i915 snd_mixer_oss drm_kms_helper uvcvideo videodev snd_pcm v4l1_compat btusb joydev bluetooth iwlagn pcmcia snd_timer v4l2_compat_ioctl32 drm iwlcore i2c_algo_bit snd t
>  hinkpad_acpi yenta_socket i2c_i801 tpm_tis soundcore tpm nvram led_class video snd_page_alloc tpm_bios i2c_core mac80211 cfg80211 wmi rfkill rsrc_nonstatic output pcmcia_core evdev ac serio_raw psmouse button battery processor ext4 mbcache jbd2 crc16 dm_mod sg sd_mod sr_mod crc_t10dif cdrom uhci_hcd firewire_ohci firewire_core crc_itu_t ahci ehci_hcd libata e1000e scsi_mod usbcore nls_base thermal thermal_sys [last unloaded: scsi_wait_scan]
> [ 7716.171547] Pid: 0, comm: swapper Not tainted 2.6.32-5-amd64 #1
> [ 7716.171549] Call Trace:
> [ 7716.171551]  <IRQ>  [<ffffffff81283705>] ? tcp_ack+0x160e/0x1952
> [ 7716.171559]  [<ffffffff81283705>] ? tcp_ack+0x160e/0x1952
> [ 7716.171564]  [<ffffffff8104dc48>] ? warn_slowpath_common+0x77/0xa3
> [ 7716.171569]  [<ffffffff81283705>] ? tcp_ack+0x160e/0x1952
> [ 7716.171573]  [<ffffffff81284166>] ? tcp_rcv_established+0xc9/0x6d9
> [ 7716.171578]  [<ffffffff8128b6ef>] ? tcp_v4_do_rcv+0x1bb/0x376
> [ 7716.171583]  [<ffffffff8126ef89>] ? ip_route_input+0x6b/0xcbf
> [ 7716.171587]  [<ffffffff8128bd0f>] ? tcp_v4_rcv+0x465/0x6b6
> [ 7716.171592]  [<ffffffff81271216>] ? ip_local_deliver_finish+0x0/0x1e9
> [ 7716.171596]  [<ffffffff81271216>] ? ip_local_deliver_finish+0x0/0x1e9
> [ 7716.171600]  [<ffffffff8127135c>] ? ip_local_deliver_finish+0x146/0x1e9
> [ 7716.171605]  [<ffffffff81270eab>] ? ip_rcv_finish+0x373/0x38d
> [ 7716.171609]  [<ffffffff81271165>] ? ip_rcv+0x2a0/0x2ed
> [ 7716.171614]  [<ffffffff8124d55e>] ? process_backlog+0x81/0xb4
> [ 7716.171618]  [<ffffffff8124db37>] ? net_rx_action+0xae/0x1c9
> [ 7716.171623]  [<ffffffff810539d6>] ? __do_softirq+0xdd/0x19f
> [ 7716.171634]  [<ffffffffa02b533d>] ? iwl_isr_ict+0x179/0x200 [iwlcore]
> [ 7716.171639]  [<ffffffff81011cac>] ? call_softirq+0x1c/0x30
> [ 7716.171643]  [<ffffffff81013903>] ? do_softirq+0x3f/0x7c
> [ 7716.171647]  [<ffffffff81053845>] ? irq_exit+0x36/0x76
> [ 7716.171651]  [<ffffffff81012ffa>] ? do_IRQ+0xa0/0xb6
> [ 7716.171655]  [<ffffffff810114d3>] ? ret_from_intr+0x0/0x11
> [ 7716.171657]  <EOI>  [<ffffffffa0201647>] ? acpi_idle_enter_simple+0x116/0x148 [processor]
> [ 7716.171677]  [<ffffffffa0201647>] ? acpi_idle_enter_simple+0x116/0x148 [processor]
> [ 7716.171682]  [<ffffffffa0201640>] ? acpi_idle_enter_simple+0x10f/0x148 [processor]
> [ 7716.171686]  [<ffffffff81237e46>] ? cpuidle_idle_call+0x94/0xee
> [ 7716.171690]  [<ffffffff8100feb1>] ? cpu_idle+0xa2/0xda
> [ 7716.171693]  [<ffffffff814ec140>] ? early_idt_handler+0x0/0x71
> [ 7716.171696]  [<ffffffff814eccd1>] ? start_kernel+0x3dc/0x3e8
> [ 7716.171699]  [<ffffffff814ec3b7>] ? x86_64_start_kernel+0xf9/0x106
> [ 7716.171701] ---[ end trace d930a229f048f9d9 ]---
> [10602.944028] TCP: Peer 151.81.183.141:30126/44441 unexpectedly shrunk window 773717473:773723425 (repaired)
> [10657.848015] TCP: Peer 151.81.183.141:30126/44441 unexpectedly shrunk window 773717473:773723425 (repaired)
> 
> ** Model information
> sys_vendor: LENOVO
> product_name: 6475KH8
> product_version: ThinkPad T400
> chassis_vendor: LENOVO
> chassis_version: Not Available
> bios_vendor: LENOVO
> bios_version: 7UET79WW (3.09 )
> board_vendor: LENOVO
> board_name: 6475KH8
> board_version: Not Available
> 
> ** Loaded modules:
> Module                  Size  Used by
> sha256_generic          8692  2 
> cbc                     2539  1 
> tun                    10828  0 
> aes_x86_64              7340  5 
> aes_generic            25714  1 aes_x86_64
> xt_state                1303  16 
> iptable_filter          2258  1 
> ip_tables              13899  1 iptable_filter
> nf_conntrack_ipv4       9833  16 
> nf_defrag_ipv4          1139  1 nf_conntrack_ipv4
> nf_conntrack_tftp       3321  0 
> nf_conntrack_proto_dccp     6466  0 
> nf_conntrack_pptp       3801  0 
> xt_conntrack            2407  0 
> x_tables               12845  3 xt_state,ip_tables,xt_conntrack
> nf_conntrack_ftp        5537  0 
> nf_conntrack_sane       3620  0 
> ts_kmp                  1623  5 
> nf_conntrack_amanda     2197  0 
> nf_conntrack_h323      36992  0 
> nf_conntrack_proto_gre     3579  1 nf_conntrack_pptp
> nf_conntrack_sip       13546  0 
> nf_conntrack_proto_sctp     6238  0 
> nf_conntrack_irc        3347  0 
> nf_conntrack_proto_udplite     2623  0 
> nf_conntrack_netlink    13128  0 
> nfnetlink               2398  1 nf_conntrack_netlink
> nf_conntrack_netbios_ns     1282  0 
> nf_conntrack_ipv6      10467  0 
> nf_conntrack           46551  18 xt_state,nf_conntrack_ipv4,nf_conntrack_tftp,nf_conntrack_proto_dccp,nf_conntrack_pptp,xt_conntrack,nf_conntrack_ftp,nf_conntrack_sane,nf_conntrack_amanda,nf_conntrack_h323,nf_conntrack_proto_gre,nf_conntrack_sip,nf_conntrack_proto_sctp,nf_conntrack_irc,nf_conntrack_proto_udplite,nf_conntrack_netlink,nf_conntrack_netbios_ns,nf_conntrack_ipv6
> ppdev                   5030  0 
> lp                      7462  0 
> parport                27954  2 ppdev,lp
> sco                     7209  2 
> bridge                 39598  0 
> stp                     1440  1 bridge
> bnep                    9427  2 
> rfcomm                 29581  6 
> l2cap                  24736  16 bnep,rfcomm
> acpi_cpufreq            5555  0 
> cpufreq_stats           2659  0 
> cpufreq_userspace       1992  0 
> cpufreq_conservative     5162  0 
> cpufreq_powersave        902  0 
> hdaps                   7765  1 
> thinkpad_ec             3694  1 hdaps
> kvm_intel              38050  0 
> kvm                   213544  1 kvm_intel
> uinput                  6376  1 
> binfmt_misc             6431  1 
> fuse                   50190  1 
> ext3                  106518  1 
> jbd                    37085  1 ext3
> loop                   11783  0 
> firewire_sbp2          11514  0 
> dm_crypt               10507  1 
> snd_hda_codec_conexant    21869  1 
> snd_hda_intel          19907  3 
> snd_hda_codec          54244  2 snd_hda_codec_conexant,snd_hda_intel
> arc4                    1274  2 
> snd_pcsp                6579  2 
> snd_hwdep               5380  1 snd_hda_codec
> ecb                     1841  2 
> snd_pcm_oss            32591  0 
> i915                  252896  2 
> snd_mixer_oss          12606  1 snd_pcm_oss
> drm_kms_helper         20065  1 i915
> uvcvideo               51743  0 
> videodev               29993  1 uvcvideo
> snd_pcm                60471  4 snd_hda_intel,snd_hda_codec,snd_pcsp,snd_pcm_oss
> v4l1_compat            11442  2 uvcvideo,videodev
> btusb                   9785  2 
> joydev                  8411  0 
> bluetooth              41827  9 sco,bnep,rfcomm,l2cap,btusb
> iwlagn                 71756  0 
> pcmcia                 19474  0 
> snd_timer              15582  1 snd_pcm
> v4l2_compat_ioctl32     8538  1 videodev
> drm                   142551  3 i915,drm_kms_helper
> iwlcore                77442  1 iwlagn
> i2c_algo_bit            4225  1 i915
> snd                    46446  19 snd_hda_codec_conexant,snd_hda_intel,snd_hda_codec,snd_pcsp,snd_hwdep,snd_pcm_oss,snd_mixer_oss,snd_pcm,snd_timer
> thinkpad_acpi          50103  0 
> yenta_socket           19115  1 
> i2c_i801                7830  0 
> tpm_tis                 7336  0 
> soundcore               4598  1 snd
> tpm                     9917  1 tpm_tis
> nvram                   5061  1 thinkpad_acpi
> led_class               2433  2 iwlcore,thinkpad_acpi
> video                  17445  1 i915
> snd_page_alloc          6249  2 snd_hda_intel,snd_pcm
> tpm_bios                4521  1 tpm
> i2c_core               15712  6 i915,drm_kms_helper,videodev,drm,i2c_algo_bit,i2c_i801
> mac80211              136844  2 iwlagn,iwlcore
> cfg80211              101432  3 iwlagn,iwlcore,mac80211
> wmi                     4323  0 
> rfkill                 13044  4 bluetooth,thinkpad_acpi,cfg80211
> rsrc_nonstatic          7294  1 yenta_socket
> output                  1692  1 video
> pcmcia_core            24118  3 pcmcia,yenta_socket,rsrc_nonstatic
> evdev                   7352  28 
> ac                      2192  0 
> serio_raw               3752  0 
> psmouse                49777  0 
> button                  4650  1 i915
> battery                 4998  0 
> processor              30231  3 acpi_cpufreq
> ext4                  285611  2 
> mbcache                 5050  2 ext3,ext4
> jbd2                   66919  1 ext4
> crc16                   1319  2 l2cap,ext4
> dm_mod                 53754  9 dm_crypt
> sg                     18744  0 
> sd_mod                 29777  4 
> sr_mod                 12602  0 
> crc_t10dif              1276  1 sd_mod
> cdrom                  29415  1 sr_mod
> uhci_hcd               18521  0 
> firewire_ohci          19468  0 
> firewire_core          36736  2 firewire_sbp2,firewire_ohci
> crc_itu_t               1307  1 firewire_core
> ahci                   32358  3 
> ehci_hcd               31039  0 
> libata                133520  1 ahci
> e1000e                109967  0 
> scsi_mod              122117  5 firewire_sbp2,sg,sd_mod,sr_mod,libata
> usbcore               121959  5 uvcvideo,btusb,uhci_hcd,ehci_hcd
> nls_base                6361  1 usbcore
> thermal                11674  0 
> thermal_sys            11942  3 video,processor,thermal
> 
> ** Network interface configuration:
> 
> auto lo
> iface lo inet loopback
> 
> iface eth0dhcp inet dhcp
> 
> 
> iface dsl-provider inet ppp
> pre-up /sbin/ifconfig eth0 up # line maintained by pppoeconf
> provider dsl-provider
> 
> iface wlan0blr inet dhcp
>         wpa-ssid rrs
> wpa-psk *******************************
> 
> iface wlan0netapp inet dhcp
> 	wpa-ssid netapp
> 
> ** Network status:
> *** IP interfaces and addresses:
> 1: lo: <LOOPBACK,UP,LOWER_UP> mtu 16436 qdisc noqueue state UNKNOWN 
>     link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
>     inet 127.0.0.1/8 scope host lo
>     inet6 ::1/128 scope host 
>        valid_lft forever preferred_lft forever
> 2: eth0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc pfifo_fast state DOWN qlen 1000
>     link/ether 00:22:68:1b:af:4a brd ff:ff:ff:ff:ff:ff
> 3: wlan0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP qlen 1000
>     link/ether 00:26:c6:72:07:9a brd ff:ff:ff:ff:ff:ff
>     inet 192.168.2.101/24 brd 192.168.2.255 scope global wlan0
>     inet6 fe80::226:c6ff:fe72:79a/64 scope link 
>        valid_lft forever preferred_lft forever
> 4: pan0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN 
>     link/ether 52:02:e9:0e:27:d2 brd ff:ff:ff:ff:ff:ff
> 
> *** Device statistics:
> Inter-|   Receive                                                |  Transmit
>  face |bytes    packets errs drop fifo frame compressed multicast|bytes    packets errs drop fifo colls carrier compressed
>     lo:42635507   41327    0    0    0     0          0         0 42635507   41327    0    0    0     0       0          0
>   eth0:       0       0    0    0    0     0          0         0        0       0    0    0    0     0       0          0
>  wlan0:1032619756 1390916    0    0    0     0          0         0 752433881 1882435    0    0    0     0       0          0
>   pan0:       0       0    0    0    0     0          0         0        0       0    0    0    0     0       0          0
> 
> *** Protocol statistics:
> Ip:
>     1449157 total packets received
>     0 forwarded
>     0 incoming packets discarded
>     1444671 incoming packets delivered
>     1938464 requests sent out
>     109 outgoing packets dropped
>     15 dropped because of missing route
>     2 reassemblies required
>     1 packets reassembled ok
>     5 fragments failed
> Icmp:
>     3120 ICMP messages received
>     0 input ICMP message failed.
>     ICMP input histogram:
>         destination unreachable: 3015
>         timeout in transit: 105
>     2318 ICMP messages sent
>     0 ICMP messages failed
>     ICMP output histogram:
>         destination unreachable: 2318
> IcmpMsg:
>         InType3: 3015
>         InType11: 105
>         OutType3: 2318
> Tcp:
>     80024 active connections openings
>     23 passive connection openings
>     14172 failed connection attempts
>     1039 connection resets received
>     47 connections established
>     1372879 segments received
>     1620413 segments send out
>     212825 segments retransmited
>     0 bad segments received.
>     7303 resets sent
> Udp:
>     66389 packets received
>     2313 packets to unknown port received.
>     0 packet receive errors
>     103244 packets sent
> UdpLite:
> TcpExt:
>     531 packets pruned from receive queue because of socket buffer overrun
>     34 ICMP packets dropped because they were out-of-window
>     1 ICMP packets dropped because socket was locked
>     1790 TCP sockets finished time wait in fast timer
>     1265 time wait sockets recycled by time stamp
>     172 packets rejects in established connections because of timestamp
>     26690 delayed acks sent
>     5 delayed acks further delayed because of locked socket
>     Quick ack mode was activated 32051 times
>     1061 packets directly queued to recvmsg prequeue.
>     620116 bytes directly received in process context from prequeue
>     359424 packet headers predicted
>     595 packets header predicted and directly queued to user
>     213531 acknowledgments not containing data payload received
>     69799 predicted acknowledgments
>     3 times recovered from packet loss due to fast retransmit
>     9376 times recovered from packet loss by selective acknowledgements
>     6 bad SACK blocks received
>     Detected reordering 5 times using FACK
>     Detected reordering 12 times using SACK
>     Detected reordering 36 times using time stamp
>     33 congestion windows fully recovered without slow start
>     70 congestion windows partially recovered using Hoe heuristic
>     13 congestion windows recovered without slow start by DSACK
>     15526 congestion windows recovered without slow start after partial ack
>     11091 TCP data loss events
>     TCPLostRetransmit: 538
>     18 timeouts after reno fast retransmit
>     5211 timeouts after SACK recovery
>     2758 timeouts in loss state
>     19421 fast retransmits
>     232 forward retransmits
>     19995 retransmits in slow start
>     88651 other TCP timeouts
>     3 classic Reno fast retransmits failed
>     2608 SACK retransmits failed
>     6832 packets collapsed in receive queue due to low socket buffer
>     72330 DSACKs sent for old packets
>     10715 DSACKs sent for out of order packets
>     5884 DSACKs received
>     28 DSACKs for out of order packets received
>     2515 connections reset due to unexpected data
>     156 connections reset due to early user close
>     3646 connections aborted due to timeout
>     7 times unabled to send RST due to no memory
>     TCPSACKDiscard: 2
>     TCPDSACKIgnoredOld: 3730
>     TCPDSACKIgnoredNoUndo: 1811
>     TCPSpuriousRTOs: 46
>     TCPSackShiftFallback: 71643
> IpExt:
>     InNoRoutes: 2
>     InMcastPkts: 342
>     OutMcastPkts: 301
>     InBcastPkts: 4
>     InOctets: 1070306263
>     OutOctets: 732197456
>     InMcastOctets: 44349
>     OutMcastOctets: 40280
>     InBcastOctets: 1312
> 
> *** Device features:
> eth0: 0x1109a9
> lo: 0x13865
> pan0: 0xff3865
> wlan0: 0x2000
> 
> ** PCI devices:
> 00:00.0 Host bridge [0600]: Intel Corporation Mobile 4 Series Chipset Memory Controller Hub [8086:2a40] (rev 07)
> 	Subsystem: Lenovo Device [17aa:20e0]
> 	Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx-
> 	Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort+ >SERR- <PERR- INTx-
> 	Latency: 0
> 	Capabilities: <access denied>
> 	Kernel driver in use: agpgart-intel
> 
> 00:02.0 VGA compatible controller [0300]: Intel Corporation Mobile 4 Series Chipset Integrated Graphics Controller [8086:2a42] (rev 07) (prog-if 00 [VGA controller])
> 	Subsystem: Lenovo Device [17aa:20e4]
> 	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+
> 	Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
> 	Latency: 0
> 	Interrupt: pin A routed to IRQ 31
> 	Region 0: Memory at f4400000 (64-bit, non-prefetchable) [size=4M]
> 	Region 2: Memory at d0000000 (64-bit, prefetchable) [size=256M]
> 	Region 4: I/O ports at 1800 [size=8]
> 	Expansion ROM at <unassigned> [disabled]
> 	Capabilities: <access denied>
> 	Kernel driver in use: i915
> 
> 00:02.1 Display controller [0380]: Intel Corporation Mobile 4 Series Chipset Integrated Graphics Controller [8086:2a43] (rev 07)
> 	Subsystem: Lenovo Device [17aa:20e4]
> 	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
> 	Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
> 	Latency: 0
> 	Region 0: Memory at f4200000 (64-bit, non-prefetchable) [size=1M]
> 	Capabilities: <access denied>
> 
> 00:03.0 Communication controller [0780]: Intel Corporation Mobile 4 Series Chipset MEI Controller [8086:2a44] (rev 07)
> 	Subsystem: Lenovo Device [17aa:20e6]
> 	Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
> 	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx+
> 	Latency: 0
> 	Interrupt: pin A routed to IRQ 11
> 	Region 0: Memory at fc226800 (64-bit, non-prefetchable) [size=16]
> 	Capabilities: <access denied>
> 
> 00:03.3 Serial controller [0700]: Intel Corporation Mobile 4 Series Chipset AMT SOL Redirection [8086:2a47] (rev 07) (prog-if 02 [16550])
> 	Subsystem: Lenovo Device [17aa:20ec]
> 	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
> 	Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
> 	Latency: 0
> 	Interrupt: pin B routed to IRQ 17
> 	Region 0: I/O ports at 1830 [size=8]
> 	Region 1: Memory at fc024000 (32-bit, non-prefetchable) [size=4K]
> 	Capabilities: <access denied>
> 	Kernel driver in use: serial
> 
> 00:19.0 Ethernet controller [0200]: Intel Corporation 82567LM Gigabit Network Connection [8086:10f5] (rev 03)
> 	Subsystem: Lenovo Device [17aa:20ee]
> 	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx+
> 	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
> 	Latency: 0
> 	Interrupt: pin A routed to IRQ 28
> 	Region 0: Memory at fc000000 (32-bit, non-prefetchable) [size=128K]
> 	Region 1: Memory at fc025000 (32-bit, non-prefetchable) [size=4K]
> 	Region 2: I/O ports at 1840 [size=32]
> 	Capabilities: <access denied>
> 	Kernel driver in use: e1000e
> 
> 00:1a.0 USB Controller [0c03]: Intel Corporation 82801I (ICH9 Family) USB UHCI Controller #4 [8086:2937] (rev 03) (prog-if 00 [UHCI])
> 	Subsystem: Lenovo Device [17aa:20f0]
> 	Control: I/O+ Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
> 	Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
> 	Latency: 0
> 	Interrupt: pin A routed to IRQ 20
> 	Region 4: I/O ports at 1860 [size=32]
> 	Capabilities: <access denied>
> 	Kernel driver in use: uhci_hcd
> 
> 00:1a.1 USB Controller [0c03]: Intel Corporation 82801I (ICH9 Family) USB UHCI Controller #5 [8086:2938] (rev 03) (prog-if 00 [UHCI])
> 	Subsystem: Lenovo Device [17aa:20f0]
> 	Control: I/O+ Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
> 	Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
> 	Latency: 0
> 	Interrupt: pin B routed to IRQ 21
> 	Region 4: I/O ports at 1880 [size=32]
> 	Capabilities: <access denied>
> 	Kernel driver in use: uhci_hcd
> 
> 00:1a.2 USB Controller [0c03]: Intel Corporation 82801I (ICH9 Family) USB UHCI Controller #6 [8086:2939] (rev 03) (prog-if 00 [UHCI])
> 	Subsystem: Lenovo Device [17aa:20f0]
> 	Control: I/O+ Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
> 	Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
> 	Latency: 0
> 	Interrupt: pin C routed to IRQ 22
> 	Region 4: I/O ports at 18a0 [size=32]
> 	Capabilities: <access denied>
> 	Kernel driver in use: uhci_hcd
> 
> 00:1a.7 USB Controller [0c03]: Intel Corporation 82801I (ICH9 Family) USB2 EHCI Controller #2 [8086:293c] (rev 03) (prog-if 20 [EHCI])
> 	Subsystem: Lenovo Device [17aa:20f1]
> 	Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx-
> 	Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
> 	Latency: 0
> 	Interrupt: pin D routed to IRQ 23
> 	Region 0: Memory at fc226c00 (32-bit, non-prefetchable) [size=1K]
> 	Capabilities: <access denied>
> 	Kernel driver in use: ehci_hcd
> 
> 00:1b.0 Audio device [0403]: Intel Corporation 82801I (ICH9 Family) HD Audio Controller [8086:293e] (rev 03)
> 	Subsystem: Lenovo Device [17aa:20f2]
> 	Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx-
> 	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
> 	Latency: 0, Cache Line Size: 64 bytes
> 	Interrupt: pin B routed to IRQ 17
> 	Region 0: Memory at fc020000 (64-bit, non-prefetchable) [size=16K]
> 	Capabilities: <access denied>
> 	Kernel driver in use: HDA Intel
> 
> 00:1c.0 PCI bridge [0604]: Intel Corporation 82801I (ICH9 Family) PCI Express Port 1 [8086:2940] (rev 03) (prog-if 00 [Normal decode])
> 	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx+
> 	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
> 	Latency: 0, Cache Line Size: 64 bytes
> 	Bus: primary=00, secondary=02, subordinate=02, sec-latency=0
> 	I/O behind bridge: 00008000-00008fff
> 	Memory behind bridge: bc000000-bc1fffff
> 	Prefetchable memory behind bridge: 00000000bc200000-00000000bc3fffff
> 	Secondary status: 66MHz- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- <SERR- <PERR-
> 	BridgeCtl: Parity- SERR- NoISA+ VGA- MAbort- >Reset- FastB2B-
> 		PriDiscTmr- SecDiscTmr- DiscTmrStat- DiscTmrSERREn-
> 	Capabilities: <access denied>
> 	Kernel driver in use: pcieport
> 
> 00:1c.1 PCI bridge [0604]: Intel Corporation 82801I (ICH9 Family) PCI Express Port 2 [8086:2942] (rev 03) (prog-if 00 [Normal decode])
> 	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx+
> 	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
> 	Latency: 0, Cache Line Size: 64 bytes
> 	Bus: primary=00, secondary=03, subordinate=03, sec-latency=0
> 	I/O behind bridge: 00009000-00009fff
> 	Memory behind bridge: f4300000-f43fffff
> 	Prefetchable memory behind bridge: 00000000bc400000-00000000bc5fffff
> 	Secondary status: 66MHz- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- <SERR- <PERR-
> 	BridgeCtl: Parity- SERR- NoISA+ VGA- MAbort- >Reset- FastB2B-
> 		PriDiscTmr- SecDiscTmr- DiscTmrStat- DiscTmrSERREn-
> 	Capabilities: <access denied>
> 	Kernel driver in use: pcieport
> 
> 00:1c.3 PCI bridge [0604]: Intel Corporation 82801I (ICH9 Family) PCI Express Port 4 [8086:2946] (rev 03) (prog-if 00 [Normal decode])
> 	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx+
> 	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
> 	Latency: 0, Cache Line Size: 64 bytes
> 	Bus: primary=00, secondary=05, subordinate=0c, sec-latency=0
> 	I/O behind bridge: 00002000-00002fff
> 	Memory behind bridge: f8000000-f9ffffff
> 	Prefetchable memory behind bridge: 00000000f4000000-00000000f40fffff
> 	Secondary status: 66MHz- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- <SERR- <PERR-
> 	BridgeCtl: Parity- SERR- NoISA+ VGA- MAbort- >Reset- FastB2B-
> 		PriDiscTmr- SecDiscTmr- DiscTmrStat- DiscTmrSERREn-
> 	Capabilities: <access denied>
> 	Kernel driver in use: pcieport
> 
> 00:1c.4 PCI bridge [0604]: Intel Corporation 82801I (ICH9 Family) PCI Express Port 5 [8086:2948] (rev 03) (prog-if 00 [Normal decode])
> 	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx+
> 	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
> 	Latency: 0, Cache Line Size: 64 bytes
> 	Bus: primary=00, secondary=0d, subordinate=14, sec-latency=0
> 	I/O behind bridge: 00003000-00003fff
> 	Memory behind bridge: fa000000-fbffffff
> 	Prefetchable memory behind bridge: 00000000f4100000-00000000f41fffff
> 	Secondary status: 66MHz- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- <SERR- <PERR-
> 	BridgeCtl: Parity- SERR- NoISA+ VGA- MAbort- >Reset- FastB2B-
> 		PriDiscTmr- SecDiscTmr- DiscTmrStat- DiscTmrSERREn-
> 	Capabilities: <access denied>
> 	Kernel driver in use: pcieport
> 
> 00:1d.0 USB Controller [0c03]: Intel Corporation 82801I (ICH9 Family) USB UHCI Controller #1 [8086:2934] (rev 03) (prog-if 00 [UHCI])
> 	Subsystem: Lenovo Device [17aa:20f0]
> 	Control: I/O+ Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
> 	Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
> 	Latency: 0
> 	Interrupt: pin A routed to IRQ 16
> 	Region 4: I/O ports at 18c0 [size=32]
> 	Capabilities: <access denied>
> 	Kernel driver in use: uhci_hcd
> 
> 00:1d.1 USB Controller [0c03]: Intel Corporation 82801I (ICH9 Family) USB UHCI Controller #2 [8086:2935] (rev 03) (prog-if 00 [UHCI])
> 	Subsystem: Lenovo Device [17aa:20f0]
> 	Control: I/O+ Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
> 	Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
> 	Latency: 0
> 	Interrupt: pin B routed to IRQ 17
> 	Region 4: I/O ports at 18e0 [size=32]
> 	Capabilities: <access denied>
> 	Kernel driver in use: uhci_hcd
> 
> 00:1d.2 USB Controller [0c03]: Intel Corporation 82801I (ICH9 Family) USB UHCI Controller #3 [8086:2936] (rev 03) (prog-if 00 [UHCI])
> 	Subsystem: Lenovo Device [17aa:20f0]
> 	Control: I/O+ Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
> 	Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
> 	Latency: 0
> 	Interrupt: pin C routed to IRQ 18
> 	Region 4: I/O ports at 1c00 [size=32]
> 	Capabilities: <access denied>
> 	Kernel driver in use: uhci_hcd
> 
> 00:1d.7 USB Controller [0c03]: Intel Corporation 82801I (ICH9 Family) USB2 EHCI Controller #1 [8086:293a] (rev 03) (prog-if 20 [EHCI])
> 	Subsystem: Lenovo Device [17aa:20f1]
> 	Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx-
> 	Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
> 	Latency: 0
> 	Interrupt: pin D routed to IRQ 19
> 	Region 0: Memory at fc227000 (32-bit, non-prefetchable) [size=1K]
> 	Capabilities: <access denied>
> 	Kernel driver in use: ehci_hcd
> 
> 00:1e.0 PCI bridge [0604]: Intel Corporation 82801 Mobile PCI Bridge [8086:2448] (rev 93) (prog-if 01 [Subtractive decode])
> 	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx-
> 	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
> 	Latency: 0
> 	Bus: primary=00, secondary=15, subordinate=18, sec-latency=32
> 	I/O behind bridge: 00004000-00007fff
> 	Memory behind bridge: f4800000-f7ffffff
> 	Prefetchable memory behind bridge: 00000000f0000000-00000000f3ffffff
> 	Secondary status: 66MHz- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort+ <SERR- <PERR-
> 	BridgeCtl: Parity- SERR- NoISA+ VGA- MAbort- >Reset- FastB2B-
> 		PriDiscTmr- SecDiscTmr- DiscTmrStat- DiscTmrSERREn-
> 	Capabilities: <access denied>
> 
> 00:1f.0 ISA bridge [0601]: Intel Corporation ICH9M-E LPC Interface Controller [8086:2917] (rev 03)
> 	Subsystem: Lenovo Device [17aa:20f5]
> 	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
> 	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
> 	Latency: 0
> 	Capabilities: <access denied>
> 
> 00:1f.2 SATA controller [0106]: Intel Corporation ICH9M/M-E SATA AHCI Controller [8086:2929] (rev 03) (prog-if 01 [AHCI 1.0])
> 	Subsystem: Lenovo Device [17aa:20f8]
> 	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+
> 	Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
> 	Latency: 0
> 	Interrupt: pin B routed to IRQ 29
> 	Region 0: I/O ports at 1c48 [size=8]
> 	Region 1: I/O ports at 183c [size=4]
> 	Region 2: I/O ports at 1c40 [size=8]
> 	Region 3: I/O ports at 1838 [size=4]
> 	Region 4: I/O ports at 1c20 [size=32]
> 	Region 5: Memory at fc226000 (32-bit, non-prefetchable) [size=2K]
> 	Capabilities: <access denied>
> 	Kernel driver in use: ahci
> 
> 00:1f.3 SMBus [0c05]: Intel Corporation 82801I (ICH9 Family) SMBus Controller [8086:2930] (rev 03)
> 	Subsystem: Lenovo Device [17aa:20f9]
> 	Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx-
> 	Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
> 	Interrupt: pin A routed to IRQ 23
> 	Region 0: Memory at fc227400 (64-bit, non-prefetchable) [size=256]
> 	Region 4: I/O ports at 1c60 [size=32]
> 	Kernel driver in use: i801_smbus
> 
> 03:00.0 Network controller [0280]: Intel Corporation PRO/Wireless 5100 AGN [Shiloh] Network Connection [8086:4237]
> 	Subsystem: Intel Corporation WiFi Link 5100 AGN [8086:1211]
> 	Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx-
> 	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
> 	Latency: 0, Cache Line Size: 64 bytes
> 	Interrupt: pin A routed to IRQ 30
> 	Region 0: Memory at f4300000 (64-bit, non-prefetchable) [size=8K]
> 	Capabilities: <access denied>
> 	Kernel driver in use: iwlagn
> 
> 15:00.0 CardBus bridge [0607]: Ricoh Co Ltd RL5c476 II [1180:0476] (rev ba)
> 	Subsystem: Lenovo Device [17aa:20c6]
> 	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
> 	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
> 	Latency: 168, Cache Line Size: 64 bytes
> 	Interrupt: pin A routed to IRQ 16
> 	Region 0: Memory at f4800000 (32-bit, non-prefetchable) [size=4K]
> 	Bus: primary=15, secondary=16, subordinate=17, sec-latency=176
> 	Memory window 0: f0000000-f3fff000 (prefetchable)
> 	Memory window 1: c0000000-c3fff000
> 	I/O window 0: 00004000-000040ff
> 	I/O window 1: 00004400-000044ff
> 	BridgeCtl: Parity- SERR- ISA- VGA- MAbort- >Reset- 16bInt+ PostWrite+
> 	16-bit legacy interface ports at 0001
> 	Kernel driver in use: yenta_cardbus
> 
> 15:00.1 FireWire (IEEE 1394) [0c00]: Ricoh Co Ltd R5C832 IEEE 1394 Controller [1180:0832] (rev 04) (prog-if 10 [OHCI])
> 	Subsystem: Lenovo Device [17aa:20c7]
> 	Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx-
> 	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
> 	Latency: 32 (500ns min, 1000ns max), Cache Line Size: 64 bytes
> 	Interrupt: pin B routed to IRQ 17
> 	Region 0: Memory at f4801000 (32-bit, non-prefetchable) [size=2K]
> 	Capabilities: <access denied>
> 	Kernel driver in use: firewire_ohci
> 
> 
> ** USB devices:
> Bus 008 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
> Bus 007 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
> Bus 006 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
> Bus 005 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
> Bus 004 Device 003: ID 0a5c:2145 Broadcom Corp. Bluetooth with Enhanced Data Rate II
> Bus 004 Device 002: ID 08ff:2810 AuthenTec, Inc. AES2810
> Bus 004 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
> Bus 003 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> Bus 002 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
> Bus 001 Device 004: ID 17ef:1004 Lenovo 
> Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> 
> 
> -- System Information:
> Debian Release: squeeze/sid
>   APT prefers testing
>   APT policy: (990, 'testing'), (500, 'unstable'), (101, 'experimental')
> Architecture: amd64 (x86_64)
> 
> Kernel: Linux 2.6.32-5-amd64 (SMP w/2 CPU cores)
> Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> 
> Versions of packages linux-image-2.6.32-5-amd64 depends on:
> ii  debconf [debconf 1.5.32                  Debian configuration management sy
> ii  initramfs-tools  0.94.4                  tools for generating an initramfs
> ii  linux-base       2.6.34-1~experimental.1 Linux image base package
> ii  module-init-tool 3.12~pre2-3             tools for managing Linux kernel mo
> 
> Versions of packages linux-image-2.6.32-5-amd64 recommends:
> ii  firmware-linux-f 2.6.34-1~experimental.1 Binary firmware for various driver
> 
> Versions of packages linux-image-2.6.32-5-amd64 suggests:
> pn  grub | lilo                   <none>     (no description available)
> ii  linux-doc-2.6.32              2.6.32-9   Linux kernel specific documentatio
> 
> Versions of packages linux-image-2.6.32-5-amd64 is related to:
> pn  firmware-bnx2                 <none>     (no description available)
> pn  firmware-bnx2x                <none>     (no description available)
> pn  firmware-ipw2x00              <none>     (no description available)
> pn  firmware-ivtv                 <none>     (no description available)
> ii  firmware-iwlwifi              0.24       Binary firmware for Intel Wireless
> ii  firmware-linux                0.24       Binary firmware for various driver
> ii  firmware-linux-nonfree        0.24       Binary firmware for various driver
> pn  firmware-qlogic               <none>     (no description available)
> pn  firmware-ralink               <none>     (no description available)
> pn  xen-hypervisor                <none>     (no description available)
> 
> -- debconf information:
>   shared/kernel-image/really-run-bootloader: true
>   linux-image-2.6.32-5-amd64/postinst/depmod-error-initrd-2.6.32-5-amd64: false
>   linux-image-2.6.32-5-amd64/prerm/removing-running-kernel-2.6.32-5-amd64: true
>   linux-image-2.6.32-5-amd64/postinst/missing-firmware-2.6.32-5-amd64:
>   linux-image-2.6.32-5-amd64/postinst/bootloader-test-error-2.6.32-5-amd64:
>   linux-image-2.6.32-5-amd64/postinst/bootloader-error-2.6.32-5-amd64:
>   linux-image-2.6.32-5-amd64/prerm/would-invalidate-boot-loader-2.6.32-5-amd64: true
> 
> 
> 

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

^ permalink raw reply

* Re: [PATCH 1/2] tulip: explicity set to D0 power state during init
From: Grant Grundler @ 2010-06-01  1:00 UTC (permalink / raw)
  To: Steven Walter; +Cc: grundler, kyle, netdev
In-Reply-To: <1275345283-10650-1-git-send-email-stevenrwalter@gmail.com>

On Mon, May 31, 2010 at 06:34:42PM -0400, Steven Walter wrote:
> During the first suspend the chip would refuse to enter D3.  Subsequent
> suspends worked okay.  During resume the chip is commanded into D0.
> Doing so during initialization fixes the initial suspend.
> 
> Signed-off-by: Steven Walter <stevenrwalter@gmail.com>

Signed-off-by: Grant Grundler <grundler@parisc-linux.org>

> ---
>  drivers/net/tulip/tulip_core.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/tulip/tulip_core.c b/drivers/net/tulip/tulip_core.c
> index 3810db9..bb8c0ee 100644
> --- a/drivers/net/tulip/tulip_core.c
> +++ b/drivers/net/tulip/tulip_core.c
> @@ -1380,6 +1380,13 @@ static int __devinit tulip_init_one (struct pci_dev *pdev,
>  		return i;
>  	}
>  
> +	/* The chip will fail to enter a low-power state later unless
> +	 * first explicitly commanded into D0 */
> +	if (pci_set_power_state(pdev, PCI_D0)) {
> +		printk (KERN_ERR PFX

My only quibble is this message really isn't "KERN_ERR" worthy.
Can you explain why you think this should be ERR and not say, KERN_NOTICE?

(I'm looking at the definitions in include/linux/kernel.h of 2.6 source tree.)

If you want to repost with KERN_NOTICE, please include my S-O-B: line above.

thanks,
grant

> +			"Failed to set power state to D0\n");
> +	}
> +
>  	irq = pdev->irq;
>  
>  	/* alloc_etherdev ensures aligned and zeroed private structures */
> -- 
> 1.6.3.3

^ permalink raw reply


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox