* Re: [PATCH for-2.6.35] virtio_net: fix oom handling on tx
From: Rusty Russell @ 2010-06-21 2:43 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Stephen Hemminger, Sridhar Samudrala, virtualization, Jiri Pirko,
Shirley Ma, netdev, linux-kernel
In-Reply-To: <20100610190343.GC4044@redhat.com>
On Fri, 11 Jun 2010 04:33:43 am Michael S. Tsirkin wrote:
> > > > @@ -572,12 +571,14 @@ again:
> > > >
> > > > /* This can happen with OOM and indirect buffers. */
> > > > if (unlikely(capacity < 0)) {
> > > > - netif_stop_queue(dev);
> > > > - dev_warn(&dev->dev, "Unexpected full queue\n");
> > > > - if (unlikely(!virtqueue_enable_cb(vi->svq))) {
> > > > - virtqueue_disable_cb(vi->svq);
> > > > - netif_start_queue(dev);
> > > > - goto again;
> > > > + if (net_ratelimit()) {
> > > > + if (likely(capacity == -ENOMEM))
> > > > + dev_warn(&dev->dev,
> > > > + "TX queue failure: out of memory\n");
> > > > + else
> > > > + dev_warn(&dev->dev,
> > > > + "Unexpected TX queue failure: %d\n",
> > > > + capacity);
...
>
> Well, I only keep the existing behaviour around.
Actually, it *does* change behavior, as the comment indicates. So let's
fix the whole thing. AFAICT wth TX_BUSY we'll get called again RSN, and
that's not really useful for OOM.
This is what I have:
Subject: virtio_net: fix oom handling on tx
Date: Thu, 10 Jun 2010 18:20:41 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
virtio net will never try to overflow the TX ring, so the only reason
add_buf may fail is out of memory. Thus, we can not stop the
device until some request completes - there's no guarantee anything
at all is outstanding.
Make the error message clearer as well: error here does not
indicate queue full.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (...and avoid TX_BUSY)
Cc: stable@kernel.org
---
drivers/net/virtio_net.c | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -562,7 +562,6 @@ static netdev_tx_t start_xmit(struct sk_
struct virtnet_info *vi = netdev_priv(dev);
int capacity;
-again:
/* Free up any pending old buffers before queueing new ones. */
free_old_xmit_skbs(vi);
@@ -571,14 +570,17 @@ again:
/* This can happen with OOM and indirect buffers. */
if (unlikely(capacity < 0)) {
- netif_stop_queue(dev);
- dev_warn(&dev->dev, "Unexpected full queue\n");
- if (unlikely(!virtqueue_enable_cb(vi->svq))) {
- virtqueue_disable_cb(vi->svq);
- netif_start_queue(dev);
- goto again;
+ if (net_ratelimit()) {
+ if (likely(capacity == -ENOMEM))
+ dev_warn(&dev->dev,
+ "TX queue failure: out of memory\n");
+ else
+ dev_warn(&dev->dev,
+ "Unexpected TX queue failure: %d\n",
+ capacity);
}
- return NETDEV_TX_BUSY;
+ kfree_skb(skb);
+ return NETDEV_TX_OK;
}
virtqueue_kick(vi->svq);
^ permalink raw reply
* Re: [v3 Patch 2/2] mlx4: add dynamic LRO disable support
From: Cong Wang @ 2010-06-21 2:23 UTC (permalink / raw)
To: Stanislaw Gruszka
Cc: netdev, nhorman, herbert.xu, bhutchings, Ramkrishna.Vepa, davem
In-Reply-To: <20100618110910.GA4347@dhcp-lab-161.englab.brq.redhat.com>
On 06/18/10 19:09, Stanislaw Gruszka wrote:
> On Fri, Jun 18, 2010 at 06:55:38AM -0400, Amerigo Wang wrote:
>> +static int mlx4_ethtool_op_set_flags(struct net_device *dev, u32 data)
>> +{
>> + struct mlx4_en_priv *priv = netdev_priv(dev);
>> + struct mlx4_en_dev *mdev = priv->mdev;
>> + int rc = 0;
>> + int changed = 0;
>> +
>> + if (data& (ETH_FLAG_NTUPLE | ETH_FLAG_RXHASH))
>> + return -EOPNOTSUPP;
>> +
>> + if (data& ETH_FLAG_LRO) {
>> + if (!(dev->features& NETIF_F_LRO))
>> + changed = 1;
>> + } else if (dev->features& NETIF_F_LRO) {
>> + changed = 1;
>> + mdev->profile.num_lro = 0;
>
> Everything fine except that, what for you zero num_lro value?
>
> If we set it to zero it will stay zero and we will not create
> proper number of lro descriptors in mlx4_en_create_rx_ring()
> (called from mlx4_en_set_ringparam() -> mlx4_en_alloc_resources())
> when someone enable LRO again on.
>
Huh? Isn't ->num_lro which controls LRO of mlx4 driver?
^ permalink raw reply
* Re: [PATCH] net: optimize Berkeley Packet Filter (BPF) processing
From: Changli Gao @ 2010-06-21 2:15 UTC (permalink / raw)
To: Hagen Paul Pfeifer; +Cc: David Miller, shemminger, netdev, Linus Torvalds
In-Reply-To: <20100620215743.GA4036@nuttenaction>
On Mon, Jun 21, 2010 at 5:57 AM, Hagen Paul Pfeifer <hagen@jauu.net> wrote:
> * David Miller | 2010-06-20 15:09:28 [-0700]:
>
>>I think from this perspective, the change is fine too, nothing visible
>>to the user is being changed here.
>
> Fine! I have a fundamental question: can we start to use a C language
> extension, known as "Labels as Values" in the kernel? I checked this and at
> least gcc, llvm and icc support this extension (btw: c1x[1] don't mention
> this):
>
FYI: FreeBSD goes even further, and its BPF implementation exploits
JIT in two architectures: i386 and amd64.
--
Regards,
Changli Gao(xiaosuo@gmail.com)
^ permalink raw reply
* Re: 2.6.35-rc3: Reported regressions from 2.6.34
From: Maxim Levitsky @ 2010-06-20 22:58 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linux Kernel Mailing List, Maciej Rutecki, Andrew Morton,
Linus Torvalds, Kernel Testers List, Network Development,
Linux ACPI, Linux PM List, Linux SCSI List, Linux Wireless List,
DRI
In-Reply-To: <lc60d4toGTL.A.QzD._LpHMB@chimera>
On Mon, 2010-06-21 at 00:11 +0200, Rafael J. Wysocki wrote:
> This message contains a list of some regressions from 2.6.34,
> for which there are no fixes in the mainline known to the tracking team.
> If any of them have been fixed already, please let us know.
>
> If you know of any other unresolved regressions from 2.6.34, please let us
> know either and we'll add them to the list. Also, please let us know
> if any of the entries below are invalid.
>
> Each entry from the list will be sent additionally in an automatic reply
> to this message with CCs to the people involved in reporting and handling
> the issue.
>
>
> Listed regressions statistics:
>
> Date Total Pending Unresolved
> ----------------------------------------
> 2010-06-21 46 37 26
> 2010-06-09 15 13 10
>
>
> Unresolved regressions
> ----------------------
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16255
> Subject : 2.6.35-rc3 deadlocks on semaphore operations
> Submitter : Christoph Lameter <cl-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
> Date : 2010-06-18 14:49 (3 days old)
> Message-ID : <alpine.DEB.2.00.1006180940140.11575-sBS69tsa9Uj/9pzu0YdTqQ@public.gmane.org>
> References : http://marc.info/?l=linux-kernel&m=127687262727707&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16248
> Subject : inconsistent lock state
> Submitter : Sergey Senozhatsky <sergey.senozhatsky-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Date : 2010-06-15 11:24 (6 days old)
> Message-ID : <20100615112434.GA3967-dY8u8AhHFaWtd10JCjopabkcH5ONE+aC@public.gmane.org>
> References : http://marc.info/?l=linux-kernel&m=127660087625903&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16247
> Subject : drm/i915 BUG with 2.6.35-rc
> Submitter : Benny Halevy <bhalevy-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org>
> Date : 2010-06-14 22:38 (7 days old)
> Message-ID : <4C16AF56.1040002-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org>
> References : http://marc.info/?l=linux-kernel&m=127655510531367&w=2
Don't have time to test, but I confirm that running compiz without
mode-setting (ubuntu 8.10) hangs the system. (device is i945)
It might be related to few intel regressions on this list.
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16235
> Subject : [REGRESSION] [IWL3945] Broadcast is broken?
> Submitter : Maciej Rutecki <maciej.rutecki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Date : 2010-06-14 17:24 (7 days old)
> Message-ID : <201006141924.24061.maciej.rutecki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> References : http://marc.info/?l=linux-kernel&m=127653628301300&w=2
I was hit by this bug. Fix is now present in iwlwifi tree.
http://git.kernel.org/?p=linux/kernel/git/iwlwifi/iwlwifi-2.6.git;a=commit;h=4d23e4e5eb50431426facf192354ad2506e2dd40
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16234
> Subject : [2.6.35-rc3] reboot mutex 'bug'...
> Submitter : Daniel J Blueman <daniel.blueman-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Date : 2010-06-14 15:16 (7 days old)
> Message-ID : <AANLkTimDcTnyEPmt2ZcCM1UWtn4AYKotiqyjobJApkO7-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
> References : http://marc.info/?l=linux-kernel&m=127652861118933&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16232
> Subject : 2.6.35-rc3 - WARNING:iwl_set_dynamic_key
> Submitter : Mario Guenterberg <mario.guenterberg-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
> Date : 2010-06-14 11:55 (7 days old)
> Message-ID : <20100614115510.GA7904@guenti-laptop>
> References : http://marc.info/?l=linux-kernel&m=127651695627147&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16230
> Subject : inconsistent IN-HARDIRQ-W -> HARDIRQ-ON-W usage: fasync, 2.6.35-rc3
> Submitter : Dominik Brodowski <linux-X3ehHDuj6sIIGcDfoQAp7OTW4wlIGRCZ@public.gmane.org>
> Date : 2010-06-13 9:53 (8 days old)
> Message-ID : <20100613095305.GA13231-S7uyTPAaJ/sb6pqDj42GsMgv3T4z79SOrE5yTffgRl4@public.gmane.org>
> References : http://marc.info/?l=linux-kernel&m=127642282208277&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16228
> Subject : BUG/boot failure on Dell Precision T3500 (pci/ahci_stop_engine)
> Submitter : Brian Bloniarz <phunge0-PkbjNfxxIARBDgjK7y7TUQ@public.gmane.org>
> Date : 2010-06-16 17:57 (5 days old)
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16222
> Subject : 2.6.35-rc{12} regression: inactive console corrupted
> Submitter : Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
> Date : 2010-06-12 10:33 (9 days old)
> Message-ID : <20100612103321.GA1458-+ZI9xUNit7I@public.gmane.org>
> References : http://marc.info/?l=linux-kernel&m=127633882614501&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16221
> Subject : 2.6.35-rc2-git5 -- [drm:drm_mode_getfb] *ERROR* invalid framebuffer id
> Submitter : Miles Lane <miles.lane-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Date : 2010-06-11 20:31 (10 days old)
> Message-ID : <AANLkTim0jVRyqkwlGOcrg_XTvUQwcBYfWJX-aRzkkrLG-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
> References : http://marc.info/?l=linux-kernel&m=127628828119623&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16205
> Subject : acpi: freeing invalid memtype bf799000-bf79a000
> Submitter : Marcin Slusarz <marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Date : 2010-06-09 20:09 (12 days old)
> Message-ID : <20100609200910.GA2876-OI9uyE9O0yo@public.gmane.org>
> References : http://marc.info/?l=linux-kernel&m=127611427029914&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16201
> Subject : SIOCGIWFREQ ioctl fails to get frequency info
> Submitter : nuh <nuh-hRtevi7K+EWJQ7yn63+t2w@public.gmane.org>
> Date : 2010-06-14 10:45 (7 days old)
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16199
> Subject : 2.6.35-rc2-git1 - include/linux/cgroup.h:534 invoked rcu_dereference_check() without protection!
> Submitter : Miles Lane <miles.lane-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Date : 2010-06-07 18:14 (14 days old)
> Message-ID : <AANLkTin2pPqOUx--9fIX3BH3e-cU6oCRufijcx_4ozx5-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
> References : http://marc.info/?l=linux-kernel&m=127593447812015&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16198
> Subject : Running make install over sshfs is painful now
> Submitter : Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Date : 2010-06-07 6:53 (14 days old)
> Message-ID : <20100607065324.GA25590-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
> References : http://marc.info/?l=linux-kernel&m=127589362011138&w=2
I confirm this.
Its direct result of adding '+' to kernel version.
This just causes only troubles.
I suggest to have a config option for it.
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16197
> Subject : [BUG on 2.6.35-rc2] sysfs: cannot create duplicate filename '/devices/pci0000:00/0000:00:11.0/0000:02:03.0/slot'
> Submitter : Ryan Wang <openspace.wang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Date : 2010-06-07 0:23 (14 days old)
> Message-ID : <AANLkTincwMZPnYW3S4uz4k2GOn52RpgBIBRfzyD010Yo-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
> References : http://marc.info/?l=linux-kernel&m=127587022219378&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16184
> Subject : Container, X86-64, i386, iptables rule
> Submitter : Jean-Marc Pigeon <jmp-4qkeo2rQ0gg@public.gmane.org>
> Date : 2010-06-12 04:17 (9 days old)
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16179
> Subject : 2.6.35-rc2 completely hosed on intel gfx?
> Submitter : Norbert Preining <preining-DX+603jRYB8@public.gmane.org>
> Date : 2010-06-06 11:55 (15 days old)
> Message-ID : <20100606115534.GA9399-DqSSrKF0TaySnEC3TeqHn5dqbFPxfnh/@public.gmane.org>
> References : http://marc.info/?l=linux-kernel&m=127582534931581&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16178
> Subject : 2.6.35-rc2 : OOPS with LTP memcg regression test run.
> Submitter : Sachin Sant <sachinp-xthvdsQ13ZrQT0dZR+AlfA@public.gmane.org>
> Date : 2010-06-06 15:18 (15 days old)
> Message-ID : <4C0BB98E.9030101-xthvdsQ13ZrQT0dZR+AlfA@public.gmane.org>
> References : http://marc.info/?l=linux-kernel&m=127583683912607&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16176
> Subject : Microcode errors with iwl3945
> Submitter : Steinar H. Gunderson <sgunderson-jG/AHqQBv7lBDgjK7y7TUQ@public.gmane.org>
> Date : 2010-06-10 19:28 (11 days old)
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16175
> Subject : 2.6.35-rc1 system oom, many processes killed but memory not free
> Submitter : andrew hendry <andrew.hendry-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Date : 2010-06-05 0:46 (16 days old)
> Message-ID : <AANLkTim7CiW-yfugZUAHZCqLvXKgt9CwolCvbLGdCLAk-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
> References : http://marc.info/?l=linux-kernel&m=127569877714937&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16173
> Subject : After uncompressing the kernel, at boot time, the server hangs.
> Submitter : David Hill <hilld-HTiBYHdybX7UkGsOFmftXw@public.gmane.org>
> Date : 2010-06-09 23:25 (12 days old)
> First-Bad-Commit: http://git.kernel.org/linus/cf7500c0ea133d66f8449d86392d83f840102632
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16172
> Subject : 2.6.25-rc1 ahci regression
> Submitter : Luming Yu <luming.yu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Date : 2010-06-03 7:02 (18 days old)
> First-Bad-Commit: http://git.kernel.org/linus/365cfa1ed5a36f9bcb9f64c9f0f52155af2e9fef
> Message-ID : <AANLkTikWak8i-Kaj-e-EUFWE66tfMmp2UPhGJCKkK1zK-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>>
> References : http://marc.info/?l=linux-kernel&m=127554855724361&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16160
> Subject : 2.6.35 Radeon KMS power management regression?
> Submitter : Nigel Cunningham <ncunningham-VWkGxi2CTS+6c6uEtOJ/EA@public.gmane.org>
> Date : 2010-06-01 6:23 (20 days old)
> Message-ID : <4C04A767.8000209-VWkGxi2CTS+6c6uEtOJ/EA@public.gmane.org>
> References : http://marc.info/?l=linux-kernel&m=127537343722290&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16145
> Subject : Unable to boot unless "notsc" or "clocksource=hpet", or acpi_pad disabling the TSC
> Submitter : Tom Gundersen <teg-B22kvLQNl6c@public.gmane.org>
> Date : 2010-06-07 13:11 (14 days old)
> Handled-By : Venkatesh Pallipadi <venki-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
> Len Brown <lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16122
> Subject : 2.6.35-rc1: WARNING at fs/fs-writeback.c:1142 __mark_inode_dirty+0x103/0x170
> Submitter : Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
> Date : 2010-06-04 13:18 (17 days old)
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16090
> Subject : sysfs: cannot create duplicate filename
> Submitter : Tobias <devnull-fBT1nhYaLZ4@public.gmane.org>
> Date : 2010-06-01 15:59 (20 days old)
> Handled-By : Jesse Barnes <jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org>
>
>
> Regressions with patches
> ------------------------
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16231
> Subject : Noticeable slow-down in 2.6.35-rc3
> Submitter : Chris Clayton <chris2553-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
> Date : 2010-06-13 20:15 (8 days old)
> First-Bad-Commit: http://git.kernel.org/linus/597a264b1a9c7e36d1728f677c66c5c1f7e3b837
> Message-ID : <AANLkTimDUf0N6b5PBy2wTGeAWEIY-lUvQPHQ7D7Gyrq4-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
> References : http://marc.info/?l=linux-kernel&m=127646015226601&w=2
> Handled-By : John Fastabend <john.r.fastabend-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Patch : https://patchwork.kernel.org/patch/105859/
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16220
> Subject : md/raid/udev fails to create md partition devices (/dev/mdXpY)
> Submitter : Duncan <1i5t5.duncan-j9pdmedNgrk@public.gmane.org>
> Date : 2010-06-15 17:19 (6 days old)
> Handled-By : Neil Brown <neilb-l3A5Bk7waGM@public.gmane.org>
> Patch : https://bugzilla.kernel.org/show_bug.cgi?id=16220#c2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16215
> Subject : sysfs: cannot create duplicate filename '/class/net/bnep0'
> Submitter : Janusz Krzysztofik <jkrzyszt-NCk8gXQAEuFz6jiHbVrK7g@public.gmane.org>
> Date : 2010-06-15 14:55 (6 days old)
> Handled-By : Eric W. Biederman <ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
> Patch : https://bugzilla.kernel.org/show_bug.cgi?id=16215#c10
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16196
> Subject : 2.6.35-rc2-git1 - WARNING: at net/wireless/mlme.c:341 cfg80211_send_assoc_timeout+0x107/0x11e [cfg80211]()
> Submitter : Miles Lane <miles.lane-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Date : 2010-06-07 19:06 (14 days old)
> Message-ID : <AANLkTinmZh9GnrZLzOGi5Q_xHbky8cKdHAkOnsIA6_dZ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
> References : http://marc.info/?l=linux-kernel&m=127593758817428&w=2
> Handled-By : Johannes Berg <johannes.berg-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Patch : http://marc.info/?l=linux-wireless&m=127608099427316&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16180
> Subject : radeon regression with 2.6.35-rc2-00001-g386f40c: black screen after resume
> Submitter : cedric <cedric-x1Cn44Nr1HaZIoH1IeqzKA@public.gmane.org>
> Date : 2010-06-11 10:59 (10 days old)
> Handled-By : Cedric Godin <cedric.godin-AgBVmzD5pcezQB+pC5nmwQ@public.gmane.org>
> Patch : https://bugzilla.kernel.org/attachment.cgi?id=26733
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16169
> Subject : Complain from preemptive debug
> Submitter : Sedat Dilek <sedat.dilek-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
> Date : 2010-05-31 10:10 (21 days old)
> Message-ID : <AANLkTilTnAAZIizKinYsxFkNTkrmPqk6XJJuUjjhJ7EP-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
> References : http://lkml.org/lkml/2010/5/31/77
> Handled-By : Dmitry Monakhov <dmonakhov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
> Patch : http://www.spinics.net/lists/cpufreq/msg01631.html
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16156
> Subject : No Sound with 2.6.34.x Kernel with my Audio-Chip
> Submitter : Ch: Hanisch <ch-hanisch-zqRNUXuvxA0b1SvskN2V4Q@public.gmane.org>
> Date : 2010-06-08 11:51 (13 days old)
> Handled-By : Takashi Iwai <tiwai-l3A5Bk7waGM@public.gmane.org>
> Patch : https://bugzilla.kernel.org/attachment.cgi?id=26724
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16131
> Subject : kernel BUG at fs/btrfs/extent-tree.c:4363 (btrfs_free_tree_block)
> Submitter : Chow Loong Jin <hyperair-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
> Date : 2010-06-05 18:53 (16 days old)
> Handled-By : Yan Zheng <zheng.yan-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> Patch : https://patchwork.kernel.org/patch/103235/
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16127
> Subject : Boot freeze on HP Compaq nx6325 (RS482) with Radeon KMS
> Submitter : Jure Repinc <jlp.bugs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Date : 2010-06-04 21:14 (17 days old)
> Handled-By : Dave Airlie <airlied-cv59FeDIM0c@public.gmane.org>
> Patch : https://bugzilla.kernel.org/attachment.cgi?id=26677
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16120
> Subject : Oops: 0000 [#1] SMP, unable to handle kernel NULL pointer dereference at (null)
> Submitter : Alex Zhavnerchik <alex.vizor-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Date : 2010-06-04 09:25 (17 days old)
> Handled-By : Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Patch : https://bugzilla.kernel.org/show_bug.cgi?id=16120#c6
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16092
> Subject : Caught 64-bit read from uninitialized memory in memtype_rb_augment_cb
> Submitter : Christian Casteyde <casteyde.christian-GANU6spQydw@public.gmane.org>
> Date : 2010-06-01 18:08 (20 days old)
> Handled-By : Venki <venki-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
> Patch : https://bugzilla.kernel.org/show_bug.cgi?id=16092#c2
>
>
> For details, please visit the bug entries and follow the links given in
> references.
>
> As you can see, there is a Bugzilla entry for each of the listed regressions.
> There also is a Bugzilla entry used for tracking the regressions from 2.6.34,
> unresolved as well as resolved, at:
>
> http://bugzilla.kernel.org/show_bug.cgi?id=16055
>
> Please let the tracking team know if there are any Bugzilla entries that
> should be added to the list in there.
>
> Thanks!
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH] net: optimize Berkeley Packet Filter (BPF) processing
From: Hagen Paul Pfeifer @ 2010-06-20 21:57 UTC (permalink / raw)
To: David Miller; +Cc: shemminger, netdev, Linus Torvalds
In-Reply-To: <20100620.150928.245399526.davem@davemloft.net>
* David Miller | 2010-06-20 15:09:28 [-0700]:
>I think from this perspective, the change is fine too, nothing visible
>to the user is being changed here.
Fine! I have a fundamental question: can we start to use a C language
extension, known as "Labels as Values" in the kernel? I checked this and at
least gcc, llvm and icc support this extension (btw: c1x[1] don't mention
this):
static int sk_run_filter(struct sock_filter *filter) {
static const void *codetable[] =
{ &&BPF_S_RET_K, &&BPF_S_ALU_ADD_X, &&BPF_S_ALU_SUB_X, &&BPF_S_ALU_MUL_X };
int pc = 0;
goto *codetable[*(filter[pc++].code)];
BPF_S_RET_K:
return k;
BPF_S_ALU_ADD_X:
A += X;
goto *codetable[*(filter[pc++].code)];
BPF_S_ALU_SUB_X:
A -= X;
goto *codetable[*(filter[pc++].code)];
BPF_S_ALU_MUL_X:
A *= X
goto *codetable[*(filter[pc++].code)];
}
At least for gcc and llvm the results are quite impressive: http://llvm.org/bugs/show_bug.cgi?id=3120
arch/m68k/amiga/config.c:amiga_reset() seems to be the only user in the kernel
who use this extension (and nobody complains? ;-)
Cheers, Hagen
[1] http://www.open-std.org/jtc1/sc22/wg14/www/docs/n1425.pdf
--
Hagen Paul Pfeifer <hagen@jauu.net> || http://blog.jauu.net/
Telephone: +49 174 5455209 || Key Id: 0x98350C22
Key Fingerprint: 490F 557B 6C48 6D7E 5706 2EA2 4A22 8D45 9835 0C22
^ permalink raw reply
* 2.6.35-rc3: Reported regressions 2.6.33 -> 2.6.34
From: Rafael J. Wysocki @ 2010-06-20 22:32 UTC (permalink / raw)
To: Linux Kernel Mailing List
Cc: Maciej Rutecki, Andrew Morton, Linus Torvalds,
Kernel Testers List, Network Development, Linux ACPI,
Linux PM List, Linux SCSI List, Linux Wireless List, DRI
This message contains a list of some post-2.6.33 regressions introduced before
2.6.34, for which there are no fixes in the mainline known to the tracking team.
If any of them have been fixed already, please let us know.
If you know of any other unresolved post-2.6.33 regressions, please let us know
either and we'll add them to the list. Also, please let us know if any
of the entries below are invalid.
Each entry from the list will be sent additionally in an automatic reply to
this message with CCs to the people involved in reporting and handling the
issue.
Listed regressions statistics:
Date Total Pending Unresolved
----------------------------------------
2010-06-21 114 36 28
2010-06-13 111 40 34
2010-05-09 80 27 24
2010-05-04 76 26 22
2010-04-20 64 35 34
2010-04-07 48 35 33
2010-03-21 15 13 10
Unresolved regressions
----------------------
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16254
Subject : TCP stream performance regression due to c377411f2494a931ff7facdbb3a6839b1266bcf6
Submitter : Alex,Shi <alex.shi@intel.com>
Date : 2010-06-18 7:17 (3 days old)
First-Bad-Commit: http://git.kernel.org/linus/c377411f2494a931ff7facdbb3a6839b1266bcf6
Message-ID : <1276845448.2118.346.camel@debian>
References : http://marc.info/?l=linux-kernel&m=127684931020672&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16233
Subject : Fwd: [2.6.34] INFO: task rsync:20019 blocked for more than 120 seconds.
Submitter : Jan De Luyck <mailinglists+linuxkernel_20080830@kcore.org>
Date : 2010-06-14 19:49 (7 days old)
Message-ID : <AANLkTimutyh3WIALv3NIxA8Xt5JtU6tp4EWOnuSqhdyD@mail.gmail.com>
References : http://marc.info/?l=linux-kernel&m=127654498016377&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16207
Subject : Suspend hangs since 2.6.34
Submitter : Tino Keitel <tino.keitel+xorg@tikei.de>
Date : 2010-06-09 17:53 (12 days old)
Message-ID : <20100609175356.GA17332@x61.home>
References : http://marc.info/?l=linux-kernel&m=127610606214060&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16206
Subject : PROBLEM: PPP and other serial port related application hangs in kernel space
Submitter : Ales Teska <ales.teska@gmail.com>
Date : 2010-06-09 20:46 (12 days old)
Message-ID : <900E3B14-5B92-4A37-9581-049DB40F4D1C@gmail.com>
References : http://marc.info/?l=linux-kernel&m=127611640301071&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16170
Subject : Leadtek Winfast DTV Dongle (STK7700P based) is not working in 2.6.34
Submitter : <macjariel@gmail.com>
Date : 2010-06-09 11:11 (12 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16162
Subject : SSD + sata_nv + btrfs oops
Submitter : Dave Airlie <airlied@gmail.com>
Date : 2010-06-01 3:04 (20 days old)
Message-ID : <AANLkTilqsIdlzZgUf7TMLHYKqHDZoVkcs42vcG8wXKEr@mail.gmail.com>
References : http://marc.info/?l=linux-kernel&m=127536149022333&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16158
Subject : winxp guest hangs after idle for ~30 minutes
Submitter : <brimhall@pobox.com>
Date : 2010-06-08 17:52 (13 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16139
Subject : wait_even_interruptible_timeout(), signal, spin_lock() = system hang
Submitter : Shirish Pargaonkar <shirishpargaonkar@gmail.com>
Date : 2010-05-28 16:44 (24 days old)
Message-ID : <AANLkTiliRFydAhxH2-Dp1RKuz6sq7vgWIcMvLMi68ftg@mail.gmail.com>
References : http://marc.info/?l=linux-kernel&m=127506510328758&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16137
Subject : Ooops in BTRFS in 2.6.34 / x86_64 when mounting subvolume by name
Submitter : armin walland <a.walland@focusmr.com>
Date : 2010-05-27 12:27 (25 days old)
Message-ID : <201005271428.01239.a.walland@focusmr.com>
References : http://marc.info/?l=linux-kernel&m=127496434110736&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16135
Subject : [BUG] kacpi_notify goes into an infinite loop (luckly it calls cond_resched)
Submitter : Steven Rostedt <rostedt@goodmis.org>
Date : 2010-05-29 1:01 (23 days old)
First-Bad-Commit: http://git.kernel.org/linus/fa80945269f312bc609e8384302f58b03c916e12
Message-ID : <1275094882.22648.607.camel@gandalf.stny.rr.com>
References : http://marc.info/?l=linux-kernel&m=127509490405845&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16111
Subject : hostap_pci: infinite registered netdevice wifi0
Submitter : Petr Pisar <petr.pisar@atlas.cz>
Date : 2010-06-02 20:55 (19 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16097
Subject : 2.6.34 on Samsung P460: reset after "Waiting for /dev to be fully populated"
Submitter : Harald Dunkel <harald.dunkel@aixigo.de>
Date : 2010-05-25 9:12 (27 days old)
Message-ID : <4BFB947E.9080509@aixigo.de>
References : http://marc.info/?l=linux-kernel&m=127477877432254&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16084
Subject : iwl3945 bug in 2.6.34
Submitter : Satish Eerpini <eerpini@gmail.com>
Date : 2010-05-23 6:37 (29 days old)
Message-ID : <AANLkTik_7rxDBc0TKlAfoYyM5S6Cf_Hyxbr4W5ORnTsq@mail.gmail.com>
References : http://marc.info/?l=linux-kernel&m=127459596015626&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16082
Subject : host panic on kernel 2.6.34
Submitter : Hao, Xudong <xudong.hao@intel.com>
Date : 2010-05-24 8:23 (28 days old)
Message-ID : <BC00F5384FCFC9499AF06F92E8B78A9E04DCCCE242@shsmsx502.ccr.corp.intel.com>
References : http://marc.info/?l=linux-kernel&m=127468951208864&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16050
Subject : The ibmcam driver is not working
Submitter : Bill Davidsen <davidsen@tmr.com>
Date : 2010-05-25 23:02 (27 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16035
Subject : Incorrect initial resolution of (external) vga monitor with KMS
Submitter : <andreas.eckstein@gmx.net>
Date : 2010-05-23 12:28 (29 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16034
Subject : 2.6.34: dlm: possible circular locking dependency detected
Submitter : CaT <cat@zip.com.au>
Date : 2010-05-21 6:59 (31 days old)
Message-ID : <20100521065933.GH2657@zip.com.au>
References : http://marc.info/?l=linux-kernel&m=127442519608471&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15977
Subject : WARNING: at lib/dma-debug.c:866 check_for_stack
Submitter : Zdenek Kabelac <zdenek.kabelac@gmail.com>
Date : 2010-05-14 8:56 (38 days old)
Message-ID : <AANLkTikyx2eaxaiUCFDSfpmn1UG0t2GOxArz6F4wp1LJ@mail.gmail.com>
References : http://marc.info/?l=linux-kernel&m=127382742729825&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15936
Subject : Suspicious rcu_dereference_check() usage detected during 2.6.34-rc6 boot on PPC64/p5 processor
Submitter : Subrata Modak <subrata@linux.vnet.ibm.com>
Date : 2010-05-06 7:29 (46 days old)
Message-ID : <1273130279.4898.5.camel@subratamodak.linux.ibm.com>
References : http://marc.info/?l=linux-kernel&m=127313031922395&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15924
Subject : kacpid consumes ~100% CPU, system freezes randomly
Submitter : Jaroslav Kameník <jaroslav@kamenik.cz>
Date : 2010-05-06 21:12 (46 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15862
Subject : 2.6.34-rc4/5: iwlagn unusable until reload
Submitter : Nico Schottelius <nico-linux-20100427@schottelius.org>
Date : 2010-04-27 7:49 (55 days old)
Message-ID : <20100427074934.GB3261@ikn.schottelius.org>
References : http://marc.info/?l=linux-kernel&m=127235784004839&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15805
Subject : reiserfs locking
Submitter : Alexander Beregalov <a.beregalov@gmail.com>
Date : 2010-04-15 21:02 (67 days old)
Message-ID : <t2ka4423d671004151402n7b2dc425mdc9c6bb9640d63fb@mail.gmail.com>
References : http://marc.info/?l=linux-kernel&m=127136535323933&w=2
Handled-By : Frederic Weisbecker <fweisbec@gmail.com>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15717
Subject : bluetooth oops
Submitter : Pavel Machek <pavel@ucw.cz>
Date : 2010-03-14 20:14 (99 days old)
Message-ID : <20100314201434.GE22059@elf.ucw.cz>
References : http://marc.info/?l=linux-kernel&m=126859771528426&w=4
Handled-By : Marcel Holtmann <marcel@holtmann.org>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15704
Subject : [r8169] WARNING: at net/sched/sch_generic.c
Submitter : Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Date : 2010-03-31 10:21 (82 days old)
Message-ID : <20100331102142.GA3294@swordfish.minsk.epam.com>
References : http://marc.info/?l=linux-kernel&m=127003090406108&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15673
Subject : 2.6.34-rc2: "ima_dec_counts: open/free imbalance"?
Submitter : Thomas Meyer <thomas@m3y3r.de>
Date : 2010-03-28 11:31 (85 days old)
Message-ID : <1269775909.5301.4.camel@localhost.localdomain>
References : http://marc.info/?l=linux-kernel&m=126977593326800&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15671
Subject : intel graphic card hanging (Hangcheck timer elapsed... GPU hung)
Submitter : Norbert Preining <preining@logic.at>
Date : 2010-03-27 16:11 (86 days old)
Message-ID : <20100327161104.GA12043@gamma.logic.tuwien.ac.at>
References : http://marc.info/?l=linux-kernel&m=126970883105262&w=2
Handled-By : Jesse Barnes <jbarnes@virtuousgeek.org>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15669
Subject : INFO: suspicious rcu_dereference_check()
Submitter : Zdenek Kabelac <zdenek.kabelac@gmail.com>
Date : 2010-03-08 1:26 (105 days old)
Message-ID : <c4e36d111003250348q678eb2e6w4f3e8133e7fd6e58@mail.gmail.com>
References : http://marc.info/?l=linux-kernel&m=126801163107713&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15664
Subject : Graphics hang and kernel backtrace when starting Azureus with Compiz enabled
Submitter : Alex Villacis Lasso <avillaci@ceibo.fiec.espol.edu.ec>
Date : 2010-04-01 01:09 (81 days old)
Regressions with patches
------------------------
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16147
Subject : ksoftirq hogs the CPU
Submitter : Thomas Jarosch <thomas.jarosch@intra2net.com>
Date : 2010-06-07 15:17 (14 days old)
First-Bad-Commit: http://git.kernel.org/linus/ae74e823cb7d4cd476f623fce9a38f625f6c09a8
Handled-By : Martin Wilck <martin.wilck@ts.fujitsu.com>
Patch : https://bugzilla.kernel.org/attachment.cgi?id=26732
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16138
Subject : PCMCIA regression
Submitter : Mikulas Patocka <mpatocka@redhat.com>
Date : 2010-05-25 20:25 (27 days old)
Message-ID : <Pine.LNX.4.64.1005251619020.12278@hs20-bc2-1.build.redhat.com>
References : http://marc.info/?l=linux-kernel&m=127481913909672&w=2
Handled-By : Dominik Brodowski <linux@brodo.de>
Patch : https://bugzilla.kernel.org/attachment.cgi?id=26685
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16054
Subject : UML broken for CONFIG_SLAB
Submitter : Parag Warudkar <parag.lkml@gmail.com>
Date : 2010-05-23 21:40 (29 days old)
Message-ID : <alpine.DEB.2.00.1005231149100.605@parag-laptop>
References : http://marc.info/?l=linux-kernel&m=127465083806617&w=2
Handled-By : Borislav Petkov <bp@alien8.de>
Patch : http://git.kernel.org/tip/055c47272b8f5679d08ccc57efea3cb4aaeb5fc6
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16040
Subject : kacpid consumes ~40% of cpu all the time beginning with 2.6.34
Submitter : Mehmet Giritli <mehmet@giritli.eu>
Date : 2010-05-24 07:32 (28 days old)
Patch : https://patchwork.kernel.org/patch/104903/
https://patchwork.kernel.org/patch/104912/
https://patchwork.kernel.org/patch/104909/
https://patchwork.kernel.org/patch/104911/
https://patchwork.kernel.org/patch/104910/
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16007
Subject : x86/pci Oops with CONFIG_SND_HDA_INTEL
Submitter : Graham Ramsey <ramsey.graham@ntlworld.com>
Date : 2010-05-19 17:09 (33 days old)
Handled-By : Yinghai Lu <yinghai@kernel.org>
Patch : https://patchwork.kernel.org/patch/105662/
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15951
Subject : commit 9630bdd9 changes behavior of the poweroff
Submitter : Michal Hocko <mhocko@suse.cz>
Date : 2010-04-01 13:39 (81 days old)
First-Bad-Commit: http://git.kernel.org/linus/9630bdd9b15d2f489c646d8bc04b60e53eb5ec78
Message-ID : <20100401133923.GA4104@tiehlicka.suse.cz>
References : http://marc.info/?l=linux-kernel&m=127012918316305&w=4
Handled-By : Rafael J. Wysocki <rjw@sisk.pl>
Patch : https://patchwork.kernel.org/patch/106701/
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15863
Subject : 2.6.34-rc5-git7 (plus all patches) -- another suspicious rcu_dereference_check() usage.
Submitter : Miles Lane <miles.lane@gmail.com>
Date : 2010-04-27 0:51 (55 days old)
Message-ID : <h2ya44ae5cd1004261751waa5cb65ei3d139cbcfa2cc5cf@mail.gmail.com>
References : http://marc.info/?l=linux-kernel&m=127232949104878&w=2
Handled-By : Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Patch : https://patchwork.kernel.org/patch/96096/
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15589
Subject : 2.6.34-rc1: Badness at fs/proc/generic.c:316
Submitter : Christian Kujau <lists@nerdbynature.de>
Date : 2010-03-13 23:53 (100 days old)
Message-ID : < <AANLkTikNcCtUn9SQwKu2b3IE6NiAwAhciHsm1HVH4EJh@mail.gmail.com>>
References : http://marc.info/?l=linux-kernel&m=126852442903680&w=2
Handled-By : Michael Ellerman <michael@ellerman.id.au>
Jindřich Makovička <makovick@gmail.com>
Patch : http://patchwork.ozlabs.org/patch/52978/
http://lkml.indiana.edu/hypermail/linux/kernel/1006.0/00137.html
For details, please visit the bug entries and follow the links given in
references.
As you can see, there is a Bugzilla entry for each of the listed regressions.
There also is a Bugzilla entry used for tracking the regressions introduced
between 2.6.33 and 2.6.34, unresolved as well as resolved, at:
http://bugzilla.kernel.org/show_bug.cgi?id=15310
Please let the tracking teak know if there are any Bugzilla entries that
should be added to the list in there.
Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* 2.6.35-rc3: Reported regressions from 2.6.34
From: Rafael J. Wysocki @ 2010-06-20 22:11 UTC (permalink / raw)
To: Linux Kernel Mailing List
Cc: Maciej Rutecki, Andrew Morton, Linus Torvalds,
Kernel Testers List, Network Development, Linux ACPI,
Linux PM List, Linux SCSI List, Linux Wireless List, DRI
This message contains a list of some regressions from 2.6.34,
for which there are no fixes in the mainline known to the tracking team.
If any of them have been fixed already, please let us know.
If you know of any other unresolved regressions from 2.6.34, please let us
know either and we'll add them to the list. Also, please let us know
if any of the entries below are invalid.
Each entry from the list will be sent additionally in an automatic reply
to this message with CCs to the people involved in reporting and handling
the issue.
Listed regressions statistics:
Date Total Pending Unresolved
----------------------------------------
2010-06-21 46 37 26
2010-06-09 15 13 10
Unresolved regressions
----------------------
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16255
Subject : 2.6.35-rc3 deadlocks on semaphore operations
Submitter : Christoph Lameter <cl-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Date : 2010-06-18 14:49 (3 days old)
Message-ID : <alpine.DEB.2.00.1006180940140.11575-sBS69tsa9Uj/9pzu0YdTqQ@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=127687262727707&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16248
Subject : inconsistent lock state
Submitter : Sergey Senozhatsky <sergey.senozhatsky-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-06-15 11:24 (6 days old)
Message-ID : <20100615112434.GA3967-dY8u8AhHFaWtd10JCjopabkcH5ONE+aC@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=127660087625903&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16247
Subject : drm/i915 BUG with 2.6.35-rc
Submitter : Benny Halevy <bhalevy-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org>
Date : 2010-06-14 22:38 (7 days old)
Message-ID : <4C16AF56.1040002-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=127655510531367&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16235
Subject : [REGRESSION] [IWL3945] Broadcast is broken?
Submitter : Maciej Rutecki <maciej.rutecki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-06-14 17:24 (7 days old)
Message-ID : <201006141924.24061.maciej.rutecki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=127653628301300&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16234
Subject : [2.6.35-rc3] reboot mutex 'bug'...
Submitter : Daniel J Blueman <daniel.blueman-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-06-14 15:16 (7 days old)
Message-ID : <AANLkTimDcTnyEPmt2ZcCM1UWtn4AYKotiqyjobJApkO7-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=127652861118933&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16232
Subject : 2.6.35-rc3 - WARNING:iwl_set_dynamic_key
Submitter : Mario Guenterberg <mario.guenterberg-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
Date : 2010-06-14 11:55 (7 days old)
Message-ID : <20100614115510.GA7904@guenti-laptop>
References : http://marc.info/?l=linux-kernel&m=127651695627147&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16230
Subject : inconsistent IN-HARDIRQ-W -> HARDIRQ-ON-W usage: fasync, 2.6.35-rc3
Submitter : Dominik Brodowski <linux-X3ehHDuj6sIIGcDfoQAp7OTW4wlIGRCZ@public.gmane.org>
Date : 2010-06-13 9:53 (8 days old)
Message-ID : <20100613095305.GA13231-S7uyTPAaJ/sb6pqDj42GsMgv3T4z79SOrE5yTffgRl4@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=127642282208277&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16228
Subject : BUG/boot failure on Dell Precision T3500 (pci/ahci_stop_engine)
Submitter : Brian Bloniarz <phunge0-PkbjNfxxIARBDgjK7y7TUQ@public.gmane.org>
Date : 2010-06-16 17:57 (5 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16222
Subject : 2.6.35-rc{12} regression: inactive console corrupted
Submitter : Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
Date : 2010-06-12 10:33 (9 days old)
Message-ID : <20100612103321.GA1458-+ZI9xUNit7I@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=127633882614501&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16221
Subject : 2.6.35-rc2-git5 -- [drm:drm_mode_getfb] *ERROR* invalid framebuffer id
Submitter : Miles Lane <miles.lane-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-06-11 20:31 (10 days old)
Message-ID : <AANLkTim0jVRyqkwlGOcrg_XTvUQwcBYfWJX-aRzkkrLG-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=127628828119623&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16205
Subject : acpi: freeing invalid memtype bf799000-bf79a000
Submitter : Marcin Slusarz <marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-06-09 20:09 (12 days old)
Message-ID : <20100609200910.GA2876-OI9uyE9O0yo@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=127611427029914&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16201
Subject : SIOCGIWFREQ ioctl fails to get frequency info
Submitter : nuh <nuh-hRtevi7K+EWJQ7yn63+t2w@public.gmane.org>
Date : 2010-06-14 10:45 (7 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16199
Subject : 2.6.35-rc2-git1 - include/linux/cgroup.h:534 invoked rcu_dereference_check() without protection!
Submitter : Miles Lane <miles.lane-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-06-07 18:14 (14 days old)
Message-ID : <AANLkTin2pPqOUx--9fIX3BH3e-cU6oCRufijcx_4ozx5-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=127593447812015&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16198
Subject : Running make install over sshfs is painful now
Submitter : Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-06-07 6:53 (14 days old)
Message-ID : <20100607065324.GA25590-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=127589362011138&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16197
Subject : [BUG on 2.6.35-rc2] sysfs: cannot create duplicate filename '/devices/pci0000:00/0000:00:11.0/0000:02:03.0/slot'
Submitter : Ryan Wang <openspace.wang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-06-07 0:23 (14 days old)
Message-ID : <AANLkTincwMZPnYW3S4uz4k2GOn52RpgBIBRfzyD010Yo-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=127587022219378&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16184
Subject : Container, X86-64, i386, iptables rule
Submitter : Jean-Marc Pigeon <jmp-4qkeo2rQ0gg@public.gmane.org>
Date : 2010-06-12 04:17 (9 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16179
Subject : 2.6.35-rc2 completely hosed on intel gfx?
Submitter : Norbert Preining <preining-DX+603jRYB8@public.gmane.org>
Date : 2010-06-06 11:55 (15 days old)
Message-ID : <20100606115534.GA9399-DqSSrKF0TaySnEC3TeqHn5dqbFPxfnh/@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=127582534931581&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16178
Subject : 2.6.35-rc2 : OOPS with LTP memcg regression test run.
Submitter : Sachin Sant <sachinp-xthvdsQ13ZrQT0dZR+AlfA@public.gmane.org>
Date : 2010-06-06 15:18 (15 days old)
Message-ID : <4C0BB98E.9030101-xthvdsQ13ZrQT0dZR+AlfA@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=127583683912607&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16176
Subject : Microcode errors with iwl3945
Submitter : Steinar H. Gunderson <sgunderson-jG/AHqQBv7lBDgjK7y7TUQ@public.gmane.org>
Date : 2010-06-10 19:28 (11 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16175
Subject : 2.6.35-rc1 system oom, many processes killed but memory not free
Submitter : andrew hendry <andrew.hendry-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-06-05 0:46 (16 days old)
Message-ID : <AANLkTim7CiW-yfugZUAHZCqLvXKgt9CwolCvbLGdCLAk-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=127569877714937&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16173
Subject : After uncompressing the kernel, at boot time, the server hangs.
Submitter : David Hill <hilld-HTiBYHdybX7UkGsOFmftXw@public.gmane.org>
Date : 2010-06-09 23:25 (12 days old)
First-Bad-Commit: http://git.kernel.org/linus/cf7500c0ea133d66f8449d86392d83f840102632
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16172
Subject : 2.6.25-rc1 ahci regression
Submitter : Luming Yu <luming.yu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-06-03 7:02 (18 days old)
First-Bad-Commit: http://git.kernel.org/linus/365cfa1ed5a36f9bcb9f64c9f0f52155af2e9fef
Message-ID : <AANLkTikWak8i-Kaj-e-EUFWE66tfMmp2UPhGJCKkK1zK-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>>
References : http://marc.info/?l=linux-kernel&m=127554855724361&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16160
Subject : 2.6.35 Radeon KMS power management regression?
Submitter : Nigel Cunningham <ncunningham-VWkGxi2CTS+6c6uEtOJ/EA@public.gmane.org>
Date : 2010-06-01 6:23 (20 days old)
Message-ID : <4C04A767.8000209-VWkGxi2CTS+6c6uEtOJ/EA@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=127537343722290&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16145
Subject : Unable to boot unless "notsc" or "clocksource=hpet", or acpi_pad disabling the TSC
Submitter : Tom Gundersen <teg-B22kvLQNl6c@public.gmane.org>
Date : 2010-06-07 13:11 (14 days old)
Handled-By : Venkatesh Pallipadi <venki-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Len Brown <lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16122
Subject : 2.6.35-rc1: WARNING at fs/fs-writeback.c:1142 __mark_inode_dirty+0x103/0x170
Submitter : Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
Date : 2010-06-04 13:18 (17 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16090
Subject : sysfs: cannot create duplicate filename
Submitter : Tobias <devnull-fBT1nhYaLZ4@public.gmane.org>
Date : 2010-06-01 15:59 (20 days old)
Handled-By : Jesse Barnes <jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org>
Regressions with patches
------------------------
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16231
Subject : Noticeable slow-down in 2.6.35-rc3
Submitter : Chris Clayton <chris2553-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
Date : 2010-06-13 20:15 (8 days old)
First-Bad-Commit: http://git.kernel.org/linus/597a264b1a9c7e36d1728f677c66c5c1f7e3b837
Message-ID : <AANLkTimDUf0N6b5PBy2wTGeAWEIY-lUvQPHQ7D7Gyrq4-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=127646015226601&w=2
Handled-By : John Fastabend <john.r.fastabend-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Patch : https://patchwork.kernel.org/patch/105859/
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16220
Subject : md/raid/udev fails to create md partition devices (/dev/mdXpY)
Submitter : Duncan <1i5t5.duncan-j9pdmedNgrk@public.gmane.org>
Date : 2010-06-15 17:19 (6 days old)
Handled-By : Neil Brown <neilb-l3A5Bk7waGM@public.gmane.org>
Patch : https://bugzilla.kernel.org/show_bug.cgi?id=16220#c2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16215
Subject : sysfs: cannot create duplicate filename '/class/net/bnep0'
Submitter : Janusz Krzysztofik <jkrzyszt-NCk8gXQAEuFz6jiHbVrK7g@public.gmane.org>
Date : 2010-06-15 14:55 (6 days old)
Handled-By : Eric W. Biederman <ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
Patch : https://bugzilla.kernel.org/show_bug.cgi?id=16215#c10
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16196
Subject : 2.6.35-rc2-git1 - WARNING: at net/wireless/mlme.c:341 cfg80211_send_assoc_timeout+0x107/0x11e [cfg80211]()
Submitter : Miles Lane <miles.lane-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-06-07 19:06 (14 days old)
Message-ID : <AANLkTinmZh9GnrZLzOGi5Q_xHbky8cKdHAkOnsIA6_dZ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=127593758817428&w=2
Handled-By : Johannes Berg <johannes.berg-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Patch : http://marc.info/?l=linux-wireless&m=127608099427316&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16180
Subject : radeon regression with 2.6.35-rc2-00001-g386f40c: black screen after resume
Submitter : cedric <cedric-x1Cn44Nr1HaZIoH1IeqzKA@public.gmane.org>
Date : 2010-06-11 10:59 (10 days old)
Handled-By : Cedric Godin <cedric.godin-AgBVmzD5pcezQB+pC5nmwQ@public.gmane.org>
Patch : https://bugzilla.kernel.org/attachment.cgi?id=26733
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16169
Subject : Complain from preemptive debug
Submitter : Sedat Dilek <sedat.dilek-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
Date : 2010-05-31 10:10 (21 days old)
Message-ID : <AANLkTilTnAAZIizKinYsxFkNTkrmPqk6XJJuUjjhJ7EP-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
References : http://lkml.org/lkml/2010/5/31/77
Handled-By : Dmitry Monakhov <dmonakhov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
Patch : http://www.spinics.net/lists/cpufreq/msg01631.html
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16156
Subject : No Sound with 2.6.34.x Kernel with my Audio-Chip
Submitter : Ch: Hanisch <ch-hanisch-zqRNUXuvxA0b1SvskN2V4Q@public.gmane.org>
Date : 2010-06-08 11:51 (13 days old)
Handled-By : Takashi Iwai <tiwai-l3A5Bk7waGM@public.gmane.org>
Patch : https://bugzilla.kernel.org/attachment.cgi?id=26724
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16131
Subject : kernel BUG at fs/btrfs/extent-tree.c:4363 (btrfs_free_tree_block)
Submitter : Chow Loong Jin <hyperair-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
Date : 2010-06-05 18:53 (16 days old)
Handled-By : Yan Zheng <zheng.yan-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Patch : https://patchwork.kernel.org/patch/103235/
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16127
Subject : Boot freeze on HP Compaq nx6325 (RS482) with Radeon KMS
Submitter : Jure Repinc <jlp.bugs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-06-04 21:14 (17 days old)
Handled-By : Dave Airlie <airlied-cv59FeDIM0c@public.gmane.org>
Patch : https://bugzilla.kernel.org/attachment.cgi?id=26677
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16120
Subject : Oops: 0000 [#1] SMP, unable to handle kernel NULL pointer dereference at (null)
Submitter : Alex Zhavnerchik <alex.vizor-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-06-04 09:25 (17 days old)
Handled-By : Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Patch : https://bugzilla.kernel.org/show_bug.cgi?id=16120#c6
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16092
Subject : Caught 64-bit read from uninitialized memory in memtype_rb_augment_cb
Submitter : Christian Casteyde <casteyde.christian-GANU6spQydw@public.gmane.org>
Date : 2010-06-01 18:08 (20 days old)
Handled-By : Venki <venki-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Patch : https://bugzilla.kernel.org/show_bug.cgi?id=16092#c2
For details, please visit the bug entries and follow the links given in
references.
As you can see, there is a Bugzilla entry for each of the listed regressions.
There also is a Bugzilla entry used for tracking the regressions from 2.6.34,
unresolved as well as resolved, at:
http://bugzilla.kernel.org/show_bug.cgi?id=16055
Please let the tracking team know if there are any Bugzilla entries that
should be added to the list in there.
Thanks!
^ permalink raw reply
* Re: [PATCH] net: optimize Berkeley Packet Filter (BPF) processing
From: David Miller @ 2010-06-20 22:09 UTC (permalink / raw)
To: hagen; +Cc: shemminger, netdev
In-Reply-To: <20100620095019.GA32223@nuttenaction>
From: Hagen Paul Pfeifer <hagen@jauu.net>
Date: Sun, 20 Jun 2010 11:50:20 +0200
> * Stephen Hemminger | 2010-06-19 22:16:11 [-0700]:
>
>>I don't think this works because it breaks ABI compatibility for applications tha
>>use older versions.
>
> Are you sure Stephen? It is a one-to-one mapping of the ABI but maybe it was
> too late yesterday ... ;-)
I think from this perspective, the change is fine too, nothing visible
to the user is being changed here.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 1/8] e1000e: cleanup ethtool loopback setup code
From: David Miller @ 2010-06-20 21:48 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, bphilips, bruce.w.allan
In-Reply-To: <AANLkTik2Rait7ugcDt36ncwqdO-fZrr9iM8usecAyBAC@mail.gmail.com>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Sun, 20 Jun 2010 00:32:20 -0700
> I know that Bruce (and company) are actively looking into your first
> point. I would think that he would have either a response or update
> on the status come Monday/Tuesday.
>
> Regarding option 2, understood and I will work out with Bruce on when
> and who will do the work. I will be taking a look at it tomorrow
> (later today), if I am not able to come up with a patch in the near
> future. I will return to working on it by Wednesday.
Great, thanks for letting me know it's being looked at.
^ permalink raw reply
* Re: [PATCH] net: optimize Berkeley Packet Filter (BPF) processing
From: Stephen Hemminger @ 2010-06-20 18:49 UTC (permalink / raw)
To: Hagen Paul Pfeifer; +Cc: netdev, davem
In-Reply-To: <20100620095019.GA32223@nuttenaction>
On Sun, 20 Jun 2010 11:50:20 +0200
Hagen Paul Pfeifer <hagen@jauu.net> wrote:
> * Stephen Hemminger | 2010-06-19 22:16:11 [-0700]:
>
> >I don't think this works because it breaks ABI compatibility for applications tha
> >use older versions.
>
> Are you sure Stephen? It is a one-to-one mapping of the ABI but maybe it was
> too late yesterday ... ;-)
I was worried that the new (remapped codes) would overlap the ones from user
space. Maybe best to have separate structures for the userspace API and the
kernel optimized filter instructions. You could then do what ever transformations
you want there.
^ permalink raw reply
* Re: [RFC PATCH v7 01/19] Add a new structure for skb buffer from external.
From: Ben Hutchings @ 2010-06-20 15:19 UTC (permalink / raw)
To: Herbert Xu
Cc: Michael S. Tsirkin, Xin, Xiaohui, Stephen Hemminger,
netdev@vger.kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, mingo@elte.hu, davem@davemloft.net,
jdike@linux.intel.com, Rusty Russell
In-Reply-To: <20100620115926.GA31849@gondor.apana.org.au>
On Sun, 2010-06-20 at 21:59 +1000, Herbert Xu wrote:
> On Sun, Jun 20, 2010 at 02:47:19PM +0300, Michael S. Tsirkin wrote:
> >
> > Let's do this then. So far the virtio spec avoided making layout
> > assumptions, leaving guests lay out data as they see fit.
> > Isn't it possible to keep supporting this with zero copy for hardware
> > that can issue DMA at arbitrary addresses?
>
> I think you're mistaken with respect to what is being proposed.
> Raising 512 bytes isn't a hard constraint, it is merely an
> optimisation for Intel NICs because their PS mode can produce
> a head fragment of up to 512 bytes.
>
> If the guest didn't allocate 512 bytes it wouldn't be the end of
> the world, it'd just mean that we'd either copy whatever is in
> the head fragment, or we waste 4096-X bytes of memory where X
> is the number of bytes in the head.
If I understand correctly what this 'PS mode' is (I haven't seen the
documentation for it), it is a feature that Microsoft requested from
hardware vendors for use in Hyper-V. As a result, the SFC9000 family
and presumably other controllers also implement something similar.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply
* Re: Distributed Switch Architecture(DSA)
From: Joakim Tjernlund @ 2010-06-20 14:41 UTC (permalink / raw)
To: Lennert Buytenhek; +Cc: netdev
In-Reply-To: <20100619185739.GQ14513@mail.wantstofly.org>
Lennert Buytenhek <buytenh@wantstofly.org> wrote on 2010/06/19 20:57:39:
>
> On Sat, Jun 19, 2010 at 08:48:31PM +0200, Joakim Tjernlund wrote:
>
> > > > > > Not sure how one would express whether VLAN tags should be stripped
> > > > > > off or not when egressing the HW switch's physical port.
> > > > >
> > > > > If you transmit a packet onto 'lan', it will be sent to the switch chip
> > > > > with an "untagged" DSA tag. If you transmit a packet onto 'lan.123',
> > > > > it will be sent to the switch chip with a "tagged" DSA tag. See
> > > > > net/dsa/tag_dsa.c for details.
> > > >
> > > > Ah, now I get it, thanks.
> > > > However, how does this work for LAN to LAN pkgs? LAN1 and LAN2 could be
> > > > in the same VLAN but one is implicit(port) VLAN and the
> > > > other is explicit.
> > >
> > > If you tell the HW switch to forward these packets, they will never
> > > appear at the CPU interface, so the DSA tagging/untagging doesn't enter
> > > the picture.
> >
> > "tell the HW switch"? Doesn't DSA do that already?
>
> Not in its current iteration, as I've explained in previous emails.
Sorry, I didn't quite get that.
>
>
> > If not, what is the point of DSA then if it doesn't use the native
> > forwarding capabilities of the HW switch?
>
> The point is and always was to provide a framework for proper integration
> of hardware switch chips into the Linux kernel. This framework doesn't
> become useless just because it doesn't already support every single
> hardware feature at this point.
Right, sorry if I sounded a bit harsh.
So DSA currently does a very minimal config of the HW switch to get
things going.
If you want to do something more fancy one has to
add a control plane to DSA which would possibly talk
to a user space app. Is that correct?
>
>
> > > > How do I config the HW switch to do that?
> > >
> > > Tell the switch that the vlan is native on one of the ports but not on
> > > the other. It's been a while since I looked at the chip docs but there
> > > are ways of doing this.
> >
> > The current DSA impl. does not support this? There should be some
> > way to manage this within the DSA framework.
>
> Have you even tried the DSA code?
Not yet and I don't have any MV HW either :(
^ permalink raw reply
* Re: [PATCH] Driver-core: Always create class directories fixing the broken network drivers.
From: Kay Sievers @ 2010-06-20 13:37 UTC (permalink / raw)
To: Eric W. Biederman; +Cc: Johannes Berg, Greg KH, netdev
In-Reply-To: <m1hbkx6g6p.fsf@fess.ebiederm.org>
On Sun, Jun 20, 2010 at 14:29, Eric W. Biederman <ebiederm@xmission.com> wrote:
> Kay Sievers <kay.sievers@vrfy.org> writes:
>> On Sun, Jun 20, 2010 at 13:33, Johannes Berg <johannes@sipsolutions.net> wrote:
>>> On Sun, 2010-06-20 at 12:52 +0200, Kay Sievers wrote:
>>>
>>>> As mentioned earlier, It's pretty fragile to change things in this
>>>> area, and I prefer the broken network driver-core interactions to be
>>>> fixed instead - even when they are more complicated.
>>>
>>> Can you _please_ offer a proper way to fix it then?
>>
>> Sorry, I have no real experience with the issues created by the
>> assumption that network driver need to be able to get unloaded while
>> in use. That's very special, always requires a
>> compiled-into-the-kernel part of the subsystem, and makes it hard to
>> work with, as we can not use any of the usual core infrastructure to
>> solve that.
>
> So please look at https://bugzilla.kernel.org/show_bug.cgi?id=16215
>
> That simply creates and destroys the network device as things come
> and go.
I'm still not sure, any help here would be appreciated.
> I think the bnep case is much more serious because it is real hardware
> not a testing simulation, and it is the second instance of this.
>
> Calling the change broken when I can boot up and run X in that
> configuration just fine is a vast overstatement.
Oh, I seriously would love this rule - it would make my work so much
easier. But I need to make it totally clear: "Adding intermediate
directories into 'input' sysfs it absolutely broken, regardless if
your box comes up or not. :)
X is using udev, and udev aggressively hides these details and forbids
matching such details, but many other tools which read sysfs directly,
including ones using the conceptually broken 'device' symlink will for
sure break with such changes.
> Especially
> when you don't acknowledge that the device layer is broken.
Stacking devices from different classes is broken, and not a direct
problem of the core. It is just not supported. The core might just
need to refuse that in the first place, but that's a different issue.
> I will agree that insane amounts of backwards compatibility are a good
> idea. So I will cook up a version of my patch that adds a hack to the
> device layer to only apply this change to devices of class net.
>
> That should save let us postpone the architectural dreams for another
> day.
It's not a dream, it needs to be fixed where it is used. We can not
allow to stack classes.
Kay
^ permalink raw reply
* Re: [RFC PATCH v7 01/19] Add a new structure for skb buffer from external.
From: Michael S. Tsirkin @ 2010-06-20 12:48 UTC (permalink / raw)
To: Herbert Xu
Cc: Xin, Xiaohui, Stephen Hemminger, netdev@vger.kernel.org,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org, mingo@elte.hu,
davem@davemloft.net, jdike@linux.intel.com, Rusty Russell
In-Reply-To: <20100620115926.GA31849@gondor.apana.org.au>
On Sun, Jun 20, 2010 at 09:59:26PM +1000, Herbert Xu wrote:
> On Sun, Jun 20, 2010 at 02:47:19PM +0300, Michael S. Tsirkin wrote:
> >
> > Let's do this then. So far the virtio spec avoided making layout
> > assumptions, leaving guests lay out data as they see fit.
> > Isn't it possible to keep supporting this with zero copy for hardware
> > that can issue DMA at arbitrary addresses?
>
> I think you're mistaken with respect to what is being proposed.
> Raising 512 bytes isn't a hard constraint, it is merely an
> optimisation for Intel NICs because their PS mode can produce
> a head fragment of up to 512 bytes.
>
Thanks for the clarification. So what is discussed here is
the API changes that will enable this optimization?
Of couse, it makes sense to consider this to try and avoid code churn
in the future.
As a side note, I hope to see a basic zero copy implementation with
GSO/GRO that beats copy in host convincingly before work is started on
further optimizations, though.
> If the guest didn't allocate 512 bytes it wouldn't be the end of
> the world, it'd just mean that we'd either copy whatever is in
> the head fragment,
I don't know how much will copying the head cost.
> or we waste 4096-X bytes of memory where X
> is the number of bytes in the head.
This seems mostly harmless - and guest can always do a copy internally
to save memory, correct?
Note also that we lock a full page to allow DMA, anyway.
> Cheers,
> --
> Visit Openswan at http://www.openswan.org/
> Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply
* [PATCH] Driver-core: Always create network class directories in get_device_parent.
From: Eric W. Biederman @ 2010-06-20 12:46 UTC (permalink / raw)
To: Greg KH; +Cc: Johannes Berg, netdev, Kay Sievers
In-Reply-To: <AANLkTikZAKZA9mfb7RjaqNFnX8gCM3A9PTfH350botL8@mail.gmail.com>
In get_device_parent there was added check to not add a class
directory when a class device was put under another class device. The
check was put in place as a just in case measure to not break old
userspace if any existing code happened to depend on it. Devices in
the input subsystem are affected by this code path so there is a
reasonable chance that some piece of user space will break if we just
remove this kludge.
At the same time there are at least two network drivers that have
potential unnecessary namespace conflicts because class directories
have not been created for their network devices.
With the introduction of tagged sysfs directories for properly
handling network namespace support this omission in creating the class
directories went from a bad thing in terms of namespace pollution, to
actually breaking device_remove.
Currently there are two reported network device drivers that break
because the class directory was not created by the device layer. The
usb bnep driver and the mac80211_hwsim driver.
Every solution proposed changes the sysfs layout for the affected
devices, and thus has the potential to break userspace.
Since we are changing the sysfs layout anyway, and since we are now
talking about several devices all with the same problem, all caused by
the same over convservative bit of code. Let's fix the device layer
for network devices.
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---
drivers/base/core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/base/core.c b/drivers/base/core.c
index 9630fbd..ffb8443 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -673,7 +673,7 @@ static struct kobject *get_device_parent(struct device *dev,
*/
if (parent == NULL)
parent_kobj = virtual_device_parent(dev);
- else if (parent->class)
+ else if (parent->class && (strcmp(dev->class->name, "net") != 0))
return &parent->kobj;
else
parent_kobj = &parent->kobj;
--
1.6.5.2.143.g8cc62
^ permalink raw reply related
* Re: [PATCH] Driver-core: Always create class directories fixing the broken network drivers.
From: Eric W. Biederman @ 2010-06-20 12:29 UTC (permalink / raw)
To: Kay Sievers; +Cc: Johannes Berg, Greg KH, netdev
In-Reply-To: <AANLkTikZAKZA9mfb7RjaqNFnX8gCM3A9PTfH350botL8@mail.gmail.com>
Kay Sievers <kay.sievers@vrfy.org> writes:
> On Sun, Jun 20, 2010 at 13:33, Johannes Berg <johannes@sipsolutions.net> wrote:
>> On Sun, 2010-06-20 at 12:52 +0200, Kay Sievers wrote:
>>
>>> As mentioned earlier, It's pretty fragile to change things in this
>>> area, and I prefer the broken network driver-core interactions to be
>>> fixed instead - even when they are more complicated.
>>
>> Can you _please_ offer a proper way to fix it then?
>
> Sorry, I have no real experience with the issues created by the
> assumption that network driver need to be able to get unloaded while
> in use. That's very special, always requires a
> compiled-into-the-kernel part of the subsystem, and makes it hard to
> work with, as we can not use any of the usual core infrastructure to
> solve that.
So please look at https://bugzilla.kernel.org/show_bug.cgi?id=16215
That simply creates and destroys the network device as things come
and go.
I think the bnep case is much more serious because it is real hardware
not a testing simulation, and it is the second instance of this.
Calling the change broken when I can boot up and run X in that
configuration just fine is a vast overstatement. Especially
when you don't acknowledge that the device layer is broken.
I will agree that insane amounts of backwards compatibility are a good
idea. So I will cook up a version of my patch that adds a hack to the
device layer to only apply this change to devices of class net.
That should save let us postpone the architectural dreams for another
day.
Eric
^ permalink raw reply
* Re: [RFC PATCH v7 01/19] Add a new structure for skb buffer from external.
From: Herbert Xu @ 2010-06-20 11:59 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Xin, Xiaohui, Stephen Hemminger, netdev@vger.kernel.org,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org, mingo@elte.hu,
davem@davemloft.net, jdike@linux.intel.com, Rusty Russell
In-Reply-To: <20100620114719.GC5285@redhat.com>
On Sun, Jun 20, 2010 at 02:47:19PM +0300, Michael S. Tsirkin wrote:
>
> Let's do this then. So far the virtio spec avoided making layout
> assumptions, leaving guests lay out data as they see fit.
> Isn't it possible to keep supporting this with zero copy for hardware
> that can issue DMA at arbitrary addresses?
I think you're mistaken with respect to what is being proposed.
Raising 512 bytes isn't a hard constraint, it is merely an
optimisation for Intel NICs because their PS mode can produce
a head fragment of up to 512 bytes.
If the guest didn't allocate 512 bytes it wouldn't be the end of
the world, it'd just mean that we'd either copy whatever is in
the head fragment, or we waste 4096-X bytes of memory where X
is the number of bytes in the head.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply
* Re: [RFC PATCH v7 01/19] Add a new structure for skb buffer from external.
From: Michael S. Tsirkin @ 2010-06-20 11:47 UTC (permalink / raw)
To: Herbert Xu
Cc: Xin, Xiaohui, Stephen Hemminger, netdev@vger.kernel.org,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org, mingo@elte.hu,
davem@davemloft.net, jdike@linux.intel.com, Rusty Russell
In-Reply-To: <20100620113609.GA31693@gondor.apana.org.au>
On Sun, Jun 20, 2010 at 09:36:09PM +1000, Herbert Xu wrote:
> On Sun, Jun 20, 2010 at 02:11:24PM +0300, Michael S. Tsirkin wrote:
> >
> > Rather than modifying all guests, it seems much easier not to assume
> > specific buffer layout in host. Copying network header around seems a
> > small cost.
>
> Well sure we can debate the specifics of this implementation detail.
Let's do this then. So far the virtio spec avoided making layout
assumptions, leaving guests lay out data as they see fit.
Isn't it possible to keep supporting this with zero copy for hardware
that can issue DMA at arbitrary addresses?
> However, the fact that virtio_net doesn't support feature renegotiation
> on live migration is not a valid reason against this.
>
> Cheers,
--
MST
^ permalink raw reply
* Re: [PATCH] Driver-core: Always create class directories fixing the broken network drivers.
From: Kay Sievers @ 2010-06-20 11:46 UTC (permalink / raw)
To: Johannes Berg; +Cc: Eric W. Biederman, Greg KH, netdev
In-Reply-To: <1277033628.3642.1.camel@jlt3.sipsolutions.net>
On Sun, Jun 20, 2010 at 13:33, Johannes Berg <johannes@sipsolutions.net> wrote:
> On Sun, 2010-06-20 at 12:52 +0200, Kay Sievers wrote:
>
>> As mentioned earlier, It's pretty fragile to change things in this
>> area, and I prefer the broken network driver-core interactions to be
>> fixed instead - even when they are more complicated.
>
> Can you _please_ offer a proper way to fix it then?
Sorry, I have no real experience with the issues created by the
assumption that network driver need to be able to get unloaded while
in use. That's very special, always requires a
compiled-into-the-kernel part of the subsystem, and makes it hard to
work with, as we can not use any of the usual core infrastructure to
solve that.
The only real simple thing that works is splitting the module in two
modules, which isn't really something I would propose.
Maybe the wait-for in the module-exit like your recent mail suggests
works, but I did not try that. Otherwise we can solve this by changing
the net driver and by adding some needed stuff to the core to allow
in-core bus device cleanup.
The class device hierarchy should be removed for proper network
namespace support, it's nothing we properly support with the current
core code. We better don't fiddle around with stuff nobody really
knows what it breaks. Just like I ran into the 'input' stuff now,
which was a really simple case to find.
Kay
^ permalink raw reply
* Re: [RFC PATCH v7 01/19] Add a new structure for skb buffer from external.
From: Herbert Xu @ 2010-06-20 11:36 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Xin, Xiaohui, Stephen Hemminger, netdev@vger.kernel.org,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org, mingo@elte.hu,
davem@davemloft.net, jdike@linux.intel.com, Rusty Russell
In-Reply-To: <20100620111124.GB5285@redhat.com>
On Sun, Jun 20, 2010 at 02:11:24PM +0300, Michael S. Tsirkin wrote:
>
> Rather than modifying all guests, it seems much easier not to assume
> specific buffer layout in host. Copying network header around seems a
> small cost.
Well sure we can debate the specifics of this implementation detail.
However, the fact that virtio_net doesn't support feature renegotiation
on live migration is not a valid reason against this.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply
* Re: [PATCH] Driver-core: Always create class directories fixing the broken network drivers.
From: Johannes Berg @ 2010-06-20 11:33 UTC (permalink / raw)
To: Kay Sievers; +Cc: Eric W. Biederman, Greg KH, netdev
In-Reply-To: <AANLkTilVHF0dITpB3yJYaCnGPonhdl7NWnb-P12RAFTs@mail.gmail.com>
On Sun, 2010-06-20 at 12:52 +0200, Kay Sievers wrote:
> As mentioned earlier, It's pretty fragile to change things in this
> area, and I prefer the broken network driver-core interactions to be
> fixed instead - even when they are more complicated.
Can you _please_ offer a proper way to fix it then?
johannes
^ permalink raw reply
* Re: [RFC PATCH v7 01/19] Add a new structure for skb buffer from external.
From: Michael S. Tsirkin @ 2010-06-20 11:11 UTC (permalink / raw)
To: Herbert Xu
Cc: Xin, Xiaohui, Stephen Hemminger, netdev@vger.kernel.org,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org, mingo@elte.hu,
davem@davemloft.net, jdike@linux.intel.com, Rusty Russell
In-Reply-To: <20100620110254.GA31484@gondor.apana.org.au>
On Sun, Jun 20, 2010 at 09:02:54PM +1000, Herbert Xu wrote:
> On Sun, Jun 20, 2010 at 01:39:09PM +0300, Michael S. Tsirkin wrote:
> >
> > > It's just like migrating from a backend that supports TSO
> > > to one that doesn't.
> >
> > Exactly. We don't support such migration.
>
> Well that's something that has to be addressed in the virtio_net.
Rather than modifying all guests, it seems much easier not to assume
specific buffer layout in host. Copying network header around seems a
small cost.
> Cheers,
> --
> Visit Openswan at http://www.openswan.org/
> Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply
* Re: [RFC PATCH v7 01/19] Add a new structure for skb buffer from external.
From: Herbert Xu @ 2010-06-20 11:02 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Xin, Xiaohui, Stephen Hemminger, netdev@vger.kernel.org,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org, mingo@elte.hu,
davem@davemloft.net, jdike@linux.intel.com, Rusty Russell
In-Reply-To: <20100620103909.GA5285@redhat.com>
On Sun, Jun 20, 2010 at 01:39:09PM +0300, Michael S. Tsirkin wrote:
>
> > It's just like migrating from a backend that supports TSO
> > to one that doesn't.
>
> Exactly. We don't support such migration.
Well that's something that has to be addressed in the virtio_net.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply
* Re: [PATCH] Driver-core: Always create class directories fixing the broken network drivers.
From: Kay Sievers @ 2010-06-20 10:52 UTC (permalink / raw)
To: Eric W. Biederman; +Cc: Greg KH, Johannes Berg, netdev
In-Reply-To: <m139wiuswa.fsf_-_@fess.ebiederm.org>
On Sun, Jun 20, 2010 at 08:20, Eric W. Biederman <ebiederm@xmission.com> wrote:
>
> In get_device_parent there is a check to not add a class directory
> when a class device was put under another class device. The check was
> put in place as a just in case measure to not break old userspace if
> any existing code happened to depend on it. Currently the only known
> way that we get a class device under a class device is due to the
> rearrangement of devices that happened when the new sysfs layout was
> introduced.
>
> With the introduction of tagged sysfs directories for properly
> handling network namespace support this omission in creating the class
> directories went from a bad thing in terms of namespace pollution, to
> actually breaking device_remove.
>
> Currently there are two reported network device drivers that break
> because the class directory was not created by the device layer. The
> usb bnep driver and the mac80211_hwsim driver.
>
> Every solution proposed changes the sysfs layout for the affected
> devices, and thus has the potential to break userspace.
>
> Since we are changing the sysfs layout anyway, and since we are now
> talking about several devices all with the same problem, all caused by
> the same over conservative bit of code. Let's kill that bit of code.
>
> There have been other proposals to fix this but they all have been
> more complicated, and none of them have actually resulted in working
> code.
>
> Any userspace that works with both the old and the new sysfs layouts
> should not be affected by this change, and even if someone depends
> on it we are talking a very small number of drivers overall that
> are affected.
>
> My apologoies for not fully catching this hole in the logic the
> when this code was originally added.
We can not do this. Simply comparing the sysfs tree before and after
shows that it breaks 'input'. inputX and mouseX are now spearated by a
subdirectory, which is wrong.
As mentioned earlier, It's pretty fragile to change things in this
area, and I prefer the broken network driver-core interactions to be
fixed instead - even when they are more complicated.
Thanks,
Kay
^ permalink raw reply
* Re: [RFC PATCH v7 01/19] Add a new structure for skb buffer from external.
From: Michael S. Tsirkin @ 2010-06-20 10:39 UTC (permalink / raw)
To: Herbert Xu
Cc: Xin, Xiaohui, Stephen Hemminger, netdev@vger.kernel.org,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org, mingo@elte.hu,
davem@davemloft.net, jdike@linux.intel.com, Rusty Russell
In-Reply-To: <20100620103235.GA31284@gondor.apana.org.au>
On Sun, Jun 20, 2010 at 08:32:35PM +1000, Herbert Xu wrote:
> On Sun, Jun 20, 2010 at 01:06:32PM +0300, Michael S. Tsirkin wrote:
> >
> > Changing the guest virtio to match the backend is a problem,
> > this breaks migration etc.
>
> As long as it's done in a backwards compatible way it should be
> fine.
Possibly, but to me the need to do this implies that
we'll need another change with different hardware at the backend.
> It's just like migrating from a backend that supports TSO
> to one that doesn't.
>
> Cheers,
Exactly. We don't support such migration.
> --
> Visit Openswan at http://www.openswan.org/
> Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox