* Re: [PATCH net-next-2.6] ipv4: use skb_dst_copy() in ip_copy_metadata()
From: David Miller @ 2010-07-06 2:08 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
In-Reply-To: <1278064102.2530.29.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 02 Jul 2010 11:48:22 +0200
> Avoid touching dst refcount in ip_fragment().
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH] usbnet: remove direct access to urb->status
From: David Miller @ 2010-07-06 2:08 UTC (permalink / raw)
To: oneukum; +Cc: netdev
In-Reply-To: <201007021558.25774.oneukum@suse.de>
From: Oliver Neukum <oneukum@suse.de>
Date: Fri, 2 Jul 2010 15:58:25 +0200
> From a2e8da61490cba876b1b4814c4832822527c43dd Mon Sep 17 00:00:00 2001
> From: Oliver Neukum <oliver@neukum.org>
> Date: Fri, 2 Jul 2010 15:51:55 +0200
> Subject: [PATCH] usbnet: remove direct access to urb->status
>
> USB drivers should not use urb->status directly because
> it is scheduled to become a parameter. This does the conversion
> for drivers/net/usb
>
> Signed-off-by: Oliver Neukum <oneukum@suse.de>
Applied.
^ permalink raw reply
* Re: [PATCH] ks8842: Replace usage of dev_dbg with netdev_dbg
From: David Miller @ 2010-07-06 2:08 UTC (permalink / raw)
To: richard.rojfors; +Cc: netdev
In-Reply-To: <1278285999.2594.4.camel@debian>
From: Richard Röjfors <richard.rojfors@pelagicore.com>
Date: Mon, 05 Jul 2010 01:26:39 +0200
> This patch replaces all usage of dev_dbg with netdev_dbg.
>
> A side effect is that the pointer to the platform device in the adapter
> struct can be removed.
>
> Signed-off-by: Richard Röjfors <richard.rojfors@pelagicore.com>
Applied.
^ permalink raw reply
* Re: [PATCH] ns83820: Use the instance of net_device_stats from net_device.
From: David Miller @ 2010-07-06 2:07 UTC (permalink / raw)
To: segooon
Cc: kernel-janitors, adobriyan, shemminger, tj, jpirko, netdev,
linux-kernel
In-Reply-To: <1278332071-17865-1-git-send-email-segooon@gmail.com>
From: Kulikov Vasiliy <segooon@gmail.com>
Date: Mon, 5 Jul 2010 16:14:28 +0400
> Since net_device has an instance of net_device_stats,
> we can remove the instance of this from the adapter structure.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH] ni52: Use the instance of net_device_stats from net_device.
From: David Miller @ 2010-07-06 2:07 UTC (permalink / raw)
To: segooon
Cc: kernel-janitors, joe, jpirko, shemminger, jkosina, netdev,
linux-kernel
In-Reply-To: <1278332065-17831-1-git-send-email-segooon@gmail.com>
From: Kulikov Vasiliy <segooon@gmail.com>
Date: Mon, 5 Jul 2010 16:14:23 +0400
> Since net_device has an instance of net_device_stats,
> we can remove the instance of this from the adapter structure.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH] starfire: Use the instance of net_device_stats from net_device.
From: David Miller @ 2010-07-06 2:07 UTC (permalink / raw)
To: segooon
Cc: kernel-janitors, ionut, joe, jpirko, shemminger, akpm, netdev,
linux-kernel
In-Reply-To: <1278332077-18431-1-git-send-email-segooon@gmail.com>
From: Kulikov Vasiliy <segooon@gmail.com>
Date: Mon, 5 Jul 2010 16:14:34 +0400
> Since net_device has an instance of net_device_stats,
> we can remove the instance of this from the adapter structure.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Applied.
^ permalink raw reply
* Re: setsockopt(IP_TOS) being privileged or distinct capability?
From: Hagen Paul Pfeifer @ 2010-07-06 2:07 UTC (permalink / raw)
To: Philip Prindeville; +Cc: Alexander Clouter, netdev
In-Reply-To: <4C321EAF.9000508@redfish-solutions.com>
* Philip Prindeville | 2010-07-05 12:04:31 [-0600]:
>I understand that. That's part of the reason that I've submitted
>patches for APR, Apache, Thunderbird, Firefox, Proftpd, Curl, wget,
>etc. There is pressure within certain technical groups to get ISP's
>to voluntarily implement RFC-4594... that's the carrot. The stick
>being FCC heavy-handed regulation of the ISP's if they don't.
Where is the _real_ advantage if setsockopt(IP_TOS) where a privileged
operation? At the end the user/service is still required to set his service
class, but this time with CAP_NET_ADMIN. Do you think that Service
Providers/Transit Providers trust (and this is the critical aspect) customers
based on some IP flags - this is extreme unlikely. 99% of users have
effective CAP_NET_ADMIN capabilities - and you cannot stop using them.
Service Providers/Transit Providers will trust customers who pays more and
then they will accept their DIFFSERV suggestion signaled via IP DSCP. All
other customers will be treated normal, with zeroed DSCP. It makes no sense
for ISP's to shift the trust aspect to the customer side.
HGN
^ permalink raw reply
* Re: [PATCH] natsemi: Use the instance of net_device_stats from net_device.
From: David Miller @ 2010-07-06 2:07 UTC (permalink / raw)
To: segooon
Cc: kernel-janitors, thockin, jpirko, joe, bhutchings, shemminger,
netdev, linux-kernel
In-Reply-To: <1278332059-17795-1-git-send-email-segooon@gmail.com>
From: Kulikov Vasiliy <segooon@gmail.com>
Date: Mon, 5 Jul 2010 16:14:17 +0400
> Since net_device has an instance of net_device_stats,
> we can remove the instance of this from the adapter structure.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH] mac89x0: Use the instance of net_device_stats from net_device.
From: David Miller @ 2010-07-06 2:07 UTC (permalink / raw)
To: segooon; +Cc: kernel-janitors, joe, eric.dumazet, kaber, tj, netdev,
linux-kernel
In-Reply-To: <1278332051-17760-1-git-send-email-segooon@gmail.com>
From: Kulikov Vasiliy <segooon@gmail.com>
Date: Mon, 5 Jul 2010 16:14:09 +0400
> Since net_device has an instance of net_device_stats,
> we can remove the instance of this from the adapter structure.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH] lance: Use the instance of net_device_stats from net_device.
From: David Miller @ 2010-07-06 2:07 UTC (permalink / raw)
To: segooon
Cc: kernel-janitors, joe, shemminger, eric.dumazet, kaber, netdev,
linux-kernel
In-Reply-To: <1278332046-17195-1-git-send-email-segooon@gmail.com>
From: Kulikov Vasiliy <segooon@gmail.com>
Date: Mon, 5 Jul 2010 16:14:03 +0400
> Since net_device has an instance of net_device_stats,
> we can remove the instance of this from the adapter structure.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH] ksz884x: Use the instance of net_device_stats from net_device.
From: David Miller @ 2010-07-06 2:07 UTC (permalink / raw)
To: segooon
Cc: kernel-janitors, eric.dumazet, jpirko, dkirjanov, netdev,
linux-kernel
In-Reply-To: <1278332040-17160-1-git-send-email-segooon@gmail.com>
From: Kulikov Vasiliy <segooon@gmail.com>
Date: Mon, 5 Jul 2010 16:13:58 +0400
> Since net_device has an instance of net_device_stats,
> we can remove the instance of this from the adapter structure.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH] hamachi: Use the instance of net_device_stats from net_device.
From: David Miller @ 2010-07-06 2:07 UTC (permalink / raw)
To: segooon
Cc: kernel-janitors, joe, jpirko, adobriyan, shemminger, netdev,
linux-kernel
In-Reply-To: <1278332023-16524-1-git-send-email-segooon@gmail.com>
From: Kulikov Vasiliy <segooon@gmail.com>
Date: Mon, 5 Jul 2010 16:13:41 +0400
> Since net_device has an instance of net_device_stats,
> we can remove the instance of this from the adapter structure.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH] fealnx: Use the instance of net_device_stats from net_device.
From: David Miller @ 2010-07-06 2:06 UTC (permalink / raw)
To: segooon
Cc: kernel-janitors, joe, jpirko, shemminger, adobriyan, netdev,
linux-kernel
In-Reply-To: <1278332018-16490-1-git-send-email-segooon@gmail.com>
From: Kulikov Vasiliy <segooon@gmail.com>
Date: Mon, 5 Jul 2010 16:13:36 +0400
> Since net_device has an instance of net_device_stats,
> we can remove the instance of this from the adapter structure.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH] hp100: Use the instance of net_device_stats from net_device.
From: David Miller @ 2010-07-06 2:07 UTC (permalink / raw)
To: segooon
Cc: kernel-janitors, perex, jpirko, adobriyan, shemminger, jkosina,
netdev, linux-kernel
In-Reply-To: <1278332028-16769-1-git-send-email-segooon@gmail.com>
From: Kulikov Vasiliy <segooon@gmail.com>
Date: Mon, 5 Jul 2010 16:13:46 +0400
> Since net_device has an instance of net_device_stats,
> we can remove the instance of this from the adapter structure.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH] ethoc: Use the instance of net_device_stats from net_device.
From: David Miller @ 2010-07-06 2:06 UTC (permalink / raw)
To: segooon
Cc: kernel-janitors, thomas, jonas, eric.dumazet, julia, netdev,
linux-kernel
In-Reply-To: <1278332012-16456-1-git-send-email-segooon@gmail.com>
From: Kulikov Vasiliy <segooon@gmail.com>
Date: Mon, 5 Jul 2010 16:13:31 +0400
> Since net_device has an instance of net_device_stats,
> we can remove the instance of this from the adapter structure.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH] davinci_emac: Use the instance of net_device_stats from net_device.
From: David Miller @ 2010-07-06 2:06 UTC (permalink / raw)
To: segooon
Cc: kernel-janitors, chaithrika, srk, khilman, jpirko, netdev,
linux-kernel
In-Reply-To: <1278332007-16175-1-git-send-email-segooon@gmail.com>
From: Kulikov Vasiliy <segooon@gmail.com>
Date: Mon, 5 Jul 2010 16:13:26 +0400
> Since net_device has an instance of net_device_stats,
> we can remove the instance of this from the adapter structure.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH] epic100: Use the instance of net_device_stats from net_device.
From: David Miller @ 2010-07-06 2:06 UTC (permalink / raw)
To: segooon
Cc: kernel-janitors, joe, jpirko, shemminger, adobriyan, netdev,
linux-kernel
In-Reply-To: <1278332002-15860-1-git-send-email-segooon@gmail.com>
From: Kulikov Vasiliy <segooon@gmail.com>
Date: Mon, 5 Jul 2010 16:13:20 +0400
> Since net_device has an instance of net_device_stats,
> we can remove the instance of this from the adapter structure.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH] cs89x0: Use the instance of net_device_stats from net_device.
From: David Miller @ 2010-07-06 2:06 UTC (permalink / raw)
To: segooon
Cc: kernel-janitors, joe, shemminger, julia, dongdong.deng, netdev,
linux-kernel
In-Reply-To: <1278331997-15826-1-git-send-email-segooon@gmail.com>
From: Kulikov Vasiliy <segooon@gmail.com>
Date: Mon, 5 Jul 2010 16:13:15 +0400
> Since net_device has an instance of net_device_stats,
> we can remove the instance of this from the adapter structure.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH] sun3_82586: Use the instance of net_device_stats from net_device.
From: David Miller @ 2010-07-06 2:06 UTC (permalink / raw)
To: segooon
Cc: kernel-janitors, jpirko, eric.dumazet, kaber, tj, netdev,
linux-kernel
In-Reply-To: <1278331992-15792-1-git-send-email-segooon@gmail.com>
From: Kulikov Vasiliy <segooon@gmail.com>
Date: Mon, 5 Jul 2010 16:13:10 +0400
> Since net_device has an instance of net_device_stats,
> we can remove the instance of this from the adapter structure.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH 4/4] phylib: Allow reading and writing a mii bus from atomic context.
From: David Miller @ 2010-07-06 2:05 UTC (permalink / raw)
To: richardcochran; +Cc: netdev
In-Reply-To: <a06cf09ed5096bf8f9434d90828adfa70586e936.1278307573.git.richard.cochran@omicron.at>
From: Richard Cochran <richardcochran@gmail.com>
Date: Mon, 5 Jul 2010 07:33:14 +0200
> In order to support hardware time stamping from a PHY, it is necessary to
> read from the PHY while running in_interrupt(). This patch allows a mii
> bus to operate in an atomic context. An mii_bus driver may declare itself
> capable for this mode. Drivers which do not do this will remain with the
> default that bus operations may sleep.
>
> Before commit 35b5f6b1a82b5c586e0b24c711dc6ba944e88ef1 mii bus
> operations were protected with spin locks. That commit replaced the
> locks with mutexs in order to accommodate i2c buses that need to
> sleep. Thus, this patch restores the original behavior as a run time
> option.
>
> Signed-off-by: Richard Cochran <richard.cochran@omicron.at>
Ok, I'm not to happy about this one, to be honest.
Conditional locking is always a problem waiting to happen.
Question: What context can you call mdiobus_lock() in?
Answer: You absolutely cannot know.
Therefore every piece of code, except those with special knowledge
of what kind of device is behind the mdiobus object, have to assume
the worst which is that the interface can only be called in sleepable
contexts.
We need to find another way to accomodate this, I really don't want to
see this kind of situation where the locking facility type is
conditional upon the device sitting behind the interface.
^ permalink raw reply
* Re: [PATCH 3/4] phylib: preserve ifreq parameter when calling generic phy_mii_ioctl()
From: David Miller @ 2010-07-06 2:03 UTC (permalink / raw)
To: richardcochran; +Cc: netdev
In-Reply-To: <3187f4618ad376027868b372df3c22c4c26ec3ec.1278307573.git.richard.cochran@omicron.at>
From: Richard Cochran <richardcochran@gmail.com>
Date: Mon, 5 Jul 2010 07:33:03 +0200
> The phy_mii_ioctl() function unnecessarily throws away the original ifreq.
> We need access to the ifreq in order to support PHYs that can perform
> hardware time stamping.
>
> Two maverick drivers filter the ioctl commands passed to phy_mii_ioctl().
> This is unnecessary since phylib will check the command in any case.
>
> Signed-off-by: Richard Cochran <richard.cochran@omicron.at>
Applied.
^ permalink raw reply
* Re: [PATCH 2/4] phylib: add a way to make PHY time stamps possible.
From: David Miller @ 2010-07-06 2:03 UTC (permalink / raw)
To: richardcochran; +Cc: netdev
In-Reply-To: <f5d438863bb1132293cb6eab89fe199a739e4957.1278307573.git.richard.cochran@omicron.at>
From: Richard Cochran <richardcochran@gmail.com>
Date: Mon, 5 Jul 2010 07:32:52 +0200
> This patch adds a new networking option to allow hardware time stamps
> from PHY devices. Using PHY time stamps will still require adding two
> inline function calls to each MAC driver. The CONFIG option makes
> these calls safe to add, since the calls become NOOPs when the option
> is disabled.
>
> The patch also adds phylib driver methods for the SIOCSHWTSTAMP ioctl
> and callbacks for transmit and receive time stamping. Drivers may
> optionally implement these functions.
>
> Signed-off-by: Richard Cochran <richard.cochran@omicron.at>
Applied.
^ permalink raw reply
* Re: [PATCH 1/4] net: add driver hooks for time stamping.
From: David Miller @ 2010-07-06 2:03 UTC (permalink / raw)
To: richardcochran; +Cc: netdev
In-Reply-To: <a9c79dd7d996a352b37ea4e650b235d0c8b996d1.1278307573.git.richard.cochran@omicron.at>
From: Richard Cochran <richardcochran@gmail.com>
Date: Mon, 5 Jul 2010 07:31:07 +0200
> This patch adds hooks for transmit and receive time stamps. The
> transmit hook allows a software fallback for transmit time stamps,
> for MACs lacking time stamping hardware. The receive hook does not yet
> have any effect, but it prepares the way for hardware time stamping
> in PHY devices. Using the hooks will still require adding two inline
> function calls to each MAC driver.
>
> Signed-off-by: Richard Cochran <richard.cochran@omicron.at>
Applied.
^ permalink raw reply
* Re: Splice status
From: Changli Gao @ 2010-07-06 2:01 UTC (permalink / raw)
To: Eric Dumazet; +Cc: Jens Axboe, Ofer Heifetz, netdev@vger.kernel.org
In-Reply-To: <1278334254.2877.158.camel@edumazet-laptop>
On Mon, Jul 5, 2010 at 8:50 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Le lundi 05 juillet 2010 à 13:52 +0300, Ofer Heifetz a écrit :
>> I am using Samba, so from my understanding of the source code, it
> loops and performs splice(sock, pipe) and splice(pipe, fd). There is no
> flush of any sort in between.
>>
>> When you say drain you mean to flush all data to pipe?
>>
>
> Draining pipe before splice() call would only trigger the bug less
> often.
If we don't drain the pipe before calling splice(2), the data spliced
from pipe maybe not be what we expect. Then data corruption occurs.
>
> splice(sock, pipe) can block if caller dont use appropriate "non
> blocking pipe' splice() mode, even if pipe is empty before a splice()
> call.
I don't think it is expected. The code of sys_recvfile is much like
the sendfile(2) implementation in kernel. If sys_recvfile may block
without non_block flag, sendfile(2) may block too.
BTW: Samba can use sendfile(2) instead in sys_recvfile.
--
Regards,
Changli Gao(xiaosuo@gmail.com)
^ permalink raw reply
* Re: [NET] ioc3-eth: Use the instance of net_device_stats from net_device.
From: David Miller @ 2010-07-06 1:56 UTC (permalink / raw)
To: ralf
Cc: segooon, kernel-janitors, jpirko, eric.dumazet, kaber, adobriyan,
linux-mips, netdev, linux-kernel
In-Reply-To: <20100705125938.GB28849@linux-mips.org>
From: Ralf Baechle <ralf@linux-mips.org>
Date: Mon, 5 Jul 2010 13:59:38 +0100
> Since net_device has an instance of net_device_stats, we can remove the
> instance of this from the adapter structure.
>
> Based on original patch by Kulikov Vasiliy.
>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Applied.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox