* Re: [PATCH net-next-2.6] tg3: allow TSO on vlan devices
From: David Miller @ 2010-07-09 6:12 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev, mcarlson, mchan
In-Reply-To: <1278605695.2651.48.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 08 Jul 2010 18:14:55 +0200
> Similar to commit 72dccb01e8632aa (bnx2: Update vlan_features)
>
> In order to enable TSO on vlan devices, tg3 needs to update
> dev->vlan_features.
>
> Tested on HP NC326m (aka BCM5715S (rev a3))
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH net-next-2.6] bnx2: 64 bit stats on all arches
From: David Miller @ 2010-07-09 6:13 UTC (permalink / raw)
To: eric.dumazet; +Cc: mchan, netdev, mcarlson
In-Reply-To: <1278598123.2651.24.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 08 Jul 2010 16:08:43 +0200
> [PATCH net-next-2.6] bnx2: 64 bit stats on all arches
>
> Now core network is able to handle 64 bit netdevice stats on 32 bit
> arches, we can provide them for bnx2, since hardware maintains some 64
> bit counters.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> Acked-by: Michael Chan <mchan@broadcom.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH net-next-2.6 V2] tg3: 64 bit stats on all arches
From: David Miller @ 2010-07-09 6:14 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev, mcarlson, mchan
In-Reply-To: <1278571464.2543.7.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 08 Jul 2010 08:44:24 +0200
> Now core network is able to handle 64 bit netdevice stats on 32 bit
> arches, we can provide them for tg3, since hardware maintains 64 bit
> counters.
>
> I'll provide bnx2 and bnx2x patches as well.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH] cxgb4vf: remove obsolete DECLARE_PCI_UNMAP_ADDR usage
From: FUJITA Tomonori @ 2010-07-09 6:12 UTC (permalink / raw)
To: davem; +Cc: fujita.tomonori, leedom, netdev
In-Reply-To: <20100708.230939.102558536.davem@davemloft.net>
On Thu, 08 Jul 2010 23:09:39 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> > btw, I'm not sure that seeing if a platform does real DMA unmapping in
> > a driver is a good thing. But I suppose that we need to accept it if
> > this leads to big performance boost.
> >
> > Both can be applied to net-next.
>
> I think the value of these "optimizations" is rapidly decreasing to
> zero. And I believe I've told the authors of either this driver or
> another one that they should just remove this stuff completely.
I prefer to remove this stuff completely too.
If this trick improves the performance greatly, we could add this to
the DMA API (that's better than adding such ifdef hack to drivers).
^ permalink raw reply
* Re: 2.6.35-rc4-git3: Reported regressions from 2.6.34
From: David Miller @ 2010-07-09 6:20 UTC (permalink / raw)
To: eric.dumazet
Cc: torvalds, rjw, linux-kernel, akpm, netdev, kaber, jengelh,
casteyde.christian
In-Reply-To: <1278653334.2435.196.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 09 Jul 2010 07:28:54 +0200
> Le jeudi 08 juillet 2010 à 21:34 -0700, David Miller a écrit :
>> From: Linus Torvalds <torvalds@linux-foundation.org>
>> Date: Thu, 8 Jul 2010 18:34:25 -0700
>>
>> > On Thu, Jul 8, 2010 at 4:33 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
>> >>
>> >> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16187
>> >> Subject : Carrier detection failed in dhcpcd when link is up
>> >> Submitter : Christian Casteyde <casteyde.christian@free.fr>
>> >> Date : 2010-06-12 15:15 (27 days old)
>> >> First-Bad-Commit: http://git.kernel.org/linus/10708f37ae729baba9b67bd134c3720709d4ae62
>> >> Handled-By : Andrew Morton <akpm@linux-foundation.org>
>> >
>> > David? This bisects to a networking commit. Doesn't look sensible, but
>> > what do I know?
>>
>> My suspicion is that dhcpd uses netlink to dump the info of the
>> available links, and due to some bug gets confused with the new 64-bit
>> statistic netlink attribute being there now.
>> a second to have a look at this.
>
> It could be a dhcpcd bug because of extended size of answer
>
> According to strace, dhcpcd tries a recvmsg() call with
> a 256 bytes buffer to hold answer.
>
> Looking at current dhcpcd source, I confirm it cannot realloc its buffer
...
> This program needs to fix this.
Agreed, I don't there is any reasonable way we could cater to this
application bug with some compatability bits. Restricting the link
dump to 256 bytes is just too much inflexibility.
If NetworkManager can get this right, dhcpd very well can too :-)
^ permalink raw reply
* Re: [PATCH -net-2.6] ll_temac: fix DMA resources leak
From: David Miller @ 2010-07-09 6:23 UTC (permalink / raw)
To: dkirjanov; +Cc: john.linn, brian.hill, netdev
In-Reply-To: <20100708135445.GA30923@hera.kernel.org>
From: Denis Kirjanov <dkirjanov@hera.kernel.org>
Date: Thu, 8 Jul 2010 13:54:45 +0000
> Fix DMA resources leak.
>
> Signed-off-by: Denis Kirjanov <dkirjanov@kernel.org>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Applied to net-next-2.6, thanks.
^ permalink raw reply
* [PATCH v2] ks8842: Do the TX timeout work in workqueue context.
From: Richard Röjfors @ 2010-07-09 6:01 UTC (permalink / raw)
To: netdev; +Cc: davem
Currently all code that needs to be run at TX timeout is done in the
calling context, where bottom halves are disabled. Some of the code
blocks, so it needs to be done in a different context. This patch
adds in a work struct which is scheduled at TX timeout. Then the
timeout code is executed within work queue context.
In the process an unnecessary bank change before resetting the
controller was removed.
Signed-off-by: Richard Röjfors <richard.rojfors@pelagicore.com>
---
diff --git a/drivers/net/ks8842.c b/drivers/net/ks8842.c
index d47bba9..0be9261 100644
--- a/drivers/net/ks8842.c
+++ b/drivers/net/ks8842.c
@@ -119,6 +119,8 @@ struct ks8842_adapter {
int irq;
struct tasklet_struct tasklet;
spinlock_t lock; /* spinlock to be interrupt safe */
+ struct work_struct timeout_work;
+ struct net_device *netdev;
};
static inline void ks8842_select_bank(struct ks8842_adapter *adapter, u16 bank)
@@ -197,7 +199,6 @@ static void ks8842_reset(struct ks8842_adapter *adapter)
msleep(10);
iowrite16(0, adapter->hw_addr + REG_GRR);
*/
- iowrite16(32, adapter->hw_addr + REG_SELECT_BANK);
iowrite32(0x1, adapter->hw_addr + REG_TIMB_RST);
msleep(20);
}
@@ -553,6 +554,8 @@ static int ks8842_close(struct net_device *netdev)
netdev_dbg(netdev, "%s - entry\n", __func__);
+ cancel_work_sync(&adapter->timeout_work);
+
/* free the irq */
free_irq(adapter->irq, netdev);
@@ -595,9 +598,11 @@ static int ks8842_set_mac(struct net_device *netdev, void *p)
return 0;
}
-static void ks8842_tx_timeout(struct net_device *netdev)
+static void ks8842_tx_timeout_work(struct work_struct *work)
{
- struct ks8842_adapter *adapter = netdev_priv(netdev);
+ struct ks8842_adapter *adapter =
+ container_of(work, struct ks8842_adapter, timeout_work);
+ struct net_device *netdev = adapter->netdev;
unsigned long flags;
netdev_dbg(netdev, "%s: entry\n", __func__);
@@ -606,6 +611,9 @@ static void ks8842_tx_timeout(struct net_device *netdev)
/* disable interrupts */
ks8842_write16(adapter, 18, 0, REG_IER);
ks8842_write16(adapter, 18, 0xFFFF, REG_ISR);
+
+ netif_stop_queue(netdev);
+
spin_unlock_irqrestore(&adapter->lock, flags);
ks8842_reset_hw(adapter);
@@ -615,6 +623,15 @@ static void ks8842_tx_timeout(struct net_device *netdev)
ks8842_update_link_status(netdev, adapter);
}
+static void ks8842_tx_timeout(struct net_device *netdev)
+{
+ struct ks8842_adapter *adapter = netdev_priv(netdev);
+
+ netdev_dbg(netdev, "%s: entry\n", __func__);
+
+ schedule_work(&adapter->timeout_work);
+}
+
static const struct net_device_ops ks8842_netdev_ops = {
.ndo_open = ks8842_open,
.ndo_stop = ks8842_close,
@@ -649,6 +666,8 @@ static int __devinit ks8842_probe(struct platform_device *pdev)
SET_NETDEV_DEV(netdev, &pdev->dev);
adapter = netdev_priv(netdev);
+ adapter->netdev = netdev;
+ INIT_WORK(&adapter->timeout_work, ks8842_tx_timeout_work);
adapter->hw_addr = ioremap(iomem->start, resource_size(iomem));
if (!adapter->hw_addr)
goto err_ioremap;
^ permalink raw reply related
* Re: [PATCH 2/6 net-next-2.6] vxge: Use fifo based trans_start time
From: David Miller @ 2010-07-09 6:34 UTC (permalink / raw)
To: jon.mason; +Cc: netdev, sreenivasa.honnur, ram.vepa
In-Reply-To: <20100708192125.GB15167@exar.com>
From: Jon Mason <jon.mason@exar.com>
Date: Thu, 8 Jul 2010 14:21:26 -0500
> @@ -968,8 +969,10 @@ vxge_xmit(struct sk_buff *skb, struct net_device *dev)
> VXGE_HW_FIFO_TXD_TX_CKO_UDP_EN);
>
> vxge_hw_fifo_txdl_post(fifo_hw, dtr);
> +
> #ifdef NETIF_F_LLTX
> - dev->trans_start = jiffies; /* NETIF_F_LLTX driver :( */
> + txq = netdev_get_tx_queue(dev, vpath_no);
> + txq->trans_start = jiffies;
> #endif
This comment was placed there not just for it's artistic value,
you should heed what it's saying when making changes like this.
NETIF_F_LLTX drivers cannot use the per-txq trans_start mechanism,
because doing so is racy.
The dev_watchdog() timer, which checks these ->trans_start values,
can only synchornize with the driver by the traditional means,
which is by taking the spinlock on the TX queue. This is bypassed
by NETIF_F_LLTX drivers, so the driver can be in it's TX handler
while the watchdog timer is trying to evaluate the trans_start
state.
This is one of a many reasons why NETIF_F_LLTX is a bad idea and you
should convert your driver away from it.
^ permalink raw reply
* Re: [PATCH v4 1/9] atm: propagate signal changes via notifier
From: Karl Hiramoto @ 2010-07-09 6:36 UTC (permalink / raw)
To: David Miller; +Cc: linux-atm-general, netdev, chas
In-Reply-To: <20100708.214745.48520104.davem@davemloft.net>
On 07/09/2010 06:47 AM, David Miller wrote:
> From: Karl Hiramoto <karl@hiramoto.org>
> Date: Thu, 8 Jul 2010 10:34:47 +0200
>
>> +
>> +/*
>> + * atm_dev_signal_change
>> + *
>> + * Propagate lower layer signal change in atm_dev->signal to netdevice.
>> + * The event will be sent via a notifier call chain.
>> + */
> I said to format comments:
>
> /* Like
> * this.
> */
>
> not:
>
> /*
> * Like
> * this.
> */
>
> Honestly, I don't know how I can be more clear about this :-)
Ok, fixing it, but there are 100's of occurences in net/ like i had it. :-)
--
Karl
^ permalink raw reply
* Re: [PATCH v3 1/2] ks8842: Do the TX timeout work in workqueue context.
From: David Miller @ 2010-07-09 6:36 UTC (permalink / raw)
To: richard.rojfors; +Cc: netdev
In-Reply-To: <1278656894.6953.14.camel@debian>
From: Richard Röjfors <richard.rojfors@pelagicore.com>
Date: Fri, 09 Jul 2010 08:28:14 +0200
> Currently all code that needs to be run at TX timeout is done in the
> calling context, where bottom halves are disabled. Some of the code
> blocks, so it needs to be done in a different context. This patch
> adds in a work struct which is scheduled at TX timeout. Then the
> timeout code is executed within work queue context.
>
> Signed-off-by: Richard Röjfors <richard.rojfors@pelagicore.com>
Applied.
^ permalink raw reply
* Re: [PATCH v3 2/2] ks8842: Remove unnecessary bank select.
From: David Miller @ 2010-07-09 6:37 UTC (permalink / raw)
To: richard.rojfors; +Cc: netdev
In-Reply-To: <1278656896.6953.15.camel@debian>
From: Richard Röjfors <richard.rojfors@pelagicore.com>
Date: Fri, 09 Jul 2010 08:28:16 +0200
> This patch removes an unnecessary bank select before resetting the
> controller.
>
> Signed-off-by: Richard Röjfors <richard.rojfors@pelagicore.com>
Also applied, thanks.
^ permalink raw reply
* Re: [PATCH v4 1/9] atm: propagate signal changes via notifier
From: David Miller @ 2010-07-09 6:38 UTC (permalink / raw)
To: karl; +Cc: linux-atm-general, netdev, chas
In-Reply-To: <4C36C353.9080501@hiramoto.org>
From: Karl Hiramoto <karl@hiramoto.org>
Date: Fri, 09 Jul 2010 08:36:03 +0200
> Ok, fixing it, but there are 100's of occurences in net/ like i had it. :-)
I would be happy to see a patch which fixes them up :-)
^ permalink raw reply
* Re: [PATCH 1/4] ax88796: free irq on error
From: David Miller @ 2010-07-09 6:42 UTC (permalink / raw)
To: segooon; +Cc: kernel-janitors, p_gortmaker, julia, tj, joe, netdev
In-Reply-To: <1278590996-3122-1-git-send-email-segooon@gmail.com>
From: Kulikov Vasiliy <segooon@gmail.com>
Date: Thu, 8 Jul 2010 16:09:54 +0400
> If ax_ei_open() failed we must free previously requested irq.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH 2/4] ll_temac: fix memory leak
From: David Miller @ 2010-07-09 6:43 UTC (permalink / raw)
To: segooon
Cc: kernel-janitors, john.linn, grant.likely, jpirko, brian.hill,
netdev
In-Reply-To: <1278591006-3156-1-git-send-email-segooon@gmail.com>
From: Kulikov Vasiliy <segooon@gmail.com>
Date: Thu, 8 Jul 2010 16:10:03 +0400
> If of_iomap() or irq_of_parse_and_map() fail then np must be freed.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH 4/4] fec_mpc52xx: fix error path
From: David Miller @ 2010-07-09 6:44 UTC (permalink / raw)
To: segooon
Cc: kernel-janitors, grant.likely, jpirko, eric.dumazet, smaclennan,
netdev
In-Reply-To: <1278591018-3724-1-git-send-email-segooon@gmail.com>
From: Kulikov Vasiliy <segooon@gmail.com>
Date: Thu, 8 Jul 2010 16:10:16 +0400
> Error path in mpc52xx_fec_probe() is broken.
> We must free everything that we've allocated.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Also applied, thanks.
^ permalink raw reply
* Re: [PATCH net-next-2.6 1/2] net: Get rid of rtnl_link_stats64 / net_device_stats union
From: David Miller @ 2010-07-09 6:46 UTC (permalink / raw)
To: eric.dumazet; +Cc: bhutchings, netdev, linux-net-drivers
In-Reply-To: <1278649543.2435.105.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 09 Jul 2010 06:25:43 +0200
> This could be a small helper function, to hide the sizeof(*storage) /
> sizeof(u64) magic..
>
> static void stats_to_stats64(struct rtnl_link_stats64 *dst,
> const net_device_stats *src)
> {
Ben, please add Eric' suggestion and respin your second patch as
well.
Thanks!
^ permalink raw reply
* Re: [PATCH net-next-2.6] sfc: Remove unused field left from mis-merge
From: David Miller @ 2010-07-09 6:47 UTC (permalink / raw)
To: bhutchings; +Cc: netdev, linux-net-drivers
In-Reply-To: <1278632192.16013.309.camel@achroite.uk.solarflarecom.com>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Fri, 09 Jul 2010 00:36:32 +0100
> Commit eedc765ca4b19a41cf0b921a492ac08d640060d1 merged changes from
> net-2.6 that added and then removed efx_nic::port_num, which was also
> added in net-next-2.6. The end result should be that it is removed,
> since it is now unused.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Applied.
^ permalink raw reply
* Re: [PATCH 1/6 net-next-2.6] vxge: Remove queue_state references
From: David Miller @ 2010-07-09 6:47 UTC (permalink / raw)
To: jon.mason; +Cc: netdev, Sreenivasa.Honnur, ramkrishna.vepa
In-Reply-To: <20100708231936.GA19237@exar.com>
From: Jon Mason <jon.mason@exar.com>
Date: Thu, 8 Jul 2010 18:19:37 -0500
> On Thu, Jul 08, 2010 at 12:19:57PM -0700, Jon Mason wrote:
>> Remove queue_state references, as they are no longer necessary.
>>
>> Also, The driver needs to start/stop the queue regardless of which type
>> of steering is enabled. Remove checks for TX_MULTIQ_STEERING only and
>> start/stop for all steering types.
>>
>> Signed-off-by: Jon Mason <jon.mason@exar.com>
>> Signed-off-by: Sreenivasa Honnur <sreenivasa.honnur@exar.com>
>> Signed-off-by: Ramkrishna Vepa <ram.vepa@exar.com>
>
> Ram's e-mail address is incorrect in this series. Would you like me
> to resubmit with it corrected?
The series ended up needing to be respun anyways since the
txq->trans_start change is invalid.
^ permalink raw reply
* Re: [PATCH net-next] cxgb4vf: Implement "Unhandled Interrupts" statistic
From: David Miller @ 2010-07-09 6:48 UTC (permalink / raw)
To: leedom; +Cc: netdev
In-Reply-To: <201007081107.45287.leedom@chelsio.com>
From: Casey Leedom <leedom@chelsio.com>
Date: Thu, 8 Jul 2010 11:07:44 -0700
>>From 6c9cc1b5441afb32ecfcd10ac3060452e3c4df6f Mon Sep 17 00:00:00 2001
> From: Casey Leedom <leedom@chelsio.com>
> Date: Thu, 8 Jul 2010 10:05:48 -0700
> Subject: [PATCH net-next] cxgb4vf: Implement "Unhandled Interrupts" statistic
>
> Implement "Unhandled Interrupts" statistic so we can detect when the
> hardware tells us that it things we have work to do but we don't find
> anything ...
>
> Signed-off-by: Casey Leedom <leedom@chelsio.com>
Applied, thanks.
^ permalink raw reply
* [PATCH v3 0/2] ks8842: Do the TX timeout work in workqueue context.
From: Richard Röjfors @ 2010-07-09 6:28 UTC (permalink / raw)
To: netdev; +Cc: davem
To follow are two patches. One that schedules tx timeout to be done
in work queue context.
The other removed an unnecessary bank select before reset.
--Richard
^ permalink raw reply
* [PATCH v3 1/2] ks8842: Do the TX timeout work in workqueue context.
From: Richard Röjfors @ 2010-07-09 6:28 UTC (permalink / raw)
To: netdev; +Cc: davem
Currently all code that needs to be run at TX timeout is done in the
calling context, where bottom halves are disabled. Some of the code
blocks, so it needs to be done in a different context. This patch
adds in a work struct which is scheduled at TX timeout. Then the
timeout code is executed within work queue context.
Signed-off-by: Richard Röjfors <richard.rojfors@pelagicore.com>
---
diff --git a/drivers/net/ks8842.c b/drivers/net/ks8842.c
index d47bba9..5191af2 100644
--- a/drivers/net/ks8842.c
+++ b/drivers/net/ks8842.c
@@ -119,6 +119,8 @@ struct ks8842_adapter {
int irq;
struct tasklet_struct tasklet;
spinlock_t lock; /* spinlock to be interrupt safe */
+ struct work_struct timeout_work;
+ struct net_device *netdev;
};
static inline void ks8842_select_bank(struct ks8842_adapter *adapter, u16 bank)
@@ -553,6 +555,8 @@ static int ks8842_close(struct net_device *netdev)
netdev_dbg(netdev, "%s - entry\n", __func__);
+ cancel_work_sync(&adapter->timeout_work);
+
/* free the irq */
free_irq(adapter->irq, netdev);
@@ -595,9 +599,11 @@ static int ks8842_set_mac(struct net_device *netdev, void *p)
return 0;
}
-static void ks8842_tx_timeout(struct net_device *netdev)
+static void ks8842_tx_timeout_work(struct work_struct *work)
{
- struct ks8842_adapter *adapter = netdev_priv(netdev);
+ struct ks8842_adapter *adapter =
+ container_of(work, struct ks8842_adapter, timeout_work);
+ struct net_device *netdev = adapter->netdev;
unsigned long flags;
netdev_dbg(netdev, "%s: entry\n", __func__);
@@ -606,6 +612,9 @@ static void ks8842_tx_timeout(struct net_device *netdev)
/* disable interrupts */
ks8842_write16(adapter, 18, 0, REG_IER);
ks8842_write16(adapter, 18, 0xFFFF, REG_ISR);
+
+ netif_stop_queue(netdev);
+
spin_unlock_irqrestore(&adapter->lock, flags);
ks8842_reset_hw(adapter);
@@ -615,6 +624,15 @@ static void ks8842_tx_timeout(struct net_device *netdev)
ks8842_update_link_status(netdev, adapter);
}
+static void ks8842_tx_timeout(struct net_device *netdev)
+{
+ struct ks8842_adapter *adapter = netdev_priv(netdev);
+
+ netdev_dbg(netdev, "%s: entry\n", __func__);
+
+ schedule_work(&adapter->timeout_work);
+}
+
static const struct net_device_ops ks8842_netdev_ops = {
.ndo_open = ks8842_open,
.ndo_stop = ks8842_close,
@@ -649,6 +667,8 @@ static int __devinit ks8842_probe(struct platform_device *pdev)
SET_NETDEV_DEV(netdev, &pdev->dev);
adapter = netdev_priv(netdev);
+ adapter->netdev = netdev;
+ INIT_WORK(&adapter->timeout_work, ks8842_tx_timeout_work);
adapter->hw_addr = ioremap(iomem->start, resource_size(iomem));
if (!adapter->hw_addr)
goto err_ioremap;
^ permalink raw reply related
* [PATCH v3 2/2] ks8842: Remove unnecessary bank select.
From: Richard Röjfors @ 2010-07-09 6:28 UTC (permalink / raw)
To: netdev; +Cc: davem
This patch removes an unnecessary bank select before resetting the
controller.
Signed-off-by: Richard Röjfors <richard.rojfors@pelagicore.com>
---
diff --git a/drivers/net/ks8842.c b/drivers/net/ks8842.c
index 5191af2..0be9261 100644
--- a/drivers/net/ks8842.c
+++ b/drivers/net/ks8842.c
@@ -199,7 +199,6 @@ static void ks8842_reset(struct ks8842_adapter *adapter)
msleep(10);
iowrite16(0, adapter->hw_addr + REG_GRR);
*/
- iowrite16(32, adapter->hw_addr + REG_SELECT_BANK);
iowrite32(0x1, adapter->hw_addr + REG_TIMB_RST);
msleep(20);
}
^ permalink raw reply related
* Re: [PATCH v4 1/9] atm: propagate signal changes via notifier
From: Simon Horman @ 2010-07-09 6:50 UTC (permalink / raw)
To: David Miller; +Cc: karl, linux-atm-general, netdev, chas
In-Reply-To: <20100708.233801.258129125.davem@davemloft.net>
On Thu, Jul 08, 2010 at 11:38:01PM -0700, David Miller wrote:
> From: Karl Hiramoto <karl@hiramoto.org>
> Date: Fri, 09 Jul 2010 08:36:03 +0200
>
> > Ok, fixing it, but there are 100's of occurences in net/ like i had it. :-)
>
> I would be happy to see a patch which fixes them up :-)
Really? By my calculations it would be an awful lot of churn.
$ find net/ -type f -name "*.[chS]" | xargs grep "\/\* *$" | wc -l
6833
$ find net/ -type f -name "*.[chS]" | xargs grep -l "\/\* *$" | wc -l
929
^ permalink raw reply
* Re: [PATCH v4 1/9] atm: propagate signal changes via notifier
From: David Miller @ 2010-07-09 6:53 UTC (permalink / raw)
To: horms; +Cc: karl, linux-atm-general, netdev, chas
In-Reply-To: <20100709065012.GB24576@verge.net.au>
From: Simon Horman <horms@verge.net.au>
Date: Fri, 9 Jul 2010 15:50:13 +0900
> On Thu, Jul 08, 2010 at 11:38:01PM -0700, David Miller wrote:
>> From: Karl Hiramoto <karl@hiramoto.org>
>> Date: Fri, 09 Jul 2010 08:36:03 +0200
>>
>> > Ok, fixing it, but there are 100's of occurences in net/ like i had it. :-)
>>
>> I would be happy to see a patch which fixes them up :-)
>
> Really? By my calculations it would be an awful lot of churn.
>
> $ find net/ -type f -name "*.[chS]" | xargs grep "\/\* *$" | wc -l
> 6833
> $ find net/ -type f -name "*.[chS]" | xargs grep -l "\/\* *$" | wc -l
> 929
I didn't mean "one patch" which fixes them up :)
Done graudually in chunks over a period of time, it's not likely
to be so much churn.
This is how every other coding style malfeasance gets handled.
^ permalink raw reply
* [PATCH v5 0/9] atm: propagate atm_dev signal carrier to LOWER_UP of netdevice
From: Karl Hiramoto @ 2010-07-09 6:55 UTC (permalink / raw)
To: linux-atm-general, netdev, chas, davem; +Cc: Karl Hiramoto
Changes from v4:
* remove a "* \n" inside a comment in atmdev.h
Changes from v3:
* read_lock_irqsave() instead of read_lock_irq()
* format comments in atmdev.h
Changes from v2:
* use atomic instead of blocking notifier
* use read_lock_irq() instead of read_lock() in atm/br2684
* clean up comments
* remove unused variable.
Changes from v1:
Use atm_dev notifier chain instead of callback function pointer in struct vcc.
In drivers/usb/atm call atm_dev_signal_change().
In userspace it's helpful to know if a network device has a carrier signal.
Often it is monitored via netlink. This patchset allows a way for the
struct atm_dev drivers to pass carrier on/off to the netdevice.
For DSL, carrier is on when the line has reached showtime state.
Currently this patchset only propagates the changes to br2684 vccs,
as this is the only type of hardware I have to test.
If you prefer git you can pull from:
git://github.com/karlhiramoto/linux-2.6.git atm-v5
drivers/atm/adummy.c | 39 ++++++++++++++++++++++++
drivers/atm/idt77105.c | 11 ++++---
drivers/atm/solos-pci.c | 6 ++--
drivers/atm/suni.c | 5 ++-
drivers/usb/atm/cxacru.c | 18 ++++++------
drivers/usb/atm/speedtch.c | 10 +++---
drivers/usb/atm/ueagle-atm.c | 13 ++++++--
include/linux/atmdev.h | 17 +++++++++++
net/atm/br2684.c | 66 ++++++++++++++++++++++++++++++++++++++++-
net/atm/common.c | 30 +++++++++++++++++++
10 files changed, 186 insertions(+), 29 deletions(-)
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox