* Re: [PATCH v2] depca: fix leaks in depca_module_init()
From: David Miller @ 2010-07-13 3:32 UTC (permalink / raw)
To: segooon; +Cc: kernel-janitors, jpirko, joe, shemminger, eric.dumazet, netdev
In-Reply-To: <20100712145233.GA30504@albatros>
From: Kulikov Vasiliy <segooon@gmail.com>
Date: Mon, 12 Jul 2010 18:52:33 +0400
> Since some of xxx_register_driver() can return error we must unregister
> already registered drivers.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] cxgb4vf: fix TX Queue restart
From: David Miller @ 2010-07-13 3:32 UTC (permalink / raw)
To: leedom; +Cc: netdev
In-Reply-To: <201007121502.54176.leedom@chelsio.com>
From: Casey Leedom <leedom@chelsio.com>
Date: Mon, 12 Jul 2010 15:02:53 -0700
>>From e1c7a6e339a47c42aaf3e425fa3228b33a425a8f Mon Sep 17 00:00:00 2001
> From: Casey Leedom <leedom@chelsio.com>
> Date: Mon, 12 Jul 2010 14:39:07 -0700
> Subject: [PATCH net-next] cxgb4vf: fix TX Queue restart
>
> Fix up TX Queue Host Flow Control to cause an Egress Queue Status Update to
> be generated when we run out of TX Queue Descriptors. This will, in turn,
> allow us to restart a stopped TX Queue.
>
> Signed-off-by: Casey Leedom <leedom@chelsio.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH -net-next-2.6] ll_temac: Fix missing validate_addr hook
From: David Miller @ 2010-07-13 3:33 UTC (permalink / raw)
To: dkirjanov; +Cc: netdev
In-Reply-To: <20100710211044.GA24861@hera.kernel.org>
From: Denis Kirjanov <dkirjanov@kernel.org>
Date: Sat, 10 Jul 2010 21:10:44 +0000
> Fix missing validate_addr hook
>
> Signed-off-by: Denis Kirjanov <dkirjanov@kernel.org>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH] tc35815: fix iomap leak
From: David Miller @ 2010-07-13 3:33 UTC (permalink / raw)
To: segooon; +Cc: kernel-janitors, anemo, jpirko, eric.dumazet, adobriyan, netdev
In-Reply-To: <1278756199-4636-1-git-send-email-segooon@gmail.com>
From: Kulikov Vasiliy <segooon@gmail.com>
Date: Sat, 10 Jul 2010 14:03:18 +0400
> If tc35815_init_one() fails we must unmap mapped regions.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH 2/3 v2] macsonic: free irqs if sonic_open() fails
From: David Miller @ 2010-07-13 3:33 UTC (permalink / raw)
To: segooon
Cc: error27, kernel-janitors, fthain, u.kleine-koenig, tj, geert,
netdev
In-Reply-To: <20100710113906.GB6967@albatros>
From: Kulikov Vasiliy <segooon@gmail.com>
Date: Sat, 10 Jul 2010 15:39:06 +0400
> macsonic_open() doesn't check sonic_open() return code. If it is error
> we must free requested IRQs.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH 3/3] xtsonic: free irq if sonic_open() fails
From: David Miller @ 2010-07-13 3:33 UTC (permalink / raw)
To: segooon; +Cc: kernel-janitors, u.kleine-koenig, tj, joe, netdev
In-Reply-To: <1278759704-7777-1-git-send-email-segooon@gmail.com>
From: Kulikov Vasiliy <segooon@gmail.com>
Date: Sat, 10 Jul 2010 15:01:44 +0400
> xtsonic_open() doesn't check sonic_open() return code. If it is error
> we must free requested IRQ.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next-2.6][atm]: remove IRQF_DISABLED in combination with IRQF_SHARED
From: David Miller @ 2010-07-13 3:34 UTC (permalink / raw)
To: chas; +Cc: netdev
In-Reply-To: <201007101342.o6ADg2wx019157@cmf.nrl.navy.mil>
From: "chas williams - CONTRACTOR" <chas@cmf.nrl.navy.mil>
Date: Sat, 10 Jul 2010 09:42:02 -0400
> From: chas williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
>
> commit 2fae0433cf7febc4b69ff58730de1ca412846743
> Author: chas williams - CONTRACTOR <chas@relax.cmf.nrl.navy.mil>
> Date: Sat Jul 10 09:38:05 2010 -0400
>
> [atm]: remove IRQF_DISABLED in combination with IRQF_SHARED
>
> Signed-off-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Applied.
^ permalink raw reply
* Re: [patch] isdn: fix strlen() usage
From: David Miller @ 2010-07-13 3:34 UTC (permalink / raw)
To: error27; +Cc: isdn, shemminger, hohndel, jkosina, netdev, kernel-janitors
In-Reply-To: <20100710143111.GA19184@bicker>
From: Dan Carpenter <error27@gmail.com>
Date: Sat, 10 Jul 2010 16:31:11 +0200
> There was a missing "else" statement so the original code overflowed if
> ->master->name was too long. Also the ->slave and ->master buffers can
> hold names with 9 characters and a NULL so I cleaned it up to allow
> another character.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Applied.
^ permalink raw reply
* Re: [patch] 9p: strlen() doesn't count the terminator
From: David Miller @ 2010-07-13 3:34 UTC (permalink / raw)
To: akpm
Cc: error27, ericvh, adkulkar, jvrao, linux-kernel, tilman, netdev,
kernel-janitors
In-Reply-To: <20100712130458.bb8ae751.akpm@linux-foundation.org>
From: Andrew Morton <akpm@linux-foundation.org>
Date: Mon, 12 Jul 2010 13:04:58 -0700
> This bug doesn't strike me as serious enough to warrant backporting the fix
> into -stable. What was your thinking there?
Meanwhile I'll queue this up to net-next-2.6, thanks.
^ permalink raw reply
* Re: [PATCH 1/2] net: cleanups
From: David Miller @ 2010-07-13 3:35 UTC (permalink / raw)
To: xiaosuo; +Cc: netdev
In-Reply-To: <1278830466-22386-1-git-send-email-xiaosuo@gmail.com>
From: Changli Gao <xiaosuo@gmail.com>
Date: Sun, 11 Jul 2010 14:41:06 +0800
> net: cleanups
>
> remove useless blanks.
>
> Signed-off-by: Changli Gao <xiaosuo@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH 2/2] inet, inet6: make tcp_sendmsg() and tcp_sendpage() through inet_sendmsg() and inet_sendpage()
From: David Miller @ 2010-07-13 3:35 UTC (permalink / raw)
To: xiaosuo; +Cc: kuznet, pekkas, jmorris, yoshfuji, kaber, therbert, netdev
In-Reply-To: <1278830515-22422-1-git-send-email-xiaosuo@gmail.com>
From: Changli Gao <xiaosuo@gmail.com>
Date: Sun, 11 Jul 2010 14:41:55 +0800
> inet, inet6: make tcp_sendmsg() and tcp_sendpage() through inet_sendmsg() and
> inet_sendpage()
>
> a new boolean flag no_autobind is added to structure proto to avoid the autobind
> calls when the protocol is TCP. Then sock_rps_record_flow() is called int the
> TCP's sendmsg() and sendpage() pathes.
>
> Signed-off-by: Changli Gao <xiaosuo@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next-2.6] net: sock_free() optimizations
From: David Miller @ 2010-07-13 3:35 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
In-Reply-To: <1278837917.2538.138.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sun, 11 Jul 2010 10:45:17 +0200
> Avoid two extra instructions in sock_free(), to reload
> skb->truesize and skb->sk
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks Eric.
^ permalink raw reply
* Re: [PATCH 02/12] isdn: autoconvert trivial BKL users to private mutex
From: David Miller @ 2010-07-13 3:35 UTC (permalink / raw)
To: arnd; +Cc: linux-kernel, jkacur, fweisbec, isdn, netdev
In-Reply-To: <1278883143-29035-3-git-send-email-arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Sun, 11 Jul 2010 23:18:53 +0200
> All these files use the big kernel lock in a trivial
> way to serialize their private file operations,
> typically resulting from an earlier semi-automatic
> pushdown from VFS.
>
> None of these drivers appears to want to lock against
> other code, and they all use the BKL as the top-level
> lock in their file operations, meaning that there
> is no lock-order inversion problem.
>
> Consequently, we can remove the BKL completely,
> replacing it with a per-file mutex in every case.
> Using a scripted approach means we can avoid
> typos.
...
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied.
^ permalink raw reply
* Re: [PATCH 06/12] net: autoconvert trivial BKL users to private mutex
From: David Miller @ 2010-07-13 3:35 UTC (permalink / raw)
To: arnd; +Cc: linux-kernel, jkacur, fweisbec, netdev
In-Reply-To: <1278883143-29035-7-git-send-email-arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Sun, 11 Jul 2010 23:18:57 +0200
> All these files use the big kernel lock in a trivial
> way to serialize their private file operations,
> typically resulting from an earlier semi-automatic
> pushdown from VFS.
>
> None of these drivers appears to want to lock against
> other code, and they all use the BKL as the top-level
> lock in their file operations, meaning that there
> is no lock-order inversion problem.
>
> Consequently, we can remove the BKL completely,
> replacing it with a per-file mutex in every case.
> Using a scripted approach means we can avoid
> typos.
...
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied.
^ permalink raw reply
* Re: [PATCH] fec: use interrupt for MDIO completion indication
From: David Miller @ 2010-07-13 3:36 UTC (permalink / raw)
To: baruch; +Cc: netdev, linux-arm-kernel, kernel, bryan.wu, gerg
In-Reply-To: <006416d38a8e51ba8dd8631613a991528dc7976a.1278918594.git.baruch@tkos.co.il>
From: Baruch Siach <baruch@tkos.co.il>
Date: Mon, 12 Jul 2010 10:12:51 +0300
> With the move to phylib (commit e6b043d) I was seeing sporadic "MDIO write
> timeout" messages. Measure of the actual time spent showed latency times of
> more than 1600us.
>
> This patch uses the MII event indication of the FEC hardware to detect
> completion of MDIO transactions.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] drivers/scsi: Remove warnings after vsprintf %pV introduction
From: David Miller @ 2010-07-13 3:37 UTC (permalink / raw)
To: James.Bottomley
Cc: joe, sfr, netdev, linux-next, linux-kernel, gregkh, matthew,
linux-scsi
In-Reply-To: <1278923239.32614.1.camel@mulgrave.site>
From: James Bottomley <James.Bottomley@suse.de>
Date: Mon, 12 Jul 2010 04:27:18 -0400
> What's the other 60% of the patch about? the strange addition of
> scsi_show_extd_sense_args() and all the KERN_CONT bits?
Well the new function is for logical seperation, and KERN_CONT
is what is supposed to be at the front of every printk format
that continues a partially-printed line.
^ permalink raw reply
* Re: [PATCH 10/36] drivers/isdn: Remove unnecessary casts of private_data
From: David Miller @ 2010-07-13 4:13 UTC (permalink / raw)
To: joe; +Cc: trivial, linux-kernel, isdn, netdev
In-Reply-To: <3dced1fd71a6f9b10f10cb2f47c88e3767a6e6cf.1278967120.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Mon, 12 Jul 2010 13:50:02 -0700
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply
* Re: [PATCH 31/36] net/core: Remove unnecessary casts of private_data
From: David Miller @ 2010-07-13 4:14 UTC (permalink / raw)
To: joe; +Cc: trivial, linux-kernel, netdev
In-Reply-To: <217e404708d336ed1ad3254c5ea6626ee94b6a3d.1278967121.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Mon, 12 Jul 2010 13:50:23 -0700
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply
* Re: [PATCH 13/36] drivers/net/caif: Remove unnecessary casts of private_data
From: David Miller @ 2010-07-13 4:13 UTC (permalink / raw)
To: joe; +Cc: trivial, linux-kernel, netdev
In-Reply-To: <2fadd3261e91b96050bf8193efacee08842ef9eb.1278967120.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Mon, 12 Jul 2010 13:50:05 -0700
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply
* Re: [PATCH 32/36] net/irda: Remove unnecessary casts of private_data
From: David Miller @ 2010-07-13 4:14 UTC (permalink / raw)
To: joe; +Cc: trivial, linux-kernel, samuel, netdev
In-Reply-To: <0f791bb0d02971908720f0d09b4d8ff9140bb6d0.1278967121.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Mon, 12 Jul 2010 13:50:24 -0700
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply
* Re: [REGRESSION,BISECTED] Panic on ifup
From: David Miller @ 2010-07-13 4:20 UTC (permalink / raw)
To: timo.teras; +Cc: linux, netdev
In-Reply-To: <4C3ABDC3.3000408@iki.fi>
From: Timo Teräs <timo.teras@iki.fi>
Date: Mon, 12 Jul 2010 10:01:23 +0300
> And here goes the patch (which I've only compile tested so far).
Timo, since this tested positively for the reporter, please make
a formal submission once you are happy with the patch.
Thanks.
^ permalink raw reply
* Re: [PATCH] hso: remove driver version
From: David Miller @ 2010-07-13 4:21 UTC (permalink / raw)
To: f.aben; +Cc: gregkh, linux-usb, netdev
In-Reply-To: <1278942125.23105.39.camel@filip-linux>
From: Filip Aben <f.aben@option.com>
Date: Mon, 12 Jul 2010 15:42:05 +0200
> This patch removes the driver version from the driver. This version
> hasn't changed since the driver's inclusion in the kernel and is a
> source of confusion for some customers.
>
> Signed-off-by: Filip Aben <f.aben@option.com>
Applied, thanks.
^ permalink raw reply
* iproute, batch-cmds, and mac-vlans.
From: Ben Greear @ 2010-07-13 4:49 UTC (permalink / raw)
To: NetDev
After too much time debugging, I finally realized that the ip
tool was truncating my command because the mac-vlan device name
had a '#' in it.
]# cat /tmp/foo.txt
ru add to 10.99.21.1 iif eth0#0 lookup local pref 11
# IP tool has some hacked up debugging code
]# ip -batch /tmp/foo.txt
argc: 4
arg -:to:-
arg -:iif:-
WARNING: Using TABLE_MAIN in iprule_modify, table_ok: 0 cmd: 32
So, it acts on eth0 instead of eth0#0, and silently ignores the 'lookup local pref 11'.
I understand that it is trying to parse # as comments, but would you
all be interested in a patch that allowed ignoring '#' except
when it is the first non-whitespace character on a line, and maybe
when preceded by whitespace? This would of course have the possibility
of breaking someone's script somewhere, so it could be enabled with
a new command line arg, perhaps.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply
* Re: [Pv-drivers] RFC: Network Plugin Architecture (NPA) for vmxnet3
From: Stephen Hemminger @ 2010-07-13 5:16 UTC (permalink / raw)
To: Shreyas Bhatewara
Cc: Christoph Hellwig, Pankaj Thakkar, pv-drivers@vmware.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
In-Reply-To: <1278990388.32650.22.camel@eng-rhel5-64>
On Mon, 12 Jul 2010 20:06:28 -0700
Shreyas Bhatewara <sbhatewara@vmware.com> wrote:
>
> On Thu, 2010-05-06 at 13:21 -0700, Christoph Hellwig wrote:
> > On Wed, May 05, 2010 at 10:52:53AM -0700, Stephen Hemminger wrote:
> > > Let me put it bluntly. Any design that allows external code to run
> > > in the kernel is not going to be accepted. Out of tree kernel modules are enough
> > > of a pain already, why do you expect the developers to add another
> > > interface.
> >
> > Exactly. Until our friends at VMware get this basic fact it's useless
> > to continue arguing.
> >
> > Pankaj and Dmitry: you're fine to waste your time on this, but it's not
> > going to go anywhere until you address that fundamental problem. The
> > first thing you need to fix in your archicture is to integrate the VF
> > function code into the kernel tree, and we can work from there.
> >
> > Please post patches doing this if you want to resume the discussion.
> >
> > _______________________________________________
> > Pv-drivers mailing list
> > Pv-drivers@vmware.com
> > http://mailman2.vmware.com/mailman/listinfo/pv-drivers
>
>
> As discussed, following is the patch to give you an idea
> about implementation of NPA for vmxnet3 driver. Although the
> patch is big, I have verified it with checkpatch.pl. It gave
> 0 errors / warnings.
>
> Signed-off-by: Matthieu Bucchaineri <matthieu@vmware.com>
> Signed-off-by: Shreyas Bhatewara <sbhatewara@vmware.com>
I think the concept won't fly.
But you should really at least try running checkpatch to make sure
the style conforms.
--
^ permalink raw reply
* Re: iproute, batch-cmds, and mac-vlans.
From: Stephen Hemminger @ 2010-07-13 5:19 UTC (permalink / raw)
To: Ben Greear; +Cc: NetDev
In-Reply-To: <4C3BF050.7040206@candelatech.com>
On Mon, 12 Jul 2010 21:49:20 -0700
Ben Greear <greearb@candelatech.com> wrote:
> After too much time debugging, I finally realized that the ip
> tool was truncating my command because the mac-vlan device name
> had a '#' in it.
>
> ]# cat /tmp/foo.txt
> ru add to 10.99.21.1 iif eth0#0 lookup local pref 11
>
>
> # IP tool has some hacked up debugging code
> ]# ip -batch /tmp/foo.txt
> argc: 4
> arg -:to:-
> arg -:iif:-
> WARNING: Using TABLE_MAIN in iprule_modify, table_ok: 0 cmd: 32
>
>
> So, it acts on eth0 instead of eth0#0, and silently ignores the 'lookup local pref 11'.
>
> I understand that it is trying to parse # as comments, but would you
> all be interested in a patch that allowed ignoring '#' except
> when it is the first non-whitespace character on a line, and maybe
> when preceded by whitespace? This would of course have the possibility
> of breaking someone's script somewhere, so it could be enabled with
> a new command line arg, perhaps.
Putting # in device name just sounds like a bad idea.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox