* Re: [PATCH 3/6] vxge: NETIF_F_LLTX removal
From: David Miller @ 2010-07-16 3:50 UTC (permalink / raw)
To: jon.mason; +Cc: netdev, ramkrishna.vepa
In-Reply-To: <1279219648-10345-3-git-send-email-jon.mason@exar.com>
From: Jon Mason <jon.mason@exar.com>
Date: Thu, 15 Jul 2010 13:47:25 -0500
> NETIF_F_LLTX and it's usage of local transmit locks are depricated in
> favor of using the netdev queue's transmit lock. Remove the local
> lock and all references to it, and use the netdev queue transmit lock
> in the transmit completion handler.
>
> Signed-off-by: Jon Mason <jon.mason@exar.com>
> Signed-off-by: Ramkrishna Vepa <ramkrishna.vepa@exar.com>
Thanks a lot for doing this work.
Applied.
^ permalink raw reply
* Re: [PATCH 2/6] vxge: Fix multicast issues
From: David Miller @ 2010-07-16 3:50 UTC (permalink / raw)
To: jon.mason; +Cc: netdev, sreenivasa.honnur, ramkrishna.vepa
In-Reply-To: <1279219648-10345-2-git-send-email-jon.mason@exar.com>
From: Jon Mason <jon.mason@exar.com>
Date: Thu, 15 Jul 2010 13:47:24 -0500
> Fix error in multicast flag check, add calls to restore the status of
> multicast and promiscuous mode settings after change_mtu, and style
> cleanups to shorten the function calls by using a temporary variable.
>
> Signed-off-by: Jon Mason <jon.mason@exar.com>
> Signed-off-by: Sreenivasa Honnur <sreenivasa.honnur@exar.com>
> Signed-off-by: Ramkrishna Vepa <ramkrishna.vepa@exar.com>
Applied.
^ permalink raw reply
* Re: [PATCH 1/6] vxge: Remove queue_state references
From: David Miller @ 2010-07-16 3:50 UTC (permalink / raw)
To: jon.mason; +Cc: netdev, sreenivasa.honnur, ramkrishna.vepa
In-Reply-To: <1279219648-10345-1-git-send-email-jon.mason@exar.com>
From: Jon Mason <jon.mason@exar.com>
Date: Thu, 15 Jul 2010 13:47:23 -0500
> Remove queue_state references, as they are no longer necessary.
>
> Also, The driver needs to start/stop the queue regardless of which type
> of steering is enabled. Remove checks for TX_MULTIQ_STEERING only and
> start/stop for all steering types.
>
> Signed-off-by: Jon Mason <jon.mason@exar.com>
> Signed-off-by: Sreenivasa Honnur <sreenivasa.honnur@exar.com>
> Signed-off-by: Ramkrishna Vepa <ramkrishna.vepa@exar.com>
Applied.
^ permalink raw reply
* [PATCH] ipt_REJECT: can't work with bridges
From: Changli Gao @ 2010-07-16 3:32 UTC (permalink / raw)
To: Patrick McHardy
Cc: David S. Miller, Alexey Kuznetsov, Pekka Savola (ipv6),
James Morris, Hideaki YOSHIFUJI, netfilter-devel, netdev,
Changli Gao
ipt_REJECT: can't work with bridges
ip_route_me_harder can't create the route cache when the outdev is the same with
the indev for the skbs whichout a valid protocol set.
__mkroute_input functions has this check:
1998 if (skb->protocol != htons(ETH_P_IP)) {
1999 /* Not IP (i.e. ARP). Do not create route, if it is
2000 * invalid for proxy arp. DNAT routes are always valid.
2001 *
2002 * Proxy arp feature have been extended to allow, ARP
2003 * replies back to the same interface, to support
2004 * Private VLAN switch technologies. See arp.c.
2005 */
2006 if (out_dev == in_dev &&
2007 IN_DEV_PROXY_ARP_PVLAN(in_dev) == 0) {
2008 err = -EINVAL;
2009 goto cleanup;
2010 }
2011 }
This patch gives the new skb a valid protocol to bypass this check. In order to
make ipt_REJECT work with bridges, you also need to enable ip_forward.
Signed-off-by: Changli Gao <xiaosuo@gmail.com>
----
net/ipv4/netfilter/ipt_REJECT.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ipv4/netfilter/ipt_REJECT.c b/net/ipv4/netfilter/ipt_REJECT.c
index bbbd273..e0bca39 100644
--- a/net/ipv4/netfilter/ipt_REJECT.c
+++ b/net/ipv4/netfilter/ipt_REJECT.c
@@ -111,6 +111,7 @@ static void send_reset(struct sk_buff *oldskb, int hook)
/* ip_route_me_harder expects skb->dst to be set */
skb_dst_set_noref(nskb, skb_dst(oldskb));
+ nskb->protocol = __constant_htons(ETH_P_IP);
if (ip_route_me_harder(nskb, addr_type))
goto free_nskb;
^ permalink raw reply related
* Re: [PATCH 7/8] net: bridge: fix sign bug
From: David Miller @ 2010-07-16 3:28 UTC (permalink / raw)
To: shemminger
Cc: segooon, kernel-janitors, herbert, yoshfuji, eric.dumazet, bridge,
netdev
In-Reply-To: <20100715122144.0f2cf5cf@nehalam>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Thu, 15 Jul 2010 12:21:44 -0700
> On Thu, 15 Jul 2010 22:47:33 +0400
> Kulikov Vasiliy <segooon@gmail.com> wrote:
>
>> ipv6_skip_exthdr() can return error code that is below zero.
>> 'offset' is unsigned, so it makes no sense.
>> ipv6_skip_exthdr() returns 'int' so we can painlessly change type of
>> offset to int.
>>
>> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
...
> Acked-by: Stephen Hemminger <shemminger@vyatta.com>
Applied.
^ permalink raw reply
* Re: [PATCH 5/8] drivers: ixgbevf: fix unsigned underflow
From: David Miller @ 2010-07-16 3:28 UTC (permalink / raw)
To: gregory.v.rose
Cc: segooon, kernel-janitors, jeffrey.t.kirsher, eric.dumazet, joe,
netdev
In-Reply-To: <43F901BD926A4E43B106BF17856F0755EA96143E@orsmsx508.amr.corp.intel.com>
From: "Rose, Gregory V" <gregory.v.rose@intel.com>
Date: Thu, 15 Jul 2010 11:52:54 -0700
>>-----Original Message-----
>>From: Kulikov Vasiliy [mailto:segooon@gmail.com]
>>Sent: Thursday, July 15, 2010 11:46 AM
>>To: kernel-janitors@vger.kernel.org
>>Cc: David S. Miller; Kirsher, Jeffrey T; Rose, Gregory V; Eric Dumazet;
>>Joe Perches; netdev@vger.kernel.org
>>Subject: [PATCH 5/8] drivers: ixgbevf: fix unsigned underflow
>>
>>'count' is unsigned. It is initialized to zero, then it can be increased
>>multiple times, and finally it is used in such a way:
>>
>> >>>> count--;
>> |
>> | /* clear timestamp and dma mappings for remaining portion of
>>packet */
>> | while (count >= 0) {
>> | count--;
>> | ...
>> ^
>>If count is zero here (so, it was never increased), we would have a very
>>long loop :)
>>
>>Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
...
> Acked By: Greg Rose <gregory.v.rose@intel.com>
Applied.
^ permalink raw reply
* Re: [PATCH 4/8] drivers: irda: fix sign bug
From: David Miller @ 2010-07-16 3:28 UTC (permalink / raw)
To: segooon; +Cc: kernel-janitors, samuel, kuninori.morimoto.gx, tj, netdev
In-Reply-To: <1279219530-12454-1-git-send-email-segooon@gmail.com>
From: Kulikov Vasiliy <segooon@gmail.com>
Date: Thu, 15 Jul 2010 22:45:29 +0400
> platform_get_irq_byname() can return negative results, it is not seen to
> unsigned irq. Make it signed.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH 3/8] drivers: irda: fix sign bug
From: David Miller @ 2010-07-16 3:28 UTC (permalink / raw)
To: segooon; +Cc: kernel-janitors, samuel, kuninori.morimoto.gx, netdev
In-Reply-To: <1279219494-12408-1-git-send-email-segooon@gmail.com>
From: Kulikov Vasiliy <segooon@gmail.com>
Date: Thu, 15 Jul 2010 22:44:54 +0400
> platform_get_irq_byname() can return negative results, it is not seen to
> unsigned irq. Make it signed.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH 1/2] bnx2: allocate with GFP_KERNEL flag on RX path init
From: David Miller @ 2010-07-16 3:25 UTC (permalink / raw)
To: mchan; +Cc: sgruszka, netdev
In-Reply-To: <C27F8246C663564A84BB7AB3439772421B842BD26F@IRVEXCHCCR01.corp.ad.broadcom.com>
From: "Michael Chan" <mchan@broadcom.com>
Date: Thu, 15 Jul 2010 07:48:40 -0700
> Stanislaw Gruszka wrote:
>
>> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
>> ---
>> @@ -2974,7 +2974,7 @@ bnx2_rx_skb(struct bnx2 *bp, struct
>> bnx2_rx_ring_info *rxr, struct sk_buff *skb,
>> int err;
>> u16 prod = ring_idx & 0xffff;
>>
>> - err = bnx2_alloc_rx_skb(bp, rxr, prod);
>> + err = bnx2_alloc_rx_skb(bp, rxr, prod, GFP_KERNEL);
>
> This should be GFP_ATOMIC since it is called from NAPI softirq
> context.
This fatal issue gives me doubts about whether this patch was even
tested at all.
Immediately the kernel memory allocator should have issued a warning
due to this GFP_KERNEL allocation in a non-sleep'able context.
Stanislaw, how did you test this patch?
^ permalink raw reply
* (unknown),
From: Sgt. Ken Holland @ 2010-07-16 3:18 UTC (permalink / raw)
Hi, Im Sgt. Ken Holland of the US Marine in Ba'qubah,Iraq. Im in
possesion of some funds totalling $15.5M proceeds from a Crude Oil
deal. I would like to enlist your support to transfer these funds.Since
we are working here on Official capacity we cannot keep this funds
thats why we need you. If you are interested, do reach me so that i can
give you further details.
Sgt.Ken Holland
^ permalink raw reply
* Re: [RFC] Question about tcp_sendmsg()
From: David Miller @ 2010-07-16 2:15 UTC (permalink / raw)
To: eric.dumazet; +Cc: ilpo.jarvinen, krkumar2, netdev
In-Reply-To: <1279199688.2496.32.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 15 Jul 2010 15:14:48 +0200
> While investigating for various bug reports in tcp stack, I looked at
> commit def87cf42069a (tcp: Slightly optimize tcp_sendmsg)
>
> One question I have is that the
>
> sg = sk->sk_route_caps & NETIF_F_SG;
>
> is now done at the beginning of tcp_sendmsg(), and kept in sg variable
> for the whole tcp_sendmsg() duration, even if task has to wait for
> space.
>
> Previously sk->sk_route_caps & NETIF_F_SG was done in select_size()
> itself.
>
> I am wondering if this can have a side effect, if SG capability changes
> while a thread has to wait in sk_stream_wait_memory(), and socket route
> changes (sk_route_caps flips NETIF_F_SG bit)
The consequence of this happening would be that we would linearize the
SKB in the device layer transmit path.
Therefore, to me it seems harmless. And since such SG capability
changes are so rare, caching the value in this function as we do now
seems reasonable.
^ permalink raw reply
* Re: [PATCH 1/3] drivers: isdn: use kernel macros to convert hex digit
From: David Miller @ 2010-07-16 2:08 UTC (permalink / raw)
To: andy.shevchenko; +Cc: linux-kernel, isdn, tilman, netdev
In-Reply-To: <1279197440-6585-1-git-send-email-andy.shevchenko@gmail.com>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Thu, 15 Jul 2010 15:37:18 +0300
> Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH 3/3] drivers: isdn: get rid of custom strtoul()
From: David Miller @ 2010-07-16 2:08 UTC (permalink / raw)
To: andy.shevchenko
Cc: linux-kernel, hjlipp, tilman, isdn, gigaset307x-common, netdev
In-Reply-To: <1279197440-6585-3-git-send-email-andy.shevchenko@gmail.com>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Thu, 15 Jul 2010 15:37:20 +0300
> There were two methods isdn_gethex() and isdn_getnum() which are custom
> implementations of strtoul(). Get rid of them in regard to
> strict_strtoul() kernel's function.
>
> Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH 2/3] drivers: isdn: remove custom strtoul()
From: David Miller @ 2010-07-16 2:08 UTC (permalink / raw)
To: andy.shevchenko; +Cc: linux-kernel, isdn, netdev
In-Reply-To: <1279197440-6585-2-git-send-email-andy.shevchenko@gmail.com>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Thu, 15 Jul 2010 15:37:19 +0300
> In this case we safe to use strict_strtoul().
>
> Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH] net/nuc900: enable Mac driver clock
From: David Miller @ 2010-07-16 2:07 UTC (permalink / raw)
To: mcuos.com; +Cc: linux-kernel, netdev
In-Reply-To: <4C3D87FD.6030101@gmail.com>
From: Wan ZongShun <mcuos.com@gmail.com>
Date: Wed, 14 Jul 2010 17:48:45 +0800
> This patch fixed a bug that Mac driver does not work,because I missed the clk enable.
>
> I have ever tested the driver when I submitted previous Mac driver patch,
> and it worked good, since my bootloader has enabled the clock in advance.
>
> But when I try to use other bootloader where clock engine was disabled,the
> Mac driver does not work, so I send this patch to fix this issue.
>
> Signed-off-by: Wan ZongShun <mcuos.com@gmail.com>
Applied, thank you.
^ permalink raw reply
* Re: [PATCH net-next] drivers/net/mlx4: Use %pV, pr_<level>, printk_once
From: David Miller @ 2010-07-16 2:07 UTC (permalink / raw)
To: joe; +Cc: rolandd, yevgenyp, jackm, netdev, linux-kernel
In-Reply-To: <baf5f3949ffd5a48a6f5667b6d6394e6d48c91ca.1278696312.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Sat, 10 Jul 2010 10:22:46 -0700
> Remove near duplication of format string constants by using the newly
> introduced vsprintf extention %pV to reduce text by 20k or so.
>
> $ size drivers/net/mlx4/built-in.o*
> text data bss dec hex filename
> 161367 1866 48784 212017 33c31 drivers/net/mlx4/built-in.o
> 142621 1866 46248 190735 2e90f drivers/net/mlx4/built-in.o.new
>
> Use printk_once as appropriate.
> Convert printks to pr_<level>, some bare printks now use pr_cont.
> Remove now unused #define PFX.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied, thanks Joe.
^ permalink raw reply
* Re: [PATCH 23/25] isdn/hisax: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)
From: David Miller @ 2010-07-16 2:07 UTC (permalink / raw)
To: PeterHuewe; +Cc: kernel-janitors, isdn, tj, netdev, linux-kernel
In-Reply-To: <201007152107.31524.PeterHuewe@gmx.de>
From: Peter Huewe <PeterHuewe@gmx.de>
Date: Thu, 15 Jul 2010 21:07:30 +0200
> From: Peter Huewe <peterhuewe@gmx.de>
>
> This patch converts pci_table entries, where .subvendor=PCI_ANY_ID and
> .subdevice=PCI_ANY_ID, .class=0 and .class_mask=0, to use the
> PCI_VDEVICE macro, and thus improves readability.
>
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Applied.
^ permalink raw reply
* Re: [PATCH 22/25] mISDN: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)
From: David Miller @ 2010-07-16 2:07 UTC (permalink / raw)
To: PeterHuewe
Cc: kernel-janitors, isdn, akpm, jkosina, roel.kluin, netdev,
linux-kernel
In-Reply-To: <201007152105.39404.PeterHuewe@gmx.de>
From: Peter Huewe <PeterHuewe@gmx.de>
Date: Thu, 15 Jul 2010 21:05:38 +0200
> From: Peter Huewe <peterhuewe@gmx.de>
>
> This patch converts pci_table entries, where .subvendor=PCI_ANY_ID and
> .subdevice=PCI_ANY_ID, .class=0 and .class_mask=0, to use the
> PCI_VDEVICE macro, and thus improves readability.
>
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Applied.
^ permalink raw reply
* Re: [PATCH 20/25] mISDN: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)
From: David Miller @ 2010-07-16 2:07 UTC (permalink / raw)
To: PeterHuewe
Cc: kernel-janitors, isdn, akpm, u.kleine-koenig, tj, netdev,
linux-kernel
In-Reply-To: <201007152104.08458.PeterHuewe@gmx.de>
From: Peter Hüwe <PeterHuewe@gmx.de>
Date: Thu, 15 Jul 2010 21:04:07 +0200
> From: Peter Huewe <peterhuewe@gmx.de>
>
> This patch converts pci_table entries, where .subvendor=PCI_ANY_ID and
> .subdevice=PCI_ANY_ID, .class=0 and .class_mask=0, to use the
> PCI_VDEVICE macro, and thus improves readability.
>
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Applied.
^ permalink raw reply
* Re: [PATCH 21/25] isdn/hardware/eicon: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)
From: David Miller @ 2010-07-16 2:07 UTC (permalink / raw)
To: PeterHuewe; +Cc: kernel-janitors, mac, isdn, arnd, netdev, linux-kernel
In-Reply-To: <201007152104.45958.PeterHuewe@gmx.de>
From: Peter Huewe <PeterHuewe@gmx.de>
Date: Thu, 15 Jul 2010 21:04:45 +0200
> From: Peter Huewe <peterhuewe@gmx.de>
>
> This patch converts pci_table entries, where .subvendor=PCI_ANY_ID and
> .subdevice=PCI_ANY_ID, .class=0 and .class_mask=0, to use the
> PCI_VDEVICE macro, and thus improves readability.
>
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Applied.
^ permalink raw reply
* Re: [PATCH 19/25] isdn/hardware/mISDN: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)
From: David Miller @ 2010-07-16 2:06 UTC (permalink / raw)
To: PeterHuewe
Cc: kernel-janitors, isdn, u.kleine-koenig, tj, jkosina, netdev,
linux-kernel
In-Reply-To: <201007152102.38008.PeterHuewe@gmx.de>
From: Peter Huewe <PeterHuewe@gmx.de>
Date: Thu, 15 Jul 2010 21:02:36 +0200
> From: Peter Huewe <peterhuewe@gmx.de>
>
> This patch converts pci_table entries, where .subvendor=PCI_ANY_ID and
> .subdevice=PCI_ANY_ID, .class=0 and .class_mask=0, to use the
> PCI_VDEVICE macro, and thus improves readability.
>
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Applied.
^ permalink raw reply
* Re: [PATCH 09/25] atm: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)
From: David Miller @ 2010-07-16 2:06 UTC (permalink / raw)
To: PeterHuewe
Cc: kernel-janitors, chas, hsweeten, tj, linux-atm-general, netdev,
linux-kernel
In-Reply-To: <201007152048.27535.PeterHuewe@gmx.de>
From: Peter Huewe <PeterHuewe@gmx.de>
Date: Thu, 15 Jul 2010 20:48:26 +0200
> From: Peter Huewe <peterhuewe@gmx.de>
>
> This patch converts pci_table entries, where .subvendor=PCI_ANY_ID and
> .subdevice=PCI_ANY_ID, .class=0 and .class_mask=0, to use the
> PCI_VDEVICE macro, and thus improves readability.
>
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Applied.
^ permalink raw reply
* Re: [PATCH 08/25] atm: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)
From: David Miller @ 2010-07-16 2:06 UTC (permalink / raw)
To: PeterHuewe
Cc: kernel-janitors, chas, hsweeten, tj, linux-atm-general, netdev,
linux-kernel
In-Reply-To: <201007152045.33543.PeterHuewe@gmx.de>
From: Peter Huewe <PeterHuewe@gmx.de>
Date: Thu, 15 Jul 2010 20:45:32 +0200
> From: Peter Huewe <peterhuewe@gmx.de>
>
> This patch converts pci_table entries, where .subvendor=PCI_ANY_ID and
> .subdevice=PCI_ANY_ID, .class=0 and .class_mask=0, to use the
> PCI_VDEVICE macro, and thus improves readability.
>
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Applied.
^ permalink raw reply
* Re: [PATCH 10/25] atm: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)
From: David Miller @ 2010-07-16 2:06 UTC (permalink / raw)
To: PeterHuewe
Cc: kernel-janitors, chas, tj, linux-atm-general, netdev,
linux-kernel
In-Reply-To: <201007152049.33395.PeterHuewe@gmx.de>
From: Peter Huewe <PeterHuewe@gmx.de>
Date: Thu, 15 Jul 2010 20:49:32 +0200
> From: Peter Huewe <peterhuewe@gmx.de>
>
> This patch converts pci_table entries, where .subvendor=PCI_ANY_ID and
> .subdevice=PCI_ANY_ID, .class=0 and .class_mask=0, to use the
> PCI_VDEVICE macro, and thus improves readability.
>
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Applied.
^ permalink raw reply
* Re: [PATCH 07/25] atm: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)
From: David Miller @ 2010-07-16 2:06 UTC (permalink / raw)
To: PeterHuewe
Cc: kernel-janitors, chas, roel.kluin, eric.dumazet, tj,
linux-atm-general, netdev, linux-kernel
In-Reply-To: <201007152044.12653.PeterHuewe@gmx.de>
From: Peter Huewe <PeterHuewe@gmx.de>
Date: Thu, 15 Jul 2010 20:44:11 +0200
> From: Peter Huewe <peterhuewe@gmx.de>
>
> This patch converts pci_table entries, where .subvendor=PCI_ANY_ID and
> .subdevice=PCI_ANY_ID, .class=0 and .class_mask=0, to use the
> PCI_VDEVICE macro, and thus improves readability.
>
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Applied.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox