* Re: [net-2.6 2/2] bnx2x: Update bnx2x version to 1.52.53-4
From: David Miller @ 2010-08-19 6:41 UTC (permalink / raw)
To: yaniv.home; +Cc: netdev
In-Reply-To: <1281976447.3997.18.camel@lb-tlvb-yanivr.il.broadcom.com>
From: "Yaniv Rosner" <yaniv.home@broadcom.com>
Date: Mon, 16 Aug 2010 19:34:07 +0300
> Update bnx2x version to 1.52.53-4
>
> Signed-off-by: Yaniv Rosner <yanivr@broadcom.com>
> Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Applied.
^ permalink raw reply
* Re: via-rhine interrupts
From: David Miller @ 2010-08-19 6:49 UTC (permalink / raw)
To: jarkao2; +Cc: ruzicka.jakub, netdev
In-Reply-To: <20100815200431.GA4993@del.dom.local>
From: Jarek Poplawski <jarkao2@gmail.com>
Date: Sun, 15 Aug 2010 22:04:31 +0200
> I've just tested it using a simplistic patch below, which skips
> some napi receiving by doing it only every second jiffie (on even
> ones), and I've got around 30% less interrupts from via-rhine,
> which seems to suggest napi works OK, but there is too low
> traffic (or too fast soft interrupt handling) to affect hard
> interrupts. (Btw, probably CONFIG_HZ can matter here a bit too.
> I tested with 1000.)
100Mbit on any modern system isn't going to trigger NAPI much at all
even with near full link utilization.
The simply cpu processes the packets too fast for them to gather up
much at all.
Some improvement in polling could be gained if the via-rhine has some
HW interrupt mitigation settings. However after a quick perusal of
the driver I don't see anything about this. The mitigation ethtool
ops aren't implemented either, so I'm not optimistic :-)
^ permalink raw reply
* Re: [PATCH] tcp: allow effective reduction of TCP's rcv-buffer via setsockopt
From: Hagen Paul Pfeifer @ 2010-08-19 6:58 UTC (permalink / raw)
To: David Miller; +Cc: netdev, kaber, eric.dumazet, ilpo.jarvinen
In-Reply-To: <20100818.233337.52187393.davem@davemloft.net>
On Wed, 18 Aug 2010 23:33:37 -0700 (PDT), David Miller wrote:
> From: Hagen Paul Pfeifer <hagen@jauu.net>
> Date: Sun, 15 Aug 2010 21:36:16 +0200
>
>> +
>> + if (sk->sk_userlocks & SOCK_RCVBUF_LOCK &&
>> + (req->window_clamp > tcp_full_space(sk) || req->window_clamp ==
0))
>> + req->window_clamp = tcp_full_space(sk);
>> +
>
> Logically the patch looks fine, but please fix the indentation of the
> second line of the two new if() statements in this patch, the
> second line's first character should line up with the character
> right after the openning "(" on the previous line.
Sorry Dave, I played with my vim settings ... I will resubmit the patch.
;-)
^ permalink raw reply
* Re: [PATCH] greth: Use return value of register_netdev
From: David Miller @ 2010-08-19 7:05 UTC (permalink / raw)
To: tklauser; +Cc: kristoffer, netdev, kernel-janitors
In-Reply-To: <1282061484-19377-1-git-send-email-tklauser@distanz.ch>
From: Tobias Klauser <tklauser@distanz.ch>
Date: Tue, 17 Aug 2010 18:11:24 +0200
> Use the return value provided by register_netdev on error instead of
> hard setting it to -ENOMEM.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Applied.
^ permalink raw reply
* Re: [PATCH] tehuti: Use net_device_stats from struct net_device
From: David Miller @ 2010-08-19 7:06 UTC (permalink / raw)
To: tklauser; +Cc: baum, andy, netdev, kernel-janitors
In-Reply-To: <1282061577-19484-1-git-send-email-tklauser@distanz.ch>
From: Tobias Klauser <tklauser@distanz.ch>
Date: Tue, 17 Aug 2010 18:12:57 +0200
> struct net_device has its own struct net_device_stats member, so use
> this one instead of a private copy in the bdx_priv struct.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Please delete the bdx_get_stats() function and the assignment of
it into the netdev ops, as it is now superfluous.
Thanks.
^ permalink raw reply
* Re: [PATCH] sunhme: Use return value of register_netdev
From: David Miller @ 2010-08-19 7:06 UTC (permalink / raw)
To: tklauser; +Cc: netdev, kernel-janitors
In-Reply-To: <1282061585-19527-1-git-send-email-tklauser@distanz.ch>
From: Tobias Klauser <tklauser@distanz.ch>
Date: Tue, 17 Aug 2010 18:13:05 +0200
> Use the return value provided by register_netdev on error instead of
> using a previously set value.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Applied.
^ permalink raw reply
* Re: [PATCH] ep93xx_eth: Use net_device_stats from struct net_device
From: David Miller @ 2010-08-19 7:07 UTC (permalink / raw)
To: tklauser; +Cc: kernel, netdev, kernel-janitors
In-Reply-To: <1282061678-19590-1-git-send-email-tklauser@distanz.ch>
From: Tobias Klauser <tklauser@distanz.ch>
Date: Tue, 17 Aug 2010 18:14:38 +0200
> struct net_device has its own struct net_device_stats member, so use
> this one instead of a private copy in the ep93xx_priv struct.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Please delete the ep93xx_get_stats() function and the assignment of
it into the netdev ops, as it is now superfluous.
Thanks.
^ permalink raw reply
* Re: [PATCH net-next 1/2] drivers/net/sungem: Use netdev_<level>, netif_<level> and pr_<level>
From: David Miller @ 2010-08-19 7:07 UTC (permalink / raw)
To: joe; +Cc: netdev, linux-kernel
In-Reply-To: <1282067705-14800-1-git-send-email-joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Tue, 17 Aug 2010 10:55:04 -0700
> Use the current logging message styles.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next-2.6] net: simplify flags for tx timestamping
From: David Miller @ 2010-08-19 7:07 UTC (permalink / raw)
To: socketcan; +Cc: patrick.ohly, netdev
In-Reply-To: <4C6ADC02.5000305@hartkopp.net>
From: Oliver Hartkopp <socketcan@hartkopp.net>
Date: Tue, 17 Aug 2010 20:59:14 +0200
> This patch removes the abstraction introduced by the union skb_shared_tx in
> the shared skb data.
>
> The access of the different union elements at several places led to some
> confusion about accessing the shared tx_flags e.g. in skb_orphan_try().
>
> http://marc.info/?l=linux-netdev&m=128084897415886&w=2
>
> Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Applied, thanks for following up on this Oliver.
^ permalink raw reply
* Re: [PATCH net-next 2/2] drivers/net/sunvnet.c: Use pr_<level> and netdev_<level>
From: David Miller @ 2010-08-19 7:07 UTC (permalink / raw)
To: joe; +Cc: netdev, linux-kernel
In-Reply-To: <1282067705-14800-2-git-send-email-joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Tue, 17 Aug 2010 10:55:05 -0700
> Use the current message logging styles.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply
* Re: [PATCH] ibmveth: Fix opps during MTU change on an active device
From: David Miller @ 2010-08-19 7:10 UTC (permalink / raw)
To: rcj; +Cc: netdev, santil, brking, rfolco
In-Reply-To: <20100817191543.GA5016@linux.vnet.ibm.com>
From: Robert Jennings <rcj@linux.vnet.ibm.com>
Date: Tue, 17 Aug 2010 14:15:45 -0500
> This fixes the following opps which can occur when trying to deallocate
> receive buffer pools when changing the MTU of an active ibmveth device.
...
> Reported-by: Rafael Camarda Silva Folco <rfolco@linux.vnet.ibm.com>
> Signed-off-by: Robert Jennings <rcj@linux.vnet.ibm.com>
Applied, thank you.
^ permalink raw reply
* Re: [PATCH v4] ether1: Use net_device_stats from struct net_device
From: David Miller @ 2010-08-19 7:12 UTC (permalink / raw)
To: tklauser
Cc: linux, netdev, linux-arm-kernel, kernel-janitors, shemminger,
eric.dumazet, error27
In-Reply-To: <1282198504-4009-1-git-send-email-tklauser@distanz.ch>
From: Tobias Klauser <tklauser@distanz.ch>
Date: Thu, 19 Aug 2010 08:15:04 +0200
> struct net_device has its own struct net_device_stats member, so use
> this one instead of a private copy in the ether1_priv struct. As the new
> ndo_get_stats function would just return dev->stats we can omit it. This
> patch also removes an incorrect memset of the stats on open.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Applied.
^ permalink raw reply
* Re: [PATCH v4] ether3: Use net_device_stats from struct net_device
From: David Miller @ 2010-08-19 7:13 UTC (permalink / raw)
To: tklauser
Cc: linux, netdev, linux-arm-kernel, kernel-janitors, shemminger,
eric.dumazet, error27
In-Reply-To: <1282198531-4157-1-git-send-email-tklauser@distanz.ch>
From: Tobias Klauser <tklauser@distanz.ch>
Date: Thu, 19 Aug 2010 08:15:31 +0200
> struct net_device has its own struct net_device_stats member, so use
> this one instead of a private copy in the ether1_priv struct. As the new
> ndo_get_stats function would just return dev->stats we can omit it. This
> patch also removes an incorrect memset of the stats on open.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
Applied, thanks.
^ permalink raw reply
* Re: [PATCH net-next-2.6] atm: remove a net_device_stats clear
From: David Miller @ 2010-08-19 7:15 UTC (permalink / raw)
To: eric.dumazet
Cc: shemminger, tklauser, linux, netdev, linux-arm-kernel,
kernel-janitors, error27
In-Reply-To: <1282164274.2328.2.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 18 Aug 2010 22:44:34 +0200
> Le mercredi 18 août 2010 à 13:10 -0700, David Miller a écrit :
>> Yep, both the ether1 and ether3 patch have this problem. Looks
>> like we'll see v4 coming some :-)
>
> To be fair, we accepted some bits like that in the past ;)
Yes, but let's nip it in the butt immediately when we do
notice it :-)
> [PATCH net-next-2.6] atm: remove a net_device_stats clear
>
> No need to clear device stats in lec_open()
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks!
^ permalink raw reply
* Re: [PATCH net-next-2.6] vxge: Implement 64bit stats
From: David Miller @ 2010-08-19 7:17 UTC (permalink / raw)
To: jon.mason
Cc: eric.dumazet, netdev, Ramkrishna.Vepa, Sivakumar.Subramani,
Sreenivasa.Honnur
In-Reply-To: <20100818225330.GJ17009@exar.com>
From: Jon Mason <jon.mason@exar.com>
Date: Wed, 18 Aug 2010 17:53:31 -0500
> On Wed, Aug 18, 2010 at 06:42:54AM -0700, Eric Dumazet wrote:
>> vxge_get_stats() is racy, since it clears a block of memory (net_stats)
>> possibly still used by other cpus.
>>
>> We can update this driver to full 64bit stats, since ndo_get_stats64()
>> provides a private block to store results, and driver maintains 64bit
>> counters already.
>>
>> We also remove net_stats field from struct vxge_sw_stats
>>
>> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> Acked-by: Jon Mason <jon.mason@exar.com>
Applied, thanks everyone.
^ permalink raw reply
* Re: [PATCH net-next-2.6] slip: fix get_stats() method
From: David Miller @ 2010-08-19 7:17 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
In-Reply-To: <1282137188.2194.74.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 18 Aug 2010 15:13:08 +0200
> Use integrated net_device_stats instead of a static one, and make sure
> no transient values are feeded. ndo_get_stats() can be called by
> concurrent cpus.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks Eric.
It's pretty freaky how, even to this day, we keep finding these static
function local variables in code which potentially runs multithreaded.
^ permalink raw reply
* Re: [PATCH] vlan: Match underlying dev carrier on vlan add
From: David Miller @ 2010-08-19 7:27 UTC (permalink / raw)
To: kernel; +Cc: netdev
In-Reply-To: <20100818044508.GA23361@linuxace.com>
From: Phil Oester <kernel@linuxace.com>
Date: Tue, 17 Aug 2010 21:45:08 -0700
> When adding a new vlan, if the underlying interface has no carrier,
> then the newly added vlan interface should also have no carrier.
> At present, this is not true - the newly added vlan is added with
> carrier up. Fix by checking state of real device.
>
> Signed-off-by: Phil Oester <kernel@linuxace.com>
Applied, thanks Phil.
^ permalink raw reply
* Re: [PATCH 1/2] netxen: fix inconsistent lock state
From: David Miller @ 2010-08-19 7:28 UTC (permalink / raw)
To: amit.salecha; +Cc: netdev, ameen.rahman
In-Reply-To: <1282114312-23500-1-git-send-email-amit.salecha@qlogic.com>
From: Amit Kumar Salecha <amit.salecha@qlogic.com>
Date: Tue, 17 Aug 2010 23:51:51 -0700
> Spin lock rds_ring->lock is used in poll routine, so other users should
> use spin_lock_bh(). While posting rx buffers from netxen_nic_attach,
> rds_ring->lock is not required, so cleaning it instead of fixing it by
> spin_lock_bh().
>
> Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com>
Applied.
^ permalink raw reply
* Re: [PATCH 2/2] netxen: update version 4.0.74
From: David Miller @ 2010-08-19 7:28 UTC (permalink / raw)
To: amit.salecha; +Cc: netdev, ameen.rahman
In-Reply-To: <1282114312-23500-2-git-send-email-amit.salecha@qlogic.com>
From: Amit Kumar Salecha <amit.salecha@qlogic.com>
Date: Tue, 17 Aug 2010 23:51:52 -0700
> Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com>
Applied.
^ permalink raw reply
* [PATCH] net: sh_eth: remove unused variable
From: Kuninori Morimoto @ 2010-08-19 7:35 UTC (permalink / raw)
To: Linux-Net; +Cc: Samuel Ortiz, David S. Miller, shimoda
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
drivers/net/sh_eth.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/sh_eth.c b/drivers/net/sh_eth.c
index f5a9eb1..79fd02b 100644
--- a/drivers/net/sh_eth.c
+++ b/drivers/net/sh_eth.c
@@ -1437,7 +1437,7 @@ static const struct net_device_ops sh_eth_netdev_ops = {
static int sh_eth_drv_probe(struct platform_device *pdev)
{
- int ret, i, devno = 0;
+ int ret, devno = 0;
struct resource *res;
struct net_device *ndev = NULL;
struct sh_eth_private *mdp;
--
1.7.0.4
^ permalink raw reply related
* Re: [PATCH] net: sh_eth: remove unused variable
From: David Miller @ 2010-08-19 7:39 UTC (permalink / raw)
To: kuninori.morimoto.gx; +Cc: netdev, samuel, yoshihiro.shimoda.uh
In-Reply-To: <w3pwrrnt5qq.wl%kuninori.morimoto.gx@renesas.com>
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Date: Thu, 19 Aug 2010 16:35:09 +0900 (JST)
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Applied, thank you.
^ permalink raw reply
* Re: [PATCH] irda: fix a race in irlan_eth_xmit()
From: David Miller @ 2010-08-19 7:42 UTC (permalink / raw)
To: eric.dumazet; +Cc: samuel, netdev
In-Reply-To: <1282127083.2194.45.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 18 Aug 2010 12:24:43 +0200
> After skb is queued, its illegal to dereference it.
>
> Cache skb->len into a temporary variable.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH] qlnic: fix a race in qlcnic_get_stats()
From: David Miller @ 2010-08-19 7:44 UTC (permalink / raw)
To: eric.dumazet; +Cc: amit.salecha, netdev
In-Reply-To: <1282128168.2194.49.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 18 Aug 2010 12:42:48 +0200
> Dont clear netdev->stats, it might give transient wrong values to
> concurrent stat readers.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH] netxen: fix a race in netxen_nic_get_stats()
From: David Miller @ 2010-08-19 7:44 UTC (permalink / raw)
To: eric.dumazet; +Cc: amit.salecha, netdev
In-Reply-To: <1282134570.2194.53.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 18 Aug 2010 14:29:30 +0200
> Dont clear netdev->stats, it might give transient wrong values to
> concurrent stat readers.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Also applied, thanks Eric.
^ permalink raw reply
* Re: [PATCH] ll_temac: Fix poll implementation
From: David Miller @ 2010-08-19 7:48 UTC (permalink / raw)
To: monstr; +Cc: glikely, netdev, rusty
In-Reply-To: <1282127194-4185-1-git-send-email-monstr@monstr.eu>
From: Michal Simek <monstr@monstr.eu>
Date: Wed, 18 Aug 2010 12:26:34 +0200
> Functions ll_temac_rx_irq and ll_temac_tx_irq
> have pointer to net_device as second parameter not
> pointer to temac_local.
>
> Signed-off-by: Michal Simek <monstr@monstr.eu>
Applied, thanks a lot.
I can't count how many times this kind of error has been
introduced. It's of cource because the handle passed to
IRQ handlers is an opaque void pointer, so if the underlying
type gets changed there is absolutely no type checking done
against by-hand calls of the IRQ handler.
Rusty Russell was, if I remember correctly, doing some work
to correct this such that IRQ handlers could in fact have
some proper typing in their handlers. Or maybe that was for
timer handlers?
Anyways that kind of thing would help here.
Rusty?
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox