* Re: [PATCH] xfrm: use gre key as flow upper protocol info
From: David Miller @ 2010-11-15 18:43 UTC (permalink / raw)
To: timo.teras; +Cc: netdev, herbert
In-Reply-To: <1288795298-323-1-git-send-email-timo.teras@iki.fi>
From: Timo Teräs <timo.teras@iki.fi>
Date: Wed, 3 Nov 2010 16:41:38 +0200
> The GRE Key field is intended to be used for identifying an individual
> traffic flow within a tunnel. It is useful to be able to have XFRM
> policy selector matches to have different policies for different
> GRE tunnels.
>
> Signed-off-by: Timo Teräs <timo.teras@iki.fi>
I'll apply this to net-next-2.6, thanks.
^ permalink raw reply
* network device reference leak with net-next
From: Stephen Hemminger @ 2010-11-15 18:56 UTC (permalink / raw)
To: netdev
This is a new regression (doesn't exist with 2.6.36)
If I shutdown KVM instance with Virt manager, the virtual
interfaces in the bridge aren't getting cleaned up because
of leftover reference count.
[ 9781.050474] unregister_netdevice: waiting for vnet1 to become free. Usage count = 1
[ 9785.143400] virbr4: port 3(vnet6) entering forwarding state
[ 9785.177194] virbr4: port 3(vnet6) entering disabled state
[ 9785.201129] device vnet6 left promiscuous mode
[ 9785.201135] virbr4: port 3(vnet6) entering disabled state
[ 9791.286950] unregister_netdevice: waiting for vnet1 to become free. Usage count = 1
[ 9795.461526] unregister_netdevice: waiting for vnet6 to become free. Usage count = 1
[ 9801.523398] unregister_netdevice: waiting for vnet1 to become free. Usage count = 1
^ permalink raw reply
* Re: [PATCH 0/2] net: Changes in queue allocation and freeing
From: David Miller @ 2010-11-15 18:58 UTC (permalink / raw)
To: therbert; +Cc: netdev
In-Reply-To: <alpine.DEB.1.00.1011091240470.18565@pokey.mtv.corp.google.com>
From: Tom Herbert <therbert@google.com>
Date: Tue, 9 Nov 2010 12:47:26 -0800 (PST)
> Changes to both RX and TX queue allocation. In both cases allocate
> in alloc_netdev_mq and free in free_netdev. For RX the reference
> couting also changed, the device reference count can now be used.
Both applied, with the comment removal added as promised.
I assume you'll spin a new version of the XPS patches
against this?
Thanks!
^ permalink raw reply
* Re: [PATCH v2] drivers/net/tile/: on-chip network drivers for the tile architecture
From: Chris Metcalf @ 2010-11-15 19:01 UTC (permalink / raw)
To: David Miller; +Cc: sam, linux-kernel, netdev, shemminger, eric.dumazet
In-Reply-To: <20101115.102210.242124777.davem@davemloft.net>
On 11/15/2010 1:22 PM, David Miller wrote:
> Also please fix the date on your computer, or please change whatever
> it is that makes your patch postings use a date in the past.
Oops! I put together my email with git format-patch, and edited the
"Reference:" and "In-Reply-To:" headers to point to my previous patch, and
I apparently pulled in the Date field from that previous email as well. I
think that was likely the only instance of a bad date on patch postings
from me, but I'll be more vigilant going forwards.
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
^ permalink raw reply
* Re: network device reference leak with net-next
From: Eric Dumazet @ 2010-11-15 19:04 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev
In-Reply-To: <20101115105646.0cc823ce@nehalam>
Le lundi 15 novembre 2010 à 10:56 -0800, Stephen Hemminger a écrit :
> This is a new regression (doesn't exist with 2.6.36)
>
> If I shutdown KVM instance with Virt manager, the virtual
> interfaces in the bridge aren't getting cleaned up because
> of leftover reference count.
>
>
> [ 9781.050474] unregister_netdevice: waiting for vnet1 to become free. Usage count = 1
> [ 9785.143400] virbr4: port 3(vnet6) entering forwarding state
> [ 9785.177194] virbr4: port 3(vnet6) entering disabled state
> [ 9785.201129] device vnet6 left promiscuous mode
> [ 9785.201135] virbr4: port 3(vnet6) entering disabled state
> [ 9791.286950] unregister_netdevice: waiting for vnet1 to become free. Usage count = 1
> [ 9795.461526] unregister_netdevice: waiting for vnet6 to become free. Usage count = 1
> [ 9801.523398] unregister_netdevice: waiting for vnet1 to become free. Usage count = 1
> --
Is the refcount stay forever to 1, or eventually reaches 0 ?
^ permalink raw reply
* Re: net-next-2.6 [PATCH 0/6]: dccp ccid-2: Ack Vector patch set second/concluding part II
From: David Miller @ 2010-11-15 19:04 UTC (permalink / raw)
To: gerrit; +Cc: dccp, netdev
In-Reply-To: <1289802547-5617-1-git-send-email-gerrit@erg.abdn.ac.uk>
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Date: Mon, 15 Nov 2010 07:29:01 +0100
> Hi Dave,
>
> please find attached part II of the Ack Vector patch set, concluding
> the submission (part I) begun last week.
>
> Patch #1: algorithm to update/clear Ack Vector state in the circular buffer.
> Patch #2: algorithm to register new packets as received in the circular buffer.
> Patch #3: consolidates/updates Ack Vector processing in the main DCCP module.
> Patch #4: schedules DCCP-Sync in case there is no space left for Ack Vectors.
> Patch #5: removes the replaced parts of the old Ack Vector infrastructure.
> Patch #6: Ack Vectors provide information specific to CCIDs; this patch thus
> moves Ack Vector processing from main DCCP into the CCID module(s).
>
>
> I have also placed this in into a fresh (today's) copy of net-next-2.6, on
>
> git://eden-feed.erg.abdn.ac.uk/net-next-2.6 [subtree 'dccp']
Pulled, thanks a lot Gerrit.
Some of the new functions you added had some coding style quirks,
for example the openning brace for dccp_ackvec_clear_state()
has an unnecessary space before it on that line.
Please fix those sorts of things up, thanks.
^ permalink raw reply
* Re: [PATCH 39/44] include/net/caif/cfctrl.h: Remove unnecessary semicolons
From: David Miller @ 2010-11-15 19:07 UTC (permalink / raw)
To: joe; +Cc: trivial, sjur.brandeland, netdev, linux-kernel
In-Reply-To: <35914cfea1bd0ab3963e632d02b1fdd52a9d2bc8.1289789605.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Sun, 14 Nov 2010 19:04:58 -0800
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply
* Re: [PATCH 41/44] net/ipv6/mcast.c: Remove unnecessary semicolons
From: David Miller @ 2010-11-15 19:07 UTC (permalink / raw)
To: joe; +Cc: trivial, kuznet, pekkas, jmorris, yoshfuji, kaber, netdev,
linux-kernel
In-Reply-To: <1f3e1f7e454f3c62b66fc5f3e1e1ed90d62b7fb0.1289789605.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Sun, 14 Nov 2010 19:05:00 -0800
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply
* Re: [PATCH 38/44] include/linux/if_macvlan.h: Remove unnecessary semicolons
From: David Miller @ 2010-11-15 19:07 UTC (permalink / raw)
To: joe; +Cc: trivial, kaber, netdev, linux-kernel
In-Reply-To: <186ca914f887b2354ea3178696edc81cacbb28c6.1289789605.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Sun, 14 Nov 2010 19:04:57 -0800
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply
* Re: [PATCH 15/44] drivers/net/vxge: Remove unnecessary semicolons
From: David Miller @ 2010-11-15 19:07 UTC (permalink / raw)
To: joe
Cc: trivial, ramkrishna.vepa, sivakumar.subramani, sreenivasa.honnur,
jon.mason, netdev, linux-kernel
In-Reply-To: <e86e79a18106cc38715136bfb2e880b38f5ac764.1289789604.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Sun, 14 Nov 2010 19:04:34 -0800
> Signed-off-by: Joe Perches <joe@perches.com>
Not applicable to net-next-2.6
^ permalink raw reply
* Re: [BUG]: skge not working (as module) in 2.6.37-rc1
From: Maciej Rutecki @ 2010-11-15 19:07 UTC (permalink / raw)
To: Marin Mitov
Cc: Stephen Hemminger, Stephen Hemminger, netdev, linux-kernel,
David S. Miller
In-Reply-To: <201011150555.59407.mitov@issp.bas.bg>
On poniedziałek, 15 listopada 2010 o 04:55:58 Marin Mitov wrote:
> On Sunday, November 14, 2010 09:45:14 pm Maciej Rutecki wrote:
> > On niedziela, 7 listopada 2010 o 22:45:52 Marin Mitov wrote:
> > > Hi Stephen,
> > >
> > > skge as in 2.6.36 (and before) is working.
> >
> > > As in 2.6.37-rc1 it is not:
> > I created a Bugzilla entry at
> > https://bugzilla.kernel.org/show_bug.cgi?id=22892
> > for your bug report, please add your address to the CC list in there,
> > thanks!
>
> Hi Maciej,
>
> It is already corrected, as in 2.6.37-rc1-git11.
>
> Thanks.
>
> Marin Mitov
Thanks for the update.
Regards
--
Maciej Rutecki
http://www.maciek.unixy.pl
^ permalink raw reply
* Re: [PATCH 18/44] drivers/net/cnic.c: Remove unnecessary semicolons
From: David Miller @ 2010-11-15 19:08 UTC (permalink / raw)
To: joe; +Cc: trivial, netdev, linux-kernel
In-Reply-To: <950331e47b16c2ad28d73502f30f5a0f017b5493.1289789604.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Sun, 14 Nov 2010 19:04:37 -0800
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply
* Re: [PATCH 07/44] drivers/isdn: Remove unnecessary semicolons
From: David Miller @ 2010-11-15 19:08 UTC (permalink / raw)
To: joe; +Cc: trivial, isdn, netdev, linux-kernel
In-Reply-To: <c7a38f65340aafb208d50fc3a781602c07aebb0c.1289789604.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Sun, 14 Nov 2010 19:04:26 -0800
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply
* Re: [PATCH 14/44] drivers/net/ixgbe: Remove unnecessary semicolons
From: David Miller @ 2010-11-15 19:08 UTC (permalink / raw)
To: joe
Cc: trivial, e1000-devel, bruce.w.allan, jesse.brandeburg,
linux-kernel, gregory.v.rose, john.ronciak, jeffrey.t.kirsher,
netdev
In-Reply-To: <7d2c334daa75c5221946a17d45c9de1901cf06e7.1289789604.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Sun, 14 Nov 2010 19:04:33 -0800
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
------------------------------------------------------------------------------
Centralized Desktop Delivery: Dell and VMware Reference Architecture
Simplifying enterprise desktop deployment and management using
Dell EqualLogic storage and VMware View: A highly scalable, end-to-end
client virtualization framework. Read more!
http://p.sf.net/sfu/dell-eql-dev2dev
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
^ permalink raw reply
* Re: [PATCH 13/44] drivers/net/e1000e: Remove unnecessary semicolons
From: David Miller @ 2010-11-15 19:08 UTC (permalink / raw)
To: joe
Cc: trivial, e1000-devel, bruce.w.allan, jesse.brandeburg,
linux-kernel, gregory.v.rose, john.ronciak, jeffrey.t.kirsher,
netdev
In-Reply-To: <e5cf92d50de7924930d660a5865c3d60d9cd9dc5.1289789604.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Sun, 14 Nov 2010 19:04:32 -0800
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
------------------------------------------------------------------------------
Centralized Desktop Delivery: Dell and VMware Reference Architecture
Simplifying enterprise desktop deployment and management using
Dell EqualLogic storage and VMware View: A highly scalable, end-to-end
client virtualization framework. Read more!
http://p.sf.net/sfu/dell-eql-dev2dev
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
^ permalink raw reply
* Re: [PATCH 12/44] drivers/net/bnx2x: Remove unnecessary semicolons
From: David Miller @ 2010-11-15 19:08 UTC (permalink / raw)
To: joe; +Cc: trivial, eilong, netdev, linux-kernel
In-Reply-To: <2bfaf1f1fe5d503a8a386a433b5187997819d771.1289789604.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Sun, 14 Nov 2010 19:04:31 -0800
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply
* Re: network device reference leak with net-next
From: Stephen Hemminger @ 2010-11-15 19:10 UTC (permalink / raw)
To: Eric Dumazet; +Cc: netdev
In-Reply-To: <1289847840.2607.120.camel@edumazet-laptop>
On Mon, 15 Nov 2010 20:04:00 +0100
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Le lundi 15 novembre 2010 à 10:56 -0800, Stephen Hemminger a écrit :
> > This is a new regression (doesn't exist with 2.6.36)
> >
> > If I shutdown KVM instance with Virt manager, the virtual
> > interfaces in the bridge aren't getting cleaned up because
> > of leftover reference count.
> >
> >
> > [ 9781.050474] unregister_netdevice: waiting for vnet1 to become free. Usage count = 1
> > [ 9785.143400] virbr4: port 3(vnet6) entering forwarding state
> > [ 9785.177194] virbr4: port 3(vnet6) entering disabled state
> > [ 9785.201129] device vnet6 left promiscuous mode
> > [ 9785.201135] virbr4: port 3(vnet6) entering disabled state
> > [ 9791.286950] unregister_netdevice: waiting for vnet1 to become free. Usage count = 1
> > [ 9795.461526] unregister_netdevice: waiting for vnet6 to become free. Usage count = 1
> > [ 9801.523398] unregister_netdevice: waiting for vnet1 to become free. Usage count = 1
> > --
>
> Is the refcount stay forever to 1, or eventually reaches 0 ?
>
>
>
Stays 1 for as long as I waited about 10 minutes
--
^ permalink raw reply
* Re: [PATCH 0/5] bridge RCU patches (rev2)
From: David Miller @ 2010-11-15 19:13 UTC (permalink / raw)
To: shemminger; +Cc: netdev
In-Reply-To: <20101115163809.215552143@vyatta.com>
All applied to net-next-2.6
^ permalink raw reply
* Re: [PATCH] hso: Fix unused variable warning
From: David Miller @ 2010-11-15 19:13 UTC (permalink / raw)
To: alan; +Cc: netdev
In-Reply-To: <20101115173038.6846.72062.stgit@localhost.localdomain>
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Date: Mon, 15 Nov 2010 17:30:42 +0000
> From: Alan Cox <alan@linux.intel.com>
>
> Fallout from the TIOCGICOUNT work
>
> Signed-off-by: Alan Cox <alan@linux.intel.com>
Applied to net-next-2.6, thanks.
^ permalink raw reply
* Re: [net-next-2.6 PATCH] enic: Fix build warnings
From: David Miller @ 2010-11-15 19:13 UTC (permalink / raw)
To: vkolluri; +Cc: netdev, roprabhu, dwang2
In-Reply-To: <20101115180955.5779.32244.stgit@savbu-pc100.cisco.com>
From: Vasanthy Kolluri <vkolluri@cisco.com>
Date: Mon, 15 Nov 2010 10:09:55 -0800
> From: Vasanthy Kolluri <vkolluri@cisco.com>
>
> Fix data type of argument passed to pci_alloc_consistent and pci_free_consistent routines.
>
> Signed-off-by: Vasanthy Kolluri <vkolluri@cisco.com>
> Signed-off-by: Roopa Prabhu <roprabhu@cisco.com>
> Signed-off-by: David Wang <dwang2@cisco.com>
Applied, thank you.
^ permalink raw reply
* Re: ethtool maintenance
From: Jeff Garzik @ 2010-11-15 19:16 UTC (permalink / raw)
To: Ben Hutchings; +Cc: NetDev, David Miller
In-Reply-To: <1289832387.2586.10.camel@bwh-desktop>
[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]
On 11/15/2010 09:46 AM, Ben Hutchings wrote:
> On Sat, 2010-11-13 at 14:30 +0000, Ben Hutchings wrote:
>> On Sat, 2010-11-13 at 03:45 -0500, Jeff Garzik wrote:
>>> So, a recent emergency surgery has really set me back, work-wise.
>>> ethtool [the userspace utility] 2.6.36 is still not out, and personally
>>> it remains a third or fourth priority.
>>>
>>> While it's likely that I could get back to ethtool's patch queue next
>>> week, it continues to be low man on the totem pole. Seems only fair to
>>> see if anyone else is interested in maintaining it.
>>>
>>> I emailed Ben Hutchings privately about this, but haven't heard back, so
>>> I thought I'd go ahead and email the list.
>>>
>>> Anyone interested?
>>
>> I am interested, but will need to clear it with my boss before making
>> such a commitment.
>
> OK, this is fine. Are there any patches waiting other than mine and
> these?
>
> http://patchwork.ozlabs.org/patch/67662/
> http://patchwork.ozlabs.org/patch/68237/
> http://patchwork.ozlabs.org/patch/69155/
>
> I'll need to sort out my kernel.org account before I can publish a git
> tree.
I've attached an mbox.
In the short term, there is no need to wait, I can simply publish 'git
pull' requests from you, and push a release out to SF.
I would recommend moving the tarball release area away from SF in the
long term; SF is really going downhill.
Jeff
[-- Attachment #2: mbox.bz2 --]
[-- Type: application/x-bzip, Size: 23028 bytes --]
^ permalink raw reply
* Re: [PATCH 1/1] net: rtnetlink.h -- only include linux/netdevice.h when used by the kernel
From: David Miller @ 2010-11-15 19:30 UTC (permalink / raw)
To: apw; +Cc: eric.dumazet, netdev, linux-kernel, tim.gardner
In-Reply-To: <1289836919-19153-2-git-send-email-apw@canonical.com>
From: Andy Whitcroft <apw@canonical.com>
Date: Mon, 15 Nov 2010 16:01:59 +0000
> The commit below added a new helper dev_ingress_queue to cleanly obtain the
> ingress queue pointer. This necessitated including 'linux/netdevice.h':
...
> However this include triggers issues for applications in userspace
> which use the rtnetlink interfaces. Commonly this requires they include
> 'net/if.h' and 'linux/rtnetlink.h' leading to a compiler error as below:
>
> In file included from /usr/include/linux/netdevice.h:28:0,
> from /usr/include/linux/rtnetlink.h:9,
> from t.c:2:
> /usr/include/linux/if.h:135:8: error: redefinition of ‘struct ifmap’
> /usr/include/net/if.h:112:8: note: originally defined here
> /usr/include/linux/if.h:169:8: error: redefinition of ‘struct ifreq’
> /usr/include/net/if.h:127:8: note: originally defined here
> /usr/include/linux/if.h:218:8: error: redefinition of ‘struct ifconf’
> /usr/include/net/if.h:177:8: note: originally defined here
>
> The new helper is only defined for the kernel and protected by __KERNEL__
> therefore we can simply pull the include down into the same protected
> section.
>
> Signed-off-by: Andy Whitcroft <apw@canonical.com>
Applied, thanks Andy.
^ permalink raw reply
* Re: [PATCH 1/1] UDEV - Add 'udevlom' command line param to start_udev
From: Rick Jones @ 2010-11-15 19:32 UTC (permalink / raw)
To: Ben Hutchings
Cc: Matt Domsch, Greg KH, K, Narendra, linux-hotplug@vger.kernel.org,
netdev@vger.kernel.org, Hargrave, Jordan, Rose, Charles
In-Reply-To: <1289841399.2586.18.camel@bwh-desktop>
>>I'm getting a lot of pushback from Dell customers on our
>>linux-poweredge mailing list (thread starts [1]) that the choice of
>>name "lomX" is poor, due to HP's extensive use of LOM meaning Lights
>>Out Management, rather than my intended meaning of "LAN on
>>Motherboard". Gotta hate TLA collisions.
I think Sun (sorry, Oracle) push LOM for Lights-Out Management quite a lot -
calling their service processor an iLOM IIRC.
>>So, I'm open to new ideas for naming these. At LPC, Ted noted that
>>2- and 3-letter names are expected. "nic[1234]" or "en[1234]" ?
>
> [...]
>
> I would suggest avoiding "nic" since some people use "NIC" to mean
> specifically an add-in card rather than LOM. In addition there is some
> ambiguity with multi-port cards/controllers of whether NIC means a
> controller or a port.
>
> Other options for the prefix:
> - "lan". Maybe too generic.
yes and no - that is the prefix for "ethernet" network interface names in HP-UX,
going back decades. so, there is precedent for that, and given the way HP-UX
device name persistence works, 99 times out of ten, the "built-in" or "core" LAN
interfaces ended-up being enumerated starting from zero - lan0, lan1, etc.
(There are exceptions relating to certain modles of systems and a full
re-install of the OS with add-on cards present but that is a story for another
thread).
> - "mbe" = MotherBoard Ethernet. Looks a bit like "GbE" as some OEMs put
> on the port labels.
Collides with Multi-Bit Error.
> - "eom" = Ethernet On Motherboard
Collides with End of Message.
If there is indeed *no* way to get then named eth[1-N], and "lan" doesn't
resonate well-enough, then my contribution to the bikeshed would be "cor" simply
because I don't know the TLA with which that collides :)
Are folks sufficently confident that using anything other than "eth" won't cause
some unpleasant "our app always ass-u-me-d interfaces started with 'eth'"
situations?
rick jones
^ permalink raw reply
* the future of ethtool
From: Jeff Garzik @ 2010-11-15 19:41 UTC (permalink / raw)
To: Ben Hutchings; +Cc: NetDev, David Miller
Thanks for accepting ethtool maintainership.
There are two key unresolved issues with ethtool that are worth noting
to the next maintainer. Both of these come from years of user and
customer complaints.
1) ethtool command line interface.
For 1,001 minor reasons of user taste and expectation, people tend to
complain about the command line interface. Due to script usage it is
set in stone, and has been since before my tenure. But users
continually request something more flexible, often, in particular,
wanting to set multiple settings in one execution, or wanting to apply
the same setting to multiple interface in one execution.
Obviously one can script this, but, it is probably the #1 user request.
My thought was to create "nictool", a new tool with more flexible
command line interface, using the same old ethtool ioctls currently in
use today. ('nictool' also solves a minor naming complaint from
wireless and other people, who use ethtool on non-ethernet network
interfaces)
2) multiple settings and the ethtool kernel interface
Another common complaint is related to multiple settings, and associated
hardware NIC resets.
Many ethtool driver implementations look like this:
ethtool_op_do_something()
stop RX/TX
apply settings
perform full NIC reset, consuming much time
start RX/TX
The problem arises when the user wishes to change multiple hardware
attributes at the same time. A user wishing to change 4 attributes
could wind up with 4 ethtool(1) invocations, with 4 accompanying
hardware NIC resets. Time consuming, inefficient, and unnecessary.
Obviously the world has not ended without these changes, but these items
do cause continued complaints from users, and we're here to be
responsive to users presumably ;-)
Jeff
^ permalink raw reply
* Re: [RFC PATCH] network: return errors if we know tcp_connect failed
From: Alexey Kuznetsov @ 2010-11-15 20:00 UTC (permalink / raw)
To: Eric Paris
Cc: Patrick McHardy, Hua Zhong, netdev, linux-kernel, davem, pekkas,
jmorris, yoshfuji
In-Reply-To: <1289836066.14282.7.camel@localhost.localdomain>
Hello!
On Mon, Nov 15, 2010 at 10:47:46AM -0500, Eric Paris wrote:
> Well I'm (I guess?) surprised that the --reject-with icmp doesn't do
> anything with a local outgoing connection
Yeah. This was "an obvious surpise": for local socket the first icmp error always
arrives on locked socket and gets dropped. I even forgot about this (tcp-reset
still works ok due to backlog) This makes the idea to respect error more attractive.
Alexey
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox