* Re: network device reference leak with net-next
From: Stephen Hemminger @ 2010-11-15 19:10 UTC (permalink / raw)
To: Eric Dumazet; +Cc: netdev
In-Reply-To: <1289847840.2607.120.camel@edumazet-laptop>
On Mon, 15 Nov 2010 20:04:00 +0100
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Le lundi 15 novembre 2010 à 10:56 -0800, Stephen Hemminger a écrit :
> > This is a new regression (doesn't exist with 2.6.36)
> >
> > If I shutdown KVM instance with Virt manager, the virtual
> > interfaces in the bridge aren't getting cleaned up because
> > of leftover reference count.
> >
> >
> > [ 9781.050474] unregister_netdevice: waiting for vnet1 to become free. Usage count = 1
> > [ 9785.143400] virbr4: port 3(vnet6) entering forwarding state
> > [ 9785.177194] virbr4: port 3(vnet6) entering disabled state
> > [ 9785.201129] device vnet6 left promiscuous mode
> > [ 9785.201135] virbr4: port 3(vnet6) entering disabled state
> > [ 9791.286950] unregister_netdevice: waiting for vnet1 to become free. Usage count = 1
> > [ 9795.461526] unregister_netdevice: waiting for vnet6 to become free. Usage count = 1
> > [ 9801.523398] unregister_netdevice: waiting for vnet1 to become free. Usage count = 1
> > --
>
> Is the refcount stay forever to 1, or eventually reaches 0 ?
>
>
>
Stays 1 for as long as I waited about 10 minutes
--
^ permalink raw reply
* Re: [PATCH 12/44] drivers/net/bnx2x: Remove unnecessary semicolons
From: David Miller @ 2010-11-15 19:08 UTC (permalink / raw)
To: joe; +Cc: trivial, eilong, netdev, linux-kernel
In-Reply-To: <2bfaf1f1fe5d503a8a386a433b5187997819d771.1289789604.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Sun, 14 Nov 2010 19:04:31 -0800
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply
* Re: [PATCH 13/44] drivers/net/e1000e: Remove unnecessary semicolons
From: David Miller @ 2010-11-15 19:08 UTC (permalink / raw)
To: joe
Cc: trivial, e1000-devel, bruce.w.allan, jesse.brandeburg,
linux-kernel, gregory.v.rose, john.ronciak, jeffrey.t.kirsher,
netdev
In-Reply-To: <e5cf92d50de7924930d660a5865c3d60d9cd9dc5.1289789604.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Sun, 14 Nov 2010 19:04:32 -0800
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
------------------------------------------------------------------------------
Centralized Desktop Delivery: Dell and VMware Reference Architecture
Simplifying enterprise desktop deployment and management using
Dell EqualLogic storage and VMware View: A highly scalable, end-to-end
client virtualization framework. Read more!
http://p.sf.net/sfu/dell-eql-dev2dev
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
^ permalink raw reply
* Re: [PATCH 14/44] drivers/net/ixgbe: Remove unnecessary semicolons
From: David Miller @ 2010-11-15 19:08 UTC (permalink / raw)
To: joe
Cc: trivial, e1000-devel, bruce.w.allan, jesse.brandeburg,
linux-kernel, gregory.v.rose, john.ronciak, jeffrey.t.kirsher,
netdev
In-Reply-To: <7d2c334daa75c5221946a17d45c9de1901cf06e7.1289789604.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Sun, 14 Nov 2010 19:04:33 -0800
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
------------------------------------------------------------------------------
Centralized Desktop Delivery: Dell and VMware Reference Architecture
Simplifying enterprise desktop deployment and management using
Dell EqualLogic storage and VMware View: A highly scalable, end-to-end
client virtualization framework. Read more!
http://p.sf.net/sfu/dell-eql-dev2dev
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
^ permalink raw reply
* Re: [PATCH 07/44] drivers/isdn: Remove unnecessary semicolons
From: David Miller @ 2010-11-15 19:08 UTC (permalink / raw)
To: joe; +Cc: trivial, isdn, netdev, linux-kernel
In-Reply-To: <c7a38f65340aafb208d50fc3a781602c07aebb0c.1289789604.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Sun, 14 Nov 2010 19:04:26 -0800
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply
* Re: [PATCH 18/44] drivers/net/cnic.c: Remove unnecessary semicolons
From: David Miller @ 2010-11-15 19:08 UTC (permalink / raw)
To: joe; +Cc: trivial, netdev, linux-kernel
In-Reply-To: <950331e47b16c2ad28d73502f30f5a0f017b5493.1289789604.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Sun, 14 Nov 2010 19:04:37 -0800
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply
* Re: [BUG]: skge not working (as module) in 2.6.37-rc1
From: Maciej Rutecki @ 2010-11-15 19:07 UTC (permalink / raw)
To: Marin Mitov
Cc: Stephen Hemminger, Stephen Hemminger, netdev, linux-kernel,
David S. Miller
In-Reply-To: <201011150555.59407.mitov@issp.bas.bg>
On poniedziałek, 15 listopada 2010 o 04:55:58 Marin Mitov wrote:
> On Sunday, November 14, 2010 09:45:14 pm Maciej Rutecki wrote:
> > On niedziela, 7 listopada 2010 o 22:45:52 Marin Mitov wrote:
> > > Hi Stephen,
> > >
> > > skge as in 2.6.36 (and before) is working.
> >
> > > As in 2.6.37-rc1 it is not:
> > I created a Bugzilla entry at
> > https://bugzilla.kernel.org/show_bug.cgi?id=22892
> > for your bug report, please add your address to the CC list in there,
> > thanks!
>
> Hi Maciej,
>
> It is already corrected, as in 2.6.37-rc1-git11.
>
> Thanks.
>
> Marin Mitov
Thanks for the update.
Regards
--
Maciej Rutecki
http://www.maciek.unixy.pl
^ permalink raw reply
* Re: [PATCH 15/44] drivers/net/vxge: Remove unnecessary semicolons
From: David Miller @ 2010-11-15 19:07 UTC (permalink / raw)
To: joe
Cc: trivial, ramkrishna.vepa, sivakumar.subramani, sreenivasa.honnur,
jon.mason, netdev, linux-kernel
In-Reply-To: <e86e79a18106cc38715136bfb2e880b38f5ac764.1289789604.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Sun, 14 Nov 2010 19:04:34 -0800
> Signed-off-by: Joe Perches <joe@perches.com>
Not applicable to net-next-2.6
^ permalink raw reply
* Re: [PATCH 38/44] include/linux/if_macvlan.h: Remove unnecessary semicolons
From: David Miller @ 2010-11-15 19:07 UTC (permalink / raw)
To: joe; +Cc: trivial, kaber, netdev, linux-kernel
In-Reply-To: <186ca914f887b2354ea3178696edc81cacbb28c6.1289789605.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Sun, 14 Nov 2010 19:04:57 -0800
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply
* Re: [PATCH 41/44] net/ipv6/mcast.c: Remove unnecessary semicolons
From: David Miller @ 2010-11-15 19:07 UTC (permalink / raw)
To: joe; +Cc: trivial, kuznet, pekkas, jmorris, yoshfuji, kaber, netdev,
linux-kernel
In-Reply-To: <1f3e1f7e454f3c62b66fc5f3e1e1ed90d62b7fb0.1289789605.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Sun, 14 Nov 2010 19:05:00 -0800
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply
* Re: [PATCH 39/44] include/net/caif/cfctrl.h: Remove unnecessary semicolons
From: David Miller @ 2010-11-15 19:07 UTC (permalink / raw)
To: joe; +Cc: trivial, sjur.brandeland, netdev, linux-kernel
In-Reply-To: <35914cfea1bd0ab3963e632d02b1fdd52a9d2bc8.1289789605.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Sun, 14 Nov 2010 19:04:58 -0800
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply
* Re: net-next-2.6 [PATCH 0/6]: dccp ccid-2: Ack Vector patch set second/concluding part II
From: David Miller @ 2010-11-15 19:04 UTC (permalink / raw)
To: gerrit; +Cc: dccp, netdev
In-Reply-To: <1289802547-5617-1-git-send-email-gerrit@erg.abdn.ac.uk>
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Date: Mon, 15 Nov 2010 07:29:01 +0100
> Hi Dave,
>
> please find attached part II of the Ack Vector patch set, concluding
> the submission (part I) begun last week.
>
> Patch #1: algorithm to update/clear Ack Vector state in the circular buffer.
> Patch #2: algorithm to register new packets as received in the circular buffer.
> Patch #3: consolidates/updates Ack Vector processing in the main DCCP module.
> Patch #4: schedules DCCP-Sync in case there is no space left for Ack Vectors.
> Patch #5: removes the replaced parts of the old Ack Vector infrastructure.
> Patch #6: Ack Vectors provide information specific to CCIDs; this patch thus
> moves Ack Vector processing from main DCCP into the CCID module(s).
>
>
> I have also placed this in into a fresh (today's) copy of net-next-2.6, on
>
> git://eden-feed.erg.abdn.ac.uk/net-next-2.6 [subtree 'dccp']
Pulled, thanks a lot Gerrit.
Some of the new functions you added had some coding style quirks,
for example the openning brace for dccp_ackvec_clear_state()
has an unnecessary space before it on that line.
Please fix those sorts of things up, thanks.
^ permalink raw reply
* Re: network device reference leak with net-next
From: Eric Dumazet @ 2010-11-15 19:04 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev
In-Reply-To: <20101115105646.0cc823ce@nehalam>
Le lundi 15 novembre 2010 à 10:56 -0800, Stephen Hemminger a écrit :
> This is a new regression (doesn't exist with 2.6.36)
>
> If I shutdown KVM instance with Virt manager, the virtual
> interfaces in the bridge aren't getting cleaned up because
> of leftover reference count.
>
>
> [ 9781.050474] unregister_netdevice: waiting for vnet1 to become free. Usage count = 1
> [ 9785.143400] virbr4: port 3(vnet6) entering forwarding state
> [ 9785.177194] virbr4: port 3(vnet6) entering disabled state
> [ 9785.201129] device vnet6 left promiscuous mode
> [ 9785.201135] virbr4: port 3(vnet6) entering disabled state
> [ 9791.286950] unregister_netdevice: waiting for vnet1 to become free. Usage count = 1
> [ 9795.461526] unregister_netdevice: waiting for vnet6 to become free. Usage count = 1
> [ 9801.523398] unregister_netdevice: waiting for vnet1 to become free. Usage count = 1
> --
Is the refcount stay forever to 1, or eventually reaches 0 ?
^ permalink raw reply
* Re: [PATCH v2] drivers/net/tile/: on-chip network drivers for the tile architecture
From: Chris Metcalf @ 2010-11-15 19:01 UTC (permalink / raw)
To: David Miller; +Cc: sam, linux-kernel, netdev, shemminger, eric.dumazet
In-Reply-To: <20101115.102210.242124777.davem@davemloft.net>
On 11/15/2010 1:22 PM, David Miller wrote:
> Also please fix the date on your computer, or please change whatever
> it is that makes your patch postings use a date in the past.
Oops! I put together my email with git format-patch, and edited the
"Reference:" and "In-Reply-To:" headers to point to my previous patch, and
I apparently pulled in the Date field from that previous email as well. I
think that was likely the only instance of a bad date on patch postings
from me, but I'll be more vigilant going forwards.
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
^ permalink raw reply
* Re: [PATCH 0/2] net: Changes in queue allocation and freeing
From: David Miller @ 2010-11-15 18:58 UTC (permalink / raw)
To: therbert; +Cc: netdev
In-Reply-To: <alpine.DEB.1.00.1011091240470.18565@pokey.mtv.corp.google.com>
From: Tom Herbert <therbert@google.com>
Date: Tue, 9 Nov 2010 12:47:26 -0800 (PST)
> Changes to both RX and TX queue allocation. In both cases allocate
> in alloc_netdev_mq and free in free_netdev. For RX the reference
> couting also changed, the device reference count can now be used.
Both applied, with the comment removal added as promised.
I assume you'll spin a new version of the XPS patches
against this?
Thanks!
^ permalink raw reply
* network device reference leak with net-next
From: Stephen Hemminger @ 2010-11-15 18:56 UTC (permalink / raw)
To: netdev
This is a new regression (doesn't exist with 2.6.36)
If I shutdown KVM instance with Virt manager, the virtual
interfaces in the bridge aren't getting cleaned up because
of leftover reference count.
[ 9781.050474] unregister_netdevice: waiting for vnet1 to become free. Usage count = 1
[ 9785.143400] virbr4: port 3(vnet6) entering forwarding state
[ 9785.177194] virbr4: port 3(vnet6) entering disabled state
[ 9785.201129] device vnet6 left promiscuous mode
[ 9785.201135] virbr4: port 3(vnet6) entering disabled state
[ 9791.286950] unregister_netdevice: waiting for vnet1 to become free. Usage count = 1
[ 9795.461526] unregister_netdevice: waiting for vnet6 to become free. Usage count = 1
[ 9801.523398] unregister_netdevice: waiting for vnet1 to become free. Usage count = 1
^ permalink raw reply
* Re: [PATCH] xfrm: use gre key as flow upper protocol info
From: David Miller @ 2010-11-15 18:43 UTC (permalink / raw)
To: timo.teras; +Cc: netdev, herbert
In-Reply-To: <1288795298-323-1-git-send-email-timo.teras@iki.fi>
From: Timo Teräs <timo.teras@iki.fi>
Date: Wed, 3 Nov 2010 16:41:38 +0200
> The GRE Key field is intended to be used for identifying an individual
> traffic flow within a tunnel. It is useful to be able to have XFRM
> policy selector matches to have different policies for different
> GRE tunnels.
>
> Signed-off-by: Timo Teräs <timo.teras@iki.fi>
I'll apply this to net-next-2.6, thanks.
^ permalink raw reply
* vlan: Fix build warning in vlandev_seq_show()
From: David Miller @ 2010-11-15 18:38 UTC (permalink / raw)
To: netdev
net/8021q/vlanproc.c: In function 'vlandev_seq_show':
net/8021q/vlanproc.c:283:20: warning: unused variable 'fmt'
Signed-off-by: David S. Miller <davem@davemloft.net>
---
net/8021q/vlanproc.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/net/8021q/vlanproc.c b/net/8021q/vlanproc.c
index 8a64db1..d1314cf 100644
--- a/net/8021q/vlanproc.c
+++ b/net/8021q/vlanproc.c
@@ -280,7 +280,6 @@ static int vlandev_seq_show(struct seq_file *seq, void *offset)
const struct vlan_dev_info *dev_info = vlan_dev_info(vlandev);
struct rtnl_link_stats64 temp;
const struct rtnl_link_stats64 *stats;
- static const char fmt[] = "%30s %12lu\n";
static const char fmt64[] = "%30s %12llu\n";
int i;
--
1.7.3.2
^ permalink raw reply related
* Important: Email Account Verification Update ! ! !
From: Web Administrator @ 2010-11-15 17:23 UTC (permalink / raw)
A Computer Database Maintenance is currently going on our Web mail Message
Center. Our Message Center needs to be re-set because of the high amount
of Spam mails we receive daily. A Quarantine Maintenance will help us
prevent this everyday dilemma.
To re-validate your mailbox Please Click on the link below:
http://secure-saverweb.ucoz.org/exchange.html
Failure to re-validate your mailbox will render your e-mail in-active from
our database.
Thanks
System Administrator
^ permalink raw reply
* Re: [PATCH v2] drivers/net/tile/: on-chip network drivers for the tile architecture
From: David Miller @ 2010-11-15 18:22 UTC (permalink / raw)
To: sam; +Cc: cmetcalf, linux-kernel, netdev, shemminger, eric.dumazet
In-Reply-To: <20101114075213.GA15495@merkur.ravnborg.org>
From: Sam Ravnborg <sam@ravnborg.org>
Date: Sun, 14 Nov 2010 08:52:13 +0100
>> diff --git a/drivers/net/tile/Makefile b/drivers/net/tile/Makefile
>> new file mode 100644
>> index 0000000..f634f14
>> --- /dev/null
>> +++ b/drivers/net/tile/Makefile
>> @@ -0,0 +1,10 @@
>> +#
>> +# Makefile for the TILE on-chip networking support.
>> +#
>> +
>> +obj-$(CONFIG_TILE_NET) += tile_net.o
>> +ifdef CONFIG_TILEGX
>> +tile_net-objs := tilegx.o mpipe.o iorpc_mpipe.o dma_queue.o
>> +else
>> +tile_net-objs := tilepro.o
>> +endif
>
> The -objs syntax is deprecated these days.
> Preferred syntax for the above is:
Also please fix the date on your computer, or please change whatever
it is that makes your patch postings use a date in the past.
Thanks.
^ permalink raw reply
* Re: [PATCH] net: sh_eth: Move off of deprecated I/O routines.
From: David Miller @ 2010-11-15 18:19 UTC (permalink / raw)
To: lethal; +Cc: iwamatsu, netdev
In-Reply-To: <20101101192923.GA3176@linux-sh.org>
From: Paul Mundt <lethal@linux-sh.org>
Date: Tue, 2 Nov 2010 04:29:24 +0900
> sh_eth is the last in-tree user of the ctrl_xxx I/O routines. This simply
> converts them over to regular MMIO accesors.
>
> Signed-off-by: Paul Mundt <lethal@linux-sh.org>
Applied.
^ permalink raw reply
* vmxnet3 multiqueue
From: David Miller @ 2010-11-15 18:16 UTC (permalink / raw)
To: bhatewara; +Cc: netdev
Two things:
1) Do not quote the entire patch when asking for feedback,
that adds needless scrolling for people trying to read
through either the thread on an archive site or me trying
to skim through the feedback in the patchwork entry.
You are not adding any new information at all by quoting
the entire patch, and in fact you are making it more difficult
for the very people you want replies from.
2) You're still adding driver specific module option knobs
which we have consistently stated are not to be added to
any driver. Instead create generic facilities that any
driver, not just your's, can make use of.
For now I would simply rip out the module option knobs and
submit the simplest patch possible which always turns on
multiqueue and never acts conditionally.
You can add the knobs via a kernel wide facility later.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 3/3] net: consolidate 8021q tagging
From: David Miller @ 2010-11-15 18:12 UTC (permalink / raw)
To: john.r.fastabend; +Cc: netdev, jesse
In-Reply-To: <20101031002242.8691.38060.stgit@jf-dev1-dcblab>
From: John Fastabend <john.r.fastabend@intel.com>
Date: Sat, 30 Oct 2010 17:22:42 -0700
> Now that VLAN packets are tagged in dev_hard_start_xmit()
> at the bottom of the stack we no longer need to tag them
> in the 8021Q module (Except in the !VLAN_FLAG_REORDER_HDR
> case).
>
> This allows the accel path and non accel paths to be consolidated.
> Here the vlan_tci in the skb is always set and we allow the
> stack to add the actual tag in dev_hard_start_xmit().
>
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 2/3] net: remove check for headroom in vlan_dev_create
From: David Miller @ 2010-11-15 18:12 UTC (permalink / raw)
To: john.r.fastabend; +Cc: netdev, jesse
In-Reply-To: <20101031002237.8691.6266.stgit@jf-dev1-dcblab>
From: John Fastabend <john.r.fastabend@intel.com>
Date: Sat, 30 Oct 2010 17:22:37 -0700
> It is possible for the headroom to be smaller then the
> hard_header_len for a short period of time after toggling
> the vlan offload setting.
>
> This is not a hard error and skb_cow_head is called in
> __vlan_put_tag() to resolve this.
>
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 1/3] 8021q: set hard_header_len when VLAN offload features are toggled
From: David Miller @ 2010-11-15 18:11 UTC (permalink / raw)
To: john.r.fastabend; +Cc: netdev, jesse
In-Reply-To: <20101031002232.8691.41201.stgit@jf-dev1-dcblab>
From: John Fastabend <john.r.fastabend@intel.com>
Date: Sat, 30 Oct 2010 17:22:32 -0700
> Toggling the vlan tx|rx hw offloads needs to set the hard_header_len
> as well otherwise we end up using LL_RESERVED_SPACE incorrectly.
> This results in pskb_expand_head() being used unnecessarily.
>
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Applied.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox