* Re: [PATCH 07/10] drivers/net/vxge: Remove unnecessary casts of netdev_priv
From: David Miller @ 2010-11-17 18:44 UTC (permalink / raw)
To: joe
Cc: trivial, ramkrishna.vepa, sivakumar.subramani, sreenivasa.honnur,
jon.mason, netdev, linux-kernel
In-Reply-To: <5aee4bf89b5baa6e1d32c99be560893925ed2e19.1289855436.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Mon, 15 Nov 2010 13:12:30 -0800
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
VXGE folks, note that this means any patches you send to me need
to take Joe's changes into account. If you diff against current
net-next-2.6 you'll be fine.
^ permalink raw reply
* Re: [PATCH 10/10] net/atm: Remove unnecessary casts of netdev_priv
From: David Miller @ 2010-11-17 18:45 UTC (permalink / raw)
To: joe; +Cc: trivial, netdev, linux-kernel
In-Reply-To: <0953cd1e1042f41ae839f5b9e4adaffd555c71eb.1289855436.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Mon, 15 Nov 2010 13:12:33 -0800
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply
* Re: [PATCH 08/10] drivers/net: Remove unnecessary casts of netdev_priv
From: David Miller @ 2010-11-17 18:45 UTC (permalink / raw)
To: joe; +Cc: trivial, p_gortmaker, ysato, netdev, linux-kernel
In-Reply-To: <8b57be072e62f8f7d39d4ecd9ce5c999e4f8bbdc.1289855436.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Mon, 15 Nov 2010 13:12:31 -0800
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply
* Re: [PATCH 06/10] drivers/net/usb: Remove unnecessary casts of netdev_priv
From: David Miller @ 2010-11-17 18:45 UTC (permalink / raw)
To: petkan; +Cc: joe, trivial, petkan, gregkh, linux-usb, netdev, linux-kernel
In-Reply-To: <alpine.DEB.2.00.1011161958320.1392@gabi>
From: Petko Manolov <petkan@nucleusys.com>
Date: Tue, 16 Nov 2010 19:59:29 +0200 (EET)
> ACK! :-)
Please do not top post.
Also, please use a properly formed "Acked-by: " tag if you want
your ACK to actually show up in the commit log message.
Thanks.
^ permalink raw reply
* Re: [PATCH 3/3] SELinux: return -ECONNREFUSED from ip_postroute to signal fatal error
From: David Miller @ 2010-11-17 18:55 UTC (permalink / raw)
To: eparis
Cc: kaber, netdev, linux-kernel, selinux, netfilter-devel, equinox,
eric.dumazet, hzhong, jmorris, kuznet, paul.moore, pekkas, sds,
yoshfuji
In-Reply-To: <1290004739.14282.73.camel@localhost.localdomain>
From: Eric Paris <eparis@redhat.com>
Date: Wed, 17 Nov 2010 09:38:59 -0500
> On Wed, 2010-11-17 at 12:43 +0100, Patrick McHardy wrote:
>> On 16.11.2010 22:52, Eric Paris wrote:
>> > The SELinux netfilter hooks just return NF_DROP if they drop a packet. We
>> > want to signal that a drop in this hook is a permanant fatal error and is not
>> > transient. If we do this the error will be passed back up the stack in some
>> > places and applications will get a faster interaction that something went
>> > wrong.
>>
>> Looks good to me. I'd suggest to have these patches go through Dave's
>> tree since I want to make use of the netfilter error propagation
>> mechanism to return proper errno codes for netfilter re-routing
>> failures.
>
>
> I'd be happy if Dave pulled patches 1 and 2. I can resend patch #3 once
> I can cajole another of the SELinux maintainers to look at it (I believe
> he most likely one is on vacation this week)
I think it's best to pull this all into net-next-2.6 now, so that's what
I'm doing right now.
If there are problems we can apply changes on top.
Thanks.
^ permalink raw reply
* Re: [PATCH 1/3] netfilter: allow hooks to pass error code back up the stack
From: David Miller @ 2010-11-17 18:55 UTC (permalink / raw)
To: eparis
Cc: netdev, linux-kernel, selinux, netfilter-devel, equinox,
eric.dumazet, hzhong, jmorris, kaber, kuznet, paul.moore, pekkas,
sds, yoshfuji
In-Reply-To: <20101116215238.6727.39248.stgit@paris.rdu.redhat.com>
From: Eric Paris <eparis@redhat.com>
Date: Tue, 16 Nov 2010 16:52:38 -0500
> SELinux would like to pass certain fatal errors back up the stack. This patch
> implements the generic netfilter support for this functionality.
>
> Based-on-patch-by: Patrick McHardy <kaber@trash.net>
> Signed-off-by: Eric Paris <eparis@redhat.com>
Applied.
^ permalink raw reply
* Re: [PATCH 2/3] network: tcp_connect should return certain errors up the stack
From: David Miller @ 2010-11-17 18:56 UTC (permalink / raw)
To: eparis
Cc: netdev, linux-kernel, selinux, netfilter-devel, equinox,
eric.dumazet, hzhong, jmorris, kaber, kuznet, paul.moore, pekkas,
sds, yoshfuji
In-Reply-To: <20101116215249.6727.89763.stgit@paris.rdu.redhat.com>
From: Eric Paris <eparis@redhat.com>
Date: Tue, 16 Nov 2010 16:52:49 -0500
> The current tcp_connect code completely ignores errors from sending an skb.
> This makes sense in many situations (like -ENOBUFFS) but I want to be able to
> immediately fail connections if they are denied by the SELinux netfilter hook.
> Netfilter does not normally return ECONNREFUSED when it drops a packet so we
> respect that error code as a final and fatal error that can not be recovered.
>
> Based-on-patch-by: Patrick McHardy <kaber@trash.net>
> Signed-off-by: Eric Paris <eparis@redhat.com>
Applied.
^ permalink raw reply
* Re: [PATCH 3/3] SELinux: return -ECONNREFUSED from ip_postroute to signal fatal error
From: David Miller @ 2010-11-17 18:56 UTC (permalink / raw)
To: eparis
Cc: netdev, linux-kernel, selinux, netfilter-devel, equinox,
eric.dumazet, hzhong, jmorris, kaber, kuznet, paul.moore, pekkas,
sds, yoshfuji
In-Reply-To: <20101116215257.6727.12163.stgit@paris.rdu.redhat.com>
From: Eric Paris <eparis@redhat.com>
Date: Tue, 16 Nov 2010 16:52:57 -0500
> The SELinux netfilter hooks just return NF_DROP if they drop a packet. We
> want to signal that a drop in this hook is a permanant fatal error and is not
> transient. If we do this the error will be passed back up the stack in some
> places and applications will get a faster interaction that something went
> wrong.
>
> Signed-off-by: Eric Paris <eparis@redhat.com>
Applied.
^ permalink raw reply
* Re: [PATCH] drivers/isdn/hisax: Add printf format/argument verification and fix fallout
From: David Miller @ 2010-11-17 18:58 UTC (permalink / raw)
To: joe; +Cc: linux-kernel, isdn, netdev
In-Reply-To: <f92d95e7dc0afca09c2d76880b76973e4eafb169.1289451201.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Wed, 10 Nov 2010 20:54:58 -0800
> Add __attribute__((format... to several functins
> Make formats and arguments match.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH net-next-2.6] clarify documentation for net.ipv4.igmp_max_memberships
From: David Miller @ 2010-11-17 19:22 UTC (permalink / raw)
To: jeder
Cc: netdev, rdunlap, opurdila, apetlund, William.Allen.Simpson,
ian.campbell, linux-doc, linux-kernel, jpirko
In-Reply-To: <1289835691.8257.1274.camel@jerms-wks.usersys.redhat.com>
From: Jeremy Eder <jeder@redhat.com>
Date: Mon, 15 Nov 2010 10:41:31 -0500
> This patch helps clarify documentation for
> net.ipv4.igmp_max_memberships by providing a formula for
> calculating the maximum number of multicast groups that can be
> subscribed to, plus defining the theoretical limit.
>
> Signed-off-by: Jiri Pirko <jpirko@redhat.com>
> Signed-off-by: Jeremy Eder <jeder@redhat.com>
Applied, thanks Jeremy.
^ permalink raw reply
* Re: [PATCH net-next 1/4] rtnetlink: Link address family API
From: David Miller @ 2010-11-17 19:30 UTC (permalink / raw)
To: tgraf; +Cc: netdev
In-Reply-To: <20101116143014.GA26669@canuck.infradead.org>
From: Thomas Graf <tgraf@infradead.org>
Date: Tue, 16 Nov 2010 09:30:14 -0500
> Each net_device contains address family specific data such as
> per device settings and statistics. We already expose this data
> via procfs/sysfs and partially netlink.
>
> The netlink method requires the requester to send one RTM_GETLINK
> request for each address family it wishes to receive data of
> and then merge this data itself.
>
> This patch implements a new API which combines all address family
> specific link data in a new netlink attribute IFLA_AF_SPEC.
> IFLA_AF_SPEC contains a sequence of nested attributes, one for each
> address family which in turn defines the structure of its own
> attribute. Example:
>
> [IFLA_AF_SPEC] = {
> [AF_INET] = {
> [IFLA_INET_CONF] = ...,
> },
> [AF_INET6] = {
> [IFLA_INET6_FLAGS] = ...,
> [IFLA_INET6_CONF] = ...,
> }
> }
>
> The API also allows for address families to implement a function
> which parses the IFLA_AF_SPEC attribute sent by userspace to
> implement address family specific link options.
>
> Signed-off-by: Thomas Graf <tgraf@infradead.org>
Applied, but note that as-implemented it has the "partial update"
problem. When we can't get the af-specific ops for a "parse"
operation, we just skip that AF yet we let the modifications of
the other AF's succeed and make it appear to the user that
everything got updated and all the attributes were consumed.
I don't know what we can do about this with how things work
right now.
^ permalink raw reply
* Re: [PATCH net-next 2/4] inet: Define IPV4_DEVCONF_MAX
From: David Miller @ 2010-11-17 19:30 UTC (permalink / raw)
To: tgraf; +Cc: netdev
In-Reply-To: <20101116143120.GB26669@canuck.infradead.org>
From: Thomas Graf <tgraf@infradead.org>
Date: Tue, 16 Nov 2010 09:31:20 -0500
> Define IPV4_DEVCONF_MAX to get rid of MAX - 1 notation.
>
> Signed-off-by: Thomas Graf <tgraf@infradead.org>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 3/4] ipv4: AF_INET link address family
From: David Miller @ 2010-11-17 19:30 UTC (permalink / raw)
To: tgraf; +Cc: netdev
In-Reply-To: <20101116143248.GC26669@canuck.infradead.org>
From: Thomas Graf <tgraf@infradead.org>
Date: Tue, 16 Nov 2010 09:32:48 -0500
> Implements the AF_INET link address family exposing the per
> device configuration settings via netlink using the attribute
> IFLA_INET_CONF.
>
> The format of IFLA_INET_CONF differs depending on the direction
> the attribute is sent. The attribute sent by the kernel consists
> of a u32 array, basically a 1:1 copy of in_device->cnf.data[].
> The attribute expected by the kernel must consist of a sequence
> of nested u32 attributes, each representing a change request,
> e.g.
> [IFLA_INET_CONF] = {
> [IPV4_DEVCONF_FORWARDING] = 1,
> [IPV4_DEVCONF_NOXFRM] = 0,
> }
>
> libnl userspace API documentation and example available from:
> http://www.infradead.org/~tgr/libnl/doc-git/group__link__inet.html
>
> Signed-off-by: Thomas Graf <tgraf@infradead.org>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 4/4] ipv6: AF_INET6 link address family
From: David Miller @ 2010-11-17 19:30 UTC (permalink / raw)
To: tgraf; +Cc: netdev, yoshfuji
In-Reply-To: <20101116143357.GD26669@canuck.infradead.org>
From: Thomas Graf <tgraf@infradead.org>
Date: Tue, 16 Nov 2010 09:33:57 -0500
> IPv6 already exposes some address family data via netlink in the
> IFLA_PROTINFO attribute if RTM_GETLINK request is sent with the
> address family set to AF_INET6. We take over this format and
> reuse all the code.
>
> Signed-off-by: Thomas Graf <tgraf@infradead.org>
> Cc: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 0/5] qlcnic: Bug fixes
From: David Miller @ 2010-11-17 19:51 UTC (permalink / raw)
To: anirban.chakraborty; +Cc: netdev, Dept_NX_Linux_NIC_Driver
In-Reply-To: <alpine.OSX.2.00.1011161510040.88679@macintosh-2.local>
From: Anirban Chakraborty <anirban.chakraborty@qlogic.com>
Date: Tue, 16 Nov 2010 16:07:38 -0800
> Please apply following patches to net-next.
All applied, thank you.
^ permalink raw reply
* Re: [PATCH] r8169: fix checksum broken
From: David Miller @ 2010-11-17 19:54 UTC (permalink / raw)
To: romieu; +Cc: shanwei, netdev
In-Reply-To: <20101112231325.GB6676@electric-eye.fr.zoreil.com>
From: Francois Romieu <romieu@fr.zoreil.com>
Date: Sat, 13 Nov 2010 00:13:25 +0100
> Francois Romieu <romieu@fr.zoreil.com> :
> [...]
>> Which kind of device do you use : PCI-E 8168 / 810x or PCI 8169 ?
>
> Wrong page. Forget it.
>
> Acked-by: Francois Romieu <romieu@fr.zoreil.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH] r8169: fix checksum broken
From: David Miller @ 2010-11-17 19:55 UTC (permalink / raw)
To: romieu; +Cc: shanwei, netdev, jgarzik
In-Reply-To: <20101115210122.GA22621@electric-eye.fr.zoreil.com>
From: Francois Romieu <romieu@fr.zoreil.com>
Date: Mon, 15 Nov 2010 22:01:23 +0100
> Shan Wei <shanwei@cn.fujitsu.com> :
> [...]
>> If these are right, driver will set ip_summed with CHECKSUM_UNNECESSARY for other
>> upper protocol, e.g. sctp, igmp protocol. This will cause protocol stack ignores
>> checksum check for packets with invalid checksum.
>
> The documentation of these bits is identical for the 8139c+ and the 8169.
Also applied, thank you.
^ permalink raw reply
* Re: [PATCH] net: bnx2x: fix error value sign
From: David Miller @ 2010-11-17 20:23 UTC (permalink / raw)
To: eric.dumazet; +Cc: segoon, kernel-janitors, eilong, netdev, linux-kernel
In-Reply-To: <1289766728.2743.147.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sun, 14 Nov 2010 21:32:08 +0100
> Le dimanche 14 novembre 2010 à 21:29 +0100, Eric Dumazet a écrit :
>
>> I remember sending same patch in the past... it was lost somehow...
>
> Ah, it was another issue, patch was not lost ;)
:-) Applied, thanks everyone.
^ permalink raw reply
* Re: [PATCH 06/11] drivers/net/s2io.c: Remove unnecessary casts of pci_get_drvdata
From: David Miller @ 2010-11-17 20:28 UTC (permalink / raw)
To: joe
Cc: trivial, ramkrishna.vepa, sivakumar.subramani, sreenivasa.honnur,
jon.mason, netdev, linux-kernel
In-Reply-To: <5add1304ab2cd7f730a81a85598ef7357b087a86.1289851770.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Mon, 15 Nov 2010 12:13:57 -0800
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply
* Re: [PATCH 07/11] drivers/net/vxge/vxge-main.c: Remove unnecessary casts of pci_get_drvdata
From: David Miller @ 2010-11-17 20:28 UTC (permalink / raw)
To: jon.mason
Cc: joe, trivial, Ramkrishna.Vepa, Sivakumar.Subramani,
Sreenivasa.Honnur, netdev, linux-kernel
In-Reply-To: <20101115225056.GA12891@exar.com>
From: Jon Mason <jon.mason@exar.com>
Date: Mon, 15 Nov 2010 16:50:56 -0600
> On Mon, Nov 15, 2010 at 12:13:58PM -0800, Joe Perches wrote:
>> Signed-off-by: Joe Perches <joe@perches.com>
>
> Looks good to me.
>
> Acked-by: Jon Mason <jon.mason@exar.com>
Applied.
^ permalink raw reply
* Re: [PATCH] net: more Kconfig whitespace cleanup
From: David Miller @ 2010-11-17 20:29 UTC (permalink / raw)
To: phdm; +Cc: netdev
In-Reply-To: <1289673809-17825-1-git-send-email-phdm@macqel.be>
From: Philippe De Muyter <phdm@macqel.be>
Date: Sat, 13 Nov 2010 19:43:29 +0100
> indentation for TSI108_ETH entry was too big.
>
> Signed-off-by: Philippe De Muyter <phdm@macqel.be>
Applied.
^ permalink raw reply
* Re: [PATCH] net: use the macros defined for the members of flowi
From: David Miller @ 2010-11-17 20:29 UTC (permalink / raw)
To: xiaosuo; +Cc: netdev
In-Reply-To: <1289623435-22713-1-git-send-email-xiaosuo@gmail.com>
From: Changli Gao <xiaosuo@gmail.com>
Date: Sat, 13 Nov 2010 12:43:55 +0800
> Use the macros defined for the members of flowi to clean the code up.
>
> Signed-off-by: Changli Gao <xiaosuo@gmail.com>
Applied, thank you.
^ permalink raw reply
* Re: [PATCH 09/14] drivers/net/can/sja1000: Use printf extension %pR for struct resource
From: David Miller @ 2010-11-17 20:29 UTC (permalink / raw)
To: joe-6d6DIl74uiNBDgjK7y7TUQ
Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w,
netdev-u79uwXL29TY76Z2rM5mHXA, trivial-DgEjT+Ai2ygdnm+yROfE0A,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, wg-5Yr1BZd7O62+XT7JhA+gdA
In-Reply-To: <199bf35f52ea48bef79d4b40b504b0c85dca6fad.1289597644.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
From: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
Date: Fri, 12 Nov 2010 13:37:59 -0800
> Using %pR standardizes the struct resource output.
>
> Signed-off-by: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH v2] net: zero kobject in rx_queue_release
From: David Miller @ 2010-11-17 20:29 UTC (permalink / raw)
To: john.r.fastabend; +Cc: netdev, eric.dumazet, therbert
In-Reply-To: <20101116163139.2084.20075.stgit@jf-dev1-dcblab>
From: John Fastabend <john.r.fastabend@intel.com>
Date: Tue, 16 Nov 2010 08:31:39 -0800
> netif_set_real_num_rx_queues() can decrement and increment
> the number of rx queues. For example ixgbe does this as
> features and offloads are toggled. Presumably this could
> also happen across down/up on most devices if the available
> resources changed (cpu offlined).
>
> The kobject needs to be zero'd in this case so that the
> state is not preserved across kobject_put()/kobject_init_and_add().
>
> This resolves the following error report.
>
> ixgbe 0000:03:00.0: eth2: NIC Link is Up 10 Gbps, Flow Control: RX/TX
> kobject (ffff880324b83210): tried to init an initialized object, something is seriously wrong.
> Pid: 1972, comm: lldpad Not tainted 2.6.37-rc18021qaz+ #169
> Call Trace:
> [<ffffffff8121c940>] kobject_init+0x3a/0x83
> [<ffffffff8121cf77>] kobject_init_and_add+0x23/0x57
> [<ffffffff8107b800>] ? mark_lock+0x21/0x267
> [<ffffffff813c6d11>] net_rx_queue_update_kobjects+0x63/0xc6
> [<ffffffff813b5e0e>] netif_set_real_num_rx_queues+0x5f/0x78
> [<ffffffffa0261d49>] ixgbe_set_num_queues+0x1c6/0x1ca [ixgbe]
> [<ffffffffa0262509>] ixgbe_init_interrupt_scheme+0x1e/0x79c [ixgbe]
> [<ffffffffa0274596>] ixgbe_dcbnl_set_state+0x167/0x189 [ixgbe]
>
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Applied.
^ permalink raw reply
* Re: [PATCH] net: ipv4: tcp_probe: cleanup snprintf() use
From: David Miller @ 2010-11-17 20:30 UTC (permalink / raw)
To: segoon
Cc: kernel-janitors, kuznet, pekkas, jmorris, yoshfuji, kaber, netdev,
linux-kernel
In-Reply-To: <1289754368-31660-1-git-send-email-segoon@openwall.com>
From: Vasiliy Kulikov <segoon@openwall.com>
Date: Sun, 14 Nov 2010 20:06:08 +0300
> snprintf() returns number of bytes that were copied if there is no overflow.
> This code uses return value as number of copied bytes. Theoretically format
> string '%lu.%09lu %pI4:%u %pI4:%u %d %#x %#x %u %u %u %u\n' may be expanded
> up to 163 bytes. In reality tv.tv_sec is just few bytes instead of 20, 2 ports
> are just 5 bytes each instead of 10, length is 5 bytes instead of 10. The rest
> is an unstrusted input. Theoretically if tv_sec is big then copy_to_user() would
> overflow tbuf.
>
> tbuf was increased to fit in 163 bytes. snprintf() is used to follow return
> value semantic.
>
> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
Applied, thanks.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox