* Re: 2.6.37-rc2-git4: Reported regressions 2.6.35 -> 2.6.36
From: Jesse Gross @ 2010-11-19 0:36 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linux Kernel Mailing List, Maciej Rutecki, Florian Mickler,
Andrew Morton, Linus Torvalds, Kernel Testers List,
Network Development, Linux ACPI, Linux PM List, Linux SCSI List,
Linux Wireless List, DRI
In-Reply-To: <tTUH_XeInOH.A.dMF.c3b5MB@chimera>
On Thu, Nov 18, 2010 at 3:50 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=20462
> Subject : 2.6.36-rc7-git2 - panic/GPF: e1000e/vlans?
> Submitter : Nikola Ciprich <extmaillist@linuxbox.cz>
> Date : 2010-10-15 7:10 (35 days old)
> Message-ID : <20101015071008.GA8714@pcnci.linuxbox.cz>
> References : http://marc.info/?l=linux-kernel&m=128712984831303&w=2
A fix for this has been sent to -stable:
http://www.spinics.net/lists/netdev/msg146227.html
^ permalink raw reply
* Re: [PATCH 0/15] RFC: create drivers/net/legacy for ISA, EISA, MCA drivers
From: Jeff Kirsher @ 2010-11-19 0:34 UTC (permalink / raw)
To: Joe Perches; +Cc: Paul Gortmaker, davem@davemloft.net, netdev@vger.kernel.org
In-Reply-To: <1290124345.1817.53.camel@Joe-Laptop>
[-- Attachment #1: Type: text/plain, Size: 819 bytes --]
On Thu, 2010-11-18 at 15:52 -0800, Joe Perches wrote:
> On Thu, 2010-11-04 at 19:28 -0700, Jeff Kirsher wrote:
> > Joe and I are working to organize the drivers into
> > /drivers/net/<technology> directories and to cleanup the Kconfig to
> > reflect the organization. Ethernet drivers will be in
> > /drivers/net/ethernet, and so on.
> []
> > We are hoping not to drag this out and plan on getting this into
> > 2.6.38 (net-next) within the couple of weeks.
>
> What is an appropriate time frame for doing these
> reorganization file/directory moves for net-next?
>
> David, do you have a preference?
>
I am almost ~50% done with the patch, I am hoping to get the patch out
this weekend. I have been testing as I go to ensure that there are no
breakages,that has been the reason for the delay.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply
* [PATCH] SuperH IrDA: correct Baud rate error correction
From: Nicolas Kaiser @ 2010-11-19 0:24 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: Kuninori Morimoto, irda-users, netdev, linux-kernel
It looks to me as if the second value of rate_err_array is intended
to be a decimal 625. However, with a leading 0 it becomes an octal
constant, and as such evaluates to a decimal 405.
Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
---
drivers/net/irda/sh_sir.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/irda/sh_sir.c b/drivers/net/irda/sh_sir.c
index 00b38bc..52a7c86 100644
--- a/drivers/net/irda/sh_sir.c
+++ b/drivers/net/irda/sh_sir.c
@@ -258,7 +258,7 @@ static int sh_sir_set_baudrate(struct sh_sir_self *self, u32 baudrate)
/* Baud Rate Error Correction x 10000 */
u32 rate_err_array[] = {
- 0000, 0625, 1250, 1875,
+ 0, 625, 1250, 1875,
2500, 3125, 3750, 4375,
5000, 5625, 6250, 6875,
7500, 8125, 8750, 9375,
--
1.7.2.2
^ permalink raw reply related
* Re: error while building the kernel Mainline
From: Simon Horman @ 2010-11-19 0:20 UTC (permalink / raw)
To: Justin P. Mattock
Cc: Patrick McHardy, David Miller, randy.dunlap, eric.dumazet,
linux-net, linux-kernel, netdev, netfilter-devel
In-Reply-To: <4CE5BB30.5080209@gmail.com>
On Thu, Nov 18, 2010 at 03:48:00PM -0800, Justin P. Mattock wrote:
> On 11/18/2010 01:48 PM, Patrick McHardy wrote:
> >Am 18.11.2010 22:15, schrieb David Miller:
> >>From: David Miller<davem@davemloft.net>
> >>Date: Thu, 18 Nov 2010 13:10:04 -0800 (PST)
> >>
> >>>From: Randy Dunlap<randy.dunlap@oracle.com>
> >>>Date: Thu, 18 Nov 2010 13:03:18 -0800
> >>>
> >>>>On Thu, 18 Nov 2010 12:54:51 -0800 (PST) David Miller wrote:
> >>>>
> >>>>>From: Patrick McHardy<kaber@trash.net>
> >>>>>Date: Thu, 18 Nov 2010 21:32:11 +0100
> >>>>>
> >>>>>>Thanks for testing. Dave, please apply directly, thanks!
> >>>>
> >>>>Dave,
> >>>>
> >>>>This patch does not fix the config/build error that I posted for linux-next.
> >>>
> >>>And it has bugs, now when NF_CONNTRACT is set to "m" IPVS isn't offered
> >>>at all.
> >>>
> >>>So I'm reverting.
> >>
> >>Ignore this, I was looking for "*_IPVS" in the config instead of
> >>"*_IP_VS" for some stupid reason.
> >
> >I always make the same mistake :)
> >
> >>Patch is sane and I'll look into Randy's problem when I get a chance.
> >>:-)
> >
> >I've already asked the tproxy guys to look into this, it's a
> >different problem that requires more tproxy knowledge than
> >have.
> >
>
>
> go outside to clean the garage, and put up the christmas lights up,
> come back and am freaking for a second that the problems not
> fixed...
>
> tripping me out man!!
On a similar note, sorry for not participating in the IPVS portion of
this thread, it was all over by the time that I woke up this morning.
^ permalink raw reply
* linux-next: manual merge of the net tree with the net-current tree
From: Stephen Rothwell @ 2010-11-19 0:17 UTC (permalink / raw)
To: David Miller, netdev; +Cc: linux-next, linux-kernel, Eric Dumazet
[-- Attachment #1: Type: text/plain, Size: 514 bytes --]
Hi all,
Today's linux-next merge of the net tree got a conflict in
drivers/net/bonding/bond_main.c between commit
3006bc38895895f1a0352c2e17e1a503f35f7e2f ("bonding: fix a race in IGMP
handling") from the net-current tree and commit
866f3b25a2eb60d7529c227a0ecd80c3aba443fd ("bonding: IGMP handling
cleanup") from the net tree.
I just assumed that the latter is a better solution and used that.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply
* linux-next: manual merge of the net tree with the net-current tree
From: Stephen Rothwell @ 2010-11-19 0:17 UTC (permalink / raw)
To: David Miller, netdev; +Cc: linux-next, linux-kernel, Thomas Graf
Hi all,
Today's linux-next merge of the net tree got a conflict in
net/ipv6/addrconf.c between commit
18a31e1e282f9ed563b131526a88162ccbe04ee3 ("ipv6: Expose reachable and
retrans timer values as msecs") from the net-current tree and commit
b382b191ea9e9ccefc437433d23befe91f4a8925 ("ipv6: AF_INET6 link address
family") from the net tree.
I fixed it up (I think - see below) and can carry the fix as necessary.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
diff --cc net/ipv6/addrconf.c
index 2fc35b3,470e7ac..0000000
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@@ -3896,6 -3894,69 +3899,68 @@@ static void snmp6_fill_stats(u64 *stats
}
}
+ static int inet6_fill_ifla6_attrs(struct sk_buff *skb, struct inet6_dev *idev)
+ {
+ struct nlattr *nla;
+ struct ifla_cacheinfo ci;
+
+ NLA_PUT_U32(skb, IFLA_INET6_FLAGS, idev->if_flags);
+
+ ci.max_reasm_len = IPV6_MAXPLEN;
- ci.tstamp = (__u32)(TIME_DELTA(idev->tstamp, INITIAL_JIFFIES) / HZ * 100
- + TIME_DELTA(idev->tstamp, INITIAL_JIFFIES) % HZ * 100 / HZ);
- ci.reachable_time = idev->nd_parms->reachable_time;
- ci.retrans_time = idev->nd_parms->retrans_time;
++ ci.tstamp = cstamp_delta(idev->tstamp);
++ ci.reachable_time = jiffies_to_msecs(idev->nd_parms->reachable_time);
++ ci.retrans_time = jiffies_to_msecs(idev->nd_parms->retrans_time);
+ NLA_PUT(skb, IFLA_INET6_CACHEINFO, sizeof(ci), &ci);
+
+ nla = nla_reserve(skb, IFLA_INET6_CONF, DEVCONF_MAX * sizeof(s32));
+ if (nla == NULL)
+ goto nla_put_failure;
+ ipv6_store_devconf(&idev->cnf, nla_data(nla), nla_len(nla));
+
+ /* XXX - MC not implemented */
+
+ nla = nla_reserve(skb, IFLA_INET6_STATS, IPSTATS_MIB_MAX * sizeof(u64));
+ if (nla == NULL)
+ goto nla_put_failure;
+ snmp6_fill_stats(nla_data(nla), idev, IFLA_INET6_STATS, nla_len(nla));
+
+ nla = nla_reserve(skb, IFLA_INET6_ICMP6STATS, ICMP6_MIB_MAX * sizeof(u64));
+ if (nla == NULL)
+ goto nla_put_failure;
+ snmp6_fill_stats(nla_data(nla), idev, IFLA_INET6_ICMP6STATS, nla_len(nla));
+
+ return 0;
+
+ nla_put_failure:
+ return -EMSGSIZE;
+ }
+
+ static size_t inet6_get_link_af_size(const struct net_device *dev)
+ {
+ if (!__in6_dev_get(dev))
+ return 0;
+
+ return inet6_ifla6_size();
+ }
+
+ static int inet6_fill_link_af(struct sk_buff *skb, const struct net_device *dev)
+ {
+ struct inet6_dev *idev = __in6_dev_get(dev);
+
+ if (!idev)
+ return -ENODATA;
+
+ if (inet6_fill_ifla6_attrs(skb, idev) < 0)
+ return -EMSGSIZE;
+
+ return 0;
+ }
+
+ static int inet6_parse_link_af(struct net_device *dev, const struct nlattr *nla)
+ {
+ return -EOPNOTSUPP;
+ }
+
static int inet6_fill_ifinfo(struct sk_buff *skb, struct inet6_dev *idev,
u32 pid, u32 seq, int event, unsigned int flags)
{
^ permalink raw reply
* Re: 2.6.37-rc2-git4: Reported regressions from 2.6.36
From: Alex Deucher @ 2010-11-18 23:52 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linux Kernel Mailing List, Linux SCSI List, Linux ACPI,
Network Development, Linux Wireless List, DRI, Florian Mickler,
Andrew Morton, Kernel Testers List, Linus Torvalds, Linux PM List,
Maciej Rutecki
In-Reply-To: <sKkKYVppECN.A.KhC.Phb5MB@chimera>
On Thu, Nov 18, 2010 at 6:23 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> This message contains a list of some regressions from 2.6.36,
> for which there are no fixes in the mainline known to the tracking team.
> If any of them have been fixed already, please let us know.
>
> If you know of any other unresolved regressions from 2.6.36, please let us
> know either and we'll add them to the list. Also, please let us know
> if any of the entries below are invalid.
>
> Each entry from the list will be sent additionally in an automatic reply
> to this message with CCs to the people involved in reporting and handling
> the issue.
>
>
> Listed regressions statistics:
>
> Date Total Pending Unresolved
> ----------------------------------------
> 2010-11-19 39 29 25
>
>
> Unresolved regressions
> ----------------------
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=23222
> Subject : 2.6.36 radeon KMS: [drm] Cannot find any crtc or sizes
> Submitter : Ján Bednár <jan.bednar@gmail.com>
> Date : 2010-11-18 15:33 (1 days old)
>
I've added a fix to that bug.
Alex
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=23142
> Subject : autofs4 hang in 2.6.37-rc1
> Submitter : Avi Kivity <avi@redhat.com>
> Date : 2010-11-14 12:55 (5 days old)
> Message-ID : <4CDFDC2B.6040205@redhat.com>
> References : http://marc.info/?l=linux-kernel&m=128973936026185&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=23122
> Subject : Regression in 2.6.37-rc1 for Intel 915 Graphics Adapter - bisected to commit e9e331a
> Submitter : Larry Finger <Larry.Finger@lwfinger.net>
> Date : 2010-11-11 1:47 (8 days old)
> Message-ID : <4CDB4B1D.7000503@lwfinger.net>
> References : http://marc.info/?l=linux-kernel&m=128944001311444&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=23102
> Subject : [bisected] i915 regression in post 2.6.36 kernels
> Submitter : Johannes Hirte <johannes.hirte@fem.tu-ilmenau.de>
> Date : 2010-11-10 7:02 (9 days old)
> Message-ID : <201011100802.20332.johannes.hirte@fem.tu-ilmenau.de>
> References : http://marc.info/?l=linux-kernel&m=128937310017057&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=23092
> Subject : WARNING in tty_io.c
> Submitter : Shan Wei <shanwei@cn.fujitsu.com>
> Date : 2010-11-10 8:06 (9 days old)
> Message-ID : <4CDA5291.4010802@cn.fujitsu.com>
> References : http://marc.info/?l=linux-kernel&m=128937645120159&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=23012
> Subject : ftdi_sio /dev/ttyUSB error: "Resource Temporarily Unavailable"
> Submitter : Kevin Smith <thirdwiggin@gmail.com>
> Date : 2010-11-16 06:25 (3 days old)
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22942
> Subject : [2.6.37-rc1, OOM] virtblk: OOM in do_virtblk_request()
> Submitter : Dave Chinner <david@fromorbit.com>
> Date : 2010-11-05 1:30 (14 days old)
> Message-ID : <20101105013003.GE13830@dastard>
> References : http://marc.info/?l=linux-kernel&m=128892062917641&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22912
> Subject : spi_lm70llp module crash on unload (2.6.37-rc1)
> Submitter : Randy Dunlap <randy.dunlap@oracle.com>
> Date : 2010-11-05 0:16 (14 days old)
> Message-ID : <20101104171620.00d8c95d.randy.dunlap@oracle.com>
> References : http://marc.info/?l=linux-kernel&m=128891627913647&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22882
> Subject : (2.6.37-rc1) amd64-agp module crashed on second load
> Submitter : Randy Dunlap <randy.dunlap@oracle.com>
> Date : 2010-11-05 0:13 (14 days old)
> Message-ID : <20101104171333.fea1f498.randy.dunlap@oracle.com>
> References : http://marc.info/?l=linux-kernel&m=128891605213447&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22812
> Subject : kernel oops on 2.6.37-rc1
> Submitter : Andrew <atswartz@gmail.com>
> Date : 2010-11-12 16:05 (7 days old)
> First-Bad-Commit: http://git.kernel.org/linus/a68c439b1966c91f0ef474e2bf275d6792312726
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22692
> Subject : [regression, 2.6.37-rc1] 'ip link tap0 up' stuck in do_exit()
> Submitter : Dave Chinner <david@fromorbit.com>
> Date : 2010-11-03 6:26 (16 days old)
> Message-ID : <20101103062609.GB31163@dastard>
> References : http://marc.info/?l=linux-kernel&m=128876560131870&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22682
> Subject : [oops, 2.6.37-rc1] Unpacking initramfs failed, oops in free_init_pages()
> Submitter : Dave Chinner <david@fromorbit.com>
> Date : 2010-11-03 1:54 (16 days old)
> Message-ID : <20101103015427.GA31163@dastard>
> References : http://marc.info/?l=linux-kernel&m=128874930119723&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22672
> Subject : Regression in 2.6.37-rc1 for Intel 945 Graphics Adapter - bisected to commit e9e331a
> Submitter : Larry Finger <Larry.Finger@lwfinger.net>
> Date : 2010-11-11 01:56 (8 days old)
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22652
> Subject : [drm:i915_gem_mmap_gtt_ioctl] *ERROR* Attempting to mmap a purgeable buffer
> Submitter : Tobias <devnull@plzk.org>
> Date : 2010-11-10 21:59 (9 days old)
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22642
> Subject : 2.6.37-rc1: Disk takes 10 seconds to resume - MacBook2,1
> Submitter : Tobias <devnull@plzk.org>
> Date : 2010-11-10 19:33 (9 days old)
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22572
> Subject : Linux 2.6.37-rc1 (acpi_video)
> Submitter : Randy Dunlap <randy.dunlap@oracle.com>
> Date : 2010-11-02 18:51 (17 days old)
> Message-ID : <20101102115106.bac57d21.randy.dunlap@oracle.com>
> References : http://marc.info/?l=linux-kernel&m=128872403920449&w=2
> http://marc.info/?l=linux-acpi&m=128874714517914&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22562
> Subject : Regression in 2.6.37-rc1 - logs spammed with "unable to enumerate USB port" - bisected to commit 3df7169e
> Submitter : Larry Finger <Larry.Finger@lwfinger.net>
> Date : 2010-11-02 22:32 (17 days old)
> First-Bad-Commit: http://git.kernel.org/linus/3df7169e73fc1d71a39cffeacc969f6840cdf52b
> Message-ID : <4CD09166.4060202@lwfinger.net>
> References : http://marc.info/?l=linux-kernel&m=128873713207906&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22552
> Subject : AMD boot freeze bisected to b126b4703afa4010b161784a43650337676dd03b
> Submitter : Borislav Petkov <bp@amd64.org>
> Date : 2010-11-02 17:03 (17 days old)
> First-Bad-Commit: http://git.kernel.org/linus/b126b4703afa4010b161784a43650337676dd03b
> Message-ID : <20101102170335.GC24927@aftab>
> References : http://marc.info/?l=linux-kernel&m=128871752109913&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22542
> Subject : [2.6.37-rc1] drm:i195 errors
> Submitter : Paul Rolland <rol@witbe.net>
> Date : 2010-11-02 14:58 (17 days old)
> Message-ID : <20101102155813.09cb2c6e@tux.DEF.witbe.net>
> References : http://marc.info/?l=linux-kernel&m=128870991628970&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22532
> Subject : 2.6.37-rc1: BUG: scheduling while atomic (kvm_init)
> Submitter : Thomas Meyer <thomas@m3y3r.de>
> Date : 2010-11-02 19:06 (17 days old)
> Message-ID : <50AA24C585B14210A44AB599605C7CBD@hugo>
> References : http://marc.info/?l=linux-kernel&m=128872479921559&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22522
> Subject : 2.6.37-rc1 boot Problem - BUG: unable to handle kernel null pointer - dmesg und config Datei
> Submitter : werner <w.landgraf@ru.ru>
> Date : 2010-11-02 2:09 (17 days old)
> Message-ID : <web-395697375@zbackend1.aha.ru>
> References : http://marc.info/?l=linux-kernel&m=128866380110940&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22472
> Subject : vga_switcheroo fails to switch from intel to ati
> Submitter : Radu Andries <admiral0@tuxfamily.org>
> Date : 2010-11-08 16:46 (11 days old)
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22282
> Subject : 2.6.37-rc1: WARNING..debugobjects: ODEBUG: free active (active state 0) object type: percpu_counter
> Submitter : Randy Dunlap <randy.dunlap@oracle.com>
> Date : 2010-11-01 21:58 (18 days old)
> Message-ID : <4CCF37E8.1070208@oracle.com>
> References : http://marc.info/?l=linux-kernel&m=128864879328429&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22102
> Subject : [2.6.36-09452-g2d10d87] BUG: unable to handle kernel NULL pointer dereference at (null)
> Submitter : Carlos R. Mafra <crmafra2@gmail.com>
> Date : 2010-10-30 20:07 (20 days old)
> Message-ID : <20101030200751.GA2866@Pilar.aei.mpg.de>
> References : http://marc.info/?l=linux-kernel&m=128846935825136&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22082
> Subject : 2.6.36-git11 -- kernel/pid.c:419 invoked rcu_dereference_check() without protection!
> Submitter : Miles Lane <miles.lane@gmail.com>
> Date : 2010-10-29 5:22 (21 days old)
> Message-ID : <AANLkTimGgzOZb8EwUQO16cZcL+ycveKTYzg_AAX+D+Kw@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=128832975924288&w=2
>
>
> Regressions with patches
> ------------------------
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22962
> Subject : building (e)glibc against 2.6.37-rc1 headers fails
> Submitter : <stephan@openelec.tv>
> Date : 2010-11-15 00:09 (4 days old)
> Patch : https://bugzilla.kernel.org/show_bug.cgi?id=22962#c5
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22932
> Subject : [REGRESSION] [2.6.37-rc1] Fan noise after suspend to ram/disk
> Submitter : Maciej Rutecki <maciej.rutecki@gmail.com>
> Date : 2010-11-04 16:06 (15 days old)
> First-Bad-Commit: http://git.kernel.org/linus/3e384ee6c687cb397581ee8f9440fc8220cfac80
> Message-ID : <201011041706.59046.maciej.rutecki@gmail.com>
> References : http://marc.info/?l=linux-kernel&m=128888684308982&w=2
> Handled-By : Rafael J. Wysocki <rjw@sisk.pl>
> Patch : https://bugzilla.kernel.org/attachment.cgi?id=37372
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22722
> Subject : regression since 2.6.36: backlight in sony-laptop not working
> Submitter : Norbert Preining <preining@logic.at>
> Date : 2010-11-04 14:29 (15 days old)
> Message-ID : <20101104142915.GC7650@gamma.logic.tuwien.ac.at>
> References : http://marc.info/?l=linux-kernel&m=128888097600601&w=2
> Handled-By : Mattia Dongili <malattia@linux.it>
> Patch : https://bugzilla.kernel.org/attachment.cgi?id=37442
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22662
> Subject : divide error in select_task_rq_fair()
> Submitter : Myron Stowe <myron.stowe@hp.com>
> Date : 2010-11-10 23:58 (9 days old)
> Patch : http://lkml.org/lkml/2010/11/13/176
>
>
> For details, please visit the bug entries and follow the links given in
> references.
>
> As you can see, there is a Bugzilla entry for each of the listed regressions.
> There also is a Bugzilla entry used for tracking the regressions from 2.6.36,
> unresolved as well as resolved, at:
>
> http://bugzilla.kernel.org/show_bug.cgi?id=21782
>
> Please let the tracking team know if there are any Bugzilla entries that
> should be added to the list in there.
>
> Thanks!
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
^ permalink raw reply
* Re: [PATCH 0/15] RFC: create drivers/net/legacy for ISA, EISA, MCA drivers
From: Joe Perches @ 2010-11-18 23:52 UTC (permalink / raw)
To: Jeff Kirsher; +Cc: Paul Gortmaker, davem@davemloft.net, netdev@vger.kernel.org
In-Reply-To: <AANLkTim2yH7eAqqYQW+JVC5GtFR5mX4uZnMa02+yubFk@mail.gmail.com>
On Thu, 2010-11-04 at 19:28 -0700, Jeff Kirsher wrote:
> Joe and I are working to organize the drivers into
> /drivers/net/<technology> directories and to cleanup the Kconfig to
> reflect the organization. Ethernet drivers will be in
> /drivers/net/ethernet, and so on.
[]
> We are hoping not to drag this out and plan on getting this into
> 2.6.38 (net-next) within the couple of weeks.
What is an appropriate time frame for doing these
reorganization file/directory moves for net-next?
David, do you have a preference?
^ permalink raw reply
* 2.6.37-rc2-git4: Reported regressions 2.6.35 -> 2.6.36
From: Rafael J. Wysocki @ 2010-11-18 23:50 UTC (permalink / raw)
To: Linux Kernel Mailing List
Cc: Maciej Rutecki, Florian Mickler, Andrew Morton, Linus Torvalds,
Kernel Testers List, Network Development, Linux ACPI,
Linux PM List, Linux SCSI List, Linux Wireless List, DRI
This message contains a list of some post-2.6.35 regressions introduced before
2.6.36, for which there are no fixes in the mainline known to the tracking team.
If any of them have been fixed already, please let us know.
If you know of any other unresolved post-2.6.35 regressions, please let us know
either and we'll add them to the list. Also, please let us know if any
of the entries below are invalid.
Each entry from the list will be sent additionally in an automatic reply to
this message with CCs to the people involved in reporting and handling the
issue.
Listed regressions statistics:
Date Total Pending Unresolved
----------------------------------------
2010-11-19 92 38 34
2010-10-17 70 27 27
2010-10-10 56 16 15
2010-10-03 52 16 14
2010-09-26 46 15 13
2010-09-20 38 15 15
2010-09-12 28 14 13
2010-08-30 21 16 15
Unresolved regressions
----------------------
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=23212
Subject : multifunction card reader of acer aspire one stopped working
Submitter : Thibault Mondary <thibm@free.fr>
Date : 2010-11-18 14:03 (1 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=23132
Subject : without "pci=nocrs", Dell Inspiron 1545 hangs
Submitter : Bjorn Helgaas <bjorn.helgaas@hp.com>
Date : 2010-11-17 19:18 (2 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=23062
Subject : kvm segfaults on 2.6.36-64bit kernel with 32 bit userspace
Submitter : Jorge Boncompte <jorge@dti2.net>
Date : 2010-11-17 11:59 (2 days old)
First-Bad-Commit: http://git.kernel.org/linus/9581d442b905
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22842
Subject : iwl3945 suddenly stops working
Submitter : Felipe Contreras <felipe.contreras@gmail.com>
Date : 2010-11-14 11:14 (5 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22782
Subject : 2.6.36: general protection fault during lockfs lockspace removal
Submitter : nik@linuxbox.cz <nik@linuxbox.cz>
Date : 2010-11-12 12:05 (7 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22732
Subject : 2.6.37-rc1: hibernation breaks swap
Submitter : Zhang Rui <rui.zhang@intel.com>
Date : 2010-11-11 08:38 (8 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22272
Subject : High [extra timer interrupt] count in powertop since 2.6.36
Submitter : Ian Kumlien <pomac@demius.net>
Date : 2010-10-30 23:52 (20 days old)
Message-ID : <alpine.LNX.2.00.1010310148450.24290@twilight.pomac.com>
References : http://marc.info/?l=linux-kernel&m=128848330304431&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22172
Subject : alsa-util.c: snd_pcm_avail_delay() returned strange values: delay 0 is less than avail 32
Submitter : Tobias <devnull@plzk.org>
Date : 2010-11-06 09:33 (13 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22092
Subject : Kernel v2.6.36 trouble on USB disconnect
Submitter : Ketil Froyn <ketil@froyn.name>
Date : 2010-10-29 8:05 (21 days old)
Message-ID : <AANLkTik5qVxkEGVAA1PSOGk2KTW+ekHpSwttsQEWzWj+@mail.gmail.com>
References : http://marc.info/?l=linux-kernel&m=128833956503607&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=21932
Subject : Regression in 2.6.36 in single stepping over hardware breakpoint (Wine)
Submitter : Michael Stefaniuc <mstefani@redhat.com>
Date : 2010-10-28 0:12 (22 days old)
Message-ID : <4CC8BFDD.8080600@redhat.com>
References : http://marc.info/?l=linux-kernel&m=128822477714448&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=21662
Subject : 2.6.35->2.6.36 regression, vanilla kernel panic, ppp or hrtimers crashing
Submitter : Denys Fedoryshchenko <nuclearcat@nuclearcat.com>
Date : 2010-10-25 9:22 (25 days old)
Message-ID : <201010251222.37191.nuclearcat@nuclearcat.com>
References : http://marc.info/?l=linux-kernel&m=128799855826011&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=21652
Subject : several problems with intel graphics since 2.6.36
Submitter : Norbert Preining <preining@logic.at>
Date : 2010-10-27 14:32 (23 days old)
Message-ID : <20101027143252.GA8676@gamma.logic.tuwien.ac.at>
References : http://marc.info/?l=linux-kernel&m=128818998630241&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=21402
Subject : [KVM] Noacpi Windows guest can not boot up on 32bit KVM host
Submitter : xudong <xudong.hao@intel.com>
Date : 2010-10-29 03:01 (21 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=21372
Subject : NULL pointer deference at disk_replace_part_tbl+0x32
Submitter : Luis R. Rodriguez <mcgrof@gmail.com>
Date : 2010-10-28 17:22 (22 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=21332
Subject : Regression in single stepping over hardware breakpoint (Wine)
Submitter : Michael Stefaniuc <mstefani@redhat.com>
Date : 2010-10-27 23:41 (23 days old)
First-Bad-Commit: http://git.kernel.org/linus/0c4519e825c9e2b6a8310deff8582f8c35bfbba9
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=20462
Subject : 2.6.36-rc7-git2 - panic/GPF: e1000e/vlans?
Submitter : Nikola Ciprich <extmaillist@linuxbox.cz>
Date : 2010-10-15 7:10 (35 days old)
Message-ID : <20101015071008.GA8714@pcnci.linuxbox.cz>
References : http://marc.info/?l=linux-kernel&m=128712984831303&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=20352
Subject : Fwd: Re: UML kernel crash of v2.6.36-rcX kernel
Submitter : Toralf Förster <toralf.foerster@gmx.de>
Date : 2010-10-13 11:28 (37 days old)
First-Bad-Commit: http://git.kernel.org/linus/365b18189789bfa1acd9939e6312b8a4b4577b28
Message-ID : <201010131328.06465.toralf.foerster@gmx.de>
References : http://marc.info/?l=linux-kernel&m=128696930132503&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=20342
Subject : [LogFS] [2.6.36-rc7] Deadlock in logfs_get_wblocks, hold and wait on same lock super->s_write_mutex
Submitter : Prasad Joshi <prasadjoshi124@gmail.com>
Date : 2010-10-13 9:49 (37 days old)
Message-ID : <AANLkTinvsMxTxEbDEFmb5M-6fYjdRvErU==Zs7+qANkV@mail.gmail.com>
References : http://marc.info/?l=linux-kernel&m=128696335024718&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=20332
Subject : [LogFS] [2.6.36-rc7] Kernel BUG at lib/btree.c:465!
Submitter : Prasad Joshi <prasadjoshi124@gmail.com>
Date : 2010-10-12 18:56 (38 days old)
Message-ID : <AANLkTimAbCZNhLQ5nADUiAC+7JpAeJBEmjFwdxyZ-FxO@mail.gmail.com>
References : http://marc.info/?l=linux-kernel&m=128690910501830&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=20322
Subject : 2.6.36-rc7: inconsistent lock state: inconsistent {IN-RECLAIM_FS-R} -> {RECLAIM_FS-ON-W} usage.
Submitter : Dave Jones <davej@redhat.com>
Date : 2010-10-11 20:10 (39 days old)
Message-ID : <20101011201007.GA29707@redhat.com>
References : http://marc.info/?l=linux-kernel&m=128682782828453&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=20232
Subject : kworker consumes ~100% CPU on HP Elitebook 8540w running 2.6.36_rc6-git4
Submitter : Ozan Caglayan <ozan@pardus.org.tr>
Date : 2010-10-13 06:13 (37 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=20172
Subject : 2.6.36-rc7 boot stalls unless nolapic_timer - Lenovo S12
Submitter : Chris Vine <chris@cvine.freeserve.co.uk>
Date : 2010-10-10 12:59 (40 days old)
Message-ID : <<20101010135912.76eb61b7@boulder.homenet>>
References : http://marc.info/?l=linux-kernel&m=128671620721712&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=19802
Subject : [drm:init_ring_common] *ERROR* render ring head not reset to zero
Submitter : Thomas Meyer <thomas@m3y3r.de>
Date : 2010-10-04 20:31 (46 days old)
Message-ID : <201010042231.20320.thomas@m3y3r.de>
References : http://marc.info/?l=linux-kernel&m=128622441331199&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=19782
Subject : 2.6.36-rc6-git2 -- BUG dentry: Poison overwritten (after resume from hibernation)
Submitter : Miles Lane <miles.lane@gmail.com>
Date : 2010-10-03 3:54 (47 days old)
Message-ID : <AANLkTimrqtzBHAZSuDhEs_3CKA6pCbM35b1BtKH=MvC_@mail.gmail.com>
References : http://marc.info/?l=linux-kernel&m=128607809314079&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=19632
Subject : 2.6.36-rc6: modprobe Not tainted warning
Submitter : Heinz Diehl <htd@fritha.org>
Date : 2010-09-30 18:25 (50 days old)
Message-ID : <20100930182516.GA15089@fritha.org>
References : http://marc.info/?l=linux-kernel&m=128587114004680&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=19392
Subject : WARNING: at drivers/net/wireless/ath/ath5k/base.c:3475 ath5k_bss_info_changed+0x44/0x168 [ath5k]()
Submitter : Justin Mattock <justinmattock@gmail.com>
Date : 2010-09-28 22:30 (52 days old)
Message-ID : <AANLkTim5WCGKPvEkOkO_YnMF9pg8mvLfQoFBNUFpfa_k@mail.gmail.com>
References : http://marc.info/?l=linux-kernel&m=128571307018635&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=19372
Subject : 2.6.36-rc6: WARNING: at drivers/gpu/drm/radeon/radeon_fence.c:235 radeon_fence_wait+0x35a/0x3c0
Submitter : Alexey Dobriyan <adobriyan@gmail.com>
Date : 2010-09-29 21:29 (51 days old)
Message-ID : <20100929212923.GA5578@core2.telecom.by>
References : http://marc.info/?l=linux-kernel&m=128579579400315&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=19142
Subject : Screen flickers when switching from the console to X
Submitter : Andrey Rahmatullin <wrar@altlinux.org>
Date : 2010-09-27 12:05 (53 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=19052
Subject : 2.6.36-rc5-git1 -- [drm:i915_report_and_clear_eir] *ERROR* EIR stuck: 0x00000010, masking
Submitter : Miles Lane <miles.lane@gmail.com>
Date : 2010-09-22 23:47 (58 days old)
Message-ID : <AANLkTikWQjUQjFJU9MO1+XbSLAEE-GARz+S+Dz2Fgu4h@mail.gmail.com>
References : http://marc.info/?l=linux-kernel&m=128519926626322&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=19002
Subject : Radeon rv730 AGP/KMS/DRM kernel lockup
Submitter : Duncan <1i5t5.duncan@cox.net>
Date : 2010-09-23 16:48 (57 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=17121
Subject : Two blank rectangles more than 10 cm long when booting
Submitter : Eric Valette <eric.valette@free.fr>
Date : 2010-08-26 17:24 (85 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=17061
Subject : 2.6.36-rc1 on zaurus: bluetooth regression
Submitter : Pavel Machek <pavel@ucw.cz>
Date : 2010-08-21 15:24 (90 days old)
Message-ID : <20100821152445.GA1536@ucw.cz>
References : http://marc.info/?l=linux-kernel&m=128240433828087&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16971
Subject : qla4xxx compile failure on 32-bit PowerPC: missing readq and writeq
Submitter : Meelis Roos <mroos@linux.ee>
Date : 2010-08-19 21:03 (92 days old)
Message-ID : <<alpine.SOC.1.00.1008192359310.19654@math.ut.ee>>
References : http://marc.info/?l=linux-kernel&m=128225184900892&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16951
Subject : hackbench regression with 2.6.36-rc1
Submitter : Zhang, Yanmin <yanmin_zhang@linux.intel.com>
Date : 2010-08-18 6:18 (93 days old)
Message-ID : <1282112318.21202.8.camel@ymzhang.sh.intel.com>
References : http://marc.info/?l=linux-kernel&m=128211235904910&w=2
Regressions with patches
------------------------
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22452
Subject : data corruption after mmap()ing a file and writev() some data to another file
Submitter : Marius Tolzmann <tolzmann@molgen.mpg.de>
Date : 2010-11-08 10:33 (11 days old)
Patch : http://www.spinics.net/lists/xfs/msg02126.html
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=21092
Subject : Kernel 2.6.36 Bug during quotaon on reiserfs
Submitter : <markus.gapp@gmx.net>
Date : 2010-10-24 16:57 (26 days old)
Handled-By : Jan Kara <jack@suse.cz>
Patch : https://bugzilla.kernel.org/attachment.cgi?id=35292
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=20182
Subject : 2.6.36-rc7: NULL pointer dereference in ehci_clear_tt_buffer_complete
Submitter : Stefan Richter <stefanr@s5r6.in-berlin.de>
Date : 2010-10-11 20:56 (39 days old)
Message-ID : <tkrat.9f585ea47331a2a2@s5r6.in-berlin.de>
References : http://marc.info/?l=linux-kernel&m=128683064431749&w=2
Handled-By : Alan Stern <stern@rowland.harvard.edu>
Patch : https://patchwork.kernel.org/patch/250761/
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=20162
Subject : [LogFS][2.6.36.rc7+] Kernel BUG at readwrite.c:1193
Submitter : Prasad Joshi <prasadjoshi124@gmail.com>
Date : 2010-10-10 17:44 (40 days old)
Message-ID : <AANLkTi=JkcuWBPo+X-i+9o-BJFVqjea1J3e=Mr=HvAWF@mail.gmail.com>
References : http://marc.info/?l=linux-kernel&m=128673196203340&w=2
Handled-By : Prasad Gajanan Joshi <prasadjoshi124@gmail.com>
Patch : https://bugzilla.kernel.org/show_bug.cgi?id=20162#c1
For details, please visit the bug entries and follow the links given in
references.
As you can see, there is a Bugzilla entry for each of the listed regressions.
There also is a Bugzilla entry used for tracking the regressions introduced
between 2.6.35 and 2.6.36, unresolved as well as resolved, at:
http://bugzilla.kernel.org/show_bug.cgi?id=16444
Please let the tracking team know if there are any Bugzilla entries that
should be added to the list in there.
Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH 1/2] of/phylib: Use device tree properties to initialize Marvell PHYs.
From: David Daney @ 2010-11-18 23:48 UTC (permalink / raw)
To: Grant Likely
Cc: netdev-u79uwXL29TY76Z2rM5mHXA,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, Cyril Chemparathy,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Arnaud Patard
In-Reply-To: <20101118204036.GA16908-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org>
On 11/18/2010 12:40 PM, Grant Likely wrote:
> On Wed, Nov 17, 2010 at 03:54:30PM -0800, David Daney wrote:
>> Some aspects of PHY initialization are board dependent, things like
>> indicator LED connections and some clocking modes cannot be determined
>> by probing. The dev_flags element of struct phy_device can be used to
>> control these things if an appropriate value can be passed from the
>> Ethernet driver. We run into problems however if the PHY connections
>> are specified by the device tree. There is no way for the Ethernet
>> driver to know what flags it should pass.
>>
>> If we are using the device tree, the struct phy_device will be
>> populated with the device tree node corresponding to the PHY, and we
>> can extract extra configuration information from there.
>>
>> The next question is what should the format of that information be?
>> It is highly device specific, and the device tree representation
>> should not be tied to any arbitrary kernel defined constants. A
>> straight forward representation is just to specify the exact bits that
>> should be set using the "marvell,reg-init" property:
>>
>> phy5: ethernet-phy@5 {
>> reg =<5>;
>> device_type = "ethernet-phy";
>
> Some notes:
> - device_type is only relevant for real openfirmware platforms. It
> should not appear in dts files.
Documentation/powerpc/dts-bindings/phy.txt says device_type should be
here. I can remove it from my patch comment, but should it also be
removed from the phy.txt file?
> - This example phy node needs a compatible property
Ok, what would you suggest? Something like:
compatible = "marvell,88e1145";
I can certainly do that, but I would note that the kernel probes these
things and would completely ignore the compatible property.
> - This new binding needs to be documented. You can use devicetree.org.
>
Agreed, I was planning to do that once the patch was approved.
Where would that go? Vendor:Marvell, or Type:PHY/compatible=marvell,*
... or somewhere else?
>> marvell,reg-init =
>> <0x00030010 0x5777>, /* Reg 3,16<- 0x5777 */
>> <0x00030011 0x00aa>, /* Reg 3,17<- 0x00aa */
>> <0x00030012 0x4105>, /* Reg 3,18<- 0x4105 */
>> <0x00030013 0x0060>; /* Reg 3,19<- 0x0060 */
>> <0x00020015 0x00300000>; /* clear bits 4..5 of Reg 2,21 */
>> };
>>
Thanks,
David Daney
^ permalink raw reply
* Re: error while building the kernel Mainline
From: Justin P. Mattock @ 2010-11-18 23:48 UTC (permalink / raw)
To: Patrick McHardy
Cc: David Miller, randy.dunlap, eric.dumazet, linux-net, linux-kernel,
netdev, horms, netfilter-devel
In-Reply-To: <4CE59F3F.3080407@trash.net>
On 11/18/2010 01:48 PM, Patrick McHardy wrote:
> Am 18.11.2010 22:15, schrieb David Miller:
>> From: David Miller<davem@davemloft.net>
>> Date: Thu, 18 Nov 2010 13:10:04 -0800 (PST)
>>
>>> From: Randy Dunlap<randy.dunlap@oracle.com>
>>> Date: Thu, 18 Nov 2010 13:03:18 -0800
>>>
>>>> On Thu, 18 Nov 2010 12:54:51 -0800 (PST) David Miller wrote:
>>>>
>>>>> From: Patrick McHardy<kaber@trash.net>
>>>>> Date: Thu, 18 Nov 2010 21:32:11 +0100
>>>>>
>>>>>> Thanks for testing. Dave, please apply directly, thanks!
>>>>
>>>> Dave,
>>>>
>>>> This patch does not fix the config/build error that I posted for linux-next.
>>>
>>> And it has bugs, now when NF_CONNTRACT is set to "m" IPVS isn't offered
>>> at all.
>>>
>>> So I'm reverting.
>>
>> Ignore this, I was looking for "*_IPVS" in the config instead of
>> "*_IP_VS" for some stupid reason.
>
> I always make the same mistake :)
>
>> Patch is sane and I'll look into Randy's problem when I get a chance.
>> :-)
>
> I've already asked the tproxy guys to look into this, it's a
> different problem that requires more tproxy knowledge than
> have.
>
go outside to clean the garage, and put up the christmas lights up, come
back and am freaking for a second that the problems not fixed...
tripping me out man!!
Justin P. Mattock
^ permalink raw reply
* Re: [RFC PATCH] netfilter: remove the duplicate tables
From: Changli Gao @ 2010-11-18 23:36 UTC (permalink / raw)
To: Eric Dumazet; +Cc: Patrick McHardy, David S. Miller, netfilter-devel, netdev
In-Reply-To: <1290095020.2781.203.camel@edumazet-laptop>
On Thu, Nov 18, 2010 at 11:43 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Le jeudi 18 novembre 2010 à 22:39 +0800, Changli Gao a écrit :
>> As only xt_counters are private to each CPU, we don't need to maintain
>> a whole individual table for each CPU.
>>
>> In the kernel space, we use the memory of ipt_entry.counters to save a
>> pointer to a percpu xt_counters. When iptables runs, it only update the
>> counters on its own CPU.
>>
>> On non SMP platforms, no change is made.
>>
>> Only the code of iptables is converted. Thanks for reviews.
>>
>
> Changli
>
> I answered you a (difficult) work was in progress, still you post a
> patch that needs our review and time ? This is crazy.
Sorry for interrupt, and thanks for review. I posted this patch to
check if I was in the right direction.
>
> I am tempted to stop here. Oh well...
>
> Your way of allocating a percpu counter for each counter is a pure TLB
> and cache line blower (up to two cache lines per counter), not counting
> the time needed to load a new table with 10.000 entries. Some people
> still use scripts with hundred of calls to iptables.
>
> percpu_alloc() is not meant to be used thousand of times per second. It
> is not scalable.
>
> You consume 16 bytes per counter in the main table, while 4 bytes index
> should be enough on SMP build. Most firewalls I know use two or four
> cpus at most.
I think we can't change the structure of ipt_entry, as it is exposed
to userspace as an ABI. Though there is no need to keep the same
structure in the kernel space, converting is a big work. :)
>
> They care about speed, not really because iptables duplicates table on
> each cpu. By the way, not using NUMA can definitly hurt firewalls with
> many rules, unless you make sure the main table is vmalloced() with node
> distribution, not a single node. Even with this, this can hurt
> latencies.
This is what I worry about. I think only test can verify it.
>
> Allocating one contiguous percpu var for all counters is a must.
>
> Problem is : percpu alloc doesnt allow big allocations.
>
> #define PCPU_MIN_UNIT_SIZE PFN_ALIGN(32 << 10)
>
> So max allocation is 32 Kbytes, thats 2048 'xt_counters' only.
> -> cannot really use pcpu-alloc, but a kmalloc_node() or vmalloc_node()
> per cpu
>
Thanks. I'll try.
--
Regards,
Changli Gao(xiaosuo@gmail.com)
^ permalink raw reply
* 2.6.37-rc2-git4: Reported regressions from 2.6.36
From: Rafael J. Wysocki @ 2010-11-18 23:23 UTC (permalink / raw)
To: Linux Kernel Mailing List
Cc: Maciej Rutecki, Florian Mickler, Andrew Morton, Linus Torvalds,
Kernel Testers List, Network Development, Linux ACPI,
Linux PM List, Linux SCSI List, Linux Wireless List, DRI
This message contains a list of some regressions from 2.6.36,
for which there are no fixes in the mainline known to the tracking team.
If any of them have been fixed already, please let us know.
If you know of any other unresolved regressions from 2.6.36, please let us
know either and we'll add them to the list. Also, please let us know
if any of the entries below are invalid.
Each entry from the list will be sent additionally in an automatic reply
to this message with CCs to the people involved in reporting and handling
the issue.
Listed regressions statistics:
Date Total Pending Unresolved
----------------------------------------
2010-11-19 39 29 25
Unresolved regressions
----------------------
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=23222
Subject : 2.6.36 radeon KMS: [drm] Cannot find any crtc or sizes
Submitter : Ján Bednár <jan.bednar@gmail.com>
Date : 2010-11-18 15:33 (1 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=23142
Subject : autofs4 hang in 2.6.37-rc1
Submitter : Avi Kivity <avi@redhat.com>
Date : 2010-11-14 12:55 (5 days old)
Message-ID : <4CDFDC2B.6040205@redhat.com>
References : http://marc.info/?l=linux-kernel&m=128973936026185&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=23122
Subject : Regression in 2.6.37-rc1 for Intel 915 Graphics Adapter - bisected to commit e9e331a
Submitter : Larry Finger <Larry.Finger@lwfinger.net>
Date : 2010-11-11 1:47 (8 days old)
Message-ID : <4CDB4B1D.7000503@lwfinger.net>
References : http://marc.info/?l=linux-kernel&m=128944001311444&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=23102
Subject : [bisected] i915 regression in post 2.6.36 kernels
Submitter : Johannes Hirte <johannes.hirte@fem.tu-ilmenau.de>
Date : 2010-11-10 7:02 (9 days old)
Message-ID : <201011100802.20332.johannes.hirte@fem.tu-ilmenau.de>
References : http://marc.info/?l=linux-kernel&m=128937310017057&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=23092
Subject : WARNING in tty_io.c
Submitter : Shan Wei <shanwei@cn.fujitsu.com>
Date : 2010-11-10 8:06 (9 days old)
Message-ID : <4CDA5291.4010802@cn.fujitsu.com>
References : http://marc.info/?l=linux-kernel&m=128937645120159&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=23012
Subject : ftdi_sio /dev/ttyUSB error: "Resource Temporarily Unavailable"
Submitter : Kevin Smith <thirdwiggin@gmail.com>
Date : 2010-11-16 06:25 (3 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22942
Subject : [2.6.37-rc1, OOM] virtblk: OOM in do_virtblk_request()
Submitter : Dave Chinner <david@fromorbit.com>
Date : 2010-11-05 1:30 (14 days old)
Message-ID : <20101105013003.GE13830@dastard>
References : http://marc.info/?l=linux-kernel&m=128892062917641&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22912
Subject : spi_lm70llp module crash on unload (2.6.37-rc1)
Submitter : Randy Dunlap <randy.dunlap@oracle.com>
Date : 2010-11-05 0:16 (14 days old)
Message-ID : <20101104171620.00d8c95d.randy.dunlap@oracle.com>
References : http://marc.info/?l=linux-kernel&m=128891627913647&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22882
Subject : (2.6.37-rc1) amd64-agp module crashed on second load
Submitter : Randy Dunlap <randy.dunlap@oracle.com>
Date : 2010-11-05 0:13 (14 days old)
Message-ID : <20101104171333.fea1f498.randy.dunlap@oracle.com>
References : http://marc.info/?l=linux-kernel&m=128891605213447&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22812
Subject : kernel oops on 2.6.37-rc1
Submitter : Andrew <atswartz@gmail.com>
Date : 2010-11-12 16:05 (7 days old)
First-Bad-Commit: http://git.kernel.org/linus/a68c439b1966c91f0ef474e2bf275d6792312726
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22692
Subject : [regression, 2.6.37-rc1] 'ip link tap0 up' stuck in do_exit()
Submitter : Dave Chinner <david@fromorbit.com>
Date : 2010-11-03 6:26 (16 days old)
Message-ID : <20101103062609.GB31163@dastard>
References : http://marc.info/?l=linux-kernel&m=128876560131870&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22682
Subject : [oops, 2.6.37-rc1] Unpacking initramfs failed, oops in free_init_pages()
Submitter : Dave Chinner <david@fromorbit.com>
Date : 2010-11-03 1:54 (16 days old)
Message-ID : <20101103015427.GA31163@dastard>
References : http://marc.info/?l=linux-kernel&m=128874930119723&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22672
Subject : Regression in 2.6.37-rc1 for Intel 945 Graphics Adapter - bisected to commit e9e331a
Submitter : Larry Finger <Larry.Finger@lwfinger.net>
Date : 2010-11-11 01:56 (8 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22652
Subject : [drm:i915_gem_mmap_gtt_ioctl] *ERROR* Attempting to mmap a purgeable buffer
Submitter : Tobias <devnull@plzk.org>
Date : 2010-11-10 21:59 (9 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22642
Subject : 2.6.37-rc1: Disk takes 10 seconds to resume - MacBook2,1
Submitter : Tobias <devnull@plzk.org>
Date : 2010-11-10 19:33 (9 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22572
Subject : Linux 2.6.37-rc1 (acpi_video)
Submitter : Randy Dunlap <randy.dunlap@oracle.com>
Date : 2010-11-02 18:51 (17 days old)
Message-ID : <20101102115106.bac57d21.randy.dunlap@oracle.com>
References : http://marc.info/?l=linux-kernel&m=128872403920449&w=2
http://marc.info/?l=linux-acpi&m=128874714517914&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22562
Subject : Regression in 2.6.37-rc1 - logs spammed with "unable to enumerate USB port" - bisected to commit 3df7169e
Submitter : Larry Finger <Larry.Finger@lwfinger.net>
Date : 2010-11-02 22:32 (17 days old)
First-Bad-Commit: http://git.kernel.org/linus/3df7169e73fc1d71a39cffeacc969f6840cdf52b
Message-ID : <4CD09166.4060202@lwfinger.net>
References : http://marc.info/?l=linux-kernel&m=128873713207906&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22552
Subject : AMD boot freeze bisected to b126b4703afa4010b161784a43650337676dd03b
Submitter : Borislav Petkov <bp@amd64.org>
Date : 2010-11-02 17:03 (17 days old)
First-Bad-Commit: http://git.kernel.org/linus/b126b4703afa4010b161784a43650337676dd03b
Message-ID : <20101102170335.GC24927@aftab>
References : http://marc.info/?l=linux-kernel&m=128871752109913&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22542
Subject : [2.6.37-rc1] drm:i195 errors
Submitter : Paul Rolland <rol@witbe.net>
Date : 2010-11-02 14:58 (17 days old)
Message-ID : <20101102155813.09cb2c6e@tux.DEF.witbe.net>
References : http://marc.info/?l=linux-kernel&m=128870991628970&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22532
Subject : 2.6.37-rc1: BUG: scheduling while atomic (kvm_init)
Submitter : Thomas Meyer <thomas@m3y3r.de>
Date : 2010-11-02 19:06 (17 days old)
Message-ID : <50AA24C585B14210A44AB599605C7CBD@hugo>
References : http://marc.info/?l=linux-kernel&m=128872479921559&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22522
Subject : 2.6.37-rc1 boot Problem - BUG: unable to handle kernel null pointer - dmesg und config Datei
Submitter : werner <w.landgraf@ru.ru>
Date : 2010-11-02 2:09 (17 days old)
Message-ID : <web-395697375@zbackend1.aha.ru>
References : http://marc.info/?l=linux-kernel&m=128866380110940&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22472
Subject : vga_switcheroo fails to switch from intel to ati
Submitter : Radu Andries <admiral0@tuxfamily.org>
Date : 2010-11-08 16:46 (11 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22282
Subject : 2.6.37-rc1: WARNING..debugobjects: ODEBUG: free active (active state 0) object type: percpu_counter
Submitter : Randy Dunlap <randy.dunlap@oracle.com>
Date : 2010-11-01 21:58 (18 days old)
Message-ID : <4CCF37E8.1070208@oracle.com>
References : http://marc.info/?l=linux-kernel&m=128864879328429&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22102
Subject : [2.6.36-09452-g2d10d87] BUG: unable to handle kernel NULL pointer dereference at (null)
Submitter : Carlos R. Mafra <crmafra2@gmail.com>
Date : 2010-10-30 20:07 (20 days old)
Message-ID : <20101030200751.GA2866@Pilar.aei.mpg.de>
References : http://marc.info/?l=linux-kernel&m=128846935825136&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22082
Subject : 2.6.36-git11 -- kernel/pid.c:419 invoked rcu_dereference_check() without protection!
Submitter : Miles Lane <miles.lane@gmail.com>
Date : 2010-10-29 5:22 (21 days old)
Message-ID : <AANLkTimGgzOZb8EwUQO16cZcL+ycveKTYzg_AAX+D+Kw@mail.gmail.com>
References : http://marc.info/?l=linux-kernel&m=128832975924288&w=2
Regressions with patches
------------------------
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22962
Subject : building (e)glibc against 2.6.37-rc1 headers fails
Submitter : <stephan@openelec.tv>
Date : 2010-11-15 00:09 (4 days old)
Patch : https://bugzilla.kernel.org/show_bug.cgi?id=22962#c5
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22932
Subject : [REGRESSION] [2.6.37-rc1] Fan noise after suspend to ram/disk
Submitter : Maciej Rutecki <maciej.rutecki@gmail.com>
Date : 2010-11-04 16:06 (15 days old)
First-Bad-Commit: http://git.kernel.org/linus/3e384ee6c687cb397581ee8f9440fc8220cfac80
Message-ID : <201011041706.59046.maciej.rutecki@gmail.com>
References : http://marc.info/?l=linux-kernel&m=128888684308982&w=2
Handled-By : Rafael J. Wysocki <rjw@sisk.pl>
Patch : https://bugzilla.kernel.org/attachment.cgi?id=37372
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22722
Subject : regression since 2.6.36: backlight in sony-laptop not working
Submitter : Norbert Preining <preining@logic.at>
Date : 2010-11-04 14:29 (15 days old)
Message-ID : <20101104142915.GC7650@gamma.logic.tuwien.ac.at>
References : http://marc.info/?l=linux-kernel&m=128888097600601&w=2
Handled-By : Mattia Dongili <malattia@linux.it>
Patch : https://bugzilla.kernel.org/attachment.cgi?id=37442
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22662
Subject : divide error in select_task_rq_fair()
Submitter : Myron Stowe <myron.stowe@hp.com>
Date : 2010-11-10 23:58 (9 days old)
Patch : http://lkml.org/lkml/2010/11/13/176
For details, please visit the bug entries and follow the links given in
references.
As you can see, there is a Bugzilla entry for each of the listed regressions.
There also is a Bugzilla entry used for tracking the regressions from 2.6.36,
unresolved as well as resolved, at:
http://bugzilla.kernel.org/show_bug.cgi?id=21782
Please let the tracking team know if there are any Bugzilla entries that
should be added to the list in there.
Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* [PATCH 4/4] X25: remove bkl in routing ioctls
From: Andrew Hendry @ 2010-11-18 23:21 UTC (permalink / raw)
To: netdev
Routing doesn't use the socket data and is protected by x25_route_list_lock
Signed-off-by: Andrew Hendry <andrew.hendry@gmail.com>
---
net/x25/af_x25.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/net/x25/af_x25.c b/net/x25/af_x25.c
index 2f235a6..2351ace 100644
--- a/net/x25/af_x25.c
+++ b/net/x25/af_x25.c
@@ -1412,9 +1412,7 @@ static int x25_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
rc = -EPERM;
if (!capable(CAP_NET_ADMIN))
break;
- lock_kernel();
rc = x25_route_ioctl(cmd, argp);
- unlock_kernel();
break;
case SIOCX25GSUBSCRIP:
lock_kernel();
@@ -1710,9 +1708,7 @@ static int compat_x25_ioctl(struct socket *sock, unsigned int cmd,
rc = -EPERM;
if (!capable(CAP_NET_ADMIN))
break;
- lock_kernel();
rc = x25_route_ioctl(cmd, argp);
- unlock_kernel();
break;
case SIOCX25GSUBSCRIP:
lock_kernel();
--
1.7.1
^ permalink raw reply related
* [PATCH 3/4] X25: remove bkl in inq and outq ioctls
From: Andrew Hendry @ 2010-11-18 23:21 UTC (permalink / raw)
To: netdev
Signed-off-by: Andrew Hendry <andrew.hendry@gmail.com>
---
net/x25/af_x25.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/net/x25/af_x25.c b/net/x25/af_x25.c
index 2259783..2f235a6 100644
--- a/net/x25/af_x25.c
+++ b/net/x25/af_x25.c
@@ -1361,12 +1361,10 @@ static int x25_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
case TIOCOUTQ: {
int amount;
- lock_kernel();
amount = sk->sk_sndbuf - sk_wmem_alloc_get(sk);
if (amount < 0)
amount = 0;
rc = put_user(amount, (unsigned int __user *)argp);
- unlock_kernel();
break;
}
@@ -1377,11 +1375,11 @@ static int x25_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
* These two are safe on a single CPU system as
* only user tasks fiddle here
*/
- lock_kernel();
+ lock_sock(sk);
if ((skb = skb_peek(&sk->sk_receive_queue)) != NULL)
amount = skb->len;
+ release_sock(sk);
rc = put_user(amount, (unsigned int __user *)argp);
- unlock_kernel();
break;
}
--
1.7.1
^ permalink raw reply related
* [PATCH 2/4] X25: remove bkl in timestamp ioctls
From: Andrew Hendry @ 2010-11-18 23:21 UTC (permalink / raw)
To: netdev
Signed-off-by: Andrew Hendry <andrew.hendry@gmail.com>
---
net/x25/af_x25.c | 8 --------
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/net/x25/af_x25.c b/net/x25/af_x25.c
index c99029b..2259783 100644
--- a/net/x25/af_x25.c
+++ b/net/x25/af_x25.c
@@ -1387,19 +1387,15 @@ static int x25_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
case SIOCGSTAMP:
rc = -EINVAL;
- lock_kernel();
if (sk)
rc = sock_get_timestamp(sk,
(struct timeval __user *)argp);
- unlock_kernel();
break;
case SIOCGSTAMPNS:
rc = -EINVAL;
- lock_kernel();
if (sk)
rc = sock_get_timestampns(sk,
(struct timespec __user *)argp);
- unlock_kernel();
break;
case SIOCGIFADDR:
case SIOCSIFADDR:
@@ -1689,19 +1685,15 @@ static int compat_x25_ioctl(struct socket *sock, unsigned int cmd,
break;
case SIOCGSTAMP:
rc = -EINVAL;
- lock_kernel();
if (sk)
rc = compat_sock_get_timestamp(sk,
(struct timeval __user*)argp);
- unlock_kernel();
break;
case SIOCGSTAMPNS:
rc = -EINVAL;
- lock_kernel();
if (sk)
rc = compat_sock_get_timestampns(sk,
(struct timespec __user*)argp);
- unlock_kernel();
break;
case SIOCGIFADDR:
case SIOCSIFADDR:
--
1.7.1
^ permalink raw reply related
* [PATCH 1/4] X25: pushdown bkl in ioctls
From: Andrew Hendry @ 2010-11-18 23:20 UTC (permalink / raw)
To: netdev
Push down the bkl in the ioctls so they can be removed one at a time.
Signed-off-by: Andrew Hendry <andrew.hendry@gmail.com>
---
net/x25/af_x25.c | 41 ++++++++++++++++++++++++++++++++++++++---
1 files changed, 38 insertions(+), 3 deletions(-)
diff --git a/net/x25/af_x25.c b/net/x25/af_x25.c
index f7af98d..c99029b 100644
--- a/net/x25/af_x25.c
+++ b/net/x25/af_x25.c
@@ -1357,14 +1357,16 @@ static int x25_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
void __user *argp = (void __user *)arg;
int rc;
- lock_kernel();
switch (cmd) {
case TIOCOUTQ: {
- int amount = sk->sk_sndbuf - sk_wmem_alloc_get(sk);
+ int amount;
+ lock_kernel();
+ amount = sk->sk_sndbuf - sk_wmem_alloc_get(sk);
if (amount < 0)
amount = 0;
rc = put_user(amount, (unsigned int __user *)argp);
+ unlock_kernel();
break;
}
@@ -1375,23 +1377,29 @@ static int x25_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
* These two are safe on a single CPU system as
* only user tasks fiddle here
*/
+ lock_kernel();
if ((skb = skb_peek(&sk->sk_receive_queue)) != NULL)
amount = skb->len;
rc = put_user(amount, (unsigned int __user *)argp);
+ unlock_kernel();
break;
}
case SIOCGSTAMP:
rc = -EINVAL;
+ lock_kernel();
if (sk)
rc = sock_get_timestamp(sk,
(struct timeval __user *)argp);
+ unlock_kernel();
break;
case SIOCGSTAMPNS:
rc = -EINVAL;
+ lock_kernel();
if (sk)
rc = sock_get_timestampns(sk,
(struct timespec __user *)argp);
+ unlock_kernel();
break;
case SIOCGIFADDR:
case SIOCSIFADDR:
@@ -1410,27 +1418,36 @@ static int x25_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
rc = -EPERM;
if (!capable(CAP_NET_ADMIN))
break;
+ lock_kernel();
rc = x25_route_ioctl(cmd, argp);
+ unlock_kernel();
break;
case SIOCX25GSUBSCRIP:
+ lock_kernel();
rc = x25_subscr_ioctl(cmd, argp);
+ unlock_kernel();
break;
case SIOCX25SSUBSCRIP:
rc = -EPERM;
if (!capable(CAP_NET_ADMIN))
break;
+ lock_kernel();
rc = x25_subscr_ioctl(cmd, argp);
+ unlock_kernel();
break;
case SIOCX25GFACILITIES: {
struct x25_facilities fac = x25->facilities;
+ lock_kernel();
rc = copy_to_user(argp, &fac,
sizeof(fac)) ? -EFAULT : 0;
+ unlock_kernel();
break;
}
case SIOCX25SFACILITIES: {
struct x25_facilities facilities;
rc = -EFAULT;
+ lock_kernel();
if (copy_from_user(&facilities, argp,
sizeof(facilities)))
break;
@@ -1466,12 +1483,15 @@ static int x25_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
break;
x25->facilities = facilities;
rc = 0;
+ unlock_kernel();
break;
}
case SIOCX25GDTEFACILITIES: {
+ lock_kernel();
rc = copy_to_user(argp, &x25->dte_facilities,
sizeof(x25->dte_facilities));
+ unlock_kernel();
if (rc)
rc = -EFAULT;
break;
@@ -1480,6 +1500,7 @@ static int x25_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
case SIOCX25SDTEFACILITIES: {
struct x25_dte_facilities dtefacs;
rc = -EFAULT;
+ lock_kernel();
if (copy_from_user(&dtefacs, argp, sizeof(dtefacs)))
break;
rc = -EINVAL;
@@ -1496,13 +1517,16 @@ static int x25_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
break;
x25->dte_facilities = dtefacs;
rc = 0;
+ unlock_kernel();
break;
}
case SIOCX25GCALLUSERDATA: {
struct x25_calluserdata cud = x25->calluserdata;
+ lock_kernel();
rc = copy_to_user(argp, &cud,
sizeof(cud)) ? -EFAULT : 0;
+ unlock_kernel();
break;
}
@@ -1510,6 +1534,7 @@ static int x25_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
struct x25_calluserdata calluserdata;
rc = -EFAULT;
+ lock_kernel();
if (copy_from_user(&calluserdata, argp,
sizeof(calluserdata)))
break;
@@ -1517,24 +1542,29 @@ static int x25_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
if (calluserdata.cudlength > X25_MAX_CUD_LEN)
break;
x25->calluserdata = calluserdata;
+ unlock_kernel();
rc = 0;
break;
}
case SIOCX25GCAUSEDIAG: {
struct x25_causediag causediag;
+ lock_kernel();
causediag = x25->causediag;
rc = copy_to_user(argp, &causediag,
sizeof(causediag)) ? -EFAULT : 0;
+ unlock_kernel();
break;
}
case SIOCX25SCAUSEDIAG: {
struct x25_causediag causediag;
rc = -EFAULT;
+ lock_kernel();
if (copy_from_user(&causediag, argp, sizeof(causediag)))
break;
x25->causediag = causediag;
+ unlock_kernel();
rc = 0;
break;
@@ -1543,6 +1573,7 @@ static int x25_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
case SIOCX25SCUDMATCHLEN: {
struct x25_subaddr sub_addr;
rc = -EINVAL;
+ lock_kernel();
if(sk->sk_state != TCP_CLOSE)
break;
rc = -EFAULT;
@@ -1553,21 +1584,25 @@ static int x25_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
if(sub_addr.cudmatchlength > X25_MAX_CUD_LEN)
break;
x25->cudmatchlength = sub_addr.cudmatchlength;
+ unlock_kernel();
rc = 0;
break;
}
case SIOCX25CALLACCPTAPPRV: {
rc = -EINVAL;
+ lock_kernel();
if (sk->sk_state != TCP_CLOSE)
break;
clear_bit(X25_ACCPT_APPRV_FLAG, &x25->flags);
+ unlock_kernel();
rc = 0;
break;
}
case SIOCX25SENDCALLACCPT: {
rc = -EINVAL;
+ lock_kernel();
if (sk->sk_state != TCP_ESTABLISHED)
break;
/* must call accptapprv above */
@@ -1575,6 +1610,7 @@ static int x25_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
break;
x25_write_internal(sk, X25_CALL_ACCEPTED);
x25->state = X25_STATE_3;
+ unlock_kernel();
rc = 0;
break;
}
@@ -1583,7 +1619,6 @@ static int x25_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
rc = -ENOIOCTLCMD;
break;
}
- unlock_kernel();
return rc;
}
--
1.7.1
^ permalink raw reply related
* Re: [PATCH] qlge: Fix incorrect usage of module parameters and netdev msg level
From: Sonny Rao @ 2010-11-18 23:12 UTC (permalink / raw)
To: ron.mercer, netdev@vger.kernel.org, Milton Miller, Linux Driver,
"linux-kernel@vger.kernel.org" <lin
In-Reply-To: <20101118221713.GB14333@linux-ox1b.qlogic.org>
On Thu, Nov 18, 2010 at 02:17:14PM -0800, Ron Mercer wrote:
> On Thu, Nov 18, 2010 at 01:50:02PM -0800, Sonny Rao wrote:
> > Driver appears to be mistaking the permission field with default value
> > in the case of debug and qlge_irq_type.
> >
> > Driver is also passing debug as a bitmask into netif_msg_init()
> > which wants a number of bits. Ron Mercer suggests we should
> > change this to pass in -1 so the defaults get used instead,
> > which makes the default much less verbose.
> >
> > Signed-off-by: Milton Miller <miltonm@bga.com>
> > Signed-off-by: Sonny Rao <sonnyrao@linux.vnet.ibm.com>
>
> Milton/Sonny,
> Did you happen to test this to see if the log output was the same?
Well, I haven't tried the -1 but I suspect it is much more sane than
the 15 I had before because that was excessively verbose and I always
ended up turning it down. I'll try it out and see.
--
Sonny Rao, LTC OzLabs, BML team
^ permalink raw reply
* [PATCH] net: fix kernel-doc for sk_filter_rcu_release
From: Randy Dunlap @ 2010-11-18 23:02 UTC (permalink / raw)
To: netdev; +Cc: davem
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix kernel-doc warning for sk_filter_rcu_release():
Warning(net/core/filter.c:586): missing initial short description on line:
* sk_filter_rcu_release: Release a socket filter by rcu_head
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
---
net/core/filter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- lnx-2637-r2g4-kerndoc.orig/net/core/filter.c
+++ lnx-2637-r2g4-kerndoc/net/core/filter.c
@@ -589,7 +589,7 @@ int sk_chk_filter(struct sock_filter *fi
EXPORT_SYMBOL(sk_chk_filter);
/**
- * sk_filter_rcu_release: Release a socket filter by rcu_head
+ * sk_filter_rcu_release - Release a socket filter by rcu_head
* @rcu: rcu_head that contains the sk_filter to free
*/
static void sk_filter_rcu_release(struct rcu_head *rcu)
^ permalink raw reply
* Re: alchemy/gpr: au1000_eth regression with v2.6.37rc2
From: Florian Fainelli @ 2010-11-18 22:30 UTC (permalink / raw)
To: Wolfgang Grandegger; +Cc: Linux-MIPS, Netdev
In-Reply-To: <4CE58593.50509@grandegger.com>
Hello Wolfgang,
Le Thursday 18 November 2010 20:59:15, Wolfgang Grandegger a écrit :
> Hello,
>
> I just realized that the v2.6.37-rc2 kernel does not boot any more on
> the Alchemy GPR board. It works fine with v2.6.36. It hangs in the
> probe function of the au1000_eth driver when probing the second
> ethernet port (eth1):
>
> au1000_eth_mii: probed
> au1000-eth au1000-eth.0: (unregistered net_device): attached PHY driver
> [Generic PHY] (mii_bus:phy_addr=0:00, irq=-1) au1000-eth au1000-eth.0:
> eth0: Au1xx0 Ethernet found at 0x10500000, irq 35 au1000_eth: au1000_eth
> version 1.7 Pete Popov <ppopov@embeddedalley.com> ... hangs ...
>
> Similar messages should follow for eth1. I narrowed down (bisect'ed) the
> problem to commit:
>
> commit d0e7cb5d401695809ba8c980124ab1d8c66efc8b
> Author: Florian Fainelli <florian@openwrt.org>
> Date: Wed Sep 8 11:15:13 2010 +0000
>
> au1000-eth: remove volatiles, switch to I/O accessors
>
> Remove all the volatile keywords where they were used, switch to using
> the proper readl/writel accessors.
>
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> The kernel actually hangs when accessing "&aup->mac->mii_control" in
> au1000_mdio_read(), but only for eth1. Any idea what does go wrong?
I do not understand so far while it hangs only for eth1. My device only has
one ethernet MAC, so I could not notice the problem. Looking at this close,
there are a couple of u32 const* usages in au1000_mdio_{read,write} which are
looking wrong to me now. Can you try to remove these?
>
> In principle, I do not want to access the MII regs of the MAC because
> eth0 and eth1 are connected to switches. But that's not possible, even
> with "aup->phy_static_config=1" and "aup->phy_addr=0".
If you think this is another issue, I will fix it in another patch.
--
Florian
^ permalink raw reply
* Re: [PATCH] qlge: Fix incorrect usage of module parameters and netdev msg level
From: Ron Mercer @ 2010-11-18 22:17 UTC (permalink / raw)
To: Sonny Rao
Cc: netdev@vger.kernel.org, Milton Miller, Linux Driver,
linux-kernel@vger.kernel.org, sonnyrao@linux.vnet.ibm.com
In-Reply-To: <20101118215002.GS32203@us.ibm.com>
On Thu, Nov 18, 2010 at 01:50:02PM -0800, Sonny Rao wrote:
> Driver appears to be mistaking the permission field with default value
> in the case of debug and qlge_irq_type.
>
> Driver is also passing debug as a bitmask into netif_msg_init()
> which wants a number of bits. Ron Mercer suggests we should
> change this to pass in -1 so the defaults get used instead,
> which makes the default much less verbose.
>
> Signed-off-by: Milton Miller <miltonm@bga.com>
> Signed-off-by: Sonny Rao <sonnyrao@linux.vnet.ibm.com>
Milton/Sonny,
Did you happen to test this to see if the log output was the same?
^ permalink raw reply
* Re: Fwd: a Great Idea - include Kademlia networking protocol in kernel -- REVISITED
From: Marcos @ 2010-11-18 22:21 UTC (permalink / raw)
To: Honglei Cong, netdev
In-Reply-To: <AANLkTi=RQjvwpTwZtkjcyjgMVsZbYfi=34wSd-_JE3pP@mail.gmail.com>
>> Yes, of course, all that will have to be considered. But I'm
>> suggesting that such a move is an investment in the future, that the
>> the number of machines that will want or request peer-2-peer
>> connectivity will (or should) only increase. Done right, such a move
>> should *simplify* things. We're biased to think in centralized ways
>> because of the centuries-old history of *who* has the resources. But
>> as networking, computation, and storage become commodified further,
>> whole new topologies for the *right* architecture become available.
>> The idea of "the OS" itself morphs. And the *only* way maximize the
> Agree with u. But 'kernel' is not.
...Consider a unified model of two orthogonal resources: processor --
memory. In theory such a unified model should be realizable. For
example, if we fix the processor side (say the user's machine), then
you can move around the memory side, unify different memory stores:
cache, RAM, local HD, Networked file storage (naturally logarithmic
scaling). There's no more need to "install applications": it's all
installed out there somewhere (probably from the same place where it
was created), you just need to "page it in". Create an abstract,
user-controlled, peer grouping model that allows arbitrary "trust (or
privacy) groups" where "node discovery" (say new annoucements) and
"shared memory" is allowed and watch the Social Linux Network Brain
evolve. (I better not even mention an integrated voting model
yet....)
Too idealistic?
marcos
pangaia.sourceforge.net
^ permalink raw reply
* [PATCH] qlge: Fix incorrect usage of module parameters and netdev msg level
From: Sonny Rao @ 2010-11-18 21:50 UTC (permalink / raw)
To: netdev@vger.kernel.org
Cc: Milton Miller, Linux Driver, linux-kernel@vger.kernel.org,
Ron Mercer, sonnyrao
Driver appears to be mistaking the permission field with default value
in the case of debug and qlge_irq_type.
Driver is also passing debug as a bitmask into netif_msg_init()
which wants a number of bits. Ron Mercer suggests we should
change this to pass in -1 so the defaults get used instead,
which makes the default much less verbose.
Signed-off-by: Milton Miller <miltonm@bga.com>
Signed-off-by: Sonny Rao <sonnyrao@linux.vnet.ibm.com>
---
v2: Changed debug to be -1 and updated changelog
drivers/net/qlge/qlge_main.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/qlge/qlge_main.c b/drivers/net/qlge/qlge_main.c
index d9a7626..66878bb 100644
--- a/drivers/net/qlge/qlge_main.c
+++ b/drivers/net/qlge/qlge_main.c
@@ -62,15 +62,15 @@ static const u32 default_msg =
/* NETIF_MSG_PKTDATA | */
NETIF_MSG_HW | NETIF_MSG_WOL | 0;
-static int debug = 0x00007fff; /* defaults above */
-module_param(debug, int, 0);
+static int debug = -1; /* defaults above */
+module_param(debug, int, 0664);
MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)");
#define MSIX_IRQ 0
#define MSI_IRQ 1
#define LEG_IRQ 2
static int qlge_irq_type = MSIX_IRQ;
-module_param(qlge_irq_type, int, MSIX_IRQ);
+module_param(qlge_irq_type, int, 0664);
MODULE_PARM_DESC(qlge_irq_type, "0 = MSI-X, 1 = MSI, 2 = Legacy.");
static int qlge_mpi_coredump;
^ permalink raw reply related
* Re: error while building the kernel Mainline
From: Patrick McHardy @ 2010-11-18 21:48 UTC (permalink / raw)
To: David Miller
Cc: randy.dunlap, justinmattock, eric.dumazet, linux-net,
linux-kernel, netdev, horms, netfilter-devel
In-Reply-To: <20101118.131527.45904827.davem@davemloft.net>
Am 18.11.2010 22:15, schrieb David Miller:
> From: David Miller <davem@davemloft.net>
> Date: Thu, 18 Nov 2010 13:10:04 -0800 (PST)
>
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>> Date: Thu, 18 Nov 2010 13:03:18 -0800
>>
>>> On Thu, 18 Nov 2010 12:54:51 -0800 (PST) David Miller wrote:
>>>
>>>> From: Patrick McHardy <kaber@trash.net>
>>>> Date: Thu, 18 Nov 2010 21:32:11 +0100
>>>>
>>>>> Thanks for testing. Dave, please apply directly, thanks!
>>>
>>> Dave,
>>>
>>> This patch does not fix the config/build error that I posted for linux-next.
>>
>> And it has bugs, now when NF_CONNTRACT is set to "m" IPVS isn't offered
>> at all.
>>
>> So I'm reverting.
>
> Ignore this, I was looking for "*_IPVS" in the config instead of
> "*_IP_VS" for some stupid reason.
I always make the same mistake :)
> Patch is sane and I'll look into Randy's problem when I get a chance.
> :-)
I've already asked the tproxy guys to look into this, it's a
different problem that requires more tproxy knowledge than
have.
^ permalink raw reply
* Re: error while building the kernel Mainline
From: David Miller @ 2010-11-18 21:15 UTC (permalink / raw)
To: randy.dunlap
Cc: kaber, justinmattock, eric.dumazet, linux-net, linux-kernel,
netdev, horms, netfilter-devel
In-Reply-To: <20101118.131004.58430322.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Thu, 18 Nov 2010 13:10:04 -0800 (PST)
> From: Randy Dunlap <randy.dunlap@oracle.com>
> Date: Thu, 18 Nov 2010 13:03:18 -0800
>
>> On Thu, 18 Nov 2010 12:54:51 -0800 (PST) David Miller wrote:
>>
>>> From: Patrick McHardy <kaber@trash.net>
>>> Date: Thu, 18 Nov 2010 21:32:11 +0100
>>>
>>> > Thanks for testing. Dave, please apply directly, thanks!
>>
>> Dave,
>>
>> This patch does not fix the config/build error that I posted for linux-next.
>
> And it has bugs, now when NF_CONNTRACT is set to "m" IPVS isn't offered
> at all.
>
> So I'm reverting.
Ignore this, I was looking for "*_IPVS" in the config instead of
"*_IP_VS" for some stupid reason.
Patch is sane and I'll look into Randy's problem when I get a chance.
:-)
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox