* [PATCH net-next-2.6] xps: NUMA allocations for per cpu data
From: Eric Dumazet @ 2010-11-28 15:43 UTC (permalink / raw)
To: David Miller; +Cc: netdev, Tom Herbert
In-Reply-To: <1290791866.2855.263.camel@edumazet-laptop>
store_xps_map() allocates maps that are used by single cpu, it makes
sense to use NUMA allocations.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Tom Herbert <therbert@google.com>
---
net/core/net-sysfs.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
index 68dbbfd..35f28b1 100644
--- a/net/core/net-sysfs.c
+++ b/net/core/net-sysfs.c
@@ -950,8 +950,9 @@ static ssize_t store_xps_map(struct netdev_queue *queue,
if (map_len >= alloc_len) {
alloc_len = alloc_len ?
2 * alloc_len : XPS_MIN_MAP_ALLOC;
- new_map = kzalloc(XPS_MAP_SIZE(alloc_len),
- GFP_KERNEL);
+ new_map = kzalloc_node(XPS_MAP_SIZE(alloc_len),
+ GFP_KERNEL,
+ cpu_to_node(cpu));
if (!new_map)
goto error;
new_map->alloc_len = alloc_len;
^ permalink raw reply related
* Re: [PATCH] ks8842: Fix TX cache flush issue
From: David Miller @ 2010-11-28 18:38 UTC (permalink / raw)
To: richard.rojfors; +Cc: netdev, ferringb
In-Reply-To: <1290430257.13971.7.camel@debian>
From: Richard Röjfors <richard.rojfors@pelagicore.com>
Date: Mon, 22 Nov 2010 13:50:57 +0100
> This patch fixes a cache sync issue found in MeeGo 1.1.
>
> It was found that bytes after the first 64 of the TX buffer was not
> flushed from the cache correctly.
>
> The patch switches out kmalloc/dma_map_single/dma_sync_single_for_device
> to dma_alloc_coherent.
>
> Signed-off-by: Richard Röjfors <richard.rojfors@pelagicore.com>
Why is dma_sync_single_*() not working properly?
Maybe the length arguments are not correct? Maybe the cache flush
implementation accidently misses the last cache line when the buffer
length ends in the middle of a cache line.
Did you even check to see what the actual cause of the problem is?
I'm not applying this patch, not enough justification or explanation
in the commit message exists yet. For all we know there could be
a bug elsewhere, and that would effect other drivers too not just
ks8842.
^ permalink raw reply
* Re: [PATCH v2] tcp: restrict net.ipv4.tcp_adv_win_scale (#20312)
From: David Miller @ 2010-11-28 18:39 UTC (permalink / raw)
To: adobriyan; +Cc: eric.dumazet, shemminger, netdev, bhutchings
In-Reply-To: <20101122225421.GA7372@core2.telecom.by>
From: Alexey Dobriyan <adobriyan@gmail.com>
Date: Tue, 23 Nov 2010 00:54:21 +0200
> tcp_win_from_space() does the following:
>
> if (sysctl_tcp_adv_win_scale <= 0)
> return space >> (-sysctl_tcp_adv_win_scale);
> else
> return space - (space >> sysctl_tcp_adv_win_scale);
>
> "space" is int.
>
> As per C99 6.5.7 (3) shifting int for 32 or more bits is
> undefined behaviour.
>
> Indeed, if sysctl_tcp_adv_win_scale is exactly 32,
> space >> 32 equals space and function returns 0.
>
> Which means we busyloop in tcp_fixup_rcvbuf().
>
> Restrict net.ipv4.tcp_adv_win_scale to [-31, 31].
>
> Fix https://bugzilla.kernel.org/show_bug.cgi?id=20312
>
> Steps to reproduce:
>
> echo 32 >/proc/sys/net/ipv4/tcp_adv_win_scale
> wget www.kernel.org
> [softlockup]
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
I'll aply this, thanks Alexey.
^ permalink raw reply
* Re: [PATCH net-next] sctp: kill unused macro definition
From: David Miller @ 2010-11-28 18:47 UTC (permalink / raw)
To: shanwei; +Cc: vladislav.yasevich, linux-sctp, netdev
In-Reply-To: <4CEB82BA.6030406@cn.fujitsu.com>
From: Shan Wei <shanwei@cn.fujitsu.com>
Date: Tue, 23 Nov 2010 17:00:42 +0800
>
> These macros have been existed for several years since v2.6.12-rc2.
> But they never be used. So remove them now.
>
> Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
Applied.
^ permalink raw reply
* Re: [PATCH NEXT] qlcnic: avoid using reset_devices as it may become obsolete.
From: David Miller @ 2010-11-28 18:48 UTC (permalink / raw)
To: amit.salecha; +Cc: netdev, ameen.rahman, anirban.chakraborty, rajesh.borundia
In-Reply-To: <1290511521-5773-1-git-send-email-amit.salecha@qlogic.com>
From: Amit Kumar Salecha <amit.salecha@qlogic.com>
Date: Tue, 23 Nov 2010 03:25:21 -0800
> From: Rajesh Borundia <rajesh.borundia@qlogic.com>
>
> In kdump environment do not depend upon reset_devices parameter
> to reset the pci function as this parameter may become obsolete.
> Instead use an adapter specific mechanism to determine if the pci
> function needs to be reset.
>
> Per function refcount is maintained in driver, which is set in probe
> and reset in remove handler of adapter. If the probe detects the count
> as non zero then reset the function.
>
> Signed-off-by: Rajesh Borundia <rajesh.borundia@qlogic.com>
> Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com>
Applied.
^ permalink raw reply
* Re: [PATCH] netxen: avoid using reset_devices as it may become obsolete
From: David Miller @ 2010-11-28 18:48 UTC (permalink / raw)
To: amit.salecha; +Cc: netdev, ameen.rahman, anirban.chakraborty, rajesh.borundia
In-Reply-To: <1290517707-8554-1-git-send-email-amit.salecha@qlogic.com>
From: Amit Kumar Salecha <amit.salecha@qlogic.com>
Date: Tue, 23 Nov 2010 05:08:27 -0800
> From: Rajesh Borundia <rajesh.borundia@qlogic.com>
>
> In kdump environment do not depend on reset_devices
> parameter to reset the device as the parameter may become obsolete.
> Instead use an adapter specific mechanism to determine if the device
> needs a reset.
>
> Driver maintains a count of number of pci functions probed
> and decrements the count when remove handler of that pci function
> is called. If the first probe, probe of function 0,
> detects the count as non zero then reset the device.
>
> Signed-off-by: Rajesh Borundia <rajesh.borundia@qlogic.com>
> Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH] 8021q: vlan device is lockless do not transfer real_num_{tx|rx}_queues
From: David Miller @ 2010-11-28 18:48 UTC (permalink / raw)
To: john.r.fastabend; +Cc: netdev, eric.dumazet
In-Reply-To: <20101124231450.3158.67194.stgit@jf-dev1-dcblab>
From: John Fastabend <john.r.fastabend@intel.com>
Date: Wed, 24 Nov 2010 15:14:50 -0800
> Now that the vlan device is lockless and single queue do not
> transfer the real num queues. This is causing a BUG_ON to occur.
>
> kernel BUG at net/8021q/vlan.c:345!
> Call Trace:
> [<ffffffff813fd6e8>] ? fib_rules_event+0x28/0x1b0
> [<ffffffff814ad2b5>] notifier_call_chain+0x55/0x80
> [<ffffffff81089156>] raw_notifier_call_chain+0x16/0x20
> [<ffffffff813e5af7>] call_netdevice_notifiers+0x37/0x70
> [<ffffffff813e6756>] netdev_features_change+0x16/0x20
> [<ffffffffa02995be>] ixgbe_fcoe_enable+0xae/0x100 [ixgbe]
> [<ffffffffa01da06a>] vlan_dev_fcoe_enable+0x2a/0x30 [8021q]
> [<ffffffffa02d08c3>] fcoe_create+0x163/0x630 [fcoe]
> [<ffffffff811244d5>] ? mmap_region+0x255/0x5a0
> [<ffffffff81080ef0>] param_attr_store+0x50/0x80
> [<ffffffff810809b6>] module_attr_store+0x26/0x30
> [<ffffffff811b9db2>] sysfs_write_file+0xf2/0x180
> [<ffffffff8114fc88>] vfs_write+0xc8/0x190
> [<ffffffff81150621>] sys_write+0x51/0x90
> [<ffffffff8100c0b2>] system_call_fastpath+0x16/0x1b
>
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Applied.
^ permalink raw reply
* Re: [PATCH 3/6] net: add some KERN_CONT markers to continuation lines
From: David Miller @ 2010-11-28 18:48 UTC (permalink / raw)
To: u.kleine-koenig; +Cc: linux-kernel, linux, kernel, arjan, torvalds, netdev
In-Reply-To: <1290589070-854-3-git-send-email-u.kleine-koenig@pengutronix.de>
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Wed, 24 Nov 2010 09:57:47 +0100
> Cc: netdev@vger.kernel.org
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied.
^ permalink raw reply
* Re: [PATCH]ipv6: kill two unused macro definition
From: David Miller @ 2010-11-28 18:49 UTC (permalink / raw)
To: shanwei; +Cc: netdev, adobriyan
In-Reply-To: <4CEE14AC.7090008@cn.fujitsu.com>
From: Shan Wei <shanwei@cn.fujitsu.com>
Date: Thu, 25 Nov 2010 15:47:56 +0800
> 1. IPV6_TLV_TEL_DST_SIZE
> This has not been using for several years since created.
>
> 2. RT6_INFO_LEN
> commit 33120b30 kill all RT6_INFO_LEN's references, but only this definition remained.
>
> commit 33120b30cc3b8665204d4fcde7288638b0dd04d5
> Author: Alexey Dobriyan <adobriyan@sw.ru>
> Date: Tue Nov 6 05:27:11 2007 -0800
>
> [IPV6]: Convert /proc/net/ipv6_route to seq_file interface
>
>
> Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next-2.6] net: add netif_tx_queue_frozen_or_stopped
From: David Miller @ 2010-11-28 18:49 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
In-Reply-To: <1290544922.2866.11.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 23 Nov 2010 21:42:02 +0100
> When testing struct netdev_queue state against FROZEN bit, we also test
> XOFF bit. We can test both bits at once and save some cycles.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 1/2] bnx2: Fix reset bug on 5709
From: David Miller @ 2010-11-28 18:49 UTC (permalink / raw)
To: mchan; +Cc: netdev
In-Reply-To: <1290642535-20293-1-git-send-email-mchan@broadcom.com>
From: "Michael Chan" <mchan@broadcom.com>
Date: Wed, 24 Nov 2010 15:48:54 -0800
> From: Eddie Wai <waie@broadcom.com>
>
> The 5709 chip requires the BNX2_MISC_NEW_CORE_CTL_DMA_ENABLE bit to be
> cleared and polling for pending DMAs to complete before chip reset.
> Without this step, we've seen NMIs during repeated resets of the chip.
>
> Signed-off-by: Eddie Wai <waie@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 2/2] bnx2: Remove config access to non-standard registers
From: David Miller @ 2010-11-28 18:49 UTC (permalink / raw)
To: mchan; +Cc: netdev
In-Reply-To: <1290642535-20293-2-git-send-email-mchan@broadcom.com>
From: "Michael Chan" <mchan@broadcom.com>
Date: Wed, 24 Nov 2010 15:48:55 -0800
> In KVM passthrough mode, the driver may not have config access to
> non-standard registers. The BNX2_PCICFG_MISC_CONFIG config register
> access to setup mailbox swapping can be done using MMIO.
>
> Update version to 2.0.20.
>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] bnx2x: Use helpers instead of direct access to the shinfo(skb) fields
From: David Miller @ 2010-11-28 19:08 UTC (permalink / raw)
To: vladz; +Cc: eilong, netdev
In-Reply-To: <1290939815.21703.81.camel@lb-tlvb-vladz>
From: "Vladislav Zolotarov" <vladz@broadcom.com>
Date: Sun, 28 Nov 2010 12:23:35 +0200
> Signed-off-by: Vladislav Zolotarov <vladz@broadcom.com>
> Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Applied, thanks.
^ permalink raw reply
* Re: [Pv-drivers] [PATCH] vmxnet3: fix compilation when RSS is disabled
From: Bhavesh Davda @ 2010-11-28 19:09 UTC (permalink / raw)
To: Scott Goldman
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org, pv-drivers@vmware.com,
randy.dunlap@oracle.com
In-Reply-To: <1290890035-32285-2-git-send-email-scottjg@vmware.com>
Straightforward enough. Thanks for fixing this Scott!
On Nov 27, 2010, at 12:35 PM, "Scott J. Goldman" <scottjg@vmware.com> wrote:
> If RSS is disabled, we can ifdef out some RSS specific code. This fixes
> the compile error found by Randy Dunlap.
>
> Signed-off-by: Scott J. Goldman <scottjg@vmware.com>
Reviewed-by: Bhavesh Davda <bhavesh@vmware.com>
> ---
> drivers/net/vmxnet3/vmxnet3_ethtool.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/vmxnet3/vmxnet3_ethtool.c b/drivers/net/vmxnet3/vmxnet3_ethtool.c
> index 9ddaea6..8e17fc8 100644
> --- a/drivers/net/vmxnet3/vmxnet3_ethtool.c
> +++ b/drivers/net/vmxnet3/vmxnet3_ethtool.c
> @@ -553,7 +553,7 @@ vmxnet3_get_rxnfc(struct net_device *netdev, struct ethtool_rxnfc *info,
> return -EOPNOTSUPP;
> }
>
> -
> +#ifdef VMXNET3_RSS
> static int
> vmxnet3_get_rss_indir(struct net_device *netdev,
> struct ethtool_rxfh_indir *p)
> @@ -598,6 +598,7 @@ vmxnet3_set_rss_indir(struct net_device *netdev,
> return 0;
>
> }
> +#endif
>
> static struct ethtool_ops vmxnet3_ethtool_ops = {
> .get_settings = vmxnet3_get_settings,
> @@ -623,8 +624,10 @@ static struct ethtool_ops vmxnet3_ethtool_ops = {
> .get_ringparam = vmxnet3_get_ringparam,
> .set_ringparam = vmxnet3_set_ringparam,
> .get_rxnfc = vmxnet3_get_rxnfc,
> +#ifdef VMXNET3_RSS
> .get_rxfh_indir = vmxnet3_get_rss_indir,
> .set_rxfh_indir = vmxnet3_set_rss_indir,
> +#endif
> };
>
> void vmxnet3_set_ethtool_ops(struct net_device *netdev)
> --
> 1.7.0.4
>
> _______________________________________________
> Pv-drivers mailing list
> Pv-drivers@vmware.com
> http://mailman2.vmware.com/mailman/listinfo/pv-drivers
^ permalink raw reply
* Re: [PATCH net-next 1/5] X25 remove bkl in subscription ioctls
From: David Miller @ 2010-11-28 19:12 UTC (permalink / raw)
To: andrew.hendry; +Cc: netdev
In-Reply-To: <1290687495.5053.35.camel@jaunty>
From: Andrew Hendry <andrew.hendry@gmail.com>
Date: Thu, 25 Nov 2010 23:18:15 +1100
>
> Signed-off-by: Andrew Hendry <andrew.hendry@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 2/5] X25 remove bkl in facility ioctls
From: David Miller @ 2010-11-28 19:13 UTC (permalink / raw)
To: andrew.hendry; +Cc: netdev
In-Reply-To: <1290687515.5053.40.camel@jaunty>
From: Andrew Hendry <andrew.hendry@gmail.com>
Date: Thu, 25 Nov 2010 23:18:35 +1100
>
> Signed-off-by: Andrew Hendry <andrew.hendry@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 3/5] X25 remove bkl from calluserdata ioctls
From: David Miller @ 2010-11-28 19:13 UTC (permalink / raw)
To: andrew.hendry; +Cc: netdev
In-Reply-To: <1290687520.5053.41.camel@jaunty>
From: Andrew Hendry <andrew.hendry@gmail.com>
Date: Thu, 25 Nov 2010 23:18:40 +1100
>
> Signed-off-by: Andrew Hendry <andrew.hendry@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 4/5] X25 remove bkl from causediag ioctls
From: David Miller @ 2010-11-28 19:13 UTC (permalink / raw)
To: andrew.hendry; +Cc: netdev
In-Reply-To: <1290687523.5053.42.camel@jaunty>
From: Andrew Hendry <andrew.hendry@gmail.com>
Date: Thu, 25 Nov 2010 23:18:43 +1100
>
> Signed-off-by: Andrew Hendry <andrew.hendry@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 5/5] X25 remove bkl in call user data length ioctl
From: David Miller @ 2010-11-28 19:13 UTC (permalink / raw)
To: andrew.hendry; +Cc: netdev
In-Reply-To: <1290687525.5053.43.camel@jaunty>
From: Andrew Hendry <andrew.hendry@gmail.com>
Date: Thu, 25 Nov 2010 23:18:45 +1100
>
> Signed-off-by: Andrew Hendry <andrew.hendry@gmail.com>
Applied.
^ permalink raw reply
* Re: ethoc driver changes (version 2)
From: David Miller @ 2010-11-28 19:17 UTC (permalink / raw)
To: jonas; +Cc: netdev
In-Reply-To: <1290688232-25142-1-git-send-email-jonas@southpole.se>
From: Jonas Bonn <jonas@southpole.se>
Date: Thu, 25 Nov 2010 13:30:24 +0100
> This series incorporates the changes requested in the review of the original
> set. The patch to "prevent overflow of cur_rx" has been dropped
> completely and the comments concerning the usage of division in the
> calculation of the BD entry have been incorporated into a new patch,
> number 8 "remove division from loops"; this new patch should take care of
> the potential overflow issues that existed previously, too.
All applied, thank you Jonas.
^ permalink raw reply
* Re: [PATCH] xfrm: use gre key as flow upper protocol info
From: David Miller @ 2010-11-28 19:22 UTC (permalink / raw)
To: timo.teras; +Cc: netdev, herbert
In-Reply-To: <4CEBC9C1.8080101@iki.fi>
From: Timo Teräs <timo.teras@iki.fi>
Date: Tue, 23 Nov 2010 16:03:45 +0200
> So we probably would need to do:
>
> xfrm: fix gre key endianess
>
> fl->fl_gre_key is network byte order contrary to fl->fl_icmp_*.
> Make xfrm_flowi_{s|d}port return network byte order values for gre
> key too.
>
> Signed-off-by: Timo Teräs <timo.teras@iki.fi>
Ok, applied, thanks Timo.
^ permalink raw reply
* jhash ipv6 prepare patch
From: David Miller @ 2010-11-28 19:26 UTC (permalink / raw)
To: kadlec; +Cc: netdev
Just FYI, I've applied that patch to net-next-2.6
^ permalink raw reply
* Re: [GIT PULL net-2.6] vhost-net: rcu fixup
From: David Miller @ 2010-11-28 19:27 UTC (permalink / raw)
To: mst; +Cc: kvm, virtualization, netdev, linux-kernel
In-Reply-To: <20101125122301.GA15990@redhat.com>
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Thu, 25 Nov 2010 14:23:01 +0200
> Please merge the following fix for 2.6.36.
> Thanks!
>
> The following changes since commit a27e13d370415add3487949c60810e36069a23a6:
>
> econet: fix CVE-2010-3848 (2010-11-24 11:51:47 -0800)
>
> are available in the git repository at:
> git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost-net
>
> Michael S. Tsirkin (1):
> vhost/net: fix rcu check usage
>
Pulled, thanks Michael.
^ permalink raw reply
* Re: net-2.6 [Patch 1/1][BUG-FIX] dccp: advancing the Ack window
From: David Miller @ 2010-11-28 19:29 UTC (permalink / raw)
To: gerrit; +Cc: dccp, netdev
In-Reply-To: <20101123123656.GB3915@gerrit.erg.abdn.ac.uk>
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Date: Tue, 23 Nov 2010 13:36:56 +0100
> dccp: fix error in updating the GAR
>
> This fixes a bug in updating the Greatest Acknowledgment number Received (GAR):
> the current implementation does not track the greatest received value -
> lower values in the range AWL..AWH (RFC 4340, 7.5.1) erase higher ones.
>
> Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH] au1000_eth: fix invalid address accessing the MAC enable register
From: David Miller @ 2010-11-28 19:31 UTC (permalink / raw)
To: wg; +Cc: Netdev, linux-mips, florian
In-Reply-To: <4CEBEE79.8040507@grandegger.com>
From: Wolfgang Grandegger <wg@grandegger.com>
Date: Tue, 23 Nov 2010 17:40:25 +0100
> "aup->enable" holds already the address pointing to the MAC enable
> register. The bug was introduced by commit d0e7cb:
>
> "au1000-eth: remove volatiles, switch to I/O accessors".
>
> CC: Florian Fainelli <florian@openwrt.org>
> Signed-off-by: Wolfgang Grandegger <wg@denx.de>
> Acked-by: Florian Fainelli <florian@openwrt.org>
Applied, thanks.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox