* Re: [PATCH net-next 2/6] tg3: Move EEE definitions into mdio.h
From: Ben Hutchings @ 2010-12-06 19:30 UTC (permalink / raw)
To: Matt Carlson; +Cc: davem, netdev, andy
In-Reply-To: <1291660134-3801-3-git-send-email-mcarlson@broadcom.com>
On Mon, 2010-12-06 at 10:28 -0800, Matt Carlson wrote:
> In commit 52b02d04c801fff51ca49ad033210846d1713253 entitled "tg3: Add
> EEE support", Ben Hutchings had commented that the EEE advertisement
> register will be in a standard location. This patch moves that
> definition into mdio.h and changes the code to use it.
>
> Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
> Reviewed-by: Benjamin Li <benli@broadcom.com>
[...]
Thanks, Matt.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply
* Re: [PATCH 2.6.36] vlan: Avoid hwaccel vlan packets when vid not used
From: Michael Leun @ 2010-12-06 19:34 UTC (permalink / raw)
To: Jesse Gross; +Cc: Eric Dumazet, David Miller, Ben Greear, linux-kernel, netdev
In-Reply-To: <AANLkTikrDTCDxsyOG4m0XcrOY=3pTRwWqnPGsio9cBFj@mail.gmail.com>
On Mon, 6 Dec 2010 10:14:55 -0800
Jesse Gross <jesse@nicira.com> wrote:
> On Sun, Dec 5, 2010 at 2:44 AM, Michael Leun
> <lkml20101129@newton.leun.net> wrote:
> > Hi Jesse,
> >
> > On Sun, 5 Dec 2010 10:55:28 +0100
> > Michael Leun <lkml20101129@newton.leun.net> wrote:
> >
> >> On Sun, 05 Dec 2010 09:03:53 +0100
> >> Eric Dumazet <eric.dumazet@gmail.com> wrote:
> >>
> >> > > But on
> >> > >
> >> > > hpdl320g5:/home/ml # lspci | grep Eth
> >> > > 03:04.0 Ethernet controller: Broadcom Corporation NetXtreme
> >> > > BCM5714 Gigabit Ethernet (rev a3) 03:04.1 Ethernet controller:
> >> > > Broadcom Corporation NetXtreme BCM5714 Gigabit Ethernet (rev
> >> > > a3)
> >> > >
> >> > > the good message is that it also does not crash, but with
> >> > > tcpdump I see vlan tags when no vlan devices configured on the
> >> > > respective eth, if so I do not see tags anymore vlan tags on
> >> > > the trunk interface.
> >> > >
> >> >
> >> > For all these very specific needs, you'll have to try 2.6.37 I am
> >> > afraid. Jesse did huge changes to exactly make this working, we
> >> > wont backport this to 2.6.36, but only avoid crashes.
> >>
> >> OK, I'm perfectly fine with that, of course, actually nice to hear
> >> that the issue already is addressed.
> >>
> >> Likely I'll give some rc an shot on this machine (maybe over
> >> christmas), but it is an production machine (acutally testing other
> >> devices is the "product" produced on this machine), so
> >> unfortunately I'm not that free in when and what I can do (but the
> >> possibility to, for example, bridge the trunk interface would make
> >> testing easier, that justifies something...).
> >>
> >> Thank you all very much for your work.
> >
> > Are these changes already in 2.6.37-rc4? Or, if not are they
> > somewhere publically available already?
> >
> > I looked into various changelogs but have some difficulties to
> > identify them...
> >
> > Maybe I have some time next days to give them an try...
>
> Yes, all of the existing vlan changes are in 2.6.37-rc4. There were a
> number of patches but the main one was
> 3701e51382a026cba10c60b03efabe534fba4ca4
Then, I'm afraid, this (seeing vlan tags even if vlan interfaces are
configured) does not work on HP DL320G5 (for exact description and
examples please see my mail a few days ago).
--
MfG,
Michael Leun
^ permalink raw reply
* Re: [PATCH 2.6.36] vlan: Avoid hwaccel vlan packets when vid not used
From: Jesse Gross @ 2010-12-06 20:04 UTC (permalink / raw)
To: Michael Leun; +Cc: Eric Dumazet, David Miller, Ben Greear, linux-kernel, netdev
In-Reply-To: <20101206203437.54b550e0@xenia.leun.net>
On Mon, Dec 6, 2010 at 11:34 AM, Michael Leun
<lkml20101129@newton.leun.net> wrote:
> On Mon, 6 Dec 2010 10:14:55 -0800
> Jesse Gross <jesse@nicira.com> wrote:
>
>> On Sun, Dec 5, 2010 at 2:44 AM, Michael Leun
>> <lkml20101129@newton.leun.net> wrote:
>> > Hi Jesse,
>> >
>> > On Sun, 5 Dec 2010 10:55:28 +0100
>> > Michael Leun <lkml20101129@newton.leun.net> wrote:
>> >
>> >> On Sun, 05 Dec 2010 09:03:53 +0100
>> >> Eric Dumazet <eric.dumazet@gmail.com> wrote:
>> >>
>> >> > > But on
>> >> > >
>> >> > > hpdl320g5:/home/ml # lspci | grep Eth
>> >> > > 03:04.0 Ethernet controller: Broadcom Corporation NetXtreme
>> >> > > BCM5714 Gigabit Ethernet (rev a3) 03:04.1 Ethernet controller:
>> >> > > Broadcom Corporation NetXtreme BCM5714 Gigabit Ethernet (rev
>> >> > > a3)
>> >> > >
>> >> > > the good message is that it also does not crash, but with
>> >> > > tcpdump I see vlan tags when no vlan devices configured on the
>> >> > > respective eth, if so I do not see tags anymore vlan tags on
>> >> > > the trunk interface.
>> >> > >
>> >> >
>> >> > For all these very specific needs, you'll have to try 2.6.37 I am
>> >> > afraid. Jesse did huge changes to exactly make this working, we
>> >> > wont backport this to 2.6.36, but only avoid crashes.
>> >>
>> >> OK, I'm perfectly fine with that, of course, actually nice to hear
>> >> that the issue already is addressed.
>> >>
>> >> Likely I'll give some rc an shot on this machine (maybe over
>> >> christmas), but it is an production machine (acutally testing other
>> >> devices is the "product" produced on this machine), so
>> >> unfortunately I'm not that free in when and what I can do (but the
>> >> possibility to, for example, bridge the trunk interface would make
>> >> testing easier, that justifies something...).
>> >>
>> >> Thank you all very much for your work.
>> >
>> > Are these changes already in 2.6.37-rc4? Or, if not are they
>> > somewhere publically available already?
>> >
>> > I looked into various changelogs but have some difficulties to
>> > identify them...
>> >
>> > Maybe I have some time next days to give them an try...
>>
>> Yes, all of the existing vlan changes are in 2.6.37-rc4. There were a
>> number of patches but the main one was
>> 3701e51382a026cba10c60b03efabe534fba4ca4
>
> Then, I'm afraid, this (seeing vlan tags even if vlan interfaces are
> configured) does not work on HP DL320G5 (for exact description and
> examples please see my mail a few days ago).
What driver are you using? Is it tg3?
The vlan changes that I made unfortunately require updating drivers to
get the full benefit. I've been busy lately so tg3 hasn't yet been
updated.
I know that tg3 does some things differently depending on whether a
vlan group is configured, so that would likely be the cause of what
you are seeing. I'd have to look at it in more detail to be sure
though.
You said that everything works on the other Broadcom NIC that you
tested? Maybe it uses bnx2 instead?
^ permalink raw reply
* Re: [PATCH 2/2] bluetooth: Use printf extension %pMbt
From: Gustavo F. Padovan @ 2010-12-06 20:07 UTC (permalink / raw)
To: Joe Perches
Cc: Michał Mirosław, Marcel Holtmann, netdev,
David S. Miller, linux-bluetooth, linux-kernel
In-Reply-To: <1291661413.17494.219.camel@Joe-Laptop>
Hi Joe,
* Joe Perches <joe@perches.com> [2010-12-06 10:50:13 -0800]:
> On Mon, 2010-12-06 at 16:15 -0200, Gustavo F. Padovan wrote:
> > This patch doesn't apply to the bluetooth-next-2.6 tree.
> > Can you please rebase it against the bluetooth-next-2.6 tree?
>
> No worries, it was done against next-20101202.
>
> Do you care about using %pMR vs %pMbt as Michał suggested in
> https://lkml.org/lkml/2010/12/4/21 ?
I'm fine either way. It depends more if another subsystem will want to use
%pMR or not as you said.
--
Gustavo F. Padovan
http://profusion.mobi
^ permalink raw reply
* Misuse of LRO, how widespread
From: Stephen Hemminger @ 2010-12-06 20:18 UTC (permalink / raw)
To: David Miller, Olof Johansson, Ben Hutchings, Divy Le Ray; +Cc: netdev
I inspected all drivers in net-next to see which drivers are using
LRO and which ones are broken. Most concerning is that Chelsio
and Solarflare drivers ignore ETH_FLAG_LRO.
The ones that are using LRO but allow disabling it:
qlcnic, netxen, mv643, s2io, myi10ge, bnx2x, ixgbe, vmxnet3
One driver seems confused about LRO vs GRO:
mlx4 - comments about LRO and depends on LRO but driver is using GRO
Drivers with not using ethtool interface to disable LRO:
pasemi_mac, sfc, ehea, cxgb3, cxgb4
^ permalink raw reply
* Re: Misuse of LRO, how widespread
From: Ben Hutchings @ 2010-12-06 20:30 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: David Miller, Olof Johansson, Divy Le Ray, netdev
In-Reply-To: <20101206121829.5b8c852e@nehalam>
On Mon, 2010-12-06 at 12:18 -0800, Stephen Hemminger wrote:
> I inspected all drivers in net-next to see which drivers are using
> LRO and which ones are broken. Most concerning is that Chelsio
> and Solarflare drivers ignore ETH_FLAG_LRO.
>
> The ones that are using LRO but allow disabling it:
> qlcnic, netxen, mv643, s2io, myi10ge, bnx2x, ixgbe, vmxnet3
>
> One driver seems confused about LRO vs GRO:
> mlx4 - comments about LRO and depends on LRO but driver is using GRO
sfc is also in this category. (And it's not confused, it was using
inet_lro before being converted to GRO.)
> Drivers with not using ethtool interface to disable LRO:
> pasemi_mac, sfc, ehea, cxgb3, cxgb4
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply
* Re: [PATCH net-next-2.6] net: dummy: add auto_up module parameter
From: David Miller @ 2010-12-06 20:36 UTC (permalink / raw)
To: opurdila; +Cc: netdev, ddvlad, lucian.grijincu
In-Reply-To: <1291132647-15018-1-git-send-email-opurdila@ixiacom.com>
From: Octavian Purdila <opurdila@ixiacom.com>
Date: Tue, 30 Nov 2010 17:57:27 +0200
> Add auto_up module parameter to automatically bring up the created
> devices. This is useful when using the dummy driver for testing net
> device register / unregister performance.
>
> Signed-off-by: Octavian Purdila <opurdila@ixiacom.com>
Registering a new netdevice with IFF_UP set is an error. You can't
set IFF_UP without also doing all of the other work, callbacks, and
state changes which are made by dev_open()'s code paths.
If, as you say, your interests are in testing register/unregister
performance, you can do that by making the appropriate calls in a loop
from userspace.
I honestly don't see what you hope to gain with this change, and
anyways since the registration state is basically illegal you'll need
to find another way to do this.
^ permalink raw reply
* Re: [PATCHv3 1/2] usbnet: changes for upcoming cdc_ncm driver
From: David Miller @ 2010-12-06 20:59 UTC (permalink / raw)
To: alexey.orishko
Cc: gregkh, linux-usb, netdev, oliver, yauheni.kaliuta, balbi,
sjur.brandeland, alexey.orishko
In-Reply-To: <1291109008-3613-1-git-send-email-alexey.orishko@stericsson.com>
From: Alexey Orishko <alexey.orishko@gmail.com>
Date: Tue, 30 Nov 2010 12:23:27 +0300
> Changes:
> include/linux/usb/usbnet.h:
> - a new flag to indicate driver's capability to accumulate IP packets in Tx
> direction and extract several packets from single skb in Rx direction.
> drivers/net/usb/usbnet.c:
> - the procedure of counting packets in usbnet was updated due to the
> accumulating of IP packets in the driver
> - no short packets are sent if indicated by the flag in driver_info
> structure
>
> Signed-off-by: Alexey Orishko <alexey.orishko@stericsson.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next-2.6 1/3] be2net: Fix be_dev_family_check() return value check
From: David Miller @ 2010-12-06 20:59 UTC (permalink / raw)
To: sathya.perla; +Cc: netdev
In-Reply-To: <20101201110228.GA1560@emulex.com>
From: Sathya Perla <sathya.perla@emulex.com>
Date: Wed, 1 Dec 2010 16:32:28 +0530
> Signed-off-by: Sathya Perla <sathya.perla@emulex.com>
Applied.
^ permalink raw reply
* Re: [PATCHv3 2/2] USB CDC NCM host driver
From: David Miller @ 2010-12-06 20:59 UTC (permalink / raw)
To: alexey.orishko-Re5JQEeQqe8AvxtiuMwx3w
Cc: gregkh-l3A5Bk7waGM, linux-usb-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA, oliver-GvhC2dPhHPQdnm+yROfE0A,
yauheni.kaliuta-xNZwKgViW5gAvxtiuMwx3w, balbi-l0cyMroinI0,
sjur.brandeland-0IS4wlFg1OjSUeElwK9/Pw,
alexey.orishko-0IS4wlFg1OjSUeElwK9/Pw
In-Reply-To: <1291109008-3613-2-git-send-email-alexey.orishko-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
From: Alexey Orishko <alexey.orishko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date: Tue, 30 Nov 2010 12:23:28 +0300
> The patch provides USB CDC NCM host driver support in the Linux Kernel.
>
> Changes:
> drivers/net/usb/cdc_ncm.c:
> - initial submission of the CDC NCM host driver;
> - verified on Intel 32/64 bit, Intel Atom, ST-Ericsson U8500 (ARM)
> - throughput measured over 100 Mbits duplex;
> - driver supports 16-bit NTB format only, but it is more than enough for
> transfers up to 64K;
> - driver can handle up to 32 datagrams in received NTB;
> - timer is used to collect several packets in Tx direction
>
> drivers/net/usb/Kconfig:
> - a new entry to compile CDC NCM host driver
> drivers/net/usb/Makefile:
> - a new entry to compile CDC NCM host driver
>
> Signed-off-by: Alexey Orishko <alexey.orishko-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH net-next-2.6 2/3] be2net: FW init cmd fix for lancer
From: David Miller @ 2010-12-06 20:59 UTC (permalink / raw)
To: sathya.perla; +Cc: netdev
In-Reply-To: <20101201110336.GA1623@emulex.com>
From: Sathya Perla <sathya.perla@emulex.com>
Date: Wed, 1 Dec 2010 16:33:36 +0530
> Lancer can use the same pattern as BE to indicate a driver load
> to the FW.
>
> Signed-off-by: Padmanabh Ratnakar <padmanabh.ratnakar@emulex.com>
> Signed-off-by: Sathya Perla <sathya.perla@emulex.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next-2.6 3/3] be2net: Handle out of buffer completions for lancer
From: David Miller @ 2010-12-06 21:00 UTC (permalink / raw)
To: sathya.perla; +Cc: netdev
In-Reply-To: <20101201110417.GA1653@emulex.com>
From: Sathya Perla <sathya.perla@emulex.com>
Date: Wed, 1 Dec 2010 16:34:17 +0530
> If Lancer chip does not have posted RX buffers, it posts an RX completion entry
> with the same frag_index as the last valid completion. The Error bit is also
> set. In BE, a flush completion is indicated with a zero value for num_rcvd in
> the completion.
> Such completions don't carry any data and are not processed.
> This patch refactors code to handle both cases with the same code.
>
> Signed-off-by: Padmanabh Ratnakar <padmanabh.ratnakar@emulex.com>
> Signed-off-by: Sathya Perla <sathya.perla@emulex.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next-2.6] : __in_dev_get_rtnl() can use rtnl_dereference()
From: David Miller @ 2010-12-06 21:00 UTC (permalink / raw)
To: eric.dumazet
Cc: amwang, linux-kernel, kuznet, pekkas, jmorris, yoshfuji, kaber,
netdev
In-Reply-To: <1291203462.2856.607.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 01 Dec 2010 12:37:42 +0100
> Le mercredi 01 décembre 2010 à 12:21 +0100, Eric Dumazet a écrit :
>
>> Same here. RTNL is held. Please use __in_dev_get_rtnl()
>
> By the way we can use rtnl_dereference() in __in_dev_get_rtnl()
>
> [PATCH net-next-2.6] : __in_dev_get_rtnl() can use rtnl_dereference()
>
> If caller holds RTNL, we dont need a memory barrier
> (smp_read_barrier_depends) included in rcu_dereference().
>
> Just use rtnl_dereference() to properly document the assertions.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH v2 1/2] af_packet: use vmalloc_to_page() instead for the addresss returned by vmalloc()
From: David Miller @ 2010-12-06 21:01 UTC (permalink / raw)
To: xiaosuo; +Cc: eric.dumazet, jpirko, nhorman, netdev
In-Reply-To: <1291207940-17140-1-git-send-email-xiaosuo@gmail.com>
From: Changli Gao <xiaosuo@gmail.com>
Date: Wed, 1 Dec 2010 20:52:20 +0800
> The following commit causes the pgv->buffer may point to the memory
> returned by vmalloc(). And we can't use virt_to_page() for the vmalloc
> address.
>
> This patch introduces a new inline function pgv_to_page(), which calls
> vmalloc_to_page() for the vmalloc address, and virt_to_page() for the
> __get_free_pages address.
>
> We used to increase page pointer to get the next page at the next page
> address, after Neil's patch, it is wrong, as the physical address may
> be not continuous. This patch also fixes this issue.
>
> commit 0e3125c755445664f00ad036e4fc2cd32fd52877
> Author: Neil Horman <nhorman@tuxdriver.com>
> Date: Tue Nov 16 10:26:47 2010 -0800
>
> packet: Enhance AF_PACKET implementation to not require high order contiguous memory allocation (v4)
>
> Signed-off-by: Changli Gao <xiaosuo@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH v2 2/2] af_packet: remove pgv.flags
From: David Miller @ 2010-12-06 21:01 UTC (permalink / raw)
To: xiaosuo; +Cc: eric.dumazet, jpirko, nhorman, netdev
In-Reply-To: <1291207977-17176-1-git-send-email-xiaosuo@gmail.com>
From: Changli Gao <xiaosuo@gmail.com>
Date: Wed, 1 Dec 2010 20:52:57 +0800
> As we can check if an address is vmalloc address with is_vmalloc_addr(),
> we remove pgv.flags. Then we may get more pg_vecs.
>
> Signed-off-by: Changli Gao <xiaosuo@gmail.com>
Applied.
^ permalink raw reply
* Re: [Patch] net: kill an RCU warning in inet_fill_link_af()
From: David Miller @ 2010-12-06 21:01 UTC (permalink / raw)
To: eric.dumazet
Cc: amwang, linux-kernel, kuznet, pekkas, jmorris, yoshfuji, kaber,
netdev, tgraf
In-Reply-To: <1291219386.2856.924.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 01 Dec 2010 17:03:06 +0100
> Le mercredi 01 décembre 2010 à 19:14 +0800, Amerigo Wang a écrit :
>> From: WANG Cong <amwang@redhat.com>
>>
>> The latest net-next-2.6 triggers an RCU warning during boot,
>> lockdep complains that in inet_fill_link_af() we call rcu_dereference_check()
>> without rcu_read_lock() protection.
>>
>> This patch fixes it by replacing __in_dev_get_rcu() with in_dev_get().
>
> Here is a better version, thanks a lot for your report and initial
> patch.
>
>
> [PATCH net-next-2.6] net: kill an RCU warning in inet_fill_link_af()
>
> commits 9f0f7272 (ipv4: AF_INET link address family) and cf7afbfeb8c
> (rtnl: make link af-specific updates atomic) used incorrect
> __in_dev_get_rcu() in RTNL protected contexts, triggering PROVE_RCU
> warnings.
>
> Switch to __in_dev_get_rtnl(), wich is more appropriate, since we hold
> RTNL.
>
> Based on a report and initial patch from Amerigo Wang.
>
> Reported-by: Amerigo Wang <amwang@redhat.com>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> Cc: Thomas Graf <tgraf@infradead.org>
Applied.
^ permalink raw reply
* Re: [PATCH v2] net: Fix too optimistic NETIF_F_HW_CSUM features
From: David Miller @ 2010-12-06 21:01 UTC (permalink / raw)
To: mirq-linux
Cc: netdev, bhutchings, jesse, jon.mason, Ramkrishna.Vepa,
Sivakumar.Subramani, Sreenivasa.Honnur
In-Reply-To: <20101130163057.29978.92721.stgit@rechot.qmqm.pl>
From: MichałMirosław <mirq-linux@rere.qmqm.pl>
Date: Tue, 30 Nov 2010 17:38:00 +0100 (CET)
> NETIF_F_HW_CSUM is a superset of NETIF_F_IP_CSUM+NETIF_F_IPV6_CSUM, but
> some drivers miss the difference. Fix this and also fix UFO dependency
> on checksumming offload as it makes the same mistake in assumptions.
>
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Applied.
^ permalink raw reply
* Re: [net-next PATCH V2] ehea: Use the standard logging functions
From: David Miller @ 2010-12-06 21:02 UTC (permalink / raw)
To: leitao; +Cc: joe, netdev
In-Reply-To: <4CF7EB82.5020609@linux.vnet.ibm.com>
From: Breno Leitao <leitao@linux.vnet.ibm.com>
Date: Thu, 02 Dec 2010 16:54:58 -0200
> On 11/30/2010 04:18 PM, Joe Perches wrote:
>> Remove ehea_error, ehea_info and ehea_debug macros.
>> Use pr_fmt, pr_<level>, netdev_<level> and netif_<level> as
>> appropriate.
>> Fix messages to use trailing "\n", some messages had an extra one
>> as the old ehea_<level> macros added a trailing "\n".
>> Coalesced long format strings.
>>
>> Uncompiled/untested.
>>
>> Signed-off-by: Joe Perches<joe@perches.com>
> Signed-off-by: Breno Leitao<leitao@linux.vnet.ibm.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next-2.6] filter: add SKF_AD_RXHASH and SKF_AD_CPU
From: David Miller @ 2010-12-06 21:02 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev, wirelesser
In-Reply-To: <1291189556.2856.476.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 01 Dec 2010 08:45:56 +0100
> Add SKF_AD_RXHASH and SKF_AD_CPU to filter ancillary mechanism,
> to be able to build advanced filters.
>
> This can help spreading packets on several sockets with a fast
> selection, after RPS dispatch to N cpus for example, or to catch a
> percentage of flows in one queue.
>
> tcpdump -s 500 "cpu = 1" :
>
> [0] ld CPU
> [1] jeq #1 jt 2 jf 3
> [2] ret #500
> [3] ret #0
>
> # take 12.5 % of flows (average)
> tcpdump -s 1000 "rxhash & 7 = 2" :
>
> [0] ld RXHASH
> [1] and #7
> [2] jeq #2 jt 3 jf 4
> [3] ret #1000
> [4] ret #0
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH] net: arp: use assignment
From: David Miller @ 2010-12-06 21:07 UTC (permalink / raw)
To: xiaosuo; +Cc: netdev
In-Reply-To: <1291270051-27109-1-git-send-email-xiaosuo@gmail.com>
From: Changli Gao <xiaosuo@gmail.com>
Date: Thu, 2 Dec 2010 14:07:31 +0800
> Only when dont_send is 0, arp_filter() is consulted, so we can simply
> assign the return value of arp_filter() to dont_send instead.
>
> Signed-off-by: Changli Gao <xiaosuo@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next-2.6] filter: add a security check at install time
From: David Miller @ 2010-12-06 21:07 UTC (permalink / raw)
To: eric.dumazet; +Cc: xiaosuo, hagen, wirelesser, netdev, drosenberg
In-Reply-To: <1291272384.2856.1074.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 02 Dec 2010 07:46:24 +0100
> [PATCH v2 net-next-2.6] filter: add a security check at install time
Applied.
^ permalink raw reply
* Re: [PATCH net-next-2.6] [Resend] Fix a typo in datagram.c and sctp/socket.c.
From: David Miller @ 2010-12-06 21:10 UTC (permalink / raw)
To: dshwatrz; +Cc: netdev
In-Reply-To: <AANLkTim+igD_3ob7d+_-yjTov_SDMf9GuPV8gzODCyk_@mail.gmail.com>
From: David Shwatrz <dshwatrz@gmail.com>
Date: Thu, 2 Dec 2010 21:01:55 +0200
> This patch fixes a typo in net/core/datagram.c and in net/sctp/socket.c
Applied, thanks.
^ permalink raw reply
* Re: Misuse of LRO, how widespread
From: Dimitris Michailidis @ 2010-12-06 21:15 UTC (permalink / raw)
To: Stephen Hemminger
Cc: David Miller, Olof Johansson, Ben Hutchings, Divy Le Ray, netdev
In-Reply-To: <20101206121829.5b8c852e@nehalam>
Stephen Hemminger wrote:
> I inspected all drivers in net-next to see which drivers are using
> LRO and which ones are broken. Most concerning is that Chelsio
> and Solarflare drivers ignore ETH_FLAG_LRO.
>
> The ones that are using LRO but allow disabling it:
> qlcnic, netxen, mv643, s2io, myi10ge, bnx2x, ixgbe, vmxnet3
>
> One driver seems confused about LRO vs GRO:
> mlx4 - comments about LRO and depends on LRO but driver is using GRO
>
> Drivers with not using ethtool interface to disable LRO:
> pasemi_mac, sfc, ehea, cxgb3, cxgb4
cxgb4 uses GRO, not LRO.
^ permalink raw reply
* Re: [net-2.6 PATCH] ixgbe: fix possible NULL pointer deference in shutdown path
From: David Miller @ 2010-12-06 21:17 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, bphilips, donald.c.skidmore
In-Reply-To: <20101202065447.13252.88901.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 01 Dec 2010 22:54:53 -0800
> From: Don Skidmore <donald.c.skidmore@intel.com>
>
> After freeing the rings we were not zeroing out the ring count values.
> This patch now clears these counts correctly.
>
> Reported-by: Yinghai Lu <yinghai@kernel.org>
> Signed-off-by: Don Skidmore <donald.c.skidmore@intel.com>
> Tested-by: Stephen Ko <stephen.s.ko@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
> ---
>
> 0 files changed, 0 insertions(+), 0 deletions(-)
Whoa. Some stacked-GIT problem or something like that?
Please check it out.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 1/2] ixgbe: fix for link failure on SFP+ DA cables
From: David Miller @ 2010-12-06 21:21 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, bphilips, donald.c.skidmore
In-Reply-To: <20101203232218.21869.62349.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Fri, 03 Dec 2010 15:23:30 -0800
> From: Don Skidmore <donald.c.skidmore@intel.com>
>
> This patch helps prevent FW/SW semaphore collision from leading
> to link establishment failure. The collision might mess up the
> PHY registers so we reset the PHY. However there are SFI/KR areas
> in the PHY that are not reset with a Reset_AN so we need to change
> LMS to reset it. Also wait until AN state machine is AN_GOOD
>
> Signed-off-by: Don Skidmore <donald.c.skidmore@intel.com>
> Tested-by: Stephen Ko <stephen.s.ko@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox