* Re: [stable] [PATCH 2.6.36] vlan: Avoid hwaccel vlan packets when vid not used
From: Greg KH @ 2010-12-08 23:06 UTC (permalink / raw)
To: David Miller
Cc: eric.dumazet, lkml20101129, netdev, jesse, linux-kernel, greearb,
stable
In-Reply-To: <20101208.084731.189716071.davem@davemloft.net>
On Wed, Dec 08, 2010 at 08:47:31AM -0800, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Wed, 01 Dec 2010 11:55:14 +0100
>
>
> Greg/-stable, please integrate this patch from Eric into 2.6.36 if you
> haven't already done so.
It looks like I took a different, older version, I'll update it to this
one now.
thanks,
greg k-h
^ permalink raw reply
* [net-2.6 PATCH] enic: Bug Fix: Pass napi reference to the isr that services receive queue
From: Vasanthy Kolluri @ 2010-12-08 23:05 UTC (permalink / raw)
To: davem; +Cc: netdev, roprabhu, dwang2
From: Vasanthy Kolluri <vkolluri@cisco.com>
Pass reference to napi instead of enic device to the isr that services receive queue.
Signed-off-by: Vasanthy Kolluri <vkolluri@cisco.com>
Signed-off-by: Roopa Prabhu <roprabhu@cisco.com>
Signed-off-by: David Wang <dwang2@cisco.com>
---
drivers/net/enic/enic_main.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
index a466ef9..aa28b27 100644
--- a/drivers/net/enic/enic_main.c
+++ b/drivers/net/enic/enic_main.c
@@ -1962,7 +1962,8 @@ static void enic_poll_controller(struct net_device *netdev)
case VNIC_DEV_INTR_MODE_MSIX:
for (i = 0; i < enic->rq_count; i++) {
intr = enic_msix_rq_intr(enic, i);
- enic_isr_msix_rq(enic->msix_entry[intr].vector, enic);
+ enic_isr_msix_rq(enic->msix_entry[intr].vector,
+ &enic->napi[i]);
}
intr = enic_msix_wq_intr(enic, i);
enic_isr_msix_wq(enic->msix_entry[intr].vector, enic);
^ permalink raw reply related
* Re: [STABLE 2.6.32 PATCH] net: release dst entry while cache-hot for GSO case too
From: Greg KH @ 2010-12-08 23:05 UTC (permalink / raw)
To: avagin@gmail.com
Cc: krkumar2, avagin, eric.dumazet, netdev, Greg Kroah-Hartman, mjt,
stable, David Miller
In-Reply-To: <4D000B0D.2060101@gmail.com>
On Thu, Dec 09, 2010 at 01:47:41AM +0300, avagin@gmail.com wrote:
> Hi Greg,
>
> This patch is acked by David S. Miller. Greg, maybe you can commit it?
What specific patch please?
confused,
greg k-h
^ permalink raw reply
* [net-next-2.6 PATCH] enic: Add ndo_set_rx_mode support for enic vnics
From: Roopa Prabhu @ 2010-12-08 23:01 UTC (permalink / raw)
To: davem; +Cc: netdev
From: Roopa Prabhu <roprabhu@cisco.com>
Add ndo_set_rx_mode support to register unicast and multicast
address filters for enic devices
Signed-off-by: Roopa Prabhu <roprabhu@cisco.com>
Signed-off-by: David Wang <dwang2@cisco.com>
Signed-off-by: Christian Benvenuti <benve@cisco.com>
---
drivers/net/enic/enic.h | 4 +
drivers/net/enic/enic_main.c | 121 ++++++++++++++++++++++++++++++++++--------
drivers/net/enic/enic_res.h | 1
3 files changed, 102 insertions(+), 24 deletions(-)
diff --git a/drivers/net/enic/enic.h b/drivers/net/enic/enic.h
index 7067254..8f374c1 100644
--- a/drivers/net/enic/enic.h
+++ b/drivers/net/enic/enic.h
@@ -32,7 +32,7 @@
#define DRV_NAME "enic"
#define DRV_DESCRIPTION "Cisco VIC Ethernet NIC Driver"
-#define DRV_VERSION "1.4.1.7"
+#define DRV_VERSION "1.4.1.8"
#define DRV_COPYRIGHT "Copyright 2008-2010 Cisco Systems, Inc"
#define ENIC_BARS_MAX 6
@@ -78,8 +78,10 @@ struct enic {
spinlock_t devcmd_lock;
u8 mac_addr[ETH_ALEN];
u8 mc_addr[ENIC_MULTICAST_PERFECT_FILTERS][ETH_ALEN];
+ u8 uc_addr[ENIC_UNICAST_PERFECT_FILTERS][ETH_ALEN];
unsigned int flags;
unsigned int mc_count;
+ unsigned int uc_count;
int csum_rx_enabled;
u32 port_mtu;
u32 rx_coalesce_usecs;
diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
index 9f293fa..1931f15 100644
--- a/drivers/net/enic/enic_main.c
+++ b/drivers/net/enic/enic_main.c
@@ -1002,7 +1002,7 @@ static int enic_dev_packet_filter(struct enic *enic, int directed,
return err;
}
-static int enic_dev_add_multicast_addr(struct enic *enic, u8 *addr)
+static int enic_dev_add_addr(struct enic *enic, u8 *addr)
{
int err;
@@ -1013,7 +1013,7 @@ static int enic_dev_add_multicast_addr(struct enic *enic, u8 *addr)
return err;
}
-static int enic_dev_del_multicast_addr(struct enic *enic, u8 *addr)
+static int enic_dev_del_addr(struct enic *enic, u8 *addr)
{
int err;
@@ -1024,29 +1024,19 @@ static int enic_dev_del_multicast_addr(struct enic *enic, u8 *addr)
return err;
}
-/* netif_tx_lock held, BHs disabled */
-static void enic_set_multicast_list(struct net_device *netdev)
+static void enic_add_multicast_addr_list(struct enic *enic)
{
- struct enic *enic = netdev_priv(netdev);
+ struct net_device *netdev = enic->netdev;
struct netdev_hw_addr *ha;
- int directed = 1;
- int multicast = (netdev->flags & IFF_MULTICAST) ? 1 : 0;
- int broadcast = (netdev->flags & IFF_BROADCAST) ? 1 : 0;
- int promisc = (netdev->flags & IFF_PROMISC) ? 1 : 0;
unsigned int mc_count = netdev_mc_count(netdev);
- int allmulti = (netdev->flags & IFF_ALLMULTI) ||
- mc_count > ENIC_MULTICAST_PERFECT_FILTERS;
- unsigned int flags = netdev->flags | (allmulti ? IFF_ALLMULTI : 0);
u8 mc_addr[ENIC_MULTICAST_PERFECT_FILTERS][ETH_ALEN];
unsigned int i, j;
- if (mc_count > ENIC_MULTICAST_PERFECT_FILTERS)
+ if (mc_count > ENIC_MULTICAST_PERFECT_FILTERS) {
+ netdev_warn(netdev, "Registering only %d out of %d "
+ "multicast addresses\n",
+ ENIC_MULTICAST_PERFECT_FILTERS, mc_count);
mc_count = ENIC_MULTICAST_PERFECT_FILTERS;
-
- if (enic->flags != flags) {
- enic->flags = flags;
- enic_dev_packet_filter(enic, directed,
- multicast, broadcast, promisc, allmulti);
}
/* Is there an easier way? Trying to minimize to
@@ -1068,7 +1058,7 @@ static void enic_set_multicast_list(struct net_device *netdev)
mc_addr[j]) == 0)
break;
if (j == mc_count)
- enic_dev_del_multicast_addr(enic, enic->mc_addr[i]);
+ enic_dev_del_addr(enic, enic->mc_addr[i]);
}
for (i = 0; i < mc_count; i++) {
@@ -1077,7 +1067,7 @@ static void enic_set_multicast_list(struct net_device *netdev)
enic->mc_addr[j]) == 0)
break;
if (j == enic->mc_count)
- enic_dev_add_multicast_addr(enic, mc_addr[i]);
+ enic_dev_add_addr(enic, mc_addr[i]);
}
/* Save the list to compare against next time
@@ -1089,6 +1079,89 @@ static void enic_set_multicast_list(struct net_device *netdev)
enic->mc_count = mc_count;
}
+static void enic_add_unicast_addr_list(struct enic *enic)
+{
+ struct net_device *netdev = enic->netdev;
+ struct netdev_hw_addr *ha;
+ unsigned int uc_count = netdev_uc_count(netdev);
+ u8 uc_addr[ENIC_UNICAST_PERFECT_FILTERS][ETH_ALEN];
+ unsigned int i, j;
+
+ if (uc_count > ENIC_UNICAST_PERFECT_FILTERS) {
+ netdev_warn(netdev, "Registering only %d out of %d "
+ "unicast addresses\n",
+ ENIC_UNICAST_PERFECT_FILTERS, uc_count);
+ uc_count = ENIC_UNICAST_PERFECT_FILTERS;
+ }
+
+ /* Is there an easier way? Trying to minimize to
+ * calls to add/del unicast addrs. We keep the
+ * addrs from the last call in enic->uc_addr and
+ * look for changes to add/del.
+ */
+
+ i = 0;
+ netdev_for_each_uc_addr(ha, netdev) {
+ if (i == uc_count)
+ break;
+ memcpy(uc_addr[i++], ha->addr, ETH_ALEN);
+ }
+
+ for (i = 0; i < enic->uc_count; i++) {
+ for (j = 0; j < uc_count; j++)
+ if (compare_ether_addr(enic->uc_addr[i],
+ uc_addr[j]) == 0)
+ break;
+ if (j == uc_count)
+ enic_dev_del_addr(enic, enic->uc_addr[i]);
+ }
+
+ for (i = 0; i < uc_count; i++) {
+ for (j = 0; j < enic->uc_count; j++)
+ if (compare_ether_addr(uc_addr[i],
+ enic->uc_addr[j]) == 0)
+ break;
+ if (j == enic->uc_count)
+ enic_dev_add_addr(enic, uc_addr[i]);
+ }
+
+ /* Save the list to compare against next time
+ */
+
+ for (i = 0; i < uc_count; i++)
+ memcpy(enic->uc_addr[i], uc_addr[i], ETH_ALEN);
+
+ enic->uc_count = uc_count;
+}
+
+/* netif_tx_lock held, BHs disabled */
+static void enic_set_rx_mode(struct net_device *netdev)
+{
+ struct enic *enic = netdev_priv(netdev);
+ int directed = 1;
+ int multicast = (netdev->flags & IFF_MULTICAST) ? 1 : 0;
+ int broadcast = (netdev->flags & IFF_BROADCAST) ? 1 : 0;
+ int promisc = (netdev->flags & IFF_PROMISC) ||
+ netdev_uc_count(netdev) > ENIC_UNICAST_PERFECT_FILTERS;
+ int allmulti = (netdev->flags & IFF_ALLMULTI) ||
+ netdev_mc_count(netdev) > ENIC_MULTICAST_PERFECT_FILTERS;
+ unsigned int flags = netdev->flags |
+ (allmulti ? IFF_ALLMULTI : 0) |
+ (promisc ? IFF_PROMISC : 0);
+
+ if (enic->flags != flags) {
+ enic->flags = flags;
+ enic_dev_packet_filter(enic, directed,
+ multicast, broadcast, promisc, allmulti);
+ }
+
+ if (!promisc) {
+ enic_add_unicast_addr_list(enic);
+ if (!allmulti)
+ enic_add_multicast_addr_list(enic);
+ }
+}
+
/* rtnl lock is held */
static void enic_vlan_rx_register(struct net_device *netdev,
struct vlan_group *vlan_group)
@@ -1852,7 +1925,7 @@ static int enic_open(struct net_device *netdev)
vnic_rq_enable(&enic->rq[i]);
enic_dev_add_station_addr(enic);
- enic_set_multicast_list(netdev);
+ enic_set_rx_mode(netdev);
netif_wake_queue(netdev);
@@ -2328,7 +2401,8 @@ static const struct net_device_ops enic_netdev_dynamic_ops = {
.ndo_start_xmit = enic_hard_start_xmit,
.ndo_get_stats = enic_get_stats,
.ndo_validate_addr = eth_validate_addr,
- .ndo_set_multicast_list = enic_set_multicast_list,
+ .ndo_set_rx_mode = enic_set_rx_mode,
+ .ndo_set_multicast_list = enic_set_rx_mode,
.ndo_set_mac_address = enic_set_mac_address_dynamic,
.ndo_change_mtu = enic_change_mtu,
.ndo_vlan_rx_register = enic_vlan_rx_register,
@@ -2349,7 +2423,8 @@ static const struct net_device_ops enic_netdev_ops = {
.ndo_get_stats = enic_get_stats,
.ndo_validate_addr = eth_validate_addr,
.ndo_set_mac_address = enic_set_mac_address,
- .ndo_set_multicast_list = enic_set_multicast_list,
+ .ndo_set_rx_mode = enic_set_rx_mode,
+ .ndo_set_multicast_list = enic_set_rx_mode,
.ndo_change_mtu = enic_change_mtu,
.ndo_vlan_rx_register = enic_vlan_rx_register,
.ndo_vlan_rx_add_vid = enic_vlan_rx_add_vid,
diff --git a/drivers/net/enic/enic_res.h b/drivers/net/enic/enic_res.h
index 9a103d9..25be273 100644
--- a/drivers/net/enic/enic_res.h
+++ b/drivers/net/enic/enic_res.h
@@ -34,6 +34,7 @@
#define ENIC_MAX_MTU 9000
#define ENIC_MULTICAST_PERFECT_FILTERS 32
+#define ENIC_UNICAST_PERFECT_FILTERS 32
#define ENIC_NON_TSO_MAX_DESC 16
^ permalink raw reply related
* tc: show format ABI changed
From: Stephen Hemminger @ 2010-12-08 22:51 UTC (permalink / raw)
To: David Miller, Eric Dumazet, Jarek Poplawski; +Cc: netdev
Although well intentioned, the following patch should have not
been applied since it changes the kernel ABI. It broke some scripts
parsing the output format of tc commands.
Before HTB would report bogus zero values, now it reports
nothing and that changes the output format. Like the empty
fields in /proc, I argue we can't play fast and loose with
netlink responses.
Not a big deal to fix the script in this case, in this case
so don't revert it.
commit d250a5f90e53f5e150618186230795352d154c88
Author: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri Oct 2 10:32:18 2009 +0000
pkt_sched: gen_estimator: Dont report fake rate estimators
Jarek Poplawski a écrit :
>
>
> Hmm... So you made me to do some "real" work here, and guess what?:
> there is one serious checkpatch warning! ;-) Plus, this new parameter
> should be added to the function description. Otherwise:
> Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
>
> Thanks,
> Jarek P.
>
> PS: I guess full "Don't" would show we really mean it...
Okay :) Here is the last round, before the night !
Thanks again
[RFC] pkt_sched: gen_estimator: Don't report fake rate estimators
We currently send TCA_STATS_RATE_EST elements to netlink users, even if no estimator
is running.
# tc -s -d qdisc
qdisc pfifo_fast 0: dev eth0 root bands 3 priomap 1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1
Sent 112833764978 bytes 1495081739 pkt (dropped 0, overlimits 0 requeues 0)
rate 0bit 0pps backlog 0b 0p requeues 0
User has no way to tell if the "rate 0bit 0pps" is a real estimation, or a fake
one (because no estimator is active)
After this patch, tc command output is :
$ tc -s -d qdisc
qdisc pfifo_fast 0: dev eth0 root bands 3 priomap 1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1
Sent 561075 bytes 1196 pkt (dropped 0, overlimits 0 requeues 0)
backlog 0b 0p requeues 0
We add a parameter to gnet_stats_copy_rate_est() function so that
it can use gen_estimator_active(bstats, r), as suggested by Jarek.
This parameter can be NULL if check is not necessary, (htb for
example has a mandatory rate estimator)
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply
* Re: echo > 0 .../disable_ipv6 broken in 2.6.37-rc4
From: Brian Haley @ 2010-12-08 22:49 UTC (permalink / raw)
To: Eric W. Biederman
Cc: netdev, Mahesh Kelkar, Lorenzo Colitti, Stephen Hemminger
In-Reply-To: <m14oaoeywf.fsf@fess.ebiederm.org>
On 12/08/2010 04:29 PM, Eric W. Biederman wrote:
> Brian Haley <brian.haley@hp.com> writes:
>
>> On 12/05/2010 07:24 PM, Eric W. Biederman wrote:
>>>
>>> In 2.6.37-rc4 ipv6 can be disabled not enabled.
>>> The last kernel I have tested and know this works on is 2.6.33.
>>>
>>> To reproduce:
>>> ~ # ip link set lo up
>>> ~ # ping6 ::1
>>> PING ::1(::1) 56 data bytes
>>> 64 bytes from ::1: icmp_seq=1 ttl=64 time=0.026 ms
>>> ^C
>>> --- ::1 ping statistics ---
>>> 1 packets transmitted, 1 received, 0% packet loss, time 782ms
>>> rtt min/avg/max/mdev = 0.026/0.026/0.026/0.000 ms
>>> ~ # echo 1 > /proc/sys/net/ipv6/conf/lo/disable_ipv6
>>> ~ # ping6 ::1
>>> connect: Network is unreachable
>>> ~ # echo 0 > /proc/sys/net/ipv6/conf/lo/disable_ipv6
>>> ~ # ping6 ::1
<snip>
>> I'm pulling the latest tree now, my 2.6.32.24 system is running fine, so
>> it's something after that.
>
> Agreed. I don't have problems on 2.6.33 either, but because of overload
> I haven't been doing regular testing of the kernels inbetween.
This got broken in 2.6.34-rc1, and the most obvious culprit is this,
although I haven't bisected it:
commit dc2b99f71ef477a31020511876ab4403fb7c4420
Author: stephen hemminger <shemminger@vyatta.com>
Date: Mon Feb 8 19:48:05 2010 +0000
IPv6: keep permanent addresses on admin down
Permanent IPV6 addresses should not be removed when the link is
set to admin down, only when device is removed.
When link is lost permanent addresses should be marked as tentative
so that when link comes back they are subject to duplicate address
detection (if DAD was enabled for that address).
Other routing systems keep manually configured IPv6 addresses
when link is set down.
Even though there was a bugfix update, it didn't help.
I unfortunately won't be able to look at this more until at least Friday,
I couldn't come up with a quick patch just looking quickly at addrconf_ifdown().
-Brian
^ permalink raw reply
* Re: [STABLE 2.6.32 PATCH] net: release dst entry while cache-hot for GSO case too
From: avagin @ 2010-12-08 22:47 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: David Miller, eric.dumazet, mjt, avagin, stable, netdev, krkumar2
In-Reply-To: <20101026.115434.241921999.davem@davemloft.net>
Hi Greg,
This patch is acked by David S. Miller. Greg, maybe you can commit it?
On 10/26/2010 10:54 PM, David Miller wrote:
> From: Eric Dumazet<eric.dumazet@gmail.com>
> Date: Mon, 11 Oct 2010 18:30:52 +0200
>
>> Le lundi 11 octobre 2010 à 20:19 +0400, Andrew Vagin a écrit :
>>> On 10/11/2010 07:59 PM, David Miller wrote:
>>>> From: Eric Dumazet<eric.dumazet@gmail.com>
>>>> Date: Mon, 11 Oct 2010 17:46:49 +0200
>>>>
>>>>> This patch was an optimization, not a bug fix.
>>>> Right, this has no business going into 2.6.32-stable at all.
>>> This is bug fix. Now nobody drops dst in case gso and veth, because the
>>> commit 60df914e295a21a223e43a7ee01e0c73c64dd111 deletes skb_dst_drop
>>> from the veth.c. We should commit my patch or revert commit 60df914e.
>>>
>>> We have two bug reports:
>>>
>>> http://www.spinics.net/lists/netdev/msg142104.html
>>>
>>> http://bugzilla.openvz.org/show_bug.cgi?id=1634
>>>
>>> Taylan verified that the patch really fix his bug.
>>
>> Now that makes sense ;)
>
> In case there is any doubt about this -stable patch submission:
>
> Acked-by: David S. Miller<davem@davemloft.net>
^ permalink raw reply
* Re: [Bugme-new] [Bug 24472] New: Kernel panic - not syncing: Fatal Exception
From: Jarek Poplawski @ 2010-12-08 22:01 UTC (permalink / raw)
To: Paweł Staszewski
Cc: Andrew Morton, netdev, Paul Mackerras, bugzilla-daemon,
bugme-daemon, pstaszewski
In-Reply-To: <4CFFEB01.7040700@itcare.pl>
Paweł Staszewski wrote:
> W dniu 2010-12-08 21:22, Andrew Morton pisze:
>> (switched to email. Please respond via emailed reply-to-all, not via the
>> bugzilla web interface).
>>
>> On Wed, 8 Dec 2010 20:14:45 GMT
>> bugzilla-daemon@bugzilla.kernel.org wrote:
>>
>>> https://bugzilla.kernel.org/show_bug.cgi?id=24472
>>>
>>> Summary: Kernel panic - not syncing: Fatal Exception
>>> Product: Drivers
>>> Version: 2.5
>>> Kernel Version: 2.6.36.1
Hi,
Could you try to revert this patch?:
http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.36.y.git;a=commitdiff;h=55c95e738da85373965cb03b4f975d0fd559865b
Jarek P.
^ permalink raw reply
* Re: echo > 0 .../disable_ipv6 broken in 2.6.37-rc4
From: Eric W. Biederman @ 2010-12-08 21:29 UTC (permalink / raw)
To: Brian Haley; +Cc: netdev, Mahesh Kelkar, Lorenzo Colitti
In-Reply-To: <4CFD0AF0.9090809@hp.com>
Brian Haley <brian.haley@hp.com> writes:
> On 12/05/2010 07:24 PM, Eric W. Biederman wrote:
>>
>> In 2.6.37-rc4 ipv6 can be disabled not enabled.
>> The last kernel I have tested and know this works on is 2.6.33.
>>
>> To reproduce:
>> ~ # ip link set lo up
>> ~ # ping6 ::1
>> PING ::1(::1) 56 data bytes
>> 64 bytes from ::1: icmp_seq=1 ttl=64 time=0.026 ms
>> ^C
>> --- ::1 ping statistics ---
>> 1 packets transmitted, 1 received, 0% packet loss, time 782ms
>> rtt min/avg/max/mdev = 0.026/0.026/0.026/0.000 ms
>> ~ # echo 1 > /proc/sys/net/ipv6/conf/lo/disable_ipv6
>> ~ # ping6 ::1
>> connect: Network is unreachable
>> ~ # echo 0 > /proc/sys/net/ipv6/conf/lo/disable_ipv6
>> ~ # ping6 ::1
>> connect: Network is unreachable
>>
>>
>> I intend to poke at this a little more but at the moment
>> I am drawing a blank at what is going on.
>
> It should just be calling addrconf_notify() with either NETDEV_UP
> or NETDEV_DOWN. Does the address not come back? Or the route?
The address never went away, and I don't think we have a route to ::1.
Playing with this a little more if I delete the address and then bounce
the interface ping ::1 works again. So something is just not getting
reinitialized.
Unfortunately I don't see anything obvious. I'm still scratching my
head.
>> I intend to keep poking at this but if anyone can figure this out
>> before I do I would be greatly appreciative.
>
> I'm pulling the latest tree now, my 2.6.32.24 system is running fine, so
> it's something after that.
Agreed. I don't have problems on 2.6.33 either, but because of overload
I haven't been doing regular testing of the kernels inbetween.
Eric
^ permalink raw reply
* Re: pull request: wireless-next-2.6 2010-12-08
From: David Miller @ 2010-12-08 21:25 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, netdev
In-Reply-To: <20101208210432.GH2423@tuxdriver.com>
From: "John W. Linville" <linville@tuxdriver.com>
Date: Wed, 8 Dec 2010 16:04:32 -0500
> Here is the latest batch of updates intended for 2.6.38. It also
> includes my last wireless-2.6 pull request that you just added
> to net-2.6.
>
> This includes the usual batch of drivers updates, with ath9k and
> iwlwifi as the usual standouts. This also includes some mac80211
> documentation updates from Johannes, and a flurry of ath5k updates
> from Nick. This also includes a collection of bluetooth updates by
> way of Gustavo, a couple of libertas updates, some more work on b43
> N-phy support, and a variety of other patches.
>
> Please let me know if there are problems!
Ok, I'll suck this in later tonight, thanks John. I'm working
on the net-2.6 --> net-next-2.6 merge at the moment.
^ permalink raw reply
* Re: [PATCH 0/2] New jhash function
From: Rusty Russell @ 2010-12-08 21:23 UTC (permalink / raw)
To: David Miller; +Cc: kadlec, linux-kernel, netdev, netfilter-devel, torvalds
In-Reply-To: <20101208.090954.115924303.davem@davemloft.net>
On Thu, 9 Dec 2010 03:39:54 am David Miller wrote:
> From: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
> Date: Fri, 3 Dec 2010 13:38:59 +0100
>
> > The current jhash.h implements the lookup2() hash function by Bob Jenkins.
> > However, lookup2() is outdated as Bob wrote a new hash function called
> > lookup3(). There is a longer comparison of those two and other hash
> > functions at http://burtleburtle.net/bob/hash/doobs.html.
> >
> > Please consider applying the following patches.
>
> Patch #1 is already in the net-next-2.6 tree, and as long as there are
> no major objections to the general crowd (including Rusty et al.) I am
> happy to put patch #2 into my tree as well.
>
> Rusty, does the current version of patch #2 look good to you?
Yes, 2/2 good. Thanks Jozsef!
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
^ permalink raw reply
* 2.6.37-rc5: NULL pointer oops in selinux_socket_unix_stream_connect
From: Jeremy Fitzhardinge @ 2010-12-08 21:09 UTC (permalink / raw)
To: James Morris, Stephen Smalley; +Cc: NetDev, Linux Kernel Mailing List
I just got this oops in a freshly booted 2.6.37-rc5 Xen domain, while
sitting idle at the login prompt:
BUG: unable to handle kernel NULL pointer dereference at 0000000000000210
IP: [<ffffffff811d55d4>] selinux_socket_unix_stream_connect+0x29/0xa0
PGD 1c99d067 PUD 1cb03067 PMD 0
Oops: 0000 [#1] SMP
last sysfs file: /sys/devices/system/cpu/sched_mc_power_savings
CPU 0
Modules linked in: sunrpc dm_mirror dm_region_hash dm_log [last unloaded: scsi_wait_scan]
Pid: 2297, comm: at-spi-registry Not tainted 2.6.37-rc5+ #293 /
RIP: e030:[<ffffffff811d55d4>] [<ffffffff811d55d4>] selinux_socket_unix_stream_connect+0x29/0xa0
RSP: e02b:ffff880006e7dd68 EFLAGS: 00010292
RAX: ffff88001d1ed8c0 RBX: ffff88001d06d9a0 RCX: 0000000000000022
RDX: ffff88001d1ed580 RSI: 0000000000000000 RDI: ffff88001b7d6ac0
RBP: ffff880006e7de18 R08: 00000000ffff0201 R09: ffff88001e78c968
R10: 000000001f47e9c2 R11: ffff88001fbf4400 R12: ffff88001d1ed8c0
R13: ffff88001d1ed580 R14: ffff88001ca00cc0 R15: 0000000000000000
FS: 00007fa643031920(0000) GS:ffff88001ff85000(0000) knlGS:0000000000000000
CS: e033 DS: 0000 ES: 0000 CR0: 000000008005003b
CR2: 0000000000000210 CR3: 000000001d78a000 CR4: 0000000000002660
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
Process at-spi-registry (pid: 2297, threadinfo ffff880006e7c000, task ffff88001cdd1140)
Stack:
ffff88001d4c0bc0 000000004cffecc5 ffff880006e7ddc8 ffffffff81028dc5
ffff8800ffffffff 0001628b2ec3fe22 ffff880006e7dde8 ffff88001d1edb80
0000000000000001 0000936a4da34099 0000000000000000 00000000000000fa
Call Trace:
[<ffffffff81028dc5>] ? pvclock_clocksource_read+0x48/0xb1
[<ffffffff810074ab>] ? xen_clocksource_read+0x20/0x22
[<ffffffff81008fd9>] ? xen_spin_lock+0xc6/0xd9
[<ffffffff811d1d1e>] security_unix_stream_connect+0x16/0x18
[<ffffffff81484366>] unix_stream_connect+0x215/0x3ff
[<ffffffff813f351d>] sys_connect+0x7a/0xa0
[<ffffffff8108cd9d>] ? audit_syscall_entry+0x1c2/0x1ee
[<ffffffff8100bb42>] system_call_fastpath+0x16/0x1b
Code: c9 c3 55 48 89 e5 41 55 41 54 53 48 81 ec 98 00 00 00 0f 1f 44 00 00 b9 22 00 00 00 48 8b 47 20 48 8b 76 20 48 8b 98 10 02 00 00 <4c> 8b a6 10 02 00 00 31 c0 4c 8b aa 10 02 00 00 4c 8d 85 50 ff
RIP [<ffffffff811d55d4>] selinux_socket_unix_stream_connect+0x29/0xa0
RSP <ffff880006e7dd68>
CR2: 0000000000000210
---[ end trace 50030b578c1ee27e ]---
This corresponds to:
(gdb) list *0xffffffff811d55d4
0xffffffff811d55d4 is in selinux_socket_unix_stream_connect (/home/jeremy/git/upstream/security/selinux/hooks.c:3929).
3924 static int selinux_socket_unix_stream_connect(struct socket *sock,
3925 struct socket *other,
3926 struct sock *newsk)
3927 {
3928 struct sk_security_struct *sksec_sock = sock->sk->sk_security;
3929 struct sk_security_struct *sksec_other = other->sk->sk_security;
3930 struct sk_security_struct *sksec_new = newsk->sk_security;
3931 struct common_audit_data ad;
3932 int err;
3933
The system is a somewhat out of date Fedora 13 with
selinux-policy-3.7.19-73.fc13.noarch and
selinux-policy-targeted-3.7.19-73.fc13.noarch installed.
I'm not sure what at-spi-registry is or what it is trying to do here.
The crash seems non-deterministic; I rebooted the domain without any issues.
Thanks,
J
^ permalink raw reply
* pull request: wireless-next-2.6 2010-12-08
From: John W. Linville @ 2010-12-08 21:04 UTC (permalink / raw)
To: davem-fT/PcQaiUtIeIZ0/mPfg9Q
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA
Dave,
Here is the latest batch of updates intended for 2.6.38. It also
includes my last wireless-2.6 pull request that you just added
to net-2.6.
This includes the usual batch of drivers updates, with ath9k and
iwlwifi as the usual standouts. This also includes some mac80211
documentation updates from Johannes, and a flurry of ath5k updates
from Nick. This also includes a collection of bluetooth updates by
way of Gustavo, a couple of libertas updates, some more work on b43
N-phy support, and a variety of other patches.
Please let me know if there are problems!
Thanks,
John
---
The following changes since commit cfa969e385a23e4c85f50e0ed5de25a2e18bf9d4:
Revert "ehea: Use the standard logging functions" (2010-12-06 20:45:28 -0800)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next-2.6.git for-davem
Anderson Lizardo (1):
Bluetooth: Fix error handling for l2cap_init()
Andrei Emeltchenko (8):
Bluetooth: Check sk is not owned before freeing l2cap_conn
Bluetooth: timer check sk is not owned before freeing
Bluetooth: do not use assignment in if condition
Bluetooth: clean up sco code
Bluetooth: clean up rfcomm code
Bluetooth: clean up l2cap code
Bluetooth: clean up hci code
Bluetooth: clean up legal text
Andy Shevchenko (1):
wireless: ray_cs: use '%pm' format option to print MAC
Bala Shanmugam (1):
Bluetooth: Add new PID for Atheros 3011
Ben Greear (1):
ath9k: Move debugfs under ieee80211/[phyname]/ath9k/
Bruno Randolf (1):
cfg80211: Add documentation for antenna ops
Christian Lamparter (2):
carl9170: fix carl9170_tx_prepare typo
mac80211: ignore non-bcast mcast deauth/disassoc franes
Daniel Drake (1):
libertas: fix memory corruption in lbs_remove_card()
David Kilroy (1):
orinoco: abort scan on interface down
Felix Fietkau (12):
ath9k: fix software retry counter tracking
ath9k_hw: fix endian issues with CTLs on AR9003
ath9k_hw: fix more bitfield related endian issues
ath5k: Use Generic DMA for later support of AHB bus.
ath5k: Introduce ath5k_init_softc function as in ath9k
ath5k: Move PCI bus functions to separate file.
ath5k: Use generic eeprom read from common ath_bus_opts struct.
ath5k: Check if pci pdev struct is initialized in common functions.
ath5k: Add a function to read chipset's MAC revision
ath5k: Add initial registers values for radio RF2317 chip.
ath5k: Add AHB bus support.
ath5k: Fix reset and interrupts for AHB type of devices.
Gabor Juhos (1):
ath9k: use per-device struct for pm_qos_* operations
Gustavo F. Padovan (4):
Bluetooth: Fix not returning proper error in SCO
Merge git://git.kernel.org/.../padovan/bluetooth-2.6 into test
Bluetooth: Get rid of __l2cap_get_sock_by_psm()
Bluetooth: Get rid of __rfcomm_get_sock_by_channel()
Hauke Mehrtens (1):
ssb: Add sysfs attributes to ssb devices
Helmut Schaa (1):
mac80211: Minor optimization in ieee80211_rx_h_data
Joe Perches (2):
ath9k: hif_usb: Reduce indent 1 column
wireless: Remove unnecessary casts of usb_get_intfdata
Johan Hedberg (3):
Bluetooth: Simplify remote features callback function logic
Bluetooth: Create a unified authentication request function
Bluetooth: Automate remote name requests
Johannes Berg (17):
iwlagn: remove powersave warning
iwlagn: fix station powersave accounting for aggregation
iwlagn: advertise reliable TX status
iwlwifi: use mac80211 AC defines
ath9k/carl9170: advertise P2P
nl80211/cfg80211: extend mgmt-tx API for off-channel
mac80211: implement off-channel mgmt TX
mac80211: fix RX aggregation locking
cfg80211: include CQM packet loss docs
mac80211: document workqueue
mac80211: publish docs for _ni functions
mac80211: publish some misc docs
mac80211: publish some rate control docs
mac80211: document aggregation
mac80211: publish interface iteration docs
mac80211: document station handling
mac80211: publish SMPS docs
Johannes Stezenbach (1):
mac80211/rt2x00: add ieee80211_tx_status_ni()
John W. Linville (5):
Merge branch 'master' of git://git.kernel.org/.../padovan/bluetooth-2.6
Revert "ath9k: Fix STA disconnect issue due to received MIC failed bcast frames"
Merge branch 'master' of git://git.kernel.org/.../padovan/bluetooth-next-2.6
Merge branch 'master' of git://git.kernel.org/.../linville/wireless-2.6
Merge branch 'master' of git://git.kernel.org/.../linville/wireless-next-2.6 into for-davem
Jouni Malinen (1):
mac80211: Fix frame injection using non-AP vif
Mohammed Shafi Shajakhan (1):
ath9k: Add support for Adaptive Power Management
Nick Kossifidis (30):
ath5k: Reset cleanup and generic cleanup
ath5k: Add new function to stop rx/tx DMA
ath5k: Stop PCU on reset
ath5k: Use new dma_stop function on base.c
ath5k: Debug DMA timeouts
ath5k: Use DCU early termination correctly
ath5k: Check RXE when setting RXDP
ath5k: Use new function to stop beacon queue
ath5k: Add new field on ath5k_hw to track bandwidth modes
ath5k: Put core clock initialization on a new function
ath5k: Small cleanup on tweak_initvals
ath5k: Increase PHY settling parameters for turo mode
ath5k: Move tx retries setting outside reset_tx_queue
ath5k: Extend get_default_sifs/slot_time
ath5k: Extend rate_duration
ath5k: Set all IFS intervals, not just slot time
ath5k: Use turbo flag on DCU
ath5k: Always set IFS intervals on reset
ath5k: Tweak power detector delays on RF5111/RF5112
ath5k: Update spur mitigation filter for turbo/half/quarter
ath5k: Update PLL programming for turbo/half/quarter
ath5k: Skip powertable setting when we are on the same channel
ath5k: Support synth-only channel change for AR2413/AR5413
ath5k: No need to save/restore staid flags on reset
ath5k: Tweak phy activate to rx start delay based on bwmode
ath5k: Skip tx power setting on AR5210 for now
ath5k: Use correct clock when setting ofdm timings
ath5k: Cleanup turbo channel flags
ath5k: Clean up turbo mode initvals/rfregs
ath5k: Set turbo bit on rf bank 2
Rafał Miłecki (8):
ssb: extract indexes for power tables
b43: N-PHY: swap values for radio registers 0x3b and 0x3c
b43: N-PHY: implement very basic TX power control management
b43: N-PHY: initialize perical variable, add missing call to CCA reset
b43: N-PHY: fix RSSI calibration
b43: N-PHY: fix RSSI selection
b43: N-PHY: use defines for RSSI types
b43: N-PHY: fix code path on PHY init
Rajkumar Manoharan (2):
ath9k: Disable SWBA interrupt on remove_interface
Revert "ath9k_htc: Handle monitor mode properly for HTC devices"
Senthil Balasubramanian (2):
mac80211: Fix STA disconnect due to MIC failure
ath9k: Fix STA disconnect issue due to received MIC failed bcast frames
Stanislaw Gruszka (1):
iwlagn: fix microcode error on 4965
Stefan Seyfried (1):
Bluetooth: Fix log spamming in btusb due to autosuspend
Sujith Manoharan (1):
ath9k_htc: Remove unused structures
Sven Neumann (1):
libertas: fix invalid access
Vasanthakumar Thiagarajan (3):
ath9k: Reintroduce modparam to enable btcoex
ath9k: Remove code which enables btcoex based on subsys id
ath9k: Fix bug in reading input gpio state for ar9003
Vasiliy Kulikov (3):
Bluetooth: bnep: fix information leak to userland
Bluetooth: cmtp: fix information leak to userland
Bluetooth: hidp: fix information leak to userland
Wey-Yi Guy (8):
iwlwifi: remove unused define
iwlwifi: use antenna information in EEPROM
iwlagn: Offical name for 6050g2 device
iwlagn: Offical name for 6000g2a device
iwlagn: Offical name for 6000g2b device
iwlagn: Offical name for 100/130 device
iwlagn: use different kill mask when SCO active
iwlagn: minor change in bt coex normal LUT
Documentation/DocBook/80211.tmpl | 70 ++-
drivers/bluetooth/ath3k.c | 4 +
drivers/bluetooth/btusb.c | 12 +-
drivers/net/wireless/ath/ar9170/usb.c | 6 +-
drivers/net/wireless/ath/ath.h | 2 +
drivers/net/wireless/ath/ath5k/Kconfig | 17 +-
drivers/net/wireless/ath/ath5k/Makefile | 2 +
drivers/net/wireless/ath/ath5k/ahb.c | 219 +++++
drivers/net/wireless/ath/ath5k/ani.c | 6 +-
drivers/net/wireless/ath/ath5k/ath5k.h | 260 ++++--
drivers/net/wireless/ath/ath5k/attach.c | 28 +-
drivers/net/wireless/ath/ath5k/base.c | 753 ++++++----------
drivers/net/wireless/ath/ath5k/base.h | 5 +-
drivers/net/wireless/ath/ath5k/caps.c | 6 -
drivers/net/wireless/ath/ath5k/debug.c | 1 +
drivers/net/wireless/ath/ath5k/debug.h | 2 +
drivers/net/wireless/ath/ath5k/desc.c | 24 +-
drivers/net/wireless/ath/ath5k/dma.c | 180 ++++-
drivers/net/wireless/ath/ath5k/eeprom.c | 127 ++--
drivers/net/wireless/ath/ath5k/eeprom.h | 2 +-
drivers/net/wireless/ath/ath5k/initvals.c | 409 ++++----
drivers/net/wireless/ath/ath5k/led.c | 11 +-
drivers/net/wireless/ath/ath5k/pci.c | 326 +++++++
drivers/net/wireless/ath/ath5k/pcu.c | 571 ++++++++----
drivers/net/wireless/ath/ath5k/phy.c | 641 ++++++++++---
drivers/net/wireless/ath/ath5k/qcu.c | 692 ++++++++------
drivers/net/wireless/ath/ath5k/reg.h | 31 +-
drivers/net/wireless/ath/ath5k/reset.c | 1221 +++++++++++-------------
drivers/net/wireless/ath/ath5k/rfbuffer.h | 1169 ++++++++---------------
drivers/net/wireless/ath/ath5k/sysfs.c | 4 +-
drivers/net/wireless/ath/ath9k/ar9003_eeprom.c | 317 ++++---
drivers/net/wireless/ath/ath9k/ar9003_eeprom.h | 9 +-
drivers/net/wireless/ath/ath9k/ar9003_phy.c | 6 +-
drivers/net/wireless/ath/ath9k/ath9k.h | 7 +-
drivers/net/wireless/ath/ath9k/beacon.c | 3 +-
drivers/net/wireless/ath/ath9k/btcoex.c | 23 -
drivers/net/wireless/ath/ath9k/btcoex.h | 1 -
drivers/net/wireless/ath/ath9k/debug.c | 35 +-
drivers/net/wireless/ath/ath9k/debug.h | 16 -
drivers/net/wireless/ath/ath9k/eeprom.c | 6 +-
drivers/net/wireless/ath/ath9k/eeprom.h | 28 +-
drivers/net/wireless/ath/ath9k/eeprom_def.c | 11 +-
drivers/net/wireless/ath/ath9k/hif_usb.c | 119 ++--
drivers/net/wireless/ath/ath9k/htc_drv_main.c | 64 ++-
drivers/net/wireless/ath/ath9k/htc_hst.h | 19 -
drivers/net/wireless/ath/ath9k/hw.c | 12 +-
drivers/net/wireless/ath/ath9k/hw.h | 1 +
drivers/net/wireless/ath/ath9k/init.c | 44 +-
drivers/net/wireless/ath/ath9k/main.c | 21 +-
drivers/net/wireless/ath/ath9k/reg.h | 6 +-
drivers/net/wireless/ath/ath9k/xmit.c | 27 +-
drivers/net/wireless/ath/carl9170/fw.c | 3 +-
drivers/net/wireless/ath/carl9170/main.c | 3 +-
drivers/net/wireless/ath/carl9170/tx.c | 2 +-
drivers/net/wireless/ath/carl9170/usb.c | 3 +-
drivers/net/wireless/b43/phy_n.c | 305 +++++--
drivers/net/wireless/b43/phy_n.h | 2 +-
drivers/net/wireless/b43/radio_2055.c | 246 +++---
drivers/net/wireless/iwlwifi/iwl-1000.c | 12 +-
drivers/net/wireless/iwlwifi/iwl-5000.c | 20 +-
drivers/net/wireless/iwlwifi/iwl-6000.c | 66 +-
drivers/net/wireless/iwlwifi/iwl-agn-eeprom.c | 20 +
drivers/net/wireless/iwlwifi/iwl-agn-lib.c | 34 +-
drivers/net/wireless/iwlwifi/iwl-agn-tx.c | 45 +-
drivers/net/wireless/iwlwifi/iwl-agn-ucode.c | 24 +-
drivers/net/wireless/iwlwifi/iwl-agn.c | 3 +-
drivers/net/wireless/iwlwifi/iwl-commands.h | 1 +
drivers/net/wireless/iwlwifi/iwl-eeprom.h | 1 -
drivers/net/wireless/libertas/if_sdio.c | 1 -
drivers/net/wireless/libertas/if_spi.c | 1 -
drivers/net/wireless/libertas/main.c | 2 -
drivers/net/wireless/orinoco/main.c | 12 +-
drivers/net/wireless/orinoco/scan.c | 8 +
drivers/net/wireless/orinoco/scan.h | 1 +
drivers/net/wireless/p54/p54usb.c | 2 +-
drivers/net/wireless/ray_cs.c | 14 +-
drivers/net/wireless/rt2x00/rt2800pci.c | 1 +
drivers/net/wireless/rt2x00/rt2x00.h | 1 +
drivers/net/wireless/rt2x00/rt2x00dev.c | 9 +-
drivers/net/wireless/zd1201.c | 2 +-
drivers/ssb/main.c | 30 +
drivers/ssb/pci.c | 44 +
include/linux/nl80211.h | 25 +-
include/linux/ssb/ssb.h | 4 +
include/linux/ssb/ssb_regs.h | 40 +
include/net/bluetooth/hci.h | 16 +-
include/net/bluetooth/hci_core.h | 14 +-
include/net/bluetooth/l2cap.h | 22 +-
include/net/bluetooth/rfcomm.h | 18 +-
include/net/bluetooth/sco.h | 20 +-
include/net/cfg80211.h | 18 +-
include/net/mac80211.h | 28 +-
net/bluetooth/bnep/core.c | 1 +
net/bluetooth/cmtp/core.c | 1 +
net/bluetooth/hci_conn.c | 23 +-
net/bluetooth/hci_core.c | 66 +-
net/bluetooth/hci_event.c | 177 +++-
net/bluetooth/hci_sock.c | 17 +-
net/bluetooth/hidp/core.c | 2 +-
net/bluetooth/l2cap.c | 94 ++-
net/bluetooth/rfcomm/core.c | 8 +-
net/bluetooth/rfcomm/sock.c | 24 +-
net/bluetooth/rfcomm/tty.c | 28 +-
net/bluetooth/sco.c | 28 +-
net/mac80211/agg-rx.c | 8 +-
net/mac80211/cfg.c | 94 ++-
net/mac80211/debugfs_sta.c | 29 +-
net/mac80211/ieee80211_i.h | 5 +
net/mac80211/rx.c | 28 +-
net/mac80211/sta_info.h | 29 +-
net/mac80211/status.c | 15 +-
net/mac80211/tx.c | 7 +-
net/mac80211/work.c | 22 +
net/wireless/core.h | 4 +-
net/wireless/mlme.c | 9 +-
net/wireless/nl80211.c | 57 +-
116 files changed, 5566 insertions(+), 3909 deletions(-)
create mode 100644 drivers/net/wireless/ath/ath5k/ahb.c
create mode 100644 drivers/net/wireless/ath/ath5k/pci.c
Omnibus patch is available here:
http://www.kernel.org/pub/linux/kernel/people/linville/wireless-next-2.6-2010-12-08.patch.bz2
--
John W. Linville Someday the world will need a hero, and you
linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org might be all we have. Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* refcounting on dgram Unix sockets for poll(POLLOUT)
From: Alban Crequy @ 2010-12-08 21:01 UTC (permalink / raw)
To: netdev
Hi,
When a connected datagram Unix socket is polled for POLLOUT events, the
poller is added in the wait_queue_head_t of the "server" socket:
net/unix/af_unix.c::unix_dgram_poll()
other = unix_peer_get(sk);
if (other) {
if (unix_peer(other) != sk) {
sock_poll_wait(file, &unix_sk(other)->peer_wait,
wait);
...
I wonder what prevent the "server" socket ("other") to be released
while the poller is still waiting for POLLOUT events.
There is a reference taken on the "server" socket when the client
connects:
net/unix/af_unix.c::unix_dgram_connect()
other = unix_find_other(net, sunaddr, alen, sock->type,
hash, &err);
But that reference could be released when the client socket
disconnects from another thread in one of the 3 possible locations:
1. unix_dgram_connect() when connecting to a different socket
if (other != old_peer)
unix_dgram_disconnected(sk, old_peer);
sock_put(old_peer);
2. unix_dgram_sendmsg() when the server socket is SOCK_DEAD:
unix_dgram_disconnected(sk, other);
sock_put(other);
3. unix_release_sock() when the client socket is released:
skpair = unix_peer(sk);
if (skpair != NULL) {
sock_put(skpair); /* It may now die */
I tried to release all the references to server_sockfd with
close(server_sockfd) on the server thread and with
connect(client_sockfd) to a different socket while client_sockfd is
being polled for POLLOUT events in a different thread, hoping to crash
the poller with the stack:
free_poll_entry()->remove_wait_queue()->spin_lock_irqsave()
But I didn't manage to crash the kernel.
Am I missing something? Is there another reference taken on
server_sockfd to protect the kernel from this scenario?
And btw, what is the test (unix_peer(other) != sk) in unix_dgram_poll()?
Alban
^ permalink raw reply
* Re: [PATCH 1/2] via-velocity: set sleep speed to 10Mbps for powersaving.
From: David Miller @ 2010-12-08 20:56 UTC (permalink / raw)
To: davidlv.linux; +Cc: netdev, romieu, DavidLv, ShirleyHu, AndersMa
In-Reply-To: <AANLkTi==2E1VxbXatjEN7hORfPbxmiSTbD6SwqH5JGEu@mail.gmail.com>
From: David Lv <davidlv.linux@gmail.com>
Date: Wed, 8 Dec 2010 12:10:53 +0800
> I am sending this patch for setting speed to 10Mbps when entering into
> sleep mode.
> It is for power saving.
> Thanks!
>
> Signed-off-by: David Lv <DavidLv@viatech.com.cn>
> Acked-by: Francois Romieu <romieu@fr.zoreil.com>
...
> + velocity_set_int_opt((int *) &opts->sleep_speed_10m, sleep_speed_10M[index],
> + SLEEP_SPEED_DISABLE, SLEEP_SPEED_ENABLE, SLEEP_SPEED_DEF, "Sleep
> Speed Forced 10M", devname);
...
Same problem here, you email client corrupted the patch,
please fix this and resubmit.
Thanks.
^ permalink raw reply
* Re: [PATCH 2/2] via-velocity: fix the WOL bug on 1000M full duplex forced mode
From: David Miller @ 2010-12-08 20:56 UTC (permalink / raw)
To: davidlv.linux; +Cc: netdev, romieu, DavidLv, ShirleyHu, AndersMa
In-Reply-To: <AANLkTi=+r4cjE-3RJgrsrVaPBz0Ok_7XqZ+dxZgFCCUg@mail.gmail.com>
From: David Lv <davidlv.linux@gmail.com>
Date: Wed, 8 Dec 2010 13:47:19 +0800
> The VIA velocity card can't be waken up by WOL tool on 1000M full
> duplex forced mode.
> This patch fixes the bug.
> Thanks!
>
> Signed-off-by: David Lv <DavidLv@viatech.com.cn>
> Acked-by: Francois Romieu <romieu@fr.zoreil.com>
...
>
> - MII_REG_BITS_OFF(ADVERTISE_1000FULL | ADVERTISE_1000HALF,
> MII_CTRL1000, vptr->mac_regs);
Your email client has corrupted the patch by chopping up long lines
etc., please correct this and resubmit your patch.
^ permalink raw reply
* Re: IPsecv6 tunnel mode fragmentation
From: David Miller @ 2010-12-08 20:37 UTC (permalink / raw)
To: herbert; +Cc: latten, netdev, samudrala, rashmin
In-Reply-To: <20101208071109.GA14537@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Wed, 8 Dec 2010 15:11:09 +0800
> Joy Latten <latten@austin.ibm.com> wrote:
>>
>> We have come across an ipsec problem that I think was
>> noted a while back in the following link.
>> http://www.mail-archive.com/netdev@vger.kernel.org/msg61659.html
>
> Looks like a configuration issue to me. One end is using the
> same IP address (*::1234) both within and outside the tunnel.
> Thus when the ICMP error message is sent it ends up outside the
> tunnel causing it to be discarded by the other side.
>
> So if you're using tunnel mode you really should use distinct
> IP addresses.
Agreed.
^ permalink raw reply
* Re: [Bugme-new] [Bug 24472] New: Kernel panic - not syncing: Fatal Exception
From: Paweł Staszewski @ 2010-12-08 20:30 UTC (permalink / raw)
To: Andrew Morton
Cc: netdev, Paul Mackerras, bugzilla-daemon, bugme-daemon,
pstaszewski
In-Reply-To: <20101208122233.835a4997.akpm@linux-foundation.org>
W dniu 2010-12-08 21:22, Andrew Morton pisze:
> (switched to email. Please respond via emailed reply-to-all, not via the
> bugzilla web interface).
>
> On Wed, 8 Dec 2010 20:14:45 GMT
> bugzilla-daemon@bugzilla.kernel.org wrote:
>
>> https://bugzilla.kernel.org/show_bug.cgi?id=24472
>>
>> Summary: Kernel panic - not syncing: Fatal Exception
>> Product: Drivers
>> Version: 2.5
>> Kernel Version: 2.6.36.1
>> Platform: All
>> OS/Version: Linux
>> Tree: Mainline
>> Status: NEW
>> Severity: normal
>> Priority: P1
>> Component: Network
>> AssignedTo: drivers_network@kernel-bugs.osdl.org
>> ReportedBy: pstaszewski@artcom.pl
>> Regression: No
>>
>>
>> Created an attachment (id=39332)
>> --> (https://bugzilla.kernel.org/attachment.cgi?id=39332)
>> Kernel Panic
>>
>> Hello i have problems with ppp driver and pppoe
>> I have random kernel panics
>>
>> In attached image is Call Trace from panic.
>>
>>
> ppp_unregister_channel() appears to be using a bad pointer.
> --
Yes.
I see kernel panics when connection is terminated - but this happend
randomly
Sometimes to reproduce i need to connect->disconnect 50 - 60 times
before kernel panic.
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
^ permalink raw reply
* Re: [PATCH] tcp: protect sysctl_tcp_cookie_size reads
From: David Miller @ 2010-12-08 20:35 UTC (permalink / raw)
To: eric.dumazet; +Cc: Martin, netdev, bhutchings, william.allen.simpson
In-Reply-To: <1291760447.5324.31.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 07 Dec 2010 23:20:47 +0100
> Make sure sysctl_tcp_cookie_size is read once in
> tcp_cookie_size_check(), or we might return an illegal value to caller
> if sysctl_tcp_cookie_size is changed by another cpu.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH] tcp: avoid a possible divide by zero
From: David Miller @ 2010-12-08 20:35 UTC (permalink / raw)
To: eric.dumazet; +Cc: bhutchings, Martin, netdev
In-Reply-To: <1291759435.5324.25.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 07 Dec 2010 23:03:55 +0100
> [PATCH v2] tcp: avoid a possible divide by zero
>
> sysctl_tcp_tso_win_divisor might be set to zero while one cpu runs in
> tcp_tso_should_defer(). Make sure we dont allow a divide by zero by
> reading sysctl_tcp_tso_win_divisor exactly once.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH v2 0/3] bonding: add the debugfs interface to see RLB hash table
From: Jay Vosburgh @ 2010-12-08 20:33 UTC (permalink / raw)
To: Taku Izumi; +Cc: netdev@vger.kernel.org, eric.dumazet, shemminger
In-Reply-To: <4CF89A00.8030902@jp.fujitsu.com>
Taku Izumi <izumi.taku@jp.fujitsu.com> wrote:
>Hi Jay,
>
>Thank you for your quick review. I update my patchset according to your comment.
>But I didn't take measures against your concern about seq_file. If I come up with
>a good idea, I'll correct it.
>
>--
>This patchset provides the debugfs facility to the bonding driver and
>the interface to see RLB hashtable in it.
>
> *[PATCH 1/3] bonding: add the debugfs facility to the bonding driver
> *[PATCH 2/3] bonding: migrate some macros from bond_alb.c to bond_alb.h
> *[PATCH 3/3] bonding: add the debugfs interface to see RLB hash table
After applying your patches to net-next-2.6, I'm seeing the
following crash when executing "rmmod bonding":
BUG: unable to handle kernel paging request at 6b6b6b9f
IP: [<c0201f11>] debugfs_remove_recursive+0x1e/0x11a
*pde = 00000000
Oops: 0000 [#1] PREEMPT SMP
last sysfs file: /sys/devices/virtual/net/bond0/flags
Modules linked in: bonding(-) ipv6 mperf microcode loop tg3 e1000 libphy sworks_agp agpgart edd ext3 mbcache jbd pata_serverworks mptspi mptscsih mptbase [last unloaded: speedstep_lib]
Pid: 5237, comm: rmmod Not tainted 2.6.37-rc1-cur+ #11 /eserver xSeries 335 -[8676GBX]-
EIP: 0060:[<c0201f11>] EFLAGS: 00010202 CPU: 2
EIP is at debugfs_remove_recursive+0x1e/0x11a
EAX: 6b6b6b6b EBX: f4d99480 ECX: 00000000 EDX: f3d5a5d4
ESI: f4d99950 EDI: f2d445b8 EBP: f4d03eb8 ESP: f4d03ea8
DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068
Process rmmod (pid: 5237, ti=f4d02000 task=f3d5a240 task.ti=f4d02000)
Stack:
f4d03ec0 f4d99480 f4d99950 f4d99000 f4d03ec0 f801dc05 f4d03ef4 f8015c5b
c0156ab6 f4d03ed8 c0134ff0 f4d9949c f4d03ee4 c037ec67 f4d99150 f4d03ef4
f4d99000 f4d03f20 f4d99000 f4d03f08 c030eafe f4d03f20 c0ce4140 f80233a4
Call Trace:
[<f801dc05>] ? bond_debug_unregister+0xe/0x10 [bonding]
[<f8015c5b>] ? bond_uninit+0x324/0x36d [bonding]
[<c0156ab6>] ? trace_hardirqs_on+0xb/0xd
[<c0134ff0>] ? local_bh_enable_ip+0x97/0xae
[<c037ec67>] ? _raw_spin_unlock_bh+0x2f/0x32
[<c030eafe>] ? rollback_registered_many+0x187/0x1fb
[<c030eb81>] ? unregister_netdevice_many+0xf/0x4d
[<c0318890>] ? __rtnl_link_unregister+0x56/0x8a
[<c0318f45>] ? rtnl_link_unregister+0x19/0x21
[<f801e32d>] ? bonding_exit+0x30/0x3c [bonding]
[<c0162ddc>] ? sys_delete_module+0x184/0x1dc
[<c01555fe>] ? put_lock_stats+0xd/0x22
[<c0155708>] ? lock_release_holdtime+0xf5/0xfa
[<c01a8fa3>] ? sys_munmap+0x39/0x3f
[<c037f098>] ? restore_all_notrace+0x0/0x18
[<c010294c>] ? sysenter_do_call+0x12/0x32
Code: fc ff 89 d8 e8 27 77 fc ff 5b 5e 5d c3 55 89 e5 57 89 c7 56 53 83 ec 04 85 c0 0f 84 01 01 00 00 8b 40 40 85 c0 0f 84 f6 00 00 00 <83> 78 34 00 0f 84 ec 00 00 00 8b 47 34 31 d2 89 fe 05 a4 00 00
EIP: [<c0201f11>] debugfs_remove_recursive+0x1e/0x11a SS:ESP 0068:f4d03ea8
CR2: 000000006b6b6b9f
---[ end trace e274f539dfd6ed30 ]---
This happens regardless of activity; e.g., "insmod bonding
mode=balance-alb" followed immediately by "rmmod bonding" generates the
above.
Any thoughts?
-J
---
-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com
^ permalink raw reply
* Re: ctnetlink loop
From: Holger Eitzenberger @ 2010-12-08 20:31 UTC (permalink / raw)
To: David Miller; +Cc: pablo, netfilter-devel, netdev
In-Reply-To: <20101208.095020.245408999.davem@davemloft.net>
Hi,
> Holger, this replay -EAGAIN loop in nfnetlink processing was added by
> Pablo to handle module loading properly, I think. So it might not be
> safe to just unilaterally remove it.
thanks for your reply!
Pablo, do we really need the replay loop really? I now have several
boxes with problems due to this replay. 'perf report' always gives me
something like:
18.88% ulogd [kernel]
[k] __nla_put
10.73% ulogd [kernel]
[k] nla_parse
8.72% ulogd [kernel]
[k] __nla_reserve
6.64% ulogd [kernel]
[k] nla_put
5.14% ulogd [kernel]
[k] validate_nla
5.03% ulogd [kernel]
[k] pskb_expand_head
4.92% ulogd [kernel]
[k] ctnetlink_fill_info [nf_conntrack_netlink]
3.07% ulogd [kernel]
[k] skb_put
3.03% ulogd [kernel]
[k] ctnetlink_dump_counters [nf_conntrack
And 'strace' shows me that ulogd is stuck in its 'select' call.
/holger
^ permalink raw reply
* Re: [Bugme-new] [Bug 24472] New: Kernel panic - not syncing: Fatal Exception
From: Andrew Morton @ 2010-12-08 20:22 UTC (permalink / raw)
To: netdev, Paul Mackerras; +Cc: bugzilla-daemon, bugme-daemon, pstaszewski
In-Reply-To: <bug-24472-10286@https.bugzilla.kernel.org/>
(switched to email. Please respond via emailed reply-to-all, not via the
bugzilla web interface).
On Wed, 8 Dec 2010 20:14:45 GMT
bugzilla-daemon@bugzilla.kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=24472
>
> Summary: Kernel panic - not syncing: Fatal Exception
> Product: Drivers
> Version: 2.5
> Kernel Version: 2.6.36.1
> Platform: All
> OS/Version: Linux
> Tree: Mainline
> Status: NEW
> Severity: normal
> Priority: P1
> Component: Network
> AssignedTo: drivers_network@kernel-bugs.osdl.org
> ReportedBy: pstaszewski@artcom.pl
> Regression: No
>
>
> Created an attachment (id=39332)
> --> (https://bugzilla.kernel.org/attachment.cgi?id=39332)
> Kernel Panic
>
> Hello i have problems with ppp driver and pppoe
> I have random kernel panics
>
> In attached image is Call Trace from panic.
>
>
ppp_unregister_channel() appears to be using a bad pointer.
^ permalink raw reply
* Re: WARNING at local_bh_enable while tcp_retransmit
From: Jarek Poplawski @ 2010-12-08 20:20 UTC (permalink / raw)
To: Ilya Loginov; +Cc: netdev, davem
In-Reply-To: <20101208123645.84091844.isloginov@gmail.com>
Ilya Loginov wrote:
> On Tue, 07 Dec 2010 21:56:19 +0100
> Jarek Poplawski <jarkao2@gmail.com> wrote:
>
>> Hi, isn't any of your drivers disabling irqs on this path?
>
> No. But we are in soft_irq because tcp_retransmit. So, may be,
> interrupts were really disabled.
Should be easy to check by copying this WARN_ON_ONCE from
kernel/softirq.c:143 local_bh_enable to the beginning of
your rioth_start_xmit.
Jarek P.
^ permalink raw reply
* Re: [PATCH] ehea: Fixing LRO configuration
From: David Miller @ 2010-12-08 20:19 UTC (permalink / raw)
To: leitao; +Cc: bhutchings, shemminger, netdev
In-Reply-To: <1291834280-30787-1-git-send-email-leitao@linux.vnet.ibm.com>
From: leitao@linux.vnet.ibm.com
Date: Wed, 8 Dec 2010 16:51:20 -0200
> In order to set LRO on ehea, the user must set a module parameter, which
> is not the standard way to do so. This patch adds a way to set LRO using
> the ethtool tool.
>
> Signed-off-by: Breno Leitao <leitao@linux.vnet.ibm.com>
Applied, thanks Breno.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox