* Re: [PATCH NEXT 2/3] netxen: enable LRO based on NETIF_F_LRO
From: David Miller @ 2010-12-31 18:58 UTC (permalink / raw)
To: amit.salecha
Cc: netdev, ameen.rahman, anirban.chakraborty, sucheta.chakraborty
In-Reply-To: <1293439423-25193-3-git-send-email-amit.salecha@qlogic.com>
From: Amit Kumar Salecha <amit.salecha@qlogic.com>
Date: Mon, 27 Dec 2010 00:43:42 -0800
> + if (!!data) {
This form of the test is not only unnecessary, it's ugly. Please just
test plain "data".
> + dev->features &= ~NETIF_F_LRO;
> + netxen_send_lro_cleanup(adapter);
> + dev_info(&adapter->pdev->dev,
> + "disabling LRO as rx_csum is off\n");
You should use netdev_info() and fix the tabbing here.
> + if (!adapter->rx_csum) {
> + dev_info(&adapter->pdev->dev, "rx csum is off, "
> + "cannot toggle LRO\n");
> + return -EINVAL;
> + }
Please use netdev_info().
^ permalink raw reply
* Re: [PATCH NEXT 1/3] netxen: update module description
From: David Miller @ 2010-12-31 18:55 UTC (permalink / raw)
To: amit.salecha; +Cc: netdev, ameen.rahman, anirban.chakraborty
In-Reply-To: <1293439423-25193-2-git-send-email-amit.salecha@qlogic.com>
From: Amit Kumar Salecha <amit.salecha@qlogic.com>
Date: Mon, 27 Dec 2010 00:43:41 -0800
> This driver supports only Intelligent Ethernet Adapters.
>
> Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH v2 0/4] dcbnl: Extending dcbnl to support non-host DCBX
From: David Miller @ 2010-12-31 18:52 UTC (permalink / raw)
To: shmulikr; +Cc: eilong, john.r.fastabend, lucy.liu, netdev
In-Reply-To: <1293726402.29378.91.camel@lb-tlvb-shmulik.il.broadcom.com>
From: "Shmulik Ravid" <shmulikr@broadcom.com>
Date: Thu, 30 Dec 2010 18:26:42 +0200
> DCBX is the exchange protocol for negotiating DCB parameters between a
> host and a switch. In some circumstances the DCBX negotiator can not
> reside in the host directly on top of the networking interface. For
> instance many converged network adapters support an embedded DCBX engine
> that performs the negotiation and configures the device with the
> negotiated parameters. Another example is virtual hosts and SRIOV
> virtual functions.
>
> The following patches extend the dcbnl netlink interface so in addition
> to its current semantics it offers a standard mechanism for managing
> such non-host DCBX engines. In this new mode 'set' operations are used
> to set the initial negotiation configuration and the 'get' operation are
> used to retrieve the negotiated results.
All applied, thanks.
^ permalink raw reply
* Re: [net-next-2.6 PATCH v2 0/3] Series short description
From: David Miller @ 2010-12-31 18:49 UTC (permalink / raw)
To: john.r.fastabend; +Cc: netdev, lucy.liu, shmulikr
In-Reply-To: <20101230192449.21487.9764.stgit@jf-dev1-dcblab>
From: John Fastabend <john.r.fastabend@intel.com>
Date: Thu, 30 Dec 2010 11:25:40 -0800
> Version 2 adds the recommended tlv attributes to the ets struct this will
> be needed for offloaded LLDP engines. Host controlled LLDP agents will most
> likely not use these fields.
>
> Also Shmulik Ravid caught an error with a spin_lock on kmalloc failure.
BTW, even though I replied "applied" to v1 of these patches I made
sure to actully apply v2 :-)
^ permalink raw reply
* Re: [net-next-2.6 PATCH 2/3] dcbnl: add appliction tlv handlers
From: David Miller @ 2010-12-31 18:42 UTC (permalink / raw)
To: john.r.fastabend; +Cc: netdev, tgraf
In-Reply-To: <20101220205018.24232.994.stgit@jf-dev1-dcblab>
From: John Fastabend <john.r.fastabend@intel.com>
Date: Mon, 20 Dec 2010 12:50:18 -0800
> This patch adds application tlv handlers. Networking stacks
> may use the application priority to set the skb priority of
> their stack using the negoatiated dcbx priority.
>
> This patch provides the dcb_{get|set}app() routines for the
> stack to query these parameters. Notice lower layer drivers
> can use the dcbnl_ops routines if additional handling is
> needed. Perhaps in the firmware case for example
>
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 3/3] net_dcb: add application notifiers
From: David Miller @ 2010-12-31 18:42 UTC (permalink / raw)
To: john.r.fastabend; +Cc: netdev, tgraf
In-Reply-To: <20101220205023.24232.72153.stgit@jf-dev1-dcblab>
From: John Fastabend <john.r.fastabend@intel.com>
Date: Mon, 20 Dec 2010 12:50:24 -0800
> DCBx applications priorities can be changed dynamically. If
> application stacks are expected to keep the skb priority
> consistent with the dcbx priority the stack will need to
> be notified when these changes occur.
>
> This patch adds application notifiers for the stack to register
> with.
>
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 1/3] dcbnl: add support for ieee8021Qaz attributes
From: David Miller @ 2010-12-31 18:42 UTC (permalink / raw)
To: john.r.fastabend; +Cc: netdev, tgraf
In-Reply-To: <20101220205013.24232.3980.stgit@jf-dev1-dcblab>
From: John Fastabend <john.r.fastabend@intel.com>
Date: Mon, 20 Dec 2010 12:50:13 -0800
> The IEEE8021Qaz is the IEEE standard version of CEE. The
> standard has had enough significant changes from the CEE
> version that many of the CEE attributes have no meaning
> in the new spec or do not easily map to IEEE standards.
>
> Rather then attempt to create a complicated mapping
> between CEE and IEEE standards this patch adds a nested
> IEEE attribute to the list of DCB attributes. The policy
> is,
...
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Applied.
^ permalink raw reply
* Re: [PATCH] sky2: Do not use legacy PCI power management
From: Stephen Hemminger @ 2010-12-31 18:15 UTC (permalink / raw)
To: Rafael J. Wysocki, David Miller
Cc: netdev, Stephen Hemminger, Linux-pm mailing list
In-Reply-To: <201012261944.32517.rjw@sisk.pl>
On Sun, 26 Dec 2010 19:44:32 +0100
"Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> The sky2 driver uses the legacy PCI power management, so it has to do
> some PCI-specific things in its ->suspend() and ->resume() callbacks,
> which isn't necessary and should better be done by the PCI
> sybsystem-level power management code. Moreover, it uses
> device_set_wakeup_enable() incorrectly (that function should be
> used when the WoL setting is changed rather than during suspend).
>
> Convert sky2 to the new PCI power management framework and make it
> let the PCI subsystem take care of all the PCI-specific aspects of
> device handling during system power transitions.
>
> Tested on a desktop machine with a Marvell 88E8056 PCI-E adapter.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Tested on 88E8055 (laptop), my desktop machines have video issues and
won't suspend/resume.
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
^ permalink raw reply
* Re: Sky2 - problems with VLANs - kernel 2.6.36
From: Stephen Hemminger @ 2010-12-31 18:13 UTC (permalink / raw)
To: David; +Cc: netdev, Linux Kernel Mailing List
In-Reply-To: <4CD48DE6.7060906@unsolicited.net>
On Fri, 05 Nov 2010 23:06:14 +0000
David <david@unsolicited.net> wrote:
> I've just installed a Lycom dual port gigabit ethernet card, picked up
> as follows :-
>
> 03:00.0 Ethernet controller: Marvell Technology Group Ltd. 88E8062 PCI-E
> IPMI Gigabit Ethernet Controller (rev 14)
> Subsystem: Marvell Technology Group Ltd. Device 6222
> Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
> Stepping- SERR+ FastB2B- DisINTx+
> Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
> <TAbort- <MAbort- >SERR- <PERR- INTx-
> Latency: 0, Cache Line Size: 64 bytes
> Interrupt: pin A routed to IRQ 41
> Region 0: Memory at fe8fc000 (64-bit, non-prefetchable) [size=16K]
> Region 2: I/O ports at c800 [size=256]
> Expansion ROM at fe8c0000 [disabled] [size=128K]
> Capabilities: <access denied>
> Kernel driver in use: sky2
> Kernel modules: sky2
>
> I'm having a problem with VLANs. Outgoing packets are tagged correctly
> and devices on the VLAN are responding. Unfortunately all of the
> response packets stay on the raw device and are not allocated to the VLAN.
>
> I've done some investigation (printks etc.), and have found that neither
> of the following cases in sky2_status_intr() are being triggered...
>
> case OP_RXVLAN:
> printk("RXVLAN, length=%u, status=%u\n", length,
> status);
> sky2->rx_tag = length;
> break;
>
> case OP_RXCHKSVLAN:
> printk("RXCHKSVLAN, length=%u, status=%u\n",
> length, status);
> sky2->rx_tag = length;
> /* fall through */
>
> ... however the status when calling sky2_skb_rx() does have GMR_FS_VLAN
> set, it's just we haven't been able to find out which VLAN the packet
> comes from (and sky2->rx_tag is zero). Does anyone have any suggestions
> as to how I proceed from here? I'm happy to test patches etc.
Did it work with older kernels?
^ permalink raw reply
* Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
From: Justin P. Mattock @ 2010-12-31 17:59 UTC (permalink / raw)
To: Dan Carpenter, Grant Likely, trivial-DgEjT+Ai2ygdnm+yROfE0A,
devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b,
linux-scsi-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA,
li
In-Reply-To: <20101231174100.GF1886@bicker>
On 12/31/2010 09:41 AM, Dan Carpenter wrote:
> On Fri, Dec 31, 2010 at 06:17:58AM -0800, Justin P. Mattock wrote:
>>> Wrong: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
>>>
>>> Right: [PATCH 02/15] spi/dw_spi: Typo change diable to disable
>>>
>>> regards,
>>> dan carpenter
>>>
>>
>> alright.. so having the backlash is alright for the subject
>
> Well really my point is not so much about backslashes vs colons, it's
> about getting the *one* correct prefix. This stuff is probably
> scriptable most of the time, but you may still be required to think a
> little on the corner cases.
>
> Here is a script to get you started.
>
> git log --format="%s" drivers/spi/dw_spi.c | \
> head -n 20 | \
> perl -ne 's/(.*):.*/$1/; print' | \
> sort | uniq -c | sort -rn | \
> perl -ne 's/^\W+\d+ //; print' | \
> head -n 1
>
> regards,
> dan carpenter
>
thats a nice little script there(just ran it) any way you want to add
this into to getmaintainers.pl or something? (this way people get the
maintainers address plus a subject line in the mix)
Justin P. Mattock
------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and,
should the need arise, upgrade to a full multi-node Oracle RAC database
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
^ permalink raw reply
* Re: [PATCH] UDPCP Communication Protocol
From: Stephen Hemminger @ 2010-12-31 17:46 UTC (permalink / raw)
To: stefani; +Cc: linux-kernel, akpm, davem, netdev
In-Reply-To: <1293787785-3834-1-git-send-email-stefani@seibold.net>
On Fri, 31 Dec 2010 10:29:45 +0100
stefani@seibold.net wrote:
> +/*
> + * UDPCP destination descriptor
> + *
> + * For each communication address an individual destination descriptor will
> + * be create.
> + *
> + * The fields has the following meanings:
> + *
> + * list: link list: part of udpcp_sock.destlist
> + * xmit: messages fragments to be transmit
> + * tx_time: timestamp of the last transmitted message fragment
> + * rx_time: timestamp ot the last received message fragment
> + * txTimeout: statistic use only: number of transmit timeout
> + * rxTimeout: statistic use only: number of receive timeout
> + * txRetries: statistic use only: number of transmit retries
> + * rxDiscardedFrags: statistic use only: number of discarded messages
> + * xmit_wait: message fragment which is waiting for an ACK
> + * xmit_last: last fragment transmitted
> + * recv_msg: first fragment of the received message
> + * recv_last: last fragment of the received message
> + * lastmsg: last messages fragment header received
> + * ipc: linux internal ipc cookie
> + * fl: flow/routing information
> + * rt: routing entry currently used for this destination
> + * addr: ipv4 destination address
> + * port: destination port number
> + * msgid: current message id for outgoing data messages
> + * use_flag: statistic use only: flag for dest using TX and/or RX
> + * insync: flag for protocol synchronization
> + * ackmode; ack mode for the current assembled message
> + * chkmode; checksum mode for the current assembled message
> + * try: current number of retries xmit_wait message
> + * acks: number of outstandig ack's
> + */
Why not use docbook format comments for this?
^ permalink raw reply
* Re: [PATCH] UDPCP Communication Protocol
From: Stephen Hemminger @ 2010-12-31 17:46 UTC (permalink / raw)
To: stefani; +Cc: linux-kernel, akpm, davem, netdev
In-Reply-To: <1293787785-3834-1-git-send-email-stefani@seibold.net>
On Fri, 31 Dec 2010 10:29:45 +0100
stefani@seibold.net wrote:
> +struct __attribute__ ((packed)) udpcphdr {
> + struct udphdr udphdr;
> + __be32 chksum;
> + __be16 msginfo;
> + u8 fragamount;
> + u8 fragnum;
> + __be16 msgid;
> + __be16 length;
> +};
Adding (unnecessary) packed attribute will make access slow on
some architectures. For arch that can't do unaligned access, the
compiler ends up doing byte access for each element.
^ permalink raw reply
* Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
From: Dan Carpenter @ 2010-12-31 17:41 UTC (permalink / raw)
To: Justin P. Mattock
Cc: Grant Likely, trivial, devel, linux-scsi, netdev, linux-usb,
linux-wireless, linux-kernel, ivtv-devel, linux-m68k,
spi-devel-general, linux-media
In-Reply-To: <4D1DE616.7010105@gmail.com>
On Fri, Dec 31, 2010 at 06:17:58AM -0800, Justin P. Mattock wrote:
> >Wrong: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
> >
> >Right: [PATCH 02/15] spi/dw_spi: Typo change diable to disable
> >
> >regards,
> >dan carpenter
> >
>
> alright.. so having the backlash is alright for the subject
Well really my point is not so much about backslashes vs colons, it's
about getting the *one* correct prefix. This stuff is probably
scriptable most of the time, but you may still be required to think a
little on the corner cases.
Here is a script to get you started.
git log --format="%s" drivers/spi/dw_spi.c | \
head -n 20 | \
perl -ne 's/(.*):.*/$1/; print' | \
sort | uniq -c | sort -rn | \
perl -ne 's/^\W+\d+ //; print' | \
head -n 1
regards,
dan carpenter
^ permalink raw reply
* [PATCH 3/7] net/atl1c/atl1c.h Typo change desciptor to descriptor.
From: Justin P. Mattock @ 2010-12-31 17:39 UTC (permalink / raw)
To: trivial; +Cc: netdev, linux-kernel, Justin P. Mattock
Below is a patch, that changes a typo from "desciptor" to "descriptor".
Let me know if I missed anything.
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
---
drivers/net/atl1c/atl1c.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/atl1c/atl1c.h b/drivers/net/atl1c/atl1c.h
index 9ab5809..7cb375e 100644
--- a/drivers/net/atl1c/atl1c.h
+++ b/drivers/net/atl1c/atl1c.h
@@ -265,7 +265,7 @@ struct atl1c_recv_ret_status {
__le32 word3;
};
-/* RFD desciptor */
+/* RFD descriptor */
struct atl1c_rx_free_desc {
__le64 buffer_addr;
};
@@ -531,7 +531,7 @@ struct atl1c_rfd_ring {
struct atl1c_buffer *buffer_info;
};
-/* receive return desciptor (rrd) ring */
+/* receive return descriptor (rrd) ring */
struct atl1c_rrd_ring {
void *desc; /* descriptor ring virtual address */
dma_addr_t dma; /* descriptor ring physical address */
--
1.6.5.2.180.gc5b3e
^ permalink raw reply related
* [PATCH 2/7] net/sungem.h Typo change desciptor to descriptor.
From: Justin P. Mattock @ 2010-12-31 17:38 UTC (permalink / raw)
To: trivial; +Cc: netdev, linux-kernel, Justin P. Mattock
Below is a patch, that changes a typo from "desciptor" to "descriptor".
Let me know if I missed anything.
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
---
drivers/net/sungem.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/sungem.h b/drivers/net/sungem.h
index 1990546..bfb6683 100644
--- a/drivers/net/sungem.h
+++ b/drivers/net/sungem.h
@@ -843,7 +843,7 @@ struct gem_txd {
/* GEM requires that RX descriptors are provided four at a time,
* aligned. Also, the RX ring may not wrap around. This means that
- * there will be at least 4 unused desciptor entries in the middle
+ * there will be at least 4 unused descriptor entries in the middle
* of the RX ring at all times.
*
* Similar to HME, GEM assumes that it can write garbage bytes before
--
1.6.5.2.180.gc5b3e
^ permalink raw reply related
* Re: [PATCH v2 00/12] make rpc_pipefs be mountable multiple time
From: Trond Myklebust @ 2010-12-31 16:54 UTC (permalink / raw)
To: Rob Landley
Cc: Kirill A. Shutemov, Rob Landley, J. Bruce Fields, Neil Brown,
Pavel Emelyanov, linux-nfs-u79uwXL29TY76Z2rM5mHXA,
David S. Miller, netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <4D1C5953.6020200-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
On Thu, 2010-12-30 at 04:05 -0600, Rob Landley wrote:
> On 12/30/2010 03:44 AM, Kirill A. Shutemov wrote:
> >>> If no rpcmount mountoption, no rpc_pipefs was found at
> >>> '/var/lib/nfs/rpc_pipefs' and we are in init's mount namespace, we use
> >>> init_rpc_pipefs.
> >>
> >> It's the "we are in init's mount namespace" that I was wondering about.
> >>
> >> So if I naievely chroot, nfs mount stops working the way it did before I
> >> chrooted unless I do an extra setup step?
> >
> > No. It will work as before since you are still in init's mount namespace.
> > Creating new mount namespace changes rules.
>
> Ah, CLONE_NEWNS and then you need /var/lib/nfs/rpc_pipefs. Got it.
>
> I'm kind of surprised that the kernel cares about a specific path under
> /var/lib. (Seems like policy in the kernel somehow.) Can't it just
> check the current process's mount list to see if an instance of
> rpc_pipefs is mounted in the current namespace the way lxc looks for
> cgroups? Or are there potential performance/scalability issues with that?
The kernel doesn't give a damn about the /var/lib/nfs/rpc_pipefs bit.
That's all for the benefit of the userland utilities.
Trond
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org
www.netapp.com
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [*v3 PATCH 01/22] IPVS: netns, add basic init per netns.
From: Hans Schillstrom @ 2010-12-31 15:36 UTC (permalink / raw)
To: Jan Engelhardt
Cc: horms, ja, daniel.lezcano, wensong, lvs-devel, netdev,
netfilter-devel, Hans Schillstrom
In-Reply-To: <alpine.LNX.2.01.1012310055050.15397@obet.zrqbmnf.qr>
On Friday, December 31, 2010 00:58:35 Jan Engelhardt wrote:
>
> On Thursday 2010-12-30 11:50, hans@schillstrom.com wrote:
> >+++ b/include/net/ip_vs.h
> >@@ -28,6 +28,15 @@
> > #if defined(CONFIG_NF_CONNTRACK) || defined(CONFIG_NF_CONNTRACK_MODULE)
> > #include <net/netfilter/nf_conntrack.h>
> > #endif
> >+#include <net/net_namespace.h> /* Netw namespace */
> >+
> >+/*
> >+ * Generic access of ipvs struct
> >+ */
> >+static inline struct netns_ipvs * net_ipvs(struct net* net)
>
> Balancing the '*' between the ' ' would be nice... I know it's hard at this
> time of the year ;-)
>
I'll send a new patch set and run checkpatch,
but that will be after new years eve :-)
> >diff --git a/include/net/netns/ip_vs.h b/include/net/netns/ip_vs.h
> >new file mode 100644
> >index 0000000..9068d95
> >--- /dev/null
> >+++ b/include/net/netns/ip_vs.h
> >@@ -0,0 +1,26 @@
> >+/*
> >+ * ip_vs.h
> >+ *
> >+ * Created on: Nov 23, 2010
> >+ * Author: hans
> >+ */
>
> Filenames, creation dates, author names (when they don't serve a copyright
> notice), CVS $Id$ tags, etc. don't belong into files. The git log exists for
> that very purpose.
>
Oops that's an eclipse feature, that should be removed.
> >+struct netns_ipvs {
> >+ int inc; /* Incarnation */
> >+};
>
> Just my thoughts: Incarnation - haven't heard that in a while. ("inc"
> is also used as an abbreviation for increment, so ~ ~). Other places
> use "generation" as a term (such as the VFS on inode generation). [I
> also get the feeling that (re)"incarnation" may require a death, so
> it is different from "generation" after all -]
:-))
>
> >+++ b/net/netfilter/ipvs/ip_vs_core.c
> >@@ -1813,6 +1820,44 @@ static struct nf_hook_ops ip_vs_ops[] __read_mostly = {
> > #endif
> > };
> >
> >+/*
> >+ * Initialize IP Virtual Server netns mem.
> >+ */
> >+static int __net_init __ip_vs_init(struct net *net)
> >+{
> >+ struct netns_ipvs *ipvs;
> >+
> >+ if (!net_eq(net, &init_net)) {
> >+ pr_err("The final patch for enabling netns is missing\n");
> >+ return -EPERM;
> >+ }
> >+ ipvs = (struct netns_ipvs *)net_generic(net, ip_vs_net_id);
>
> Pointless cast is pointless.
Well, that is a reminder from a backport...
>
> >index c1c167a..ea390f8 100644
> >--- a/net/netfilter/ipvs/ip_vs_sync.c
> >+++ b/net/netfilter/ipvs/ip_vs_sync.c
> >@@ -1639,3 +1639,31 @@ int stop_sync_thread(int state)
> >
> > return 0;
> > }
> >+
> >+/*
> >+ * Initialize data struct for each netns
> >+ */
> >+static int __net_init __ip_vs_sync_init(struct net *net)
> >+{
> >+ return 0;
> >+}
> >+
> >+static void __ip_vs_sync_cleanup(struct net *net)
> >+{
> >+ return;
> >+}
>
> The trailing return; in functions returning nothing can be (and
> generally, is) omitted.
>
Oops
Thanks alot
/Hans
^ permalink raw reply
* Re: [PATCH 07/15]drivers:net:wireless:iwlwifi Typo change diable to disable.
From: Larry Finger @ 2010-12-31 15:33 UTC (permalink / raw)
To: Justin P. Mattock
Cc: trivial, linux-m68k, linux-kernel, netdev, ivtv-devel,
linux-media, linux-wireless, linux-scsi, spi-devel-general, devel,
linux-usb
In-Reply-To: <1293750484-1161-7-git-send-email-justinmattock@gmail.com>
On 12/30/2010 05:07 PM, Justin P. Mattock wrote:
> The below patch fixes a typo "diable" to "disable". Please let me know if this
> is correct or not.
>
> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
>
ACKed-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
> drivers/net/wireless/iwlwifi/iwl-agn-ict.c | 2 +-
> drivers/net/wireless/iwlwifi/iwl-agn.c | 4 ++--
> drivers/net/wireless/iwlwifi/iwl-core.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-ict.c b/drivers/net/wireless/iwlwifi/iwl-agn-ict.c
> index a5dbfea..b5cb3be 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-agn-ict.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-agn-ict.c
> @@ -197,7 +197,7 @@ static irqreturn_t iwl_isr(int irq, void *data)
>
> none:
> /* re-enable interrupts here since we don't have anything to service. */
> - /* only Re-enable if diabled by irq and no schedules tasklet. */
> + /* only Re-enable if disabled by irq and no schedules tasklet. */
> if (test_bit(STATUS_INT_ENABLED, &priv->status) && !priv->_agn.inta)
> iwl_enable_interrupts(priv);
>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.c b/drivers/net/wireless/iwlwifi/iwl-agn.c
> index c2636a7..9b912c0 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-agn.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-agn.c
> @@ -1316,7 +1316,7 @@ static void iwl_irq_tasklet_legacy(struct iwl_priv *priv)
> }
>
> /* Re-enable all interrupts */
> - /* only Re-enable if diabled by irq */
> + /* only Re-enable if disabled by irq */
> if (test_bit(STATUS_INT_ENABLED, &priv->status))
> iwl_enable_interrupts(priv);
>
> @@ -1530,7 +1530,7 @@ static void iwl_irq_tasklet(struct iwl_priv *priv)
> }
>
> /* Re-enable all interrupts */
> - /* only Re-enable if diabled by irq */
> + /* only Re-enable if disabled by irq */
> if (test_bit(STATUS_INT_ENABLED, &priv->status))
> iwl_enable_interrupts(priv);
> }
> diff --git a/drivers/net/wireless/iwlwifi/iwl-core.c b/drivers/net/wireless/iwlwifi/iwl-core.c
> index 25fb391..8700ab3 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-core.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-core.c
> @@ -1304,7 +1304,7 @@ irqreturn_t iwl_isr_legacy(int irq, void *data)
>
> none:
> /* re-enable interrupts here since we don't have anything to service. */
> - /* only Re-enable if diabled by irq */
> + /* only Re-enable if disabled by irq */
> if (test_bit(STATUS_INT_ENABLED, &priv->status))
> iwl_enable_interrupts(priv);
> spin_unlock_irqrestore(&priv->lock, flags);
^ permalink raw reply
* Re: [PATCH 03/15]drivers:staging:rtl8187se:r8180_hw.h Typo change diable to disable.
From: Larry Finger @ 2010-12-31 15:32 UTC (permalink / raw)
To: Justin P. Mattock
Cc: trivial, linux-m68k, linux-kernel, netdev, ivtv-devel,
linux-media, linux-wireless, linux-scsi, spi-devel-general, devel,
linux-usb
In-Reply-To: <1293750484-1161-3-git-send-email-justinmattock@gmail.com>
On 12/30/2010 05:07 PM, Justin P. Mattock wrote:
> The below patch fixes a typo "diable" to "disable". Please let me know if this
> is correct or not.
>
> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
>
> ---
ACKed-by: Larry Finger <Larry.Finger@lwfinger.net>
> drivers/staging/rtl8187se/r8180_hw.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/rtl8187se/r8180_hw.h b/drivers/staging/rtl8187se/r8180_hw.h
> index 3fca144..2911d40 100644
> --- a/drivers/staging/rtl8187se/r8180_hw.h
> +++ b/drivers/staging/rtl8187se/r8180_hw.h
> @@ -554,7 +554,7 @@
> /* by amy for power save */
> /* by amy for antenna */
> #define EEPROM_SW_REVD_OFFSET 0x3f
> -/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are diable. */
> +/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are disabled. */
> #define EEPROM_SW_AD_MASK 0x0300
> #define EEPROM_SW_AD_ENABLE 0x0100
>
^ permalink raw reply
* Re: [PATCH] net: eepro testing positive EBUSY return by request_irq()?
From: Ben Hutchings @ 2010-12-31 15:27 UTC (permalink / raw)
To: roel kluin; +Cc: davem, netdev, Andrew Morton, LKML
In-Reply-To: <4D1DECFC.8020701@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1400 bytes --]
On Fri, 2010-12-31 at 15:47 +0100, roel kluin wrote:
> Fix -EBUSY test for request_irq().
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> drivers/net/eepro.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> I just found this in the code, no bug was observed. Is this patch needed? the test
> for an -EBUSY return by request_irq() occurs much more frequently in kernel code.
>
> diff --git a/drivers/net/eepro.c b/drivers/net/eepro.c
> index 7c82631..47cfecb 100644
> --- a/drivers/net/eepro.c
> +++ b/drivers/net/eepro.c
> @@ -920,7 +920,7 @@ static int eepro_grab_irq(struct net_device *dev)
>
> eepro_sw2bank0(ioaddr); /* Switch back to Bank 0 */
>
> - if (request_irq (*irqp, NULL, IRQF_SHARED, "bogus", dev) != EBUSY) {
> + if (request_irq (*irqp, NULL, IRQF_SHARED, "bogus", dev) != -EBUSY) {
> unsigned long irq_mask;
> /* Twinkle the interrupt, and check if it's seen */
> irq_mask = probe_irq_on();
This condition is completely bogus - request_irq() with a NULL handler
now returns -EINVAL before even checking whether the IRQ is in use. The
code should be fixed along the lines of what I did for 3c503 in commit
b0cf4dfb7cd21556efd9a6a67edcba0840b4d98d.
The e2100 and hp net drivers have the same bug.
Ben.
--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply
* Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
From: James Bottomley @ 2010-12-31 15:06 UTC (permalink / raw)
To: Justin P. Mattock
Cc: Dan Carpenter, Grant Likely, trivial-DgEjT+Ai2ygdnm+yROfE0A,
devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b,
linux-scsi-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-wireless-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
ivtv-devel-jGorlIydJmRM656bX5wj8A,
linux-m68k-cunTk1MwBs8S/qaLPR03pWD2FQJk+8+b,
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
linux-media-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <4D1DE616.7010105-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Fri, 2010-12-31 at 06:17 -0800, Justin P. Mattock wrote:
> On 12/31/2010 01:11 AM, Dan Carpenter wrote:
> > On Thu, Dec 30, 2010 at 10:52:30PM -0800, Justin P. Mattock wrote:
> >> On 12/30/2010 10:45 PM, Grant Likely wrote:
> >>> On Thu, Dec 30, 2010 at 03:07:51PM -0800, Justin P. Mattock wrote:
> >>>> The below patch fixes a typo "diable" to "disable". Please let me know if this
> >>>> is correct or not.
> >>>>
> >>>> Signed-off-by: Justin P. Mattock<justinmattock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >>>
> >>> applied, thanks.
> >>>
> >>> g.
> >>
> >> ahh.. thanks.. just cleared up the left out diabled that I had
> >> thought I forgotten(ended up separating comments and code and
> >> forgot)
> >
> > This is really just defensiveness and random grumbling and grumpiness on
> > my part, but one reason I may have missed the first patch is because
> > your subject lines are crap.
> >
> > Wrong: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
> >
> > Right: [PATCH 02/15] spi/dw_spi: Typo change diable to disable
> >
> > regards,
> > dan carpenter
> >
>
> alright.. so having the backlash is alright for the subject
>
> Thanks for the pointer on this..
There is actually no specific form. Most of us edit this part of the
subject line anyway to conform to whatever (nonuniform) conventions we
use. I just use <component>: with no scsi or drivers prefix because the
git tree is tagged [SCSI]; others are different.
James
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* [PATCH] net: eepro testing positive EBUSY return by request_irq()?
From: roel kluin @ 2010-12-31 14:47 UTC (permalink / raw)
To: davem, netdev, Andrew Morton, LKML
Fix -EBUSY test for request_irq().
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
drivers/net/eepro.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
I just found this in the code, no bug was observed. Is this patch needed? the test
for an -EBUSY return by request_irq() occurs much more frequently in kernel code.
diff --git a/drivers/net/eepro.c b/drivers/net/eepro.c
index 7c82631..47cfecb 100644
--- a/drivers/net/eepro.c
+++ b/drivers/net/eepro.c
@@ -920,7 +920,7 @@ static int eepro_grab_irq(struct net_device *dev)
eepro_sw2bank0(ioaddr); /* Switch back to Bank 0 */
- if (request_irq (*irqp, NULL, IRQF_SHARED, "bogus", dev) != EBUSY) {
+ if (request_irq (*irqp, NULL, IRQF_SHARED, "bogus", dev) != -EBUSY) {
unsigned long irq_mask;
/* Twinkle the interrupt, and check if it's seen */
irq_mask = probe_irq_on();
^ permalink raw reply related
* Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
From: Justin P. Mattock @ 2010-12-31 14:17 UTC (permalink / raw)
To: Dan Carpenter, Grant Likely, trivial, devel, linux-scsi, netdev,
li
In-Reply-To: <20101231091136.GC1886@bicker>
On 12/31/2010 01:11 AM, Dan Carpenter wrote:
> On Thu, Dec 30, 2010 at 10:52:30PM -0800, Justin P. Mattock wrote:
>> On 12/30/2010 10:45 PM, Grant Likely wrote:
>>> On Thu, Dec 30, 2010 at 03:07:51PM -0800, Justin P. Mattock wrote:
>>>> The below patch fixes a typo "diable" to "disable". Please let me know if this
>>>> is correct or not.
>>>>
>>>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>>>
>>> applied, thanks.
>>>
>>> g.
>>
>> ahh.. thanks.. just cleared up the left out diabled that I had
>> thought I forgotten(ended up separating comments and code and
>> forgot)
>
> This is really just defensiveness and random grumbling and grumpiness on
> my part, but one reason I may have missed the first patch is because
> your subject lines are crap.
>
> Wrong: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
>
> Right: [PATCH 02/15] spi/dw_spi: Typo change diable to disable
>
> regards,
> dan carpenter
>
alright.. so having the backlash is alright for the subject
Thanks for the pointer on this..
Justin P. Mattock
^ permalink raw reply
* Re: [PATCH 14/15]include:media:davinci:vpss.h Typo change diable to disable.
From: Justin P. Mattock @ 2010-12-31 14:15 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: trivial, linux-m68k, linux-kernel, netdev, ivtv-devel,
linux-media, linux-wireless, linux-scsi, spi-devel-general, devel,
linux-usb
In-Reply-To: <4D1DAFF5.3090108@gmail.com>
On 12/31/2010 02:27 AM, Mauro Carvalho Chehab wrote:
> Em 30-12-2010 21:08, Justin P. Mattock escreveu:
>> The below patch fixes a typo "diable" to "disable". Please let me know if this
>> is correct or not.
>>
>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
> Acked-by: Mauro Carvalho Chehab<mchehab@redhat.com>
>
> PS.: Next time, please c/c linux-media ONLY on patches related to media
> drivers (/drivers/video and the corresponding include files). Having to
> dig into a series of 15 patches to just actually look on 3 patches
> is not nice.
>
alright...
>>
>> ---
>> include/media/davinci/vpss.h | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/include/media/davinci/vpss.h b/include/media/davinci/vpss.h
>> index c59cc02..b586495 100644
>> --- a/include/media/davinci/vpss.h
>> +++ b/include/media/davinci/vpss.h
>> @@ -44,7 +44,7 @@ struct vpss_pg_frame_size {
>> short pplen;
>> };
>>
>> -/* Used for enable/diable VPSS Clock */
>> +/* Used for enable/disable VPSS Clock */
>> enum vpss_clock_sel {
>> /* DM355/DM365 */
>> VPSS_CCDC_CLOCK,
>
>
Justin P. Mattock
^ permalink raw reply
* Re: [PATCH v2 00/12] make rpc_pipefs be mountable multiple time
From: Kirill A. Shutemov @ 2010-12-31 13:03 UTC (permalink / raw)
To: Rob Landley
Cc: Kirill A. Shutemov, Rob Landley, Trond Myklebust, J. Bruce Fields,
Neil Brown, Pavel Emelyanov, linux-nfs, David S. Miller, netdev,
linux-kernel
In-Reply-To: <4D1C809B.30405@parallels.com>
[-- Attachment #1: Type: text/plain, Size: 3227 bytes --]
On Thu, Dec 30, 2010 at 06:52:43AM -0600, Rob Landley wrote:
> On 12/30/2010 05:45 AM, Kirill A. Shutemov wrote:
> > Currently, there is no association between rpc_pipefs and mount namespace,
>
> There is in that the root context doesn't need to have this mounted, and
> new namespaces do. So there's an existing association between a LACK of
> a namespace and a different default behavior.
>
> My understanding (correct me if I'm wrong) is that the historical
> behavior is that there's only one, and it doesn't actually live anywhere
> in the filesystem tree. You're adding a special location. I'm
> wondering if there's any way for that location not to be special.
/var/lib/net/rpc_pipefs is default path where userspace part of NFS stack
(gssd, idmapd) want to see rpc_pipefs
> > so I don't see simple way to restrict number of rpc_pipefs per mount
> > namespace. Associating mount namespace with rpc_pipefs is not a good idea,
> > I think.
>
> I'm talking about associating a default rpc_pipefs instance with a
> namespace, which it seems to me you're already doing by emulating the
> legacy behavior. Before you CLONE_NEWNS you get a magic default mount
> that doesn't exist in the tree. After you CLONE_NEWNS you get something
> like -EINVAL unless you supply your own default.
Root namespace is special. In case of nfsroot you need rpc_pipefs before
root available.
> (I'm actually not sure
> why new namespaces don't fall back to the magic global one...)
It breaks isolation. Container should not use host's rpc_pipefs without
host's permission.
> I'm suggesting that if the user doesn't specify -o rpcmount then the
> default could be the first rpc_pipefs mount visible to the current
> process context, rather than a specific path. Logic to do that exists
> in the proc/self/mounts code (which I'm reading through now...).
static int check_rpc_pipefs(struct vfsmount *mnt, void *arg)
{
struct vfsmount **rpcmount = arg;
struct path path = {
.mnt = mnt,
.dentry = mnt->mnt_root,
};
if (!mnt->mnt_sb)
return 0;
if (mnt->mnt_sb->s_magic != RPCAUTH_GSSMAGIC)
return 0;
if (!path_is_under(&path, ¤t->fs->root))
return 0;
*rpcmount = mntget(mnt);
return 1;
}
struct vfsmount *get_rpc_pipefs(const char *p)
{
int error;
struct vfsmount *rpcmount = ERR_PTR(-EINVAL);
struct path path;
if (!p) {
iterate_mounts(check_rpc_pipefs, &rpcmount,
current->nsproxy->mnt_ns->root);
if (IS_ERR(rpcmount) && (current->nsproxy->mnt_ns ==
init_task.nsproxy->mnt_ns))
return mntget(init_rpc_pipefs);
return rpcmount;
}
error = kern_path(p, LOOKUP_FOLLOW | LOOKUP_DIRECTORY, &path);
if (error)
return ERR_PTR(error);
check_rpc_pipefs(path.mnt, &rpcmount);
path_put(&path);
return rpcmount;
}
EXPORT_SYMBOL_GPL(get_rpc_pipefs);
Something like this? Patch to replace patch #10 attached.
--
Kirill A. Shutemov
[-- Attachment #2: sunrpc-introduce-get_rpc_pipefs.patch --]
[-- Type: text/plain, Size: 2466 bytes --]
>From 36bdb502360461a8426821a37728aef3a3b8c738 Mon Sep 17 00:00:00 2001
From: Kirill A. Shutemov <kas@openvz.org>
Date: Mon, 20 Dec 2010 04:03:52 +0200
Subject: [PATCH] sunrpc: introduce get_rpc_pipefs()
Get rpc_pipefs mount point by path.
Signed-off-by: Kirill A. Shutemov <kas@openvz.org>
---
include/linux/sunrpc/rpc_pipe_fs.h | 2 +
net/sunrpc/rpc_pipe.c | 51 ++++++++++++++++++++++++++++++++++++
2 files changed, 53 insertions(+), 0 deletions(-)
diff --git a/include/linux/sunrpc/rpc_pipe_fs.h b/include/linux/sunrpc/rpc_pipe_fs.h
index b09bfa5..922057c 100644
--- a/include/linux/sunrpc/rpc_pipe_fs.h
+++ b/include/linux/sunrpc/rpc_pipe_fs.h
@@ -46,6 +46,8 @@ RPC_I(struct inode *inode)
extern struct vfsmount *init_rpc_pipefs;
+struct vfsmount *get_rpc_pipefs(const char *path);
+
extern int rpc_queue_upcall(struct inode *, struct rpc_pipe_msg *);
struct rpc_clnt;
diff --git a/net/sunrpc/rpc_pipe.c b/net/sunrpc/rpc_pipe.c
index b1e299b..4e09a90 100644
--- a/net/sunrpc/rpc_pipe.c
+++ b/net/sunrpc/rpc_pipe.c
@@ -16,6 +16,9 @@
#include <linux/namei.h>
#include <linux/fsnotify.h>
#include <linux/kernel.h>
+#include <linux/nsproxy.h>
+#include <linux/mnt_namespace.h>
+#include <linux/fs_struct.h>
#include <asm/ioctls.h>
#include <linux/fs.h>
@@ -931,6 +934,54 @@ static const struct super_operations s_ops = {
#define RPCAUTH_GSSMAGIC 0x67596969
+static int check_rpc_pipefs(struct vfsmount *mnt, void *arg)
+{
+ struct vfsmount **rpcmount = arg;
+ struct path path = {
+ .mnt = mnt,
+ .dentry = mnt->mnt_root,
+ };
+
+ if (!mnt->mnt_sb)
+ return 0;
+ if (mnt->mnt_sb->s_magic != RPCAUTH_GSSMAGIC)
+ return 0;
+
+ if (!path_is_under(&path, ¤t->fs->root))
+ return 0;
+
+ *rpcmount = mntget(mnt);
+ return 1;
+}
+
+struct vfsmount *get_rpc_pipefs(const char *p)
+{
+ int error;
+ struct vfsmount *rpcmount = ERR_PTR(-EINVAL);
+ struct path path;
+
+ if (!p) {
+ iterate_mounts(check_rpc_pipefs, &rpcmount,
+ current->nsproxy->mnt_ns->root);
+
+ if (IS_ERR(rpcmount) && (current->nsproxy->mnt_ns ==
+ init_task.nsproxy->mnt_ns))
+ return mntget(init_rpc_pipefs);
+
+ return rpcmount;
+ }
+
+ error = kern_path(p, LOOKUP_FOLLOW | LOOKUP_DIRECTORY, &path);
+ if (error)
+ return ERR_PTR(error);
+
+ check_rpc_pipefs(path.mnt, &rpcmount);
+ path_put(&path);
+
+ return rpcmount;
+}
+EXPORT_SYMBOL_GPL(get_rpc_pipefs);
+
/*
* We have a single directory with 1 node in it.
*/
--
1.7.3.4
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox