* Re: [PATCH 5/8] niu: convert to new ethtool set_phys_id
From: David Miller @ 2011-04-06 21:36 UTC (permalink / raw)
To: shemminger; +Cc: bhutchings, netdev
In-Reply-To: <20110404153119.29c02c9c@nehalam>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 4 Apr 2011 15:31:19 -0700
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied.
^ permalink raw reply
* Re: [PATCH 4/8] s2io: convert to set_phys_id
From: David Miller @ 2011-04-06 21:36 UTC (permalink / raw)
To: shemminger; +Cc: bhutchings, jdmason, netdev
In-Reply-To: <20110404210805.593573200@linuxplumber.net>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 04 Apr 2011 14:06:38 -0700
> Convert to new ethtool set physical id model. Remove no longer used
> timer, and fix docbook comment.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied.
^ permalink raw reply
* Re: [PATCH 3/8] bnx2x: convert to set_phys_id
From: David Miller @ 2011-04-06 21:36 UTC (permalink / raw)
To: shemminger; +Cc: bhutchings, eilong, netdev
In-Reply-To: <20110404210805.493178297@linuxplumber.net>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 04 Apr 2011 14:06:37 -0700
> Also cleanup error codes to no lie about things that driver doesn't
> support. If device is down report -EAGAIN (same as Broadcom), and
> if port doesn't blink then error as well.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied.
^ permalink raw reply
* Re: [PATCH 2/8] bnx2: convert to set_phys_id
From: David Miller @ 2011-04-06 21:36 UTC (permalink / raw)
To: shemminger; +Cc: bhutchings, mchan, netdev
In-Reply-To: <20110404210805.389777981@linuxplumber.net>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 04 Apr 2011 14:06:36 -0700
> In this case, need to add element to device private to hold
> original led state.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied.
^ permalink raw reply
* Re: [PATCH 1/8] vxge: convert to set_phys_id
From: David Miller @ 2011-04-06 21:36 UTC (permalink / raw)
To: shemminger; +Cc: bhutchings, jdmason, netdev
In-Reply-To: <20110404210805.288930078@linuxplumber.net>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 04 Apr 2011 14:06:35 -0700
> Also fix up incorrect docbook comment
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next-2.6 11/12] cxgb3: implement set_phys_id
From: David Miller @ 2011-04-06 21:32 UTC (permalink / raw)
To: shemminger; +Cc: bhutchings, divy, netdev
In-Reply-To: <20110404184502.288358458@linuxplumber.net>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 04 Apr 2011 11:43:51 -0700
> Implement new ethtool set_phys_id on Chelsio cxgb3 board.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next-2.6 12/12] qlcnic: convert to set_phys_id
From: David Miller @ 2011-04-06 21:32 UTC (permalink / raw)
To: shemminger; +Cc: bhutchings, amit.salecha, anirban.chakraborty, netdev
In-Reply-To: <20110404184502.382340801@linuxplumber.net>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 04 Apr 2011 11:43:52 -0700
> Convert driver to use new ethtool set_phys_id.
> Not completely sure that this is correct for all cases of device
> up/down and doing operation. Compile tested only.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Please address the feedback given by qlcnic developers.
Thanks.
^ permalink raw reply
* Re: [PATCH net-next-2.6 10/12] tg3: implement ethtool set_phys_id
From: David Miller @ 2011-04-06 21:32 UTC (permalink / raw)
To: shemminger; +Cc: bhutchings, mcarlson, mchan, netdev
In-Reply-To: <20110404184502.194825403@linuxplumber.net>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 04 Apr 2011 11:43:50 -0700
> Implement control of LED via set_phys_id.
> Note: since PHY is powered off if device is down, this board
> only allows blinking if device is up.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next-2.6 09/12] ixgb: convert to set_phys_id
From: David Miller @ 2011-04-06 21:32 UTC (permalink / raw)
To: shemminger
Cc: bhutchings, jeffrey.t.kirsher, jesse.brandeburg, bruce.w.allan,
carolyn.wyborny, donald.c.skidmore, john.ronciak, netdev
In-Reply-To: <20110404184502.102613916@linuxplumber.net>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 04 Apr 2011 11:43:49 -0700
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Deferred to Intel driver maintainers.
^ permalink raw reply
* Re: [PATCH net-next-2.6 08/12] ixgbe: convert to ethtool set_phys_id
From: David Miller @ 2011-04-06 21:32 UTC (permalink / raw)
To: shemminger
Cc: bhutchings, jeffrey.t.kirsher, jesse.brandeburg, bruce.w.allan,
carolyn.wyborny, donald.c.skidmore, john.ronciak, netdev
In-Reply-To: <20110404184502.007626879@linuxplumber.net>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 04 Apr 2011 11:43:48 -0700
> Convert ixgbe driver to use new set_phys_id ethtool interface.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Deferred to Intel driver maintainers.
^ permalink raw reply
* Re: [PATCH net-next-2.6 07/12] igbvf: remove bogus phys_id
From: David Miller @ 2011-04-06 21:31 UTC (permalink / raw)
To: shemminger
Cc: bhutchings, jeffrey.t.kirsher, jesse.brandeburg, bruce.w.allan,
carolyn.wyborny, donald.c.skidmore, john.ronciak, netdev
In-Reply-To: <20110404184501.915865252@linuxplumber.net>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 04 Apr 2011 11:43:47 -0700
> This device lies about supporting phys_id. Remove it and just
> let the upper layer report not supported.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Deferred to Intel driver maintainers.
^ permalink raw reply
* Re: [PATCH net-next-2.6 06/12] igb: convert to ethtool set_phys_id
From: David Miller @ 2011-04-06 21:31 UTC (permalink / raw)
To: shemminger
Cc: bhutchings, jeffrey.t.kirsher, jesse.brandeburg, bruce.w.allan,
carolyn.wyborny, donald.c.skidmore, john.ronciak, netdev
In-Reply-To: <20110404184501.824549872@linuxplumber.net>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 04 Apr 2011 11:43:46 -0700
> Convert igb driver to use new set_phys_id ethtool interface.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Deferred to Intel driver maintainers.
^ permalink raw reply
* Re: [PATCH net-next-2.6 05/12] e1000e: implement ethtool set_phys_id
From: David Miller @ 2011-04-06 21:31 UTC (permalink / raw)
To: shemminger
Cc: bhutchings, jeffrey.t.kirsher, jesse.brandeburg, bruce.w.allan,
carolyn.wyborny, donald.c.skidmore, john.ronciak, netdev
In-Reply-To: <20110404184501.732239902@linuxplumber.net>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 04 Apr 2011 11:43:45 -0700
> The new ethtool set_phys_id takes over controlling the LED for identifying
> boards. This fixes the lockout during that period.
> For this device lots of extra infrastructure can also be removed by using
> set_phys_id.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Deferred to Intel driver maintainers.
^ permalink raw reply
* Re: [PATCH net-next-2.6 04/12] e1000: convert to set_phys_id
From: David Miller @ 2011-04-06 21:31 UTC (permalink / raw)
To: shemminger
Cc: bhutchings, jeffrey.t.kirsher, jesse.brandeburg, bruce.w.allan,
carolyn.wyborny, donald.c.skidmore, john.ronciak, netdev
In-Reply-To: <20110404184501.640779086@linuxplumber.net>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 04 Apr 2011 11:43:44 -0700
> Convert to new LED control infrastucture and remove no longer
> necessary bits.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Deferred to Intel driver maintainers.
^ permalink raw reply
* Re: [PATCH net-next-2.6 03/12] e100: implemenet set_phys_id
From: David Miller @ 2011-04-06 21:31 UTC (permalink / raw)
To: shemminger
Cc: bhutchings, jeffrey.t.kirsher, jesse.brandeburg, bruce.w.allan,
carolyn.wyborny, donald.c.skidmore, john.ronciak, netdev
In-Reply-To: <20110404184501.541503577@linuxplumber.net>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 04 Apr 2011 11:43:43 -0700
> Implement set_phys_id to control LED.
> Compile tested only.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Deferred to Intel driver maintainers.
^ permalink raw reply
* Re: [PATCH net-next-2.6 02/12] skge: implement set_phys_id
From: David Miller @ 2011-04-06 21:30 UTC (permalink / raw)
To: shemminger; +Cc: bhutchings, netdev
In-Reply-To: <20110404184501.450494215@linuxplumber.net>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 04 Apr 2011 11:43:42 -0700
> Implement set_phys_id led control on SysKonnect board.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied, although I had to fix:
> + case ETHTOOL_ID_ACTIVE:
> + return -1;
to return -EINVAL.
^ permalink raw reply
* Re: [PATCH net-next-2.6 01/12] sky2: support ethtool set_phys_id
From: David Miller @ 2011-04-06 21:30 UTC (permalink / raw)
To: shemminger; +Cc: bhutchings, netdev
In-Reply-To: <20110404184501.356412753@linuxplumber.net>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 04 Apr 2011 11:43:41 -0700
> Use ethtool set_phys_id to control LED. Fixes issues with RTNL being
> held for extended periods.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied.
^ permalink raw reply
* Re: NETIF_F_TSO vs NETIF_F_TSO{6,_ECN}
From: David Miller @ 2011-04-06 21:22 UTC (permalink / raw)
To: bhutchings; +Cc: mirq-linux, netdev, herbert
In-Reply-To: <1302028298.2932.76.camel@bwh-desktop>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Tue, 05 Apr 2011 19:31:38 +0100
> *sigh* So it seems the commit message was wrong... and it should have
> included a change like this:
This seems correct, can you formally submit this fix?
Thanks.
^ permalink raw reply
* Re: 2.6.39-rc2 boot crash
From: David Miller @ 2011-04-06 21:21 UTC (permalink / raw)
To: emunson; +Cc: dave, linux-kernel, kaber, zbr, gregkh, ksrinivasan, netdev
In-Reply-To: <20110406212041.GA2596@mgebm.net>
From: Eric B Munson <emunson@mgebm.net>
Date: Wed, 6 Apr 2011 17:20:41 -0400
> A bisect points at commit 04f482faf50535229a5a5c8d629cf963899f857c for the
> first bad one. Unfortunately, I have not made netconsole work yet and the
> hang is happening mostly right when X starts so I can't even see the console.
> I will keep at the netconsole and see if I can get it functioning, also I will
> try to boot this kernel in a VM and see if that helps.
Patrick, please help Eric so we can fix this bug.
Thanks.
^ permalink raw reply
* Re: 2.6.39-rc2 boot crash
From: Eric B Munson @ 2011-04-06 21:20 UTC (permalink / raw)
To: Dave Hansen; +Cc: linux-kernel, kaber, zbr, davem, gregkh, ksrinivasan, netdev
In-Reply-To: <1302115953.8094.217.camel@nimitz>
[-- Attachment #1: Type: text/plain, Size: 1466 bytes --]
On Wed, 06 Apr 2011, Dave Hansen wrote:
> On Wed, 2011-04-06 at 14:47 -0400, Eric B Munson wrote:
> > I am seeing a boot crash on my machine with 2.6.39-rc2. I don't yet have
> > netconsole setup and I don't have serial so the best I can do at the moment
> > is a couple of pictures of the stack trace.
> >
> > http://tinypic.com/r/2zsr19i/7
> >
> > And
> >
> > http://tinypic.com/r/2iw22dj/7
> >
> > I will try and get a net console working for better output, is there
> > anything else that would help?
>
> This:
>
> > boot_delay= Milliseconds to delay each printk during boot.
> > Values larger than 10 seconds (10000) are changed to
> > no delay (0).
> > Format: integer
>
> sometimes gives you enough time to get something out of the system. You
> might also want to try and boot the same kernel in a VM. It might just
> be a weird configuration issue, or maybe even a lockdep bug. If it's
> not hardware related, booting in a VM should help a lot.
>
> -- Dave
>
A bisect points at commit 04f482faf50535229a5a5c8d629cf963899f857c for the
first bad one. Unfortunately, I have not made netconsole work yet and the
hang is happening mostly right when X starts so I can't even see the console.
I will keep at the netconsole and see if I can get it functioning, also I will
try to boot this kernel in a VM and see if that helps.
Eric
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply
* Re: fedora 14 kernel performance with ip forwarding workload
From: Eric Dumazet @ 2011-04-06 21:11 UTC (permalink / raw)
To: Brandeburg, Jesse
Cc: David Miller, acme@ghostprotocols.net, jesse.brandeburg@gmail.com,
fedora-kernel-list@redhat.com, netdev@vger.kernel.org
In-Reply-To: <alpine.WNT.2.00.1104061400320.6556@JBRANDEB-DESK2.amr.corp.intel.com>
Le mercredi 06 avril 2011 à 14:08 -0700, Brandeburg, Jesse a écrit :
> Thanks for the replies,
> Yes indeed, I bet that conntrack was the item that caused the grief I saw.
> In fact turning off CONFIG_NETFILTER disables conntrack and solved my
> problem. :-)
>
> Now the question is how to get the netfiltery/conntracky goodness without
> impacting those who want to go fast, maybe without a helmet.
Thats pretty simple, just load netfilter modules if necessary.
If not loaded, cost is pretty small, being predicted branches.
^ permalink raw reply
* Re: fedora 14 kernel performance with ip forwarding workload
From: Brandeburg, Jesse @ 2011-04-06 21:08 UTC (permalink / raw)
To: Eric Dumazet
Cc: David Miller, acme@ghostprotocols.net, jesse.brandeburg@gmail.com,
fedora-kernel-list@redhat.com, netdev@vger.kernel.org
In-Reply-To: <1302121945.2701.31.camel@edumazet-laptop>
On Wed, 6 Apr 2011, Eric Dumazet wrote:
> Le mercredi 06 avril 2011 à 13:29 -0700, David Miller a écrit :
> > From: Eric Dumazet <eric.dumazet@gmail.com>
> > Date: Wed, 06 Apr 2011 22:18:56 +0200
> >
> > > I remember last time I work on a fedora kernel, it had conntrack enabled
> > >
> > > And yes, conntrack can really slowdown a router, because of default
> > > parameters.
> >
> > Yes, if conntrack is enabled performance will indeed tank.
>
> I just check on latest fedora14 (yum updated) :
>
> - conntrack is statically included in kernel, you cannot remove it.
>
>
> Hmm...
Thanks for the replies,
Yes indeed, I bet that conntrack was the item that caused the grief I saw.
In fact turning off CONFIG_NETFILTER disables conntrack and solved my
problem. :-)
Now the question is how to get the netfiltery/conntracky goodness without
impacting those who want to go fast, maybe without a helmet.
^ permalink raw reply
* Re: pull request: wireless-2.6 2011-04-06
From: David Miller @ 2011-04-06 21:05 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, netdev, linux-kernel
In-Reply-To: <20110406200032.GK11941@tuxdriver.com>
From: "John W. Linville" <linville@tuxdriver.com>
Date: Wed, 6 Apr 2011 16:00:33 -0400
> Here is another batch of fixes intended for 2.6.39...
>
> This includes a fix to avoid receiving duplicate frames in "cooked"
> monitor mode, a mac80211 documentation fix to avoid developer
> confusion, an rt2x00 fix to avoid cancelling some uninitialized work,
> a wl12xx buffer overflow fix, an email address correction for wl12xx
> module info, a zd1211rw regression fix, a zd1211rw WARNING fix,
> and rtlwifi fix to avoid using some uninitialized variables, a fix
> to broaden the iwl600 hardware supported by iwlagn to match what the
> Windows driver is supporting, a b43 fix to allocate properly sized
> receive buffers, and some stuff related to device IDs.
>
> Please let me know if there are problems!
Pulled, thanks John.
^ permalink raw reply
* Re: [PATCH] pppoe: drop PPPOX_ZOMBIEs in pppoe_flush_dev
From: David Miller @ 2011-04-06 21:05 UTC (permalink / raw)
To: uweber; +Cc: netdev
In-Reply-To: <20110404123324.GA12662@babylon>
From: Ulrich Weber <uweber@astaro.com>
Date: Mon, 4 Apr 2011 14:33:24 +0200
> otherwise we loop forever if a PPPoE socket was set
> to PPPOX_ZOMBIE state by a PADT message when the
> ethernet device is going down afterwards.
>
> Signed-off-by: Ulrich Weber <uweber@astaro.com>
Applied, thanks Ulrich.
^ permalink raw reply
* RE: mdiobus_register() issue for an SMSC8720a PHY
From: ANDY KENNEDY @ 2011-04-06 21:03 UTC (permalink / raw)
To: netdev
In-Reply-To: <9AC3F0E75060224C8BBC5BA2DDC8853A1FA0C0C6@EXV1.corp.adtran.com>
> ====== get_device_parent:689
> dev = 0x8781da40
> dev->class = 0x803c2ad4
> dev->class->p = 0x00000000
> dev->class->p->class_dirs = 0x00000048
Ughh. I deleted a line of text from the e-mail I sent. I found my
problem. The line of text that would have given all of you the answer
quickly was this:
The below code is from arch/mips/<myboard>/platform.c.
Perhaps this is vague, so I'll clarify. I start this process from the
board level configuration, therefore the mdio class (which gets created
in the init of mdiobus) isn't -- thus class->p is empty.
So, now I just need to relocate this code to some "real" network driver,
I guess.
Andy
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox